Re: Review Request 125056: Fix build on OS X

2015-11-07 Thread Samuel Gaist 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125056/
---

(Updated Nov. 7, 2015, 11:39 p.m.)


Status
--

This change has been marked as submitted.


Review request for kde-workspace, Jonathan Riddell and Valentin Rusu.


Repository: kwallet-pam


Description
---

Added implementation of pam_syslog and pam_vsyslog for OS X

Added include dir setup to FindLibGcrypt

add reviewboardrc


Diffs
-

  .reviewboardrc PRE-CREATION 
  CMakeLists.txt bfdcfda71ef5ba3b5e4247afe02af1c23d064783 
  cmake/modules/FindLibGcrypt.cmake 27de0b46a82e92a24734476ea32401bef01a8ca8 
  pam_darwin.h PRE-CREATION 
  pam_darwin.c PRE-CREATION 
  pam_kwallet.c a84585ef1fc3f4aeac728e707d52479ec85b5300 

Diff: https://git.reviewboard.kde.org/r/125056/diff/


Testing
---

Build on OS X 10.8


Thanks,

Samuel Gaist

Re: Review Request 125056: Fix build on OS X

2015-11-06 Thread Valentin Rusu 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125056/#review88111
---

Ship it!


Ship It!

- Valentin Rusu


On Oct. 26, 2015, 2:20 p.m., Samuel Gaist wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125056/
> ---
> 
> (Updated Oct. 26, 2015, 2:20 p.m.)
> 
> 
> Review request for kde-workspace, Jonathan Riddell and Valentin Rusu.
> 
> 
> Repository: kwallet-pam
> 
> 
> Description
> ---
> 
> Added implementation of pam_syslog and pam_vsyslog for OS X
> 
> Added include dir setup to FindLibGcrypt
> 
> add reviewboardrc
> 
> 
> Diffs
> -
> 
>   .reviewboardrc PRE-CREATION 
>   CMakeLists.txt bfdcfda71ef5ba3b5e4247afe02af1c23d064783 
>   cmake/modules/FindLibGcrypt.cmake 27de0b46a82e92a24734476ea32401bef01a8ca8 
>   pam_darwin.h PRE-CREATION 
>   pam_darwin.c PRE-CREATION 
>   pam_kwallet.c a84585ef1fc3f4aeac728e707d52479ec85b5300 
> 
> Diff: https://git.reviewboard.kde.org/r/125056/diff/
> 
> 
> Testing
> ---
> 
> Build on OS X 10.8
> 
> 
> Thanks,
> 
> Samuel Gaist
> 
>

Re: Review Request 125056: Fix build on OS X

2015-09-05 Thread Samuel Gaist 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125056/
---

(Updated Sept. 5, 2015, 8:02 p.m.)


Review request for kde-workspace and Jonathan Riddell.


Repository: kwallet-pam


Description (updated)
---

Added implementation of pam_syslog and pam_vsyslog for OS X

Added include dir setup to FindLibGcrypt

add reviewboardrc


Diffs
-

  .reviewboardrc PRE-CREATION 
  CMakeLists.txt bfdcfda71ef5ba3b5e4247afe02af1c23d064783 
  cmake/modules/FindLibGcrypt.cmake 27de0b46a82e92a24734476ea32401bef01a8ca8 
  pam_darwin.h PRE-CREATION 
  pam_darwin.c PRE-CREATION 
  pam_kwallet.c a84585ef1fc3f4aeac728e707d52479ec85b5300 

Diff: https://git.reviewboard.kde.org/r/125056/diff/


Testing
---

Build on OS X 10.8


Thanks,

Samuel Gaist

Re: Review Request 125056: Fix build on OS X

2015-09-05 Thread Samuel Gaist 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125056/
---

(Updated Sept. 5, 2015, 8:01 p.m.)


Review request for kde-workspace and Jonathan Riddell.


Repository: kwallet-pam


Description
---

Added implementation of pam_syslog and pam_vsyslog for OS X


add reviewboardrc


Diffs (updated)
-

  .reviewboardrc PRE-CREATION 
  CMakeLists.txt bfdcfda71ef5ba3b5e4247afe02af1c23d064783 
  cmake/modules/FindLibGcrypt.cmake 27de0b46a82e92a24734476ea32401bef01a8ca8 
  pam_darwin.h PRE-CREATION 
  pam_darwin.c PRE-CREATION 
  pam_kwallet.c a84585ef1fc3f4aeac728e707d52479ec85b5300 

Diff: https://git.reviewboard.kde.org/r/125056/diff/


Testing
---

Build on OS X 10.8


Thanks,

Samuel Gaist

Re: Review Request 125056: Fix build on OS X

2015-09-05 Thread Samuel Gaist 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125056/
---

(Updated Sept. 5, 2015, 7:47 p.m.)


Review request for kde-workspace and Jonathan Riddell.


Repository: kwallet-pam


Description (updated)
---

Added implementation of pam_syslog and pam_vsyslog for OS X


add reviewboardrc


Diffs (updated)
-

  .reviewboardrc PRE-CREATION 
  CMakeLists.txt bfdcfda71ef5ba3b5e4247afe02af1c23d064783 
  pam_darwin.h PRE-CREATION 
  pam_darwin.c PRE-CREATION 
  pam_kwallet.c a84585ef1fc3f4aeac728e707d52479ec85b5300 

Diff: https://git.reviewboard.kde.org/r/125056/diff/


Testing
---

Build on OS X 10.8


Thanks,

Samuel Gaist

Re: Review Request 125056: Fix build on OS X

2015-09-05 Thread Martin Klapetek 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125056/#review84880
---


Looks good to me


CMakeLists.txt (line 45)


This change is already preceeded with 
https://git.reviewboard.kde.org/r/124962/


- Martin Klapetek


On Sept. 5, 2015, 1:47 a.m., Samuel Gaist wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125056/
> ---
> 
> (Updated Sept. 5, 2015, 1:47 a.m.)
> 
> 
> Review request for kde-workspace and Jonathan Riddell.
> 
> 
> Repository: kwallet-pam
> 
> 
> Description
> ---
> 
> Add include dir setup to gcrypt find cmake module
> 
> Added implementation of pam_syslog and pam_vsyslog for OS X
> 
> 
> add reviewboardrc
> 
> 
> Diffs
> -
> 
>   .reviewboardrc PRE-CREATION 
>   CMakeLists.txt f60ac4121c793d62a7471074c1d4ea687360557c 
>   cmake/modules/FindLibGcrypt.cmake 27de0b46a82e92a24734476ea32401bef01a8ca8 
>   pam_darwin.h PRE-CREATION 
>   pam_darwin.c PRE-CREATION 
>   pam_kwallet.c a84585ef1fc3f4aeac728e707d52479ec85b5300 
> 
> Diff: https://git.reviewboard.kde.org/r/125056/diff/
> 
> 
> Testing
> ---
> 
> Build on OS X 10.8
> 
> 
> Thanks,
> 
> Samuel Gaist
> 
>