Re: X11 expert help needed
Am Fri, 29 Jul 2011 21:54:38 +0200 schrieb Alexander Neundorf : > From these three, only Xkbfile is a separate library ? > For the other two only for headers is checked. > > Do you know what the exact purpose of XSync and xkbfile is (not only > for KDE) ? XSync() is similar to XFlush() and locks until all calls to the server have been processed... !! --> BUT this is NOT extensions/sync.h, what's checked for HAVE_XSYNC - this implements some sort of mutex protocol across X11 clients. afaics it's currently only used (by kwin) to schedule window resizes until the client is internally done with the resize (relayouting and stuff - iff supported) xkbfile sounds and looks alot like support for parsing the xkbd files (keyboard layouts, "setxkbmap") - but i'm not really sure. > What is Xi ? extensions/XI.h ? - X input extension, general input handling stuff XI2 is the current version - should be low level stuff and is _maybe_ required by kglobalaccel > > > I think it would make sense to update the KDE's one. > > In the KDE version additionally Xau, Xdmcl, Xpm and Xft are added xpm is the xpixmap format (im/export i assume, it should not required to use Pixmap drawables but eg. for cursors or so, i think...) xft are fonts, not really required since there's fontconfig but you may loose support for server only fonts. xdmc_p_ (no idea about _l_, typo?) & libXau should somehow be related to the desktop manager (KDM in our case) -> ask Ossi ;-) (but i don't think they're required for each and every application) Cheers, Thomas
Re: X11 expert help needed
Hi Martin, thanks for having a look :-) But I still have questions... On Thursday 28 July 2011, Martin Gräßlin wrote: > On Monday 18 July 2011 22:43:20 Alexander Neundorf wrote: > > Hi, > > > > I'm currently comparing our FindX11.cmake with the one in current cmake. > > Our copy is in kdelibs/cmake/modules/, CMake's is in its Module/ > > directory. > > > > There are some things our version checks for, which the one from cmake > > doesn't, and vice versa. > > Also, we append more of the libs to the X11_LIBRARIES variable. > > > > Is this good ? > > Should the stuff we do just be merged into the cmake version ? > > Can somebody who knows more about X11 please have a look at these two > > files, one in kdelibs, the other one in cmake 2.8.5 or git HEAD ? > > http://cmake.org/gitweb?p=cmake.git;a=summary > > > > Helping hands are very appreciated :-) > > I just had a look at the diff. As far as I have seen the KDE version > includes checks for > * XSync > * Xkbfile > * SM From these three, only Xkbfile is a separate library ? For the other two only for headers is checked. Do you know what the exact purpose of XSync and xkbfile is (not only for KDE) ? > For XSync I can find a > #ifdef HAVE_XSYNC > in kde-workspace/kwin/client.cpp No idea if it is really required, but at > least it's used. Though I cannot find a check in either the toplevel or > kwin's CMakeLists.txt. > > Xkbfile is used by the keyboard KCM and is checked in kde-workspace > CMakeLists.txt if(NOT X11_Xkbfile_FOUND) > macro_log_feature(X11_Xkbfile_FOUND "libXkbfile" "X11 keyboard layout > library" "http://xorg.freedesktop.org"; TRUE "" "Needed for keyboard > modules.") endif(NOT X11_Xkbfile_FOUND) > > SM sounds like it would be needed by ksmserver. But at least in the > CMakeLists.txt I could not find a usage. > > Maybe an idea would be to git blame the file and contact the devs why they > added the checks. > > In the other direction it seems like only Xi is in CMake version which is > missing in KDE's. What is Xi ? > I think it would make sense to update the KDE's one. In the KDE version additionally Xau, Xdmcl, Xpm and Xft are added automatically to X11_LIBRARIES. This means whoever uses X11_LIBRARIES, also links against those libraries. I don't know how much of a problem this is, but if it is not really necessary, I'd prefer not to merge this part (where X11_LIBRARIES is set) to cmake. What do you think ? Alex
Re: X11 expert help needed
On Monday 18 July 2011 22:43:20 Alexander Neundorf wrote: > Hi, > > I'm currently comparing our FindX11.cmake with the one in current cmake. > Our copy is in kdelibs/cmake/modules/, CMake's is in its Module/ directory. > > There are some things our version checks for, which the one from cmake > doesn't, and vice versa. > Also, we append more of the libs to the X11_LIBRARIES variable. > > Is this good ? > Should the stuff we do just be merged into the cmake version ? > Can somebody who knows more about X11 please have a look at these two files, > one in kdelibs, the other one in cmake 2.8.5 or git HEAD ? > http://cmake.org/gitweb?p=cmake.git;a=summary > > Helping hands are very appreciated :-) I just had a look at the diff. As far as I have seen the KDE version includes checks for * XSync * Xkbfile * SM For XSync I can find a #ifdef HAVE_XSYNC in kde-workspace/kwin/client.cpp No idea if it is really required, but at least it's used. Though I cannot find a check in either the toplevel or kwin's CMakeLists.txt. Xkbfile is used by the keyboard KCM and is checked in kde-workspace CMakeLists.txt if(NOT X11_Xkbfile_FOUND) macro_log_feature(X11_Xkbfile_FOUND "libXkbfile" "X11 keyboard layout library" "http://xorg.freedesktop.org"; TRUE "" "Needed for keyboard modules.") endif(NOT X11_Xkbfile_FOUND) SM sounds like it would be needed by ksmserver. But at least in the CMakeLists.txt I could not find a usage. Maybe an idea would be to git blame the file and contact the devs why they added the checks. In the other direction it seems like only Xi is in CMake version which is missing in KDE's. I think it would make sense to update the KDE's one. Cheers Martin signature.asc Description: This is a digitally signed message part.
Re: X11 expert help needed
On Tuesday 26 July 2011, Ruurd Pels wrote: > On Tuesday 26 July 2011 22.43.33 Alexander Neundorf wrote: > > > Should the stuff we do just be merged into the cmake version ? > > > Can somebody who knows more about X11 please have a look at these two > > > files, one in kdelibs, the other one in cmake 2.8.5 or git HEAD ? > > > http://cmake.org/gitweb?p=cmake.git;a=summary > > What happens if you use de cmake version (copy over kde version then try a > cmake... How much extra does de KDE version do and is it possible to do > that in a sort of X11ExtraCheck cmake? No need to copy and try... a diff shows the differences. It's checking for a few things more here and there. I could simply add that to the cmake version. But since I actually don't really know what these libs are for, whether they are always there or only in some versions or on some OSs, or whatever, I'd like to get some expert input on that. Alex
Re: X11 expert help needed
On Tuesday 26 July 2011 22.43.33 Alexander Neundorf wrote: > > Should the stuff we do just be merged into the cmake version ? > > Can somebody who knows more about X11 please have a look at these two > > files, one in kdelibs, the other one in cmake 2.8.5 or git HEAD ? > > http://cmake.org/gitweb?p=cmake.git;a=summary What happens if you use de cmake version (copy over kde version then try a cmake... How much extra does de KDE version do and is it possible to do that in a sort of X11ExtraCheck cmake? R
Re: X11 expert help needed
On Monday 18 July 2011, Alexander Neundorf wrote: > Hi, > > I'm currently comparing our FindX11.cmake with the one in current cmake. > Our copy is in kdelibs/cmake/modules/, CMake's is in its Module/ directory. > > There are some things our version checks for, which the one from cmake > doesn't, and vice versa. > Also, we append more of the libs to the X11_LIBRARIES variable. > > Is this good ? > Should the stuff we do just be merged into the cmake version ? > Can somebody who knows more about X11 please have a look at these two > files, one in kdelibs, the other one in cmake 2.8.5 or git HEAD ? > http://cmake.org/gitweb?p=cmake.git;a=summary > > Helping hands are very appreciated :-) > Alex Anybody ? Alex
