Review Request: Do not patch strings that can be combined.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104712/ --- Review request for KDE Base Apps. Description --- The way it is now, it created two strings, one of which does not hold anything to translate (just markup). This change merges them to one string with a placeholder which enables the translator to see the whole picture. Diffs - konqueror/settings/konqhtml/css/kcmcss.cpp b4e5146 Diff: http://git.reviewboard.kde.org/r/104712/diff/ Testing --- Thanks, Frederik Schwarzer
Re: Review Request: Do not patch strings that can be combined.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104712/#review12884 --- Ship it! Ship It! - Dawit Alemayehu On April 24, 2012, 5:01 p.m., Frederik Schwarzer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104712/ > --- > > (Updated April 24, 2012, 5:01 p.m.) > > > Review request for KDE Base Apps. > > > Description > --- > > The way it is now, it created two strings, one of which does not hold > anything to translate (just markup). This change merges them to one string > with a placeholder which enables the translator to see the whole picture. > > > Diffs > - > > konqueror/settings/konqhtml/css/kcmcss.cpp b4e5146 > > Diff: http://git.reviewboard.kde.org/r/104712/diff/ > > > Testing > --- > > > Thanks, > > Frederik Schwarzer > >
Re: Review Request: Do not patch strings that can be combined.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104712/#review12889 --- This review has been submitted with commit a35a6c8bc56028f704d547a82cf175c7d481fd90 by Frederik Schwarzer to branch master. - Commit Hook On April 24, 2012, 5:01 p.m., Frederik Schwarzer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104712/ > --- > > (Updated April 24, 2012, 5:01 p.m.) > > > Review request for KDE Base Apps. > > > Description > --- > > The way it is now, it created two strings, one of which does not hold > anything to translate (just markup). This change merges them to one string > with a placeholder which enables the translator to see the whole picture. > > > Diffs > - > > konqueror/settings/konqhtml/css/kcmcss.cpp b4e5146 > > Diff: http://git.reviewboard.kde.org/r/104712/diff/ > > > Testing > --- > > > Thanks, > > Frederik Schwarzer > >
