Re: Review Request: Fix Date Display in dolphin info panel

2011-12-02 Thread Commit Hook 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103300/#review8663
---


This review has been submitted with commit 
21c198a312abcdf3bad0bc72c02f175f32b439b5 by Weng Xuetian to branch frameworks.

- Commit Hook


On Nov. 30, 2011, 9:17 p.m., Xuetian Weng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103300/
> ---
> 
> (Updated Nov. 30, 2011, 9:17 p.m.)
> 
> 
> Review request for kdelibs and Nepomuk.
> 
> 
> Description
> ---
> 
> The date in dolphin info panel is passed by kfilemetadatareader directly. So 
> all the localization work should be done at the kfilemetadatareader side.
> There are two problems.
> 1. date given by nepomuk is stored as UTC time, needed to convert to 
> localtime.
> 2. date localization will not work without a KComponentData.
> 
> 
> Diffs
> -
> 
>   nepomuk/utils/utils.cpp e81615a 
>   kio/kfile/kfilemetadatareaderprocess.cpp 03ff887 
> 
> Diff: http://git.reviewboard.kde.org/r/103300/diff/diff
> 
> 
> Testing
> ---
> 
> Works for me.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

Re: Review Request: Fix Date Display in dolphin info panel

2011-12-01 Thread Commit Hook 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103300/#review8645
---


This review has been submitted with commit 
df90e1f8d34551666dfb680e985842daedf51b5f by Weng Xuetian to branch KDE/4.7.

- Commit Hook


On Nov. 30, 2011, 9:17 p.m., Xuetian Weng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103300/
> ---
> 
> (Updated Nov. 30, 2011, 9:17 p.m.)
> 
> 
> Review request for kdelibs and Nepomuk.
> 
> 
> Description
> ---
> 
> The date in dolphin info panel is passed by kfilemetadatareader directly. So 
> all the localization work should be done at the kfilemetadatareader side.
> There are two problems.
> 1. date given by nepomuk is stored as UTC time, needed to convert to 
> localtime.
> 2. date localization will not work without a KComponentData.
> 
> 
> Diffs
> -
> 
>   nepomuk/utils/utils.cpp e81615a 
>   kio/kfile/kfilemetadatareaderprocess.cpp 03ff887 
> 
> Diff: http://git.reviewboard.kde.org/r/103300/diff/diff
> 
> 
> Testing
> ---
> 
> Works for me.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

Re: Review Request: Fix Date Display in dolphin info panel

2011-12-01 Thread Rolf Eike Beer 
>> On Dec. 1, 2011, 8:40 a.m., Sebastian Trueg wrote:
>> > Ship It!
>
> Seems I can't commit to kdelibs, could you commit this? Thank you.

If you have a developer account you can commit there. Maybe you just tried
to commit to the locked master branch? Try committing to KDE/4.7.

Eike

Re: Review Request: Fix Date Display in dolphin info panel

2011-12-01 Thread Xuetian Weng 


> On Dec. 1, 2011, 8:40 a.m., Sebastian Trueg wrote:
> > Ship It!

Seems I can't commit to kdelibs, could you commit this? Thank you.


- Xuetian


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103300/#review8638
---


On Nov. 30, 2011, 9:17 p.m., Xuetian Weng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103300/
> ---
> 
> (Updated Nov. 30, 2011, 9:17 p.m.)
> 
> 
> Review request for kdelibs and Nepomuk.
> 
> 
> Description
> ---
> 
> The date in dolphin info panel is passed by kfilemetadatareader directly. So 
> all the localization work should be done at the kfilemetadatareader side.
> There are two problems.
> 1. date given by nepomuk is stored as UTC time, needed to convert to 
> localtime.
> 2. date localization will not work without a KComponentData.
> 
> 
> Diffs
> -
> 
>   nepomuk/utils/utils.cpp e81615a 
>   kio/kfile/kfilemetadatareaderprocess.cpp 03ff887 
> 
> Diff: http://git.reviewboard.kde.org/r/103300/diff/diff
> 
> 
> Testing
> ---
> 
> Works for me.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

Re: Review Request: Fix Date Display in dolphin info panel

2011-12-01 Thread Xuetian Weng 


> On Nov. 30, 2011, 9:30 p.m., Sebastian Trueg wrote:
> > kio/kfile/kfilemetadatareaderprocess.cpp, line 170
> > 
> >
> > Why do you need to load the kio4 catalog?

Emm.. I'm not very sure for this part, but localization will not work without 
an active catalog.
And for this file, its translation is extracted to kio4.pot (you can check 
kio/Messages.sh) , so I think kio4 is the suitable one.


- Xuetian


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103300/#review8628
---


On Nov. 30, 2011, 9:17 p.m., Xuetian Weng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103300/
> ---
> 
> (Updated Nov. 30, 2011, 9:17 p.m.)
> 
> 
> Review request for kdelibs and Nepomuk.
> 
> 
> Description
> ---
> 
> The date in dolphin info panel is passed by kfilemetadatareader directly. So 
> all the localization work should be done at the kfilemetadatareader side.
> There are two problems.
> 1. date given by nepomuk is stored as UTC time, needed to convert to 
> localtime.
> 2. date localization will not work without a KComponentData.
> 
> 
> Diffs
> -
> 
>   nepomuk/utils/utils.cpp e81615a 
>   kio/kfile/kfilemetadatareaderprocess.cpp 03ff887 
> 
> Diff: http://git.reviewboard.kde.org/r/103300/diff/diff
> 
> 
> Testing
> ---
> 
> Works for me.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

Review Request: Fix Date Display in dolphin info panel

2011-12-01 Thread Xuetian Weng 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103300/
---

Review request for kdelibs and Nepomuk.


Description
---

The date in dolphin info panel is passed by kfilemetadatareader directly. So 
all the localization work should be done at the kfilemetadatareader side.
There are two problems.
1. date given by nepomuk is stored as UTC time, needed to convert to localtime.
2. date localization will not work without a KComponentData.


Diffs
-

  nepomuk/utils/utils.cpp e81615a 
  kio/kfile/kfilemetadatareaderprocess.cpp 03ff887 

Diff: http://git.reviewboard.kde.org/r/103300/diff/diff


Testing
---

Works for me.


Thanks,

Xuetian Weng

Re: Review Request: Fix Date Display in dolphin info panel

2011-12-01 Thread Sebastian Trueg 


> On Nov. 30, 2011, 9:30 p.m., Sebastian Trueg wrote:
> > kio/kfile/kfilemetadatareaderprocess.cpp, line 170
> > 
> >
> > Why do you need to load the kio4 catalog?
> 
> Xuetian Weng wrote:
> Emm.. I'm not very sure for this part, but localization will not work 
> without an active catalog.
> And for this file, its translation is extracted to kio4.pot (you can 
> check kio/Messages.sh) , so I think kio4 is the suitable one.

OK, makes sense to me. Please push it (darn, I should have "ship it"'ed this 
last night for 4.7.4...)


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103300/#review8628
---


On Nov. 30, 2011, 9:17 p.m., Xuetian Weng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103300/
> ---
> 
> (Updated Nov. 30, 2011, 9:17 p.m.)
> 
> 
> Review request for kdelibs and Nepomuk.
> 
> 
> Description
> ---
> 
> The date in dolphin info panel is passed by kfilemetadatareader directly. So 
> all the localization work should be done at the kfilemetadatareader side.
> There are two problems.
> 1. date given by nepomuk is stored as UTC time, needed to convert to 
> localtime.
> 2. date localization will not work without a KComponentData.
> 
> 
> Diffs
> -
> 
>   nepomuk/utils/utils.cpp e81615a 
>   kio/kfile/kfilemetadatareaderprocess.cpp 03ff887 
> 
> Diff: http://git.reviewboard.kde.org/r/103300/diff/diff
> 
> 
> Testing
> ---
> 
> Works for me.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

Re: Review Request: Fix Date Display in dolphin info panel

2011-12-01 Thread Sebastian Trueg 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103300/#review8638
---

Ship it!


Ship It!

- Sebastian Trueg


On Nov. 30, 2011, 9:17 p.m., Xuetian Weng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103300/
> ---
> 
> (Updated Nov. 30, 2011, 9:17 p.m.)
> 
> 
> Review request for kdelibs and Nepomuk.
> 
> 
> Description
> ---
> 
> The date in dolphin info panel is passed by kfilemetadatareader directly. So 
> all the localization work should be done at the kfilemetadatareader side.
> There are two problems.
> 1. date given by nepomuk is stored as UTC time, needed to convert to 
> localtime.
> 2. date localization will not work without a KComponentData.
> 
> 
> Diffs
> -
> 
>   nepomuk/utils/utils.cpp e81615a 
>   kio/kfile/kfilemetadatareaderprocess.cpp 03ff887 
> 
> Diff: http://git.reviewboard.kde.org/r/103300/diff/diff
> 
> 
> Testing
> ---
> 
> Works for me.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

Re: Review Request: Fix Date Display in dolphin info panel

2011-11-30 Thread Sebastian Trueg 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103300/#review8628
---



kio/kfile/kfilemetadatareaderprocess.cpp


Why do you need to load the kio4 catalog?


- Sebastian Trueg


On Nov. 30, 2011, 9:17 p.m., Xuetian Weng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103300/
> ---
> 
> (Updated Nov. 30, 2011, 9:17 p.m.)
> 
> 
> Review request for kdelibs and Nepomuk.
> 
> 
> Description
> ---
> 
> The date in dolphin info panel is passed by kfilemetadatareader directly. So 
> all the localization work should be done at the kfilemetadatareader side.
> There are two problems.
> 1. date given by nepomuk is stored as UTC time, needed to convert to 
> localtime.
> 2. date localization will not work without a KComponentData.
> 
> 
> Diffs
> -
> 
>   nepomuk/utils/utils.cpp e81615a 
>   kio/kfile/kfilemetadatareaderprocess.cpp 03ff887 
> 
> Diff: http://git.reviewboard.kde.org/r/103300/diff/diff
> 
> 
> Testing
> ---
> 
> Works for me.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>