---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102425/#review6007
---
This review has been submitted with commit
67b93998237a09aa2166a6c9554b7e3a3aa02921 by Dawit Alemayehu to branch
frameworks.
- Commit
On Aug. 25, 2011, 3:55 a.m., Dawit Alemayehu wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102425/
---
(Updated Aug. 25, 2011, 3:55 a.m.)
Review request for kdelibs and David Faure.
Summary
---
The attached patch fixes the logic problems in
KUrlCompletionPrivate::urlCompletion that cause it to incorrectly attempt
remote directory name completions. With this patch simply entering sftp:/
or ftp:/ into a line edit that uses KUrlCompletion will not result in a
completion attempt. Additionally the new code should be much more clearer
than the previous one.
Diffs
-
kio/kio/kurlcompletion.cpp 18ea90a
Diff: http://git.reviewboard.kde.org/r/102425/diff
Testing
---
Validated with unit test and tested using Konqueror's location bar.
Thanks,
Dawit
