Re: Review Request: Fixed KHelpCenter Font Scaling (bug 243082)
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102528/#review6456 --- This review has been submitted with commit 0dca52e75fac1724ac8eacac9a4871e077889d9c by Jure Repinc to branch active-development/4.7. - Commit On Sept. 4, 2011, 10:08 a.m., Jure Repinc wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102528/ --- (Updated Sept. 4, 2011, 10:08 a.m.) Review request for KDE Runtime. Summary --- When user clicked a button to change font size the entire document was zoomed, instead of just the font size. This meant that the text would run past the right edge and user had to scroll horizontaly to read the whole line. After this patch only the font size changes. This addresses bug 243082. http://bugs.kde.org/show_bug.cgi?id=243082 Diffs - khelpcenter/mainwindow.h 6912e5a khelpcenter/mainwindow.cpp e7997b6 khelpcenter/view.h ea91128 khelpcenter/view.cpp 47b4713 Diff: http://git.reviewboard.kde.org/r/102528/diff Testing --- Clicking on the buttons to change font size now does the right thing. I changed the font size and restarted KHelpCenter and the fonsize is saved across restart. Thanks, Jure
Re: Review Request: Fixed KHelpCenter Font Scaling (bug 243082)
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102528/#review6271 --- Ship it! Tested your patch, works fine. - Burkhard On Sept. 4, 2011, 10:08 a.m., Jure Repinc wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102528/ --- (Updated Sept. 4, 2011, 10:08 a.m.) Review request for KDE Runtime. Summary --- When user clicked a button to change font size the entire document was zoomed, instead of just the font size. This meant that the text would run past the right edge and user had to scroll horizontaly to read the whole line. After this patch only the font size changes. This addresses bug 243082. http://bugs.kde.org/show_bug.cgi?id=243082 Diffs - khelpcenter/mainwindow.h 6912e5a khelpcenter/mainwindow.cpp e7997b6 khelpcenter/view.h ea91128 khelpcenter/view.cpp 47b4713 Diff: http://git.reviewboard.kde.org/r/102528/diff Testing --- Clicking on the buttons to change font size now does the right thing. I changed the font size and restarted KHelpCenter and the fonsize is saved across restart. Thanks, Jure
Re: Review Request: Fixed KHelpCenter Font Scaling (bug 243082)
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102528/#review6276 --- This review has been submitted with commit 8a7e1ae648b209d358b8891f9abb4922256b5150 by Jure Repinc to branch KDE/4.7. - Commit On Sept. 4, 2011, 10:08 a.m., Jure Repinc wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102528/ --- (Updated Sept. 4, 2011, 10:08 a.m.) Review request for KDE Runtime. Summary --- When user clicked a button to change font size the entire document was zoomed, instead of just the font size. This meant that the text would run past the right edge and user had to scroll horizontaly to read the whole line. After this patch only the font size changes. This addresses bug 243082. http://bugs.kde.org/show_bug.cgi?id=243082 Diffs - khelpcenter/mainwindow.h 6912e5a khelpcenter/mainwindow.cpp e7997b6 khelpcenter/view.h ea91128 khelpcenter/view.cpp 47b4713 Diff: http://git.reviewboard.kde.org/r/102528/diff Testing --- Clicking on the buttons to change font size now does the right thing. I changed the font size and restarted KHelpCenter and the fonsize is saved across restart. Thanks, Jure
Review Request: Fixed KHelpCenter Font Scaling (bug 243082)
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102528/ --- Review request for KDE Runtime. Summary --- When user clicked a button to change font size the entire document was zoomed, instead of just the font size. This meant that the text would run past the right edge and user had to scroll horizontaly to read the whole line. After this patch only the font size changes. This addresses bug 243082. http://bugs.kde.org/show_bug.cgi?id=243082 Diffs - khelpcenter/mainwindow.h 6912e5a khelpcenter/mainwindow.cpp e7997b6 khelpcenter/view.h ea91128 khelpcenter/view.cpp 47b4713 Diff: http://git.reviewboard.kde.org/r/102528/diff Testing --- Clicking on the buttons to change font size now does the right thing. I changed the font size and restarted KHelpCenter and the fonsize is saved across restart. Thanks, Jure
