Re: Review Request: Make KSambaSharePrivate::getNetUserShareInfo less noisy

2011-08-11 Thread David Faure

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102172/#review5627
---

Ship it!


Sure, nice addition to my initial ac7fe47dc commit.

- David


On Aug. 1, 2011, 10:52 p.m., Albert Astals Cid wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/102172/
 ---
 
 (Updated Aug. 1, 2011, 10:52 p.m.)
 
 
 Review request for kdelibs and Rodrigo Belem.
 
 
 Summary
 ---
 
 Each time I open a open dialog i get a complain from 
 KSambaSharePrivate::getNetUserShareInfo that says
 kolourpaint(25821) KSambaSharePrivate::getNetUserShareInfo: We got some 
 errors while running 'net usershare info' 
 kolourpaint(25821) KSambaSharePrivate::getNetUserShareInfo: net usershare: 
 usershares are currently disabled
 With this patch people like me that have never configured that stop receiving 
 the noise on the shell
 
 
 Diffs
 -
 
   kio/kio/ksambashare.cpp cd878b6 
 
 Diff: http://git.reviewboard.kde.org/r/102172/diff
 
 
 Testing
 ---
 
 The noise is gone
 
 
 Thanks,
 
 Albert
 




Re: Review Request: Make KSambaSharePrivate::getNetUserShareInfo less noisy

2011-08-11 Thread Commit Hook

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102172/#review5633
---


This review has been submitted with commit 
75d7cc47fc071f2270492b027c01dcfb28b089b0 by Albert Astals Cid to branch KDE/4.7.

- Commit


On Aug. 1, 2011, 10:52 p.m., Albert Astals Cid wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/102172/
 ---
 
 (Updated Aug. 1, 2011, 10:52 p.m.)
 
 
 Review request for kdelibs and Rodrigo Belem.
 
 
 Summary
 ---
 
 Each time I open a open dialog i get a complain from 
 KSambaSharePrivate::getNetUserShareInfo that says
 kolourpaint(25821) KSambaSharePrivate::getNetUserShareInfo: We got some 
 errors while running 'net usershare info' 
 kolourpaint(25821) KSambaSharePrivate::getNetUserShareInfo: net usershare: 
 usershares are currently disabled
 With this patch people like me that have never configured that stop receiving 
 the noise on the shell
 
 
 Diffs
 -
 
   kio/kio/ksambashare.cpp cd878b6 
 
 Diff: http://git.reviewboard.kde.org/r/102172/diff
 
 
 Testing
 ---
 
 The noise is gone
 
 
 Thanks,
 
 Albert
 




Re: Review Request: Make KSambaSharePrivate::getNetUserShareInfo less noisy

2011-08-11 Thread Commit Hook

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102172/#review5634
---


This review has been submitted with commit 
de6bae2c9331ca2a1e9493288ca355856f4fcaad by Albert Astals Cid to branch 
frameworks.

- Commit


On Aug. 1, 2011, 10:52 p.m., Albert Astals Cid wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/102172/
 ---
 
 (Updated Aug. 1, 2011, 10:52 p.m.)
 
 
 Review request for kdelibs and Rodrigo Belem.
 
 
 Summary
 ---
 
 Each time I open a open dialog i get a complain from 
 KSambaSharePrivate::getNetUserShareInfo that says
 kolourpaint(25821) KSambaSharePrivate::getNetUserShareInfo: We got some 
 errors while running 'net usershare info' 
 kolourpaint(25821) KSambaSharePrivate::getNetUserShareInfo: net usershare: 
 usershares are currently disabled
 With this patch people like me that have never configured that stop receiving 
 the noise on the shell
 
 
 Diffs
 -
 
   kio/kio/ksambashare.cpp cd878b6 
 
 Diff: http://git.reviewboard.kde.org/r/102172/diff
 
 
 Testing
 ---
 
 The noise is gone
 
 
 Thanks,
 
 Albert
 




Review Request: Make KSambaSharePrivate::getNetUserShareInfo less noisy

2011-08-01 Thread Albert Astals Cid

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102172/
---

Review request for kdelibs and Rodrigo Belem.


Summary
---

Each time I open a open dialog i get a complain from 
KSambaSharePrivate::getNetUserShareInfo that says
kolourpaint(25821) KSambaSharePrivate::getNetUserShareInfo: We got some errors 
while running 'net usershare info' 
kolourpaint(25821) KSambaSharePrivate::getNetUserShareInfo: net usershare: 
usershares are currently disabled
With this patch people like me that have never configured that stop receiving 
the noise on the shell


Diffs
-

  kio/kio/ksambashare.cpp cd878b6 

Diff: http://git.reviewboard.kde.org/r/102172/diff


Testing
---

The noise is gone


Thanks,

Albert