Re: Review Request: Only include nepomuk directories if nepomuk is available

2011-08-23 Thread Commit Hook

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101949/#review5969
---


This review has been submitted with commit 
a47e3211681aa3123a7aa5b2d6384d0e347047de by Björn Ricks to branch frameworks.

- Commit


On July 14, 2011, 2:40 p.m., Bjoern Ricks wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101949/
> ---
> 
> (Updated July 14, 2011, 2:40 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> ---
> 
> kdelibs build fails if sdo and/or soprano aren't available
> 
> 
> Diffs
> -
> 
>   kparts/CMakeLists.txt db76613 
> 
> Diff: http://git.reviewboard.kde.org/r/101949/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bjoern
> 
>



Re: Review Request: Only include nepomuk directories if nepomuk is available

2011-08-23 Thread Commit Hook

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101949/#review5929
---


This review has been submitted with commit 
71109e44500859a412a81e2b738ddaf8419708ff by Björn Ricks to branch KDE/4.7.

- Commit


On July 14, 2011, 2:40 p.m., Bjoern Ricks wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101949/
> ---
> 
> (Updated July 14, 2011, 2:40 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> ---
> 
> kdelibs build fails if sdo and/or soprano aren't available
> 
> 
> Diffs
> -
> 
>   kparts/CMakeLists.txt db76613 
> 
> Diff: http://git.reviewboard.kde.org/r/101949/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bjoern
> 
>



Re: Review Request: Only include nepomuk directories if nepomuk is available

2011-08-21 Thread Allen Winter


> On Aug. 17, 2011, 1:19 p.m., Allen Winter wrote:
> > Has this been committed?  If so, please close this review; else please 
> > commit and close this review.
> >
> 
> Bjoern Ricks wrote:
> Commit to trunk and/or 4.7?
> 
> Allen Winter wrote:
> Only master -- better not muck around with 4.7 too much.
> 
> The real solution is to finally make Soprano a hard requirement.

On second thought, please commit to the 4.7 branch as well.
master is frozen now so you should commit into the frameworks branch.


- Allen


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101949/#review5772
---


On July 14, 2011, 2:40 p.m., Bjoern Ricks wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101949/
> ---
> 
> (Updated July 14, 2011, 2:40 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> ---
> 
> kdelibs build fails if sdo and/or soprano aren't available
> 
> 
> Diffs
> -
> 
>   kparts/CMakeLists.txt db76613 
> 
> Diff: http://git.reviewboard.kde.org/r/101949/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bjoern
> 
>



Re: Review Request: Only include nepomuk directories if nepomuk is available

2011-08-18 Thread Allen Winter


> On Aug. 17, 2011, 1:19 p.m., Allen Winter wrote:
> > Has this been committed?  If so, please close this review; else please 
> > commit and close this review.
> >
> 
> Bjoern Ricks wrote:
> Commit to trunk and/or 4.7?

Only master -- better not muck around with 4.7 too much.

The real solution is to finally make Soprano a hard requirement.  


- Allen


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101949/#review5772
---


On July 14, 2011, 2:40 p.m., Bjoern Ricks wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101949/
> ---
> 
> (Updated July 14, 2011, 2:40 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> ---
> 
> kdelibs build fails if sdo and/or soprano aren't available
> 
> 
> Diffs
> -
> 
>   kparts/CMakeLists.txt db76613 
> 
> Diff: http://git.reviewboard.kde.org/r/101949/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bjoern
> 
>



Re: Review Request: Only include nepomuk directories if nepomuk is available

2011-08-17 Thread Bjoern Ricks


> On Aug. 17, 2011, 1:19 p.m., Allen Winter wrote:
> > Has this been committed?  If so, please close this review; else please 
> > commit and close this review.
> >

Commit to trunk and/or 4.7?


- Bjoern


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101949/#review5772
---


On July 14, 2011, 2:40 p.m., Bjoern Ricks wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101949/
> ---
> 
> (Updated July 14, 2011, 2:40 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> ---
> 
> kdelibs build fails if sdo and/or soprano aren't available
> 
> 
> Diffs
> -
> 
>   kparts/CMakeLists.txt db76613 
> 
> Diff: http://git.reviewboard.kde.org/r/101949/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bjoern
> 
>



Re: Review Request: Only include nepomuk directories if nepomuk is available

2011-08-17 Thread Allen Winter

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101949/#review5772
---


Has this been committed?  If so, please close this review; else please commit 
and close this review.


- Allen


On July 14, 2011, 2:40 p.m., Bjoern Ricks wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101949/
> ---
> 
> (Updated July 14, 2011, 2:40 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> ---
> 
> kdelibs build fails if sdo and/or soprano aren't available
> 
> 
> Diffs
> -
> 
>   kparts/CMakeLists.txt db76613 
> 
> Diff: http://git.reviewboard.kde.org/r/101949/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bjoern
> 
>



Re: Review Request: Only include nepomuk directories if nepomuk is available

2011-07-17 Thread Laszlo Papp

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101949/#review4755
---

Ship it!


The compilation issue was not personally talkative enough when I tried to build 
kdelibs without sdo installed (it has not been packaged for this architecture 
that time). I have tested it more times in scratchbox for Harmattan, N9 and it 
works just fine without shared-desktop-ontologies installed. 

- Laszlo


On July 14, 2011, 2:40 p.m., Bjoern Ricks wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101949/
> ---
> 
> (Updated July 14, 2011, 2:40 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> ---
> 
> kdelibs build fails if sdo and/or soprano aren't available
> 
> 
> Diffs
> -
> 
>   kparts/CMakeLists.txt db76613 
> 
> Diff: http://git.reviewboard.kde.org/r/101949/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bjoern
> 
>



Re: Review Request: Only include nepomuk directories if nepomuk is available

2011-07-16 Thread Raphael Kubo da Costa

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101949/#review4751
---

Ship it!


Looks OK to me.

- Raphael


On July 14, 2011, 2:40 p.m., Bjoern Ricks wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101949/
> ---
> 
> (Updated July 14, 2011, 2:40 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> ---
> 
> kdelibs build fails if sdo and/or soprano aren't available
> 
> 
> Diffs
> -
> 
>   kparts/CMakeLists.txt db76613 
> 
> Diff: http://git.reviewboard.kde.org/r/101949/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bjoern
> 
>



Review Request: Only include nepomuk directories if nepomuk is available

2011-07-14 Thread Bjoern Ricks

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101949/
---

Review request for kdelibs.


Summary
---

kdelibs build fails if sdo and/or soprano aren't available


Diffs
-

  kparts/CMakeLists.txt db76613 

Diff: http://git.reviewboard.kde.org/r/101949/diff


Testing
---


Thanks,

Bjoern