Re: Review Request: Plasma Components buttons: first focus, than emit clicked() signal
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104893/#review13616 --- I am unsure whether Plasma Components related patches are relevant to k-c-d. I would rather include the plasma devel team for reviews. Other Aaron, Marco or other plasma developers might miss this. :-) - Laszlo Papp On May 9, 2012, 4:41 p.m., Sebastian Gottfried wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104893/ > --- > > (Updated May 9, 2012, 4:41 p.m.) > > > Review request for KDE Runtime. > > > Description > --- > > Otherwise a client wanting to give another QML component the focus in > reaction to a clicked button has no chance doing so because the button > will steal the focus again right after the event hander has finished > executing. > > > Diffs > - > > plasma/declarativeimports/plasmacomponents/qml/Button.qml 6aab1b2 > plasma/declarativeimports/plasmacomponents/qml/ToolButton.qml 00ffa4c > > Diff: http://git.reviewboard.kde.org/r/104893/diff/ > > > Testing > --- > > Tested the behaviour in ktouch/next, works fine. > > > Thanks, > > Sebastian Gottfried > >
Re: Review Request: Plasma Components buttons: first focus, than emit clicked() signal
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104893/#review13626 --- Ship it! Good catch, please commit to KDE/4.8 and master or let me know so I'll do it for you. - Sebastian Kügler On May 9, 2012, 4:41 p.m., Sebastian Gottfried wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104893/ > --- > > (Updated May 9, 2012, 4:41 p.m.) > > > Review request for KDE Runtime. > > > Description > --- > > Otherwise a client wanting to give another QML component the focus in > reaction to a clicked button has no chance doing so because the button > will steal the focus again right after the event hander has finished > executing. > > > Diffs > - > > plasma/declarativeimports/plasmacomponents/qml/Button.qml 6aab1b2 > plasma/declarativeimports/plasmacomponents/qml/ToolButton.qml 00ffa4c > > Diff: http://git.reviewboard.kde.org/r/104893/diff/ > > > Testing > --- > > Tested the behaviour in ktouch/next, works fine. > > > Thanks, > > Sebastian Gottfried > >
Re: Review Request: Plasma Components buttons: first focus, than emit clicked() signal
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104893/#review13632 --- This review has been submitted with commit fdb3ec834ee6912c82cdc436f614b8f7fb4fe8a5 by Sebastian Gottfried to branch master. - Commit Hook On May 9, 2012, 4:41 p.m., Sebastian Gottfried wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104893/ > --- > > (Updated May 9, 2012, 4:41 p.m.) > > > Review request for KDE Runtime. > > > Description > --- > > Otherwise a client wanting to give another QML component the focus in > reaction to a clicked button has no chance doing so because the button > will steal the focus again right after the event hander has finished > executing. > > > Diffs > - > > plasma/declarativeimports/plasmacomponents/qml/Button.qml 6aab1b2 > plasma/declarativeimports/plasmacomponents/qml/ToolButton.qml 00ffa4c > > Diff: http://git.reviewboard.kde.org/r/104893/diff/ > > > Testing > --- > > Tested the behaviour in ktouch/next, works fine. > > > Thanks, > > Sebastian Gottfried > >
