Re: Review Request: fix broken nepomuk ui files to make messages translatable
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101112/#review2626 --- Ship it! Looks fine to me. I simply used the designer field that said comment. But I just checked - it might be that the german translation of Designer is a bit weird: Kennung seems to be the one to use instead of Kommentar. - Sebastian On April 13, 2011, 2:04 p.m., Burkhard Lück wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101112/ --- (Updated April 13, 2011, 2:04 p.m.) Review request for KDE Runtime and Sebastian Trueg. Summary --- Some nepomuk ui files have strings like string extracomment=@infosome message/string xgettext extracts this properly to msgctxt @info msgid some message ui compiler generates tr2i18n(some message, 0) - that does not match xgettext, therefore no translated msg is found With string comment=@infosome message/string the ui compiler generates tr2i18n(some message, @info), that does match xgettext and the translated msg is found and shown Diffs - nepomuk/kcm/nepomukconfigwidget.ui 5652274 nepomuk/services/backupsync/gui/backupsettingspage.ui e28a7f5 nepomuk/services/backupsync/gui/intropage.ui 1a74630 nepomuk/services/backupsync/gui/restoreselection.ui 157c50a Diff: http://git.reviewboard.kde.org/r/101112/diff Testing --- Tested using locale x-test (http://techbase.kde.org/Development/Tutorials/Localization/Building_KDE's_l10n_Module), messages are translated Thanks, Burkhard
Re: Review Request: fix broken nepomuk ui files to make messages translatable
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101112/#review2648 --- This review has been submitted with commit 398f4964691e76f8d60e399c294aec282f3d6036 by Burkhard Lück. - Commit On April 13, 2011, 2:04 p.m., Burkhard Lück wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101112/ --- (Updated April 13, 2011, 2:04 p.m.) Review request for KDE Runtime and Sebastian Trueg. Summary --- Some nepomuk ui files have strings like string extracomment=@infosome message/string xgettext extracts this properly to msgctxt @info msgid some message ui compiler generates tr2i18n(some message, 0) - that does not match xgettext, therefore no translated msg is found With string comment=@infosome message/string the ui compiler generates tr2i18n(some message, @info), that does match xgettext and the translated msg is found and shown Diffs - nepomuk/kcm/nepomukconfigwidget.ui 5652274 nepomuk/services/backupsync/gui/backupsettingspage.ui e28a7f5 nepomuk/services/backupsync/gui/intropage.ui 1a74630 nepomuk/services/backupsync/gui/restoreselection.ui 157c50a Diff: http://git.reviewboard.kde.org/r/101112/diff Testing --- Tested using locale x-test (http://techbase.kde.org/Development/Tutorials/Localization/Building_KDE's_l10n_Module), messages are translated Thanks, Burkhard
Review Request: fix broken nepomuk ui files to make messages translatable
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101112/ --- Review request for KDE Runtime and Sebastian Trueg. Summary --- Some nepomuk ui files have strings like string extracomment=@infosome message/string xgettext extracts this properly to msgctxt @info msgid some message ui compiler generates tr2i18n(some message, 0) - that does not match xgettext, therefore no translated msg is found With string comment=@infosome message/string the ui compiler generates tr2i18n(some message, @info), that does match xgettext and the translated msg is found and shown Diffs - nepomuk/kcm/nepomukconfigwidget.ui 5652274 nepomuk/services/backupsync/gui/backupsettingspage.ui e28a7f5 nepomuk/services/backupsync/gui/intropage.ui 1a74630 nepomuk/services/backupsync/gui/restoreselection.ui 157c50a Diff: http://git.reviewboard.kde.org/r/101112/diff Testing --- Tested using locale x-test (http://techbase.kde.org/Development/Tutorials/Localization/Building_KDE's_l10n_Module), messages are translated Thanks, Burkhard
