Review Request: kjs: Implement JSON.parse

2012-05-25 Thread Bernd Buschinski 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105056/
---

Review request for kdelibs.


Description
---

kjs: Implement JSON.parse


Diffs
-

  kjs/CMakeLists.txt 1188064 
  kjs/interpreter.cpp cf1acf1 
  kjs/json_object.h PRE-CREATION 
  kjs/json_object.cpp PRE-CREATION 
  kjs/jsonlexer.h PRE-CREATION 
  kjs/jsonlexer.cpp PRE-CREATION 
  kjs/libkjs.map e9f679f 

Diff: http://git.reviewboard.kde.org/r/105056/diff/


Testing
---


Thanks,

Bernd Buschinski

Re: Review Request: kjs: Implement JSON.parse

2012-05-26 Thread Rolf Eike Beer 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105056/#review14177
---


You forgot to change kjs/tests/ecmatest_broken_*

- Rolf Eike Beer


On May 25, 2012, 8:19 p.m., Bernd Buschinski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105056/
> ---
> 
> (Updated May 25, 2012, 8:19 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> ---
> 
> kjs: Implement JSON.parse
> 
> 
> Diffs
> -
> 
>   kjs/CMakeLists.txt 1188064 
>   kjs/interpreter.cpp cf1acf1 
>   kjs/json_object.h PRE-CREATION 
>   kjs/json_object.cpp PRE-CREATION 
>   kjs/jsonlexer.h PRE-CREATION 
>   kjs/jsonlexer.cpp PRE-CREATION 
>   kjs/libkjs.map e9f679f 
> 
> Diff: http://git.reviewboard.kde.org/r/105056/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bernd Buschinski
> 
>

Re: Review Request: kjs: Implement JSON.parse

2012-05-27 Thread Bernd Buschinski 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105056/
---

(Updated May 27, 2012, 3:30 p.m.)


Review request for kdelibs.


Changes
---

- fixed stupid typo, that caused "123.456" to cause an syntax error
- use putDirect instead of put to store properties, we need to by-pass __proto__

now passes all ecma JSON-parse tests

this means removing all 15.12.0 - 15.12.2 tests from broken file (not yet 
included in diff)


Description
---

kjs: Implement JSON.parse


Diffs (updated)
-

  kjs/CMakeLists.txt 1188064 
  kjs/interpreter.cpp cf1acf1 
  kjs/json_object.h PRE-CREATION 
  kjs/json_object.cpp PRE-CREATION 
  kjs/jsonlexer.h PRE-CREATION 
  kjs/jsonlexer.cpp PRE-CREATION 
  kjs/libkjs.map e9f679f 

Diff: http://git.reviewboard.kde.org/r/105056/diff/


Testing
---


Thanks,

Bernd Buschinski

Re: Review Request: kjs: Implement JSON.parse

2012-05-28 Thread Maks Orlovich 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105056/#review14235
---



kjs/json_object.cpp


Comment needs fixing.



kjs/json_object.cpp


Please try to be consistent with * and & placement at least at the level of 
a single line.



kjs/json_object.cpp


static; otherwise you're polluting global namespace.




kjs/json_object.cpp


The spec seems to call for special handling of arrays, are you sure you can 
get away with not doing it? (You probably can given it's parse output, but it 
could use a comment).




kjs/json_object.cpp


Are you sure about the 'IncludeDontEnum' bit? The Walk definition seems to 
require going only through enumerable ones.




kjs/json_object.cpp


I think you end up not calling func on the very top-most object.

Also, what's the semantics here wrt to exceptions? I think you may be doing 
too much if func throws.




kjs/json_object.cpp


Again, the */& placement is all over the place.



kjs/json_object.cpp


Are you sure this is correct? The JS-ey thing would be to try to parse 
'undefined'.




kjs/json_object.cpp


The ->toString could have thrown an exception...





kjs/jsonlexer.h


Comment that it may return NULL (and not just jsUndefined).



kjs/jsonlexer.cpp


Why not use the numeric variant instead?




kjs/jsonlexer.cpp


define 'later' please.



kjs/jsonlexer.cpp


Shouldn't you at return a parse error here if propertyName is empty?

Also note the difference between "": 42 and :42 -- not sure if former is 
legit.



kjs/jsonlexer.cpp


again, "later"? Sounds like you've already implemented it.



kjs/jsonlexer.cpp


Err, does it mean it will accept 
[1 2 3 4] as an array of 4 numbers? That doesn't look right. 
For that matter even [1,2,] doesn't look right in JSON.





kjs/jsonlexer.cpp


It's generally suggested to use pointers for out params.




kjs/jsonlexer.cpp


And what if all valid characters in the buffer are whitespace? You'll run 
past the end of it. Also, this code isn't robust if ::next() is called at 
end-of-file more than once. I would suggest something like:

while(true) {
  if (m_pos >= m_code.size()) {
m_type = TokEnd;
return m_type;
  }

  if (!isJSONWhiteSpace(m_code[m_pos])) {
break;
  }
  ++m_pos;
}



- Maks Orlovich


On May 27, 2012, 3:30 p.m., Bernd Buschinski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105056/
> ---
> 
> (Updated May 27, 2012, 3:30 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> ---
> 
> kjs: Implement JSON.parse
> 
> 
> Diffs
> -
> 
>   kjs/CMakeLists.txt 1188064 
>   kjs/interpreter.cpp cf1acf1 
>   kjs/json_object.h PRE-CREATION 
>   kjs/json_object.cpp PRE-CREATION 
>   kjs/jsonlexer.h PRE-CREATION 
>   kjs/jsonlexer.cpp PRE-CREATION 
>   kjs/libkjs.map e9f679f 
> 
> Diff: http://git.reviewboard.kde.org/r/105056/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bernd Buschinski
> 
>

Re: Review Request: kjs: Implement JSON.parse

2012-05-28 Thread Bernd Buschinski 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105056/
---

(Updated May 28, 2012, 7:52 p.m.)


Review request for kdelibs.


Changes
---

All statet issues fixed.


Description
---

kjs: Implement JSON.parse


Diffs (updated)
-

  kjs/CMakeLists.txt 1188064 
  kjs/interpreter.cpp cf1acf1 
  kjs/json_object.h PRE-CREATION 
  kjs/json_object.cpp PRE-CREATION 
  kjs/jsonlexer.h PRE-CREATION 
  kjs/jsonlexer.cpp PRE-CREATION 
  kjs/libkjs.map e9f679f 

Diff: http://git.reviewboard.kde.org/r/105056/diff/


Testing
---


Thanks,

Bernd Buschinski

Re: Review Request: kjs: Implement JSON.parse

2012-06-10 Thread Maks Orlovich 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105056/#review14590
---



kjs/json_object.cpp


What namespace do the symbols for this end up in?




kjs/json_object.cpp


What happens if the call threw an exception?




kjs/json_object.cpp


I think it's true, but needs one more proviso: the check on line 89.



kjs/json_object.cpp


I think if you don't put in a space between * and /* some Windows compiler 
will whine.
(Warnings only, I think, but someone was bothered by it enough in the past 
to ask us to change a bunch)



kjs/json_object.cpp


What happens if toObject throws? (I think it can.. but I might be wrong).




kjs/jsonlexer.h


explicit



kjs/jsonlexer.h


explicit



kjs/jsonlexer.h


What's the return value on failure?



kjs/jsonlexer.cpp


static




kjs/jsonlexer.cpp


static



kjs/jsonlexer.cpp


static, comment pareameters?




kjs/jsonlexer.cpp


I don't think this is needed anymore?
(Nor the similar one in arrays)



kjs/jsonlexer.cpp


This looks like it will run out of stack space pretty quickly. I think it 
would be better to instead of firstArrayRun to have something more like what 
you have for objects. (Or just use propAdded in the same way)




kjs/jsonlexer.cpp


So JSON doesn't have 'strings'?




kjs/jsonlexer.cpp


Where did the -? go?




kjs/jsonlexer.cpp


Comment method?


- Maks Orlovich


On May 28, 2012, 7:52 p.m., Bernd Buschinski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105056/
> ---
> 
> (Updated May 28, 2012, 7:52 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> ---
> 
> kjs: Implement JSON.parse
> 
> 
> Diffs
> -
> 
>   kjs/CMakeLists.txt 1188064 
>   kjs/interpreter.cpp cf1acf1 
>   kjs/json_object.h PRE-CREATION 
>   kjs/json_object.cpp PRE-CREATION 
>   kjs/jsonlexer.h PRE-CREATION 
>   kjs/jsonlexer.cpp PRE-CREATION 
>   kjs/libkjs.map e9f679f 
> 
> Diff: http://git.reviewboard.kde.org/r/105056/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bernd Buschinski
> 
>

Re: Review Request: kjs: Implement JSON.parse

2012-06-18 Thread Bernd Buschinski 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105056/
---

(Updated June 18, 2012, 10:25 p.m.)


Review request for kdelibs.


Changes
---

All issues fixed, beside from the stack-firstrun


Description
---

kjs: Implement JSON.parse


Diffs (updated)
-

  kjs/CMakeLists.txt 1188064 
  kjs/interpreter.cpp cf1acf1 
  kjs/json_object.h PRE-CREATION 
  kjs/json_object.cpp PRE-CREATION 
  kjs/jsonlexer.h PRE-CREATION 
  kjs/jsonlexer.cpp PRE-CREATION 
  kjs/libkjs.map e9f679f 

Diff: http://git.reviewboard.kde.org/r/105056/diff/


Testing
---


Thanks,

Bernd Buschinski

Re: Review Request: kjs: Implement JSON.parse

2012-06-18 Thread Bernd Buschinski 


> On June 10, 2012, 6:57 p.m., Maks Orlovich wrote:
> > kjs/json_object.cpp, line 37
> > 
> >
> > What namespace do the symbols for this end up in?
> >

like all other generated luts, in the KJS namespace


> On June 10, 2012, 6:57 p.m., Maks Orlovich wrote:
> > kjs/json_object.cpp, line 107
> > 
> >
> > I think it's true, but needs one more proviso: the check on line 89.

Fixed with extra exception check


> On June 10, 2012, 6:57 p.m., Maks Orlovich wrote:
> > kjs/jsonlexer.cpp, line 193
> > 
> >
> > I don't think this is needed anymore?
> > (Nor the similar one in arrays)

This is still needed, as object is NULL on if we get called from called from 
JSONArray-TokLBrace.
Like the comment says.


> On June 10, 2012, 6:57 p.m., Maks Orlovich wrote:
> > kjs/jsonlexer.cpp, line 292
> > 
> >
> > This looks like it will run out of stack space pretty quickly. I think 
> > it would be better to instead of firstArrayRun to have something more like 
> > what you have for objects. (Or just use propAdded in the same way)
> >

I can't use propAdded because it has a different default-start value.


- Bernd


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105056/#review14590
---


On May 28, 2012, 7:52 p.m., Bernd Buschinski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105056/
> ---
> 
> (Updated May 28, 2012, 7:52 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> ---
> 
> kjs: Implement JSON.parse
> 
> 
> Diffs
> -
> 
>   kjs/CMakeLists.txt 1188064 
>   kjs/interpreter.cpp cf1acf1 
>   kjs/json_object.h PRE-CREATION 
>   kjs/json_object.cpp PRE-CREATION 
>   kjs/jsonlexer.h PRE-CREATION 
>   kjs/jsonlexer.cpp PRE-CREATION 
>   kjs/libkjs.map e9f679f 
> 
> Diff: http://git.reviewboard.kde.org/r/105056/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bernd Buschinski
> 
>

Re: Review Request: kjs: Implement JSON.parse

2012-07-04 Thread Maks Orlovich 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105056/#review15374
---



kjs/json_object.cpp


I think this may not be quite true in case the user function adds 
non-numeric properties to an array.



kjs/jsonlexer.h


Unused?




kjs/jsonlexer.cpp


I don't think this is needed anymore.



kjs/jsonlexer.cpp


Again, please fix this to not be needlessly recursive.



- Maks Orlovich


On June 18, 2012, 10:25 p.m., Bernd Buschinski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105056/
> ---
> 
> (Updated June 18, 2012, 10:25 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> ---
> 
> kjs: Implement JSON.parse
> 
> 
> Diffs
> -
> 
>   kjs/CMakeLists.txt 1188064 
>   kjs/interpreter.cpp cf1acf1 
>   kjs/json_object.h PRE-CREATION 
>   kjs/json_object.cpp PRE-CREATION 
>   kjs/jsonlexer.h PRE-CREATION 
>   kjs/jsonlexer.cpp PRE-CREATION 
>   kjs/libkjs.map e9f679f 
> 
> Diff: http://git.reviewboard.kde.org/r/105056/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bernd Buschinski
> 
>

Re: Review Request: kjs: Implement JSON.parse

2012-07-04 Thread Bernd Buschinski 


> On July 4, 2012, 2:24 p.m., Maks Orlovich wrote:
> > kjs/jsonlexer.cpp, line 198
> > 
> >
> > I don't think this is needed anymore.

If we got called from JSONArray-TokLBrace we did not create an object.

In more detail for the following JSON String "[{}]"
If are in parse with type=JSONArray and state=TokLBrace,
means we just found the { in the Array, and call parse(exec, JSONObject),
now in this call type=JSONObject, state=TokRBrace ("}") and, our new, object=0 
(!)
We will finish the object and return it, but as object is null, we return 0.
which would be wrong, as empty objects are allowed.
In this case we just report invalid data.
But for JSON String like "[{"a":1}]", we end up using object(0)->putDirect
and crash.

In short, remove this line and we will crash.


- Bernd


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105056/#review15374
---


On June 18, 2012, 10:25 p.m., Bernd Buschinski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105056/
> ---
> 
> (Updated June 18, 2012, 10:25 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> ---
> 
> kjs: Implement JSON.parse
> 
> 
> Diffs
> -
> 
>   kjs/CMakeLists.txt 1188064 
>   kjs/interpreter.cpp cf1acf1 
>   kjs/json_object.h PRE-CREATION 
>   kjs/json_object.cpp PRE-CREATION 
>   kjs/jsonlexer.h PRE-CREATION 
>   kjs/jsonlexer.cpp PRE-CREATION 
>   kjs/libkjs.map e9f679f 
> 
> Diff: http://git.reviewboard.kde.org/r/105056/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bernd Buschinski
> 
>

Re: Review Request: kjs: Implement JSON.parse

2012-07-04 Thread Bernd Buschinski 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105056/
---

(Updated July 4, 2012, 10:27 p.m.)


Review request for kdelibs.


Changes
---

fixed, beside from the really still needed object = object...
just with a big comment now


Description
---

kjs: Implement JSON.parse


Diffs (updated)
-

  kjs/CMakeLists.txt 1188064 
  kjs/interpreter.cpp cf1acf1 
  kjs/json_object.h PRE-CREATION 
  kjs/json_object.cpp PRE-CREATION 
  kjs/jsonlexer.h PRE-CREATION 
  kjs/jsonlexer.cpp PRE-CREATION 
  kjs/libkjs.map e9f679f 

Diff: http://git.reviewboard.kde.org/r/105056/diff/


Testing
---


Thanks,

Bernd Buschinski

Re: Review Request: kjs: Implement JSON.parse

2012-07-04 Thread Rolf Eike Beer 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105056/#review15397
---


No functional review, just reading through the code.


kjs/jsonlexer.cpp


If "we" are in parse...?



kjs/jsonlexer.cpp


Can those 3 just be merged and use "return UChar(cur.uc);"?


- Rolf Eike Beer


On July 4, 2012, 10:27 p.m., Bernd Buschinski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105056/
> ---
> 
> (Updated July 4, 2012, 10:27 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> ---
> 
> kjs: Implement JSON.parse
> 
> 
> Diffs
> -
> 
>   kjs/CMakeLists.txt 1188064 
>   kjs/interpreter.cpp cf1acf1 
>   kjs/json_object.h PRE-CREATION 
>   kjs/json_object.cpp PRE-CREATION 
>   kjs/jsonlexer.h PRE-CREATION 
>   kjs/jsonlexer.cpp PRE-CREATION 
>   kjs/libkjs.map e9f679f 
> 
> Diff: http://git.reviewboard.kde.org/r/105056/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bernd Buschinski
> 
>

Re: Review Request: kjs: Implement JSON.parse

2012-07-05 Thread Bernd Buschinski 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105056/
---

(Updated July 5, 2012, 12:35 p.m.)


Review request for kdelibs.


Description
---

kjs: Implement JSON.parse


Diffs (updated)
-

  kjs/CMakeLists.txt 1188064 
  kjs/interpreter.cpp cf1acf1 
  kjs/json_object.h PRE-CREATION 
  kjs/json_object.cpp PRE-CREATION 
  kjs/jsonlexer.h PRE-CREATION 
  kjs/jsonlexer.cpp PRE-CREATION 
  kjs/libkjs.map e9f679f 

Diff: http://git.reviewboard.kde.org/r/105056/diff/


Testing
---


Thanks,

Bernd Buschinski

Re: Review Request: kjs: Implement JSON.parse

2012-07-05 Thread Bernd Buschinski 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105056/
---

(Updated July 5, 2012, 12:50 p.m.)


Review request for kdelibs.


Changes
---

k, new stupid typo


Description
---

kjs: Implement JSON.parse


Diffs (updated)
-

  kjs/CMakeLists.txt 1188064 
  kjs/interpreter.cpp cf1acf1 
  kjs/json_object.h PRE-CREATION 
  kjs/json_object.cpp PRE-CREATION 
  kjs/jsonlexer.h PRE-CREATION 
  kjs/jsonlexer.cpp PRE-CREATION 
  kjs/libkjs.map e9f679f 

Diff: http://git.reviewboard.kde.org/r/105056/diff/


Testing
---


Thanks,

Bernd Buschinski

Re: Review Request: kjs: Implement JSON.parse

2012-07-06 Thread Maks Orlovich 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105056/#review15462
---



kjs/jsonlexer.cpp


What about two commas in a row?



kjs/jsonlexer.cpp


what if this puts you past the end of the string?



- Maks Orlovich


On July 5, 2012, 12:50 p.m., Bernd Buschinski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105056/
> ---
> 
> (Updated July 5, 2012, 12:50 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> ---
> 
> kjs: Implement JSON.parse
> 
> 
> Diffs
> -
> 
>   kjs/CMakeLists.txt 1188064 
>   kjs/interpreter.cpp cf1acf1 
>   kjs/json_object.h PRE-CREATION 
>   kjs/json_object.cpp PRE-CREATION 
>   kjs/jsonlexer.h PRE-CREATION 
>   kjs/jsonlexer.cpp PRE-CREATION 
>   kjs/libkjs.map e9f679f 
> 
> Diff: http://git.reviewboard.kde.org/r/105056/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bernd Buschinski
> 
>

Re: Review Request: kjs: Implement JSON.parse

2012-07-06 Thread Bernd Buschinski 


> On July 6, 2012, 3:12 p.m., Maks Orlovich wrote:
> > kjs/jsonlexer.cpp, line 309
> > 
> >
> > What about two commas in a row?

propAdded handles this (tested),

we will hit the TokComma case 2 times in a row

case TokComma: // Skip Comma and parse next Array Element
// if we found a comma without a leading property, this is invalid syntax
if (!propAdded)
return 0;
propAdded = false;


- Bernd


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105056/#review15462
---


On July 5, 2012, 12:50 p.m., Bernd Buschinski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105056/
> ---
> 
> (Updated July 5, 2012, 12:50 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> ---
> 
> kjs: Implement JSON.parse
> 
> 
> Diffs
> -
> 
>   kjs/CMakeLists.txt 1188064 
>   kjs/interpreter.cpp cf1acf1 
>   kjs/json_object.h PRE-CREATION 
>   kjs/json_object.cpp PRE-CREATION 
>   kjs/jsonlexer.h PRE-CREATION 
>   kjs/jsonlexer.cpp PRE-CREATION 
>   kjs/libkjs.map e9f679f 
> 
> Diff: http://git.reviewboard.kde.org/r/105056/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bernd Buschinski
> 
>

Re: Review Request: kjs: Implement JSON.parse

2012-07-06 Thread Bernd Buschinski 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105056/
---

(Updated July 6, 2012, 7:11 p.m.)


Review request for kdelibs.


Description
---

kjs: Implement JSON.parse


Diffs (updated)
-

  kjs/CMakeLists.txt 1188064 
  kjs/interpreter.cpp cf1acf1 
  kjs/json_object.h PRE-CREATION 
  kjs/json_object.cpp PRE-CREATION 
  kjs/jsonlexer.h PRE-CREATION 
  kjs/jsonlexer.cpp PRE-CREATION 
  kjs/libkjs.map e9f679f 

Diff: http://git.reviewboard.kde.org/r/105056/diff/


Testing
---


Thanks,

Bernd Buschinski

Re: Review Request: kjs: Implement JSON.parse

2012-07-22 Thread Maks Orlovich 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105056/#review16241
---

Ship it!


Ship It!

- Maks Orlovich


On July 6, 2012, 7:11 p.m., Bernd Buschinski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105056/
> ---
> 
> (Updated July 6, 2012, 7:11 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> ---
> 
> kjs: Implement JSON.parse
> 
> 
> Diffs
> -
> 
>   kjs/CMakeLists.txt 1188064 
>   kjs/interpreter.cpp cf1acf1 
>   kjs/json_object.h PRE-CREATION 
>   kjs/json_object.cpp PRE-CREATION 
>   kjs/jsonlexer.h PRE-CREATION 
>   kjs/jsonlexer.cpp PRE-CREATION 
>   kjs/libkjs.map e9f679f 
> 
> Diff: http://git.reviewboard.kde.org/r/105056/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bernd Buschinski
> 
>

Re: Review Request: kjs: Implement JSON.parse

2012-09-05 Thread Commit Hook 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105056/#review18561
---


This review has been submitted with commit 
ae94e9a23275611e1c385f799cf58053e20aeb08 by Bernd Buschinski to branch KDE/4.9.

- Commit Hook


On July 6, 2012, 7:11 p.m., Bernd Buschinski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105056/
> ---
> 
> (Updated July 6, 2012, 7:11 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> ---
> 
> kjs: Implement JSON.parse
> 
> 
> Diffs
> -
> 
>   kjs/CMakeLists.txt 1188064 
>   kjs/interpreter.cpp cf1acf1 
>   kjs/json_object.h PRE-CREATION 
>   kjs/json_object.cpp PRE-CREATION 
>   kjs/jsonlexer.h PRE-CREATION 
>   kjs/jsonlexer.cpp PRE-CREATION 
>   kjs/libkjs.map e9f679f 
> 
> Diff: http://git.reviewboard.kde.org/r/105056/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bernd Buschinski
> 
>