Re: Review Request 109549: port KRun away from KProcess
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109549/#review29574 --- kio/kio/krun.cpp http://git.reviewboard.kde.org/r/109549/#comment22055 This is missing const for the workingDirectory parameter. (Sorry, forgot to publish that review - I hate that on ReviewBoard :-/) - Milian Wolff On March 18, 2013, 7:51 p.m., Martin Tobias Holmedahl Sandsmark wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109549/ --- (Updated March 18, 2013, 7:51 p.m.) Review request for KDE Frameworks, kdelibs and David Faure. Description --- Port KRun to use QProcess instead of KProcess. Instead of passing around KProcess instances, we simply pass the command with arguments and the working directory. Diffs - kio/kio/krun.cpp 76b7385 kio/kio/krun_p.h 01abb69 Diff: http://git.reviewboard.kde.org/r/109549/diff/ Testing --- Thanks, Martin Tobias Holmedahl Sandsmark
Re: Review Request 109549: port KRun away from KProcess
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109549/#review29429 --- Ship it! Looks good to me provided you fixed the trailing whitespace issue mentionned previously. - Kevin Ottens On March 17, 2013, 4:19 p.m., Martin Tobias Holmedahl Sandsmark wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109549/ --- (Updated March 17, 2013, 4:19 p.m.) Review request for KDE Frameworks, kdelibs and David Faure. Description --- Port KRun to use QProcess instead of KProcess. Instead of passing around KProcess instances, we simply pass the command with arguments and the working directory. Diffs - kio/kio/krun.cpp 76b7385 kio/kio/krun_p.h 01abb69 Diff: http://git.reviewboard.kde.org/r/109549/diff/ Testing --- Thanks, Martin Tobias Holmedahl Sandsmark
Re: Review Request 109549: port KRun away from KProcess
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109549/ --- (Updated March 18, 2013, 7:51 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, kdelibs and David Faure. Description --- Port KRun to use QProcess instead of KProcess. Instead of passing around KProcess instances, we simply pass the command with arguments and the working directory. Diffs - kio/kio/krun.cpp 76b7385 kio/kio/krun_p.h 01abb69 Diff: http://git.reviewboard.kde.org/r/109549/diff/ Testing --- Thanks, Martin Tobias Holmedahl Sandsmark
Review Request 109549: port KRun away from KProcess
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109549/ --- Review request for KDE Frameworks, kdelibs and David Faure. Description --- Port KRun to use QProcess instead of KProcess. Instead of passing around KProcess instances, we simply pass the command with arguments and the working directory. Diffs - kio/kio/krun.cpp 76b7385 kio/kio/krun_p.h 01abb69 Diff: http://git.reviewboard.kde.org/r/109549/diff/ Testing --- Thanks, Martin Tobias Holmedahl Sandsmark
Re: Review Request 109549: port KRun away from KProcess
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109549/#review29391 --- kio/kio/krun.cpp http://git.reviewboard.kde.org/r/109549/#comment21955 Whitespacing around braces is inconsistent. kio/kio/krun.cpp http://git.reviewboard.kde.org/r/109549/#comment21954 Trailing whitespace - Rolf Eike Beer On March 17, 2013, 4:19 p.m., Martin Tobias Holmedahl Sandsmark wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109549/ --- (Updated March 17, 2013, 4:19 p.m.) Review request for KDE Frameworks, kdelibs and David Faure. Description --- Port KRun to use QProcess instead of KProcess. Instead of passing around KProcess instances, we simply pass the command with arguments and the working directory. Diffs - kio/kio/krun.cpp 76b7385 kio/kio/krun_p.h 01abb69 Diff: http://git.reviewboard.kde.org/r/109549/diff/ Testing --- Thanks, Martin Tobias Holmedahl Sandsmark
Re: Review Request 109549: port KRun away from KProcess
On March 17, 2013, 4:41 p.m., Rolf Eike Beer wrote: kio/kio/krun.cpp, line 1780 http://git.reviewboard.kde.org/r/109549/diff/1/?file=120223#file120223line1780 Whitespacing around braces is inconsistent. it's consistent with the rest of the code around it? On March 17, 2013, 4:41 p.m., Rolf Eike Beer wrote: kio/kio/krun.cpp, line 1781 http://git.reviewboard.kde.org/r/109549/diff/1/?file=120223#file120223line1781 Trailing whitespace fixed locally, but a bother to upload a new patch... - Martin Tobias Holmedahl --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109549/#review29391 --- On March 17, 2013, 4:19 p.m., Martin Tobias Holmedahl Sandsmark wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109549/ --- (Updated March 17, 2013, 4:19 p.m.) Review request for KDE Frameworks, kdelibs and David Faure. Description --- Port KRun to use QProcess instead of KProcess. Instead of passing around KProcess instances, we simply pass the command with arguments and the working directory. Diffs - kio/kio/krun.cpp 76b7385 kio/kio/krun_p.h 01abb69 Diff: http://git.reviewboard.kde.org/r/109549/diff/ Testing --- Thanks, Martin Tobias Holmedahl Sandsmark
