Re: Review Request 110388: Change default thumbnail cache directory
> On May 21, 2013, 3:29 p.m., Maarten De Meyer wrote: > > Could I get an update on this? > > This is mostly working for me. Some thumbnailers need to be recompiled but > > there is no breakage if they use the old cache for now. > > If this change is to intrusive for frozen kdelibs I could make it > > frameworks only. (although it is a bugfix imho) Yes this should be done in frameworks, where all paths in $HOME are being changed anyway. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110388/#review32905 --- On Jan. 11, 2014, 3:15 p.m., Maarten De Meyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/110388/ > --- > > (Updated Jan. 11, 2014, 3:15 p.m.) > > > Review request for kdelibs. > > > Bugs: 319528 > http://bugs.kde.org/show_bug.cgi?id=319528 > > > Repository: kdelibs > > > Description > --- > > The freedesktop spec[0] has changed the default location of the thumbnail > cache directory. > Now thumbnails are saved in $XDG_CACHE_HOME/thumbnails instead of > ~/.thumbnails/ > GNOME has already made this change. > > Some applications[1] and documentation[2] (maybe thumbnailers) will have to > be changed to adapt to this new directory. If this patch is accepted I'll > make the needed changes. > For frameworks we can use QStandardPaths::CacheLocation, I'll post a separate > review for that. > > All thumbnails will have to be regenerated. We could symlink the directory? > Is fromLocal8Bit correct or is UTF8 needed now? > > [0] > http://specifications.freedesktop.org/thumbnail-spec/thumbnail-spec-latest.html > [1] configurepreviewdialog.cpp in Dolphin > [2]http://techbase.kde.org/KDE_System_Administration/XDG_Filesystem_Hierarchy#Thumbnails > > > Diffs > - > > kio/kio/previewjob.cpp 01b674d > > Diff: https://git.reviewboard.kde.org/r/110388/diff/ > > > Testing > --- > > Remove ~/.thumbnails/ > Run dolphin with previews: thumbnails are created in .cache/thumbnails/ > > Repeated with XDG_CACHE_HOME=~/.cachetestdir/ > Thumbnails in .cachetestdir/thumbnails/ > > Not tested: gwenview and digikam. > > > Thanks, > > Maarten De Meyer > >
Re: Review Request 110388: Change default thumbnail cache directory
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110388/ --- (Updated Jan. 11, 2014, 3:15 p.m.) Status -- This change has been discarded. Review request for kdelibs. Bugs: 319528 http://bugs.kde.org/show_bug.cgi?id=319528 Repository: kdelibs Description --- The freedesktop spec[0] has changed the default location of the thumbnail cache directory. Now thumbnails are saved in $XDG_CACHE_HOME/thumbnails instead of ~/.thumbnails/ GNOME has already made this change. Some applications[1] and documentation[2] (maybe thumbnailers) will have to be changed to adapt to this new directory. If this patch is accepted I'll make the needed changes. For frameworks we can use QStandardPaths::CacheLocation, I'll post a separate review for that. All thumbnails will have to be regenerated. We could symlink the directory? Is fromLocal8Bit correct or is UTF8 needed now? [0] http://specifications.freedesktop.org/thumbnail-spec/thumbnail-spec-latest.html [1] configurepreviewdialog.cpp in Dolphin [2]http://techbase.kde.org/KDE_System_Administration/XDG_Filesystem_Hierarchy#Thumbnails Diffs - kio/kio/previewjob.cpp 01b674d Diff: https://git.reviewboard.kde.org/r/110388/diff/ Testing --- Remove ~/.thumbnails/ Run dolphin with previews: thumbnails are created in .cache/thumbnails/ Repeated with XDG_CACHE_HOME=~/.cachetestdir/ Thumbnails in .cachetestdir/thumbnails/ Not tested: gwenview and digikam. Thanks, Maarten De Meyer
Re: Review Request 110388: Change default thumbnail cache directory
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110388/#review32905 --- Could I get an update on this? This is mostly working for me. Some thumbnailers need to be recompiled but there is no breakage if they use the old cache for now. If this change is to intrusive for frozen kdelibs I could make it frameworks only. (although it is a bugfix imho) - Maarten De Meyer On May 11, 2013, 2:40 p.m., Maarten De Meyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110388/ > --- > > (Updated May 11, 2013, 2:40 p.m.) > > > Review request for kdelibs. > > > Description > --- > > The freedesktop spec[0] has changed the default location of the thumbnail > cache directory. > Now thumbnails are saved in $XDG_CACHE_HOME/thumbnails instead of > ~/.thumbnails/ > GNOME has already made this change. > > Some applications[1] and documentation[2] (maybe thumbnailers) will have to > be changed to adapt to this new directory. If this patch is accepted I'll > make the needed changes. > For frameworks we can use QStandardPaths::CacheLocation, I'll post a separate > review for that. > > All thumbnails will have to be regenerated. We could symlink the directory? > Is fromLocal8Bit correct or is UTF8 needed now? > > [0] > http://specifications.freedesktop.org/thumbnail-spec/thumbnail-spec-latest.html > [1] configurepreviewdialog.cpp in Dolphin > [2]http://techbase.kde.org/KDE_System_Administration/XDG_Filesystem_Hierarchy#Thumbnails > > > This addresses bug 319528. > http://bugs.kde.org/show_bug.cgi?id=319528 > > > Diffs > - > > kio/kio/previewjob.cpp 01b674d > > Diff: http://git.reviewboard.kde.org/r/110388/diff/ > > > Testing > --- > > Remove ~/.thumbnails/ > Run dolphin with previews: thumbnails are created in .cache/thumbnails/ > > Repeated with XDG_CACHE_HOME=~/.cachetestdir/ > Thumbnails in .cachetestdir/thumbnails/ > > Not tested: gwenview and digikam. > > > Thanks, > > Maarten De Meyer > >
Review Request 110388: Change default thumbnail cache directory
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110388/ --- Review request for kdelibs. Description --- The freedesktop spec[0] has changed the default location of the thumbnail cache directory. Now thumbnails are saved in $XDG_CACHE_HOME/thumbnails instead of ~/.thumbnails/ GNOME has already made this change. Some applications[1] and documentation[2] (maybe thumbnailers) will have to be changed to adapt to this new directory. If this patch is accepted I'll make the needed changes. For frameworks we can use QStandardPaths::CacheLocation, I'll post a separate review for that. All thumbnails will have to be regenerated. We could symlink the directory? Is fromLocal8Bit correct or is UTF8 needed now? [0] http://specifications.freedesktop.org/thumbnail-spec/thumbnail-spec-latest.html [1] configurepreviewdialog.cpp in Dolphin [2]http://techbase.kde.org/KDE_System_Administration/XDG_Filesystem_Hierarchy#Thumbnails This addresses bug 319528. http://bugs.kde.org/show_bug.cgi?id=319528 Diffs - kio/kio/previewjob.cpp 01b674d Diff: http://git.reviewboard.kde.org/r/110388/diff/ Testing --- Remove ~/.thumbnails/ Run dolphin with previews: thumbnails are created in .cache/thumbnails/ Repeated with XDG_CACHE_HOME=~/.cachetestdir/ Thumbnails in .cachetestdir/thumbnails/ Not tested: gwenview and digikam. Thanks, Maarten De Meyer
