Re: Review Request 110649: add kimgio WebP image format plugin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110649/#review34706 --- This review has been submitted with commit cd2c23ee59461cfe4f70f43fa93513c7f7f72919 by Martin Koller to branch master. - Commit Hook On June 16, 2013, 11:58 a.m., Martin Koller wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110649/ --- (Updated June 16, 2013, 11:58 a.m.) Review request for KDE Runtime. Description --- This patch adds support for the new Google invented WebP image format. See https://developers.google.com/speed/webp/?hl=ru This is what was submitted before in https://git.reviewboard.kde.org/r/106300/ but it was suggested to move it to kde-runtime Diffs - CMakeLists.txt 9f1f886 kimgio/CMakeLists.txt PRE-CREATION kimgio/webp.cpp PRE-CREATION kimgio/webp.desktop PRE-CREATION kimgio/webp.h PRE-CREATION kimgio/webp.xml PRE-CREATION Diff: http://git.reviewboard.kde.org/r/110649/diff/ Testing --- some KDE apps, including read/write with a modified kolourpaint (to be able to change the quality) Thanks, Martin Koller
Re: Review Request 110649: add kimgio WebP image format plugin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110649/ --- (Updated June 19, 2013, 7:35 p.m.) Status -- This change has been marked as submitted. Review request for KDE Runtime. Description --- This patch adds support for the new Google invented WebP image format. See https://developers.google.com/speed/webp/?hl=ru This is what was submitted before in https://git.reviewboard.kde.org/r/106300/ but it was suggested to move it to kde-runtime Diffs - CMakeLists.txt 9f1f886 kimgio/CMakeLists.txt PRE-CREATION kimgio/webp.cpp PRE-CREATION kimgio/webp.desktop PRE-CREATION kimgio/webp.h PRE-CREATION kimgio/webp.xml PRE-CREATION Diff: http://git.reviewboard.kde.org/r/110649/diff/ Testing --- some KDE apps, including read/write with a modified kolourpaint (to be able to change the quality) Thanks, Martin Koller
Re: Review Request 110649: add kimgio WebP image format plugin
On June 16, 2013, 8:52 p.m., Fredrik Höglund wrote: Looks good to me. Maksim Orlovich suggested that we should look into using lossless WebP for images in KDE, since WebP has faster decompression than libpng, and produces smaller files. I've done some tests with Oxygen icons that confirms this. Small note for making WebP the default. Be sure to look at IZ since it seems to be a lot faster then WebP, smaller and even developed inhouse by kdepepo http://kdepepo.wordpress.com/2012/10/11/imagezero-5x-faster-than-webp/ - Mark --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110649/#review34447 --- On June 16, 2013, 11:58 a.m., Martin Koller wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110649/ --- (Updated June 16, 2013, 11:58 a.m.) Review request for KDE Runtime. Description --- This patch adds support for the new Google invented WebP image format. See https://developers.google.com/speed/webp/?hl=ru This is what was submitted before in https://git.reviewboard.kde.org/r/106300/ but it was suggested to move it to kde-runtime Diffs - CMakeLists.txt 9f1f886 kimgio/CMakeLists.txt PRE-CREATION kimgio/webp.cpp PRE-CREATION kimgio/webp.desktop PRE-CREATION kimgio/webp.h PRE-CREATION kimgio/webp.xml PRE-CREATION Diff: http://git.reviewboard.kde.org/r/110649/diff/ Testing --- some KDE apps, including read/write with a modified kolourpaint (to be able to change the quality) Thanks, Martin Koller
Re: Review Request 110649: add kimgio WebP image format plugin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110649/ --- (Updated June 16, 2013, 11:58 a.m.) Review request for KDE Runtime. Changes --- changed image decoding to directly read into memory owned by QImage Description --- This patch adds support for the new Google invented WebP image format. See https://developers.google.com/speed/webp/?hl=ru This is what was submitted before in https://git.reviewboard.kde.org/r/106300/ but it was suggested to move it to kde-runtime Diffs (updated) - CMakeLists.txt 9f1f886 kimgio/CMakeLists.txt PRE-CREATION kimgio/webp.cpp PRE-CREATION kimgio/webp.desktop PRE-CREATION kimgio/webp.h PRE-CREATION kimgio/webp.xml PRE-CREATION Diff: http://git.reviewboard.kde.org/r/110649/diff/ Testing --- some KDE apps, including read/write with a modified kolourpaint (to be able to change the quality) Thanks, Martin Koller
Re: Review Request 110649: add kimgio WebP image format plugin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110649/#review34447 --- Ship it! Looks good to me. Maksim Orlovich suggested that we should look into using lossless WebP for images in KDE, since WebP has faster decompression than libpng, and produces smaller files. I've done some tests with Oxygen icons that confirms this. - Fredrik Höglund On June 16, 2013, 11:58 a.m., Martin Koller wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110649/ --- (Updated June 16, 2013, 11:58 a.m.) Review request for KDE Runtime. Description --- This patch adds support for the new Google invented WebP image format. See https://developers.google.com/speed/webp/?hl=ru This is what was submitted before in https://git.reviewboard.kde.org/r/106300/ but it was suggested to move it to kde-runtime Diffs - CMakeLists.txt 9f1f886 kimgio/CMakeLists.txt PRE-CREATION kimgio/webp.cpp PRE-CREATION kimgio/webp.desktop PRE-CREATION kimgio/webp.h PRE-CREATION kimgio/webp.xml PRE-CREATION Diff: http://git.reviewboard.kde.org/r/110649/diff/ Testing --- some KDE apps, including read/write with a modified kolourpaint (to be able to change the quality) Thanks, Martin Koller
Review Request 110649: add kimgio WebP image format plugin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110649/ --- Review request for KDE Runtime. Description --- This patch adds support for the new Google invented WebP image format. See https://developers.google.com/speed/webp/?hl=ru This is what was submitted before in https://git.reviewboard.kde.org/r/106300/ but it was suggested to move it to kde-runtime Diffs - kimgio/webp.h PRE-CREATION kimgio/webp.xml PRE-CREATION kimgio/webp.desktop PRE-CREATION kimgio/CMakeLists.txt PRE-CREATION kimgio/webp.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/110649/diff/ Testing --- some KDE apps, including read/write with a modified kolourpaint (to be able to change the quality) Thanks, Martin Koller
Re: Review Request 110649: add kimgio WebP image format plugin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110649/ --- (Updated May 26, 2013, 12:20 p.m.) Review request for KDE Runtime. Description --- This patch adds support for the new Google invented WebP image format. See https://developers.google.com/speed/webp/?hl=ru This is what was submitted before in https://git.reviewboard.kde.org/r/106300/ but it was suggested to move it to kde-runtime Diffs - kimgio/webp.h PRE-CREATION kimgio/webp.xml PRE-CREATION kimgio/webp.desktop PRE-CREATION kimgio/CMakeLists.txt PRE-CREATION kimgio/webp.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/110649/diff/ Testing --- some KDE apps, including read/write with a modified kolourpaint (to be able to change the quality) Thanks, Martin Koller
Re: Review Request 110649: add kimgio WebP image format plugin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110649/#review33153 --- kimgio/webp.cpp http://git.reviewboard.kde.org/r/110649/#comment24527 This is not particularly efficient. WebPDecodeBGRAInto() can decode directly into a QImage without using an intermediate buffer. - Fredrik Höglund On May 26, 2013, 12:20 p.m., Martin Koller wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110649/ --- (Updated May 26, 2013, 12:20 p.m.) Review request for KDE Runtime. Description --- This patch adds support for the new Google invented WebP image format. See https://developers.google.com/speed/webp/?hl=ru This is what was submitted before in https://git.reviewboard.kde.org/r/106300/ but it was suggested to move it to kde-runtime Diffs - kimgio/webp.h PRE-CREATION kimgio/webp.xml PRE-CREATION kimgio/webp.desktop PRE-CREATION kimgio/CMakeLists.txt PRE-CREATION kimgio/webp.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/110649/diff/ Testing --- some KDE apps, including read/write with a modified kolourpaint (to be able to change the quality) Thanks, Martin Koller
Re: Review Request 110649: add kimgio WebP image format plugin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110649/#review33167 --- How is this hooked up to the rest of kde-runtime? - Albert Astals Cid On May 26, 2013, 12:20 p.m., Martin Koller wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110649/ --- (Updated May 26, 2013, 12:20 p.m.) Review request for KDE Runtime. Description --- This patch adds support for the new Google invented WebP image format. See https://developers.google.com/speed/webp/?hl=ru This is what was submitted before in https://git.reviewboard.kde.org/r/106300/ but it was suggested to move it to kde-runtime Diffs - kimgio/webp.h PRE-CREATION kimgio/webp.xml PRE-CREATION kimgio/webp.desktop PRE-CREATION kimgio/CMakeLists.txt PRE-CREATION kimgio/webp.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/110649/diff/ Testing --- some KDE apps, including read/write with a modified kolourpaint (to be able to change the quality) Thanks, Martin Koller
