Review Request 112258: ksysguard process list: better keyboard navigation

[Harald Hvaal]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112258/
---

Review request for kde-workspace.


Description
---

ksysguard has good keyboard handling, but it can be better. For example, it has 
annoyed me that I cannot use the del/shift-del shortcuts or get the context 
menu unless I explicitly tab my way down to the treeview (even though pressing 
up/down with the text field focused gives the false impression that the rows 
have focus).

This diff makes this keyboard navigation more efficient. While the comments in 
the code should describe the behavior well enough, here they are listed:

* Search field
** Pressing enter moves to first item in treeview and opens context menu
** Pressing down/pgdown will move actual focus to the treeview
** Focusing the text field clears the treeview selection. This emphasises that 
only one visual element is focused at a time, as well as that you can not 
interact with the items in the view until they have been selected.
* Treeview
** Pressing up when on the first entry will move focus to the text field
** If you start typing, the focus will immediately be moved to the text field
** When focus is received, select first row in the treeview


Diffs
-

  libs/ksysguard/processui/ksysguardprocesslist.cpp 
ed2c1ff4e93041e4b1911e2643bfda6888d171bd 

Diff: http://git.reviewboard.kde.org/r/112258/diff/


Testing
---


Thanks,

Harald Hvaal

Re: Review Request 112258: ksysguard process list: better keyboard navigation

[Harald Hvaal]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112258/
---

(Updated Sept. 1, 2013, 8:24 a.m.)


Review request for kde-workspace.


Changes
---

*bump*


Description (updated)
---

ksysguard has good keyboard handling, but it can be better. For example, it has 
annoyed me that I cannot use the del/shift-del shortcuts or get the context 
menu unless I explicitly tab my way down to the treeview (even though pressing 
up/down with the text field focused gives the false impression that the rows 
have focus).

This diff makes this keyboard navigation more efficient. While the comments in 
the code should describe the behavior well enough, here they are listed:

* Search field
** Pressing enter moves to first item in treeview and opens context menu
** Pressing down/pgdown will move actual focus to the treeview
** Focusing the text field clears the treeview selection. This emphasises that 
only one visual element is focused at a time, as well as that you can not 
interact with the items in the view until they have been selected.
* Treeview
** Pressing up when on the first entry will move focus to the text field
** If you start typing, the focus will immediately be moved to the text field
** When focus is received, select first row in the treeview


Diffs
-

  libs/ksysguard/processui/ksysguardprocesslist.cpp 
ed2c1ff4e93041e4b1911e2643bfda6888d171bd 

Diff: http://git.reviewboard.kde.org/r/112258/diff/


Testing
---


Thanks,

Harald Hvaal

Re: Review Request 112258: ksysguard process list: better keyboard navigation

[Harald Hvaal]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112258/
---

(Updated Oct. 2, 2013, 6:30 a.m.)


Review request for kde-workspace.


Repository: kde-workspace


Description (updated)
---

ksysguard has good keyboard handling, but it can be better. For example, it has 
annoyed me that I cannot use the del/shift-del shortcuts or get the context 
menu unless I explicitly tab my way down to the treeview (even though pressing 
up/down with the text field focused gives the false impression that the rows 
have focus).

This diff makes this keyboard navigation more efficient. While the comments in 
the code should describe the behavior well enough, here they are listed:

* Search field
** Pressing enter moves to first item in treeview and opens context menu
** Pressing down/pgdown will move actual focus to the treeview
** Focusing the text field clears the treeview selection. This emphasises that 
only one visual element is focused at a time, as well as that you can not 
interact with the items in the view until they have been selected.
* Treeview
** Pressing up when on the first entry will move focus to the text field
** If you start typing, the focus will immediately be moved to the text field
** When focus is received, select first row in the treeview


After bumping this twice already without responses, I'm thinking about pushing 
it as it is unlikely to cause much (if any) trouble.


Diffs
-

  libs/ksysguard/processui/ksysguardprocesslist.cpp 
ed2c1ff4e93041e4b1911e2643bfda6888d171bd 

Diff: http://git.reviewboard.kde.org/r/112258/diff/


Testing
---


Thanks,

Harald Hvaal

Re: Review Request 112258: ksysguard process list: better keyboard navigation

[Harald Hvaal]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112258/
---

(Updated Oct. 18, 2013, 7:29 a.m.)


Review request for kde-workspace.


Changes
---

bump


Repository: kde-workspace


Description
---

ksysguard has good keyboard handling, but it can be better. For example, it has 
annoyed me that I cannot use the del/shift-del shortcuts or get the context 
menu unless I explicitly tab my way down to the treeview (even though pressing 
up/down with the text field focused gives the false impression that the rows 
have focus).

This diff makes this keyboard navigation more efficient. While the comments in 
the code should describe the behavior well enough, here they are listed:

* Search field
** Pressing enter moves to first item in treeview and opens context menu
** Pressing down/pgdown will move actual focus to the treeview
** Focusing the text field clears the treeview selection. This emphasises that 
only one visual element is focused at a time, as well as that you can not 
interact with the items in the view until they have been selected.
* Treeview
** Pressing up when on the first entry will move focus to the text field
** If you start typing, the focus will immediately be moved to the text field
** When focus is received, select first row in the treeview


After bumping this twice already without responses, I'm thinking about pushing 
it as it is unlikely to cause much (if any) trouble.


Diffs
-

  libs/ksysguard/processui/ksysguardprocesslist.cpp 
ed2c1ff4e93041e4b1911e2643bfda6888d171bd 

Diff: http://git.reviewboard.kde.org/r/112258/diff/


Testing (updated)
---


Thanks,

Harald Hvaal

Re: Review Request 112258: ksysguard process list: better keyboard navigation

[Harald Hvaal]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112258/
---

(Updated Oct. 18, 2013, 7:41 a.m.)


Review request for kde-workspace and John Tapsell.


Repository: kde-workspace


Description
---

ksysguard has good keyboard handling, but it can be better. For example, it has 
annoyed me that I cannot use the del/shift-del shortcuts or get the context 
menu unless I explicitly tab my way down to the treeview (even though pressing 
up/down with the text field focused gives the false impression that the rows 
have focus).

This diff makes this keyboard navigation more efficient. While the comments in 
the code should describe the behavior well enough, here they are listed:

* Search field
** Pressing enter moves to first item in treeview and opens context menu
** Pressing down/pgdown will move actual focus to the treeview
** Focusing the text field clears the treeview selection. This emphasises that 
only one visual element is focused at a time, as well as that you can not 
interact with the items in the view until they have been selected.
* Treeview
** Pressing up when on the first entry will move focus to the text field
** If you start typing, the focus will immediately be moved to the text field
** When focus is received, select first row in the treeview


After bumping this twice already without responses, I'm thinking about pushing 
it as it is unlikely to cause much (if any) trouble.


Diffs
-

  libs/ksysguard/processui/ksysguardprocesslist.cpp 
ed2c1ff4e93041e4b1911e2643bfda6888d171bd 

Diff: http://git.reviewboard.kde.org/r/112258/diff/


Testing
---


Thanks,

Harald Hvaal

Re: Review Request 112258: ksysguard process list: better keyboard navigation

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112258/#review43187
---


This review has been submitted with commit 
f01c0f9afe13b4a7df4a1d2cbe57dc39c690d265 by Harald Hvaal to branch master.

- Commit Hook


On Oct. 18, 2013, 7:41 a.m., Harald Hvaal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112258/
> ---
> 
> (Updated Oct. 18, 2013, 7:41 a.m.)
> 
> 
> Review request for kde-workspace and John Tapsell.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> ---
> 
> ksysguard has good keyboard handling, but it can be better. For example, it 
> has annoyed me that I cannot use the del/shift-del shortcuts or get the 
> context menu unless I explicitly tab my way down to the treeview (even though 
> pressing up/down with the text field focused gives the false impression that 
> the rows have focus).
> 
> This diff makes this keyboard navigation more efficient. While the comments 
> in the code should describe the behavior well enough, here they are listed:
> 
> * Search field
> ** Pressing enter moves to first item in treeview and opens context menu
> ** Pressing down/pgdown will move actual focus to the treeview
> ** Focusing the text field clears the treeview selection. This emphasises 
> that only one visual element is focused at a time, as well as that you can 
> not interact with the items in the view until they have been selected.
> * Treeview
> ** Pressing up when on the first entry will move focus to the text field
> ** If you start typing, the focus will immediately be moved to the text field
> ** When focus is received, select first row in the treeview
> 
> 
> After bumping this twice already without responses, I'm thinking about 
> pushing it as it is unlikely to cause much (if any) trouble.
> 
> 
> Diffs
> -
> 
>   libs/ksysguard/processui/ksysguardprocesslist.cpp 
> ed2c1ff4e93041e4b1911e2643bfda6888d171bd 
> 
> Diff: http://git.reviewboard.kde.org/r/112258/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harald Hvaal
> 
>

Re: Review Request 112258: ksysguard process list: better keyboard navigation

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112258/#review43189
---


This review has been submitted with commit 
680cd78d80939d02a20b4d7470b663d08fd4056e by Harald Hvaal to branch master.

- Commit Hook


On Nov. 6, 2013, 7:07 p.m., Harald Hvaal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112258/
> ---
> 
> (Updated Nov. 6, 2013, 7:07 p.m.)
> 
> 
> Review request for kde-workspace and John Tapsell.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> ---
> 
> ksysguard has good keyboard handling, but it can be better. For example, it 
> has annoyed me that I cannot use the del/shift-del shortcuts or get the 
> context menu unless I explicitly tab my way down to the treeview (even though 
> pressing up/down with the text field focused gives the false impression that 
> the rows have focus).
> 
> This diff makes this keyboard navigation more efficient. While the comments 
> in the code should describe the behavior well enough, here they are listed:
> 
> * Search field
> ** Pressing enter moves to first item in treeview and opens context menu
> ** Pressing down/pgdown will move actual focus to the treeview
> ** Focusing the text field clears the treeview selection. This emphasises 
> that only one visual element is focused at a time, as well as that you can 
> not interact with the items in the view until they have been selected.
> * Treeview
> ** Pressing up when on the first entry will move focus to the text field
> ** If you start typing, the focus will immediately be moved to the text field
> ** When focus is received, select first row in the treeview
> 
> 
> After bumping this twice already without responses, I'm thinking about 
> pushing it as it is unlikely to cause much (if any) trouble.
> 
> 
> Diffs
> -
> 
>   libs/ksysguard/processui/ksysguardprocesslist.cpp 
> ed2c1ff4e93041e4b1911e2643bfda6888d171bd 
> 
> Diff: http://git.reviewboard.kde.org/r/112258/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harald Hvaal
> 
>

Re: Review Request 112258: ksysguard process list: better keyboard navigation

[Harald Hvaal]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112258/
---

(Updated Nov. 6, 2013, 7:07 p.m.)


Status
--

This change has been marked as submitted.


Review request for kde-workspace and John Tapsell.


Repository: kde-workspace


Description
---

ksysguard has good keyboard handling, but it can be better. For example, it has 
annoyed me that I cannot use the del/shift-del shortcuts or get the context 
menu unless I explicitly tab my way down to the treeview (even though pressing 
up/down with the text field focused gives the false impression that the rows 
have focus).

This diff makes this keyboard navigation more efficient. While the comments in 
the code should describe the behavior well enough, here they are listed:

* Search field
** Pressing enter moves to first item in treeview and opens context menu
** Pressing down/pgdown will move actual focus to the treeview
** Focusing the text field clears the treeview selection. This emphasises that 
only one visual element is focused at a time, as well as that you can not 
interact with the items in the view until they have been selected.
* Treeview
** Pressing up when on the first entry will move focus to the text field
** If you start typing, the focus will immediately be moved to the text field
** When focus is received, select first row in the treeview


After bumping this twice already without responses, I'm thinking about pushing 
it as it is unlikely to cause much (if any) trouble.


Diffs
-

  libs/ksysguard/processui/ksysguardprocesslist.cpp 
ed2c1ff4e93041e4b1911e2643bfda6888d171bd 

Diff: http://git.reviewboard.kde.org/r/112258/diff/


Testing
---


Thanks,

Harald Hvaal

Re: Review Request 112258: ksysguard process list: better keyboard navigation

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112258/#review53398
---


This review has been submitted with commit 
1860078de86311ce1df40e676ce288e1a5368c07 by Harald Hvaal to branch KDE/4.11.

- Commit Hook


On Nov. 6, 2013, 7:07 p.m., Harald Hvaal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/112258/
> ---
> 
> (Updated Nov. 6, 2013, 7:07 p.m.)
> 
> 
> Review request for kde-workspace and John Tapsell.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> ---
> 
> ksysguard has good keyboard handling, but it can be better. For example, it 
> has annoyed me that I cannot use the del/shift-del shortcuts or get the 
> context menu unless I explicitly tab my way down to the treeview (even though 
> pressing up/down with the text field focused gives the false impression that 
> the rows have focus).
> 
> This diff makes this keyboard navigation more efficient. While the comments 
> in the code should describe the behavior well enough, here they are listed:
> 
> * Search field
> ** Pressing enter moves to first item in treeview and opens context menu
> ** Pressing down/pgdown will move actual focus to the treeview
> ** Focusing the text field clears the treeview selection. This emphasises 
> that only one visual element is focused at a time, as well as that you can 
> not interact with the items in the view until they have been selected.
> * Treeview
> ** Pressing up when on the first entry will move focus to the text field
> ** If you start typing, the focus will immediately be moved to the text field
> ** When focus is received, select first row in the treeview
> 
> 
> After bumping this twice already without responses, I'm thinking about 
> pushing it as it is unlikely to cause much (if any) trouble.
> 
> 
> Diffs
> -
> 
>   libs/ksysguard/processui/ksysguardprocesslist.cpp 
> ed2c1ff4e93041e4b1911e2643bfda6888d171bd 
> 
> Diff: https://git.reviewboard.kde.org/r/112258/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harald Hvaal
> 
>

Re: Review Request 112258: ksysguard process list: better keyboard navigation

[Christoph Feck]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112258/#review58426
---


This probably causes bug 335177.

- Christoph Feck


On Nov. 6, 2013, 7:07 p.m., Harald Hvaal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/112258/
> ---
> 
> (Updated Nov. 6, 2013, 7:07 p.m.)
> 
> 
> Review request for kde-workspace and John Tapsell.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> ---
> 
> ksysguard has good keyboard handling, but it can be better. For example, it 
> has annoyed me that I cannot use the del/shift-del shortcuts or get the 
> context menu unless I explicitly tab my way down to the treeview (even though 
> pressing up/down with the text field focused gives the false impression that 
> the rows have focus).
> 
> This diff makes this keyboard navigation more efficient. While the comments 
> in the code should describe the behavior well enough, here they are listed:
> 
> * Search field
> ** Pressing enter moves to first item in treeview and opens context menu
> ** Pressing down/pgdown will move actual focus to the treeview
> ** Focusing the text field clears the treeview selection. This emphasises 
> that only one visual element is focused at a time, as well as that you can 
> not interact with the items in the view until they have been selected.
> * Treeview
> ** Pressing up when on the first entry will move focus to the text field
> ** If you start typing, the focus will immediately be moved to the text field
> ** When focus is received, select first row in the treeview
> 
> 
> After bumping this twice already without responses, I'm thinking about 
> pushing it as it is unlikely to cause much (if any) trouble.
> 
> 
> Diffs
> -
> 
>   libs/ksysguard/processui/ksysguardprocesslist.cpp 
> ed2c1ff4e93041e4b1911e2643bfda6888d171bd 
> 
> Diff: https://git.reviewboard.kde.org/r/112258/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harald Hvaal
> 
>

Re: Review Request 112258: ksysguard process list: better keyboard navigation

[Thomas Lübking]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112258/#review58564
---



libs/ksysguard/processui/ksysguardprocesslist.cpp


ctrl+a will generate two key events, the second is not empty (though not 
printable string either)

-> (!(keyEvent->modifiers() & 
(Qt::ControlModifier|Qt::AltModifier|Qt::MetaModifier) && ...


- Thomas Lübking


On Nov. 6, 2013, 7:07 p.m., Harald Hvaal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/112258/
> ---
> 
> (Updated Nov. 6, 2013, 7:07 p.m.)
> 
> 
> Review request for kde-workspace and John Tapsell.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> ---
> 
> ksysguard has good keyboard handling, but it can be better. For example, it 
> has annoyed me that I cannot use the del/shift-del shortcuts or get the 
> context menu unless I explicitly tab my way down to the treeview (even though 
> pressing up/down with the text field focused gives the false impression that 
> the rows have focus).
> 
> This diff makes this keyboard navigation more efficient. While the comments 
> in the code should describe the behavior well enough, here they are listed:
> 
> * Search field
> ** Pressing enter moves to first item in treeview and opens context menu
> ** Pressing down/pgdown will move actual focus to the treeview
> ** Focusing the text field clears the treeview selection. This emphasises 
> that only one visual element is focused at a time, as well as that you can 
> not interact with the items in the view until they have been selected.
> * Treeview
> ** Pressing up when on the first entry will move focus to the text field
> ** If you start typing, the focus will immediately be moved to the text field
> ** When focus is received, select first row in the treeview
> 
> 
> After bumping this twice already without responses, I'm thinking about 
> pushing it as it is unlikely to cause much (if any) trouble.
> 
> 
> Diffs
> -
> 
>   libs/ksysguard/processui/ksysguardprocesslist.cpp 
> ed2c1ff4e93041e4b1911e2643bfda6888d171bd 
> 
> Diff: https://git.reviewboard.kde.org/r/112258/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harald Hvaal
> 
>