Review Request 112528: Make it possible to preserve mtime for copy jobs not just move ones
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112528/ --- Review request for kdelibs and David Faure. Description --- This patch changes the current logic outlined at https://bugs.kde.org/show_bug.cgi?id=55804#c48 such that the copy/paste operations will also preserve the mtime. I have no idea why I chose to only not to send the "modified" meta-data for COPY requests. There really is no good reason for it and it is inconsistent with what kio_file does for local file copy operations. This addresses bug 55804. http://bugs.kde.org/show_bug.cgi?id=55804 Diffs - kio/kio/job.cpp 8ff088c Diff: http://git.reviewboard.kde.org/r/112528/diff/ Testing --- Thanks, Dawit Alemayehu
Re: Review Request 112528: Make it possible to preserve mtime for copy jobs not just move ones
> Diffs > - > > kio/kio/job.cpp 8ff088c > > Diff: http://git.reviewboard.kde.org/r/112528/diff/ Is it reviewboard fooling me or is there no diff? Eike signature.asc Description: This is a digitally signed message part.
Re: Review Request 112528: Make it possible to preserve mtime for copy jobs not just move ones
Am Donnerstag 05 September 2013, 08:43:48 schrieb Rolf Eike Beer: > > Diffs > > - > > > > kio/kio/job.cpp 8ff088c > > > > Diff: http://git.reviewboard.kde.org/r/112528/diff/ > > Is it reviewboard fooling me or is there no diff? This one does exist, I sent the mail for the wrong RR: http://git.reviewboard.kde.org/r/112529/diff/ This does not exist. Eike signature.asc Description: This is a digitally signed message part.
Re: Review Request 112528: Make it possible to preserve mtime for copy jobs not just move ones
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112528/#review39398 --- Ship it! Ship It! - David Faure On Sept. 5, 2013, 2:52 a.m., Dawit Alemayehu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112528/ > --- > > (Updated Sept. 5, 2013, 2:52 a.m.) > > > Review request for kdelibs and David Faure. > > > Description > --- > > This patch changes the current logic outlined at > https://bugs.kde.org/show_bug.cgi?id=55804#c48 such that the copy/paste > operations will also preserve the mtime. I have no idea why I chose to only > not to send the "modified" meta-data for COPY requests. There really is no > good reason for it and it is inconsistent with what kio_file does for local > file copy operations. > > > This addresses bug 55804. > http://bugs.kde.org/show_bug.cgi?id=55804 > > > Diffs > - > > kio/kio/job.cpp 8ff088c > > Diff: http://git.reviewboard.kde.org/r/112528/diff/ > > > Testing > --- > > > Thanks, > > Dawit Alemayehu > >
Re: Review Request 112528: Make it possible to preserve mtime for copy jobs not just move ones
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112528/#review39413 --- This review has been submitted with commit ef3de4a99c3af0557f51afe61e30addb592f2d4a by Dawit Alemayehu to branch KDE/4.11. - Commit Hook On Sept. 5, 2013, 2:52 a.m., Dawit Alemayehu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112528/ > --- > > (Updated Sept. 5, 2013, 2:52 a.m.) > > > Review request for kdelibs and David Faure. > > > Description > --- > > This patch changes the current logic outlined at > https://bugs.kde.org/show_bug.cgi?id=55804#c48 such that the copy/paste > operations will also preserve the mtime. I have no idea why I chose to only > not to send the "modified" meta-data for COPY requests. There really is no > good reason for it and it is inconsistent with what kio_file does for local > file copy operations. > > > This addresses bug 55804. > http://bugs.kde.org/show_bug.cgi?id=55804 > > > Diffs > - > > kio/kio/job.cpp 8ff088c > > Diff: http://git.reviewboard.kde.org/r/112528/diff/ > > > Testing > --- > > > Thanks, > > Dawit Alemayehu > >
Re: Review Request 112528: Make it possible to preserve mtime for copy jobs not just move ones
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112528/ --- (Updated Sept. 5, 2013, 1:29 p.m.) Status -- This change has been marked as submitted. Review request for kdelibs and David Faure. Description --- This patch changes the current logic outlined at https://bugs.kde.org/show_bug.cgi?id=55804#c48 such that the copy/paste operations will also preserve the mtime. I have no idea why I chose to only not to send the "modified" meta-data for COPY requests. There really is no good reason for it and it is inconsistent with what kio_file does for local file copy operations. This addresses bug 55804. http://bugs.kde.org/show_bug.cgi?id=55804 Diffs - kio/kio/job.cpp 8ff088c Diff: http://git.reviewboard.kde.org/r/112528/diff/ Testing --- Thanks, Dawit Alemayehu
