Re: Review Request 114841: Screenlocker: don't set the mouse cursor when grabbing the mouse
> On Jan. 8, 2014, 8:10 a.m., Martin Gräßlin wrote: > > If you have the possibility (build setup) please merge to master and fix > > the merge conflict I expect to see :-) I merged 4.11 into master yesterday > > so there should no be anything else which could conflict. > > Wolfgang Bauer wrote: > I have committed to 4.11, but I don't have a KF5/PW2 build setup at the > moment. > > Martin Gräßlin wrote: > I just merged it to master and pushed as > http://commits.kde.org/kde-workspace/98768f680480df64a60fbe1802ca8ee05fb28887 OK, thank you! - Wolfgang --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114841/#review47020 --- On Jan. 8, 2014, 9:59 a.m., Wolfgang Bauer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114841/ > --- > > (Updated Jan. 8, 2014, 9:59 a.m.) > > > Review request for kde-workspace and Martin Gräßlin. > > > Bugs: 311571 and 316459 > http://bugs.kde.org/show_bug.cgi?id=311571 > http://bugs.kde.org/show_bug.cgi?id=316459 > > > Repository: kde-workspace > > > Description > --- > > Setting the cursor to ArrowCursor when calling XGrabPointer() prevents the > Screen savers from blanking the mouse cursor. > > I don't know why this has been done in the first place, but I couldn't see > any negative effect by setting it to None. Now the mouse cursor even changes > to the IBeam again when over the password field, which I find more intuitive. > > > Diffs > - > > ksmserver/screenlocker/ksldapp.cpp f0526cf > > Diff: https://git.reviewboard.kde.org/r/114841/diff/ > > > Testing > --- > > Configure a Screen saver in systemsettings and wait for it to kick in (or > lock the screen manually). > Previously (since 4.10) the mouse cursor stayed visible, now it is blanked > like it was the case before 4.10. > Moving the mouse/pressing a key (to quit the Screen saver) makes the mouse > cursor appear again as it should, regardless of whether the screen is locked > or not. > > > Thanks, > > Wolfgang Bauer > >
Re: Review Request 114841: Screenlocker: don't set the mouse cursor when grabbing the mouse
> On Jan. 8, 2014, 8:10 a.m., Martin Gräßlin wrote: > > If you have the possibility (build setup) please merge to master and fix > > the merge conflict I expect to see :-) I merged 4.11 into master yesterday > > so there should no be anything else which could conflict. > > Wolfgang Bauer wrote: > I have committed to 4.11, but I don't have a KF5/PW2 build setup at the > moment. I just merged it to master and pushed as http://commits.kde.org/kde-workspace/98768f680480df64a60fbe1802ca8ee05fb28887 - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114841/#review47020 --- On Jan. 8, 2014, 9:59 a.m., Wolfgang Bauer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114841/ > --- > > (Updated Jan. 8, 2014, 9:59 a.m.) > > > Review request for kde-workspace and Martin Gräßlin. > > > Bugs: 311571 and 316459 > http://bugs.kde.org/show_bug.cgi?id=311571 > http://bugs.kde.org/show_bug.cgi?id=316459 > > > Repository: kde-workspace > > > Description > --- > > Setting the cursor to ArrowCursor when calling XGrabPointer() prevents the > Screen savers from blanking the mouse cursor. > > I don't know why this has been done in the first place, but I couldn't see > any negative effect by setting it to None. Now the mouse cursor even changes > to the IBeam again when over the password field, which I find more intuitive. > > > Diffs > - > > ksmserver/screenlocker/ksldapp.cpp f0526cf > > Diff: https://git.reviewboard.kde.org/r/114841/diff/ > > > Testing > --- > > Configure a Screen saver in systemsettings and wait for it to kick in (or > lock the screen manually). > Previously (since 4.10) the mouse cursor stayed visible, now it is blanked > like it was the case before 4.10. > Moving the mouse/pressing a key (to quit the Screen saver) makes the mouse > cursor appear again as it should, regardless of whether the screen is locked > or not. > > > Thanks, > > Wolfgang Bauer > >
Re: Review Request 114841: Screenlocker: don't set the mouse cursor when grabbing the mouse
> On Jan. 8, 2014, 8:10 a.m., Martin Gräßlin wrote: > > If you have the possibility (build setup) please merge to master and fix > > the merge conflict I expect to see :-) I merged 4.11 into master yesterday > > so there should no be anything else which could conflict. I have committed to 4.11, but I don't have a KF5/PW2 build setup at the moment. - Wolfgang --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114841/#review47020 --- On Jan. 8, 2014, 9:59 a.m., Wolfgang Bauer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114841/ > --- > > (Updated Jan. 8, 2014, 9:59 a.m.) > > > Review request for kde-workspace and Martin Gräßlin. > > > Bugs: 311571 and 316459 > http://bugs.kde.org/show_bug.cgi?id=311571 > http://bugs.kde.org/show_bug.cgi?id=316459 > > > Repository: kde-workspace > > > Description > --- > > Setting the cursor to ArrowCursor when calling XGrabPointer() prevents the > Screen savers from blanking the mouse cursor. > > I don't know why this has been done in the first place, but I couldn't see > any negative effect by setting it to None. Now the mouse cursor even changes > to the IBeam again when over the password field, which I find more intuitive. > > > Diffs > - > > ksmserver/screenlocker/ksldapp.cpp f0526cf > > Diff: https://git.reviewboard.kde.org/r/114841/diff/ > > > Testing > --- > > Configure a Screen saver in systemsettings and wait for it to kick in (or > lock the screen manually). > Previously (since 4.10) the mouse cursor stayed visible, now it is blanked > like it was the case before 4.10. > Moving the mouse/pressing a key (to quit the Screen saver) makes the mouse > cursor appear again as it should, regardless of whether the screen is locked > or not. > > > Thanks, > > Wolfgang Bauer > >
Re: Review Request 114841: Screenlocker: don't set the mouse cursor when grabbing the mouse
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114841/ --- (Updated Jan. 8, 2014, 8:59 a.m.) Status -- This change has been marked as submitted. Review request for kde-workspace and Martin Gräßlin. Bugs: 311571 and 316459 http://bugs.kde.org/show_bug.cgi?id=311571 http://bugs.kde.org/show_bug.cgi?id=316459 Repository: kde-workspace Description --- Setting the cursor to ArrowCursor when calling XGrabPointer() prevents the Screen savers from blanking the mouse cursor. I don't know why this has been done in the first place, but I couldn't see any negative effect by setting it to None. Now the mouse cursor even changes to the IBeam again when over the password field, which I find more intuitive. Diffs - ksmserver/screenlocker/ksldapp.cpp f0526cf Diff: https://git.reviewboard.kde.org/r/114841/diff/ Testing --- Configure a Screen saver in systemsettings and wait for it to kick in (or lock the screen manually). Previously (since 4.10) the mouse cursor stayed visible, now it is blanked like it was the case before 4.10. Moving the mouse/pressing a key (to quit the Screen saver) makes the mouse cursor appear again as it should, regardless of whether the screen is locked or not. Thanks, Wolfgang Bauer
Re: Review Request 114841: Screenlocker: don't set the mouse cursor when grabbing the mouse
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114841/#review47023 --- This review has been submitted with commit c1761755915ab59f418b801a6901230f67877047 by Wolfgang Bauer to branch KDE/4.11. - Commit Hook On Jan. 5, 2014, 8:55 a.m., Wolfgang Bauer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114841/ > --- > > (Updated Jan. 5, 2014, 8:55 a.m.) > > > Review request for kde-workspace and Martin Gräßlin. > > > Bugs: 311571 and 316459 > http://bugs.kde.org/show_bug.cgi?id=311571 > http://bugs.kde.org/show_bug.cgi?id=316459 > > > Repository: kde-workspace > > > Description > --- > > Setting the cursor to ArrowCursor when calling XGrabPointer() prevents the > Screen savers from blanking the mouse cursor. > > I don't know why this has been done in the first place, but I couldn't see > any negative effect by setting it to None. Now the mouse cursor even changes > to the IBeam again when over the password field, which I find more intuitive. > > > Diffs > - > > ksmserver/screenlocker/ksldapp.cpp f0526cf > > Diff: https://git.reviewboard.kde.org/r/114841/diff/ > > > Testing > --- > > Configure a Screen saver in systemsettings and wait for it to kick in (or > lock the screen manually). > Previously (since 4.10) the mouse cursor stayed visible, now it is blanked > like it was the case before 4.10. > Moving the mouse/pressing a key (to quit the Screen saver) makes the mouse > cursor appear again as it should, regardless of whether the screen is locked > or not. > > > Thanks, > > Wolfgang Bauer > >
Re: Review Request 114841: Screenlocker: don't set the mouse cursor when grabbing the mouse
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114841/#review47020 --- Ship it! If you have the possibility (build setup) please merge to master and fix the merge conflict I expect to see :-) I merged 4.11 into master yesterday so there should no be anything else which could conflict. - Martin Gräßlin On Jan. 5, 2014, 9:55 a.m., Wolfgang Bauer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114841/ > --- > > (Updated Jan. 5, 2014, 9:55 a.m.) > > > Review request for kde-workspace and Martin Gräßlin. > > > Bugs: 311571 and 316459 > http://bugs.kde.org/show_bug.cgi?id=311571 > http://bugs.kde.org/show_bug.cgi?id=316459 > > > Repository: kde-workspace > > > Description > --- > > Setting the cursor to ArrowCursor when calling XGrabPointer() prevents the > Screen savers from blanking the mouse cursor. > > I don't know why this has been done in the first place, but I couldn't see > any negative effect by setting it to None. Now the mouse cursor even changes > to the IBeam again when over the password field, which I find more intuitive. > > > Diffs > - > > ksmserver/screenlocker/ksldapp.cpp f0526cf > > Diff: https://git.reviewboard.kde.org/r/114841/diff/ > > > Testing > --- > > Configure a Screen saver in systemsettings and wait for it to kick in (or > lock the screen manually). > Previously (since 4.10) the mouse cursor stayed visible, now it is blanked > like it was the case before 4.10. > Moving the mouse/pressing a key (to quit the Screen saver) makes the mouse > cursor appear again as it should, regardless of whether the screen is locked > or not. > > > Thanks, > > Wolfgang Bauer > >
Re: Review Request 114841: Screenlocker: don't set the mouse cursor when grabbing the mouse
> On Jan. 7, 2014, 9:51 a.m., Martin Gräßlin wrote: > > how does that behave with the normal locker (that is no screensaver)? > > Thomas Lübking wrote: > "None" is not "blank" - the patch is correct. > > If a cursor is specified, it is displayed regardless of what window the > pointer is in. If None is specified, the normal cursor for that window is > displayed when the pointer is in grab_window or one of its subwindows; > otherwise, the cursor for grab_window is displayed. > --- http://tronche.com/gui/x/xlib/input/XGrabPointer.html > > Since the screenlocker qml window (nor the batterysucking fancy show) is > not the grab_window, both will initially get the default cursor of the > grab_window (atm. the left_arrow) and not receive mouse events (so w/ or w/o > the patch, the qml locker will not display an I-beam when hovering the > lineedit - at least not here, one would have to poll the mouse for this and > don't you dare* ;-) > > W/o an explicit grab_cursor, it however should be possible (never tested, > but seems the case given the patch) to alter the cursor shape from other > clients at any time (because it's not important for the grabbing client) > > * unless we make use of http://keithp.com/blogs/Cursor_tracking/ for PW/2 With the normal locker, I see no change in behaviour as well. The mouse cursor doesn't change, even when hovering over the password input field. If a screen saver is configured, the mouse cursor will change to the IBeam (i.e. text input) shape over the password field. But just to clarify: this is intended for the 4.11 branch only. Xscreensaver support is dropped for PW/2 anyway, right? - Wolfgang --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114841/#review46960 --- On Jan. 5, 2014, 9:55 a.m., Wolfgang Bauer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114841/ > --- > > (Updated Jan. 5, 2014, 9:55 a.m.) > > > Review request for kde-workspace and Martin Gräßlin. > > > Bugs: 311571 and 316459 > http://bugs.kde.org/show_bug.cgi?id=311571 > http://bugs.kde.org/show_bug.cgi?id=316459 > > > Repository: kde-workspace > > > Description > --- > > Setting the cursor to ArrowCursor when calling XGrabPointer() prevents the > Screen savers from blanking the mouse cursor. > > I don't know why this has been done in the first place, but I couldn't see > any negative effect by setting it to None. Now the mouse cursor even changes > to the IBeam again when over the password field, which I find more intuitive. > > > Diffs > - > > ksmserver/screenlocker/ksldapp.cpp f0526cf > > Diff: https://git.reviewboard.kde.org/r/114841/diff/ > > > Testing > --- > > Configure a Screen saver in systemsettings and wait for it to kick in (or > lock the screen manually). > Previously (since 4.10) the mouse cursor stayed visible, now it is blanked > like it was the case before 4.10. > Moving the mouse/pressing a key (to quit the Screen saver) makes the mouse > cursor appear again as it should, regardless of whether the screen is locked > or not. > > > Thanks, > > Wolfgang Bauer > >
Re: Review Request 114841: Screenlocker: don't set the mouse cursor when grabbing the mouse
> On Jan. 7, 2014, 8:51 a.m., Martin Gräßlin wrote: > > how does that behave with the normal locker (that is no screensaver)? "None" is not "blank" - the patch is correct. If a cursor is specified, it is displayed regardless of what window the pointer is in. If None is specified, the normal cursor for that window is displayed when the pointer is in grab_window or one of its subwindows; otherwise, the cursor for grab_window is displayed. --- http://tronche.com/gui/x/xlib/input/XGrabPointer.html Since the screenlocker qml window (nor the batterysucking fancy show) is not the grab_window, both will initially get the default cursor of the grab_window (atm. the left_arrow) and not receive mouse events (so w/ or w/o the patch, the qml locker will not display an I-beam when hovering the lineedit - at least not here, one would have to poll the mouse for this and don't you dare* ;-) W/o an explicit grab_cursor, it however should be possible (never tested, but seems the case given the patch) to alter the cursor shape from other clients at any time (because it's not important for the grabbing client) * unless we make use of http://keithp.com/blogs/Cursor_tracking/ for PW/2 - Thomas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114841/#review46960 --- On Jan. 5, 2014, 8:55 a.m., Wolfgang Bauer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114841/ > --- > > (Updated Jan. 5, 2014, 8:55 a.m.) > > > Review request for kde-workspace and Martin Gräßlin. > > > Bugs: 311571 and 316459 > http://bugs.kde.org/show_bug.cgi?id=311571 > http://bugs.kde.org/show_bug.cgi?id=316459 > > > Repository: kde-workspace > > > Description > --- > > Setting the cursor to ArrowCursor when calling XGrabPointer() prevents the > Screen savers from blanking the mouse cursor. > > I don't know why this has been done in the first place, but I couldn't see > any negative effect by setting it to None. Now the mouse cursor even changes > to the IBeam again when over the password field, which I find more intuitive. > > > Diffs > - > > ksmserver/screenlocker/ksldapp.cpp f0526cf > > Diff: https://git.reviewboard.kde.org/r/114841/diff/ > > > Testing > --- > > Configure a Screen saver in systemsettings and wait for it to kick in (or > lock the screen manually). > Previously (since 4.10) the mouse cursor stayed visible, now it is blanked > like it was the case before 4.10. > Moving the mouse/pressing a key (to quit the Screen saver) makes the mouse > cursor appear again as it should, regardless of whether the screen is locked > or not. > > > Thanks, > > Wolfgang Bauer > >
Re: Review Request 114841: Screenlocker: don't set the mouse cursor when grabbing the mouse
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114841/#review46960 --- how does that behave with the normal locker (that is no screensaver)? - Martin Gräßlin On Jan. 5, 2014, 9:55 a.m., Wolfgang Bauer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114841/ > --- > > (Updated Jan. 5, 2014, 9:55 a.m.) > > > Review request for kde-workspace and Martin Gräßlin. > > > Bugs: 311571 and 316459 > http://bugs.kde.org/show_bug.cgi?id=311571 > http://bugs.kde.org/show_bug.cgi?id=316459 > > > Repository: kde-workspace > > > Description > --- > > Setting the cursor to ArrowCursor when calling XGrabPointer() prevents the > Screen savers from blanking the mouse cursor. > > I don't know why this has been done in the first place, but I couldn't see > any negative effect by setting it to None. Now the mouse cursor even changes > to the IBeam again when over the password field, which I find more intuitive. > > > Diffs > - > > ksmserver/screenlocker/ksldapp.cpp f0526cf > > Diff: https://git.reviewboard.kde.org/r/114841/diff/ > > > Testing > --- > > Configure a Screen saver in systemsettings and wait for it to kick in (or > lock the screen manually). > Previously (since 4.10) the mouse cursor stayed visible, now it is blanked > like it was the case before 4.10. > Moving the mouse/pressing a key (to quit the Screen saver) makes the mouse > cursor appear again as it should, regardless of whether the screen is locked > or not. > > > Thanks, > > Wolfgang Bauer > >
Review Request 114841: Screenlocker: don't set the mouse cursor when grabbing the mouse
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114841/ --- Review request for kde-workspace and Martin Gräßlin. Bugs: 311571 and 316459 http://bugs.kde.org/show_bug.cgi?id=311571 http://bugs.kde.org/show_bug.cgi?id=316459 Repository: kde-workspace Description --- Setting the cursor to ArrowCursor when calling XGrabPointer() prevents the Screen savers from blanking the mouse cursor. I don't know why this has been done in the first place, but I couldn't see any negative effect by setting it to None. Now the mouse cursor even changes to the IBeam again when over the password field, which I find more intuitive. Diffs - ksmserver/screenlocker/ksldapp.cpp f0526cf Diff: https://git.reviewboard.kde.org/r/114841/diff/ Testing --- Configure a Screen saver in systemsettings and wait for it to kick in (or lock the screen manually). Previously (since 4.10) the mouse cursor stayed visible, now it is blanked like it was the case before 4.10. Moving the mouse/pressing a key (to quit the Screen saver) makes the mouse cursor appear again as it should, regardless of whether the screen is locked or not. Thanks, Wolfgang Bauer
