Review Request 117088: Rename kuiserver to kuiserver5 for co-installability with kdelibs4 kde-runtime
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117088/ --- Review request for KDE Runtime and Aleix Pol Gonzalez. Repository: kde-runtime Description --- Rename kuiserver to kuiserver5 for co-installability with kdelibs4 kde-runtime (dbus docs say the name of a .service file is arbitrary) Diffs - kuiserver/CMakeLists.txt a724326 kuiserver/kf5_org.kde.kuiserver.service.in PRE-CREATION kuiserver/kuiserver.desktop 2d7a874 kuiserver/org.kde.kuiserver.service.in a900b64 Diff: https://git.reviewboard.kde.org/r/117088/diff/ Testing --- Thanks, Jonathan Riddell
Re: Review Request 117088: Rename kuiserver to kuiserver5 for co-installability with kdelibs4 kde-runtime
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117088/#review54206 --- >(dbus docs say the name of a .service file is arbitrary) it is. however, with this solution, user will never know (i.e. predict) will kuiserver, or kuiserver5 be started - unless you also change the name (not filename) of the service. that will however then need adjusting in 'downstream' consumers of kuiserver - Hrvoje Senjan On March 26, 2014, 2:03 p.m., Jonathan Riddell wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117088/ > --- > > (Updated March 26, 2014, 2:03 p.m.) > > > Review request for KDE Runtime and Aleix Pol Gonzalez. > > > Repository: kde-runtime > > > Description > --- > > Rename kuiserver to kuiserver5 for co-installability with kdelibs4 kde-runtime > (dbus docs say the name of a .service file is arbitrary) > > > Diffs > - > > kuiserver/CMakeLists.txt a724326 > kuiserver/kf5_org.kde.kuiserver.service.in PRE-CREATION > kuiserver/kuiserver.desktop 2d7a874 > kuiserver/org.kde.kuiserver.service.in a900b64 > > Diff: https://git.reviewboard.kde.org/r/117088/diff/ > > > Testing > --- > > > Thanks, > > Jonathan Riddell > >
Re: Review Request 117088: Rename kuiserver to kuiserver5 for co-installability with kdelibs4 kde-runtime
> On March 26, 2014, 2:29 p.m., Hrvoje Senjan wrote: > > >(dbus docs say the name of a .service file is arbitrary) > > it is. however, with this solution, user will never know (i.e. predict) > > will kuiserver, or kuiserver5 be started - unless you also change the name > > (not filename) of the service. that will however then need adjusting in > > 'downstream' consumers of kuiserver But then it won't be compatible between uses in kdelibs4 land and users in kf5 land. - Jonathan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117088/#review54206 --- On March 26, 2014, 2:03 p.m., Jonathan Riddell wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117088/ > --- > > (Updated March 26, 2014, 2:03 p.m.) > > > Review request for KDE Runtime and Aleix Pol Gonzalez. > > > Repository: kde-runtime > > > Description > --- > > Rename kuiserver to kuiserver5 for co-installability with kdelibs4 kde-runtime > (dbus docs say the name of a .service file is arbitrary) > > > Diffs > - > > kuiserver/CMakeLists.txt a724326 > kuiserver/kf5_org.kde.kuiserver.service.in PRE-CREATION > kuiserver/kuiserver.desktop 2d7a874 > kuiserver/org.kde.kuiserver.service.in a900b64 > > Diff: https://git.reviewboard.kde.org/r/117088/diff/ > > > Testing > --- > > > Thanks, > > Jonathan Riddell > >
Re: Review Request 117088: Rename kuiserver to kuiserver5 for co-installability with kdelibs4 kde-runtime
> On March 26, 2014, 2:29 p.m., Hrvoje Senjan wrote: > > >(dbus docs say the name of a .service file is arbitrary) > > it is. however, with this solution, user will never know (i.e. predict) > > will kuiserver, or kuiserver5 be started - unless you also change the name > > (not filename) of the service. that will however then need adjusting in > > 'downstream' consumers of kuiserver > > Jonathan Riddell wrote: > But then it won't be compatible between uses in kdelibs4 land and users > in kf5 land. > kuiserver would have to be a proxy that detects the current environment and launch the proper variant (like qt-chooser)? - Thomas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117088/#review54206 --- On March 26, 2014, 2:03 p.m., Jonathan Riddell wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117088/ > --- > > (Updated March 26, 2014, 2:03 p.m.) > > > Review request for KDE Runtime and Aleix Pol Gonzalez. > > > Repository: kde-runtime > > > Description > --- > > Rename kuiserver to kuiserver5 for co-installability with kdelibs4 kde-runtime > (dbus docs say the name of a .service file is arbitrary) > > > Diffs > - > > kuiserver/CMakeLists.txt a724326 > kuiserver/kf5_org.kde.kuiserver.service.in PRE-CREATION > kuiserver/kuiserver.desktop 2d7a874 > kuiserver/org.kde.kuiserver.service.in a900b64 > > Diff: https://git.reviewboard.kde.org/r/117088/diff/ > > > Testing > --- > > > Thanks, > > Jonathan Riddell > >
Re: Review Request 117088: Rename kuiserver to kuiserver5 for co-installability with kdelibs4 kde-runtime
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117088/#review56960 --- obsoleted by https://git.reviewboard.kde.org/r/117876/ - Jonathan Riddell On March 26, 2014, 2:03 p.m., Jonathan Riddell wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117088/ > --- > > (Updated March 26, 2014, 2:03 p.m.) > > > Review request for KDE Runtime and Aleix Pol Gonzalez. > > > Repository: kde-runtime > > > Description > --- > > Rename kuiserver to kuiserver5 for co-installability with kdelibs4 kde-runtime > (dbus docs say the name of a .service file is arbitrary) > > > Diffs > - > > kuiserver/CMakeLists.txt a724326 > kuiserver/kf5_org.kde.kuiserver.service.in PRE-CREATION > kuiserver/kuiserver.desktop 2d7a874 > kuiserver/org.kde.kuiserver.service.in a900b64 > > Diff: https://git.reviewboard.kde.org/r/117088/diff/ > > > Testing > --- > > > Thanks, > > Jonathan Riddell > >
Re: Review Request 117088: Rename kuiserver to kuiserver5 for co-installability with kdelibs4 kde-runtime
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117088/ --- (Updated April 30, 2014, 10:02 a.m.) Status -- This change has been discarded. Review request for KDE Runtime and Aleix Pol Gonzalez. Repository: kde-runtime Description --- Rename kuiserver to kuiserver5 for co-installability with kdelibs4 kde-runtime (dbus docs say the name of a .service file is arbitrary) Diffs - kuiserver/CMakeLists.txt a724326 kuiserver/kf5_org.kde.kuiserver.service.in PRE-CREATION kuiserver/kuiserver.desktop 2d7a874 kuiserver/org.kde.kuiserver.service.in a900b64 Diff: https://git.reviewboard.kde.org/r/117088/diff/ Testing --- Thanks, Jonathan Riddell
