Review Request 117166: remove /MainApplication object from screenlocker greeter interface
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117166/ --- Review request for kde-workspace, Martin Gräßlin and Kirill Elagin. Repository: kde-workspace Description --- Turned out it's possible to kquitapp the greeter w/o having to provide the desktop. whatever is the final resolution to bug #314989 resp. review #117157, ignorantly exposing the /MainApplication object on this process is certainly a bug. (I considered turning it into a QApplication, but that would have turned a HUGE patch and also the KDebug interface might be a benefit) As the issue exists since 4.10, i don't think it's necessary to press this into 4.11.8 (and break the "workaround" in bug #314989, which then can be reasonably resolved before 4.11.9) Diffs - ksmserver/screenlocker/greeter/greeterapp.cpp c5e2f85 Diff: https://git.reviewboard.kde.org/r/117166/diff/ Testing --- locked screen, checked dbus interface of the greeter - MainApplication is gone. Thanks, Thomas Lübking
Re: Review Request 117166: remove /MainApplication object from screenlocker greeter interface
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117166/#review54562 --- Why not simply add a parameter to KApplication constructor? - Kirill Elagin On March 29, 2014, 8:32 p.m., Thomas Lübking wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117166/ > --- > > (Updated March 29, 2014, 8:32 p.m.) > > > Review request for kde-workspace, Martin Gräßlin and Kirill Elagin. > > > Repository: kde-workspace > > > Description > --- > > Turned out it's possible to kquitapp the greeter w/o having to provide the > desktop. > whatever is the final resolution to bug #314989 resp. review #117157, > ignorantly exposing the /MainApplication object on this process is certainly > a bug. (I considered turning it into a QApplication, but that would have > turned a HUGE patch and also the KDebug interface might be a benefit) > > As the issue exists since 4.10, i don't think it's necessary to press this > into 4.11.8 (and break the "workaround" in bug #314989, which then can be > reasonably resolved before 4.11.9) > > > Diffs > - > > ksmserver/screenlocker/greeter/greeterapp.cpp c5e2f85 > > Diff: https://git.reviewboard.kde.org/r/117166/diff/ > > > Testing > --- > > locked screen, checked dbus interface of the greeter - MainApplication is > gone. > > > Thanks, > > Thomas Lübking > >
Re: Review Request 117166: remove /MainApplication object from screenlocker greeter interface
> On March 29, 2014, 8:39 p.m., Kirill Elagin wrote: > > Why not simply add a parameter to KApplication constructor? Being? I'm not aware of such parameter, kdelibs is semi-frozen and the requirement is also pretty special to add such feature to KApplication, yesno? - Thomas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117166/#review54562 --- On March 29, 2014, 8:32 p.m., Thomas Lübking wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117166/ > --- > > (Updated March 29, 2014, 8:32 p.m.) > > > Review request for kde-workspace, Martin Gräßlin and Kirill Elagin. > > > Repository: kde-workspace > > > Description > --- > > Turned out it's possible to kquitapp the greeter w/o having to provide the > desktop. > whatever is the final resolution to bug #314989 resp. review #117157, > ignorantly exposing the /MainApplication object on this process is certainly > a bug. (I considered turning it into a QApplication, but that would have > turned a HUGE patch and also the KDebug interface might be a benefit) > > As the issue exists since 4.10, i don't think it's necessary to press this > into 4.11.8 (and break the "workaround" in bug #314989, which then can be > reasonably resolved before 4.11.9) > > > Diffs > - > > ksmserver/screenlocker/greeter/greeterapp.cpp c5e2f85 > > Diff: https://git.reviewboard.kde.org/r/117166/diff/ > > > Testing > --- > > locked screen, checked dbus interface of the greeter - MainApplication is > gone. > > > Thanks, > > Thomas Lübking > >
Re: Review Request 117166: remove /MainApplication object from screenlocker greeter interface
> On March 29, 2014, 8:39 p.m., Kirill Elagin wrote: > > Why not simply add a parameter to KApplication constructor? > > Thomas Lübking wrote: > Being? > I'm not aware of such parameter, kdelibs is semi-frozen and the > requirement is also pretty special to add such feature to KApplication, yesno? I've checked KApplication code and it seems that it creates a DBus service unconditionally. Which is pretty weird. Is that true that _every single_ application wants to be exposed via DBus? I guess, no. I wouldn't call this requirement “special” at all. I'm not sure about your freezing rules, but adding a parameter with a compatible default value shouldn't be a big deal, right? - Kirill --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117166/#review54562 --- On March 29, 2014, 8:32 p.m., Thomas Lübking wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117166/ > --- > > (Updated March 29, 2014, 8:32 p.m.) > > > Review request for kde-workspace, Martin Gräßlin and Kirill Elagin. > > > Repository: kde-workspace > > > Description > --- > > Turned out it's possible to kquitapp the greeter w/o having to provide the > desktop. > whatever is the final resolution to bug #314989 resp. review #117157, > ignorantly exposing the /MainApplication object on this process is certainly > a bug. (I considered turning it into a QApplication, but that would have > turned a HUGE patch and also the KDebug interface might be a benefit) > > As the issue exists since 4.10, i don't think it's necessary to press this > into 4.11.8 (and break the "workaround" in bug #314989, which then can be > reasonably resolved before 4.11.9) > > > Diffs > - > > ksmserver/screenlocker/greeter/greeterapp.cpp c5e2f85 > > Diff: https://git.reviewboard.kde.org/r/117166/diff/ > > > Testing > --- > > locked screen, checked dbus interface of the greeter - MainApplication is > gone. > > > Thanks, > > Thomas Lübking > >
Re: Review Request 117166: remove /MainApplication object from screenlocker greeter interface
> On March 29, 2014, 8:39 p.m., Kirill Elagin wrote: > > Why not simply add a parameter to KApplication constructor? > > Thomas Lübking wrote: > Being? > I'm not aware of such parameter, kdelibs is semi-frozen and the > requirement is also pretty special to add such feature to KApplication, yesno? > > Kirill Elagin wrote: > I've checked KApplication code and it seems that it creates a DBus > service unconditionally. Which is pretty weird. > Is that true that _every single_ application wants to be exposed via > DBus? I guess, no. I wouldn't call this requirement “special” at all. > > I'm not sure about your freezing rules, but adding a parameter with a > compatible default value shouldn't be a big deal, right? > Is that true that _every single_ application wants to be exposed via DBus? No idea, but actually cannot think of other cases that don't want to. I do not expect a freeze exception for this at all, if you think it's reasonable you could propose it for KF5. - Thomas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117166/#review54562 --- On March 29, 2014, 8:32 p.m., Thomas Lübking wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117166/ > --- > > (Updated March 29, 2014, 8:32 p.m.) > > > Review request for kde-workspace, Martin Gräßlin and Kirill Elagin. > > > Repository: kde-workspace > > > Description > --- > > Turned out it's possible to kquitapp the greeter w/o having to provide the > desktop. > whatever is the final resolution to bug #314989 resp. review #117157, > ignorantly exposing the /MainApplication object on this process is certainly > a bug. (I considered turning it into a QApplication, but that would have > turned a HUGE patch and also the KDebug interface might be a benefit) > > As the issue exists since 4.10, i don't think it's necessary to press this > into 4.11.8 (and break the "workaround" in bug #314989, which then can be > reasonably resolved before 4.11.9) > > > Diffs > - > > ksmserver/screenlocker/greeter/greeterapp.cpp c5e2f85 > > Diff: https://git.reviewboard.kde.org/r/117166/diff/ > > > Testing > --- > > locked screen, checked dbus interface of the greeter - MainApplication is > gone. > > > Thanks, > > Thomas Lübking > >
Re: Review Request 117166: remove /MainApplication object from screenlocker greeter interface
> On March 29, 2014, 8:39 p.m., Kirill Elagin wrote: > > Why not simply add a parameter to KApplication constructor? > > Thomas Lübking wrote: > Being? > I'm not aware of such parameter, kdelibs is semi-frozen and the > requirement is also pretty special to add such feature to KApplication, yesno? > > Kirill Elagin wrote: > I've checked KApplication code and it seems that it creates a DBus > service unconditionally. Which is pretty weird. > Is that true that _every single_ application wants to be exposed via > DBus? I guess, no. I wouldn't call this requirement “special” at all. > > I'm not sure about your freezing rules, but adding a parameter with a > compatible default value shouldn't be a big deal, right? > > Thomas Lübking wrote: > > Is that true that _every single_ application wants to be exposed via > DBus? > No idea, but actually cannot think of other cases that don't want to. > > I do not expect a freeze exception for this at all, if you think it's > reasonable you could propose it for KF5. inb4 you ask: - new feature - api change - uncertain usecase - can easily be gained w/o api change/feature addition (pure convenience) - Thomas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117166/#review54562 --- On March 29, 2014, 8:32 p.m., Thomas Lübking wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117166/ > --- > > (Updated March 29, 2014, 8:32 p.m.) > > > Review request for kde-workspace, Martin Gräßlin and Kirill Elagin. > > > Repository: kde-workspace > > > Description > --- > > Turned out it's possible to kquitapp the greeter w/o having to provide the > desktop. > whatever is the final resolution to bug #314989 resp. review #117157, > ignorantly exposing the /MainApplication object on this process is certainly > a bug. (I considered turning it into a QApplication, but that would have > turned a HUGE patch and also the KDebug interface might be a benefit) > > As the issue exists since 4.10, i don't think it's necessary to press this > into 4.11.8 (and break the "workaround" in bug #314989, which then can be > reasonably resolved before 4.11.9) > > > Diffs > - > > ksmserver/screenlocker/greeter/greeterapp.cpp c5e2f85 > > Diff: https://git.reviewboard.kde.org/r/117166/diff/ > > > Testing > --- > > locked screen, checked dbus interface of the greeter - MainApplication is > gone. > > > Thanks, > > Thomas Lübking > >
