Re: Review Request 120652: Remove kdemacros.h and use generate_export_header for interfaces folder.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120652/#review68714 --- Ship it! Ship It! - Aleix Pol Gonzalez On Oct. 19, 2014, 2:05 a.m., Jeremy Whiting wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120652/ --- (Updated Oct. 19, 2014, 2:05 a.m.) Review request for kdelibs and Kevin Kofler. Repository: kompare Description --- Remove kdemacros.h and use generate_export_header for interfaces folder. Diffs - interfaces/CMakeLists.txt 032ae985ac7221a498afff186211fbcad68cba78 interfaces/kompareinterface.h 07a271d0844767a2fee5af3e985c1b05d3640f05 interfaces/kompareinterfaceexport.h eed5c85eb4e4c091df2f32e58d3183600ca3a8c0 Diff: https://git.reviewboard.kde.org/r/120652/diff/ Testing --- Still builds and runs as expected. Thanks, Jeremy Whiting
Re: Review Request 120652: Remove kdemacros.h and use generate_export_header for interfaces folder.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120652/ --- (Updated Oct. 19, 2014, 8:44 p.m.) Status -- This change has been marked as submitted. Review request for kdelibs and Kevin Kofler. Repository: kompare Description --- Remove kdemacros.h and use generate_export_header for interfaces folder. Diffs - interfaces/CMakeLists.txt 032ae985ac7221a498afff186211fbcad68cba78 interfaces/kompareinterface.h 07a271d0844767a2fee5af3e985c1b05d3640f05 interfaces/kompareinterfaceexport.h eed5c85eb4e4c091df2f32e58d3183600ca3a8c0 Diff: https://git.reviewboard.kde.org/r/120652/diff/ Testing --- Still builds and runs as expected. Thanks, Jeremy Whiting
Review Request 120652: Remove kdemacros.h and use generate_export_header for interfaces folder.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120652/ --- Review request for kdelibs and Kevin Kofler. Repository: kompare Description --- Remove kdemacros.h and use generate_export_header for interfaces folder. Diffs - interfaces/CMakeLists.txt 032ae985ac7221a498afff186211fbcad68cba78 interfaces/kompareinterface.h 07a271d0844767a2fee5af3e985c1b05d3640f05 interfaces/kompareinterfaceexport.h eed5c85eb4e4c091df2f32e58d3183600ca3a8c0 Diff: https://git.reviewboard.kde.org/r/120652/diff/ Testing --- Still builds and runs as expected. Thanks, Jeremy Whiting