Re: Reviving KAudioCreator

[Kevin Ottens]

Hello,

On Tuesday, 26 December 2017 23:18:00 CET Albert Astals Cid wrote:
> One kind-of-big bug i'd like fixed is that it doesn't realize the encoder
> command line is not there, i was waiting for like 5 minutes wondering why it
> took so much to encode until i realized that i don't actaully have the flac
> command line installed.

Yes, I encountered that one indeed. I'll try to take a look.

Otherwise I ripped and encoded a few CDs successfully over the week-end.

Regards.
-- 
Kévin Ottens, http://ervin.ipsquad.net

KDAB - proud supporter of KDE, http://www.kdab.com



signature.asc
Description: This is a digitally signed message part.

Re: Reviving KAudioCreator

[Leslie Zhai]

I recommend to use k3b https://github.com/kde/k3b and I am maintaining 
it, please report a bug if failed to rip cd by k3b, thanks!



在 2017年12月22日 19:48, Luigi Toscano 写道:

Luigi Toscano ha scritto:

Kevin Ottens ha scritto:

Hello all,

I happen to be one of those poor souls who still rip CDs from time to time.
I'm using Dolphin for that right now, but I miss the convenience of using
KAudioCreator a while back.

It looks like it's not released at all anymore. After a quick glance at the
repository, it seems to be in a somewhat good shape (at least it builds and
starts, I didn't push further yet).>
Then, I'd like to revive it and have it part of KDE Applications. Anyone with
an objection about that? If none, how do we proceed?

No objections; as pre-review, translations and documentation were already
checked and fixed some time ago.


I see a couple of things which need to be improved a bit so I'll try to work
on those in the meantime.

Adding Leslie in CC (not sure he is subscribed here), as he did the initial
porting.


https://github.com/KDE/kaudiocreator is just able to work.



Uhm, adding the proper address.

Do you want to move it to kdereview now?


--
Regards,
Leslie Zhai - https://reviews.llvm.org/p/xiangzhai/

Re: Reviving KAudioCreator

[Albert Astals Cid]

El divendres, 22 de desembre de 2017, a les 9:30:31 CET, Kevin Ottens va 
escriure:
> Hello all,
> 
> I happen to be one of those poor souls who still rip CDs from time to time.
> I'm using Dolphin for that right now, but I miss the convenience of using
> KAudioCreator a while back.
> 
> It looks like it's not released at all anymore. After a quick glance at the
> repository, it seems to be in a somewhat good shape (at least it builds and
> starts, I didn't push further yet).
> 
> Then, I'd like to revive it and have it part of KDE Applications. Anyone
> with an objection about that? If none, how do we proceed?
> 
> I see a couple of things which need to be improved a bit so I'll try to work
> on those in the meantime.

One kind-of-big bug i'd like fixed is that it doesn't realize the encoder 
command line is not there, i was waiting for like 5 minutes wondering why it 
took so much to encode until i realized that i don't actaully have the flac 
command line installed.

Cheers,
  Albert

> 
> Regards.

Re: Reviving KAudioCreator

[Luigi Toscano]

Luigi Toscano ha scritto:
> Kevin Ottens ha scritto:
>> Hello all,
>>
>> I happen to be one of those poor souls who still rip CDs from time to time. 
>> I'm using Dolphin for that right now, but I miss the convenience of using 
>> KAudioCreator a while back.
>>
>> It looks like it's not released at all anymore. After a quick glance at the 
>> repository, it seems to be in a somewhat good shape (at least it builds and 
>> starts, I didn't push further yet).>
>> Then, I'd like to revive it and have it part of KDE Applications. Anyone 
>> with 
>> an objection about that? If none, how do we proceed?
> 
> No objections; as pre-review, translations and documentation were already
> checked and fixed some time ago.
> 
>>
>> I see a couple of things which need to be improved a bit so I'll try to work
>> on those in the meantime.
> 
> Adding Leslie in CC (not sure he is subscribed here), as he did the initial
> porting.

Uhm, adding the proper address.
> 
> Do you want to move it to kdereview now?
> 
-- 
Luigi

Re: Reviving KAudioCreator

[Luigi Toscano]

Kevin Ottens ha scritto:
> Hello all,
> 
> I happen to be one of those poor souls who still rip CDs from time to time. 
> I'm using Dolphin for that right now, but I miss the convenience of using 
> KAudioCreator a while back.
> 
> It looks like it's not released at all anymore. After a quick glance at the 
> repository, it seems to be in a somewhat good shape (at least it builds and 
> starts, I didn't push further yet).>
> Then, I'd like to revive it and have it part of KDE Applications. Anyone with 
> an objection about that? If none, how do we proceed?

No objections; as pre-review, translations and documentation were already
checked and fixed some time ago.

>
> I see a couple of things which need to be improved a bit so I'll try to work
> on those in the meantime.

Adding Leslie in CC (not sure he is subscribed here), as he did the initial
porting.

Do you want to move it to kdereview now?

Ciao
-- 
Luigi

Re: Reviving KAudioCreator

[Kevin Ottens]

Hello,

On Friday, 22 December 2017 10:59:55 CET Boudhayan Gupta wrote:
> I did a little work on KCompactDisc about two years ago (and also
> looked at KAudioCreator), and then realised it hadn't been working for
> a long time. [...]

I think it was due to the audiocd kio not being available in the KF5 world, 
but now it's there.

I'm right now ripping a CD and getting it encoded to OGG Vorbis just fine 
using current KAudioCreator master. There are a few paper cuts but really 
minor stuff. I don't think we need to go through expensive rewrites and such. 
Can likely fly with minor adjustments.

Regards.
-- 
Kévin Ottens, http://ervin.ipsquad.net

KDAB - proud supporter of KDE, http://www.kdab.com



signature.asc
Description: This is a digitally signed message part.

Re: Reviving KAudioCreator

[Boudhayan Gupta]

Hi Kevin,

The branch is here. It has no stable API or anything of that sort but
it seems to work, enumeration and ripping to WAV.

https://cgit.kde.org/libkcompactdisc.git/log/?h=nextgen

Thanks,
Boudhayan Gupta
KDE e.V. - Community Working Group
+49 151 71032970


On 22 December 2017 at 10:59, Boudhayan Gupta  wrote:
> Hi Kevin,
>
> I did a little work on KCompactDisc about two years ago (and also
> looked at KAudioCreator), and then realised it hadn't been working for
> a long time. I never got around to finishing it, but I think someone
> else got it partially working in the meantime.
>
> IIRC the problems I ran into were:
>
> 1) KAudioCreator seemed to use KCompactDisc to enumerate audio CDs but
> that didn't work. Audio CD enumeration seems to have been removed from
> Solid in KF5.
> 2) Phonon's Audio CD reading/ripping interfaces do work (at least with
> the VLC backend), but are undocumented.
>
> I don't know if it still exists but I had a branch of KCompactDisc
> somewhere that was based off libcdio, and would expose each track as a
> QIODevice with a RIFF header generated on-the-fly (so that you can
> just use the standard Qt interfaces to copy each track as a WAV file
> somewhere)). If you want to use it I'll try to look it up.
>
> I'd volunteer to help - I love to work with oldish technology - but I
> no longer have a CD drive.
>
> Thanks,
> Boudhayan Gupta
> KDE e.V. - Community Working Group
> +49 151 71032970
>
>
> On 22 December 2017 at 09:30, Kevin Ottens  wrote:
>> Hello all,
>>
>> I happen to be one of those poor souls who still rip CDs from time to time.
>> I'm using Dolphin for that right now, but I miss the convenience of using
>> KAudioCreator a while back.
>>
>> It looks like it's not released at all anymore. After a quick glance at the
>> repository, it seems to be in a somewhat good shape (at least it builds and
>> starts, I didn't push further yet).
>>
>> Then, I'd like to revive it and have it part of KDE Applications. Anyone with
>> an objection about that? If none, how do we proceed?
>>
>> I see a couple of things which need to be improved a bit so I'll try to work
>> on those in the meantime.
>>
>> Regards.
>> --
>> Kévin Ottens, http://ervin.ipsquad.net
>>
>> KDAB - proud supporter of KDE, http://www.kdab.com
>>

Re: Reviving KAudioCreator

[Boudhayan Gupta]

Hi Kevin,

I did a little work on KCompactDisc about two years ago (and also
looked at KAudioCreator), and then realised it hadn't been working for
a long time. I never got around to finishing it, but I think someone
else got it partially working in the meantime.

IIRC the problems I ran into were:

1) KAudioCreator seemed to use KCompactDisc to enumerate audio CDs but
that didn't work. Audio CD enumeration seems to have been removed from
Solid in KF5.
2) Phonon's Audio CD reading/ripping interfaces do work (at least with
the VLC backend), but are undocumented.

I don't know if it still exists but I had a branch of KCompactDisc
somewhere that was based off libcdio, and would expose each track as a
QIODevice with a RIFF header generated on-the-fly (so that you can
just use the standard Qt interfaces to copy each track as a WAV file
somewhere)). If you want to use it I'll try to look it up.

I'd volunteer to help - I love to work with oldish technology - but I
no longer have a CD drive.

Thanks,
Boudhayan Gupta
KDE e.V. - Community Working Group
+49 151 71032970


On 22 December 2017 at 09:30, Kevin Ottens  wrote:
> Hello all,
>
> I happen to be one of those poor souls who still rip CDs from time to time.
> I'm using Dolphin for that right now, but I miss the convenience of using
> KAudioCreator a while back.
>
> It looks like it's not released at all anymore. After a quick glance at the
> repository, it seems to be in a somewhat good shape (at least it builds and
> starts, I didn't push further yet).
>
> Then, I'd like to revive it and have it part of KDE Applications. Anyone with
> an objection about that? If none, how do we proceed?
>
> I see a couple of things which need to be improved a bit so I'll try to work
> on those in the meantime.
>
> Regards.
> --
> Kévin Ottens, http://ervin.ipsquad.net
>
> KDAB - proud supporter of KDE, http://www.kdab.com
>

Reviving KAudioCreator

[Kevin Ottens]

Hello all,

I happen to be one of those poor souls who still rip CDs from time to time. 
I'm using Dolphin for that right now, but I miss the convenience of using 
KAudioCreator a while back.

It looks like it's not released at all anymore. After a quick glance at the 
repository, it seems to be in a somewhat good shape (at least it builds and 
starts, I didn't push further yet).

Then, I'd like to revive it and have it part of KDE Applications. Anyone with 
an objection about that? If none, how do we proceed?

I see a couple of things which need to be improved a bit so I'll try to work 
on those in the meantime.

Regards.
-- 
Kévin Ottens, http://ervin.ipsquad.net

KDAB - proud supporter of KDE, http://www.kdab.com



signature.asc
Description: This is a digitally signed message part.