Re: Ruqola in KDE-review
El dimarts, 17 de setembre de 2019, a les 8:20:36 CEST, laurent Montel va escriure: > Le mardi 17 septembre 2019, 00:07:38 CEST Albert Astals Cid a écrit : > > El dilluns, 16 de setembre de 2019, a les 7:00:32 CEST, laurent Montel va > escriure: > > On the left side bar. > > It's a lineedit for searching in existing room/channel in listview. > It's not for searching new channel/user as in RC. > > For it you need to click on icon at right of this lineedit > There is a menu => "open room" I see, i was confused because on the web app the search also does "search rooms", any reason this is separate here? Also I feel like the "open room" should either search as i type or have a button that says "search" i was very confused because i didn't know how to start a search, sure pressing Enter feels natural, but it's a weird when there's no button that says "search" anywhere, maybe it's just me, feel free to ignore :) Cheers, Albert
Re: Ruqola in KDE-review
Licence looks good :) Jonathan On Thu, 12 Sep 2019 at 08:20, laurent Montel wrote: > Hi, > I would like to move ruqola to extragear/network. > So I asked to sysadmin to move ruqola to kde-review (it was done). > > Ben told me that this period will start in 2 weeks. > > If you want to review it... :) > > Regards. > > -- > Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software > Engineer > KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 > 53, > www.kdab.fr KDAB - The Qt, C++ and OpenGL Experts - Platform-independent > software solutions > > >
Re: Ruqola in KDE-review
Le mardi 17 septembre 2019, 00:07:38 CEST Albert Astals Cid a écrit :
> El dilluns, 16 de setembre de 2019, a les 7:00:32 CEST, laurent Montel va
escriure:
> > Le lundi 16 septembre 2019, 00:14:12 CEST Albert Astals Cid a écrit :
> > > El dijous, 12 de setembre de 2019, a les 9:20:45 CEST, laurent Montel va
> >
> > escriure:
> > > > Hi,
> > > > I would like to move ruqola to extragear/network.
> > > > So I asked to sysadmin to move ruqola to kde-review (it was done).
> > > >
> > > > Ben told me that this period will start in 2 weeks.
> > > >
> > > > If you want to review it... :)
> > >
> > > Now onto the using side:
> > >
> > > Starting it for the first time says
> > >
> > > received something unhandled: "{\"server_id\":\"0\"}"
> > > Connected
> > > org.kde.ruqola: Unknown service type:
> > > "Accounts_OAuth_Gitlab_identity_path" org.kde.rocketchatqtrestapi: Auth
> > > settings is empty. It's a bug
> > > org.kde.rocketchatqtrestapi: Impossible to start
> > > GetSupportedLanguagesJob
> > > org.kde.rocketchatqtrestapi: Impossible to start
> > > GetSupportedLanguagesJob
> >
> > Normal it's a bug from yesterday. This one will be fixed today.
> >
> > > And then the ui says "login failed"
> > >
> > >
> > > Connected to what? Is it attempting to login to something even if i have
> > > never used the app?
> >
> > Yep on open.rocket.chat server. It's the default server. Perhaps I need to
> > disable it.
>
> If there's no user/password i guess it makes sense to not try to log in.
Indeed I will fix it
>
> > ... snip ...
> >
> > > Ah, on the second login looked different and it at least showed my
> > > account
> > > name there on the first line (even though i still was not able to
> > > configure
> > > anything?)
> > >
> > > Searching for "montel" on the webapp on the company server shows me your
> > > chat (that i don't have open), searching for the same on ruqola doesn't,
> > > so
> > > i don't really have a way to talking to you
> >
> > Where do you search it ?
>
> On the left side bar.
It's a lineedit for searching in existing room/channel in listview.
It's not for searching new channel/user as in RC.
For it you need to click on icon at right of this lineedit
There is a menu => "open room"
Regards
>
> This is the webapp when searching for you (blocked your avatar)
> https://i.imgur.com/4EMfwL6.png This is ruqola when searching for you
> https://i.imgur.com/qeSt5Qz.png
>
> Cheers,
> Albert
--
Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer
KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53,
www.kdab.fr KDAB - The Qt, C++ and OpenGL Experts - Platform-independent
software solutions
Re: Ruqola in KDE-review
Le lundi 16 septembre 2019, 23:01:56 CEST Albert Astals Cid a écrit : > El dilluns, 16 de setembre de 2019, a les 6:54:40 CEST, laurent Montel va escriure: > > Le dimanche 15 septembre 2019, 23:54:19 CEST Albert Astals Cid a écrit : > > > El dijous, 12 de setembre de 2019, a les 9:20:45 CEST, laurent Montel va > > > > escriure: > > > > Hi, > > > > I would like to move ruqola to extragear/network. > > > > So I asked to sysadmin to move ruqola to kde-review (it was done). > > > > > > > > Ben told me that this period will start in 2 weeks. > > > > > > > > If you want to review it... :) > > > > > > class LIBRUQOLACORE_TESTS_EXPORT Emoji > > > has > > > Emoji =(const Emoji ); > > > but no > > > Emoji(const Emoji ); > > > > > > newer gcc complains about it, also the operator= doesn't copy > > > mCachedHtml is that on purpose? If not i'd suggest to simply mark > > > operator= and the copy contructor as = default. > > > > > > > > > > > > > > > class LIBRUQOLACORE_TESTS_EXPORT User > > > also has the same warning, given that the operator= is implemented and > > > not > > > the copy constructor. Same suggestion to just use = default on them. > > > > > > > > > and a whole lots more of classes seem to have this issue. Can you double > > > check them for me? > > > > Fixed thanks > > Awesome, i think i may have forgotten to paste 2 more (the warning log was > very long) > > http://paste.debian.net/1101123/ Fixed thanks > Cheers, > Albert > > > > http://paste.debian.net/1100950/ > > > > > > Cheers, > > > > > > Albert > > > > > > > Regards. -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, www.kdab.fr KDAB - The Qt, C++ and OpenGL Experts - Platform-independent software solutions
Re: Ruqola in KDE-review
El dilluns, 16 de setembre de 2019, a les 7:00:32 CEST, laurent Montel va
escriure:
> Le lundi 16 septembre 2019, 00:14:12 CEST Albert Astals Cid a écrit :
> > El dijous, 12 de setembre de 2019, a les 9:20:45 CEST, laurent Montel va
> escriure:
> > > Hi,
> > > I would like to move ruqola to extragear/network.
> > > So I asked to sysadmin to move ruqola to kde-review (it was done).
> > >
> > > Ben told me that this period will start in 2 weeks.
> > >
> > > If you want to review it... :)
> >
> > Now onto the using side:
> >
> > Starting it for the first time says
> >
> > received something unhandled: "{\"server_id\":\"0\"}"
> > Connected
> > org.kde.ruqola: Unknown service type: "Accounts_OAuth_Gitlab_identity_path"
> > org.kde.rocketchatqtrestapi: Auth settings is empty. It's a bug
> > org.kde.rocketchatqtrestapi: Impossible to start GetSupportedLanguagesJob
> > org.kde.rocketchatqtrestapi: Impossible to start GetSupportedLanguagesJob
>
> Normal it's a bug from yesterday. This one will be fixed today.
>
>
> >
> > And then the ui says "login failed"
> >
> >
> > Connected to what? Is it attempting to login to something even if i have
> > never used the app?
>
> Yep on open.rocket.chat server. It's the default server. Perhaps I need to
> disable it.
If there's no user/password i guess it makes sense to not try to log in.
> ... snip ...
>
> > Ah, on the second login looked different and it at least showed my account
> > name there on the first line (even though i still was not able to configure
> > anything?)
> >
> > Searching for "montel" on the webapp on the company server shows me your
> > chat (that i don't have open), searching for the same on ruqola doesn't, so
> > i don't really have a way to talking to you
>
> Where do you search it ?
On the left side bar.
This is the webapp when searching for you (blocked your avatar)
https://i.imgur.com/4EMfwL6.png
This is ruqola when searching for you https://i.imgur.com/qeSt5Qz.png
Cheers,
Albert
Re: Ruqola in KDE-review
El dilluns, 16 de setembre de 2019, a les 6:54:40 CEST, laurent Montel va escriure: > Le dimanche 15 septembre 2019, 23:54:19 CEST Albert Astals Cid a écrit : > > El dijous, 12 de setembre de 2019, a les 9:20:45 CEST, laurent Montel va > escriure: > > > Hi, > > > I would like to move ruqola to extragear/network. > > > So I asked to sysadmin to move ruqola to kde-review (it was done). > > > > > > Ben told me that this period will start in 2 weeks. > > > > > > If you want to review it... :) > > > > class LIBRUQOLACORE_TESTS_EXPORT Emoji > > has > > Emoji =(const Emoji ); > > but no > > Emoji(const Emoji ); > > > > newer gcc complains about it, also the operator= doesn't copy mCachedHtml is > > that on purpose? If not i'd suggest to simply mark operator= and the copy > > contructor as = default. > > > > > > > > > > class LIBRUQOLACORE_TESTS_EXPORT User > > also has the same warning, given that the operator= is implemented and not > > the copy constructor. Same suggestion to just use = default on them. > > > > > > and a whole lots more of classes seem to have this issue. Can you double > > check them for me? > > Fixed thanks Awesome, i think i may have forgotten to paste 2 more (the warning log was very long) http://paste.debian.net/1101123/ Cheers, Albert > > > > > > http://paste.debian.net/1100950/ > > > > Cheers, > > Albert > > > > > Regards. > > >
Re: Ruqola in KDE-review
> Can the icons on the top bar have tooltips? I had no idea what would happen > when pressing the "two people" icon. Done.
Re: Ruqola in KDE-review
Le lundi 16 septembre 2019, 00:14:12 CEST Albert Astals Cid a écrit :
> El dijous, 12 de setembre de 2019, a les 9:20:45 CEST, laurent Montel va
escriure:
> > Hi,
> > I would like to move ruqola to extragear/network.
> > So I asked to sysadmin to move ruqola to kde-review (it was done).
> >
> > Ben told me that this period will start in 2 weeks.
> >
> > If you want to review it... :)
>
> Now onto the using side:
>
> Starting it for the first time says
>
> received something unhandled: "{\"server_id\":\"0\"}"
> Connected
> org.kde.ruqola: Unknown service type: "Accounts_OAuth_Gitlab_identity_path"
> org.kde.rocketchatqtrestapi: Auth settings is empty. It's a bug
> org.kde.rocketchatqtrestapi: Impossible to start GetSupportedLanguagesJob
> org.kde.rocketchatqtrestapi: Impossible to start GetSupportedLanguagesJob
Normal it's a bug from yesterday. This one will be fixed today.
>
> And then the ui says "login failed"
>
>
> Connected to what? Is it attempting to login to something even if i have
> never used the app?
Yep on open.rocket.chat server. It's the default server. Perhaps I need to
disable it.
> Maybe we should not try to do that? it's a bit
> confusing
>
> Can the icons on the top bar have tooltips? I had no idea what would happen
> when pressing the "two people" icon.
I will add tooltips on theses icons.
>
> Quite a few of the "default avatars" (i.e. those that don't have their own
> avatar set) look small and wrong if you compare them to what they look on
> the webapp (see your company chat for an example)
Yep known bug. For the moment I don't understand why.
>
> Configure account is unfinished? https://i.imgur.com/d8wUwNn.png
Yep it's in progress.
> Ah, on the second login looked different and it at least showed my account
> name there on the first line (even though i still was not able to configure
> anything?)
>
> Searching for "montel" on the webapp on the company server shows me your
> chat (that i don't have open), searching for the same on ruqola doesn't, so
> i don't really have a way to talking to you
Where do you search it ?
>
> Also some of the fonts look terrible for a chat app, but that may be because
> of Qt Quick itself :/
I know it. For the moment no idea about this bug too
>
> Compare https://i.imgur.com/d4sKAwn.png (ruqola) with
> https://i.imgur.com/ibZ7Uim.png (kmail)
>
> Other than that it seems that it is a good start, so i agree it's a good
> idea to make some noise around it and see if we can get some more
> contributors :)
>
> Cheers,
> Albert
>
> > Regards.
--
Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer
KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53,
www.kdab.fr KDAB - The Qt, C++ and OpenGL Experts - Platform-independent
software solutions
Re: Ruqola in KDE-review
Le dimanche 15 septembre 2019, 23:54:19 CEST Albert Astals Cid a écrit : > El dijous, 12 de setembre de 2019, a les 9:20:45 CEST, laurent Montel va escriure: > > Hi, > > I would like to move ruqola to extragear/network. > > So I asked to sysadmin to move ruqola to kde-review (it was done). > > > > Ben told me that this period will start in 2 weeks. > > > > If you want to review it... :) > > class LIBRUQOLACORE_TESTS_EXPORT Emoji > has > Emoji =(const Emoji ); > but no > Emoji(const Emoji ); > > newer gcc complains about it, also the operator= doesn't copy mCachedHtml is > that on purpose? If not i'd suggest to simply mark operator= and the copy > contructor as = default. > > > > > class LIBRUQOLACORE_TESTS_EXPORT User > also has the same warning, given that the operator= is implemented and not > the copy constructor. Same suggestion to just use = default on them. > > > and a whole lots more of classes seem to have this issue. Can you double > check them for me? Fixed thanks > > http://paste.debian.net/1100950/ > > Cheers, > Albert > > > Regards. -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, www.kdab.fr KDAB - The Qt, C++ and OpenGL Experts - Platform-independent software solutions
Re: Ruqola in KDE-review
El dijous, 12 de setembre de 2019, a les 9:20:45 CEST, laurent Montel va
escriure:
> Hi,
> I would like to move ruqola to extragear/network.
> So I asked to sysadmin to move ruqola to kde-review (it was done).
>
> Ben told me that this period will start in 2 weeks.
>
> If you want to review it... :)
Now onto the using side:
Starting it for the first time says
received something unhandled: "{\"server_id\":\"0\"}"
Connected
org.kde.ruqola: Unknown service type: "Accounts_OAuth_Gitlab_identity_path"
org.kde.rocketchatqtrestapi: Auth settings is empty. It's a bug
org.kde.rocketchatqtrestapi: Impossible to start GetSupportedLanguagesJob
org.kde.rocketchatqtrestapi: Impossible to start GetSupportedLanguagesJob
And then the ui says "login failed"
Connected to what? Is it attempting to login to something even if i have never
used the app? Maybe we should not try to do that? it's a bit confusing
Can the icons on the top bar have tooltips? I had no idea what would happen
when pressing the "two people" icon.
Quite a few of the "default avatars" (i.e. those that don't have their own
avatar set) look small and wrong if you compare them to what they look on the
webapp (see your company chat for an example)
Configure account is unfinished? https://i.imgur.com/d8wUwNn.png
Ah, on the second login looked different and it at least showed my account name
there on the first line (even though i still was not able to configure
anything?)
Searching for "montel" on the webapp on the company server shows me your chat
(that i don't have open), searching for the same on ruqola doesn't, so i don't
really have a way to talking to you
Also some of the fonts look terrible for a chat app, but that may be because of
Qt Quick itself :/
Compare https://i.imgur.com/d4sKAwn.png (ruqola) with
https://i.imgur.com/ibZ7Uim.png (kmail)
Other than that it seems that it is a good start, so i agree it's a good idea
to make some noise around it and see if we can get some more contributors :)
Cheers,
Albert
>
> Regards.
>
>
Re: Ruqola in KDE-review
El dijous, 12 de setembre de 2019, a les 9:20:45 CEST, laurent Montel va escriure: > Hi, > I would like to move ruqola to extragear/network. > So I asked to sysadmin to move ruqola to kde-review (it was done). > > Ben told me that this period will start in 2 weeks. > > If you want to review it... :) class LIBRUQOLACORE_TESTS_EXPORT Emoji has Emoji =(const Emoji ); but no Emoji(const Emoji ); newer gcc complains about it, also the operator= doesn't copy mCachedHtml is that on purpose? If not i'd suggest to simply mark operator= and the copy contructor as = default. class LIBRUQOLACORE_TESTS_EXPORT User also has the same warning, given that the operator= is implemented and not the copy constructor. Same suggestion to just use = default on them. and a whole lots more of classes seem to have this issue. Can you double check them for me? http://paste.debian.net/1100950/ Cheers, Albert > > Regards. > >
Re: Ruqola in KDE-review
Le jeudi 12 septembre 2019, 11:07:04 CEST Luca Beltrame a écrit : > Il giorno Thu, 12 Sep 2019 09:20:45 +0200 > > laurent Montel ha scritto: > > Hi, > > I would like to move ruqola to extragear/network. > > So I asked to sysadmin to move ruqola to kde-review (it was done). > > Naive question: what does ruqola do? It's a RocketChat client writen in qml. It supports main RC features. (it supports new server 2.0.0 too). See https://rocket.chat/ -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, www.kdab.fr KDAB - The Qt, C++ and OpenGL Experts - Platform-independent software solutions
Re: Ruqola in KDE-review
Il giorno Thu, 12 Sep 2019 09:20:45 +0200 laurent Montel ha scritto: > Hi, > I would like to move ruqola to extragear/network. > So I asked to sysadmin to move ruqola to kde-review (it was done). Naive question: what does ruqola do? pgpQ9_cbUN2Ck.pgp Description: Firma digitale OpenPGP
Ruqola in KDE-review
Hi, I would like to move ruqola to extragear/network. So I asked to sysadmin to move ruqola to kde-review (it was done). Ben told me that this period will start in 2 weeks. If you want to review it... :) Regards. -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, www.kdab.fr KDAB - The Qt, C++ and OpenGL Experts - Platform-independent software solutions
[sysadmin/repo-metadata] projects/kdereview/ruqola: Move Ruqola to KDE Review per the request of Laurent Montel.
Git commit ad16c293e8a0caf000157d4a1a589515ddc0f2e4 by Ben Cooksley. Committed on 12/09/2019 at 06:32. Pushed by bcooksley into branch 'master'. Move Ruqola to KDE Review per the request of Laurent Montel. CCMAIL: kde-core-devel@kde.org R +0-0projects/kdereview/ruqola/i18n.json [from: projects/playground/network/ruqola/i18n.json - 100% similarity] R +1-1projects/kdereview/ruqola/metadata.yaml [from: projects/playground/network/ruqola/metadata.yaml - 084% similarity] https://commits.kde.org/sysadmin/repo-metadata/ad16c293e8a0caf000157d4a1a589515ddc0f2e4 diff --git a/projects/playground/network/ruqola/i18n.json b/projects/kdereview/ruqola/i18n.json similarity index 100% rename from projects/playground/network/ruqola/i18n.json rename to projects/kdereview/ruqola/i18n.json diff --git a/projects/playground/network/ruqola/metadata.yaml b/projects/kdereview/ruqola/metadata.yaml similarity index 84% rename from projects/playground/network/ruqola/metadata.yaml rename to projects/kdereview/ruqola/metadata.yaml index ac582b7..a610871 100644 --- a/projects/playground/network/ruqola/metadata.yaml +++ b/projects/kdereview/ruqola/metadata.yaml @@ -5,7 +5,7 @@ members: - displayname: "Vasudha Mathur" username: vasudhamathur name: "Ruqola" -projectpath: playground/network/ruqola +projectpath: kdereview/ruqola repoactive: true repopath: ruqola type: project
