Re: clazy is in kdereview

2017-06-21 Thread Jonathan Riddell
On 16 June 2017 at 15:24, Sérgio Martins  wrote:
> clazy is a clang plugin which allows clang to understand Qt semantics.
> You get more than 50 Qt related compiler warnings, ranging from
> unneeded memory allocations to misusage of API, including fix-its for
> automatic refactoring.

Looks very cool.

I renamed the copyright file to make it consistent with other KDE
repos and updated copyright info in man page as discussed.

Jonathan


Re: clazy is in kdereview

2017-06-18 Thread Albert Astals Cid
El divendres, 16 de juny de 2017, a les 15:24:12 CEST, Sérgio Martins va 
escriure:
> Hi all,
> 
> 
> clazy is a clang plugin which allows clang to understand Qt semantics.
> You get more than 50 Qt related compiler warnings, ranging from
> unneeded memory allocations to misusage of API, including fix-its for
> automatic refactoring.

You may want to update the README.md to point to phabricator differential that 
is supposedly the "new/correct" way to contribute patches

Or maybe https://community.kde.org/Infrastructure/Phabricator ?

The man page is not in docbook which means it's not translatable using our 
toolchain, given this is a very specialized non user oriented software it gets 
the "ok, i'll not block on this" from me.

Tests are not run by make test, can that be fixed?

Besides that, cool project, i've done what i could to contribute myself, which 
is not much

Cheers,
  Albert

> 
> 
> It's being used by many people, it's stable, has 4000 lines of
> unit-tests, also works on macOS, Windows nowadays and is tested in
> many distros (via docker) regularly.
> 
> The proposed location is extragear/sdk (seems that's where other
> development utils are)
> 
> 
> Happy reviewing!
> 
> 
> Regards,
> Sergio Martins




clazy is in kdereview

2017-06-17 Thread Sérgio Martins
Hi all,


clazy is a clang plugin which allows clang to understand Qt semantics.
You get more than 50 Qt related compiler warnings, ranging from
unneeded memory allocations to misusage of API, including fix-its for
automatic refactoring.


It's being used by many people, it's stable, has 4000 lines of
unit-tests, also works on macOS, Windows nowadays and is tested in
many distros (via docker) regularly.

The proposed location is extragear/sdk (seems that's where other
development utils are)


Happy reviewing!


Regards,
Sergio Martins