kdepimlibs dependency on nepomuk-core breaks build for Calligra and kdeplasma-addons

2012-12-17 Thread Ben Cooksley
Hi all,

Currently build.kde.org is unable to successfully complete builds of
kdeplasma-addons and Calligra due to recent changes in kdepimlibs.
These changes are a port from Nepomuk (part of kdelibs) to NepomukCore
(a seperate repository).

As kdepimlibs uses the *Config.cmake method of exporting it's
location, this means that the proper location of the library is not
set correctly.
The nepomukcore library will only be found if all projects which
depend on kdepimlibs include the following:
find_package(NepomukCore)

Last time a problem such as this occurred it involved KDevPlatform and
Grantlee - and the fix in that case was to ensure the
KDevPlatformConfig.cmake file included the above find_package line
itself. Can someone please make this adjustment, or propose a better
way of fixing this?

As a further note - you probably won't be able to reproduce this on
your local systems, as the location NepomukCore is installed to is
probably already in the compiler search path.

Thanks,
Ben


Re: kdepimlibs dependency on nepomuk-core breaks build for Calligra and kdeplasma-addons

2012-12-17 Thread Alexander Neundorf
On Monday 17 December 2012, Ben Cooksley wrote:
 Hi all,
 
 Currently build.kde.org is unable to successfully complete builds of
 kdeplasma-addons and Calligra due to recent changes in kdepimlibs.
 These changes are a port from Nepomuk (part of kdelibs) to NepomukCore
 (a seperate repository).
 
 As kdepimlibs uses the *Config.cmake method of exporting it's
 location, this means that the proper location of the library is not
 set correctly.

Of which library ? nepomukcore ?
How is the dependency to nepomukCore recorded in the exported targets file ? 
Using the path to the nepomukCore library, or by depending on a target 
nepomukCore ?

In the first case, I'm not sure where the breakage is.

In the second case, kdepimlibsConfig.cmake needs to search nepomukCore first, 
so the targets exist.

I don't have a recent build of kdepimlibs around, can you attach the installed 
kdepimlibsConfig.cmake file ?

Alex


Re: kdepimlibs dependency on nepomuk-core breaks build for Calligra and kdeplasma-addons

2012-12-17 Thread Ben Cooksley
On Tue, Dec 18, 2012 at 8:14 AM, Alexander Neundorf neund...@kde.org wrote:
 On Monday 17 December 2012, Ben Cooksley wrote:
 Hi all,

 Currently build.kde.org is unable to successfully complete builds of
 kdeplasma-addons and Calligra due to recent changes in kdepimlibs.
 These changes are a port from Nepomuk (part of kdelibs) to NepomukCore
 (a seperate repository).

 As kdepimlibs uses the *Config.cmake method of exporting it's
 location, this means that the proper location of the library is not
 set correctly.

 Of which library ? nepomukcore ?

Yes.

 How is the dependency to nepomukCore recorded in the exported targets file ?

  IMPORTED_LINK_INTERFACE_LIBRARIES_RELWITHDEBINFO
KDEPIMLibs__akonadi-kde;KDEPIMLibs__kabc;KDEPIMLibs__kcalcore;KDEPIMLibs__kmime;KDEPIMLibs__kpimutils;KDE4__kdeui;KDE4__kio;nepomukcore;/srv

 Using the path to the nepomukCore library, or by depending on a target
 nepomukCore ?

As a target - named nepomukcore.


 In the first case, I'm not sure where the breakage is.

 In the second case, kdepimlibsConfig.cmake needs to search nepomukCore first,
 so the targets exist.

 I don't have a recent build of kdepimlibs around, can you attach the installed
 kdepimlibsConfig.cmake file ?

Please find it attached.


 Alex

Thanks,
Ben


KdepimLibsConfig.cmake
Description: Binary data


Re: kdepimlibs dependency on nepomuk-core breaks build for Calligra and kdeplasma-addons

2012-12-17 Thread Pino Toscano
Alle lunedì 17 dicembre 2012, Ben Cooksley ha scritto:
 Currently build.kde.org is unable to successfully complete builds of
 kdeplasma-addons and Calligra due to recent changes in kdepimlibs.
 These changes are a port from Nepomuk (part of kdelibs) to
 NepomukCore (a seperate repository).
 
 As kdepimlibs uses the *Config.cmake method of exporting it's
 location, this means that the proper location of the library is not
 set correctly.
 The nepomukcore library will only be found if all projects which
 depend on kdepimlibs include the following:
 find_package(NepomukCore)

Simple: nepomuk-core/NepomukCoreConfig.cmake.in is broken (see 
NEPOMUK_CORE_LIB_DIR and NEPOMUK_CORE_LIBRARY).

-- 
Pino Toscano


signature.asc
Description: This is a digitally signed message part.


Re: kdepimlibs dependency on nepomuk-core breaks build for Calligra and kdeplasma-addons

2012-12-17 Thread Alexander Neundorf
On Monday 17 December 2012, Pino Toscano wrote:
 Alle lunedì 17 dicembre 2012, Ben Cooksley ha scritto:
  Currently build.kde.org is unable to successfully complete builds of
  kdeplasma-addons and Calligra due to recent changes in kdepimlibs.
  These changes are a port from Nepomuk (part of kdelibs) to
  NepomukCore (a seperate repository).
  
  As kdepimlibs uses the *Config.cmake method of exporting it's
  location, this means that the proper location of the library is not
  set correctly.
  The nepomukcore library will only be found if all projects which
  depend on kdepimlibs include the following:
  find_package(NepomukCore)
 
 Simple: nepomuk-core/NepomukCoreConfig.cmake.in is broken (see
 NEPOMUK_CORE_LIB_DIR and NEPOMUK_CORE_LIBRARY).

It needs absolute install paths, but beside that I don't see anything obvious 
wrong.
http://quickgit.kde.org/?p=nepomuk-
core.gita=blobh=ba6894a93504de2d1bb4ed9d6039aea9b93267e0hb=1225d9535209d8fe7c3f2a73bb8e8f3bfa3b0376f=NepomukCoreConfig.cmake.in

Where do you see the problem ?


Alex



Re: kdepimlibs dependency on nepomuk-core breaks build for Calligra and kdeplasma-addons

2012-12-17 Thread Alexander Neundorf
On Monday 17 December 2012, Ben Cooksley wrote:
 On Tue, Dec 18, 2012 at 8:14 AM, Alexander Neundorf neund...@kde.org 
wrote:
  On Monday 17 December 2012, Ben Cooksley wrote:
  Hi all,
  
  Currently build.kde.org is unable to successfully complete builds of
  kdeplasma-addons and Calligra due to recent changes in kdepimlibs.
  These changes are a port from Nepomuk (part of kdelibs) to NepomukCore
  (a seperate repository).
  
  As kdepimlibs uses the *Config.cmake method of exporting it's
  location, this means that the proper location of the library is not
  set correctly.
  
  Of which library ? nepomukcore ?
 
 Yes.
 
  How is the dependency to nepomukCore recorded in the exported targets
  file ?
 
   IMPORTED_LINK_INTERFACE_LIBRARIES_RELWITHDEBINFO
 KDEPIMLibs__akonadi-kde;KDEPIMLibs__kabc;KDEPIMLibs__kcalcore;KDEPIMLibs__
 kmime;KDEPIMLibs__kpimutils;KDE4__kdeui;KDE4__kio;nepomukcore;/srv
 
  Using the path to the nepomukCore library, or by depending on a target
  nepomukCore ?
 
 As a target - named nepomukcore.
 
  In the first case, I'm not sure where the breakage is.
  
  In the second case, kdepimlibsConfig.cmake needs to search nepomukCore
  first, so the targets exist.
  
  I don't have a recent build of kdepimlibs around, can you attach the
  installed kdepimlibsConfig.cmake file ?
 
 Please find it attached.

Yes, it needs to find_package(NepomukCore), maybe wrapped in an
if(NOT TARGET nepomukcore)

Alex


Re: kdepimlibs dependency on nepomuk-core breaks build for Calligra and kdeplasma-addons

2012-12-17 Thread Andreas Pakulat
Hi,

On Mon, Dec 17, 2012 at 8:07 PM, Ben Cooksley bcooks...@kde.org wrote:
 Currently build.kde.org is unable to successfully complete builds of
 kdeplasma-addons and Calligra due to recent changes in kdepimlibs.
 These changes are a port from Nepomuk (part of kdelibs) to NepomukCore
 (a seperate repository).

 As kdepimlibs uses the *Config.cmake method of exporting it's
 location, this means that the proper location of the library is not
 set correctly.
 The nepomukcore library will only be found if all projects which
 depend on kdepimlibs include the following:
 find_package(NepomukCore)

 Last time a problem such as this occurred it involved KDevPlatform and
 Grantlee - and the fix in that case was to ensure the
 KDevPlatformConfig.cmake file included the above find_package line
 itself. Can someone please make this adjustment, or propose a better
 way of fixing this?

Actually thats wrong, the fix in the case of KDevPlatform was to not
expose the Grantlee dependencies in the public API of kdevplatform and
hence make it unecessary to link to grantlee when linking to the
corresponding kdevplatform library.

Andreas


Re: kdepimlibs dependency on nepomuk-core breaks build for Calligra and kdeplasma-addons

2012-12-17 Thread Pino Toscano
Alle lunedì 17 dicembre 2012, Alexander Neundorf ha scritto:
 On Monday 17 December 2012, Pino Toscano wrote:
  Alle lunedì 17 dicembre 2012, Ben Cooksley ha scritto:
   Currently build.kde.org is unable to successfully complete builds
   of kdeplasma-addons and Calligra due to recent changes in
   kdepimlibs. These changes are a port from Nepomuk (part of
   kdelibs) to NepomukCore (a seperate repository).
   
   As kdepimlibs uses the *Config.cmake method of exporting it's
   location, this means that the proper location of the library is
   not set correctly.
   The nepomukcore library will only be found if all projects which
   depend on kdepimlibs include the following:
   find_package(NepomukCore)
  
  Simple: nepomuk-core/NepomukCoreConfig.cmake.in is broken (see
  NEPOMUK_CORE_LIB_DIR and NEPOMUK_CORE_LIBRARY).
 
 It needs absolute install paths, but beside that I don't see anything
 obvious wrong.

You just described the issue, yet don't see anything wrong?
And _LIB_DIR should just go, once the other is fixed.

(P.S.: please do not mail me directly, two mailing lists are enough, 
thanks.)

-- 
Pino Toscano


signature.asc
Description: This is a digitally signed message part.


Re: kdepimlibs dependency on nepomuk-core breaks build for Calligra and kdeplasma-addons

2012-12-17 Thread Alexander Neundorf
On Monday 17 December 2012, Pino Toscano wrote:
 Alle lunedì 17 dicembre 2012, Alexander Neundorf ha scritto:
  On Monday 17 December 2012, Pino Toscano wrote:
   Alle lunedì 17 dicembre 2012, Ben Cooksley ha scritto:
Currently build.kde.org is unable to successfully complete builds
of kdeplasma-addons and Calligra due to recent changes in
kdepimlibs. These changes are a port from Nepomuk (part of
kdelibs) to NepomukCore (a seperate repository).

As kdepimlibs uses the *Config.cmake method of exporting it's
location, this means that the proper location of the library is
not set correctly.
The nepomukcore library will only be found if all projects which
depend on kdepimlibs include the following:
find_package(NepomukCore)
   
   Simple: nepomuk-core/NepomukCoreConfig.cmake.in is broken (see
   NEPOMUK_CORE_LIB_DIR and NEPOMUK_CORE_LIBRARY).
  
  It needs absolute install paths, but beside that I don't see anything
  obvious wrong.
 
 You just described the issue, yet don't see anything wrong?

You mean that it's not relocatable ?
I can live with that.
This is hatd to get right before cmake 2.8.8.
Also, I'm actually a bit unsure about the value of relocatable packages for 
shared libs on RPATH systems.
A package which depends on such a package may have the RPATH set, which will 
then be wrong if the shared library package has been installed somewhere else.

 And _LIB_DIR should just go, once the other is fixed.

Why ?
It may be useful e.g. if somebody wants to set the RPATH.

Alex