plasma-nano and plasma-phone-components are now in kdereview
Hello! plasma-nano: https://invent.kde.org/kde/plasma-nano plasma-phone-components: https://invent.kde.org/kde/plasma-phone-components Two repos have been moved to kdereview, with final intended destinition being kde/workspace. plasma-nano is a minimal shell package which other shell package can extend, while plasma-phone-components is a shell package, look and feel and several other components which makes Plasma Mobile. Thanks -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature
Re: plasma-nano and plasma-phone-components are now in kdereview
пт, 8 нояб. 2019 г. в 10:10, Bhushan Shah : > > Hello! > > plasma-nano: https://invent.kde.org/kde/plasma-nano Hi, 1. Messages.sh files do not extract from ./shell/* 2. There is a Messages.sh file under "./components", however there is nothing to extract from that directory. Looks like the "components" component is designed not to have any translatable messages. > plasma-phone-components: https://invent.kde.org/kde/plasma-phone-components I looked for missing Messages.sh files here as well, found it missing from at least ./containments/panel/* -- Alexander Potashev
Re: plasma-nano and plasma-phone-components are now in kdereview
On Friday, November 8, 2019 10:36:39 AM CET Alexander Potashev wrote: > пт, 8 нояб. 2019 г. в 10:10, Bhushan Shah : > > Hello! > > > > plasma-nano: https://invent.kde.org/kde/plasma-nano > COPYING.LIB contains the LGPL 2.1 license. The LGPL code in this repo is LGPL-2.0-or-later > > plasma-phone-components: > > https://invent.kde.org/kde/plasma-phone-components You also need the LGPL-2.0-or-later license in this repo. Christophe
Re: plasma-nano and plasma-phone-components are now in kdereview
El divendres, 8 de novembre de 2019, a les 8:09:33 CET, Bhushan Shah va escriure: > Hello! > > plasma-nano: https://invent.kde.org/kde/plasma-nano > plasma-phone-components: https://invent.kde.org/kde/plasma-phone-components > > Two repos have been moved to kdereview, with final intended destinition > being kde/workspace. > > plasma-nano is a minimal shell package which other shell package can > extend, while plasma-phone-components is a shell package, look and feel > and several other components which makes Plasma Mobile. In the future, can we please have one email per component so it gets easier to track what has been said about what? Cheers, Albert > > Thanks >
Re: plasma-nano and plasma-phone-components are now in kdereview
El divendres, 8 de novembre de 2019, a les 8:09:33 CET, Bhushan Shah va escriure: > Hello! > > plasma-nano: https://invent.kde.org/kde/plasma-nano Please mark PlasmaMiniShellPrivatePlugin::registerTypes as override What's the point of this? connect(this, &QWindow::activeChanged, this, &FullScreenOverlay::activeChanged); You're double sending the signal? Cheers, Albert
Re: plasma-nano and plasma-phone-components are now in kdereview
El divendres, 8 de novembre de 2019, a les 8:09:33 CET, Bhushan Shah va escriure: > Hello! > > plasma-phone-components: https://invent.kde.org/kde/plasma-phone-components clazy found a crasher const char* country = countrycode.toUtf8().constData(); other minor clazy stuff in http://paste.debian.net/1115558/ And other minor clang-tidy stuff in http://paste.debian.net/1115559/ Cheers, Albert
Re: plasma-nano and plasma-phone-components are now in kdereview
On Sat, 9 Nov 2019 at 07:10, Christophe Giboudeaux wrote: > On Friday, November 8, 2019 10:36:39 AM CET Alexander Potashev wrote: > > пт, 8 нояб. 2019 г. в 10:10, Bhushan Shah : > > > Hello! > > > > > > plasma-nano: https://invent.kde.org/kde/plasma-nano > > > COPYING.LIB contains the LGPL 2.1 license. The LGPL code in this repo is > LGPL-2.0-or-later > > > > plasma-phone-components: > > > https://invent.kde.org/kde/plasma-phone-components > > You also need the LGPL-2.0-or-later license in this repo. > More an aside but I never tend to bother with worrying about the difference between LGPL 2.0 and 2.1 since it's essentially just a rename. It would be cleaner to update the files to say LGPL 2.1 which is what's recommended by the licence policy https://community.kde.org/Policies/Licensing_Policy Great to see someone else care about licence review but :) Jonathan
Re: plasma-nano and plasma-phone-components are now in kdereview
Are there plans to finally fix all those nasty QML errors listed at https://invent.kde.org/kde/plasma-phone-components/issues ? вс, 10 нояб. 2019 г. в 04:07, Albert Astals Cid : > > El divendres, 8 de novembre de 2019, a les 8:09:33 CET, Bhushan Shah va > escriure: > > Hello! > > > > plasma-phone-components: https://invent.kde.org/kde/plasma-phone-components > > clazy found a crasher > const char* country = countrycode.toUtf8().constData(); > > other minor clazy stuff in http://paste.debian.net/1115558/ > > And other minor clang-tidy stuff in http://paste.debian.net/1115559/ > > Cheers, > Albert > >
Re: plasma-nano and plasma-phone-components are now in kdereview
пт, 8 нояб. 2019 г. в 10:10, Bhushan Shah : > plasma-nano: https://invent.kde.org/kde/plasma-nano Scripty (i18n daemon) fails to push to plasma-nano.git, find this in https://logs.l10n.kde.org/191122.trunk_l10n-kf5: remote: FATAL: W refs/heads/master plasma-nano scripty DENIED by refs/.* remote: error: hook declined to update refs/heads/master To ssh://g...@git.kde.org/plasma-nano.git ! [remote rejected] HEAD -> master (hook declined) error: failed to push some refs to 'ssh://g...@git.kde.org/plasma-nano.git' ERROR: commiting .desktop files failed for module kdereview_plasma-nano! May be some repo-specific configuration issue because the same procedure works for plasma-phone-components, see for example https://invent.kde.org/kde/plasma-phone-components/commit/78ce66807139cadfbe9e45b79e79729fc04ceb51 -- Alexander Potashev
Re: plasma-nano and plasma-phone-components are now in kdereview
Alexander Potashev ha scritto: > пт, 8 нояб. 2019 г. в 10:10, Bhushan Shah : >> plasma-nano: https://invent.kde.org/kde/plasma-nano > > Scripty (i18n daemon) fails to push to plasma-nano.git, find this in > https://logs.l10n.kde.org/191122.trunk_l10n-kf5: > > remote: FATAL: W refs/heads/master plasma-nano scripty DENIED by refs/.* > remote: error: hook declined to update refs/heads/master > To ssh://g...@git.kde.org/plasma-nano.git > ! [remote rejected] HEAD -> master (hook declined) > error: failed to push some refs to 'ssh://g...@git.kde.org/plasma-nano.git' > ERROR: commiting .desktop files failed for module kdereview_plasma-nano! > > > May be some repo-specific configuration issue because the same > procedure works for plasma-phone-components, see for example > https://invent.kde.org/kde/plasma-phone-components/commit/78ce66807139cadfbe9e45b79e79729fc04ceb51 Up to us (i18n), will be fixed in the next run. We are temporarily setting the repositories which are on invent directly in scripty settings, because this mixed source scenario (repositories on invent or some "bare git") is just temporary. -- Luigi
Re: plasma-nano and plasma-phone-components are now in kdereview
I've moved these into kde/workspace now for release with Plasma 5.18 (as non LTS) Jonathan On Fri, 8 Nov 2019 at 07:09, Bhushan Shah wrote: > Hello! > > plasma-nano: https://invent.kde.org/kde/plasma-nano > plasma-phone-components: > https://invent.kde.org/kde/plasma-phone-components > > Two repos have been moved to kdereview, with final intended destinition > being kde/workspace. > > plasma-nano is a minimal shell package which other shell package can > extend, while plasma-phone-components is a shell package, look and feel > and several other components which makes Plasma Mobile. > > Thanks > -- > Bhushan Shah > http://blog.bshah.in > IRC Nick : bshah on Freenode > GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D >
Re: plasma-nano and plasma-phone-components are now in kdereview
Hi Jonathan, Are you saying that Plasma 5.18 LTS will be a subset of Plasma 5.18? If so, we definitely need to notify l10n coordinators (kde-i18n-doc) and mention in the release announcement which packages are non-LTS. May also make sense to put tarballs in a separate directory, e.g. https://download.kde.org/stable/plasma/5.18.0/non-lts/plasma-nano-5.18.0.tar.xz -- Alexander Potashev пн, 9 дек. 2019 г. в 15:05, Jonathan Riddell : > > I've moved these into kde/workspace now for release with Plasma 5.18 (as non > LTS) > > Jonathan > > > On Fri, 8 Nov 2019 at 07:09, Bhushan Shah wrote: >> >> Hello! >> >> plasma-nano: https://invent.kde.org/kde/plasma-nano >> plasma-phone-components: https://invent.kde.org/kde/plasma-phone-components >> >> Two repos have been moved to kdereview, with final intended destinition >> being kde/workspace. >> >> plasma-nano is a minimal shell package which other shell package can >> extend, while plasma-phone-components is a shell package, look and feel >> and several other components which makes Plasma Mobile. >> >> Thanks >> -- >> Bhushan Shah >> http://blog.bshah.in >> IRC Nick : bshah on Freenode >> GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D
Re: plasma-nano and plasma-phone-components are now in kdereview
Appears to be fixed on L10n team side: https://websvn.kde.org/?view=revision&revision=1560522 Thanks Luigi! However I want to highlight the problem could be avoided by more complete communication from Plasma team. Thanks! -- Alexander Potashev On Mon, Dec 9, 2019 at 8:05 PM Alexander Potashev wrote: > > Hi Jonathan, > > Are you saying that Plasma 5.18 LTS will be a subset of Plasma 5.18? > > If so, we definitely need to notify l10n coordinators (kde-i18n-doc) > and mention in the release announcement which packages are non-LTS. > May also make sense to put tarballs in a separate directory, e.g. > https://download.kde.org/stable/plasma/5.18.0/non-lts/plasma-nano-5.18.0.tar.xz > > -- > Alexander Potashev > > пн, 9 дек. 2019 г. в 15:05, Jonathan Riddell : > > > > I've moved these into kde/workspace now for release with Plasma 5.18 (as > > non LTS) > > > > Jonathan > > > > > > On Fri, 8 Nov 2019 at 07:09, Bhushan Shah wrote: > >> > >> Hello! > >> > >> plasma-nano: https://invent.kde.org/kde/plasma-nano > >> plasma-phone-components: https://invent.kde.org/kde/plasma-phone-components > >> > >> Two repos have been moved to kdereview, with final intended destinition > >> being kde/workspace. > >> > >> plasma-nano is a minimal shell package which other shell package can > >> extend, while plasma-phone-components is a shell package, look and feel > >> and several other components which makes Plasma Mobile. > >> > >> Thanks > >> -- > >> Bhushan Shah > >> http://blog.bshah.in > >> IRC Nick : bshah on Freenode > >> GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D
