Re: Review Request 117832: use QFileInfo to also find hidden paths on windows

[Patrick Spendrin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117832/
---

(Updated April 29, 2014, 12:03 a.m.)


Status
--

This change has been marked as submitted.


Review request for Baloo and kdewin.


Repository: baloo


Description
---

hidden files on windows must not start with a . So instead use QFileInfo to 
correctly check that files are hidden and also modify the test and use the 
native function.


Diffs
-

  src/file/autotest/fileindexerconfigutils.h ab52f3b 

Diff: https://git.reviewboard.kde.org/r/117832/diff/


Testing
---

windows msvc 2010


Thanks,

Patrick Spendrin


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 117851: fix finding the dummy extractor

[Patrick Spendrin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117851/
---

(Updated April 29, 2014, 12:02 a.m.)


Review request for Baloo and kdewin.


Repository: baloo


Description
---

the dummy extractor executable is moved into the local build directory and
the setting of the path is adapted to the required windows path separator


Diffs
-

  src/file/autotest/fileindexingjob/CMakeLists.txt 
3fc5b2b03ecfcec9cffa2510a00b7b161ebbf94a 
  src/file/autotest/fileindexingjob/fileindexingjobtest.cpp 
8a0ca84f74f622990766d737ee6a1b108dca9068 

Diff: https://git.reviewboard.kde.org/r/117851/diff/


Testing (updated)
---

windows msvc 2010


Thanks,

Patrick Spendrin


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 117845: rename test as another exists with the same name

[Patrick Spendrin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117845/
---

(Updated April 29, 2014, 12:01 a.m.)


Review request for Baloo and kdewin.


Repository: baloo


Description
---

rename test as another exists with the same name


Diffs
-

  src/file/tests/CMakeLists.txt 4f186483a9644d7b8de84335929cda16ceff71f3 

Diff: https://git.reviewboard.kde.org/r/117845/diff/


Testing
---

msvc 2010


Thanks,

Patrick Spendrin


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Review Request 117851: fix finding the dummy extractor

[Patrick Spendrin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117851/
---

Review request for Baloo.


Repository: baloo


Description
---

the dummy extractor executable is moved into the local build directory and
the setting of the path is adapted to the required windows path separator


Diffs
-

  src/file/autotest/fileindexingjob/CMakeLists.txt 
3fc5b2b03ecfcec9cffa2510a00b7b161ebbf94a 
  src/file/autotest/fileindexingjob/fileindexingjobtest.cpp 
8a0ca84f74f622990766d737ee6a1b108dca9068 

Diff: https://git.reviewboard.kde.org/r/117851/diff/


Testing
---


Thanks,

Patrick Spendrin


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 117845: rename test as another exists with the same name

[Patrick Spendrin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117845/
---

(Updated April 28, 2014, 11:51 p.m.)


Review request for Baloo.


Changes
---

ok, it seems to work so far with just renaming the executable.


Repository: baloo


Description
---

rename test as another exists with the same name


Diffs (updated)
-

  src/file/tests/CMakeLists.txt 4f186483a9644d7b8de84335929cda16ceff71f3 

Diff: https://git.reviewboard.kde.org/r/117845/diff/


Testing
---

msvc 2010


Thanks,

Patrick Spendrin


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Baloo - [Basic Settings]

[mk-lists]

On 28 Apr 2014, at 09:13 , Kevin Krammer  wrote:
> http://techbase.kde.org/KDE_System_Administration/Configuration_Files#Shell_Expansion
Thanks, Kevin, that link was indeed just what I needed!
:-)
Greets,
Marko

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 117845: rename test as another exists with the same name

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117845/#review56797
---


This review has been submitted with commit 
497a344727824c80f1f343ccc96b40fb412292bb by Patrick Spendrin to branch KDE/4.13.

- Commit Hook


On April 28, 2014, 3:33 p.m., Patrick Spendrin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117845/
> ---
> 
> (Updated April 28, 2014, 3:33 p.m.)
> 
> 
> Review request for Baloo and kdewin.
> 
> 
> Repository: baloo
> 
> 
> Description
> ---
> 
> rename test as another exists with the same name
> 
> 
> Diffs
> -
> 
>   src/file/search/autotest/CMakeLists.txt 
> 836ef2bfb29562aa36d8ebca8678932e5f01e0f3 
>   src/file/tests/CMakeLists.txt 7b914b2f6a9b37f5ed2397ef3cc9c38ec29aba0a 
> 
> Diff: https://git.reviewboard.kde.org/r/117845/diff/
> 
> 
> Testing
> ---
> 
> msvc 2010
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 117846: make filesearchstoretest a console application

[Patrick Spendrin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117846/
---

(Updated April 28, 2014, 8:28 p.m.)


Status
--

This change has been marked as submitted.


Review request for Baloo and kdewin.


Repository: baloo


Description
---

make filesearchstoretest a console application
This is essentially only needed to not have the output of the file when running 
make test cluttered between the ctest output.


Diffs
-

  src/file/search/autotest/CMakeLists.txt 
836ef2bfb29562aa36d8ebca8678932e5f01e0f3 

Diff: https://git.reviewboard.kde.org/r/117846/diff/


Testing
---

windows msvc 2010


Thanks,

Patrick Spendrin


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 117845: rename test as another exists with the same name

[Patrick Spendrin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117845/
---

(Updated April 28, 2014, 8:27 p.m.)


Status
--

This change has been marked as submitted.


Review request for Baloo and kdewin.


Repository: baloo


Description
---

rename test as another exists with the same name


Diffs
-

  src/file/search/autotest/CMakeLists.txt 
836ef2bfb29562aa36d8ebca8678932e5f01e0f3 
  src/file/tests/CMakeLists.txt 7b914b2f6a9b37f5ed2397ef3cc9c38ec29aba0a 

Diff: https://git.reviewboard.kde.org/r/117845/diff/


Testing
---

msvc 2010


Thanks,

Patrick Spendrin


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Baloo : Milou Search Application

[Vishesh Handa]

On Tuesday, April 29, 2014 12:03:42 AM Manu Gupta wrote:
> Hello All,

Hey Manu

> 
> I came across the task on Baloo at http://community.kde.org/Baloo/Tasks
> It will be great if someone can help me with building it, as I am
> quite new to Qt and KDE libs also.
> 
> Any pointers to start will also be great.

Could you perhaps let us know where you've tried so far?

The general way of compiling an app is just running cmake, and then make 
install. But I'm guessing since you're fairly new to Qt and KDE, this would 
sound quite foreign.

Perhaps, this would be a good way? - http://en.flossmanuals.net/kde-guide/

> 
> Thanks a lot
> 
> >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
> >> <<

-- 
Vishesh Handa

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Baloo : Milou Search Application

[Manu Gupta]

Hello All,

I came across the task on Baloo at http://community.kde.org/Baloo/Tasks
It will be great if someone can help me with building it, as I am
quite new to Qt and KDE libs also.

Any pointers to start will also be great.

Thanks a lot

-- 
Regards
Manu Gupta

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 117800: Move tests inside libs/mediacenter and make them compile with the library sources instead of linking to libplasmamediacenter

[Shantanu Tushar Jha]

Hi folks,

This patch makes our tests compile with the actual sources files they are
testing, instead of linking to the object created from the sources. This is
done for these reasons-

* (this is the main reason) We no longer have to export classes just to
test them
* We can use ORM mapped classes such as Artist, Album without extra magic
for tests

However, this poses a problem that source files are built from scratch for
each test, thus considerably increasing build times. add_library with
STATIC or OBJECT don't help either because they are expecting the symbols
to be exported, just like SHARED.

Any suggestions how to solve this?


On Sun, Apr 27, 2014 at 9:38 PM, Shantanu Tushar  wrote:

>This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117800/
>   Review request for Plasma.
> By Shantanu Tushar.
>
> *Updated April 27, 2014, 4:08 p.m.*
> Changes
>
> Removed leftover CMakeLists.txt and removed unnecessary moc includes.
>
>   *Repository: * plasma-mediacenter
> Description
>
> Doing so gives us two benefits-
> 1. We no longer have to export classes just to test them
> 2. We can use ORM mapped classes such as Artist, Album without extra magic 
> for tests
>
> (the diff shows deleted/new files because of the move, reviewing 
> CMakeLists.txt changes should be sufficient)
>
>   Testing
>
> compiles, all unit tests pass
>
>   Diffs (updated)
>
>- libs/CMakeLists.txt (59334e9)
>- libs/mediacenter/CMakeLists.txt (37769f6)
>- libs/mediacenter/lastfmimagefetcher.h (4541c66)
>- libs/mediacenter/media.h (2d6cc73)
>- libs/mediacenter/pmcimagecache.h (d6d332e)
>- libs/mediacenter/subtitleprovider.h (6f0d0f6)
>- libs/test/CMakeLists.txt (52ec617)
>- libs/test/fakemediavalidator.h ()
>- libs/test/fakemediavalidator.cpp (c2fdc17)
>- libs/test/lastfmimagefetchertest.h ()
>- libs/test/lastfmimagefetchertest.cpp (9d06079)
>- libs/test/mediacentertest.h ()
>- libs/test/mediacentertest.cpp (bb4c4d1)
>- libs/test/medialibrarytest.h ()
>- libs/test/medialibrarytest.cpp (746d5b2)
>- libs/test/mediatest.h ()
>- libs/test/mediatest.cpp (86ec0d0)
>- libs/test/pmcmediatest.h ()
>- libs/test/pmcmediatest.cpp (4bdcae6)
>- libs/test/singletonfactorytest.h ()
>- libs/test/singletonfactorytest.cpp (b9fc987)
>- libs/test/testhelpers.h ()
>
> View Diff 
>



-- 
Shantanu Tushar(UTC +0530)
http://www.shantanutushar.com

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 117845: rename test as another exists with the same name

[Vishesh Handa]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117845/#review56771
---

Ship it!


Feel free to commit it after that.


src/file/tests/CMakeLists.txt


I would prefer if you kept the same test name and used set_target_properties

Eg - set_target_properties(baloo_file_extractor_dummy
PROPERTIES OUTPUT_NAME baloo_file_extractor
)




- Vishesh Handa


On April 28, 2014, 3:33 p.m., Patrick Spendrin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117845/
> ---
> 
> (Updated April 28, 2014, 3:33 p.m.)
> 
> 
> Review request for Baloo and kdewin.
> 
> 
> Repository: baloo
> 
> 
> Description
> ---
> 
> rename test as another exists with the same name
> 
> 
> Diffs
> -
> 
>   src/file/search/autotest/CMakeLists.txt 
> 836ef2bfb29562aa36d8ebca8678932e5f01e0f3 
>   src/file/tests/CMakeLists.txt 7b914b2f6a9b37f5ed2397ef3cc9c38ec29aba0a 
> 
> Diff: https://git.reviewboard.kde.org/r/117845/diff/
> 
> 
> Testing
> ---
> 
> msvc 2010
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 117845: rename test as another exists with the same name

[Patrick Spendrin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117845/
---

(Updated April 28, 2014, 3:33 p.m.)


Review request for Baloo and kdewin.


Summary (updated)
-

rename test as another exists with the same name


Repository: baloo


Description
---

rename test as another exists with the same name


Diffs
-

  src/file/search/autotest/CMakeLists.txt 
836ef2bfb29562aa36d8ebca8678932e5f01e0f3 
  src/file/tests/CMakeLists.txt 7b914b2f6a9b37f5ed2397ef3cc9c38ec29aba0a 

Diff: https://git.reviewboard.kde.org/r/117845/diff/


Testing
---

msvc 2010


Thanks,

Patrick Spendrin


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 117846: make filesearchstoretest a console application

[Vishesh Handa]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117846/#review56767
---

Ship it!


Ship It!

- Vishesh Handa


On April 28, 2014, 3:21 p.m., Patrick Spendrin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117846/
> ---
> 
> (Updated April 28, 2014, 3:21 p.m.)
> 
> 
> Review request for Baloo and kdewin.
> 
> 
> Repository: baloo
> 
> 
> Description
> ---
> 
> make filesearchstoretest a console application
> This is essentially only needed to not have the output of the file when 
> running make test cluttered between the ctest output.
> 
> 
> Diffs
> -
> 
>   src/file/search/autotest/CMakeLists.txt 
> 836ef2bfb29562aa36d8ebca8678932e5f01e0f3 
> 
> Diff: https://git.reviewboard.kde.org/r/117846/diff/
> 
> 
> Testing
> ---
> 
> windows msvc 2010
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Review Request 117845: make filesearchstoretest a console application

[Patrick Spendrin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117845/
---

Review request for Baloo and kdewin.


Repository: baloo


Description
---

rename test as another exists with the same name


Diffs
-

  src/file/search/autotest/CMakeLists.txt 
836ef2bfb29562aa36d8ebca8678932e5f01e0f3 
  src/file/tests/CMakeLists.txt 7b914b2f6a9b37f5ed2397ef3cc9c38ec29aba0a 

Diff: https://git.reviewboard.kde.org/r/117845/diff/


Testing
---

msvc 2010


Thanks,

Patrick Spendrin


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Review Request 117846: make filesearchstoretest a console application

[Patrick Spendrin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117846/
---

Review request for Baloo and kdewin.


Repository: baloo


Description
---

make filesearchstoretest a console application
This is essentially only needed to not have the output of the file when running 
make test cluttered between the ctest output.


Diffs
-

  src/file/search/autotest/CMakeLists.txt 
836ef2bfb29562aa36d8ebca8678932e5f01e0f3 

Diff: https://git.reviewboard.kde.org/r/117846/diff/


Testing
---

windows msvc 2010


Thanks,

Patrick Spendrin


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 117826: check that the directories are actually really removed

[Patrick Spendrin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117826/
---

(Updated April 28, 2014, 2:43 p.m.)


Status
--

This change has been marked as submitted.


Review request for Baloo and kdewin.


Repository: baloo


Description
---

Since removing the directories still fails on windows atm, I want to let the 
test fail in the correct place.


Diffs
-

  src/pim/akonadiplugin/autotests/searchplugintest.cpp 1c0b452 

Diff: https://git.reviewboard.kde.org/r/117826/diff/


Testing
---

windows msvc 2010


Thanks,

Patrick Spendrin


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 117825: exclude check for extended attributes for Windows

[Patrick Spendrin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117825/
---

(Updated April 28, 2014, 2:43 p.m.)


Status
--

This change has been marked as submitted.


Review request for Baloo and kdewin.


Repository: baloo


Description
---

at the moment, extended attributes are not supported on windows. The headers do 
not exist as well, so the check fails all the time.


Diffs
-

  ConfigureChecks.cmake 34db1e4 

Diff: https://git.reviewboard.kde.org/r/117825/diff/


Testing
---

msvc 2010


Thanks,

Patrick Spendrin


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 117827: malloc_trim is a gnu extension

[Patrick Spendrin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117827/
---

(Updated April 28, 2014, 2:43 p.m.)


Status
--

This change has been marked as submitted.


Review request for Baloo and kdewin.


Repository: baloo


Description
---

malloc_trim is a gnu extension, so it doesn't work on windows. I am not sure 
what the exact purpose of this call is (is the memory not freed elsewhere?), so 
I'd like to have some comments on it.


Diffs
-

  src/xapian/xapiandatabase.cpp 0478139 

Diff: https://git.reviewboard.kde.org/r/117827/diff/


Testing
---

windows msvc 2010


Thanks,

Patrick Spendrin


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 117828: prevent ex/import in exported classes used in tests

[Patrick Spendrin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117828/
---

(Updated April 28, 2014, 2:43 p.m.)


Status
--

This change has been marked as submitted.


Review request for Baloo and kdewin.


Repository: baloo


Description
---

If using class definitions of exported classes in tests, the export/import 
mechanism isn't needed. To prevent linker errors, set the EXPORT macro to empty.


Diffs
-

  src/file/autotest/CMakeLists.txt a54736e 
  src/file/autotest/fileindexingjob/CMakeLists.txt 811ed30 
  src/file/lib/autotests/CMakeLists.txt 95a0916 
  src/file/search/autotest/CMakeLists.txt eb058d2 
  src/file/tests/CMakeLists.txt 102c981 

Diff: https://git.reviewboard.kde.org/r/117828/diff/


Testing
---

windows msvc 2010


Thanks,

Patrick Spendrin


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 117830: disable extended attributes support on windows

[Patrick Spendrin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117830/
---

(Updated April 28, 2014, 2:42 p.m.)


Status
--

This change has been marked as submitted.


Review request for Baloo and kdewin.


Repository: baloo


Description
---

At the moment, there is no support available for extended attributes for 
Windows/NTFS. So we simply disable it.


Diffs
-

  src/file/lib/baloo_xattr_p.h fefc3d9 
  src/file/lib/xattrdetector.cpp 9bff838 

Diff: https://git.reviewboard.kde.org/r/117830/diff/


Testing
---

windows msvc 2010


Thanks,

Patrick Spendrin


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 117832: use QFileInfo to also find hidden paths on windows

[Patrick Spendrin]

> On April 28, 2014, 1:24 p.m., Reece Dunn wrote:
> > The *A Windows API variants use the ASCII (referred to as ANSI in the 
> > Windows docs), not UTF-8, encoding. Therefore, this will not work as 
> > expected for non-ASCII characters. This should use SetFileAttributeW with 
> > toUtf16.

The files used in the test use ascii encoding though, so it works.
I'll change it anyway though.


- Patrick


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117832/#review56750
---


On April 28, 2014, 10:05 a.m., Patrick Spendrin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117832/
> ---
> 
> (Updated April 28, 2014, 10:05 a.m.)
> 
> 
> Review request for Baloo and kdewin.
> 
> 
> Repository: baloo
> 
> 
> Description
> ---
> 
> hidden files on windows must not start with a . So instead use QFileInfo to 
> correctly check that files are hidden and also modify the test and use the 
> native function.
> 
> 
> Diffs
> -
> 
>   src/file/autotest/fileindexerconfigutils.h ab52f3b 
> 
> Diff: https://git.reviewboard.kde.org/r/117832/diff/
> 
> 
> Testing
> ---
> 
> windows msvc 2010
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 117832: use QFileInfo to also find hidden paths on windows

[Reece Dunn]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117832/#review56750
---


The *A Windows API variants use the ASCII (referred to as ANSI in the Windows 
docs), not UTF-8, encoding. Therefore, this will not work as expected for 
non-ASCII characters. This should use SetFileAttributeW with toUtf16. 

- Reece Dunn


On April 28, 2014, 10:05 a.m., Patrick Spendrin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117832/
> ---
> 
> (Updated April 28, 2014, 10:05 a.m.)
> 
> 
> Review request for Baloo and kdewin.
> 
> 
> Repository: baloo
> 
> 
> Description
> ---
> 
> hidden files on windows must not start with a . So instead use QFileInfo to 
> correctly check that files are hidden and also modify the test and use the 
> native function.
> 
> 
> Diffs
> -
> 
>   src/file/autotest/fileindexerconfigutils.h ab52f3b 
> 
> Diff: https://git.reviewboard.kde.org/r/117832/diff/
> 
> 
> Testing
> ---
> 
> windows msvc 2010
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 117830: disable extended attributes support on windows

[Patrick Spendrin]

> On April 28, 2014, 12:41 p.m., Vishesh Handa wrote:
> > I'm a little surprised that NTFS doesn't support xattr, but sure!
> 
> Thomas Lübking wrote:
> NTFS /does/ support xattr (on ntfs-3g), but WinNT does support infinite 
> length xattr via ADS only, so basically xattr invocation would have to be 
> ported for Windows.

I think that would be indeed a way to address this, but I don't want to port it 
right away.


- Patrick


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117830/#review56737
---


On April 28, 2014, 9:58 a.m., Patrick Spendrin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117830/
> ---
> 
> (Updated April 28, 2014, 9:58 a.m.)
> 
> 
> Review request for Baloo and kdewin.
> 
> 
> Repository: baloo
> 
> 
> Description
> ---
> 
> At the moment, there is no support available for extended attributes for 
> Windows/NTFS. So we simply disable it.
> 
> 
> Diffs
> -
> 
>   src/file/lib/baloo_xattr_p.h fefc3d9 
>   src/file/lib/xattrdetector.cpp 9bff838 
> 
> Diff: https://git.reviewboard.kde.org/r/117830/diff/
> 
> 
> Testing
> ---
> 
> windows msvc 2010
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 117830: disable extended attributes support on windows

[Thomas Lübking]

> On April 28, 2014, 12:41 p.m., Vishesh Handa wrote:
> > I'm a little surprised that NTFS doesn't support xattr, but sure!

NTFS /does/ support xattr (on ntfs-3g), but WinNT does support infinite length 
xattr via ADS only, so basically xattr invocation would have to be ported for 
Windows.


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117830/#review56737
---


On April 28, 2014, 9:58 a.m., Patrick Spendrin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117830/
> ---
> 
> (Updated April 28, 2014, 9:58 a.m.)
> 
> 
> Review request for Baloo and kdewin.
> 
> 
> Repository: baloo
> 
> 
> Description
> ---
> 
> At the moment, there is no support available for extended attributes for 
> Windows/NTFS. So we simply disable it.
> 
> 
> Diffs
> -
> 
>   src/file/lib/baloo_xattr_p.h fefc3d9 
>   src/file/lib/xattrdetector.cpp 9bff838 
> 
> Diff: https://git.reviewboard.kde.org/r/117830/diff/
> 
> 
> Testing
> ---
> 
> windows msvc 2010
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 117825: exclude check for extended attributes for Windows

[Vishesh Handa]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117825/#review56742
---

Ship it!


Ship It!

- Vishesh Handa


On April 28, 2014, 9:41 a.m., Patrick Spendrin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117825/
> ---
> 
> (Updated April 28, 2014, 9:41 a.m.)
> 
> 
> Review request for Baloo and kdewin.
> 
> 
> Repository: baloo
> 
> 
> Description
> ---
> 
> at the moment, extended attributes are not supported on windows. The headers 
> do not exist as well, so the check fails all the time.
> 
> 
> Diffs
> -
> 
>   ConfigureChecks.cmake 34db1e4 
> 
> Diff: https://git.reviewboard.kde.org/r/117825/diff/
> 
> 
> Testing
> ---
> 
> msvc 2010
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 117827: malloc_trim is a gnu extension

[Vishesh Handa]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117827/#review56740
---

Ship it!


I was trying to keep the memory used by the process to a minimum and in this 
particular case free would not return the memory back to the kernel, hence the 
explicit trim command. Ship it for now. Maybe we want to use a better solution 
in the future.

- Vishesh Handa


On April 28, 2014, 9:48 a.m., Patrick Spendrin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117827/
> ---
> 
> (Updated April 28, 2014, 9:48 a.m.)
> 
> 
> Review request for Baloo and kdewin.
> 
> 
> Repository: baloo
> 
> 
> Description
> ---
> 
> malloc_trim is a gnu extension, so it doesn't work on windows. I am not sure 
> what the exact purpose of this call is (is the memory not freed elsewhere?), 
> so I'd like to have some comments on it.
> 
> 
> Diffs
> -
> 
>   src/xapian/xapiandatabase.cpp 0478139 
> 
> Diff: https://git.reviewboard.kde.org/r/117827/diff/
> 
> 
> Testing
> ---
> 
> windows msvc 2010
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 117826: check that the directories are actually really removed

[Vishesh Handa]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117826/#review56741
---

Ship it!


Ship It!

- Vishesh Handa


On April 28, 2014, 9:44 a.m., Patrick Spendrin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117826/
> ---
> 
> (Updated April 28, 2014, 9:44 a.m.)
> 
> 
> Review request for Baloo and kdewin.
> 
> 
> Repository: baloo
> 
> 
> Description
> ---
> 
> Since removing the directories still fails on windows atm, I want to let the 
> test fail in the correct place.
> 
> 
> Diffs
> -
> 
>   src/pim/akonadiplugin/autotests/searchplugintest.cpp 1c0b452 
> 
> Diff: https://git.reviewboard.kde.org/r/117826/diff/
> 
> 
> Testing
> ---
> 
> windows msvc 2010
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 117828: prevent ex/import in exported classes used in tests

[Vishesh Handa]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117828/#review56739
---

Ship it!


I don't get why MSVC doesn't just ignore it, but sure.

- Vishesh Handa


On April 28, 2014, 9:50 a.m., Patrick Spendrin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117828/
> ---
> 
> (Updated April 28, 2014, 9:50 a.m.)
> 
> 
> Review request for Baloo and kdewin.
> 
> 
> Repository: baloo
> 
> 
> Description
> ---
> 
> If using class definitions of exported classes in tests, the export/import 
> mechanism isn't needed. To prevent linker errors, set the EXPORT macro to 
> empty.
> 
> 
> Diffs
> -
> 
>   src/file/autotest/CMakeLists.txt a54736e 
>   src/file/autotest/fileindexingjob/CMakeLists.txt 811ed30 
>   src/file/lib/autotests/CMakeLists.txt 95a0916 
>   src/file/search/autotest/CMakeLists.txt eb058d2 
>   src/file/tests/CMakeLists.txt 102c981 
> 
> Diff: https://git.reviewboard.kde.org/r/117828/diff/
> 
> 
> Testing
> ---
> 
> windows msvc 2010
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 117829: do not raise unknown signal on windows

[Vishesh Handa]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117829/#review56738
---



src/file/autotest/fileindexingjob/extractor.cpp


Wouldn't exit just terminate the process normally? I was hoping to simulate 
a crash.


- Vishesh Handa


On April 28, 2014, 9:54 a.m., Patrick Spendrin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117829/
> ---
> 
> (Updated April 28, 2014, 9:54 a.m.)
> 
> 
> Review request for Baloo and kdewin.
> 
> 
> Repository: baloo
> 
> 
> Description
> ---
> 
> this signal is not available on windows. Also exit should behave in a similar 
> way, so maybe exit can be used everywhere?
> 
> 
> Diffs
> -
> 
>   src/file/autotest/fileindexingjob/extractor.cpp a6d14d7 
> 
> Diff: https://git.reviewboard.kde.org/r/117829/diff/
> 
> 
> Testing
> ---
> 
> windows msvc 2010
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 117830: disable extended attributes support on windows

[Vishesh Handa]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117830/#review56737
---

Ship it!


I'm a little surprised that NTFS doesn't support xattr, but sure!

- Vishesh Handa


On April 28, 2014, 9:58 a.m., Patrick Spendrin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117830/
> ---
> 
> (Updated April 28, 2014, 9:58 a.m.)
> 
> 
> Review request for Baloo and kdewin.
> 
> 
> Repository: baloo
> 
> 
> Description
> ---
> 
> At the moment, there is no support available for extended attributes for 
> Windows/NTFS. So we simply disable it.
> 
> 
> Diffs
> -
> 
>   src/file/lib/baloo_xattr_p.h fefc3d9 
>   src/file/lib/xattrdetector.cpp 9bff838 
> 
> Diff: https://git.reviewboard.kde.org/r/117830/diff/
> 
> 
> Testing
> ---
> 
> windows msvc 2010
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 117832: use QFileInfo to also find hidden paths on windows

[Vishesh Handa]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117832/#review56736
---

Ship it!


Ship It!

- Vishesh Handa


On April 28, 2014, 10:05 a.m., Patrick Spendrin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117832/
> ---
> 
> (Updated April 28, 2014, 10:05 a.m.)
> 
> 
> Review request for Baloo and kdewin.
> 
> 
> Repository: baloo
> 
> 
> Description
> ---
> 
> hidden files on windows must not start with a . So instead use QFileInfo to 
> correctly check that files are hidden and also modify the test and use the 
> native function.
> 
> 
> Diffs
> -
> 
>   src/file/autotest/fileindexerconfigutils.h ab52f3b 
> 
> Diff: https://git.reviewboard.kde.org/r/117832/diff/
> 
> 
> Testing
> ---
> 
> windows msvc 2010
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Review Request 117832: use QFileInfo to also find hidden paths on windows

[Patrick Spendrin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117832/
---

Review request for Baloo and kdewin.


Repository: baloo


Description
---

hidden files on windows must not start with a . So instead use QFileInfo to 
correctly check that files are hidden and also modify the test and use the 
native function.


Diffs
-

  src/file/autotest/fileindexerconfigutils.h ab52f3b 

Diff: https://git.reviewboard.kde.org/r/117832/diff/


Testing
---

windows msvc 2010


Thanks,

Patrick Spendrin


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Review Request 117830: disable extended attributes support on windows

[Patrick Spendrin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117830/
---

Review request for Baloo and kdewin.


Repository: baloo


Description
---

At the moment, there is no support available for extended attributes for 
Windows/NTFS. So we simply disable it.


Diffs
-

  src/file/lib/baloo_xattr_p.h fefc3d9 
  src/file/lib/xattrdetector.cpp 9bff838 

Diff: https://git.reviewboard.kde.org/r/117830/diff/


Testing
---

windows msvc 2010


Thanks,

Patrick Spendrin


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Review Request 117829: do not raise unknown signal on windows

[Patrick Spendrin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117829/
---

Review request for Baloo and kdewin.


Repository: baloo


Description
---

this signal is not available on windows. Also exit should behave in a similar 
way, so maybe exit can be used everywhere?


Diffs
-

  src/file/autotest/fileindexingjob/extractor.cpp a6d14d7 

Diff: https://git.reviewboard.kde.org/r/117829/diff/


Testing
---

windows msvc 2010


Thanks,

Patrick Spendrin


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Review Request 117828: prevent ex/import in exported classes used in tests

[Patrick Spendrin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117828/
---

Review request for Baloo and kdewin.


Repository: baloo


Description
---

If using class definitions of exported classes in tests, the export/import 
mechanism isn't needed. To prevent linker errors, set the EXPORT macro to empty.


Diffs
-

  src/file/autotest/CMakeLists.txt a54736e 
  src/file/autotest/fileindexingjob/CMakeLists.txt 811ed30 
  src/file/lib/autotests/CMakeLists.txt 95a0916 
  src/file/search/autotest/CMakeLists.txt eb058d2 
  src/file/tests/CMakeLists.txt 102c981 

Diff: https://git.reviewboard.kde.org/r/117828/diff/


Testing
---

windows msvc 2010


Thanks,

Patrick Spendrin


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Review Request 117827: malloc_trim is a gnu extension

[Patrick Spendrin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117827/
---

Review request for Baloo and kdewin.


Repository: baloo


Description
---

malloc_trim is a gnu extension, so it doesn't work on windows. I am not sure 
what the exact purpose of this call is (is the memory not freed elsewhere?), so 
I'd like to have some comments on it.


Diffs
-

  src/xapian/xapiandatabase.cpp 0478139 

Diff: https://git.reviewboard.kde.org/r/117827/diff/


Testing
---

windows msvc 2010


Thanks,

Patrick Spendrin


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Review Request 117826: check that the directories are actually really removed

[Patrick Spendrin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117826/
---

Review request for Baloo and kdewin.


Repository: baloo


Description
---

Since removing the directories still fails on windows atm, I want to let the 
test fail in the correct place.


Diffs
-

  src/pim/akonadiplugin/autotests/searchplugintest.cpp 1c0b452 

Diff: https://git.reviewboard.kde.org/r/117826/diff/


Testing
---

windows msvc 2010


Thanks,

Patrick Spendrin


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Review Request 117825: exclude check for extended attributes for Windows

[Patrick Spendrin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117825/
---

Review request for Baloo and kdewin.


Repository: baloo


Description
---

at the moment, extended attributes are not supported on windows. The headers do 
not exist as well, so the check fails all the time.


Diffs
-

  ConfigureChecks.cmake 34db1e4 

Diff: https://git.reviewboard.kde.org/r/117825/diff/


Testing
---

msvc 2010


Thanks,

Patrick Spendrin


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Baloo - [Basic Settings]

[Kevin Krammer]

On Sunday, 2014-04-27, 22:53:02, mk-li...@email.de wrote:
> Hi Vishesh,
> 
> On 23 Apr 2014, at 23:54 , Michael Pyne  wrote:
> > I'm not sure about [$]. There are other possibilities for a KConfig file
> > besides [$e] but I don't think [$] is one of them.
> 
> could you please clarify what the [$] means on your wiki page for the
> folders key?

My guess it is a typo and should be $e, like for exclude folders

See 
http://techbase.kde.org/KDE_System_Administration/Configuration_Files#Shell_Expansion

Cheers,
Kevin

-- 
Kevin Krammer, KDE developer, xdg-utils developer
KDE user support, developer mentoring


signature.asc
Description: This is a digitally signed message part.

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<