Phabricator Questions
Hey all, I got a few questions regarding Phabricator, can anyone answer them for me: * Can I merge a change request using the web UI? If not, how exactly do I use arc to merge a request I know via it's phabricator URL? * On the main website (https://phabricator.kde.org/) the dashboard shows me an "Unbreak Now!" list with tasks from WikiToLearn and GCompris, both of which I'm not interested in. How do I configure this list? In general, is there a way for me to configure phabricator such that it only lists stuff that I'm actually interested in? With KDE on Phabricator becoming larger and larger, I fear I'll drown in unrelated stuff. * In general, is there a way to configure the main website more to my likings, to show queries I'm actually interested in? That would solve the above. Thanks -- Milian Wolff m...@milianw.de http://milianw.de >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
Re: Review Request 125777: Monitor lib: Use Kformat::spelloutDuration to localize time string
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125777/ --- (Updated Oct. 28, 2015, 10:25 a.m.) Review request for Baloo and Vishesh Handa. Changes --- Use the default locale set by KFormat's ctor, instead of setting it explicitly. Repository: baloo Description --- KFormat::spelloutDuration works perfectly well for out use case, using it is a no brainer. Diffs (updated) - src/qml/experimental/CMakeLists.txt 0b06ac8 src/qml/experimental/monitor.cpp dfc7037 Diff: https://git.reviewboard.kde.org/r/125777/diff/ Testing --- Thanks, Pinak Ahuja >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
Re: Phabricator Questions
Hi, On Wed, Oct 28, 2015 at 10:47 AM, Milian Wolff wrote: > Hey all, > > I got a few questions regarding Phabricator, can anyone answer them for me: > > * Can I merge a change request using the web UI? If not, how exactly do I > use > arc to merge a request I know via it's phabricator URL? > The tool is arc land, to be run from the local branch that corresponds to the differential. I'm not sure how to get that branch from a differential if it wasn't you who created the differential. An arc patch seems to create a branch with a single commit, so if the differential contains multiple commits that history is lost. Andreas >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
Re: Phabricator Questions
On Wed, Oct 28, 2015 at 10:47 AM, Milian Wolff wrote: > Hey all, > > I got a few questions regarding Phabricator, can anyone answer them for me: > > * Can I merge a change request using the web UI? If not, how exactly do I use > arc to merge a request I know via it's phabricator URL? "arc patch D123" to apply the patch. I guess their plan is for us to merge the branch directly, so far I've used it to cherry-pick the patch I'm interested in. > > * On the main website (https://phabricator.kde.org/) the dashboard shows me an > "Unbreak Now!" list with tasks from WikiToLearn and GCompris, both of which > I'm not interested in. How do I configure this list? In general, is there a > way for me to configure phabricator such that it only lists stuff that I'm > actually interested in? With KDE on Phabricator becoming larger and larger, I > fear I'll drown in unrelated stuff. > > * In general, is there a way to configure the main website more to my likings, > to show queries I'm actually interested in? That would solve the above. I'm not sure. Aleix >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
Re: Debug ThreadWeaver::IdDecorator
Hi, Le 26/10/2015 21:02, Thiago Macieira a écrit : On Sunday 25 October 2015 21:19:52 Olivier Churlaud wrote: #0 0x70e497d4 in ThreadWeaver::IdDecorator::~IdDecorator() () from /usr/lib/libKF5ThreadWeaver.so.5 #1 0x70e50385 in ?? () from /usr/lib/libKF5ThreadWeaver.so.5 It would help if you recompiled the ThreadWeaver library in debug mode so we can see what the ?? are. Thx for your hint. I compiled ThreadWeaver successfully but I don't know how to tell cmake to link it to this version of ThreadWeaver (and not the one in /usr/lib64) I added this to the cmake command: -DCMAKE_PREFIX_PATH=/home/olivier/Projets/threadweather/build/install it didn't work. For information, the CmakeList.txt contains: find_package( KF5 REQUIRED COMPONENTS CoreAddons Solid KDELibs4Support Codecs I18n ThreadWeaver Plasma PlasmaQuick KCMUtils NewStuff TextEditor GlobalAccel KIO NotifyConfig Archive DNSSD) I cleaned my /build folder with a rm -rf. Cheers, Olivier Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
Re: Debug ThreadWeaver::IdDecorator
Or install the debuginfo package from your distro... On Wed, Oct 28, 2015 at 6:38 AM, Olivier Churlaud wrote: > > Hi, > > Le 26/10/2015 21:02, Thiago Macieira a écrit : >> >> On Sunday 25 October 2015 21:19:52 Olivier Churlaud wrote: >>> >>> #0 0x70e497d4 in ThreadWeaver::IdDecorator::~IdDecorator() () >>> from /usr/lib/libKF5ThreadWeaver.so.5 >>> #1 0x70e50385 in ?? () from /usr/lib/libKF5ThreadWeaver.so.5 >> >> It would help if you recompiled the ThreadWeaver library in debug mode so >> we >> can see what the ?? are. > > Thx for your hint. I compiled ThreadWeaver successfully but I don't know > how to tell cmake to link it to this version of ThreadWeaver (and not > the one in /usr/lib64) > > I added this to the cmake command: > -DCMAKE_PREFIX_PATH=/home/olivier/Projets/threadweather/build/install > > it didn't work. > > For information, the CmakeList.txt contains: > > find_package( KF5 REQUIRED COMPONENTS CoreAddons Solid KDELibs4Support > Codecs I18n ThreadWeaver Plasma PlasmaQuick KCMUtils NewStuff TextEditor > GlobalAccel KIO NotifyConfig Archive DNSSD) > > I cleaned my /build folder with a rm -rf. > > Cheers, > Olivier > > > > > >>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe >>> << >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
Re: Debug ThreadWeaver::IdDecorator
here is the gdb output https://paste.kde.org/pkek8mo97 here is the valgrind output https://paste.kde.org/pw5ghd3sf hope this helps cheers, rishabh On Wed, Oct 28, 2015 at 6:16 PM, Jeremy Whiting wrote: > Or install the debuginfo package from your distro... > > On Wed, Oct 28, 2015 at 6:38 AM, Olivier Churlaud > wrote: > > > > Hi, > > > > Le 26/10/2015 21:02, Thiago Macieira a écrit : > >> > >> On Sunday 25 October 2015 21:19:52 Olivier Churlaud wrote: > >>> > >>> #0 0x70e497d4 in ThreadWeaver::IdDecorator::~IdDecorator() () > >>> from /usr/lib/libKF5ThreadWeaver.so.5 > >>> #1 0x70e50385 in ?? () from /usr/lib/libKF5ThreadWeaver.so.5 > >> > >> It would help if you recompiled the ThreadWeaver library in debug mode > so > >> we > >> can see what the ?? are. > > > > Thx for your hint. I compiled ThreadWeaver successfully but I don't know > > how to tell cmake to link it to this version of ThreadWeaver (and not > > the one in /usr/lib64) > > > > I added this to the cmake command: > > -DCMAKE_PREFIX_PATH=/home/olivier/Projets/threadweather/build/install > > > > it didn't work. > > > > For information, the CmakeList.txt contains: > > > > find_package( KF5 REQUIRED COMPONENTS CoreAddons Solid KDELibs4Support > > Codecs I18n ThreadWeaver Plasma PlasmaQuick KCMUtils NewStuff TextEditor > > GlobalAccel KIO NotifyConfig Archive DNSSD) > > > > I cleaned my /build folder with a rm -rf. > > > > Cheers, > > Olivier > > > > > > > > > > > >>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to > unsubscribe > >>> << > > >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to > unsubscribe << > >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
Re: Debug ThreadWeaver::IdDecorator
this is the output after i installed debug symbols for threadweaver .although the above output doesn't have any '?? ' but I guess this one will be more useful gdb output https://paste.kde.org/p5mt7noys On Wed, Oct 28, 2015 at 6:42 PM, RISHABH GUPTA wrote: > here is the gdb output > https://paste.kde.org/pkek8mo97 > > here is the valgrind output > https://paste.kde.org/pw5ghd3sf > > hope this helps > cheers, > rishabh > > On Wed, Oct 28, 2015 at 6:16 PM, Jeremy Whiting wrote: > >> Or install the debuginfo package from your distro... >> >> On Wed, Oct 28, 2015 at 6:38 AM, Olivier Churlaud >> wrote: >> > >> > Hi, >> > >> > Le 26/10/2015 21:02, Thiago Macieira a écrit : >> >> >> >> On Sunday 25 October 2015 21:19:52 Olivier Churlaud wrote: >> >>> >> >>> #0 0x70e497d4 in ThreadWeaver::IdDecorator::~IdDecorator() () >> >>> from /usr/lib/libKF5ThreadWeaver.so.5 >> >>> #1 0x70e50385 in ?? () from /usr/lib/libKF5ThreadWeaver.so.5 >> >> >> >> It would help if you recompiled the ThreadWeaver library in debug mode >> so >> >> we >> >> can see what the ?? are. >> > >> > Thx for your hint. I compiled ThreadWeaver successfully but I don't know >> > how to tell cmake to link it to this version of ThreadWeaver (and not >> > the one in /usr/lib64) >> > >> > I added this to the cmake command: >> > -DCMAKE_PREFIX_PATH=/home/olivier/Projets/threadweather/build/install >> > >> > it didn't work. >> > >> > For information, the CmakeList.txt contains: >> > >> > find_package( KF5 REQUIRED COMPONENTS CoreAddons Solid KDELibs4Support >> > Codecs I18n ThreadWeaver Plasma PlasmaQuick KCMUtils NewStuff TextEditor >> > GlobalAccel KIO NotifyConfig Archive DNSSD) >> > >> > I cleaned my /build folder with a rm -rf. >> > >> > Cheers, >> > Olivier >> > >> > >> > >> > >> > >> >>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to >> unsubscribe >> >>> << >> >> >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to >> unsubscribe << >> > > >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
Re: Re: Debug ThreadWeaver::IdDecorator
Hello I finally managed to install the Threadweaver in debug mod. Fulltrace in gdb : https://paste.kde.org/pdnashan2 in valgrind https://paste.kde.org/pwooi9alf Thx for your hints Cheers Olivier Le 26/10/2015 21:02, Thiago Macieira a écrit : On Sunday 25 October 2015 21:19:52 Olivier Churlaud wrote: #0 0x70e497d4 in ThreadWeaver::IdDecorator::~IdDecorator() () from /usr/lib/libKF5ThreadWeaver.so.5 #1 0x70e50385 in ?? () from /usr/lib/libKF5ThreadWeaver.so.5 It would help if you recompiled the ThreadWeaver library in debug mode so we can see what the ?? are. Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
Re: Debug ThreadWeaver::IdDecorator
On Mittwoch, 28. Oktober 2015 14:33:02 CEST, Olivier Churlaud wrote: Hello I finally managed to install the Threadweaver in debug mod. Fulltrace in gdb : https://paste.kde.org/pdnashan2 in valgrind https://paste.kde.org/pwooi9alf Thx for your hints W/o even looking at the code (is it pushed somewhere at all?) - you're not explicitly deleting and autodelete (by default) IdDecorator, are you? Cheers, Thomas Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
Re: Phabricator Questions
On Wed, Oct 28, 2015 at 10:47 PM, Milian Wolff wrote: > Hey all, Hi Milian, > > I got a few questions regarding Phabricator, can anyone answer them for me: > > * Can I merge a change request using the web UI? If not, how exactly do I use > arc to merge a request I know via it's phabricator URL? > > * On the main website (https://phabricator.kde.org/) the dashboard shows me an > "Unbreak Now!" list with tasks from WikiToLearn and GCompris, both of which > I'm not interested in. How do I configure this list? In general, is there a > way for me to configure phabricator such that it only lists stuff that I'm > actually interested in? With KDE on Phabricator becoming larger and larger, I > fear I'll drown in unrelated stuff. > > * In general, is there a way to configure the main website more to my likings, > to show queries I'm actually interested in? That would solve the above. Phabricator is extremely customisable, on a per-user basis in this regard. Please use the Dashboards application to create a personal dashboard, which you can then set as the front page. These dashboards can then be shared with other users if you wish. > > Thanks Regards, Ben > -- > Milian Wolff > m...@milianw.de > http://milianw.de >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
Re: Review Request 125777: Monitor lib: Use Kformat::spelloutDuration to localize time string
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125777/#review87608 --- Ship it! Ship It! - Vishesh Handa On Oct. 28, 2015, 10:25 a.m., Pinak Ahuja wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125777/ > --- > > (Updated Oct. 28, 2015, 10:25 a.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > --- > > KFormat::spelloutDuration works perfectly well for out use case, using it is > a no brainer. > > > Diffs > - > > src/qml/experimental/CMakeLists.txt 0b06ac8 > src/qml/experimental/monitor.cpp dfc7037 > > Diff: https://git.reviewboard.kde.org/r/125777/diff/ > > > Testing > --- > > > Thanks, > > Pinak Ahuja > > >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
Re: Re: Debug ThreadWeaver::IdDecorator
Le 28/10/2015 16:08, Thomas Lübking a écrit : On Mittwoch, 28. Oktober 2015 14:33:02 CEST, Olivier Churlaud wrote: Hello I finally managed to install the Threadweaver in debug mod. Fulltrace in gdb : https://paste.kde.org/pdnashan2 in valgrind https://paste.kde.org/pwooi9alf Thx for your hints W/o even looking at the code (is it pushed somewhere at all?) - you're not explicitly deleting and autodelete (by default) IdDecorator, are you? Cheers, Thomas The code is pushed on amarok, branch kf5. IdDecorator is never mentioned anywhere in the code. Only derived classes. It works well in the KDE4 environnement (since the amarok devs are able to compile it and running it well) but not on the KF5 one. That's why I asked it there, because it might be a modification in the library that I'm not aware of. (for instance I had trouble before because the Threadweaver::Job class was constructed with Job job(0) to indicate "no parent" and now it would do a copy of the null pointer) Thank you Olivier Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
Re: Phabricator Questions
On Thursday, October 29, 2015 6:14:22 AM CET Ben Cooksley wrote: > On Wed, Oct 28, 2015 at 10:47 PM, Milian Wolff wrote: > > Hey all, > > Hi Milian, > > > I got a few questions regarding Phabricator, can anyone answer them for > > me: > > > > * Can I merge a change request using the web UI? If not, how exactly do I > > use arc to merge a request I know via it's phabricator URL? > > > > * On the main website (https://phabricator.kde.org/) the dashboard shows > > me an "Unbreak Now!" list with tasks from WikiToLearn and GCompris, both > > of which I'm not interested in. How do I configure this list? In general, > > is there a way for me to configure phabricator such that it only lists > > stuff that I'm actually interested in? With KDE on Phabricator becoming > > larger and larger, I fear I'll drown in unrelated stuff. > > > > * In general, is there a way to configure the main website more to my > > likings, to show queries I'm actually interested in? That would solve the > > above. > > Phabricator is extremely customisable, on a per-user basis in this > regard. Please use the Dashboards application to create a personal > dashboard, which you can then set as the front page. These dashboards > can then be shared with other users if you wish. That is nice! For others: You first need to create custom queries, then you can select them in the dashboard. Not very intuitive, but it seems to work: https://phabricator.kde.org/dashboard/manage/8/ This brings me to another question: What is a project on Phabricator? Just a collection of tasks and people? I don't seem to be able to associate repositories with a project or vice versa, so one needs to manually lists repositories in a commit feed, right? Cheers -- Milian Wolff m...@milianw.de http://milianw.de >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
Re: Debug ThreadWeaver::IdDecorator
On Wed, October 28, 2015 18:45:40 Olivier Churlaud wrote:
> Le 28/10/2015 16:08, Thomas Lübking a écrit :
> > On Mittwoch, 28. Oktober 2015 14:33:02 CEST, Olivier Churlaud wrote:
> >> Hello
> >>
> >> I finally managed to install the Threadweaver in debug mod.
> >>
> >> Fulltrace in gdb : https://paste.kde.org/pdnashan2
> >>
> >> in valgrind https://paste.kde.org/pwooi9alf
> >>
> >> Thx for your hints
> >
> > W/o even looking at the code (is it pushed somewhere at all?) - you're
> > not explicitly deleting and autodelete (by default) IdDecorator, are you?
> >
> > Cheers,
> > Thomas
>
> The code is pushed on amarok, branch kf5.
>
> IdDecorator is never mentioned anywhere in the code. Only derived classes.
> It works well in the KDE4 environnement (since the amarok devs are able
> to compile it and running it well) but not on the KF5 one. That's why I
> asked it there, because it might be a modification in the library that
> I'm not aware of.
It seems to me that there is a double-deletion going on, likely due to a
manual deletion of the ThreadWeaver job after it is completed at src / core-
impl / collections / db / sql / SqlQueryMaker.cpp:234, and likely also at line
160 with similar reasoning.
Line 234 contains
> void
> SqlQueryMaker::done( ThreadWeaver::JobPointer job )
> {
>
> ThreadWeaver::QObjectDecorator *qs = new
> ThreadWeaver::QObjectDecorator(job.data()); qs->deleteLater();
> d->worker = 0; // d->worker *is* the job, prevent stale pointer
> emit queryDone();
>
> }
In this case ThreadWeaver::JobPointer is a QSharedPointer which means that the
QSharedPointer controls the object lifetime for this sql worker thread.
However the pointer is manually pulled out of the QSharedPointer (by
job.data()) and then manually deleted.
By the time the actual QSharedPointer is ready to delete the pointer, it has
already been deleted thanks to the qs->deleteLater(), which causes the crash
you see.
This is also where you see the "IdDecorator" stuff from: IdDecorator is a
superclass of the QObjectDecorator that was wrapped around d->worker.
From the moment that d->worker was enqueue()'d into ThreadWeaver (in line 212)
Amarok lost control of its object lifetime, and therefore should not attempt
to delete it manually.
Instead just let ThreadWeaver control the object lifetime. If you wish for the
code to work in both the ThreadWeaver and non-ThreadWeaver cases you should at
least also check for d->blocking when manually deleting d->worker.
Regards,
- Michael Pyne
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
