D8154: Minor spell check interface fixes
dhaumann added a comment. Looks already quite good. Btw, are there any bug reports in the Kate or frameworks-ktexteditor product on bugs.kde.org that you fix here? INLINE COMMENTS > spellcheckdialog.cpp:198 > > - > m_currentSpellCheckRange.setRange(KTextEditor::Range(replacementStartCursor, > m_currentSpellCheckRange.end())); > // we have to be careful here: due to static word wrapping the text > might change in addition to simply Hm, could you explain why removing this line is correct? Is it because in line 202 we continue with the replacementStartCursor anyway? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D8154 To: croick, #ktexteditor Cc: dhaumann, #frameworks, cullmann, sars
KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 112 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/112/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Fri, 06 Oct 2017 03:02:10 + Build duration: 2 min 23 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.qmltests Cobertura Report Project Coverage Summary Name Cobertura Coverage Report
KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 106 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/106/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Fri, 06 Oct 2017 03:02:10 + Build duration: 1 min 20 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests
D8154: Minor spell check interface fixes
croick added inline comments. INLINE COMMENTS > spellcheckbar.cpp:146 > d->deleteProgressDialog(false); // this method can be called in response > to > +d->replaceAllMap.clear(); > // pressing 'Cancel' on the dialog This might have been a feature, but without clearing the map, there is no way to revert a "Replace All"-word, except for restarting the editor. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D8154 To: croick, #ktexteditor Cc: #frameworks, cullmann, sars, dhaumann
D8154: Minor spell check interface fixes
croick created this revision. croick added a reviewer: KTextEditor. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY - empty document does not resize bar widget when spell check is started without effect - replacing the last word with an empty text does not leave the progress bar open - show first suggestion in suggestion combo box - clear replace-all-list when checking is finished TEST PLAN - perform spell check on empty document - replace trailing misspelled word in document with empty string - recheck spelling of former "Replace All" word REPOSITORY R39 KTextEditor BRANCH spellfixes REVISION DETAIL https://phabricator.kde.org/D8154 AFFECTED FILES src/spellcheck/spellcheckbar.cpp src/spellcheck/spellcheckdialog.cpp To: croick, #ktexteditor Cc: #frameworks, cullmann, sars, dhaumann
[ANNOUNCE] CMake 3.10.0-rc1 is now ready for testing
I am proud to announce the first CMake 3.10 release candidate.
https://cmake.org/download/
Documentation is available at:
https://cmake.org/cmake/help/v3.10
Release notes appear below and are also published at
https://cmake.org/cmake/help/v3.10/release/3.10.html
Some of the more significant changes in CMake 3.10 are:
* The flang Fortran compiler is now supported, with compiler id
"Flang".
* Support for the MSVC ARM64 architecture was added. Visual Studio
2017 Update 4 and above offer an ARM64 toolchain.
* The "include_guard()" command was introduced to allow guarding
CMake scripts from being included more than once. The command
supports "DIRECTORY" and "GLOBAL" options to adjust the
corresponding include guard scope. If no options given, include
guard is similar to basic variable-based check.
* "FindMPI" received a major overhaul. It now features language specific
components, better Fortran support, and support for statically linked
MPI implementations.
* A "FindOpenACC" module was added to detect compiler support for
OpenACC. Currently only supports PGI, GNU and Cray compilers.
* The "FindOpenGL" module underwent numerous improvements. It has gained
support for GLVND and EGL on Linux. It now has import targets that
separate the OpenGL library and OpenGL contexts.
* The "GoogleTest" module gained a new command
"gtest_discover_tests()" implementing dynamic (build-time) test
discovery.
* When using "AUTOMOC" or "AUTOUIC", source files that are
"GENERATED" will be processed as well. They were ignored by
"AUTOMOC" and "AUTOUIC" in earlier releases. See policy "CMP0071".
* A "CTEST_LABELS_FOR_SUBPROJECTS" CTest module variable and CTest
script variable were added to specify a list of labels that should
be treated as subprojects by CDash. To use this value in both the
CTest module and the ctest command line Dashboard Client mode (e.g.
"ctest -S") set it in the "CTestConfig.cmake" config file.
* CPack gained a "FREEBSD" generator for FreeBSD "pkg(8)",
configured by the "CPackFreeBSD" module.
* The CPack "DEB" generator, configured by the "CPackDeb" module,
was enabled on Windows. While not fully featured (due to the lack
of external UNIX tools) this will allow building basic cross-
platform Debian packages.
* The "cmake(1)" "-E" mode gained support for "sha1sum",
"sha224sum", "sha256sum", "sha384sum", and "sha512sum".
* The "file(GENERATE)" command now interprets relative paths given
to its "OUTPUT" and "INPUT" arguments with respect to the caller's
current binary and source directories, respectively. See policy
"CMP0070".
CMake 3.10 Release Notes
Changes made since CMake 3.9 include the following.
New Features
Platforms
-
* The flang Fortran compiler is now supported, with compiler id
"Flang".
* A new minimal platform file for "Midipix" was added.
* Support for the MSVC ARM64 architecture was added. Visual Studio
2017 Update 4 and above offer an ARM64 toolchain.
* Support for the IAR ARM Compiler was improved.
Generators
--
* The Makefile Generators and the "Ninja" generator learned to add
compiler launcher tools like ccache along with the compiler for the
"CUDA" language ("C" and "CXX" were supported previously). See the
"CMAKE__COMPILER_LAUNCHER" variable and
"_COMPILER_LAUNCHER" target property for details.
* The "CodeBlocks" extra generator learned to optionally exclude
files from outside the project root directory from the generated
project. See the "CMAKE_CODEBLOCKS_EXCLUDE_EXTERNAL_FILES" variable.
Commands
* The "cmake_host_system_information()" command learned more keys to
get information about the processor capabilities and the host OS
version.
* The "configure_file()" command learned to support indented "#
cmakedefine" and "# cmakedefine01". Spaces and/or tabs between the
"#" character and the "cmakedefine"/"cmakedefine01" words are now
understood and preserved in the output.
* The "execute_process()" command gained a "RESULTS_VARIABLE" option
to collect a list of results from all children in a pipeline of
processes when multiple "COMMAND" arguments are given.
* The "include_guard()" command was introduced to allow guarding
CMake scripts from being included more than once. The command
supports "DIRECTORY" and "GLOBAL" options to adjust the
corresponding include guard scope. If no options given, include
guard is similar to basic variable-based check.
* The "string()" command learned a new "PREPEND" subcommand.
* The "string(TIMESTAMP)" command now supports "%A" for full weekday
name and "%B" for full month name.
Variables
-
* A "CMAKE_DIRECTORY_LABELS" variable was added to specify labels
for all tests in a directory.
Properties
--
* A "_CPPCHECK" target property and supporting
"CMAKE__CPPCHECK" variable were introduced to tell the
Makefile Generators and the "Ninja"
KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 79 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/79/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 Date of build: Thu, 05 Oct 2017 20:07:42 + Build duration: 9 min 54 sec and counting JUnit Tests Name: (root) Failed: 3 test(s), Passed: 63 test(s), Skipped: 0 test(s), Total: 66 test(s)Failed: TestSuite.commands_testFailed: TestSuite.kateindenttest_testCstyleFailed: TestSuite.scripting_test
KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 78 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/78/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 Date of build: Thu, 05 Oct 2017 19:56:04 + Build duration: 11 min and counting JUnit Tests Name: (root) Failed: 3 test(s), Passed: 63 test(s), Skipped: 0 test(s), Total: 66 test(s)Failed: TestSuite.commands_testFailed: TestSuite.kateindenttest_testCstyleFailed: TestSuite.scripting_test
D8147: Use QActionGroup for input mode selection
This revision was automatically updated to reflect the committed changes. Closed by commit R39:9d1a97532ce3: Use QActionGroup for input mode selection (authored by croick). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8147?vs=20359=20377 REVISION DETAIL https://phabricator.kde.org/D8147 AFFECTED FILES src/view/kateview.cpp src/view/kateview.h To: croick, #ktexteditor, dhaumann Cc: dhaumann, #frameworks, cullmann, sars
D8148: Fix missing spell check bar
This revision was automatically updated to reflect the committed changes. Closed by commit R39:9a77f365de57: Fix missing spell check bar (authored by croick). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8148?vs=20360=20376 REVISION DETAIL https://phabricator.kde.org/D8148 AFFECTED FILES src/spellcheck/spellcheckdialog.cpp To: croick, #ktexteditor, dhaumann Cc: dhaumann, #frameworks, cullmann, sars
KDE Applications 17.12 release schedule
Hi people, So that you know this is the release schedule the release team agreed on. https://community.kde.org/Schedules/Applications/17.12_Release_Schedule *REMEMBER* That we're not going to ship apps that are based on kdelibs4, please try to keep https://community.kde.org/Applications/17.12_repo_drop_list_kdelibs4 as up to date as possible. Cheers, Albert
KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 111 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/111/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Thu, 05 Oct 2017 16:16:41 + Build duration: 1 min 4 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.qmltests Cobertura Report Project Coverage Summary Name Cobertura Coverage Report
KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 105 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/105/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Thu, 05 Oct 2017 16:16:41 + Build duration: 42 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests
KDE CI: Frameworks qqc2-desktop-style kf5-qt5 WindowsMSVCQt5.9 - Build # 11 - Still Failing!
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20qqc2-desktop-style%20kf5-qt5%20WindowsMSVCQt5.9/11/
Project:
Frameworks qqc2-desktop-style kf5-qt5 WindowsMSVCQt5.9
Date of build:
Thu, 05 Oct 2017 15:53:53 +
Build duration:
32 sec and counting
CONSOLE OUTPUT
[...truncated 14.52 KB...] > git config core.sparsecheckout # timeout=10 > git checkout -f 3593820d35e0d02540d054525cfec4aa59e20223[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/sysadmin/repo-metadata > git init C:\CI\workspace\Frameworks qqc2-desktop-style kf5-qt5 WindowsMSVCQt5.9\ci-tooling\repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* > git rev-parse "origin/master^{commit}" # timeout=10Checking out Revision b25d1270ebe84d6903b6af56da76912b80d23dd2 (origin/master)Commit message: "Move latte-dock to kdereview" > git config core.sparsecheckout # timeout=10 > git checkout -f b25d1270ebe84d6903b6af56da76912b80d23dd2[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/kde-build-metadata > git init C:\CI\workspace\Frameworks qqc2-desktop-style kf5-qt5 WindowsMSVCQt5.9\ci-tooling\kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* > git rev-parse "origin/master^{commit}" # timeout=10Checking out Revision efe4d9ddce0873ca9551e1ed94b422cf065511a6 (origin/master)Commit message: "Update JuK to reflect merge of frameworks branch into master." > git config core.sparsecheckout # timeout=10 > git checkout -f efe4d9ddce0873ca9551e1ed94b422cf065511a6[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Setup Dependencies)[Pipeline] bat[Frameworks qqc2-desktop-style kf5-qt5 WindowsMSVCQt5.9] Running batch scriptC:\CI\workspace\Frameworks qqc2-desktop-style kf5-qt5 WindowsMSVCQt5.9>python -u ci-tooling/helpers/prepare-dependencies.py --product Frameworks --project qqc2-desktop-style --branchGroup kf5-qt5 --environment production --platform WindowsMSVCQt5.9 --installTo "C:\CI\workspace\Frameworks qqc2-desktop-style kf5-qt5 WindowsMSVCQt5.9/install-prefix/" Retrieving: Frameworks-extra-cmake-modules-kf5-qt5[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Configuring Build)[Pipeline] bat[Frameworks qqc2-desktop-style kf5-qt5 WindowsMSVCQt5.9] Running batch scriptC:\CI\workspace\Frameworks qqc2-desktop-style kf5-qt5 WindowsMSVCQt5.9>call "C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Auxiliary/Build/vcvars64.bat" Visual Studio 2017 Developer Command Prompt v15.0.26730.15** Copyright (c) 2017 Microsoft Corporation**[vcvarsall.bat] Environment initialized for: 'x64'cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="C:\CI\workspace\Frameworks qqc2-desktop-style kf5-qt5 WindowsMSVCQt5.9/install-prefix/" -G "NMake Makefiles JOM" "C:\CI\workspace\Frameworks qqc2-desktop-style kf5-qt5 WindowsMSVCQt5.9"-- The C compiler identification is MSVC 19.11.25508.2-- The CXX compiler identification is MSVC 19.11.25508.2-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Tools/MSVC/14.11.25503/bin/HostX64/x64/cl.exe-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Tools/MSVC/14.11.25503/bin/HostX64/x64/cl.exe -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual
KDE CI: Frameworks qqc2-desktop-style kf5-qt5 XenialQt5.7 - Build # 11 - Still Failing!
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20qqc2-desktop-style%20kf5-qt5%20XenialQt5.7/11/
Project:
Frameworks qqc2-desktop-style kf5-qt5 XenialQt5.7
Date of build:
Thu, 05 Oct 2017 15:53:53 +
Build duration:
41 sec and counting
CONSOLE OUTPUT
[...truncated 31.92 KB...] > git config remote.origin.url https://anongit.kde.org/kapidox # timeout=10Fetching upstream changes from https://anongit.kde.org/kapidox > git fetch --tags --progress https://anongit.kde.org/kapidox +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision 16dfe9c5afa16b2f3d1e62bf0e0f5dc6c852ff5e (origin/master)Commit message: "GIT_SILENT Upgrade KF5 version to 5.39.0." > git config core.sparsecheckout # timeout=10 > git checkout -f 16dfe9c5afa16b2f3d1e62bf0e0f5dc6c852ff5e[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/kde-dev-scripts > git init /home/jenkins/workspace/Frameworks qqc2-desktop-style kf5-qt5 XenialQt5.7/ci-tooling/kde-dev-scripts # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-dev-scripts > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/kde-dev-scripts +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/kde-dev-scripts # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/kde-dev-scripts # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-dev-scripts > git fetch --tags --progress https://anongit.kde.org/kde-dev-scripts +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision 1a3c513450ffb2eeaf8d866878779b28d185f90c (origin/master)Commit message: "Improve conversion of translations in PO files" > git config core.sparsecheckout # timeout=10 > git checkout -f 1a3c513450ffb2eeaf8d866878779b28d185f90c[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Setup Dependencies)[Pipeline] sh[Frameworks qqc2-desktop-style kf5-qt5 XenialQt5.7] Running shell script+ python3 -u ci-tooling/helpers/prepare-dependencies.py --product Frameworks --project qqc2-desktop-style --branchGroup kf5-qt5 --environment production --platform XenialQt5.7 --installTo /home/jenkins/install-prefix/Retrieving: Frameworks-extra-cmake-modules-kf5-qt5[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Configuring Build)[Pipeline] sh[Frameworks qqc2-desktop-style kf5-qt5 XenialQt5.7] Running shell script+ python3 -u ci-tooling/helpers/configure-build.py --product Frameworks --project qqc2-desktop-style --branchGroup kf5-qt5 --platform XenialQt5.7 --installTo /home/jenkins/install-prefix/cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/" -DBUILD_COVERAGE=ON "/home/jenkins/workspace/Frameworks qqc2-desktop-style kf5-qt5 XenialQt5.7"-- The C compiler identification is GNU 5.4.0-- The CXX compiler identification is GNU 5.4.0-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - SuccessCMake Warning at /home/jenkins/install-prefix/share/ECM/find-modules/FindKF5.cmake:74 (find_package): Could not find a package configuration file provided by "KF5Kirigami2" with any of the following names:KF5Kirigami2Config.cmakekf5kirigami2-config.cmake Add the installation prefix of "KF5Kirigami2" to CMAKE_PREFIX_PATH or set "KF5Kirigami2_DIR" to a directory containing one of the above files. If "KF5Kirigami2" provides a separate development package or SDK, be sure it has been installed.Call Stack (most recent call first): CMakeLists.txt:36 (find_package)-- Could NOT find KF5Kirigami2: found neither KF5Kirigami2Config.cmake nor kf5kirigami2-config.cmake CMake Error at /usr/share/cmake-3.5/Modules/FindPackageHandleStandardArgs.cmake:148 (message): Could NOT find KF5 (missing: Kirigami2)Call Stack (most recent call first): /usr/share/cmake-3.5/Modules/FindPackageHandleStandardArgs.cmake:388 (_FPHSA_FAILURE_MESSAGE) /home/jenkins/install-prefix/share/ECM/find-modules/FindKF5.cmake:110 (find_package_handle_standard_args) CMakeLists.txt:36 (find_package)-- Configuring incomplete, errors occurred!See also
KDE CI: Frameworks qqc2-desktop-style kf5-qt5 FreeBSDQt5.7 - Build # 11 - Still Failing!
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20qqc2-desktop-style%20kf5-qt5%20FreeBSDQt5.7/11/
Project:
Frameworks qqc2-desktop-style kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 05 Oct 2017 15:53:53 +
Build duration:
36 sec and counting
CONSOLE OUTPUT
[...truncated 13.30 KB...] > git rev-parse origin/master^{commit} # timeout=10Checking out Revision 3593820d35e0d02540d054525cfec4aa59e20223 (origin/master)Commit message: "Enable GCompris on the CI system for Linux and FreeBSD. Fixes T7083" > git config core.sparsecheckout # timeout=10 > git checkout -f 3593820d35e0d02540d054525cfec4aa59e20223[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/sysadmin/repo-metadata > git init /usr/home/jenkins/workspace/Frameworks qqc2-desktop-style kf5-qt5 FreeBSDQt5.7/ci-tooling/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision b25d1270ebe84d6903b6af56da76912b80d23dd2 (origin/master)Commit message: "Move latte-dock to kdereview" > git config core.sparsecheckout # timeout=10 > git checkout -f b25d1270ebe84d6903b6af56da76912b80d23dd2[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/kde-build-metadata > git init /usr/home/jenkins/workspace/Frameworks qqc2-desktop-style kf5-qt5 FreeBSDQt5.7/ci-tooling/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision efe4d9ddce0873ca9551e1ed94b422cf065511a6 (origin/master)Commit message: "Update JuK to reflect merge of frameworks branch into master." > git config core.sparsecheckout # timeout=10 > git checkout -f efe4d9ddce0873ca9551e1ed94b422cf065511a6[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Setup Dependencies)[Pipeline] sh[Frameworks qqc2-desktop-style kf5-qt5 FreeBSDQt5.7] Running shell script+ python3.5 -u ci-tooling/helpers/prepare-dependencies.py --product Frameworks --project qqc2-desktop-style --branchGroup kf5-qt5 --environment production --platform FreeBSDQt5.7 --installTo '/usr/home/jenkins/workspace/Frameworks qqc2-desktop-style kf5-qt5 FreeBSDQt5.7/install-prefix/'Retrieving: Frameworks-extra-cmake-modules-kf5-qt5[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Configuring Build)[Pipeline] sh[Frameworks qqc2-desktop-style kf5-qt5 FreeBSDQt5.7] Running shell script+ python3.5 -u ci-tooling/helpers/configure-build.py --product Frameworks --project qqc2-desktop-style --branchGroup kf5-qt5 --platform FreeBSDQt5.7 --installTo '/usr/home/jenkins/workspace/Frameworks qqc2-desktop-style kf5-qt5 FreeBSDQt5.7/install-prefix/'cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/usr/home/jenkins/workspace/Frameworks qqc2-desktop-style kf5-qt5 FreeBSDQt5.7/install-prefix/" "/usr/home/jenkins/workspace/Frameworks qqc2-desktop-style kf5-qt5 FreeBSDQt5.7"-- The C compiler identification is Clang 3.8.0-- The CXX compiler identification is Clang 3.8.0-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- Could not set up the appstream test. appstreamcli is missing.-- Looking for __GLIBC__-- Looking for __GLIBC__ - not
KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 110 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/110/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Thu, 05 Oct 2017 15:49:52 + Build duration: 1 min 13 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.qmltests Cobertura Report Project Coverage Summary Name Cobertura Coverage Report
KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 104 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/104/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Thu, 05 Oct 2017 15:49:52 + Build duration: 1 min 33 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests
D6914: Switch from QtScript to QtQml
rjvbb added a comment. Seems I found a crasher: https://bugs.kde.org/show_bug.cgi?id=385398 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D6914 To: carewolf, cullmann, dhaumann, #frameworks Cc: rjvbb, dfaure, cullmann, #frameworks
KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 109 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/109/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Thu, 05 Oct 2017 13:45:14 + Build duration: 1 min 4 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.qmltests Cobertura Report Project Coverage Summary Name Cobertura Coverage Report
KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 103 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/103/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Thu, 05 Oct 2017 13:45:14 + Build duration: 38 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests
D7954: Fix repaint loop in KToolBar
dfaure added a comment. Ah right, my comment was wrong, it assumed that `text` was the current text of `tb`, but it's not (necessarily). So your patch is ok, it's just that I'd rather remove all this code with my other patch instead ;) But until it's approved, let's have yours in... REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D7954 To: mardelle, #frameworks, ilic, dfaure
D6317: fix crash on Windows when deleting an instance of QtMultimediaExtractor
mgallien added a comment. The problem is that, on Windows, internal objects of QMediaPlayer need to be destroyed in the context of the thread where they have been created. I am not sure making mMetadataExtractor have mRunnerThread as its parent will help on that. I can test but have no Windows around currently to do the test. REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL https://phabricator.kde.org/D6317 To: mgallien, #frameworks, davidedmundson Cc: davidedmundson, #frameworks
D7954: Fix repaint loop in KToolBar
mardelle added a comment. So did some more tests, and the loop is caused by the tb->settext() call. The QAbstractButton setText method checks if : d->text == text But d->text contains the & accel marker and not text, so we end up comparing 'ren' with 'render' on paint, thus the loop. I will review & update my patch tomorrow REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D7954 To: mardelle, #frameworks, ilic, dfaure
KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 108 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/108/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Thu, 05 Oct 2017 12:36:05 + Build duration: 1 min 16 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.qmltests Cobertura Report Project Coverage Summary Name Cobertura Coverage Report
KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 102 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/102/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Thu, 05 Oct 2017 12:36:05 + Build duration: 51 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests
D8146: Don't try to override label heights - PlasmaComponents
nicolasfella abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D8146 To: nicolasfella, #plasma Cc: mart, davidedmundson, plasma-devel, #frameworks, #plasma, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 107 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/107/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Thu, 05 Oct 2017 11:32:37 + Build duration: 1 min 9 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.qmltests Cobertura Report Project Coverage Summary Name Cobertura Coverage Report
KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 101 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/101/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Thu, 05 Oct 2017 11:32:37 + Build duration: 43 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests
KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 100 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/100/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Thu, 05 Oct 2017 11:19:21 + Build duration: 2 min 1 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests
KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 106 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/106/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Thu, 05 Oct 2017 11:19:21 + Build duration: 1 min 47 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.qmltests Cobertura Report Project Coverage Summary Name Cobertura Coverage Report
D6831: Make use of kauth helper in methods of file ioslave
chinmoyr updated this revision to Diff 20367. chinmoyr added a comment. Added correct header Removed the `openMode` variable. `FileProtocol::tryOpen` takes care of file mode. Newline changes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6831?vs=19170=20367 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6831 AFFECTED FILES src/ioslaves/file/file.cpp src/ioslaves/file/file_unix.cpp To: chinmoyr, dfaure, #frameworks Cc: #frameworks
D6830: Make use of kauth helper in copy method of file ioslave
chinmoyr updated this revision to Diff 20366. chinmoyr added a comment. used the new header and method CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6830?vs=19167=20366 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6830 AFFECTED FILES src/ioslaves/file/file.h src/ioslaves/file/file_unix.cpp To: chinmoyr, dfaure, #frameworks Cc: elvisangelaccio, #frameworks
D6317: fix crash on Windows when deleting an instance of QtMultimediaExtractor
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Can't you just parent the extractor to the mRunnerThread? Would be all round cleaner REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL https://phabricator.kde.org/D6317 To: mgallien, #frameworks, davidedmundson Cc: davidedmundson, #frameworks
D6317: fix crash on Windows when deleting an instance of QtMultimediaExtractor
mgallien added a comment. Ping REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D6317 To: mgallien, #frameworks Cc: #frameworks
D8146: Don't try to override label heights - PlasmaComponents
mart added a comment. yes, this should stay. this was done in order to have labels automatically vertically align with other controls with just a Row (before RowLayout and Layout.alignment was a thing) as David says, will get rid of those once all is ported to new controls REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D8146 To: nicolasfella, #plasma Cc: mart, davidedmundson, plasma-devel, #frameworks, #plasma, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D8077: Fix org.kde.plasma.calendar with Qt 5.10
fvogt added a comment.
In https://phabricator.kde.org/D8077#152371, @broulik wrote:
> Despite just having built p-f from git I still get
>
> > Error loading QML file:
file:///usr/share/plasma/plasmoids/org.kde.plasma.fuzzyclock/contents/ui/main.qml:51:34:
Type PlasmaCalendar.MonthView unavailable
> >
file:///usr/lib/x86_64-linux-gnu/qt5/qml/org/kde/plasma/calendar/MonthView.qml:222:22:
DaysCalendar is not a type
>
> Do I need a newer Qt 5.10 snapshot for this?
I just checked and indeed, 930aea8b9ca59a24838cf7f279653e3b2ee40cee in
qtdeclarative ("Fix implicit loading of internal types when using explicit
imports") is also necessary.
I thought I tested it without that commit, but apparently not.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D8077
To: fvogt, #plasma, broulik
Cc: broulik, #frameworks, plasma-devel, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
