[sysadmin/ci-tooling] helpers: Don't allow the dependency diagram data generation process to run on secondary platforms either.

[Ben Cooksley]

Git commit 15c5d9a75f87ff5ac78fd8aff2824faa6fdaa349 by Ben Cooksley.
Committed on 23/01/2018 at 07:41.
Pushed by bcooksley into branch 'master'.

Don't allow the dependency diagram data generation process to run on secondary 
platforms either.
This runs into the same issue that the cmake dependency metadata extraction 
process did, which I fixed in a603dc47b518eb1f6d94379f19345748ebd7fb3a

CCMAIL: kde-frameworks-devel@kde.org

M  +6-0helpers/generate-dependency-diagram-data.py

https://commits.kde.org/sysadmin/ci-tooling/15c5d9a75f87ff5ac78fd8aff2824faa6fdaa349

diff --git a/helpers/generate-dependency-diagram-data.py 
b/helpers/generate-dependency-diagram-data.py
index be5f549..e527151 100755
--- a/helpers/generate-dependency-diagram-data.py
+++ b/helpers/generate-dependency-diagram-data.py
@@ -20,6 +20,12 @@ buildEnvironment = EnvironmentHandler.generateFor( 
installPrefix=arguments.using
 # We'll assume that the directory we're running from is where the sources are 
located
 sourcesLocation = os.getcwd()
 
+# Are we allowed to run?
+# We only gather this metadata from the principal Linux platform, which at the 
moment is SUSEQt5.7 for Frameworks and SUSEQt5.9 for everyone else
+if arguments.platform != 'SUSEQt5.7' and arguments.platform != 'SUSEQt5.9':
+   # Then there is nothing for us to do
+   sys.exit(0)
+
 # First determine where we the data will be stored, both temporarily and on 
the server
 # As the API documentation can only be generated once, and we have the 
greatest capacity available for Linux we will use Linux dependency diagrams on 
api.kde.org.
 outputDirectory = os.path.join( sourcesLocation, 'dotdata' )

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 75 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/75/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Tue, 23 Jan 2018 04:10:28 +
 Build duration:
23 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiofilewidgets-kfilecopytomenutest

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.7 - Build # 26 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.7/26/
 Project:
Frameworks baloo kf5-qt5 SUSEQt5.7
 Date of build:
Tue, 23 Jan 2018 01:08:43 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 39 test(s)

D9983: Don't stat(/etc/localtime) between read() and write() copying files

[Fabian Vogt]

fvogt resigned from this revision.
fvogt added a comment.


  This should work now - I won't give the revision a total accept though as I 
didn't test it myself.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9983

To: jtamate, #frameworks
Cc: fvogt, ngraham

D10017: Find Aspell dictionaries on Windows

[Dan Leinir Turthra Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R246:9038a8effc41: Find Aspell dictionaries on Windows 
(authored by leinir).

REPOSITORY
  R246 Sonnet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10017?vs=25749=25784

REVISION DETAIL
  https://phabricator.kde.org/D10017

AFFECTED FILES
  src/plugins/aspell/aspellclient.cpp
  src/plugins/aspell/aspelldict.cpp

To: leinir, vonreth
Cc: #frameworks

D9983: Don't stat(/etc/localtime) between read() and write() copying files

[Jaime Torres Amate]

jtamate updated this revision to Diff 25783.
jtamate added a comment.


  - Don't stat(/etc/localtime) between read() and write() copying files
  
Fix logic of cancelations

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9983?vs=25644=25783

BRANCH
  timer (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D9983

AFFECTED FILES
  src/core/slavebase.cpp

To: jtamate, #frameworks, fvogt
Cc: fvogt, ngraham

D9983: Don't stat(/etc/localtime) between read() and write() copying files

[Jaime Torres Amate]

jtamate added a comment.


  In https://phabricator.kde.org/D9983#194505, @fvogt wrote:
  
  > Just a quick idea, it might be wrong: If you use a `QTimer` instead of 
`QElapsedTimer`, you can get rid of `nextTimeoutMsecs`. This would also 
simplify the logic a bit.
  
  
  QTimer and I have a strange relationship and I try to avoid it. But feel free 
to implement it that way.

INLINE COMMENTS

> fvogt wrote in slavebase.cpp:279
> This does not matter - previously this line guaranteed that this does not 
> fire again until `nextTimeout` is set again. Now it will fire on the next 
> `dispatchLoop()` call.
> 
> You probably want to call `d->nextTimeout.invalidate()` here.

You're right. I missed that QDateTime() generates an invalid datetime.

> fvogt wrote in slavebase.cpp:1052
> You probably want to call `invalidate` here as well and then not `start()` it 
> in this case.

If you are talking only in the last case // canceled. You are right again (the 
same mistake).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9983

To: jtamate, #frameworks, fvogt
Cc: fvogt, ngraham

D9983: Don't stat(/etc/localtime) between read() and write() copying files

[Fabian Vogt]

fvogt added a comment.


  Just a quick idea, it might be wrong: If you use a `QTimer` instead of 
`QElapsedTimer`, you can get rid of `nextTimeoutMsecs`. This would also 
simplify the logic a bit.

INLINE COMMENTS

> jtamate wrote in slavebase.cpp:279
> Reading the documentation http://doc.qt.io/qt-5/qelapsedtimer.html
> I'm not able to say if start() will restart a timer or continue. My guess is 
> that it also restarts.
> And also because calling restart() on a QElapsedTimer that is invalid results 
> in undefined behavior.

This does not matter - previously this line guaranteed that this does not fire 
again until `nextTimeout` is set again. Now it will fire on the next 
`dispatchLoop()` call.

You probably want to call `d->nextTimeout.invalidate()` here.

> jtamate wrote in slavebase.cpp:1052
> | before   | now| where   
>  |
> | next = now + timeout | msecs = timeout, (re)start elapsed | 
> setTimeoutSpecialCommand |
> | if next < now then   | if has elapsed timeout  then   | dispatchLoop
>  |
> |
> 
> I think both are equivalent.

You probably want to call `invalidate` here as well and then not `start()` it 
in this case.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9983

To: jtamate, #frameworks, fvogt
Cc: fvogt, ngraham

D9983: Don't stat(/etc/localtime) between read() and write() copying files

[Jaime Torres Amate]

jtamate added inline comments.

INLINE COMMENTS

> fvogt wrote in slavebase.cpp:279
> In the old code the timeout was canceled here, but now it gets started again 
> instead.

Reading the documentation http://doc.qt.io/qt-5/qelapsedtimer.html
I'm not able to say if start() will restart a timer or continue. My guess is 
that it also restarts.
And also because calling restart() on a QElapsedTimer that is invalid results 
in undefined behavior.

> fvogt wrote in slavebase.cpp:1052
> If I understand this correctly, this will change behaviour.
> It'll call the timeout function on the next dispatchLoop call.

| before   | now| where 
   |
| next = now + timeout | msecs = timeout, (re)start elapsed | 
setTimeoutSpecialCommand |
| if next < now then   | if has elapsed timeout  then   | dispatchLoop  
   |
|

I think both are equivalent.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9983

To: jtamate, #frameworks, fvogt
Cc: fvogt, ngraham

D9983: Don't stat(/etc/localtime) between read() and write() copying files

[Fabian Vogt]

fvogt requested changes to this revision.
fvogt added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> slavebase.cpp:279
>  QByteArray data = d->timeoutData;
> -d->nextTimeout = QDateTime();
> +d->nextTimeout.start();
>  d->timeoutData = QByteArray();

In the old code the timeout was canceled here, but now it gets started again 
instead.

> slavebase.cpp:1052
>  } else {
> -d->nextTimeout = QDateTime();// Canceled
> +d->nextTimeoutMsecs = 1;  // Canceled
>  }

If I understand this correctly, this will change behaviour.
It'll call the timeout function on the next dispatchLoop call.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9983

To: jtamate, #frameworks, fvogt
Cc: fvogt, ngraham

Re: KDE and Google Summer of Code 2018

[Thomas Pfeiffer]

> On 22. Jan 2018, at 00:35, David Edmundson  wrote:
> 
> 
> 
> On Sun, Jan 21, 2018 at 7:25 PM, Albert Astals Cid  > wrote:
> El divendres, 19 de gener de 2018, a les 10:42:44 CET, Marco Martin va
> escriure:
> > On Mon, Jan 15, 2018 at 8:15 PM, Nate Graham  > > wrote:
> > > I've submitted an idea for System Settings: Improve handling for touchpads
> > > and mice with Libinput
> >
> > Speaking of systemsettings, would be a good fit porting to qml some
> > medium-to-big kcm?
> 
> What's the actual benefit of that porting?
> 
> 
> Unifying and fixing all our KCMs is the intention, there's new designs from 
> Andy.
> Use of QtQuick is a side effect, but the intended direction if we're 
> rewriting something anyway.

Let’s not forget touch-friendliness as an important benefit!

D10024: Add supportedSchemes feature

[Aleix Pol Gonzalez]

apol added a comment.


  Makes sense I guess.
  
  Sounds like it would be useful to set this through kiosk, would that work?

INLINE COMMENTS

> kdiroperator.cpp:2650
> +{
> +d->supportedSchemes = schemes;
> +rereadDir();

only if d->supportedSchemes != schemes?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10024

To: mwolff, #plasma, dfaure
Cc: apol, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D10026: Fix loading NotifyByExecute

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Frameworks, hein.
Restricted Application added a project: Frameworks.
broulik requested review of this revision.

REVISION SUMMARY
  Looks like a copy paste error
  
  CHANGELOG: The "Run Command" notification action has been fixed
  
  BUG: 389284

TEST PLAN
  Configured a notification to run a command, triggered notification, command 
ran fine

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D10026

AFFECTED FILES
  src/knotificationmanager.cpp

To: broulik, #frameworks, hein

KDE CI: Frameworks purpose kf5-qt5 WindowsMSVCQt5.9 - Build # 4 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20WindowsMSVCQt5.9/4/
 Project:
Frameworks purpose kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Mon, 22 Jan 2018 16:29:12 +
 Build duration:
6 min 37 sec and counting
   CONSOLE OUTPUT
  [...truncated 24.85 KB...] > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* > git rev-parse "origin/master^{commit}" # timeout=10Checking out Revision 370d6aef4858158d009c13f3e165ecdad723d26f (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f 370d6aef4858158d009c13f3e165ecdad723d26fCommit message: "Revert "Temporarily sever the dependency on Purpose.""[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Setup Dependencies)[Pipeline] bat[Frameworks purpose kf5-qt5 WindowsMSVCQt5.9] Running batch scriptC:\CI\workspace\Frameworks purpose kf5-qt5 WindowsMSVCQt5.9>python -u ci-tooling/helpers/prepare-dependencies.py --product Frameworks --project purpose --branchGroup kf5-qt5 --environment production --platform WindowsMSVCQt5.9 --installTo "C:\CI\workspace\Frameworks purpose kf5-qt5 WindowsMSVCQt5.9/install-prefix/" Retrieving: Frameworks-extra-cmake-modules-kf5-qt5Retrieving: Frameworks-karchive-kf5-qt5Retrieving: Frameworks-ki18n-kf5-qt5Retrieving: Frameworks-kcoreaddons-kf5-qt5Retrieving: Frameworks-kwindowsystem-kf5-qt5Retrieving: Frameworks-kconfig-kf5-qt5Retrieving: Frameworks-kcrash-kf5-qt5Retrieving: Frameworks-kdbusaddons-kf5-qt5Retrieving: Frameworks-kdoctools-kf5-qt5Retrieving: Frameworks-kservice-kf5-qt5Retrieving: Frameworks-kcodecs-kf5-qt5Retrieving: Frameworks-phonon-kf5-qt5Retrieving: Frameworks-kauth-kf5-qt5Retrieving: Frameworks-kguiaddons-kf5-qt5Retrieving: Frameworks-kwidgetsaddons-kf5-qt5Retrieving: Frameworks-kconfigwidgets-kf5-qt5Retrieving: Frameworks-kitemviews-kf5-qt5Retrieving: Frameworks-kcompletion-kf5-qt5Retrieving: Frameworks-kiconthemes-kf5-qt5Retrieving: Frameworks-sonnet-kf5-qt5Retrieving: Frameworks-attica-kf5-qt5Retrieving: Frameworks-kglobalaccel-kf5-qt5Retrieving: Frameworks-ktextwidgets-kf5-qt5Retrieving: Frameworks-breeze-icons-kf5-qt5Retrieving: Frameworks-knotifications-kf5-qt5Retrieving: Frameworks-kxmlgui-kf5-qt5Retrieving: Frameworks-solid-kf5-qt5Retrieving: Frameworks-kjobwidgets-kf5-qt5Retrieving: Frameworks-kbookmarks-kf5-qt5Retrieving: Frameworks-kwallet-kf5-qt5Retrieving: Frameworks-kio-kf5-qt5Retrieving: Frameworks-kparts-kf5-qt5Retrieving: Frameworks-kplotting-kf5-qt5Retrieving: Frameworks-kdewebkit-kf5-qt5Retrieving: Frameworks-kinit-kf5-qt5Retrieving: Frameworks-kunitconversion-kf5-qt5Retrieving: Frameworks-kded-kf5-qt5Retrieving: Frameworks-kemoticons-kf5-qt5Retrieving: Frameworks-kdesignerplugin-kf5-qt5Retrieving: Frameworks-kdewin-kf5-qt5Retrieving: Frameworks-syntax-highlighting-kf5-qt5Retrieving: Frameworks-kpackage-kf5-qt5Retrieving: Frameworks-kactivities-kf5-qt5Retrieving: Frameworks-kdnssd-kf5-qt5Retrieving: Frameworks-kdeclarative-kf5-qt5Retrieving: Frameworks-kidletime-kf5-qt5Retrieving: Frameworks-kitemmodels-kf5-qt5Retrieving: Frameworks-kjs-kf5-qt5Retrieving: Frameworks-kross-kf5-qt5Retrieving: Frameworks-threadweaver-kf5-qt5Retrieving: Frameworks-ktexteditor-kf5-qt5Retrieving: Frameworks-oxygen-icons5-kf5-qt5Retrieving: Frameworks-kirigami-kf5-qt5Retrieving: Frameworks-plasma-framework-kf5-qt5Retrieving: Frameworks-krunner-kf5-qt5Retrieving: Frameworks-kfilemetadata-kf5-qt5Retrieving: Frameworks-kdelibs4support-kf5-qt5Retrieving: Frameworks-knewstuff-kf5-qt5Retrieving: Frameworks-kcmutils-kf5-qt5Retrieving: Frameworks-khtml-kf5-qt5Retrieving: Frameworks-kjsembed-kf5-qt5Retrieving: Frameworks-knotifyconfig-kf5-qt5Retrieving: Frameworks-frameworkintegration-kf5-qt5Retrieving: Frameworks-kxmlrpcclient-kf5-qt5Retrieving: Frameworks-qqc2-desktop-style-kf5-qt5Retrieving: Frameworks-kpeople-kf5-qt5Retrieving: Frameworks-kmediaplayer-kf5-qt5Retrieving: Frameworks-kimageformats-kf5-qt5Retrieving: Frameworks-baloo-kf5-qt5Retrieving: Frameworks-kdeconnect-kde-kf5-qt5Unable to fetch: Frameworks-kdeconnect-kde-kf5-qt5[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] bat[Frameworks purpose kf5-qt5 WindowsMSVCQt5.9] Running batch scriptC:\CI\workspace\Frameworks purpose kf5-qt5 WindowsMSVCQt5.9>python -u ci-tooling/helpers/capture-workspace.py --environment production [Pipeline] emailextrecipients

KDE CI: Frameworks purpose kf5-qt5 FreeBSDQt5.9 - Build # 4 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20FreeBSDQt5.9/4/
 Project:
Frameworks purpose kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 22 Jan 2018 16:29:12 +
 Build duration:
4 min 0 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.alternativesmodeltest

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 4 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/4/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 22 Jan 2018 16:29:12 +
 Build duration:
2 min 56 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltestFailed: TestSuite.menutest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/20)0%
(0/57)0%
(0/57)0%
(0/2059)0%
(0/1224)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests0%
(0/4)0%
(0/4)0%
(0/149)0%
(0/172)src0%
(0/8)0%
(0/8)0%
(0/281)0%
(0/229)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/141)0%
(0/94)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/57)0%
(0/32)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/186)0%
(0/78)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/16)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/81)0%
(0/40)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/56)0%
(0/36)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/90)src.plugins.phabricator.quick0%
(0/6)0%
(0/6)0%
(0/86)0%
(0/59)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/4)0%
(0/4)0%
(0/243)0%
(0/84)src.plugins.reviewboard.quick0%
(0/8)0%
(0/8)0%
(0/159)0%
(0/100)src.plugins.saveas0%
(0/1)0%
(0/1)0%
(0/51)0%
(0/48)src.plugins.youtube0%
(0/5)0%
(0/5)0%
(0/121)0%
(0/44)src.quick0%
(0/2)0%
(0/2)0%
(0/5)100%
(0/0)src.widgets0%
(0/2)0%
(0/2)0%
(0/40)0%

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.7 - Build # 4 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.7/4/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 22 Jan 2018 16:29:11 +
 Build duration:
2 min 14 sec and counting
   CONSOLE OUTPUT
  [...truncated 39.88 KB...] > git rev-parse origin/master^{commit} # timeout=10Checking out Revision 3995aae594166463a446a969512be1d37ec6af18 (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f 3995aae594166463a446a969512be1d37ec6af18Commit message: "Add 'michaelh' as 'michelh' to relicensecheck.pl"[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Setup Dependencies)[Pipeline] sh[Frameworks purpose kf5-qt5 SUSEQt5.7] Running shell script+ python3 -u ci-tooling/helpers/prepare-dependencies.py --product Frameworks --project purpose --branchGroup kf5-qt5 --environment production --platform SUSEQt5.7 --installTo /home/jenkins//install-prefix/Retrieving: Frameworks-extra-cmake-modules-kf5-qt5Retrieving: Frameworks-karchive-kf5-qt5Retrieving: Frameworks-ki18n-kf5-qt5Retrieving: Frameworks-kcoreaddons-kf5-qt5Retrieving: Frameworks-kwindowsystem-kf5-qt5Retrieving: Frameworks-kconfig-kf5-qt5Retrieving: Frameworks-kcrash-kf5-qt5Retrieving: Frameworks-kdbusaddons-kf5-qt5Retrieving: Frameworks-kdoctools-kf5-qt5Retrieving: Frameworks-kservice-kf5-qt5Retrieving: Frameworks-kcodecs-kf5-qt5Retrieving: Frameworks-phonon-kf5-qt5Retrieving: Frameworks-polkit-qt-1-kf5-qt5Retrieving: Frameworks-kauth-kf5-qt5Retrieving: Frameworks-kguiaddons-kf5-qt5Retrieving: Frameworks-kwidgetsaddons-kf5-qt5Retrieving: Frameworks-kconfigwidgets-kf5-qt5Retrieving: Frameworks-kitemviews-kf5-qt5Retrieving: Frameworks-kiconthemes-kf5-qt5Retrieving: Frameworks-knotifications-kf5-qt5Retrieving: Frameworks-kcompletion-kf5-qt5Retrieving: Frameworks-sonnet-kf5-qt5Retrieving: Frameworks-attica-kf5-qt5Retrieving: Frameworks-kglobalaccel-kf5-qt5Retrieving: Frameworks-ktextwidgets-kf5-qt5Retrieving: Frameworks-breeze-icons-kf5-qt5Retrieving: Frameworks-kxmlgui-kf5-qt5Retrieving: Frameworks-solid-kf5-qt5Retrieving: Frameworks-kjobwidgets-kf5-qt5Retrieving: Frameworks-kbookmarks-kf5-qt5Retrieving: Frameworks-kwallet-kf5-qt5Retrieving: Frameworks-kplotting-kf5-qt5Retrieving: Frameworks-kio-kf5-qt5Retrieving: Frameworks-kinit-kf5-qt5Retrieving: Frameworks-kunitconversion-kf5-qt5Retrieving: Frameworks-kded-kf5-qt5Retrieving: Frameworks-kemoticons-kf5-qt5Retrieving: Frameworks-kparts-kf5-qt5Retrieving: Frameworks-kdesignerplugin-kf5-qt5Retrieving: Frameworks-syntax-highlighting-kf5-qt5Retrieving: Frameworks-kpackage-kf5-qt5Retrieving: Frameworks-kactivities-kf5-qt5Retrieving: Frameworks-kdnssd-kf5-qt5Retrieving: Frameworks-kdeclarative-kf5-qt5Retrieving: Frameworks-kidletime-kf5-qt5Retrieving: Frameworks-kitemmodels-kf5-qt5Retrieving: Frameworks-kjs-kf5-qt5Retrieving: Frameworks-kross-kf5-qt5Retrieving: Frameworks-threadweaver-kf5-qt5Retrieving: Frameworks-kwayland-kf5-qt5Retrieving: Frameworks-ktexteditor-kf5-qt5Retrieving: Frameworks-oxygen-icons5-kf5-qt5Retrieving: Frameworks-kirigami-kf5-qt5Retrieving: Frameworks-plasma-framework-kf5-qt5Retrieving: Frameworks-krunner-kf5-qt5Retrieving: Frameworks-kfilemetadata-kf5-qt5Retrieving: Frameworks-kdelibs4support-kf5-qt5Retrieving: Frameworks-kpty-kf5-qt5Retrieving: Frameworks-knewstuff-kf5-qt5Retrieving: Frameworks-kactivities-stats-kf5-qt5Retrieving: Frameworks-kcmutils-kf5-qt5Retrieving: Frameworks-khtml-kf5-qt5Retrieving: Frameworks-kjsembed-kf5-qt5Retrieving: Frameworks-knotifyconfig-kf5-qt5Retrieving: Frameworks-frameworkintegration-kf5-qt5Retrieving: Frameworks-kdesu-kf5-qt5Retrieving: Frameworks-kxmlrpcclient-kf5-qt5Retrieving: Frameworks-qqc2-desktop-style-kf5-qt5Retrieving: Frameworks-prison-kf5-qt5Retrieving: Frameworks-kpeople-kf5-qt5Retrieving: Frameworks-kmediaplayer-kf5-qt5Retrieving: Frameworks-kimageformats-kf5-qt5Retrieving: Frameworks-bluez-qt-kf5-qt5Retrieving: Frameworks-baloo-kf5-qt5Retrieving: Frameworks-modemmanager-qt-kf5-qt5Retrieving: Frameworks-networkmanager-qt-kf5-qt5Retrieving: Frameworks-kaccounts-integration-kf5-qt5Unable to fetch: Frameworks-kaccounts-integration-kf5-qt5[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] sh[Frameworks purpose kf5-qt5 SUSEQt5.7] Running shell script+ python3 -u ci-tooling/helpers/capture-workspace.py --environment production[Pipeline] emailextrecipients

D10024: Add supportedSchemes feature

[Milian Wolff]

mwolff added a dependent revision: D10025: Use KFileWidget::setSupportedSchemes 
when available.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10024

To: mwolff, #plasma, dfaure
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10024: Add supportedSchemes feature

[Milian Wolff]

mwolff created this revision.
mwolff added reviewers: Plasma, dfaure.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
mwolff requested review of this revision.

REVISION SUMMARY
  This addds a whitelist of supported URL schemes to the KFileWidget
  to be used by KDEPlatformFileDialog. The whitelist is used by the
  KFilePlacesModel and KDirOperator to filter the displayed contents.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10024

AFFECTED FILES
  autotests/kdiroperatortest.cpp
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kdiroperator.h
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h
  src/filewidgets/kfilewidget.cpp
  src/filewidgets/kfilewidget.h

To: mwolff, #plasma, dfaure
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Re: KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 2 - Still Unstable!

[Aleix Pol]

How could I reproduce this? I can only reproduce it with a system
without QT_PLUGIN_PATH
properly defined.

On Sun, Jan 21, 2018 at 8:51 PM, CI System  wrote:

> *BUILD UNSTABLE*
> Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-
> qt5%20SUSEQt5.10/2/
> Project: Frameworks purpose kf5-qt5 SUSEQt5.10
> Date of build: Sun, 21 Jan 2018 19:38:55 +
> Build duration: 12 min and counting
> * JUnit Tests *
> Name: (root) Failed: 2 test(s), Passed: 1 test(s), Skipped: 0 test(s),
> Total: 3 test(s)
> *- Failed: TestSuite.alternativesmodeltest*
> *- Failed: TestSuite.menutest*
> * Cobertura Report *
> * Project Coverage Summary *
> Name Packages Files Classes Lines Conditionals
> Cobertura Coverage Report 0% (0/20) 0% (0/57) 0% (0/57) 0% (0/2058) 0%
> (0/1224)
> Coverage Breakdown by Package
> Name Files Classes Lines Conditionals
> autotests 0% (0/4) 0% (0/4) 0% (0/148) 0% (0/172)
> src 0% (0/8) 0% (0/8) 0% (0/281) 0% (0/229)
> src.externalprocess 0% (0/2) 0% (0/2) 0% (0/141) 0% (0/94)
> src.plugins.email 0% (0/1) 0% (0/1) 0% (0/57) 0% (0/32)
> src.plugins.imgur 0% (0/2) 0% (0/2) 0% (0/186) 0% (0/78)
> src.plugins.kdeconnect 0% (0/1) 0% (0/1) 0% (0/26) 0% (0/12)
> src.plugins.ktp-sendfile 0% (0/1) 0% (0/1) 0% (0/30) 0% (0/16)
> src.plugins.nextcloud 0% (0/3) 0% (0/3) 0% (0/81) 0% (0/40)
> src.plugins.pastebin 0% (0/1) 0% (0/1) 0% (0/56) 0% (0/36)
> src.plugins.phabricator 0% (0/3) 0% (0/3) 0% (0/220) 0% (0/90)
> src.plugins.phabricator.quick 0% (0/6) 0% (0/6) 0% (0/86) 0% (0/59)
> src.plugins.phabricator.tests 0% (0/1) 0% (0/1) 0% (0/60) 0% (0/28)
> src.plugins.reviewboard 0% (0/4) 0% (0/4) 0% (0/243) 0% (0/84)
> src.plugins.reviewboard.quick 0% (0/8) 0% (0/8) 0% (0/159) 0% (0/100)
> src.plugins.saveas 0% (0/1) 0% (0/1) 0% (0/51) 0% (0/48)
> src.plugins.youtube 0% (0/5) 0% (0/5) 0% (0/121) 0% (0/44)
> src.quick 0% (0/2) 0% (0/2) 0% (0/5) 100% (0/0)
> src.widgets 0% (0/2) 0% (0/2) 0% (0/40) 0% (0/6)
> tests 0% (0/1) 0% (0/1) 0% (0/16) 0% (0/4)
> tests.tool 0% (0/1) 0% (0/1) 0% (0/51) 0% (0/52)
>

D10020: add a workaround to mark snap bundle mounts as hidden

[Harald Sitter]

sitter abandoned this revision.
sitter added a comment.


  Ah. I like his patch better. Thanks

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D10020

To: sitter, apol
Cc: bshah, broulik, #frameworks

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.7 - Build # 3 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.7/3/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 22 Jan 2018 13:48:35 +
 Build duration:
8 min 3 sec and counting
   CONSOLE OUTPUT
  [...truncated 40.55 KB...]Checking out Revision 3995aae594166463a446a969512be1d37ec6af18 (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f 3995aae594166463a446a969512be1d37ec6af18Commit message: "Add 'michaelh' as 'michelh' to relicensecheck.pl"[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Setup Dependencies)[Pipeline] sh[Frameworks purpose kf5-qt5 SUSEQt5.7] Running shell script+ python3 -u ci-tooling/helpers/prepare-dependencies.py --product Frameworks --project purpose --branchGroup kf5-qt5 --environment production --platform SUSEQt5.7 --installTo /home/jenkins//install-prefix/Retrieving: Frameworks-extra-cmake-modules-kf5-qt5Retrieving: Frameworks-karchive-kf5-qt5Retrieving: Frameworks-ki18n-kf5-qt5Retrieving: Frameworks-kcoreaddons-kf5-qt5Retrieving: Frameworks-kwindowsystem-kf5-qt5Retrieving: Frameworks-kconfig-kf5-qt5Retrieving: Frameworks-kcrash-kf5-qt5Retrieving: Frameworks-kdbusaddons-kf5-qt5Retrieving: Frameworks-kdoctools-kf5-qt5Retrieving: Frameworks-kservice-kf5-qt5Retrieving: Frameworks-kcodecs-kf5-qt5Retrieving: Frameworks-phonon-kf5-qt5Retrieving: Frameworks-polkit-qt-1-kf5-qt5Retrieving: Frameworks-kauth-kf5-qt5Retrieving: Frameworks-kguiaddons-kf5-qt5Retrieving: Frameworks-kwidgetsaddons-kf5-qt5Retrieving: Frameworks-kconfigwidgets-kf5-qt5Retrieving: Frameworks-kitemviews-kf5-qt5Retrieving: Frameworks-kiconthemes-kf5-qt5Retrieving: Frameworks-knotifications-kf5-qt5Retrieving: Frameworks-kcompletion-kf5-qt5Retrieving: Frameworks-sonnet-kf5-qt5Retrieving: Frameworks-attica-kf5-qt5Retrieving: Frameworks-kglobalaccel-kf5-qt5Retrieving: Frameworks-ktextwidgets-kf5-qt5Retrieving: Frameworks-breeze-icons-kf5-qt5Retrieving: Frameworks-kxmlgui-kf5-qt5Retrieving: Frameworks-solid-kf5-qt5Retrieving: Frameworks-kjobwidgets-kf5-qt5Retrieving: Frameworks-kbookmarks-kf5-qt5Retrieving: Frameworks-kwallet-kf5-qt5Retrieving: Frameworks-kplotting-kf5-qt5Retrieving: Frameworks-kio-kf5-qt5Retrieving: Frameworks-kinit-kf5-qt5Retrieving: Frameworks-kunitconversion-kf5-qt5Retrieving: Frameworks-kded-kf5-qt5Retrieving: Frameworks-kemoticons-kf5-qt5Retrieving: Frameworks-kparts-kf5-qt5Retrieving: Frameworks-kdesignerplugin-kf5-qt5Retrieving: Frameworks-syntax-highlighting-kf5-qt5Retrieving: Frameworks-kpackage-kf5-qt5Retrieving: Frameworks-kactivities-kf5-qt5Retrieving: Frameworks-kdnssd-kf5-qt5Retrieving: Frameworks-kdeclarative-kf5-qt5Retrieving: Frameworks-kidletime-kf5-qt5Retrieving: Frameworks-kitemmodels-kf5-qt5Retrieving: Frameworks-kjs-kf5-qt5Retrieving: Frameworks-kross-kf5-qt5Retrieving: Frameworks-threadweaver-kf5-qt5Retrieving: Frameworks-kwayland-kf5-qt5Retrieving: Frameworks-ktexteditor-kf5-qt5Retrieving: Frameworks-oxygen-icons5-kf5-qt5Retrieving: Frameworks-kirigami-kf5-qt5Retrieving: Frameworks-plasma-framework-kf5-qt5Retrieving: Frameworks-krunner-kf5-qt5Retrieving: Frameworks-kfilemetadata-kf5-qt5Retrieving: Frameworks-kdelibs4support-kf5-qt5Retrieving: Frameworks-kpty-kf5-qt5Retrieving: Frameworks-knewstuff-kf5-qt5Retrieving: Frameworks-kactivities-stats-kf5-qt5Retrieving: Frameworks-kcmutils-kf5-qt5Retrieving: Frameworks-khtml-kf5-qt5Retrieving: Frameworks-kjsembed-kf5-qt5Retrieving: Frameworks-knotifyconfig-kf5-qt5Retrieving: Frameworks-frameworkintegration-kf5-qt5Retrieving: Frameworks-kdesu-kf5-qt5Retrieving: Frameworks-kxmlrpcclient-kf5-qt5Retrieving: Frameworks-qqc2-desktop-style-kf5-qt5Retrieving: Frameworks-prison-kf5-qt5Retrieving: Frameworks-kpeople-kf5-qt5Retrieving: Frameworks-kmediaplayer-kf5-qt5Retrieving: Frameworks-kimageformats-kf5-qt5Retrieving: Frameworks-bluez-qt-kf5-qt5Retrieving: Frameworks-baloo-kf5-qt5Retrieving: Frameworks-modemmanager-qt-kf5-qt5Retrieving: Frameworks-networkmanager-qt-kf5-qt5Retrieving: Frameworks-kaccounts-integration-kf5-qt5Unable to fetch: Frameworks-kaccounts-integration-kf5-qt5[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] sh[Frameworks purpose kf5-qt5 SUSEQt5.7] Running shell script+ python3 -u ci-tooling/helpers/capture-workspace.py --environment production[Pipeline] emailextrecipients[Pipeline] emailext

KDE CI: Frameworks purpose kf5-qt5 FreeBSDQt5.9 - Build # 3 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20FreeBSDQt5.9/3/
 Project:
Frameworks purpose kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 22 Jan 2018 13:48:35 +
 Build duration:
4 min 4 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.alternativesmodeltest

KDE CI: Frameworks purpose kf5-qt5 WindowsMSVCQt5.9 - Build # 3 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20WindowsMSVCQt5.9/3/
 Project:
Frameworks purpose kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Mon, 22 Jan 2018 13:48:35 +
 Build duration:
2 min 11 sec and counting
   CONSOLE OUTPUT
  [...truncated 25.19 KB...] > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* > git rev-parse "origin/master^{commit}" # timeout=10Checking out Revision 370d6aef4858158d009c13f3e165ecdad723d26f (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f 370d6aef4858158d009c13f3e165ecdad723d26fCommit message: "Revert "Temporarily sever the dependency on Purpose.""[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Setup Dependencies)[Pipeline] bat[Frameworks purpose kf5-qt5 WindowsMSVCQt5.9] Running batch scriptC:\CI\workspace\Frameworks purpose kf5-qt5 WindowsMSVCQt5.9>python -u ci-tooling/helpers/prepare-dependencies.py --product Frameworks --project purpose --branchGroup kf5-qt5 --environment production --platform WindowsMSVCQt5.9 --installTo "C:\CI\workspace\Frameworks purpose kf5-qt5 WindowsMSVCQt5.9/install-prefix/" Retrieving: Frameworks-extra-cmake-modules-kf5-qt5Retrieving: Frameworks-karchive-kf5-qt5Retrieving: Frameworks-ki18n-kf5-qt5Retrieving: Frameworks-kcoreaddons-kf5-qt5Retrieving: Frameworks-kwindowsystem-kf5-qt5Retrieving: Frameworks-kconfig-kf5-qt5Retrieving: Frameworks-kcrash-kf5-qt5Retrieving: Frameworks-kdbusaddons-kf5-qt5Retrieving: Frameworks-kdoctools-kf5-qt5Retrieving: Frameworks-kservice-kf5-qt5Retrieving: Frameworks-kcodecs-kf5-qt5Retrieving: Frameworks-phonon-kf5-qt5Retrieving: Frameworks-kauth-kf5-qt5Retrieving: Frameworks-kguiaddons-kf5-qt5Retrieving: Frameworks-kwidgetsaddons-kf5-qt5Retrieving: Frameworks-kconfigwidgets-kf5-qt5Retrieving: Frameworks-kitemviews-kf5-qt5Retrieving: Frameworks-kcompletion-kf5-qt5Retrieving: Frameworks-kiconthemes-kf5-qt5Retrieving: Frameworks-sonnet-kf5-qt5Retrieving: Frameworks-attica-kf5-qt5Retrieving: Frameworks-kglobalaccel-kf5-qt5Retrieving: Frameworks-ktextwidgets-kf5-qt5Retrieving: Frameworks-breeze-icons-kf5-qt5Retrieving: Frameworks-knotifications-kf5-qt5Retrieving: Frameworks-kxmlgui-kf5-qt5Retrieving: Frameworks-solid-kf5-qt5Retrieving: Frameworks-kjobwidgets-kf5-qt5Retrieving: Frameworks-kbookmarks-kf5-qt5Retrieving: Frameworks-kwallet-kf5-qt5Retrieving: Frameworks-kio-kf5-qt5Retrieving: Frameworks-kparts-kf5-qt5Retrieving: Frameworks-kplotting-kf5-qt5Retrieving: Frameworks-kdewebkit-kf5-qt5Retrieving: Frameworks-kinit-kf5-qt5Retrieving: Frameworks-kunitconversion-kf5-qt5Retrieving: Frameworks-kded-kf5-qt5Retrieving: Frameworks-kemoticons-kf5-qt5Retrieving: Frameworks-kdesignerplugin-kf5-qt5Retrieving: Frameworks-kdewin-kf5-qt5Retrieving: Frameworks-syntax-highlighting-kf5-qt5Retrieving: Frameworks-kpackage-kf5-qt5Retrieving: Frameworks-kactivities-kf5-qt5Retrieving: Frameworks-kdnssd-kf5-qt5Retrieving: Frameworks-kdeclarative-kf5-qt5Retrieving: Frameworks-kidletime-kf5-qt5Retrieving: Frameworks-kitemmodels-kf5-qt5Retrieving: Frameworks-kjs-kf5-qt5Retrieving: Frameworks-kross-kf5-qt5Retrieving: Frameworks-threadweaver-kf5-qt5Retrieving: Frameworks-ktexteditor-kf5-qt5Retrieving: Frameworks-oxygen-icons5-kf5-qt5Retrieving: Frameworks-kirigami-kf5-qt5Retrieving: Frameworks-plasma-framework-kf5-qt5Retrieving: Frameworks-krunner-kf5-qt5Retrieving: Frameworks-kfilemetadata-kf5-qt5Retrieving: Frameworks-kdelibs4support-kf5-qt5Retrieving: Frameworks-knewstuff-kf5-qt5Retrieving: Frameworks-kcmutils-kf5-qt5Retrieving: Frameworks-khtml-kf5-qt5Retrieving: Frameworks-kjsembed-kf5-qt5Retrieving: Frameworks-knotifyconfig-kf5-qt5Retrieving: Frameworks-frameworkintegration-kf5-qt5Retrieving: Frameworks-kxmlrpcclient-kf5-qt5Retrieving: Frameworks-qqc2-desktop-style-kf5-qt5Retrieving: Frameworks-kpeople-kf5-qt5Retrieving: Frameworks-kmediaplayer-kf5-qt5Retrieving: Frameworks-kimageformats-kf5-qt5Retrieving: Frameworks-baloo-kf5-qt5Retrieving: Frameworks-kdeconnect-kde-kf5-qt5Unable to fetch: Frameworks-kdeconnect-kde-kf5-qt5[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] bat[Frameworks purpose kf5-qt5 WindowsMSVCQt5.9] Running batch scriptC:\CI\workspace\Frameworks purpose kf5-qt5 WindowsMSVCQt5.9>python -u ci-tooling/helpers/capture-workspace.py --environment production [Pipeline] emailextrecipients[Pipeline] emailext

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 3 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/3/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 22 Jan 2018 13:48:35 +
 Build duration:
2 min 11 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltestFailed: TestSuite.menutest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/20)0%
(0/57)0%
(0/57)0%
(0/2059)0%
(0/1224)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests0%
(0/4)0%
(0/4)0%
(0/149)0%
(0/172)src0%
(0/8)0%
(0/8)0%
(0/281)0%
(0/229)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/141)0%
(0/94)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/57)0%
(0/32)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/186)0%
(0/78)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/16)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/81)0%
(0/40)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/56)0%
(0/36)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/90)src.plugins.phabricator.quick0%
(0/6)0%
(0/6)0%
(0/86)0%
(0/59)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/4)0%
(0/4)0%
(0/243)0%
(0/84)src.plugins.reviewboard.quick0%
(0/8)0%
(0/8)0%
(0/159)0%
(0/100)src.plugins.saveas0%
(0/1)0%
(0/1)0%
(0/51)0%
(0/48)src.plugins.youtube0%
(0/5)0%
(0/5)0%
(0/121)0%
(0/44)src.quick0%
(0/2)0%
(0/2)0%
(0/5)100%
(0/0)src.widgets0%
(0/2)0%
(0/2)0%
(0/40)0%

D10020: add a workaround to mark snap bundle mounts as hidden

[Bhushan Shah]

bshah added subscribers: broulik, bshah.
bshah added a comment.


  umm, @broulik had a patch for this somewhere...
  
  https://phabricator.kde.org/D9895

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D10020

To: sitter, apol
Cc: bshah, broulik, #frameworks

D10020: add a workaround to mark snap bundle mounts as hidden

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: apol.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
sitter requested review of this revision.

REVISION SUMMARY
  snap bundles are loop mounted into the file system, the more bundles the
  user has installed more litter in device lists. to improve this situation
  a bit force /snap/ loop mounts to have HintIgnore set to true.
  
  I utterly failed to find a way to make this happen via udev or mount flags.

TEST PLAN
  no more snap mounts in dolphin nor fileopen

REPOSITORY
  R245 Solid

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10020

AFFECTED FILES
  src/solid/devices/backends/udisks2/udisksdevicebackend.cpp

To: sitter, apol
Cc: #frameworks

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 35 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/35/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 22 Jan 2018 12:41:55 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest

D10017: Find Aspell dictionaries on Windows

[Hannah von Reth]

vonreth accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D10017

To: leinir, vonreth
Cc: #frameworks

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 - Build # 30 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/30/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 22 Jan 2018 12:41:55 +
 Build duration:
6 min 33 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_qfswatch_unittest

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 19 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/19/
 Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 22 Jan 2018 12:41:55 +
 Build duration:
7 min 1 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: TestSuite.kdirwatch_inotify_unittest

KDE CI: Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.9 - Build # 49 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20WindowsMSVCQt5.9/49/
 Project:
Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Mon, 22 Jan 2018 12:41:55 +
 Build duration:
2 min 25 sec and counting
   CONSOLE OUTPUT
  [...truncated 290.67 KB...][ 79%] Building CXX object autotests/CMakeFiles/kshareddatacachetest.dir/kshareddatacachetest_autogen/mocs_compilation.cpp.objkshareddatacachetest.cppmocs_compilation.cpp[ 80%] Linking CXX executable ..\bin\kshareddatacachetest.exe[ 80%] Built target kshareddatacachetestScanning dependencies of target kshelltest[ 80%] Building CXX object autotests/CMakeFiles/kshelltest.dir/kshelltest.cpp.obj[ 81%] Building CXX object autotests/CMakeFiles/kshelltest.dir/kshelltest_autogen/mocs_compilation.cpp.objkshelltest.cppmocs_compilation.cppC:\CI\workspace\Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.9\autotests\kshelltest.cpp(73): error C2248: 'QString::QString': cannot access private member declared in class 'QString'C:\CM\msvc2017x64d\include\qt5\QtCore/qstring.h(793): note: see declaration of 'QString::QString'c:\cm\msvc2017x64d\include\qt5\qtcore\qoperatingsystemversion.h(47): note: see declaration of 'QString'C:\CI\workspace\Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.9\autotests\kshelltest.cpp(74): error C2248: 'QString::QString': cannot access private member declared in class 'QString'C:\CM\msvc2017x64d\include\qt5\QtCore/qstring.h(793): note: see declaration of 'QString::QString'c:\cm\msvc2017x64d\include\qt5\qtcore\qoperatingsystemversion.h(47): note: see declaration of 'QString'C:\CI\workspace\Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.9\autotests\kshelltest.cpp(75): error C2248: 'QString::QString': cannot access private member declared in class 'QString'C:\CM\msvc2017x64d\include\qt5\QtCore/qstring.h(793): note: see declaration of 'QString::QString'c:\cm\msvc2017x64d\include\qt5\qtcore\qoperatingsystemversion.h(47): note: see declaration of 'QString'C:\CI\workspace\Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.9\autotests\kshelltest.cpp(76): error C2248: 'QString::QString': cannot access private member declared in class 'QString'C:\CM\msvc2017x64d\include\qt5\QtCore/qstring.h(793): note: see declaration of 'QString::QString'c:\cm\msvc2017x64d\include\qt5\qtcore\qoperatingsystemversion.h(47): note: see declaration of 'QString'C:\CI\workspace\Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.9\autotests\kshelltest.cpp(77): error C2248: 'QString::QString': cannot access private member declared in class 'QString'C:\CM\msvc2017x64d\include\qt5\QtCore/qstring.h(793): note: see declaration of 'QString::QString'c:\cm\msvc2017x64d\include\qt5\qtcore\qoperatingsystemversion.h(47): note: see declaration of 'QString'C:\CI\workspace\Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.9\autotests\kshelltest.cpp(78): error C2248: 'QString::QString': cannot access private member declared in class 'QString'C:\CM\msvc2017x64d\include\qt5\QtCore/qstring.h(793): note: see declaration of 'QString::QString'c:\cm\msvc2017x64d\include\qt5\qtcore\qoperatingsystemversion.h(47): note: see declaration of 'QString'C:\CI\workspace\Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.9\autotests\kshelltest.cpp(79): error C2248: 'QString::QString': cannot access private member declared in class 'QString'C:\CM\msvc2017x64d\include\qt5\QtCore/qstring.h(793): note: see declaration of 'QString::QString'c:\cm\msvc2017x64d\include\qt5\qtcore\qoperatingsystemversion.h(47): note: see declaration of 'QString'C:\CI\workspace\Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.9\autotests\kshelltest.cpp(80): error C2248: 'QString::QString': cannot access private member declared in class 'QString'C:\CM\msvc2017x64d\include\qt5\QtCore/qstring.h(793): note: see declaration of 'QString::QString'c:\cm\msvc2017x64d\include\qt5\qtcore\qoperatingsystemversion.h(47): note: see declaration of 'QString'C:\CI\workspace\Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.9\autotests\kshelltest.cpp(81): error C2248: 'QString::QString': cannot access private member declared in class 'QString'C:\CM\msvc2017x64d\include\qt5\QtCore/qstring.h(793): note: see declaration of 'QString::QString'c:\cm\msvc2017x64d\include\qt5\qtcore\qoperatingsystemversion.h(47): note: see declaration of 'QString'C:\CI\workspace\Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.9\autotests\kshelltest.cpp(82): error C2248: 'QString::QString': cannot access private member declared in class 'QString'C:\CM\msvc2017x64d\include\qt5\QtCore/qstring.h(793): note: see declaration of 'QString::QString'c:\cm\msvc2017x64d\include\qt5\qtcore\qoperatingsystemversion.h(47): note: see declaration of 'QString'C:\CI\workspace\Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.9\autotests\kshelltest.cpp(108): error C2248: 'QString::QString': cannot access private member declared in class 'QString'C:\CM\msvc2017x64d\include\qt5\QtCore/qstring.h(793): note: see declaration of 

D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

[Veluri Mithun]

This revision was automatically updated to reflect the committed changes.
Closed by commit R244:53f3dce3f012: Compile commenting 
remove_defintion(QT_NO_CAST_FROM_ASCII ) (authored by velurimithun).

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9420?vs=25712=25751

REVISION DETAIL
  https://phabricator.kde.org/D9420

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/desktoptojsontest.cpp
  autotests/kaboutdataapplicationdatatest.cpp
  autotests/kaboutdatatest.cpp
  autotests/kautosavefiletest.cpp
  autotests/kdelibs4migrationtest.cpp
  autotests/kdirwatch_unittest.cpp
  autotests/kformattest.cpp
  autotests/kpluginfactorytest.cpp
  autotests/kpluginloadertest.cpp
  autotests/kpluginmetadatatest.cpp
  autotests/kprocesstest.cpp
  autotests/krandomtest.cpp
  autotests/kshelltest.cpp
  autotests/kstringhandlertest.cpp
  autotests/ktexttohtmltest.cpp
  autotests/kusertest.cpp
  autotests/multiplugin.cpp

To: velurimithun, mlaurent
Cc: dfaure, #frameworks

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.7 - Build # 24 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.7/24/
 Project:
Frameworks kdelibs4support kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 22 Jan 2018 12:09:05 +
 Build duration:
19 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.kmimetypetest

D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

[Laurent Montel]

mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.


  Thanks

REPOSITORY
  R244 KCoreAddons

BRANCH
  complieWithoutRemoveDef

REVISION DETAIL
  https://phabricator.kde.org/D9420

To: velurimithun, mlaurent
Cc: dfaure, #frameworks

D10017: Find Aspell dictionaries on Windows

[Dan Leinir Turthra Jensen]

leinir created this revision.
leinir added a reviewer: vonreth.
leinir added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
leinir requested review of this revision.

REVISION SUMMARY
  This feeds the sonnet aspell plugin some information to assist it in locating 
dictionaries on Windows. It adds a heuristic which follows the data location 
for applications installed using Craft on Windows.
  
  Partial reintroduction of the hack in https://phabricator.kde.org/D9421 
except this time it's relocateable

TEST PLAN
  Without patch: No squiggly red lines (Sonnet debug-warns that no dictionaries 
are found)
  With patch: Squiggly red lines (Warnings gone)

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D10017

AFFECTED FILES
  src/plugins/aspell/aspellclient.cpp
  src/plugins/aspell/aspelldict.cpp

To: leinir, vonreth
Cc: #frameworks

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.7 - Build # 23 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.7/23/
 Project:
Frameworks kdelibs4support kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 22 Jan 2018 11:40:35 +
 Build duration:
28 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.kmimetypetest
   CONSOLE OUTPUT
  [...truncated 1.96 MB...]-- Installing: /home/jenkins/workspace/Frameworks kdelibs4support kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kf5/locale/countries/ve/country.desktop-- Installing: /home/jenkins/workspace/Frameworks kdelibs4support kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kf5/locale/countries/ve/flag.png-- Installing: /home/jenkins/workspace/Frameworks kdelibs4support kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kf5/locale/countries/vg/country.desktop-- Installing: /home/jenkins/workspace/Frameworks kdelibs4support kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kf5/locale/countries/vg/flag.png-- Installing: /home/jenkins/workspace/Frameworks kdelibs4support kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kf5/locale/countries/vi/country.desktop-- Installing: /home/jenkins/workspace/Frameworks kdelibs4support kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kf5/locale/countries/vi/flag.png-- Installing: /home/jenkins/workspace/Frameworks kdelibs4support kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kf5/locale/countries/vn/country.desktop-- Installing: /home/jenkins/workspace/Frameworks kdelibs4support kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kf5/locale/countries/vn/flag.png-- Installing: /home/jenkins/workspace/Frameworks kdelibs4support kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kf5/locale/countries/vu/country.desktop-- Installing: /home/jenkins/workspace/Frameworks kdelibs4support kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kf5/locale/countries/vu/flag.png-- Installing: /home/jenkins/workspace/Frameworks kdelibs4support kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kf5/locale/countries/wf/country.desktop-- Installing: /home/jenkins/workspace/Frameworks kdelibs4support kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kf5/locale/countries/wf/flag.png-- Installing: /home/jenkins/workspace/Frameworks kdelibs4support kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kf5/locale/countries/ws/country.desktop-- Installing: /home/jenkins/workspace/Frameworks kdelibs4support kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kf5/locale/countries/ws/flag.png-- Installing: /home/jenkins/workspace/Frameworks kdelibs4support kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kf5/locale/countries/ye/country.desktop-- Installing: /home/jenkins/workspace/Frameworks kdelibs4support kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kf5/locale/countries/ye/flag.png-- Installing: /home/jenkins/workspace/Frameworks kdelibs4support kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kf5/locale/countries/yt/country.desktop-- Installing: /home/jenkins/workspace/Frameworks kdelibs4support kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kf5/locale/countries/yt/flag.png-- Installing: /home/jenkins/workspace/Frameworks kdelibs4support kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kf5/locale/countries/za/country.desktop-- Installing: /home/jenkins/workspace/Frameworks kdelibs4support kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kf5/locale/countries/za/flag.png-- Installing: /home/jenkins/workspace/Frameworks kdelibs4support kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kf5/locale/countries/zm/country.desktop-- Installing: /home/jenkins/workspace/Frameworks kdelibs4support kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kf5/locale/countries/zm/flag.png-- Installing: /home/jenkins/workspace/Frameworks kdelibs4support kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kf5/locale/countries/zw/country.desktop-- Installing: /home/jenkins/workspace/Frameworks kdelibs4support kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kf5/locale/countries/zw/flag.png-- Installing: /home/jenkins/workspace/Frameworks kdelibs4support kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/lib64/plugins/kf5/kio/metainfo.so-- Set runtime path of "/home/jenkins/workspace/Frameworks kdelibs4support kf5-qt5 SUSEQt5.7/install-divert//home/jenkins/install-prefix/lib64/plugins/kf5/kio/metainfo.so" to "/home/jenkins/install-prefix/lib64"-- Installing: /home/jenkins/workspace/Frameworks kdelibs4support kf5-qt5 

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 - Build # 23 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/23/
 Project:
Frameworks kdelibs4support kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 22 Jan 2018 11:58:23 +
 Build duration:
9 min 40 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.kmimetypetest

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 - Build # 18 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.9/18/
 Project:
Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 22 Jan 2018 11:53:20 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kstandarddirstest

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 - Build # 22 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/22/
 Project:
Frameworks kdelibs4support kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 22 Jan 2018 11:40:35 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.kmimetypetest

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 - Build # 17 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.9/17/
 Project:
Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 22 Jan 2018 11:40:35 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kstandarddirstest

D8428: Fix cross-compiling with MinGW (MXE)

[Ralf Habacker]

This revision was automatically updated to reflect the committed changes.
Closed by commit R303:f14ae9d70886: Fix cross-compiling with MinGW (MXE) 
(authored by vpinon, committed by habacker).

REPOSITORY
  R303 KInit

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8428?vs=21141=25748

REVISION DETAIL
  https://phabricator.kde.org/D8428

AFFECTED FILES
  src/kdeinit/kinit_win.cpp

To: vpinon, vonreth, habacker
Cc: #frameworks, bartoloni, benjaminnelan, afarid, fernandoteles, mardelle

D9831: Add Windows notes for network related test applications

[Ralf Habacker]

This revision was automatically updated to reflect the committed changes.
Closed by commit R239:a874b6a67643: Add Windows notes for network related test 
applications (authored by habacker).
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REPOSITORY
  R239 KDELibs4Support

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9831?vs=25661=25747

REVISION DETAIL
  https://phabricator.kde.org/D9831

AFFECTED FILES
  tests/README.md

To: habacker, dfaure, kfunk
Cc: #frameworks

D9468: Refactor Solid::NetworkingPrivate to have a shared and platform specific implementation

[Ralf Habacker]

This revision was automatically updated to reflect the committed changes.
Closed by commit R239:1d1af3e51407: Refactor Solid::NetworkingPrivate to have a 
shared and platform specific… (authored by habacker).

REPOSITORY
  R239 KDELibs4Support

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9468?vs=25088=25746

REVISION DETAIL
  https://phabricator.kde.org/D9468

AFFECTED FILES
  src/CMakeLists.txt
  src/solid/networking.cpp
  src/solid/networking_unix.cpp
  src/solid/networking_win.cpp

To: habacker, dfaure
Cc: #frameworks

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 52 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/52/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 22 Jan 2018 10:10:55 +
 Build duration:
22 min and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3557/13219)19%
(1974/10459)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(607/1138)28%
(421/1490)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)12%
(250/2152)7%
(97/1450)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1445/3488)28%
(828/2917)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(671/1612)28%
(317/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)28%
(553/1968)18%
(306/1703)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
   

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 49 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/49/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 22 Jan 2018 10:10:55 +
 Build duration:
9 min 32 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3560/13224)19%
(1976/10459)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1139)28%
(421/1490)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)12%
(251/2156)7%
(98/1454)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1445/3488)28%
(828/2913)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(671/1612)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)28%
(553/1968)18%
(306/1703)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
   

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 25 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/25/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 22 Jan 2018 10:10:55 +
 Build duration:
8 min 48 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

D9961: [Plasma Theme] Guard against invalid KPluginInfo object

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:9870027494b5: [Plasma Theme] Guard against invalid 
KPluginInfo object (authored by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9961?vs=25588=25742

REVISION DETAIL
  https://phabricator.kde.org/D9961

AFFECTED FILES
  src/plasma/private/theme_p.cpp

To: broulik, #plasma, mart
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9961: [Plasma Theme] Guard against invalid KPluginInfo object

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9961

To: broulik, #plasma, mart
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9824: Optimize inotify KDirWatch backend: map inotify wd to Entry

[Milian Wolff]

This revision was automatically updated to reflect the committed changes.
Closed by commit R244:78e9ffa1844e: Optimize inotify KDirWatch backend: map 
inotify wd to Entry (authored by mwolff).

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9824?vs=25441=25740

REVISION DETAIL
  https://phabricator.kde.org/D9824

AFFECTED FILES
  src/lib/io/kdirwatch.cpp
  src/lib/io/kdirwatch_p.h

To: mwolff, dfaure, #kdevelop, markg, aaronpuchert
Cc: aaronpuchert, bcooksley, zimmerman, markg, #frameworks

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 - Build # 29 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/29/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 22 Jan 2018 08:55:34 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 34 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/34/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 22 Jan 2018 08:55:34 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kdirwatch_stat_unittest

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 18 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/18/
 Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 22 Jan 2018 08:55:34 +
 Build duration:
4 min 37 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 21 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_stat_unittest

D9824: Optimize inotify KDirWatch backend: map inotify wd to Entry

[Milian Wolff]

mwolff added a comment.


  In https://phabricator.kde.org/D9824#193095, @dfaure wrote:
  
  > This patch fixes a O(n) performance issue in the inotify backend using a 
cache, which makes KDirWatch *better* suited for applications that use 
KDirWatch heavily. Clearly a step in the right direction. Yes a cache needs 
memory, like all caches, how else is one going to optimize linear searches [in 
unsorted data]...
  >
  > I looked at whether other backends have a similar linear search, and only 
KDirWatchPrivate::checkFAMEvent has something similar, so FAM could use a cache 
where the key would be the "request number" as obtained with 
FAMREQUEST_GETREQNUM. That's a different patch though. The other backends don't 
have such a linear search, why are we even talking of "doing the same for the 
QSFW backend"? That's not applicable. How about taking a look at the code 
before requesting to optimize linear searches that don't exist?
  
  
  Note that many other functions iterate over all entries in `m_mapEntries`:
  
void KDirWatchPrivate::removeEntries(KDirWatch *instance)
void KDirWatchPrivate::stopScan(KDirWatch *instance)
void KDirWatchPrivate::startScan(KDirWatch *instance, bool notify, bool 
skippedToo)
void KDirWatchPrivate::resetList(KDirWatch *instance, bool skippedToo)
void KDirWatchPrivate::slotRescan() // twice even!
void KDirWatchPrivate::famEventReceived()
void KDirWatchPrivate::checkFAMEvent(FAMEvent *fe)
void KDirWatchPrivate::statistics()
  
  This is why I claim that more situations can trigger high CPU load when the 
list is large.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D9824

To: mwolff, dfaure, #kdevelop, markg, aaronpuchert
Cc: aaronpuchert, bcooksley, zimmerman, markg, #frameworks

Re: kdesu - console output and password keeping

[Milian Wolff]

On Sunday, January 21, 2018 10:07:20 PM CET Albert Astals Cid wrote:
> El dijous, 18 de gener de 2018, a les 10:44:04 CET, Milian Wolff va 
escriure:
> > Hey all,
> > 
> > We've recently integrated kdesu into hotspot [1] to be able to record
> > profile data as root. This is required to get access to some "advanced"
> > performance counters and trace points, most notably the sched:sched_switch
> > tracepoint required for off-CPU profiling.
> > 
> > Now, my colleague originally used kdesudo which doesn't seem to be alive
> > (?) upstream. I've seen there's some bzr repo that the kubuntu people
> > seem to use. But in KDE proper, only kdesu is available. So I used that
> > instead but it has a severe limitation: I cannot show the command output
> > _and_ enable password keeping:
> > 
> > $ man kdesu
> > .
> > 
> >-t
> >
> >Enable terminal output. This disables password keeping. This is
> > 
> > largely for debugging purposes; if you want to run a console mode app, use
> > the standard su instead.
> > .
> > 
> > I don't quite get why one would want to use standard su - we want to show
> > a
> > graphical dialog to the user and enable password keeping. Can someone
> > explain this limitation? Is there some other alternative we could use?
> 
> I guess the suggestion would be to use the polkit stuff?

Hm then I'll have to take another look at KAuth/polkit. Nate did that already 
but gave up after quite some time - it was too complicated for him to get 
done. 

But my question to kdesu remains, I wonder why -t disables password keeping...
-- 
Milian Wolff
m...@milianw.de
http://milianw.de