D16694: Improve visibility for Konsole icon when using Breeze Dark

[Anish Giri]

anishgiri updated this revision to Diff 47242.
anishgiri added a comment.


  Fixed some lines around the corner

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16694?vs=47239=47242

BRANCH
  utilities-terminal (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16694

AFFECTED FILES
  icons-dark/apps/48/utilities-terminal.svg
  icons-dark/apps/64/utilities-terminal.svg

To: anishgiri, ngraham, #vdg
Cc: emateli, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17425: dcb settings

[Jan Grulich]

jgrulich added inline comments.

INLINE COMMENTS

> dcbsetting.cpp:31
> +, appFipPriority(-1)
> +, appIscsiPriority(-1)
> +{ }

You can initialize also all the lists here, because they have default values as 
well.

> dcbsetting.cpp:197
> +if (userPriority < 8) {
> +if (userPriority < d->priorityFlowControl.size()) {
> +d->priorityFlowControl.replace(userPriority, enabled);

If you initialize the list at the beginning, you will not need to have this 
check and also do this weird thing below. Simply have the first check and 
otherwise you can do just d->priorityFlowControl[userPriority] = enabled.

> dcbsetting.cpp:212
> +
> +if (userPriority < d->priorityFlowControl.size() && userPriority < 8) {
> +return d->priorityFlowControl.value(userPriority);

Check just if userPriority is < 8.

> dcbsetting.cpp:224
> +if (userPriority < 8) {
> +if (userPriority < d->priorityBandwidth.size()) {
> +d->priorityBandwidth.replace(userPriority, bandwidthPercent);

Same as for setPriorityFlowControl()

> dcbsetting.cpp:239
> +
> +if (userPriority < d->priorityBandwidth.size() && userPriority < 8) {
> +return d->priorityBandwidth.value(userPriority);

Same as for priorityFlowControl()

> dcbsetting.cpp:251
> +if (groupId < 8) {
> +if (groupId < d->priorityGroupBandwidth.size()) {
> +d->priorityGroupBandwidth.replace(groupId, bandwidthPercent);

Same here.

> dcbsetting.cpp:266
> +
> +if (groupId < d->priorityGroupBandwidth.size() && groupId < 8) {
> +return d->priorityGroupBandwidth.value(groupId);

Same here.

> dcbsetting.cpp:277
> +
> +if (userPriority < 8) {
> +if (userPriority < d->priorityGroupId.size()) {

Here.

> dcbsetting.cpp:294
> +if (userPriority < d->priorityGroupId.size() && userPriority < 8) {
> +return d->priorityGroupId.value(userPriority);
> +} else {

Here.

> dcbsetting.cpp:304
> +
> +if (userPriority < 8) {
> +if (userPriority < d->priorityStrictBandwidth.size()) {

Also here.

> dcbsetting.cpp:320
> +
> +if (userPriority < d->priorityStrictBandwidth.size() && userPriority < 
> 8) {
> +return d->priorityStrictBandwidth.value(userPriority);

Also here.

> dcbsetting.cpp:330
> +Q_D(DcbSetting);
> +
> +if (userPriority < 8) {

Also here.

> dcbsetting.cpp:347
> +
> +if (userPriority < d->priorityTrafficClass.size() && userPriority < 8) {
> +return d->priorityTrafficClass.value(userPriority);

And last one.

> dcbsetting.cpp:356
> +{
> +// if (setting.contains(QLatin1String(NM_SETTING_DCB_APP_FCOE_MODE))) {
> +
> setAppFcoeMode(setting.value(QLatin1String(NM_SETTING_DCB_APP_FCOE_MODE)).toString());

Remove comments.

> dcbsetting.cpp:393
> +if 
> (setting.contains(QLatin1String(NM_SETTING_DCB_PRIORITY_FLOW_CONTROL))) {
> +QList list = 
> qdbus_cast>(setting.value(QLatin1String(NM_SETTING_DCB_PRIORITY_FLOW_CONTROL)));
> +for (int i = 0; i < list.size(); ++i) setPriorityFlowControl(i, 
> list.at(i));

You can directly assign whole UintList. Same for the rest of options below.

> dcbsetting.cpp:427
> +
> +// if (!appFcoeMode().isEmpty()) {
> +setting.insert(QLatin1String(NM_SETTING_DCB_APP_FCOE_MODE), "vn2vn");

Remove comments.

> dcbsetting.cpp:428
> +// if (!appFcoeMode().isEmpty()) {
> +setting.insert(QLatin1String(NM_SETTING_DCB_APP_FCOE_MODE), "vn2vn");
> +// }

Shouldn't it save appFcoeMode() instead?

> dcbsetting.cpp:447
> +
> +if ((int)appFipFlags() >= 0) {
> +setting.insert(QLatin1String(NM_SETTING_DCB_APP_FIP_FLAGS), 
> (int)appFipFlags());

You can probably insert flags all the time.

> dcbsetting.cpp:464
> +if (priorityFlowControl(7) > 0) {
> +QList list;
> +for (int i = 0; i < 8; ++i) list.append(priorityFlowControl(i));

You can directly push the list there. Same for the lists below.

> dcbsetting.h:49
> +};
> +
> +DcbSetting();

You are missing Q_DECLARE_FLAGS()

> dcbsetting.h:83
> +
> +void setPriorityFlowControl(quint32 userPriority, quint32 enabled);
> +quint32 priorityFlowControl(quint32 userPriority) const;

Here it would probably make more sense to accept second parameter as bool.

> dcbsetting.h:95
> +
> +void setPriorityStrictBandwidth(quint32 userPriority, quint32 strict);
> +quint32 priorityStrictBandwidth(quint32 userPriority) const;

Make second parameter as bool.

> dcbsetting_p.h:46
> +NetworkManager::DcbSetting::DcbFlags priorityFlowControlFlags;
> +QList priorityFlowControl;
> +QList priorityBandwidth;

You can use our "UintList" defined data type for these.

REVISION DETAIL
  https://phabricator.kde.org/D17425

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.11 - Build # 9 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.11/9/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Mon, 10 Dec 2018 07:08:43 +
 Build duration:
19 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiogui_favicontestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(262/398)66%
(262/398)53%
(32080/60116)38%
(16571/44086)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9091/9538)48%
(4276/8965)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8344/14338)50%
(4673/9259)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3908/7970)34%
(1604/4743)src.gui100%
(2/2)100%
(2/2)88%
(95/108)68%
(45/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(531/1036)37%
(318/868)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1765/4288)35%
(1306/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
   

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 370 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/370/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 10 Dec 2018 07:08:43 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiogui_favicontestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(262/398)66%
(262/398)53%
(32049/60115)38%
(16560/44086)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9091/9538)48%
(4280/8965)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8329/14337)50%
(4674/9263)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3908/7970)34%
(1604/4743)src.gui100%
(2/2)100%
(2/2)88%
(95/108)68%
(45/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(531/1036)37%
(318/868)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4288)35%
(1304/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
   

D16694: Improve visibility for Konsole icon when using Breeze Dark

[Anish Giri]

anishgiri updated this revision to Diff 47239.
anishgiri added a comment.


  Changed the border color to #eff0f1 and 50% opacity

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16694?vs=46959=47239

BRANCH
  utilities-terminal (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16694

AFFECTED FILES
  icons-dark/apps/48/utilities-terminal.svg
  icons-dark/apps/64/utilities-terminal.svg

To: anishgiri, ngraham, #vdg
Cc: emateli, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17459: SearchBar: Add Cancel button to stop long running tasks

[Christoph Cullmann]

cullmann added a comment.


  A good explanation for the timer stuff can be found here:
  
  "Solving a Problem Step by Step" on 
https://doc.qt.io/archives/qq/qq27-responsive-guis.html
  
  That avoids the pitfalls of process events (that is mentioned above in the 
article, too).

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17459

To: loh.tar, #ktexteditor, #vdg, cullmann
Cc: cullmann, abetts, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D17421: Add drive-* icons for YaST Partitioner

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:eb16fb872125: Add drive-* icons for YaST Partitioner 
(authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17421?vs=47237=47238

REVISION DETAIL
  https://phabricator.kde.org/D17421

AFFECTED FILES
  icons-dark/devices/16/drive-harddisk-encrypted.svg
  icons-dark/devices/16/drive-multidisk.svg
  icons-dark/devices/16/drive-multipartition.svg
  icons-dark/devices/16/drive-partition.svg
  icons-dark/devices/22/drive-harddisk-encrypted.svg
  icons-dark/devices/22/drive-multidisk.svg
  icons-dark/devices/22/drive-multipartition.svg
  icons-dark/devices/22/drive-partition.svg
  icons-dark/devices/64/drive-harddisk-encrypted.svg
  icons-dark/devices/64/drive-multidisk.svg
  icons-dark/devices/64/drive-multipartition.svg
  icons-dark/devices/64/drive-partition.svg
  icons-dark/devices/symbolic/drive-harddisk-encrypted-symbolic.svg
  icons-dark/devices/symbolic/drive-multidisk-symbolic.svg
  icons-dark/devices/symbolic/drive-multipartition-symbolic.svg
  icons-dark/devices/symbolic/drive-partition-symbolic.svg
  icons/devices/16/drive-harddisk-encrypted.svg
  icons/devices/16/drive-multidisk.svg
  icons/devices/16/drive-multipartition.svg
  icons/devices/16/drive-partition.svg
  icons/devices/22/drive-harddisk-encrypted.svg
  icons/devices/22/drive-multidisk.svg
  icons/devices/22/drive-multipartition.svg
  icons/devices/22/drive-partition.svg
  icons/devices/64/drive-harddisk-encrypted.svg
  icons/devices/64/drive-multidisk.svg
  icons/devices/64/drive-multipartition.svg
  icons/devices/64/drive-partition.svg
  icons/devices/symbolic/drive-harddisk-encrypted-symbolic.svg
  icons/devices/symbolic/drive-multidisk-symbolic.svg
  icons/devices/symbolic/drive-multipartition-symbolic.svg
  icons/devices/symbolic/drive-partition-symbolic.svg

To: ndavis, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, #vdg, michaelh, bruns

D17421: Add drive-* icons for YaST Partitioner

[Noah Davis]

ndavis updated this revision to Diff 47237.
ndavis added a comment.


  Add `drive-multidisk-symbolic` and `drive-multipartition-symbolic`

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17421?vs=47234=47237

BRANCH
  more-harddisk-types (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17421

AFFECTED FILES
  icons-dark/devices/16/drive-harddisk-encrypted.svg
  icons-dark/devices/16/drive-multidisk.svg
  icons-dark/devices/16/drive-multipartition.svg
  icons-dark/devices/16/drive-partition.svg
  icons-dark/devices/22/drive-harddisk-encrypted.svg
  icons-dark/devices/22/drive-multidisk.svg
  icons-dark/devices/22/drive-multipartition.svg
  icons-dark/devices/22/drive-partition.svg
  icons-dark/devices/64/drive-harddisk-encrypted.svg
  icons-dark/devices/64/drive-multidisk.svg
  icons-dark/devices/64/drive-multipartition.svg
  icons-dark/devices/64/drive-partition.svg
  icons-dark/devices/symbolic/drive-harddisk-encrypted-symbolic.svg
  icons-dark/devices/symbolic/drive-multidisk-symbolic.svg
  icons-dark/devices/symbolic/drive-multipartition-symbolic.svg
  icons-dark/devices/symbolic/drive-partition-symbolic.svg
  icons/devices/16/drive-harddisk-encrypted.svg
  icons/devices/16/drive-multidisk.svg
  icons/devices/16/drive-multipartition.svg
  icons/devices/16/drive-partition.svg
  icons/devices/22/drive-harddisk-encrypted.svg
  icons/devices/22/drive-multidisk.svg
  icons/devices/22/drive-multipartition.svg
  icons/devices/22/drive-partition.svg
  icons/devices/64/drive-harddisk-encrypted.svg
  icons/devices/64/drive-multidisk.svg
  icons/devices/64/drive-multipartition.svg
  icons/devices/64/drive-partition.svg
  icons/devices/symbolic/drive-harddisk-encrypted-symbolic.svg
  icons/devices/symbolic/drive-multidisk-symbolic.svg
  icons/devices/symbolic/drive-multipartition-symbolic.svg
  icons/devices/symbolic/drive-partition-symbolic.svg

To: ndavis, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, #vdg, michaelh, bruns

D17421: Add drive-* icons for YaST Partitioner

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Looks great now!

REPOSITORY
  R266 Breeze Icons

BRANCH
  more-harddisk-types (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17421

To: ndavis, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, #vdg, michaelh, bruns

D17421: Add drive-* icons for YaST Partitioner

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17421

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, #vdg, michaelh, bruns

D17421: Add drive-* icons for YaST Partitioner

[Noah Davis]

ndavis updated this revision to Diff 47232.
ndavis added a comment.


  Change monochrome `drive-multipartition` style and add color version

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17421?vs=47085=47232

BRANCH
  more-harddisk-types (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17421

AFFECTED FILES
  icons-dark/devices/16/drive-harddisk-encrypted.svg
  icons-dark/devices/16/drive-multidisk.svg
  icons-dark/devices/16/drive-multipartition.svg
  icons-dark/devices/16/drive-partition.svg
  icons-dark/devices/22/drive-harddisk-encrypted.svg
  icons-dark/devices/22/drive-multidisk.svg
  icons-dark/devices/22/drive-multipartition.svg
  icons-dark/devices/22/drive-partition.svg
  icons-dark/devices/64/drive-harddisk-encrypted.svg
  icons-dark/devices/64/drive-multidisk.svg
  icons-dark/devices/64/drive-partition.svg
  icons-dark/devices/symbolic/drive-harddisk-encrypted-symbolic.svg
  icons-dark/devices/symbolic/drive-partition-symbolic.svg
  icons/devices/16/drive-harddisk-encrypted.svg
  icons/devices/16/drive-multidisk.svg
  icons/devices/16/drive-multipartition.svg
  icons/devices/16/drive-partition.svg
  icons/devices/22/drive-harddisk-encrypted.svg
  icons/devices/22/drive-multidisk.svg
  icons/devices/22/drive-multipartition.svg
  icons/devices/22/drive-partition.svg
  icons/devices/64/drive-harddisk-encrypted.svg
  icons/devices/64/drive-multidisk.svg
  icons/devices/64/drive-multipartition.svg
  icons/devices/64/drive-partition.svg
  icons/devices/symbolic/drive-harddisk-encrypted-symbolic.svg
  icons/devices/symbolic/drive-partition-symbolic.svg

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, #vdg, michaelh, bruns

D17421: Add drive-* icons for YaST Partitioner

[Nathaniel Graham]

ngraham added a comment.


  In D17421#374272 , @ndavis wrote:
  
  > How is this? Monochrome icons typically don't use multiple shades of gray 
or transparency, but some do. Going clockwise, 100%, 67%, 33% and 0% opacity.
  >  F6467523: Screenshot_20181209_235842.png 

  
  
  Bingo, you've got it! I think that's much better.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17421

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, #vdg, michaelh, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.11 - Build # 8 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.11/8/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Mon, 10 Dec 2018 04:48:21 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiogui_favicontestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(262/398)66%
(262/398)53%
(32090/60116)38%
(16582/44086)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9091/9538)48%
(4278/8965)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8344/14337)50%
(4672/9259)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3908/7970)34%
(1604/4743)src.gui100%
(2/2)100%
(2/2)88%
(95/108)68%
(45/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(531/1036)37%
(318/868)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1765/4288)35%
(1306/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
   

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 369 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/369/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 10 Dec 2018 04:48:21 +
 Build duration:
7 min 12 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiogui_favicontestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(262/398)66%
(262/398)53%
(32048/60116)38%
(16552/44086)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9091/9538)48%
(4278/8965)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8328/14337)50%
(4665/9263)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3908/7970)34%
(1604/4743)src.gui100%
(2/2)100%
(2/2)88%
(95/108)68%
(45/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(531/1036)37%
(318/868)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4288)35%
(1304/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
 

D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:f28e34306378: [KDirOperator] Dont squeeze Name 
column when there isnt enough horizontal… (authored by ngraham).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17461?vs=47216=47231

REVISION DETAIL
  https://phabricator.kde.org/D17461

AFFECTED FILES
  src/filewidgets/kdiroperatordetailview.cpp

To: ngraham, #vdg, #frameworks, cullmann, cfeck
Cc: cfeck, cullmann, kde-frameworks-devel, michaelh, ngraham, bruns

D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space

[Nathaniel Graham]

ngraham added a comment.


  Cool, landing now. If I can get some assistance, I might try my hand at 
submitting a Qt patch to add the requested resize mode.

REPOSITORY
  R241 KIO

BRANCH
  kdiroperator-detail-view-name-column (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17461

To: ngraham, #vdg, #frameworks, cullmann, cfeck
Cc: cfeck, cullmann, kde-frameworks-devel, michaelh, ngraham, bruns

D17466: Fix doxygen markdown rendering

[Eli MacKenzie]

argonel created this revision.
Herald added projects: Frameworks, Documentation.
Herald added subscribers: kde-doc-english, kde-frameworks-devel.
argonel requested review of this revision.

REVISION SUMMARY
  Doxygen's parser appears to have trouble with code blocks delimited by
  backticks and lines within the code blocks that end with backticks.
  
  This also fixes an issue where a heading isn't rendered correctly
  unless it has a blank line after it.

TEST PLAN
  built docs locally

REPOSITORY
  R264 KApiDox

BRANCH
  fix_yaml_rendering

REVISION DETAIL
  https://phabricator.kde.org/D17466

AFFECTED FILES
  docs/metainfo_syntax.md

To: argonel
Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna

D17459: SearchBar: Add Cancel button to stop long running tasks

[loh tar]

loh.tar added a comment.


  
  
  > I would probably not make the button that big
  
  There are two reasons why it is so big:
  
  1. It's handy. You do not have to move the mouse, no matter which button was 
clicked
  2. It "covers" both buttons to avoid a re-start of any such action without 
the need to disable them
  
  The first is of course the main reason.
  
  > That always leads to evil things, like e.g. what happens if you press the X 
button of the view/window during that.
  
  Assumed the changes you want are done, I have problems to understand in which 
way this will avoid that the Close-Window button can be clicked. For a working 
Cancel button you have to call in some way the event loop, even direct as 
currently, or indirect due to some suspend from the current work.
  
  > It would be better to refactor the replaceAll method in a way that it does
  > 
  > 1. setup
  > 2. trigger the search part wise via e.g. single shot timer
  > 3. some finalize phase at the end
  
  As you know, I'm a bit "slow" at times, Your instructions are not sufficient 
for me how to do that.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17459

To: loh.tar, #ktexteditor, #vdg, cullmann
Cc: cullmann, abetts, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space

[Christoph Feck]

cfeck accepted this revision.
cfeck added a comment.


  See also bug 394115 (and I blamed Qt ...)

REPOSITORY
  R241 KIO

BRANCH
  kdiroperator-detail-view-name-column (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17461

To: ngraham, #vdg, #frameworks, cullmann, cfeck
Cc: cfeck, cullmann, kde-frameworks-devel, michaelh, ngraham, bruns

D17287: Enable sharing URLs via email

[Nicolas Fella]

nicolasfella added a comment.


  In D17287#370993 , @apol wrote:
  
  > I'm not sure it makes a lot of sense to have the application include the 
title, isn't it better that the user writes it down on a config page or just 
the e-mail client?
  
  
  The user still can change/remove it in the email client

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D17287

To: nicolasfella, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17305: Add KDE Connect SMS plugin

[Nicolas Fella]

nicolasfella updated this revision to Diff 47226.
nicolasfella added a comment.


  - i18n

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17305?vs=46697=47226

BRANCH
  kdeconnectsms

REVISION DETAIL
  https://phabricator.kde.org/D17305

AFFECTED FILES
  src/plugins/CMakeLists.txt
  src/plugins/kdeconnect_sms/CMakeLists.txt
  src/plugins/kdeconnect_sms/Messages.sh
  src/plugins/kdeconnect_sms/kdeconnectsmsplugin.cpp
  src/plugins/kdeconnect_sms/kdeconnectsmsplugin.json

To: nicolasfella, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

Re: Building KDE (phonon-vlc) fails

[Michael Pyne]

On Sun, Dec 09, 2018 at 10:18:42AM +0100, Frederik Schwarzer wrote:
> Hi,
> 
> please forgive my ignorance. It has been ages since I last built KDE from 
> sources.
> 
> Using kdesrc-build, the phonon-vlc package fails on cmake with the following 
> error:
> -- Checking for module 'libvlc'
> --   Found libvlc, version 3.0.4
> CMake Error at cmake/FindLIBVLC.cmake:106 (message):
>   Could not find LibVLC
> 
> Found, but not found? Maybe it is looking for a different version?
> 
> libvlc-dev is installed on Kubuntu 18.04.
> 
> Any idea on what I am missing here?

Perhaps you need a package libvlccore-dev or similar? The FindLIBVLC in
phonon-vlc checks for both libvlc and for libvlccore but only gives the
one error message if either one is missing.

Regards,
 - Michael Pyne

D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space

[Nathaniel Graham]

ngraham added a comment.


  Yeah, I do too. It's certainly more functional. Do you think I should just 
commit this now?

REPOSITORY
  R241 KIO

BRANCH
  kdiroperator-detail-view-name-column (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17461

To: ngraham, #vdg, #frameworks, cullmann
Cc: cullmann, kde-frameworks-devel, michaelh, ngraham, bruns

D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  I think the proposed change is already an improvement.

REPOSITORY
  R241 KIO

BRANCH
  kdiroperator-detail-view-name-column (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17461

To: ngraham, #vdg, #frameworks, cullmann
Cc: cullmann, kde-frameworks-devel, michaelh, ngraham, bruns

D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space

[Nathaniel Graham]

ngraham added a comment.


  A slightly nicer solution would appear to be to keep column 0 using 
`QHeaderView::Stretch` like it already is, but give only that column a minimum 
size equal to the longest item. That way the name column would dynamically 
expand as the view was enlarged which keeps the other columns aligned to the 
right side, but would not compress as the view shrinks. Unfortunately this 
doesn't appear to be easily possible: https://bugreports.qt.io/browse/QTBUG-1248

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17461

To: ngraham, #vdg, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17461

To: ngraham, #vdg, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  When a `KDirOperator` view is used in Detailed or Detailed Tree view, when 
there isn't enough horizontal space the Name column currently gets squeezed and 
become illegible.
  
  This patch fixes that by making the name column fixed-width so it never gets 
too small to read the contents; instead the view gets a horizontal scrollbar, 
which is preferable.
  
  BUG: 401506
  FIXED-IN: 5.54

TEST PLAN
  In Kate's Filesystem Browser plugin sidebar view:
  
  In the open/save dialog when there's not enough horizontal space:
  
  In the open/save dialog when there //is// enough horizontal space:
  
  In this case, the other columns no longer stick to the right size of the view 
when the window is resized, which maybe isn't as nice as current behavior. Open 
to suggestions.

REPOSITORY
  R241 KIO

BRANCH
  kdiroperator-detail-view-name-column (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17461

AFFECTED FILES
  src/filewidgets/kdiroperatordetailview.cpp

To: ngraham, #vdg, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17460: fixups for `extern` and `pragma`

[aG0aep6G aG0aep6G]

aG0aep6G created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
aG0aep6G requested review of this revision.

REVISION SUMMARY
  add "Objective-C" linkage type
  
  fix `extern(C++)` and add support for `extern(C++, ...)`
  
  fix `pragma(foo, ...)`
  
  add more well-known pragma types

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  extern-and-pragma

REVISION DETAIL
  https://phabricator.kde.org/D17460

AFFECTED FILES
  data/syntax/d.xml

To: aG0aep6G
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17459: SearchBar: Add Cancel button to stop long running tasks

[Christoph Cullmann]

cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  The idea is good, I only am not sure that we want it with process events.
  That always leads to evil things, like e.g. what happens if you press the X 
button of the view/window during that.
  It would be better to refactor the replaceAll method in a way that it does
  
  1. setup
  2. trigger the search part wise via e.g. single shot timer
  3. some finalize phase at the end

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17459

To: loh.tar, #ktexteditor, #vdg, cullmann
Cc: cullmann, abetts, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D17459: SearchBar: Add Cancel button to stop long running tasks

[Andres Betts]

abetts added a comment.


  I would probably not make the button that big, but I think it is useful

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17459

To: loh.tar, #ktexteditor, #vdg
Cc: abetts, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D17459: SearchBar: Add Cancel button to stop long running tasks

[loh tar]

loh.tar added a comment.


  Not well tested but looks so far pretty promising.
  
  The only thing what I not really like is these modulo check when to ask for 
user input. How about a QTimer with 200/300ms?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17459

To: loh.tar, #ktexteditor, #vdg
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D17459: SearchBar: Add Cancel button to stop long running tasks

[loh tar]

loh.tar created this revision.
loh.tar added reviewers: KTextEditor, VDG.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  Without this patch could it happens that Kate run an almost endless S
  job which could lead up to an unusable system due to a run out of memory
  with no possibility to cancel the job other than kill Kate, See...
  

  
  CCBUG: 333517

TEST PLAN
  Before
  F6466371: 154434.png 
  
  New waiting for action
  F6466378: 1544380395.png 
  
  New while running job
  F6466380: 1544381064.png 

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17459

AFFECTED FILES
  src/search/katesearchbar.cpp
  src/search/katesearchbar.h
  src/search/searchbarpower.ui

To: loh.tar, #ktexteditor, #vdg
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D17419: Add view-private icon

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:b849a63cefb3: Add view-private icon (authored by GB_2, 
committed by ngraham).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17419?vs=47147=47205

REVISION DETAIL
  https://phabricator.kde.org/D17419

AFFECTED FILES
  icons-dark/actions/16/view-private.svg
  icons-dark/actions/symbolic/view-private-symbolic.svg
  icons/actions/16/view-private.svg
  icons/actions/symbolic/view-private-symbolic.svg

To: GB_2, #breeze, #vdg, #falkon, ngraham, ndavis
Cc: drosca, ndavis, filipf, ngraham, #vdg, kde-frameworks-devel, #breeze, 
alexde, IohannesPetros, trickyricky26, michaelh, crozbo, firef, bruns, 
skadinna, aaronhoneycutt, mbohlender

D17442: KTextEditor: Tweak keyboard shortcuts to prepare for F6/Shift+F6 in Kate

[Nathaniel Graham]

ngraham added a comment.


  Oh!
  
  Sorry, please ignore me...

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17442

To: gregormi, #kate
Cc: ngraham, kwrite-devel, kde-frameworks-devel, hase, michaelh, bruns, 
demsking, cullmann, sars, dhaumann

D17419: Add view-private icon

[David Rosca]

drosca added a comment.


  In D17419#374064 , @ngraham wrote:
  
  > Ah yeah, I guess that makes sense.
  >
  > #falkon  folks, is this acceptable?
  
  
  Yes, looks great!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17419

To: GB_2, #breeze, #vdg, #falkon, ngraham, ndavis
Cc: drosca, ndavis, filipf, ngraham, #vdg, kde-frameworks-devel, #breeze, 
alexde, IohannesPetros, trickyricky26, michaelh, crozbo, firef, bruns, 
skadinna, aaronhoneycutt, mbohlender

D17419: Add view-private icon

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Ah yeah, I guess that makes sense.
  
  #falkon  folks, is this acceptable?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17419

To: GB_2, #breeze, #vdg, #falkon, ngraham, ndavis
Cc: ndavis, filipf, ngraham, #vdg, kde-frameworks-devel, #breeze, alexde, 
IohannesPetros, trickyricky26, michaelh, crozbo, firef, bruns, skadinna, 
aaronhoneycutt, mbohlender

D17442: KTextEditor: Tweak keyboard shortcuts to prepare for F6/Shift+F6 in Kate

[gregormi]

gregormi added a comment.


  In D17442#374054 , @ngraham wrote:
  
  > In D17442#373755 , @gregormi 
wrote:
  >
  > > In D17442#373708 , @ngraham 
wrote:
  > >
  > > > I always re-bind Find Next and and Find Previous to use [Ctrl] + [G] 
and [Ctrl] + [⇧] + [G]. These are the shortcuts that are used by most 3rd-party 
apps, as well as all GNOME and macOS apps. It might make more sense to 
standardize on those.
  > >
  > >
  > > Just to clarify: F3/Shift+F3 would stay the same, right?
  >
  >
  > Yeah, as backup/additional shortcuts so we don't break workflows for people 
who currently use them.
  
  
  This sounds that we speak of different actions here. This proposal does 
**not** touch the F3/Shift+F3 action which is "Next/Prev result" **from a 
search that was started with Ctrl+F**. It is not my intention to make changes 
there.
  It is about introducing a default shortcut where we currently have none: 
"Goto Next/Prev result item" coming **from a search across multiple files**.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17442

To: gregormi, #kate
Cc: ngraham, kwrite-devel, kde-frameworks-devel, hase, michaelh, bruns, 
demsking, cullmann, sars, dhaumann

D17442: KTextEditor: Tweak keyboard shortcuts to prepare for F6/Shift+F6 in Kate

[Nathaniel Graham]

ngraham added a comment.


  In D17442#373755 , @gregormi wrote:
  
  > In D17442#373708 , @ngraham 
wrote:
  >
  > > I always re-bind Find Next and and Find Previous to use [Ctrl] + [G] and 
[Ctrl] + [⇧] + [G]. These are the shortcuts that are used by most 3rd-party 
apps, as well as all GNOME and macOS apps. It might make more sense to 
standardize on those.
  >
  >
  > Just to clarify: F3/Shift+F3 would stay the same, right?
  
  
  Yeah, as backup/additional shortcuts so we don't break workflows for people 
who currently use them.
  
  > Currently, Ctrl+G is bound to "Goto line" which is also common in other 
programs (Atom, Sublime, ...). An alternative for "Goto line" could be Ctrl+L 
as in Qt Creator.
  
  Yeah, Ctrl+L is the more common one used in other editors that I'm familiar 
with.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17442

To: gregormi, #kate
Cc: ngraham, kwrite-devel, kde-frameworks-devel, hase, michaelh, bruns, 
demsking, cullmann, sars, dhaumann

D17030: DictionaryComboBox: Keep user preferred dictionaries on top

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R246:454d4d8be9dc: DictionaryComboBox: Keep user preferred 
dictionaries on top (authored by loh.tar, committed by cullmann).

REPOSITORY
  R246 Sonnet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17030?vs=47194=47202

REVISION DETAIL
  https://phabricator.kde.org/D17030

AFFECTED FILES
  src/core/settings.cpp
  src/core/settings_p.h
  src/core/speller.cpp
  src/core/speller.h
  src/ui/configui.ui
  src/ui/configwidget.cpp
  src/ui/dictionarycombobox.cpp

To: loh.tar, #frameworks, #vdg, ngraham, cullmann
Cc: cullmann, ngraham, kde-frameworks-devel, michaelh, bruns

D17421: Add drive-* icons for YaST Partitioner

[Noah Davis]

ndavis added a comment.


  In D17421#373983 , @ngraham wrote:
  
  > In D17421#373052 , @ndavis wrote:
  >
  > > In D17421#373045 , @ngraham 
wrote:
  > >
  > > > For `drive-multipartition`, maybe a disk with lines that make it look 
like it's internally divided into four pieces?
  > >
  > >
  > > Wasn't quite sure how to do that, so I made this: F6462669: 
Screenshot_20181208_001937.png 
  >
  >
  > That looks great!
  
  
  Only issue with it is that it looks nothing like the monochrome versions.
  
  Here are some more versions I've been playing with, but nothing looks right:
  F6466293: Screenshot_20181209_132426.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17421

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, #vdg, michaelh, bruns

Re: Contributing to KDE is hard because of its build architecture

[Konstantin Kharlamov]

Thanks a lot everyone for replies.

On 09.12.2018 20:54, Nate Graham wrote:

On 12/9/18 10:51 AM, Martin Flöser wrote:

Am 2018-12-09 16:41, schrieb Konstantin Kharlamov:


Official way of building dependencies is using kdesrc-build. It has
multiple problems:


Hi Konstantin,

sorry for your bad experienced, but I think it would have been much 
easier. Assuming you are on a Debian based distribution the steps 
should just be:


* sudo apt build-dep kmail
* kdesrc-build kde-pim

I personally don't have all dependencies build from source, but just 
the one I develop. Everything else I do through distro packages. I 
would never try to build something like webengine from source, that's 
just a mess.


In fact, our official documentation even recommends grabbing 
dependencies using the package manager: 
https://community.kde.org/Get_Involved/development#Build_some_software


This is what I do too and it works great. You get the non-KDE 
dependencies from the distro, and build only the necessary KDE 
dependencies from source using kdesrc-build. It's generally very smooth.


Did you find the instructions at 
https://community.kde.org/Get_Involved/development difficult to follow 
or understand? I'm always interested in improving this documentation.




Yeah, I couldn't use distro package manager for reasons Nicolas Fell in 
other mail mentioned. I will follow the advice on trying a docker 
container, thanks everyone again!

Re: Contributing to KDE is hard because of its build architecture

[Nicolas Fella]

Sorry to hear about your bad experience. We have an ongoing initiative to ease 
the process of getting involved [0]

On 12/9/18 10:51 AM, Martin Flöser wrote:
 > 
 > sorry for your bad experienced, but I think it would have been much
 > easier. Assuming you are on a Debian based distribution the steps should
 > just be:
 > 
 > * sudo apt build-dep kmail
 > * kdesrc-build kde-pim
 > 
 > I personally don't have all dependencies build from source, but just the
 > one I develop. Everything else I do through distro packages. I would
 > never try to build something like webengine from source, that's just a
 > mess.

That approach works fine for most KDE software. However KMail (and probably all 
the other PIM products) is special in this regard since it always requires the 
latest PIM libraries, so the distro packages are too old in most cases. You 
could use a virtual machine running KDE Neon Developer Edition Unstable to get 
the required packages. The PIM team provides a Docker container [1] that 
bundles KDE Neon and kdesrc-build. It helped me a lot building KDE PIM 
software.

[0] https://phabricator.kde.org/T7116
[1] https://community.kde.org/KDE_PIM/Docker

Re: Contributing to KDE is hard because of its build architecture

[Nate Graham]

On 12/9/18 10:51 AM, Martin Flöser wrote:

Am 2018-12-09 16:41, schrieb Konstantin Kharlamov:


Official way of building dependencies is using kdesrc-build. It has
multiple problems:


Hi Konstantin,

sorry for your bad experienced, but I think it would have been much 
easier. Assuming you are on a Debian based distribution the steps should 
just be:


* sudo apt build-dep kmail
* kdesrc-build kde-pim

I personally don't have all dependencies build from source, but just the 
one I develop. Everything else I do through distro packages. I would 
never try to build something like webengine from source, that's just a 
mess.


In fact, our official documentation even recommends grabbing 
dependencies using the package manager: 
https://community.kde.org/Get_Involved/development#Build_some_software


This is what I do too and it works great. You get the non-KDE 
dependencies from the distro, and build only the necessary KDE 
dependencies from source using kdesrc-build. It's generally very smooth.


Did you find the instructions at 
https://community.kde.org/Get_Involved/development difficult to follow 
or understand? I'm always interested in improving this documentation.


Nate

Re: Contributing to KDE is hard because of its build architecture

[Martin Flöser]

Am 2018-12-09 16:41, schrieb Konstantin Kharlamov:


Official way of building dependencies is using kdesrc-build. It has
multiple problems:


Hi Konstantin,

sorry for your bad experienced, but I think it would have been much 
easier. Assuming you are on a Debian based distribution the steps should 
just be:


* sudo apt build-dep kmail
* kdesrc-build kde-pim

I personally don't have all dependencies build from source, but just the 
one I develop. Everything else I do through distro packages. I would 
never try to build something like webengine from source, that's just a 
mess.


Cheers
Martin

D17030: DictionaryComboBox: Keep user preferred dictionaries on top

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  The intermediate diff looks strange, but the final diff is IMHO ok. Will 
apply that, thanks.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D17030

To: loh.tar, #frameworks, #vdg, ngraham, cullmann
Cc: cullmann, ngraham, kde-frameworks-devel, michaelh, bruns

D17030: DictionaryComboBox: Keep user preferred dictionaries on top

[loh tar]

loh.tar added a comment.


  Um, I'm bit confused when I now look at the diff 1/2 here???

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D17030

To: loh.tar, #frameworks, #vdg, ngraham, cullmann
Cc: cullmann, ngraham, kde-frameworks-devel, michaelh, bruns

D17030: DictionaryComboBox: Keep user preferred dictionaries on top

[loh tar]

loh.tar updated this revision to Diff 47194.
loh.tar added a comment.


  - Add @since hint to speller.h
  - Add some blank lines to speller.h to be looking a little bit nicer

REPOSITORY
  R246 Sonnet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17030?vs=45842=47194

REVISION DETAIL
  https://phabricator.kde.org/D17030

AFFECTED FILES
  src/core/settings.cpp
  src/core/settings_p.h
  src/core/speller.cpp
  src/core/speller.h
  src/ui/configui.ui
  src/ui/configwidget.cpp
  src/ui/dictionarycombobox.cpp

To: loh.tar, #frameworks, #vdg, ngraham, cullmann
Cc: cullmann, ngraham, kde-frameworks-devel, michaelh, bruns

D17457: use STL were no implicit sharing is required

[Christoph Cullmann]

cullmann created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
cullmann requested review of this revision.

REVISION SUMMARY
  try to move to STL for some parts that don't want any sharing nor
  detaching

TEST PLAN
  make && make test

REPOSITORY
  R39 KTextEditor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17457

AFFECTED FILES
  src/buffer/katetextblock.cpp
  src/buffer/katetextblock.h

To: cullmann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17030: DictionaryComboBox: Keep user preferred dictionaries on top

[Christoph Cullmann]

cullmann added a comment.


  In D17030#373994 , @loh.tar wrote:
  
  > In D17030#373912 , @cullmann 
wrote:
  >
  > > Ah, one thing: Could you add some @since 5.xxx to the new function in 
speller.h?
  >
  >
  > Only in speller? In settings_p.h are also two new, but there was no docu, 
so I also wrote nothing, but could
  
  
  I think only speller.h is installed as public API, yes.
  
  > 
  > 
  >> I assume 5.54 would be the right one.
  > 
  > In CMake it's currently `KF5_VERSION 5.53.0` so 5.54 is the right one?
  
  I think so.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D17030

To: loh.tar, #frameworks, #vdg, ngraham, cullmann
Cc: cullmann, ngraham, kde-frameworks-devel, michaelh, bruns

D17030: DictionaryComboBox: Keep user preferred dictionaries on top

[loh tar]

loh.tar added a comment.


  In D17030#373912 , @cullmann wrote:
  
  > Ah, one thing: Could you add some @since 5.xxx to the new function in 
speller.h?
  
  
  Only in speller? In settings_p.h are also two new, but there was no docu, so 
I also wrote nothing, but could
  
  > I assume 5.54 would be the right one.
  
  In CMake it's currently `KF5_VERSION 5.53.0` so 5.54 is the right one?

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D17030

To: loh.tar, #frameworks, #vdg, ngraham, cullmann
Cc: cullmann, ngraham, kde-frameworks-devel, michaelh, bruns

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

[Nathaniel Graham]

ngraham added a comment.


  In terms of the submenu text, I just noticed that we already have "Find 
Variants" in the Edit menu, so I'm okay with using "Save Variants" and "Close 
variants" for consistency. We can decide later whether we want to keep that 
style.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17137

To: gregormi, #kate, #kdevelop
Cc: ngraham, cullmann, flherne, dhaumann, kwrite-devel, kde-frameworks-devel, 
hase, michaelh, bruns, demsking, sars

D17425: dcb settings

[Jan Grulich]

jgrulich added inline comments.

INLINE COMMENTS

> setting.h:98
>  
> +enum DcbFlagType {
> +// None = 0,

This flags should be defined in dcbsetting.h, there is no reason to have them 
defined here.

REVISION DETAIL
  https://phabricator.kde.org/D17425

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17421: Add drive-* icons for YaST Partitioner

[Nathaniel Graham]

ngraham added a comment.


  In D17421#373052 , @ndavis wrote:
  
  > In D17421#373045 , @ngraham 
wrote:
  >
  > > For `drive-multipartition`, maybe a disk with lines that make it look 
like it's internally divided into four pieces?
  >
  >
  > Wasn't quite sure how to do that, so I made this: F6462669: 
Screenshot_20181208_001937.png 
  
  
  That looks great!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17421

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, #vdg, michaelh, bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.11 - Build # 6 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.11/6/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Sun, 09 Dec 2018 17:04:51 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.autotests.src Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: projectroot.autotests.src.vimode.vimode_keys
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(254/289)88%
(254/289)68%
(32962/48237)51%
(15852/30986)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(37/37)100%
(37/37)94%
(4431/4730)49%
(1696/3450)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5483/5523)58%
(996/1712)src.buffer88%
(15/17)88%
(15/17)90%
(1699/1881)76%
(1215/1598)src.completion100%
(11/11)100%
(11/11)57%
(1772/3109)43%
(1160/2717)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(184/459)22%
(76/348)src.dialogs0%
(0/4)0%
(0/4)0%
(0/732)0%
(0/176)src.document100%
(4/4)100%
(4/4)59%
(1870/3165)47%
(1565/3313)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(221/244)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)63%
(189/302)51%
(39/77)src.mode83%
(5/6)83%
(5/6)41%
(171/417)40%
(111/275)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/830)0%
(0/294)src.render100%
(7/7)100%
(7/7)77%
(953/1244)67%
(627/942)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)68%
(731/1069)58%
(268/465)src.search100%
(6/6)100%
(6/6)74%
(1109/1498)64%

D17441: tune editing actions for large number of small edits

[Christoph Cullmann]

cullmann added a comment.


  Fixed my QSet issues, I was just stupid, I shall have guarded the push_back 
with the bool, not the later use. ;=)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17441

To: cullmann, dhaumann, #kate, loh.tar
Cc: anthonyfieroni, kwrite-devel, kde-frameworks-devel, hase, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D17441: tune editing actions for large number of small edits

[Christoph Cullmann]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:2138e1d27c83: improve range handling, no allocations for 
common updates (authored by cullmann).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D17441?vs=47182=47191#toc

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17441?vs=47182=47191

REVISION DETAIL
  https://phabricator.kde.org/D17441

AFFECTED FILES
  src/buffer/katetextblock.cpp
  src/buffer/katetextrange.cpp
  src/buffer/katetextrange.h

To: cullmann, dhaumann, #kate, loh.tar
Cc: anthonyfieroni, kwrite-devel, kde-frameworks-devel, hase, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.9 - Build # 81 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.9/81/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 09 Dec 2018 16:31:56 +
 Build duration:
6 min 53 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(70/82)85%
(70/82)75%
(6346/8464)43%
(10138/23410)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2696/2772)49%
(5763/11827)src.desktoptojson100%
(2/2)100%
(2/2)77%
(86/111)38%
(121/321)src.lib67%
(2/3)67%
(2/3)60%
(352/591)26%
(242/938)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1043/2803)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(660/776)42%
(972/2301)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(377/787)45%
(863/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(740/916)52%
(854/1637)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.11 - Build # 4 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.11/4/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Sun, 09 Dec 2018 16:31:56 +
 Build duration:
5 min 45 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(70/82)85%
(70/82)75%
(6346/8464)43%
(10138/23412)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2696/2772)49%
(5762/11825)src.desktoptojson100%
(2/2)100%
(2/2)77%
(86/111)38%
(122/325)src.lib67%
(2/3)67%
(2/3)60%
(352/591)26%
(243/942)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1041/2797)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(660/776)42%
(972/2303)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(377/787)45%
(864/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(740/916)52%
(854/1637)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

D17446: cmake macros: Port away from deprecated ECM var in kcoreaddons_add_plugin

[Michael Pyne]

This revision was automatically updated to reflect the committed changes.
Closed by commit R244:1285c4bf5552: cmake macros: Port away from deprecated ECM 
var in kcoreaddons_add_plugin (authored by mpyne).

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17446?vs=47162=47189

REVISION DETAIL
  https://phabricator.kde.org/D17446

AFFECTED FILES
  KF5CoreAddonsMacros.cmake

To: mpyne, #frameworks, elvisangelaccio, apol, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

Contributing to KDE is hard because of its build architecture

[Konstantin Kharlamov]

Please, don't take it as a rant, because I got over my frustraction a 
week ago, and just writing it in the hope to point out something that 
other developers might not see.


I'm not using KDE myself (i3wm here), but 2 weeks ago I stepped into my 
never-ending journey of trying to use KMail, failed it (of course, 
filled bug-reports along the way), and then figured "Okay, I'm a 
developer — why wouldn't I just go fix the app".


And then I got into a trouble: building KMail. I have most recent stable 
KDE, but upstream KMail requires its dependencies to be also built from 
upstream. Maybe it's for the best, because when I built and debugged 
stable version of KMail, the bug went some place outside of KMail.


Official way of building dependencies is using kdesrc-build. It has 
multiple problems:


1. it's really bad at handling dependencies. The `kdesrc-build kmail` 
results in it trying to build 108 packages, including a game "bomber". I 
didn't have that much space on my HDD, so I had to delete some stuff, 
but in the end I ran the build.
2. there're also "upstream" dependencies that kdesrc-build doesn't 
handle. After the build finished, I found 5x fails out of 108 packages. 
Including KMail. Turns out, KMail depends on QtWebEngine (upstream 
version too), but kdesrc-build can't build it, you have to do that 
manually, and then somehow make sure kdesrc-build will see it.
3. it does not notify about dependency problems, it just goes straight 
to build. I understand it's not possible to include into build system 
every tiny library out there. But at least it should've printed all 
dependencies before going to build. Because you can't expect someone to 
stay overnight staring at terminal and waiting for another build fail, 
so that the person could install another dependency. It could've worked 
like this had you 3-4 packages taking an hour to build in summary, but 
not 108!
4. `kdesrc-build run` probably does not work…? I'm not sure on that one, 
because I found the option just for writing that mail. But for asking on 
IRC #kontact before I stumbled upon 1,2,3 points, the major problem I 
had is that docs mention that to run an app built with kdesrc-build I 
have to "install" it. Not necessary in the system, just don't forget to 
export correct paths. However, installing stuff on every added "printf" 
is counter-productive.


Most contributors not gonna spend a week of their time just trying to 
build an app they wanted to contribute to. E.g. for me fixing KMail 
supposed to be a quick side project, I have others to I care about. It 
would be great if those who care about KDE more made the workflow for 
new contributors as easy as:


1. Run `kdesrc-build app`
2. Install unsatisfied dependencies
3. Rerun `kdesrc-build app`, and wait for it to finish.
4. Run `kdesrc-build run app`, which will take care of all the necessary 
exports.

D17128: DocumentPrivate: Remove comment mark when joining lines

[Christoph Cullmann]

cullmann added a comment.


  I think we could do that in two steps:
  
  1. Introduce some "smart wrap" setting and using generic code like the above 
for that
  2. If then still we have too many issues, one could outsource that to a js 
function (if there, like Dominik proposed).

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17128

To: loh.tar, #ktexteditor
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, 
michaelh, ngraham, bruns, demsking, head7, kfunk, sars

D17441: tune editing actions for large number of small edits

[Christoph Cullmann]

cullmann added a comment.


  In D17441#373939 , @loh.tar wrote:
  
  > > Yes, there is now a limit for how many highlightings are done.
  > >  If its too much, we skip that, else the rendering will break everthing 
down ;=)
  >
  > Doing these highliting "on the fly" (only what is/became visible) is 
probably not possible(?)
  
  
  In principle yes, but I think that is too much work for the case that "mostly 
all things" are marked ;=)
  
  > BTW: Thanks a lot for your detailed perf explanations! Unfortunately didn't 
see I more clear, these percent data are not very self explanatory
  
  perf is really great, without any large overhead one can directly see (in 
most cases) were to put effort into.
  
  further info about the flamegraph I attached as SVG here, see on
  
  http://www.brendangregg.com/flamegraphs.html
  
  :=) The run perf on the production servers of netflix, not bad.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17441

To: cullmann, dhaumann, #kate, loh.tar
Cc: anthonyfieroni, kwrite-devel, kde-frameworks-devel, hase, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D17441: tune editing actions for large number of small edits

[loh tar]

loh.tar added a comment.


  > Yes, there is now a limit for how many highlightings are done.
  >  If its too much, we skip that, else the rendering will break everthing 
down ;=)
  
  Doing these highliting "on the fly" (only what is/became visible) is probably 
not possible(?)
  
  BTW: Thanks a lot for your detailed perf explanations! Unfortunately didn't 
see I more clear, these percent data are not very self explanatory

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17441

To: cullmann, dhaumann, #kate, loh.tar
Cc: anthonyfieroni, kwrite-devel, kde-frameworks-devel, hase, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D17436: BrightScript: Remove unused keyword list 'end'

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:d4c10b4533ed: BrightScript: Remove unused keyword list 
end (authored by dhaumann, committed by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17436?vs=47134=47186

REVISION DETAIL
  https://phabricator.kde.org/D17436

AFFECTED FILES
  data/syntax/brightscript.xml

To: dhaumann, dlevin, cullmann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17436: BrightScript: Remove unused keyword list 'end'

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  If not used, I shall go, no need to have the warning around.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix_brightscript

REVISION DETAIL
  https://phabricator.kde.org/D17436

To: dhaumann, dlevin, cullmann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17437: SearchBar: Avoid malfunction with very large files

[Christoph Cullmann]

cullmann added a comment.


  Ok, I would prefer then if you retract that and submit the cancel thingy.
  
  Btw., thanks for all the nice improvements that are submitted!
  Such fixes are highly appreciated.
  
  If you think a review is not done timely, no issue to e.g. poke me.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17437

To: loh.tar, #ktexteditor, #vdg, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, 
ngraham, bruns, demsking, sars, dhaumann

D17437: SearchBar: Avoid malfunction with very large files

[loh tar]

loh.tar added a comment.


  In this state was this patch only a simple attempt to avoid the worst case. 
  With your new improvements is it much less likely to happen, but still 
possible. I do not like to insist of this patch it's only an offer, which could 
be improved.
  
  BTW I'm working on your suggestion to add a (functioning) Cancel button. With 
that, this patch may become more obsolete ;-)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17437

To: loh.tar, #ktexteditor, #vdg, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, 
ngraham, bruns, demsking, sars, dhaumann

D17055: Avoid Q_FOREACH

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  I would say it looks reasonable and either only stuff const stuff or fresh 
things inside the for.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D17055

To: loh.tar, davidedmundson, cullmann
Cc: cullmann, kde-frameworks-devel, michaelh, ngraham, bruns

D17028: Loader: Avoid Q_FOREACH

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R246:bf8f3067fd3a: Loader: Avoid Q_FOREACH (authored by 
loh.tar, committed by cullmann).

REPOSITORY
  R246 Sonnet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17028?vs=45838=47185

REVISION DETAIL
  https://phabricator.kde.org/D17028

AFFECTED FILES
  src/core/loader.cpp

To: loh.tar, davidedmundson
Cc: cullmann, cfeck, smartins, kde-frameworks-devel, michaelh, ngraham, bruns

D17028: Loader: Avoid Q_FOREACH

[Christoph Cullmann]

cullmann added a comment.


  We started to accept his patches for other frameworks, I think there is no 
harm in doing so, here, too. Real name or not.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D17028

To: loh.tar, davidedmundson
Cc: cullmann, cfeck, smartins, kde-frameworks-devel, michaelh, ngraham, bruns

D17056: Dialog: Use DictionaryComboBox instead of plain QComboBox

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R246:a38e1c04a035: Dialog: Use DictionaryComboBox instead of 
plain QComboBox (authored by loh.tar, committed by cullmann).

REPOSITORY
  R246 Sonnet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17056?vs=45899=47184

REVISION DETAIL
  https://phabricator.kde.org/D17056

AFFECTED FILES
  src/ui/dialog.cpp
  src/ui/sonnetui.ui

To: loh.tar, #frameworks, cullmann
Cc: cullmann, mludwig, kde-frameworks-devel, michaelh, ngraham, bruns

D17056: Dialog: Use DictionaryComboBox instead of plain QComboBox

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Like the change in KTextEditor, I think this should go in.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D17056

To: loh.tar, #frameworks, cullmann
Cc: cullmann, mludwig, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.11 - Build # 5 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.11/5/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Sun, 09 Dec 2018 14:40:25 +
 Build duration:
8 min 25 sec and counting
   BUILD ARTIFACTS
  compat_reports/KF5TextEditor_compat_report.html
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.autotests.src Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: projectroot.autotests.src.vimode.vimode_keys
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(254/289)88%
(254/289)68%
(32944/48219)51%
(15832/30966)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(37/37)100%
(37/37)94%
(4431/4730)49%
(1696/3450)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5483/5523)58%
(996/1712)src.buffer88%
(15/17)88%
(15/17)90%
(1681/1863)76%
(1195/1578)src.completion100%
(11/11)100%
(11/11)57%
(1772/3109)43%
(1160/2717)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(184/459)22%
(76/348)src.dialogs0%
(0/4)0%
(0/4)0%
(0/732)0%
(0/176)src.document100%
(4/4)100%
(4/4)59%
(1870/3165)47%
(1565/3313)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(221/244)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)63%
(189/302)51%
(39/77)src.mode83%
(5/6)83%
(5/6)41%
(171/417)40%
(111/275)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/830)0%
(0/294)src.render100%
(7/7)100%
(7/7)77%
(953/1244)67%
(627/942)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)68%
(731/1069)58%
(268/465)src.search100%
(6/6)100%
 

D17030: DictionaryComboBox: Keep user preferred dictionaries on top

[Christoph Cullmann]

cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  Ah, one thing: Could you add some @since 5.xxx to the new function in 
speller.h? I assume 5.54 would be the right one.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D17030

To: loh.tar, #frameworks, #vdg, ngraham, cullmann
Cc: cullmann, ngraham, kde-frameworks-devel, michaelh, bruns

D17030: DictionaryComboBox: Keep user preferred dictionaries on top

[Christoph Cullmann]

cullmann added a comment.


  I think this makes sense, it improves the usability of the dictionary 
selection.
  I see no API issues, should be BC and docs are there, too.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D17030

To: loh.tar, #frameworks, #vdg, ngraham
Cc: cullmann, ngraham, kde-frameworks-devel, michaelh, bruns

D17441: tune editing actions for large number of small edits

[Christoph Cullmann]

cullmann added a comment.


  > The only curiosity I noticed is that no highliting take effect when there 
are too much hits(?) Search some number like 5 "142926 matches found" no 
highlight. Char A "10565 matches found" is highlighted
  
  Yes, there is now a limit for how many highlightings are done.
  If its too much, we skip that, else the rendering will break everthing down 
;=)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17441

To: cullmann, dhaumann, #kate, loh.tar
Cc: anthonyfieroni, kwrite-devel, kde-frameworks-devel, hase, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D17437: SearchBar: Avoid malfunction with very large files

[Christoph Cullmann]

cullmann added a comment.


  I think the current state after the improvements in the other bug is good 
enough to avoid such a message.
  Would it be ok for you to abandon this?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17437

To: loh.tar, #ktexteditor, #vdg, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, 
ngraham, bruns, demsking, sars, dhaumann

D17441: tune editing actions for large number of small edits

[loh tar]

loh.tar added a comment.


  > This needs now some user testing ;=)
  
  Done as previous, with that testfile. Seams to work so far. Find is still 
quick, these TAB S takes around 2min.
  
  The only curiosity I noticed is that no highliting take effect when there are 
too much hits(?) Search some number like 5 "142926 matches found" no highlight. 
Char A "10565 matches found" is highlighted

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17441

To: cullmann, dhaumann, #kate, loh.tar
Cc: anthonyfieroni, kwrite-devel, kde-frameworks-devel, hase, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D17382: KateViewInternal: Rename getMouse/Cursor() => mouse/cursorPosition() to fit coding style

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:9ed6507bce24: KateViewInternal: Rename getMouse/Cursor() 
= mouse/cursorPosition() to fit… (authored by loh.tar, committed by 
cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17382?vs=46963=47183

REVISION DETAIL
  https://phabricator.kde.org/D17382

AFFECTED FILES
  src/view/kateview.cpp
  src/view/kateviewaccessible.h
  src/view/kateviewinternal.h
  src/vimode/inputmodemanager.cpp

To: loh.tar, #ktexteditor, cullmann, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, 
ngraham, bruns, demsking, cullmann, sars

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.11 - Build # 4 - Still Unstable!

[Dr.-Ing. Christoph Cullmann]

Hi,

if somebody has an idea, why this test case doesn't work with Qt 5.11 but works 
ok with Qt 5.9,
any hints would be appreciated :(

Greetings
Christoph

- Am 9. Dez 2018 um 15:22 schrieb CI System nore...@kde.org:

> BUILD UNSTABLE
> Build URL [
> https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.11/4/
> |
> https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.11/4/
> ]
> Project:  kf5-qt5 SUSEQt5.11
> Date of build:Sun, 09 Dec 2018 14:09:15 +
> Build duration:   12 min and counting
> JUnit Tests
> Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 
> 1
> test(s)
> Name: projectroot Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s),
> Total: 61 test(s)
> Name: projectroot.autotests.src Failed: 1 test(s), Passed: 4 test(s), 
> Skipped: 0
> test(s), Total: 5 test(s)
> * Failed: projectroot.autotests.src.vimode.vimode_keys
> 
> Cobertura Report Project Coverage Summary NamePackagesFiles   
> Classes Lines
>   Conditionals
> Cobertura Coverage Report 79% (22/28) 88% (254/289)   88% (254/289)   
> 68%
> (32944/48219) 51% (15832/30966) Coverage Breakdown by Package Name
> Files
>   Classes Lines   Conditionals
> autotests.src 100% (37/37)100% (37/37)94% (4431/4730) 
> 49% (1696/3450)
> autotests.src.vimode  100% (9/9)  100% (9/9)  99% (5483/5523) 
> 58% (996/1712)
> src.buffer88% (15/17) 88% (15/17) 90% (1681/1863) 76% 
> (1195/1578)
> src.completion100% (11/11)100% (11/11)57% (1772/3109) 
> 43% (1160/2717)
> src.completion.expandingtree  100% (3/3)  100% (3/3)  40% (184/459)   
> 22%
> (76/348)
> src.dialogs   0% (0/4)0% (0/4)0% (0/732)  0% (0/176)
> src.document  100% (4/4)  100% (4/4)  59% (1870/3165) 47% 
> (1565/3313)
> src.export0% (0/4)0% (0/4)0% (0/119)  0% (0/162)
> src.include.ktexteditor   93% (14/15) 93% (14/15) 91% (221/244)   
> 65% (146/226)
> src.inputmode 100% (8/8)  100% (8/8)  63% (189/302)   51% 
> (39/77)
> src.mode  83% (5/6)   83% (5/6)   41% (171/417)   40% (111/275)
> src.part  0% (0/1)0% (0/1)0% (0/7)100% (0/0)
> src.printing  0% (0/4)0% (0/4)0% (0/830)  0% (0/294)
> src.render100% (7/7)  100% (7/7)  77% (953/1244)  67% (627/942)
> src.schema29% (2/7)   29% (2/7)   1% (20/1492)1% (6/673)
> src.script100% (16/16)100% (16/16)68% (731/1069)  58% (268/465)
> src.search100% (6/6)  100% (6/6)  74% (1109/1498) 64% 
> (576/904)
> src.spellcheck86% (6/7)   86% (6/7)   30% (374/1249)  28% 
> (216/778)
> src.swapfile  50% (1/2)   50% (1/2)   32% (122/376)   31% (62/199)
> src.syntax88% (7/8)   88% (7/8)   66% (478/729)   36% (204/572)
> src.undo  100% (5/5)  100% (5/5)  88% (657/746)   73% (302/412)
> src.utils 94% (32/34) 94% (32/34) 68% (2732/4005) 51% 
> (1351/2654)
> src.variableeditor0% (0/5)0% (0/5)0% (0/580)  0% 
> (0/128)
> src.view  88% (15/17) 88% (15/17) 56% (3670/6555) 42% 
> (1698/4010)
> src.vimode100% (29/29)100% (29/29)81% (1894/2325) 60% 
> (1042/1751)
> src.vimode.config 0% (0/1)0% (0/1)0% (0/124)  0% 
> (0/88)
> src.vimode.emulatedcommandbar 100% (12/12)100% (12/12)99% 
> (904/915)   91%
> (617/678)
> src.vimode.modes  100% (10/10)100% (10/10)87% (3298/3812) 
> 79% (1879/2384)

-- 
- Dr.-Ing. Christoph Cullmann -
AbsInt Angewandte Informatik GmbH  Email: cullm...@absint.com
Science Park 1 Tel:   +49-681-38360-22
66123 Saarbrücken  Fax:   +49-681-38360-20
GERMANYWWW:   http://www.AbsInt.com

Geschäftsführung: Dr.-Ing. Christian Ferdinand
Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.11 - Build # 4 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.11/4/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Sun, 09 Dec 2018 14:09:15 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.autotests.src Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: projectroot.autotests.src.vimode.vimode_keys
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(254/289)88%
(254/289)68%
(32944/48219)51%
(15832/30966)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(37/37)100%
(37/37)94%
(4431/4730)49%
(1696/3450)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5483/5523)58%
(996/1712)src.buffer88%
(15/17)88%
(15/17)90%
(1681/1863)76%
(1195/1578)src.completion100%
(11/11)100%
(11/11)57%
(1772/3109)43%
(1160/2717)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(184/459)22%
(76/348)src.dialogs0%
(0/4)0%
(0/4)0%
(0/732)0%
(0/176)src.document100%
(4/4)100%
(4/4)59%
(1870/3165)47%
(1565/3313)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(221/244)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)63%
(189/302)51%
(39/77)src.mode83%
(5/6)83%
(5/6)41%
(171/417)40%
(111/275)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/830)0%
(0/294)src.render100%
(7/7)100%
(7/7)77%
(953/1244)67%
(627/942)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)68%
(731/1069)58%
(268/465)src.search100%
(6/6)100%
(6/6)74%
(1109/1498)64%

D17441: tune editing actions for large number of small edits

[Christoph Cullmann]

cullmann added a comment.


  Hmpf, I amended my commit message to contain a CHANGELOG... and stuff bug 
unfortunately arc land ate that again :P

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17441

To: cullmann, dhaumann, #kate, loh.tar
Cc: anthonyfieroni, kwrite-devel, kde-frameworks-devel, hase, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D17441: tune editing actions for large number of small edits

[Christoph Cullmann]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:85a1c56ed832: tune editing actions for large number of 
small edits (authored by cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17441?vs=47181=47182

REVISION DETAIL
  https://phabricator.kde.org/D17441

AFFECTED FILES
  src/buffer/katetextblock.cpp
  src/buffer/katetextcursor.cpp
  src/buffer/katetexthistory.cpp
  src/buffer/katetexthistory.h
  src/buffer/katetextrange.h
  src/document/katedocument.cpp
  src/document/katedocument.h
  src/search/katematch.cpp
  src/search/katematch.h
  src/search/katesearchbar.cpp
  src/undo/kateundo.cpp
  src/undo/kateundo.h
  src/utils/documentcursor.cpp
  src/vimode/marks.cpp
  src/vimode/marks.h

To: cullmann, dhaumann, #kate, loh.tar
Cc: anthonyfieroni, kwrite-devel, kde-frameworks-devel, hase, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D17441: tune editing actions for large number of small edits

[Christoph Cullmann]

cullmann added a comment.


  This needs now some user testing ;=)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17441

To: cullmann, dhaumann, #kate, loh.tar
Cc: anthonyfieroni, kwrite-devel, kde-frameworks-devel, hase, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D17441: tune editing actions for large number of small edits

[Christoph Cullmann]

cullmann added inline comments.

INLINE COMMENTS

> loh.tar wrote in katetextblock.cpp:290
> Noob question: Would QPointer help?
> 
>   if (range && range->isValidityCheckRequired()) {

As it is no QObject, no ;=) Actually, I think all workaround might be even more 
expensive than the QSet.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17441

To: cullmann, dhaumann, #kate, loh.tar
Cc: anthonyfieroni, kwrite-devel, kde-frameworks-devel, hase, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D17441: tune editing actions for large number of small edits

[Christoph Cullmann]

cullmann added a comment.


  One issue I have with the auto-tests:
  
  With and without any of these changes here locally the vimode_keys test fails.
  
  FAIL!  : KeysTest::MacroTests() Compared values are not the same
  
Actual   (kate_document->text()): "completionMacro 
completionRepeatLastChange completionRep"
Expected (expected_text): "completionMacro 
completionRepeatLastChange completionRepeatLastChange"
Loc: 
[/home/cullmann/kde/src/frameworks/ktexteditor/autotests/src/vimode/keys.cpp(1512)]

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17441

To: cullmann, dhaumann, #kate, loh.tar
Cc: anthonyfieroni, kwrite-devel, kde-frameworks-devel, hase, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D17441: tune editing actions for large number of small edits

[loh tar]

loh.tar added inline comments.

INLINE COMMENTS

> cullmann wrote in katetextblock.cpp:290
> Ok, doesn't work due to the issue that we might delete the range via notifier 
> in checkValidity() :P

Noob question: Would QPointer help?

  if (range && range->isValidityCheckRequired()) {

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17441

To: cullmann, dhaumann, #kate, loh.tar
Cc: anthonyfieroni, kwrite-devel, kde-frameworks-devel, hase, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D17441: tune editing actions for large number of small edits

[Christoph Cullmann]

cullmann marked 6 inline comments as done.
cullmann added a comment.


  Crash fixed again.
  Updated comments to make more clear what happens.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17441

To: cullmann, dhaumann, #kate, loh.tar
Cc: anthonyfieroni, kwrite-devel, kde-frameworks-devel, hase, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D17441: tune editing actions for large number of small edits

[Christoph Cullmann]

cullmann updated this revision to Diff 47181.
cullmann added a comment.


  go back to QSet for the checkValidity, mark in the comments that ranges might 
be deleted

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17441?vs=47177=47181

BRANCH
  arcpatch-D17441

REVISION DETAIL
  https://phabricator.kde.org/D17441

AFFECTED FILES
  src/buffer/katetextblock.cpp
  src/buffer/katetextcursor.cpp
  src/buffer/katetexthistory.cpp
  src/buffer/katetexthistory.h
  src/buffer/katetextrange.h
  src/document/katedocument.cpp
  src/document/katedocument.h
  src/search/katematch.cpp
  src/search/katematch.h
  src/search/katesearchbar.cpp
  src/undo/kateundo.cpp
  src/undo/kateundo.h
  src/utils/documentcursor.cpp
  src/vimode/marks.cpp
  src/vimode/marks.h

To: cullmann, dhaumann, #kate, loh.tar
Cc: anthonyfieroni, kwrite-devel, kde-frameworks-devel, hase, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D17441: tune editing actions for large number of small edits

[Christoph Cullmann]

cullmann added a comment.


  Ok, the optimization with the vector fails due delets inside checkValidity(), 
need to revert that and update docs.

INLINE COMMENTS

> cullmann wrote in katetextblock.cpp:290
> This loop now crash in the unit test
> 
> ./bin/bug313759
> 
> )
> =
> 
> It works again, if I use a QSet, at that one location.
> I think this is some ordering issue, funny.
> Need to investigate.

Ok, doesn't work due to the issue that we might delete the range via notifier 
in checkValidity() :P

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17441

To: cullmann, dhaumann, #kate, loh.tar
Cc: anthonyfieroni, kwrite-devel, kde-frameworks-devel, hase, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D17441: tune editing actions for large number of small edits

[Christoph Cullmann]

cullmann added a comment.


  :P Crash for the win.

INLINE COMMENTS

> katetextblock.cpp:290
> +// we might need to invalidate ranges or notify about their changes
> +for (TextRange *range : changedRanges) {
> +if (range->isValidityCheckRequired()) {

This loop now crash in the unit test

./bin/bug313759

)
=

It works again, if I use a QSet, at that one location.
I think this is some ordering issue, funny.
Need to investigate.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17441

To: cullmann, dhaumann, #kate, loh.tar
Cc: anthonyfieroni, kwrite-devel, kde-frameworks-devel, hase, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D17441: tune editing actions for large number of small edits

[Christoph Cullmann]

cullmann updated this revision to Diff 47177.
cullmann added a comment.


  save 1% total runtime in addItem

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17441?vs=47174=47177

BRANCH
  arcpatch-D17441

REVISION DETAIL
  https://phabricator.kde.org/D17441

AFFECTED FILES
  src/buffer/katetextblock.cpp
  src/buffer/katetextcursor.cpp
  src/buffer/katetexthistory.cpp
  src/buffer/katetexthistory.h
  src/buffer/katetextrange.cpp
  src/buffer/katetextrange.h
  src/document/katedocument.cpp
  src/document/katedocument.h
  src/search/katematch.cpp
  src/search/katematch.h
  src/search/katesearchbar.cpp
  src/undo/kateundo.cpp
  src/undo/kateundo.h
  src/utils/documentcursor.cpp
  src/vimode/marks.cpp
  src/vimode/marks.h

To: cullmann, dhaumann, #kate, loh.tar
Cc: anthonyfieroni, kwrite-devel, kde-frameworks-devel, hase, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D17441: tune editing actions for large number of small edits

[Christoph Cullmann]

cullmann updated this revision to Diff 47174.
cullmann added a comment.


  next minor bottleneck: QList with things a bit larger than a pointer
  in addition, here zero sharing is needed or wanted, we can use a plain vector

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17441?vs=47173=47174

BRANCH
  arcpatch-D17441

REVISION DETAIL
  https://phabricator.kde.org/D17441

AFFECTED FILES
  src/buffer/katetextblock.cpp
  src/buffer/katetextcursor.cpp
  src/buffer/katetexthistory.cpp
  src/buffer/katetexthistory.h
  src/buffer/katetextrange.cpp
  src/buffer/katetextrange.h
  src/document/katedocument.cpp
  src/document/katedocument.h
  src/search/katematch.cpp
  src/search/katematch.h
  src/search/katesearchbar.cpp
  src/utils/documentcursor.cpp
  src/vimode/marks.cpp
  src/vimode/marks.h

To: cullmann, dhaumann, #kate, loh.tar
Cc: anthonyfieroni, kwrite-devel, kde-frameworks-devel, hase, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 368 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/368/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 09 Dec 2018 11:04:57 +
 Build duration:
1 hr 23 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiogui_favicontestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(262/398)66%
(262/398)53%
(32097/60116)38%
(16590/44086)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9093/9538)48%
(4280/8965)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8357/14337)51%
(4686/9263)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3909/7970)34%
(1604/4743)src.gui100%
(2/2)100%
(2/2)88%
(95/108)68%
(45/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(532/1036)37%
(319/868)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1765/4288)35%
(1306/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
  

D17441: tune editing actions for large number of small edits

[Christoph Cullmann]

cullmann updated this revision to Diff 47173.
cullmann added a comment.


  avoid most allocations for the common cases of a few affected ranges

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17441?vs=47172=47173

BRANCH
  arcpatch-D17441

REVISION DETAIL
  https://phabricator.kde.org/D17441

AFFECTED FILES
  src/buffer/katetextblock.cpp
  src/buffer/katetextcursor.cpp
  src/buffer/katetextrange.cpp
  src/buffer/katetextrange.h
  src/document/katedocument.cpp
  src/document/katedocument.h
  src/search/katematch.cpp
  src/search/katematch.h
  src/search/katesearchbar.cpp
  src/utils/documentcursor.cpp
  src/vimode/marks.cpp
  src/vimode/marks.h

To: cullmann, dhaumann, #kate, loh.tar
Cc: anthonyfieroni, kwrite-devel, kde-frameworks-devel, hase, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 204 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/204/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 09 Dec 2018 11:08:22 +
 Build duration:
1 hr 9 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3608/13322)18%
(1817/9850)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2247)7%
(96/1454)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1410/3491)28%
(787/2821)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(674/1574)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(582/2017)18%
(313/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%
(0/2)0%
(0/2)0%

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.9 - Build # 54 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.9/54/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 09 Dec 2018 11:03:08 +
 Build duration:
1 hr 14 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.kglobalsettingstestFailed: projectroot.autotests.ktabwidget_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report29%
(4/14)43%
(124/291)43%
(124/291)47%
(21604/45965)38%
(13043/34249)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault0%
(0/1)0%
(0/1)0%
(0/87)0%
(0/56)autotests98%
(44/45)98%
(44/45)97%
(11357/11759)50%
(7168/14375)src0%
(0/1)0%
(0/1)0%
(0/4)0%
(0/2)src.kdebugdialog0%
(0/7)0%
(0/7)0%
(0/256)0%
(0/73)src.kdecore76%
(65/86)76%
(65/86)53%
(9478/17866)48%
(5546/11459)src.kdeui19%
(13/68)19%
(13/68)8%
(759/9698)6%
(328/5364)src.kio7%
(2/27)7%
(2/27)0%
(10/2258)0%
(1/1238)src.kioslave.metainfo0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/4)src.kparts0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/12)src.kssl0%
(0/8)0%
(0/8)0%
(0/1807)0%
(0/853)src.kssl.kcm0%
(0/3)0%
(0/3)0%
(0/264)0%
(0/145)src.solid0%
(0/3)0%
(0/3)0%
(0/188)0%
(0/87)src.solid-networkstatus.kded0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/94)tests0%
(0/34)0%
(0/34)0%
(0/1537)0%
(0/487)

D17441: tune editing actions for large number of small edits

[Christoph Cullmann]

cullmann updated this revision to Diff 47172.
cullmann added a comment.


  improve m_isCheckValidityRequired management

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17441?vs=47160=47172

BRANCH
  arcpatch-D17441

REVISION DETAIL
  https://phabricator.kde.org/D17441

AFFECTED FILES
  src/buffer/katetextblock.cpp
  src/buffer/katetextblock.h
  src/buffer/katetextcursor.cpp
  src/buffer/katetextrange.cpp
  src/buffer/katetextrange.h
  src/document/katedocument.cpp
  src/document/katedocument.h
  src/search/katematch.cpp
  src/search/katematch.h
  src/search/katesearchbar.cpp
  src/utils/documentcursor.cpp
  src/vimode/marks.cpp
  src/vimode/marks.h

To: cullmann, dhaumann, #kate, loh.tar
Cc: anthonyfieroni, kwrite-devel, kde-frameworks-devel, hase, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.9 - Build # 47 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.9/47/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 09 Dec 2018 11:07:43 +
 Build duration:
1 hr 4 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kwindowsystem_kwindowinfox11testFailed: projectroot.autotests.kwindowsystem_netrootinfotestwm
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7112/9546)54%
(3484/6395)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)96%
(3004/3136)51%
(1263/2456)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)57%
(787/1391)45%
(302/670)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3314/4662)60%
(1916/3217)tests0%
(0/5)0%
(0/5)0%
(0/277)0%
(0/46)

D17441: tune editing actions for large number of small edits

[Christoph Cullmann]

cullmann added a comment.


  In D17441#373728 , @loh.tar wrote:
  
  > I have tried this one. Yes, works much more better! 
  >  Nice to see that my own (unloved) patch wake your interest to dig into 
that issue :-)
  
  
  :=) Nice that it helps a bit for the speed isue.
  
  > As usual understand I most of your talk here not really, and these perf 
protocols give me no light on the first sight. But thank you that you let me 
participate.
  
  perf helps you to easily see the hotspots.
  
  e.g. you run
  
  perf report --call-graph dwarf -F 333 kwrite the_test_file...
  
  do your actions there (here replace all).
  
  Afterwards (or if you want only partial trace, press once CTRL-C), you run 
for the flat profile
  
  perf report --max-stack 1024 --stdio -g none > report.txt
  
  Then you see directly which functions might need attentions.
  
  If e.g. a function takes 10% cumulative, 10% is spend in it and all stuff it 
calls.
  If you see there strange stuff, like e.g. the saveEditingPositons, that is a 
nice start for optimizations.
  
  perf report
  
  will allow to have some text ui, or use hotspot for graphical bliss. (or 
generate flamegraph svgs)
  
  > 
  > 
  > - Now, just find all of a char in that fat file is done very quickly
  > - Doing these tab->semicolon S still takes quite a while but works here. 
System monitor told 1.8G memory was eaten
  > 
  >   I think with this patch need KateSearchBar still some improvement. Like 
to give a hint that S is running and the possibility to abort. Would be good 
to add some test if a S may run out of memory. Not everyone has a lot of RAM 
available.
  > 
  >   Um, just a stupid question: Is there a need to do the S just as it is 
done currently? So far I understand that, is the only reason why that is so 
f**antastic slow caused by tons off calls which are intend to track a normal 
editing.
  > 
  >   Why not simple do the S on the raw file, make a diff, highlight the 
changes and we are done(?) I did the tab->semicolon S by sed, just for 
interest, and it takes 2-3 seconds :-/
  
  The thing is: is you do that this way, you loose all convenience.
  e.g. if the user has marks on lines, they will not move, if there are 
additional highlighings, they are lost, even if you just replace a few letters 
somewhere.
  All that overhead is there for a reason to have nifty features, if you want 
raw speed, yes, a script or plain command line tool like sed will always win.
  But I think we should try to shave of as much overhead as possible, without 
crippling the user experience.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17441

To: cullmann, dhaumann, #kate, loh.tar
Cc: anthonyfieroni, kwrite-devel, kde-frameworks-devel, hase, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann