D26103: Put Q_REQUIRED_RESULT in front of the functions to fix builds with [[nodiscard]]

2019-12-19 Thread Hannah von Reth 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:5cd949cce9f8: Put Q_REQUIRED_RESULT in front of the 
functions to fix builds with [[nodiscard]] (authored by vonreth).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26103?vs=71839=71868

REVISION DETAIL
  https://phabricator.kde.org/D26103

AFFECTED FILES
  src/ioslaves/ftp/ftp.h

To: vonreth, sitter, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26116: Reduce timeout when trying to connect to an app dbus interface

2019-12-19 Thread Méven Car 
meven updated this revision to Diff 71867.
meven added a comment.


  Include kde dbus daemon case

REPOSITORY
  R271 KDBusAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26116?vs=71866=71867

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26116

AFFECTED FILES
  src/kdbusservice.cpp

To: meven, #frameworks, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26116: Reduce timeout when trying to connect to an app dbus interface

2019-12-19 Thread Méven Car 
meven created this revision.
meven added reviewers: Frameworks, davidedmundson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  Currently we have a 5 minutes timeout duration.
  I would say any application that does not respond in 5 seconds is buggy, or 
at least in a bad state.
  
  This timeout can hide bugs because this code will block the current thread.
  The user won't have any feedback before the timeout expires.
  
  Encountered this issue while testing krunner.

REPOSITORY
  R271 KDBusAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26116

AFFECTED FILES
  src/kdbusservice.cpp

To: meven, #frameworks, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

2019-12-19 Thread Méven Car 
meven updated this revision to Diff 71864.
meven marked 2 inline comments as done.
meven added a comment.


  Replace use of KIOCORE_ENABLE_DEPRECATED_SINCE by 
KIOCORE_BUILD_DEPRECATED_SINCE in cpp files

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25010?vs=71703=71864

BRANCH
  arcpatch-D25010_1

REVISION DETAIL
  https://phabricator.kde.org/D25010

AFFECTED FILES
  autotests/jobremotetest.cpp
  src/core/CMakeLists.txt
  src/core/copyjob.cpp
  src/core/deletejob.cpp
  src/core/directorysizejob.cpp
  src/core/global.h
  src/core/statjob.cpp
  src/core/statjob.h
  src/filewidgets/kdiroperator.cpp
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file.h
  src/ioslaves/file/file_unix.cpp
  src/widgets/krun.cpp
  src/widgets/paste.cpp
  tests/kioslavetest.cpp
  tests/listjobtest.cpp

To: meven, #frameworks, dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26113: Places: For mounted volume display mount points instead of description

2019-12-19 Thread Méven Car 
meven updated this revision to Diff 71861.
meven added a comment.


  Remove unrelated change

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26113?vs=71860=71861

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26113

AFFECTED FILES
  src/filewidgets/kfileplacesitem.cpp

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26113: Places: For mounted volume display mount points instead of description

2019-12-19 Thread Méven Car 
meven created this revision.
meven added reviewers: Frameworks, ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  BUG: 415281
  FIXED-IN: 5.66

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26113

AFFECTED FILES
  src/core/CMakeLists.txt
  src/filewidgets/kfileplacesitem.cpp

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26112: Clean up unnecessary code

2019-12-19 Thread Méven Car 
meven created this revision.
meven added reviewers: Frameworks, bruns.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  Following https://phabricator.kde.org/D26098#inline-147037
  
  GIT_SILENT

REPOSITORY
  R245 Solid

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26112

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabdevice.cpp

To: meven, #frameworks, bruns
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24568: Provide clang-format target with a KDE Frameworks style file

2019-12-19 Thread Friedrich W. H. Kossebau 
kossebau added a comment.


  This has been missing the link from an rst file  in docs/, so the 
documentation generation picks up the file. Fixed with 
c4890d5c03ed79f0c87da861b6608bbd46c2162c 


REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24568

To: cullmann, #frameworks, dfaure, broulik, davidedmundson
Cc: zzag, sitter, mwolff, ochurlaud, nalvarez, kossebau, aacid, davidedmundson, 
dhaumann, apol, ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.12 - Build # 85 - Still Unstable!

2019-12-19 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.12/85/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 19 Dec 2019 21:29:23 +
 Build duration:
5 min 1 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 20 test(s)Failed: projectroot.tests.ECMPoQmToolsTestFailed: projectroot.tests.GenerateSipBindingsName: projectroot.tests Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.tests.ECMAddTests Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.13 - Build # 50 - Still Unstable!

2019-12-19 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.13/50/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Thu, 19 Dec 2019 21:29:23 +
 Build duration:
3 min 31 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 20 test(s)Failed: projectroot.tests.ECMPoQmToolsTestFailed: projectroot.tests.GenerateSipBindingsName: projectroot.tests Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.tests.ECMAddTests Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.13 - Build # 49 - Still Unstable!

2019-12-19 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.13/49/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Thu, 19 Dec 2019 21:19:38 +
 Build duration:
4 min 11 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 20 test(s)Failed: projectroot.tests.ECMPoQmToolsTestFailed: projectroot.tests.GenerateSipBindingsName: projectroot.tests Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.tests.ECMAddTests Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.12 - Build # 84 - Still Unstable!

2019-12-19 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.12/84/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 19 Dec 2019 21:19:38 +
 Build duration:
4 min 10 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 20 test(s)Failed: projectroot.tests.ECMPoQmToolsTestFailed: projectroot.tests.GenerateSipBindingsName: projectroot.tests Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.tests.ECMAddTests Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

D23384: Adding support for mounting KIOFuse URLs for applications that don't use KIO

2019-12-19 Thread Nathaniel Graham 
ngraham added a comment.


  I don't have any credentials issues with the current state of the patch and 
my password-protected Samba share.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23384

To: feverfew, fvogt, davidedmundson, dfaure, ngraham
Cc: alexde, broulik, sitter, davidedmundson, kde-frameworks-devel, ngraham, 
LeGast00n, GB_2, michaelh, bruns

D25878: Use clearer relative dates

2019-12-19 Thread Noah Davis 
ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R244 KCoreAddons

BRANCH
  better-relative-dates (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25878

To: ngraham, davidedmundson, #vdg, #frameworks, ndavis
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26103: Put Q_REQUIRED_RESULT in front of the functions to fix builds with [[nodiscard]]

2019-12-19 Thread Volker Krause 
vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26103

To: vonreth, sitter, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26098: Display first / in mounted storage access description

2019-12-19 Thread Stefan Brüns 
bruns added inline comments.

INLINE COMMENTS

> fstabdevice.cpp:51
> +m_product = m_device.mid(m_device.indexOf(":/") + 1);
>  if (m_product.isEmpty()) {
>  m_product = QStringLiteral("/");

this can no longer happen then ...

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D26098

To: meven, #frameworks, bruns, ngraham, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 48 - Still Unstable!

2019-12-19 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/48/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 19 Dec 2019 17:24:22 +
 Build duration:
2 min 41 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

D26098: Display first / in mounted storage access description

2019-12-19 Thread Méven Car 
This revision was automatically updated to reflect the committed changes.
Closed by commit R245:ebf1d037a358: Display first / in mounted storage access 
description (authored by meven).

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26098?vs=71831=71850

REVISION DETAIL
  https://phabricator.kde.org/D26098

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabdevice.cpp

To: meven, #frameworks, bruns, ngraham, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26099: Port QRegExp to QRegularExpression

2019-12-19 Thread Ahmad Samir 
ahmadsamir planned changes to this revision.
ahmadsamir added a comment.


  I messed up exactMatch stuff, will have to rethink it.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D26099

To: ahmadsamir, #baloo, meven, bruns, astippich
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D26106: Port QRegExp to QRegularExpression

2019-12-19 Thread Ahmad Samir 
ahmadsamir created this revision.
ahmadsamir added a reviewer: drosca.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

TEST PLAN
  The code compiles and the unit tests pass.

REPOSITORY
  R269 BluezQt

BRANCH
  l-qregularexpression (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26106

AFFECTED FILES
  tools/bluezapi2qt/CppGenerator.cpp
  tools/bluezapi2qt/Interface.cpp
  tools/bluezapi2qt/Method.cpp
  tools/bluezapi2qt/Methods.cpp
  tools/bluezapi2qt/Properties.cpp

To: ahmadsamir, drosca
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

[ANNOUNCE] CMake 3.16.2 available for download

2019-12-19 Thread Robert Maynard 
We are pleased to announce that CMake 3.16.2 is now available for download.

Please use the latest release from our download page:
  https://cmake.org/download/

Thanks for your support!

-
Changes in 3.16.2 since 3.16.1:

Brad King (6):
  VS: Fix support for v142 toolset minor versions in VS 16.5+
  FindBLAS: Consider OpenBLAS with thread libraries only with C or CXX
  FindBoost: Add support for Boost 1.72
  Autogen: Revert processing of .hh files for compatibility
  FindLAPACK: Fix support for LAPACK symbols inside BLAS libraries
  CMake 3.16.2

Cristian Adam (1):
  PCH: Append pch header file to list of forced include files

Michael Dickens (1):
  Tests: Fix testCTestResourceSpec struct initialization for some compilers

D25877: [KColorschemeManager] Add option to reenable following global theme

2019-12-19 Thread Nathaniel Graham 
ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  systemthem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25877

To: davidre, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25878: Use clearer relative dates

2019-12-19 Thread Nathaniel Graham 
ngraham added a comment.


  Ping.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D25878

To: ngraham, davidedmundson, #vdg, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26098: Display first / in mounted storage access description

2019-12-19 Thread Nathaniel Graham 
ngraham accepted this revision.

REPOSITORY
  R245 Solid

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26098

To: meven, #frameworks, bruns, ngraham, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26103: Put Q_REQUIRED_RESULT in front of the functions to fix builds with [[nodiscard]]

2019-12-19 Thread Hannah von Reth 
vonreth added a reviewer: sitter.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26103

To: vonreth, sitter
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26103: Put Q_REQUIRED_RESULT in front of the functions to fix builds with [[nodiscard]]

2019-12-19 Thread Hannah von Reth 
vonreth created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vonreth requested review of this revision.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26103

AFFECTED FILES
  src/ioslaves/ftp/ftp.h

To: vonreth
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 157 - Fixed!

2019-12-19 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/157/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 19 Dec 2019 12:53:02 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 62 test(s), Skipped: 0 test(s), Total: 62 test(s)Name: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 230 - Still Unstable!

2019-12-19 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/230/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 19 Dec 2019 12:47:27 +
 Build duration:
9 min 55 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D25877: [KColorschemeManager] Add option to reenable following global theme

2019-12-19 Thread David Redondo 
davidre added a comment.


  Ping

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25877

To: davidre, #frameworks
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 47 - Still Unstable!

2019-12-19 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/47/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 19 Dec 2019 12:45:32 +
 Build duration:
1 min 34 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

D26101: Port away from Qt 5.14 deprecated QList methods

2019-12-19 Thread Alexey Min 
alexeymin added a comment.


  Partially looks similar to what I did in D26069 
 , although that's not framework

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D26101

To: ahmadsamir, #baloo, meven, bruns, astippich
Cc: alexeymin, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D26101: Port away from Qt 5.14 deprecated QList methods

2019-12-19 Thread Ahmad Samir 
ahmadsamir updated this revision to Diff 71837.
ahmadsamir added a task: T11553: Port KDE Frameworks away from deprecated 
methods in Qt.
ahmadsamir added a comment.


  Link to T11553 

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26101?vs=71835=71837

BRANCH
  l-qt14-deprecated (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26101

AFFECTED FILES
  src/file/fileindexerconfig.cpp
  src/lib/filemonitor.cpp

To: ahmadsamir, #baloo, meven, bruns, astippich
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D26102: QAtomicInteger::loadRelaxed() and storeRelaxed() are available since Qt 5.14

2019-12-19 Thread Ahmad Samir 
ahmadsamir created this revision.
ahmadsamir added reviewers: Baloo, meven, bruns, astippich.
Herald added projects: Frameworks, Baloo.
ahmadsamir requested review of this revision.

TEST PLAN
  make && ctest

REPOSITORY
  R293 Baloo

BRANCH
  l-qt14-deprecated-2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26102

AFFECTED FILES
  src/file/filecontentindexer.cpp
  src/file/filecontentindexer.h
  src/lib/queryrunnable.cpp

To: ahmadsamir, #baloo, meven, bruns, astippich
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D26101: Port away from Qt 5.14 deprecated QList methods

2019-12-19 Thread Ahmad Samir 
ahmadsamir updated this revision to Diff 71835.
ahmadsamir retitled this revision from "Port away from Qt 14.0 deprecated QList 
methods" to "Port away from Qt 5.14 deprecated QList methods".
ahmadsamir added a comment.


  Qt 14 hasn't been released yet (I kept thinking something looks wrong...)

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26101?vs=71834=71835

BRANCH
  l-qt14-deprecated (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26101

AFFECTED FILES
  src/file/fileindexerconfig.cpp
  src/lib/filemonitor.cpp

To: ahmadsamir, #baloo, meven, bruns, astippich
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D26101: Port away from Qt 14.0 deprecated QList methods

2019-12-19 Thread Ahmad Samir 
ahmadsamir created this revision.
ahmadsamir added reviewers: Baloo, meven, bruns, astippich.
Herald added projects: Frameworks, Baloo.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  Refactor FileIndexerConfig::excludeFilters() as it doesn't make sense
  to me to convert to a QStringList to a QSet then to QStringList, if
  there is a reason I couldn't fathom it.

TEST PLAN
  The code compiles and unit tests pass

REPOSITORY
  R293 Baloo

BRANCH
  l-qt14-deprecated (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26101

AFFECTED FILES
  src/file/fileindexerconfig.cpp
  src/lib/filemonitor.cpp

To: ahmadsamir, #baloo, meven, bruns, astippich
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D26099: Port QRegExp to QRegularExpression

2019-12-19 Thread Ahmad Samir 
ahmadsamir created this revision.
ahmadsamir added reviewers: Baloo, meven, bruns, astippich.
Herald added projects: Frameworks, Baloo.
ahmadsamir requested review of this revision.

TEST PLAN
  The code builds and unit tests pass.

REPOSITORY
  R293 Baloo

BRANCH
  l-qregexp (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26099

AFFECTED FILES
  src/kioslaves/timeline/timelinetools.cpp

To: ahmadsamir, #baloo, meven, bruns, astippich
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D26098: Display first / in mounted storage access description

2019-12-19 Thread Kai Uwe Broulik 
broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R245 Solid

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26098

To: meven, #frameworks, bruns, ngraham, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26085: KCModuleQml: Ensure defaulted is emitted with the current configModule->representsDefaults on load

2019-12-19 Thread Méven Car 
meven added a comment.


  We may want an alternative approach to fix this.
  But the end result we want is : ConfigModule should be able to update their 
representsDefault anytime without having to worry about the restore default 
button state.
  Currently it mostly works except when ConfigModule change its 
representsDefault state before their KCMModule is instanciated, in which case 
the first representDefaultChanged event are not relayed.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D26085

To: meven, crossi, mart, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns