Re: New repo in kdereview: KWeather
This happens on X11 when using QtDialogs for reasons I don't understand. See https://invent.kde.org/frameworks/knewstuff/-/commit/ea19fa6e824650f3257e8047d6f90e01899b2e03. Nate On 11/29/22 16:48, Devin wrote: Hmm, I have no idea why the behaviour is different for you, but I get: https://i.imgur.com/CvGD8HS.png If you removed the "Qt.Dialog" flag here: https://invent.kde.org/plasma-mobile/kweather/-/blob/master/src/qml/settings/SettingsWindow.qml#L14, does it still have the issue? Thanks, Devin On Tue, Nov 29, 2022 at 6:44 PM Albert Astals Cid wrote: El dimecres, 30 de novembre de 2022, a les 0:33:39 (CET), Devin va escriure: Ok, now that i updated kirigami-addons, the Settings dialog shows, but it's uncloseable, any idea why that would be? That's very strange, it should be showing up as a regular window, does pressing the close button on the window decoration not work? Which close button? https://i.imgur.com/2jX2yUS.png Cheers, Albert Thanks, Devin On Tue, Nov 29, 2022 at 6:23 PM Albert Astals Cid wrote: El dilluns, 28 de novembre de 2022, a les 17:15:57 (CET), Albert Astals Cid va> escriure: El divendres, 25 de novembre de 2022, a les 4:46:40 (CET), Devin va escriure: There's potentially overlapping text. I have fixed text wrapping in the weather delegates so it should wrap properly now. Here settingsModel.forecastStyle is not i18n'ed I have fixed it now (it converts to i18n'd dedicated strings in the QML) FWIW i can't open settings anymore qrc:/qml/settings/SettingsWindow.qml:56:13: Type SettingsComponent unavailable qrc:/qml/settings/SettingsComponent.qml:61:17: Cannot assign to non-existent property "onActivated" qrc:/qml/main.qml:136: TypeError: Cannot call method 'close' of null Ok, now that i updated kirigami-addons, the Settings dialog shows, but it's uncloseable, any idea why that would be? Cheers, Albert Cheers, Albert On Mon, Nov 14, 2022 at 5:10 PM Albert Astals Cid wrote: El dimecres, 9 de novembre de 2022, a les 23:00:13 (CET), Devin va escriure: Hi everyone, I would like to put kweather through kdereview: https://invent.kde.org/plasma-mobile/kweather KWeather is an application that can give simple weather information for different weather locations. Please note that KWeatherCore (the library the app depends on) has already passed kdereview. There's potentially overlapping text. See https://i.imgur.com/BrOgi3A.png The settings show untranslateable text, i.e. MobileForm.FormComboBoxDelegate { id: forecastStyleDropdown text: i18n("Forecast Style") currentValue: settingsModel.forecastStyle Here settingsModel.forecastStyle is not i18n'ed Not KWeather's fault but i just realized that Kirigami's about page doesn't properly credit translators :/ Cheers, Albert Thanks, Devin
Re: New repo in kdereview: KWeather
Hmm, I have no idea why the behaviour is different for you, but I get: https://i.imgur.com/CvGD8HS.png If you removed the "Qt.Dialog" flag here: https://invent.kde.org/plasma-mobile/kweather/-/blob/master/src/qml/settings/SettingsWindow.qml#L14, does it still have the issue? Thanks, Devin On Tue, Nov 29, 2022 at 6:44 PM Albert Astals Cid wrote: > > El dimecres, 30 de novembre de 2022, a les 0:33:39 (CET), Devin va escriure: > > > Ok, now that i updated kirigami-addons, the Settings dialog shows, but > > > it's uncloseable, any idea why that would be? > > That's very strange, it should be showing up as a regular window, does > > pressing the close button on the window decoration not work? > > Which close button? > > https://i.imgur.com/2jX2yUS.png > > Cheers, > Albert > > > > > Thanks, > > Devin > > > > On Tue, Nov 29, 2022 at 6:23 PM Albert Astals Cid wrote: > > > El dilluns, 28 de novembre de 2022, a les 17:15:57 (CET), Albert Astals > > > Cid va> > > > escriure: > > > > El divendres, 25 de novembre de 2022, a les 4:46:40 (CET), Devin va > > > > > > escriure: > > > > > > There's potentially overlapping text. > > > > > > > > > > I have fixed text wrapping in the weather delegates so it should wrap > > > > > properly now. > > > > > > > > > > > Here settingsModel.forecastStyle is not i18n'ed > > > > > > > > > > I have fixed it now (it converts to i18n'd dedicated strings in the > > > > > QML) > > > > > > > > FWIW i can't open settings anymore > > > > > > > > qrc:/qml/settings/SettingsWindow.qml:56:13: Type SettingsComponent > > > > unavailable qrc:/qml/settings/SettingsComponent.qml:61:17: Cannot assign > > > > to > > > > non-existent property "onActivated" qrc:/qml/main.qml:136: TypeError: > > > > Cannot call method 'close' of null > > > > > > Ok, now that i updated kirigami-addons, the Settings dialog shows, but > > > it's > > > uncloseable, any idea why that would be? > > > > > > Cheers, > > > > > > Albert > > > > > > > Cheers, > > > > > > > > Albert > > > > > > > > > On Mon, Nov 14, 2022 at 5:10 PM Albert Astals Cid > wrote: > > > > > > El dimecres, 9 de novembre de 2022, a les 23:00:13 (CET), Devin va > > > > > > escriure: > > > > > > > Hi everyone, > > > > > > > > > > > > > > I would like to put kweather through kdereview: > > > > > > > > > > > > > > https://invent.kde.org/plasma-mobile/kweather > > > > > > > > > > > > > > KWeather is an application that can give simple weather > > > > > > > information > > > > > > > for different weather locations. Please note that KWeatherCore > > > > > > > (the > > > > > > > library the app depends on) has already passed kdereview. > > > > > > > > > > > > There's potentially overlapping text. > > > > > > > > > > > > See https://i.imgur.com/BrOgi3A.png > > > > > > > > > > > > The settings show untranslateable text, i.e. > > > > > > > > > > > > MobileForm.FormComboBoxDelegate { > > > > > > > > > > > > id: forecastStyleDropdown > > > > > > text: i18n("Forecast Style") > > > > > > currentValue: settingsModel.forecastStyle > > > > > > > > > > > > Here settingsModel.forecastStyle is not i18n'ed > > > > > > > > > > > > Not KWeather's fault but i just realized that Kirigami's about page > > > > > > doesn't > > > > > > properly credit translators :/ > > > > > > > > > > > > Cheers, > > > > > > > > > > > > Albert > > > > > > > > > > > > > Thanks, > > > > > > > Devin > > > >
Re: New repo in kdereview: KWeather
El dimecres, 30 de novembre de 2022, a les 0:33:39 (CET), Devin va escriure: > > Ok, now that i updated kirigami-addons, the Settings dialog shows, but > > it's uncloseable, any idea why that would be? > That's very strange, it should be showing up as a regular window, does > pressing the close button on the window decoration not work? Which close button? https://i.imgur.com/2jX2yUS.png Cheers, Albert > > Thanks, > Devin > > On Tue, Nov 29, 2022 at 6:23 PM Albert Astals Cid wrote: > > El dilluns, 28 de novembre de 2022, a les 17:15:57 (CET), Albert Astals > > Cid va> > > escriure: > > > El divendres, 25 de novembre de 2022, a les 4:46:40 (CET), Devin va > > > > escriure: > > > > > There's potentially overlapping text. > > > > > > > > I have fixed text wrapping in the weather delegates so it should wrap > > > > properly now. > > > > > > > > > Here settingsModel.forecastStyle is not i18n'ed > > > > > > > > I have fixed it now (it converts to i18n'd dedicated strings in the > > > > QML) > > > > > > FWIW i can't open settings anymore > > > > > > qrc:/qml/settings/SettingsWindow.qml:56:13: Type SettingsComponent > > > unavailable qrc:/qml/settings/SettingsComponent.qml:61:17: Cannot assign > > > to > > > non-existent property "onActivated" qrc:/qml/main.qml:136: TypeError: > > > Cannot call method 'close' of null > > > > Ok, now that i updated kirigami-addons, the Settings dialog shows, but > > it's > > uncloseable, any idea why that would be? > > > > Cheers, > > > > Albert > > > > > Cheers, > > > > > > Albert > > > > > > > On Mon, Nov 14, 2022 at 5:10 PM Albert Astals Cid wrote: > > > > > El dimecres, 9 de novembre de 2022, a les 23:00:13 (CET), Devin va > > > > escriure: > > > > > > Hi everyone, > > > > > > > > > > > > I would like to put kweather through kdereview: > > > > > > > > > > > > https://invent.kde.org/plasma-mobile/kweather > > > > > > > > > > > > KWeather is an application that can give simple weather > > > > > > information > > > > > > for different weather locations. Please note that KWeatherCore > > > > > > (the > > > > > > library the app depends on) has already passed kdereview. > > > > > > > > > > There's potentially overlapping text. > > > > > > > > > > See https://i.imgur.com/BrOgi3A.png > > > > > > > > > > The settings show untranslateable text, i.e. > > > > > > > > > > MobileForm.FormComboBoxDelegate { > > > > > > > > > > id: forecastStyleDropdown > > > > > text: i18n("Forecast Style") > > > > > currentValue: settingsModel.forecastStyle > > > > > > > > > > Here settingsModel.forecastStyle is not i18n'ed > > > > > > > > > > Not KWeather's fault but i just realized that Kirigami's about page > > > > > doesn't > > > > > properly credit translators :/ > > > > > > > > > > Cheers, > > > > > > > > > > Albert > > > > > > > > > > > Thanks, > > > > > > Devin
Re: New repo in kdereview: KWeather
> Ok, now that i updated kirigami-addons, the Settings dialog shows, but it's > uncloseable, any idea why that would be? That's very strange, it should be showing up as a regular window, does pressing the close button on the window decoration not work? Thanks, Devin On Tue, Nov 29, 2022 at 6:23 PM Albert Astals Cid wrote: > > El dilluns, 28 de novembre de 2022, a les 17:15:57 (CET), Albert Astals Cid va > escriure: > > El divendres, 25 de novembre de 2022, a les 4:46:40 (CET), Devin va > escriure: > > > > There's potentially overlapping text. > > > > > > I have fixed text wrapping in the weather delegates so it should wrap > > > properly now. > > > > > > > Here settingsModel.forecastStyle is not i18n'ed > > > > > > I have fixed it now (it converts to i18n'd dedicated strings in the QML) > > > > FWIW i can't open settings anymore > > > > qrc:/qml/settings/SettingsWindow.qml:56:13: Type SettingsComponent > > unavailable qrc:/qml/settings/SettingsComponent.qml:61:17: Cannot assign to > > non-existent property "onActivated" qrc:/qml/main.qml:136: TypeError: > > Cannot call method 'close' of null > > Ok, now that i updated kirigami-addons, the Settings dialog shows, but it's > uncloseable, any idea why that would be? > > Cheers, > Albert > > > > > Cheers, > > Albert > > > > > On Mon, Nov 14, 2022 at 5:10 PM Albert Astals Cid wrote: > > > > El dimecres, 9 de novembre de 2022, a les 23:00:13 (CET), Devin va > escriure: > > > > > Hi everyone, > > > > > > > > > > I would like to put kweather through kdereview: > > > > > > > > > > https://invent.kde.org/plasma-mobile/kweather > > > > > > > > > > KWeather is an application that can give simple weather information > > > > > for different weather locations. Please note that KWeatherCore (the > > > > > library the app depends on) has already passed kdereview. > > > > > > > > There's potentially overlapping text. > > > > > > > > See https://i.imgur.com/BrOgi3A.png > > > > > > > > The settings show untranslateable text, i.e. > > > > > > > > MobileForm.FormComboBoxDelegate { > > > > > > > > id: forecastStyleDropdown > > > > text: i18n("Forecast Style") > > > > currentValue: settingsModel.forecastStyle > > > > > > > > Here settingsModel.forecastStyle is not i18n'ed > > > > > > > > Not KWeather's fault but i just realized that Kirigami's about page > > > > doesn't > > > > properly credit translators :/ > > > > > > > > Cheers, > > > > > > > > Albert > > > > > > > > > Thanks, > > > > > Devin > > > >
Re: New repo in kdereview: KWeather
El dilluns, 28 de novembre de 2022, a les 17:15:57 (CET), Albert Astals Cid va escriure: > El divendres, 25 de novembre de 2022, a les 4:46:40 (CET), Devin va escriure: > > > There's potentially overlapping text. > > > > I have fixed text wrapping in the weather delegates so it should wrap > > properly now. > > > > > Here settingsModel.forecastStyle is not i18n'ed > > > > I have fixed it now (it converts to i18n'd dedicated strings in the QML) > > FWIW i can't open settings anymore > > qrc:/qml/settings/SettingsWindow.qml:56:13: Type SettingsComponent > unavailable qrc:/qml/settings/SettingsComponent.qml:61:17: Cannot assign to > non-existent property "onActivated" qrc:/qml/main.qml:136: TypeError: > Cannot call method 'close' of null Ok, now that i updated kirigami-addons, the Settings dialog shows, but it's uncloseable, any idea why that would be? Cheers, Albert > > Cheers, > Albert > > > On Mon, Nov 14, 2022 at 5:10 PM Albert Astals Cid wrote: > > > El dimecres, 9 de novembre de 2022, a les 23:00:13 (CET), Devin va escriure: > > > > Hi everyone, > > > > > > > > I would like to put kweather through kdereview: > > > > > > > > https://invent.kde.org/plasma-mobile/kweather > > > > > > > > KWeather is an application that can give simple weather information > > > > for different weather locations. Please note that KWeatherCore (the > > > > library the app depends on) has already passed kdereview. > > > > > > There's potentially overlapping text. > > > > > > See https://i.imgur.com/BrOgi3A.png > > > > > > The settings show untranslateable text, i.e. > > > > > > MobileForm.FormComboBoxDelegate { > > > > > > id: forecastStyleDropdown > > > text: i18n("Forecast Style") > > > currentValue: settingsModel.forecastStyle > > > > > > Here settingsModel.forecastStyle is not i18n'ed > > > > > > Not KWeather's fault but i just realized that Kirigami's about page > > > doesn't > > > properly credit translators :/ > > > > > > Cheers, > > > > > > Albert > > > > > > > Thanks, > > > > Devin
Re: Season of KDE 2023 Ideas page skeleton is live
Hi, a kind reminder. For now, there are 2 projects to improve the accessibility of QML apps and websites. Remember that the SoK is not only about code, but can also be about documentation or other relevant stuff for KDE. If there are no more ideas (GCompris and Krita won't be participating for sure from feedback), I'm not sure it's worth doing a SoK for 2 projects but we can still try to promote the projects to get new contributors to work on them. Cheers, Johnny Le sam. 12 nov. 2022 à 19:50, Johnny Jazeix a écrit : > Hi, > The timeline for this year SoK is not yet decided but > https://community.kde.org/SoK/Ideas/2023 is created for mentors to add > their ideas. > > If you are adding an idea, please remember to put your own contact > information in the description as the mentor. Do not add ideas with no > mentor and contact info. > > Remember that SoK is more general than GSoC, so these ideas are not > limited only to coding tasks and you can include projects related to > documentation, artwork, translation, reports and other types of work as > well as code. > > Cheers, > > Johnny > > ps: if anyone is willing to help for administer the event (preparing blog > post, reminding people to do things...), please raise your hand, you are > welcome! > >
Re: Season of KDE 2023 Ideas page skeleton is live
Hi, a kind reminder. For now, there are 2 projects to improve the accessibility of QML apps and websites. Remember that the SoK is not only about code, but can also be about documentation or other relevant stuff for KDE. If there are no more ideas (GCompris and Krita won't be participating for sure from feedback), I'm not sure it's worth doing a SoK for 2 projects but we can still try to promote the projects to get new contributors to work on them. Cheers, Johnny Le sam. 12 nov. 2022 à 19:50, Johnny Jazeix a écrit : > Hi, > The timeline for this year SoK is not yet decided but > https://community.kde.org/SoK/Ideas/2023 is created for mentors to add > their ideas. > > If you are adding an idea, please remember to put your own contact > information in the description as the mentor. Do not add ideas with no > mentor and contact info. > > Remember that SoK is more general than GSoC, so these ideas are not > limited only to coding tasks and you can include projects related to > documentation, artwork, translation, reports and other types of work as > well as code. > > Cheers, > > Johnny > > ps: if anyone is willing to help for administer the event (preparing blog > post, reminding people to do things...), please raise your hand, you are > welcome! > >
Re: Docker CI Image Change Freeze
Hi all, As an update to this, sufficient changes have been made within Craft that it is now possible to build Qt 5 images so i'm releasing the freeze for those images. Qt 6 remains broken, and therefore remains frozen at this time (see https://invent.kde.org/sysadmin/ci-images/-/jobs/619808) As mentioned previously, I believe this to be a CMake bug given the lack of change in Ninja. At this stage I would suggest investigation be focused on either upgrading to a newer version of Ninja that can handle the newer version of CMake, or downgrading CMake back to an older version that is compatible with Ninja being built without re2c being available. Qt 6 CI will be globally disabled in 2 weeks time if this remains unfixed, as dependencies move quickly and I'm not in favour of retaining parts of the CI system which cannot be rebuilt. Regards, Ben On Sat, Nov 19, 2022 at 7:55 AM Ben Cooksley wrote: > Hi all, > > Recently Sysadmin received a series of requests to rebuild the Docker > images used to support KDE CI services on invent.kde.org. > > Unfortunately one of these rebuilds has exposed a bug of unknown origin > (as it fails on our side but by all accounts works elsewhere) where Craft > is unable to compile Ninja (with the compilation dying due to a Makefile > syntax error that looks like a CMake bug). > > The failure log can be found at > https://invent.kde.org/sysadmin/ci-images/-/jobs/601722 > > Subsequent to this we have also received a request to rebuild our Linux > images to allow for Grantlee 5.3 to be used. > > Given how development is conducted within some projects that make heavy > use of Grantlee, and how some of that technology is used across multiple > platforms it would be harmful to the wider CI system and KDE Community to > allow for Grantlee 5.3 to become available on any of our platforms. > > I'm therefore imposing a change freeze on all KDE CI Docker images until > the issue with Craft/Ninja/CMake is resolved. > > Should any project have prematurely adopted a mandatory dependency on > Grantlee 5.3 then as they have failed to follow the correct change process > as documented on our wikis that change is deemed to be outside policy and > should be reverted immediately. > > Regards, > Ben Cooksley > KDE Sysadmin >
Re: Docker CI Image Change Freeze
Hi all, As an update to this, sufficient changes have been made within Craft that it is now possible to build Qt 5 images so i'm releasing the freeze for those images. Qt 6 remains broken, and therefore remains frozen at this time (see https://invent.kde.org/sysadmin/ci-images/-/jobs/619808) As mentioned previously, I believe this to be a CMake bug given the lack of change in Ninja. At this stage I would suggest investigation be focused on either upgrading to a newer version of Ninja that can handle the newer version of CMake, or downgrading CMake back to an older version that is compatible with Ninja being built without re2c being available. Qt 6 CI will be globally disabled in 2 weeks time if this remains unfixed, as dependencies move quickly and I'm not in favour of retaining parts of the CI system which cannot be rebuilt. Regards, Ben On Sat, Nov 19, 2022 at 7:55 AM Ben Cooksley wrote: > Hi all, > > Recently Sysadmin received a series of requests to rebuild the Docker > images used to support KDE CI services on invent.kde.org. > > Unfortunately one of these rebuilds has exposed a bug of unknown origin > (as it fails on our side but by all accounts works elsewhere) where Craft > is unable to compile Ninja (with the compilation dying due to a Makefile > syntax error that looks like a CMake bug). > > The failure log can be found at > https://invent.kde.org/sysadmin/ci-images/-/jobs/601722 > > Subsequent to this we have also received a request to rebuild our Linux > images to allow for Grantlee 5.3 to be used. > > Given how development is conducted within some projects that make heavy > use of Grantlee, and how some of that technology is used across multiple > platforms it would be harmful to the wider CI system and KDE Community to > allow for Grantlee 5.3 to become available on any of our platforms. > > I'm therefore imposing a change freeze on all KDE CI Docker images until > the issue with Craft/Ninja/CMake is resolved. > > Should any project have prematurely adopted a mandatory dependency on > Grantlee 5.3 then as they have failed to follow the correct change process > as documented on our wikis that change is deemed to be outside policy and > should be reverted immediately. > > Regards, > Ben Cooksley > KDE Sysadmin >