D20169: Add profile support interface for TerminalInterface
mschiller added a comment. Oh sry, I wasn't aware of that. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D20169 To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein Cc: dhaumann, pino, michaelh, ngraham, bruns
D20169: Add profile support interface for TerminalInterface
mschiller added a comment. ping REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D20169 To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein Cc: dhaumann, pino, michaelh, ngraham, bruns
D20169: Add profile support interface for TerminalInterface
mschiller updated this revision to Diff 58095. mschiller added a comment. - Remove install of profileinterface REPOSITORY R306 KParts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20169?vs=58094=58095 BRANCH terminal-interface-profiles (branched from master) REVISION DETAIL https://phabricator.kde.org/D20169 AFFECTED FILES src/kde_terminal_interface.h To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein Cc: dhaumann, pino, michaelh, ngraham, bruns
D20169: Add profile support interface for TerminalInterface
mschiller updated this revision to Diff 58094. mschiller added a comment. Move the interface to TerminalInterfaceV2 REPOSITORY R306 KParts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20169?vs=56697=58094 BRANCH terminal-interface-profiles (branched from master) REVISION DETAIL https://phabricator.kde.org/D20169 AFFECTED FILES src/CMakeLists.txt src/kde_terminal_interface.h To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein Cc: dhaumann, pino, michaelh, ngraham, bruns
D20169: Add profile support interface for TerminalInterface
mschiller added a comment. Ping REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D20169 To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein Cc: dhaumann, pino, michaelh, ngraham, bruns
D20169: Add profile support interface for TerminalInterface
mschiller updated this revision to Diff 56697. mschiller added a comment. change KDEPARTS to KPARTS REPOSITORY R306 KParts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20169?vs=56696=56697 BRANCH terminal-interface-profiles (branched from master) REVISION DETAIL https://phabricator.kde.org/D20169 AFFECTED FILES src/CMakeLists.txt src/terminalprofileinterface.h To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein Cc: dhaumann, pino, michaelh, ngraham, bruns
D20169: Add profile support interface for TerminalInterface
mschiller marked 3 inline comments as done. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D20169 To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein Cc: dhaumann, pino, michaelh, ngraham, bruns
D20169: Add profile support interface for TerminalInterface
mschiller updated this revision to Diff 56696. mschiller added a comment. Remove getProfilePath and remove get prefixes REPOSITORY R306 KParts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20169?vs=56672=56696 BRANCH terminal-interface-profiles (branched from master) REVISION DETAIL https://phabricator.kde.org/D20169 AFFECTED FILES src/CMakeLists.txt src/terminalprofileinterface.h To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein Cc: dhaumann, pino, michaelh, ngraham, bruns
D20169: Add profile support interface for TerminalInterface
mschiller added a comment. > wrt getProfilePath: what if an application does not store a profile as single filename, for example as directory, or even stored e.g. in a DB? maybe it would be better to have this as property of a profile Yeah Konsole Profiles seem to already have a path property in the profile implementation. So gonna remove this. > is a setProfileProperty worth having? I don't think it would be good to have the user applications mess with the users customizations. In case the profile is somehow "incompatible" with the client application, exposing some profile management functions (e.g. copy and modify) might be useful but I can't think of an actual reason which would require that. > is an API to list the available properties worth having? Just to check at runtime if getting a property was successful returning an empty QVariant should be enough, because you need to look up the available properties to check the returned type anyway. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D20169 To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein Cc: pino, michaelh, ngraham, bruns
D20169: Add profile support interface for TerminalInterface
mschiller updated this revision to Diff 56672. mschiller edited the summary of this revision. mschiller added a comment. Move the profile support to different class REPOSITORY R306 KParts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20169?vs=55201=56672 BRANCH terminal-interface-profiles (branched from master) REVISION DETAIL https://phabricator.kde.org/D20169 AFFECTED FILES src/terminalprofileinterface.h To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein Cc: pino, michaelh, ngraham, bruns
D20169: Add profile support interface for TerminalInterface
mschiller edited the summary of this revision. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D20169 To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein Cc: michaelh, ngraham, bruns
D20169: Add profile support interface for TerminalInterface
mschiller added a reviewer: hindenburg. mschiller removed a subscriber: kde-frameworks-devel. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D20169 To: mschiller, hindenburg Cc: michaelh, ngraham, bruns, kde-frameworks-devel
D20169: Add profile support interface for TerminalInterface
mschiller created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mschiller requested review of this revision. REVISION SUMMARY This enables handling profiles for the active konsolepart and has to be implemented by konsole. REPOSITORY R306 KParts BRANCH terminal-interface-profiles (branched from master) REVISION DETAIL https://phabricator.kde.org/D20169 AFFECTED FILES src/kde_terminal_interface.h To: mschiller Cc: kde-frameworks-devel, michaelh, ngraham, bruns
