Re: Gitlab Evaluation & Migration

[Michail Vourlakos]

Concerning Latte Dock, there is no objection in migrating to Gitlab.
I like it a lot as it reminds me GitHub and it will probably welcome also
new contributors (not only developers but also enthusiast users).

regards,
michail


Στις Σάβ, 23 Φεβ 2019 στις 11:44 π.μ., ο/η Ben Cooksley 
έγραψε:

> Hi all,
>
> Over the past few months a small group of KDE projects have been
> evaluating Gitlab as a replacement for Phabricator, and we’ve now
> reached the point where we’re ready to have a community wide
> discussion regarding whether we’d like to migrate to Gitlab. We'd like
> to start this by thanking those projects that have assisted in
> evaluating Gitlab for KDE, at list of which can be found at
> https://invent.kde.org/kde/
>
> This evaluation process was started in response to feedback Sysadmin
> received in the BoF session in Akademy last year regarding issues
> developers we're having with Phabricator. These included the ability
> to see the submitters details (name and email address), ability to do
> multi-commit reviews and to merge changes conveniently from the web
> amongst other things.
>
> Based on the feedback we’ve received to date regarding the Gitlab
> evaluation, the consensus seems to be that a migration would be
> beneficial and helpful to us in the long term.
>
> Among the benefits identified thus far are:
> 1) Provision of full featured task management and code review
> functionality to scratch (personal) repositories, which will ease the
> transition to playground and first release.
> 2) Ability to handle native Git commits as part of the code review
> process and merge commits from the web interface rather than having to
> take additional steps to integrate a change.
> 3) Easier and more logical grouping of projects, including being able
> to view the tasks and repositories related to a specific project more
> intuitively
>
> Further notes on the evaluation can be found at
> https://notes.kde.org/p/gitlab-evaluation-notes
>
> In regards to Phabricator it should be noted that upstream does not
> currently have plans to work on features which would resolve the
> issues we've encountered, and their responsiveness to inquiries from
> us has decreased since we migrated to it several years ago. Gitlab on
> the other hand has a thriving community which openly accepts patches
> and have been very helpful in assisting us with the evaluation process
> (including solving problems we've found).
>
> In addition to sysadmins and some of projects maintainers, KDE e.V.
> board, and onboarding goal team has been involved in Gitlab evaluation
> process as well, and they've made the following comments:
>
> Neofytos Kolokotronis of the Onboarding goal team:
> We believe this switch will be a great step forward for the Onboarding
> goal as well. The workflow, features and general behavior of Gitlab
> should be much more familiar to developers and non-coders interested
> to contribute to KDE, thus lowering the entry barrier.  Further,
> people coming from FOSS projects already on Github or Gitlab should
> find it very straightforward to start contributing to KDE right away.
> One area that is not to be ignored is that Gitlab has some great and
> up to date documentation.
>
> Eike Hein on behalf of the KDE e.V. board of directors:
> After sysadmin gave us a situation report on our code hosting and
> review infrastructure last year, we were initially involved with
> building a relationship with GitLab upstream and setting up a call
> schedule. We then turned the evaluation over to the sysadmin and
> onboarding teams and received continual updates on its progress. We're
> impressed by and thankful for the work done by everyone involved in
> the intervening months, and stand by to help implement a community
> decision based on what was collected.
>
> Based on all of the above we'd like to propose migrating towards
> Gitlab. Comments?
>
> Thanks,
> Ben Cooksley
> KDE Sysadmin
>

D15814: show all borders for pop up windows in a dock

[Michail Vourlakos]

mvourlakos added a comment.


  In D15814#343330 , @davidedmundson 
wrote:
  
  > >   first introduced at popupPlacement()
  >
  > ...by you :P
  
  
  I know :( and this broke plasma popups placement in !compositing mode.
  This is why I sent https://phabricator.kde.org/D15821
  which uses mask() in a more meaningful way both for plasma and Latte. 
  mask() in D15821  isnt used to 
distinguish plasma/docks but to place
  popups more intellengently. But in D15821 
 I need a window flag in order 
  to identify which popups can be placed according to the element trigerred 
them.
  I used Qt::Tooltip for this in D15821  
but I dont like it, I would prefer something
  which is not used that often.
  
  > Extra confusingly the comment above that line is from before the mask test 
was added, and in that comment dock means panel. 
  >  So the comment about when we're a dock explicitly excludes what you call a 
dock.  :/
  > 
  > I would have pushed for doing it explicitly. Ideally when 
outsideParentWindow was first introduced.
  
  sorry, I dont understand what explicitly means
  
  > Given we're using this mask test already, I don't like it, but if no-one 
else objects, ship it.
  >  (please also clarify comments here and line 906 to distinguish dock and 
dock)
  
  maybe is better to look first at D15821  
and decide afterwards if this should be commited now or when dialog2 arrives
  
  > Note, when Dialog gets a rewrite, we won't do it like that. I want a hint 
at the containment level that we can forward through CompactApplet.qml
  
  no problem for me, we can wait for this...

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  dockBorders

REVISION DETAIL
  https://phabricator.kde.org/D15814

To: mvourlakos, #plasma, broulik, davidedmundson
Cc: abetts, broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D15839: extend PlasmaCore.ColorScope for custom colors

[Michail Vourlakos]

mvourlakos edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15839

To: mvourlakos, #plasma, davidedmundson, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15839: extend PlasmaCore.ColorScope for custom colors

[Michail Vourlakos]

mvourlakos edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15839

To: mvourlakos, #plasma, davidedmundson, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15839: extend PlasmaCore.ColorScope for custom colors

[Michail Vourlakos]

mvourlakos added a comment.


  F6294480: εικόνα.png 
  [plasma taskmanager that is using red as textColor even though Breeze-Dark 
theme is chosen]

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15839

To: mvourlakos, #plasma, davidedmundson, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15839: extend PlasmaCore.ColorScope for custom colors

[Michail Vourlakos]

mvourlakos created this revision.
mvourlakos added reviewers: Plasma, davidedmundson, mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mvourlakos requested review of this revision.

REVISION SUMMARY
  --In the future dynamic coloring might be needed for
  panels in the desktop. In such case panel colors might
  be altered in order to follow the current active maximized
  window colors or another case could be when the panel
  is transparent and plasma theme colors arent providing
  the best constrast with the underlying background.
  This is a first step in order to support panels that color
  themselves independently from the plasma theme or according
  to the plasma theme but with best contrast at all cases.
  
  Usage Example:
  
  //Containment part
  PlasmaCore.ColorScope{
  
colorGroup: PlasmaCore.Theme.UserSetColorGroup
textColor: "#f1f1f1"

/*applets*/
  
  }
  
  //applet part
  
color: PlasmaCore.ColorScope.textColor //it is going to use #f1f1f1

TEST PLAN
  -check that applets are coloring themselves accordingly
  -check that previous behavior didnt break

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  extendColorScope

REVISION DETAIL
  https://phabricator.kde.org/D15839

AFFECTED FILES
  src/declarativeimports/core/colorscope.cpp
  src/declarativeimports/core/colorscope.h
  src/plasma/theme.h

To: mvourlakos, #plasma, davidedmundson, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15821: fix pop up positioning for !compositing mode

[Michail Vourlakos]

mvourlakos added inline comments.

INLINE COMMENTS

> dialog.cpp:910
>  const bool outsideParentWindow = ((winInfo.windowType(NET::AllTypesMask) 
> == NET::Dock) || (item->window()->flags() & Qt::X11BypassWindowManagerHint))
> -&& item->window()->mask().isNull();
> +&& !flags().testFlag(Qt::ToolTip);
>  

This positions the plasma taskmanager previews a bit out of place because 
plasma panels are enforcing 2px margin at their edges.

What type of window do you believe should be an exception in order for the 
popup to be placed according to the item that triggered it?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15821

To: mvourlakos, #plasma, broulik, davidedmundson
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D15821: fix pop up positioning for !compositing mode

[Michail Vourlakos]

mvourlakos updated this revision to Diff 42536.
mvourlakos added a comment.


  - dont use mask() to identify popups placement

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15821?vs=42510=42536

BRANCH
  maskPositioning

REVISION DETAIL
  https://phabricator.kde.org/D15821

AFFECTED FILES
  src/plasmaquick/dialog.cpp

To: mvourlakos, #plasma, broulik, davidedmundson
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D15814: show all borders for pop up windows in a dock

[Michail Vourlakos]

mvourlakos added inline comments.

INLINE COMMENTS

> davidedmundson wrote in dialog.cpp:209
> How does parentWindow->mask relate to being a dock or not?
> 
> Also we need to be a bit careful on names.
> _NET_WM_WINDOW_TYPE_DOCK is all panels, including the standard plasma one.

The idea was first introduced at popupPlacement() in dialog.cpp. 
In order to distinguish docks from panels.

It is based on the assumption that by design plasma panels do not use mask() 
because their shadows are drawn external from the window and most of the docks 
(e.g. Plank,Latte) are using masking for almost all of their operations.

Do you believe there is a better way to distinguish between docks and panels ?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15814

To: mvourlakos, #plasma, broulik, davidedmundson
Cc: abetts, broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D15814: show all borders for pop up windows in a dock

[Michail Vourlakos]

mvourlakos added a comment.


  @ngraham @abetts I searched a bit the "downward-pointing triangle" case but I 
dont think it can be drawn based on the current plasma theme implementation. 
Plasma themes are svg(s) so the borders images can also have borders so it isnt 
just drawing a triangle based on the theme background color.
  
  I believe it would be better if the relevant discussion could be taken place 
at another place, in order to keep this review clean for feedback.
  
  This commit improves the situation for Latte a lot until something better is 
supported.
  The arrow case will also need full borders in order to be drawn correctly so 
this commit still has meaning.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15814

To: mvourlakos, #plasma, broulik, davidedmundson
Cc: abetts, broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D15821: fix pop up positioning for !compositing mode

[Michail Vourlakos]

mvourlakos added a reviewer: davidedmundson.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15821

To: mvourlakos, #plasma, broulik, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15814: show all borders for pop up windows in a dock

[Michail Vourlakos]

mvourlakos added reviewers: broulik, davidedmundson.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15814

To: mvourlakos, #plasma, broulik, davidedmundson
Cc: abetts, broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D15821: fix pop up positioning for !compositing mode

[Michail Vourlakos]

mvourlakos added a comment.


  F6292209: εικόνα.png 
  [BEFORE: popup placement in plasma panel in !compositing]
  
  F6292214: εικόνα.png 
  [AFTER: popup placement in plasma panel in !compositing]

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15821

To: mvourlakos, #plasma, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15821: fix pop up positioning for !compositing mode

[Michail Vourlakos]

mvourlakos created this revision.
mvourlakos added reviewers: Plasma, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mvourlakos requested review of this revision.

REVISION SUMMARY
  --pop up positioning that was introduced in order to a dock
  pop up to not be placed far for the item triggering the pop up
  broke the plasma panel pop-ups placement in !compositing mode
  because plasma panels are also setting a mask in !compositing
  mode. This fix tries to fix the situation for plasma panels
  and also keep the functionality needed by docks.
  --The tooltips exception for !compositing mode is added because
  docks might also want to place their tooltips not according to
  window geometry or mask but according to their inner elements.

TEST PLAN
  test plasma panels in compositing and !compositing in order to
  confirm functionality
  test Latte dock in order to confirm that popups are still placed
  correctly
  test Latte dock tooltips in !compositing mode in order to confirm
  that can be placed inside the window or mask boundaries

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  maskPositioning

REVISION DETAIL
  https://phabricator.kde.org/D15821

AFFECTED FILES
  src/plasmaquick/dialog.cpp

To: mvourlakos, #plasma, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15814: show all borders for pop up windows in a dock

[Michail Vourlakos]

mvourlakos added a comment.


  In D15814#10 , @ngraham wrote:
  
  > A big improvement! Even better would be a little downward-pointing triangle 
pointing to the thing that spawned it. Here's a visual example from macOS with 
a vertical Dock: F6291932: macOS.png 
  
  
  I am not sure.
  Latte is trying to be as much plasma as possible and a "downward-pointing 
triangle" isnt shown any where else in plasma.
  So that would make Latte to look a bit out of place in Plasma.
  I think for now a small improvement would be enough.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15814

To: mvourlakos, #plasma
Cc: abetts, broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D15814: show all borders for pop up windows in a dock

[Michail Vourlakos]

mvourlakos added a comment.


  In D15814#13 , @broulik wrote:
  
  > The idea is fine in principle but Plasma may also set a mask on its panels, 
noticeably in non-composited case for rounded corners, so when I disable 
compositing I get borders on all side for regular panel popups
  
  
  how about checking for KWindowSystem::compositingActive() ?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15814

To: mvourlakos, #plasma
Cc: abetts, broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D15814: show all borders for pop up windows in a dock

[Michail Vourlakos]

mvourlakos updated this revision to Diff 42489.
mvourlakos added a comment.


  - do not consider dock for !compositing

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15814?vs=42480=42489

BRANCH
  dockBorders

REVISION DETAIL
  https://phabricator.kde.org/D15814

AFFECTED FILES
  src/plasmaquick/dialog.cpp

To: mvourlakos, #plasma
Cc: abetts, broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D15814: show all borders for pop up windows in a dock

[Michail Vourlakos]

mvourlakos added a comment.


  F6291922: εικόνα.png 
  (before)
  
  F6291928: εικόνα.png 
  (after)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15814

To: mvourlakos, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15814: show all borders for pop up windows in a dock

[Michail Vourlakos]

mvourlakos created this revision.
mvourlakos added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mvourlakos requested review of this revision.

REVISION SUMMARY
  --it creates a much better and consistent visual effect
  when applets pop ups that are present in a dock draw
  all their borders.

TEST PLAN
  --use Latte dock in order to confirm the behavior
  --use traditional plasma panel in order to confirm
  that nothing broke

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  dockBorders

REVISION DETAIL
  https://phabricator.kde.org/D15814

AFFECTED FILES
  src/plasmaquick/dialog.cpp

To: mvourlakos, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KGlobalAccel is only Plasma centric?

[Michail Vourlakos]

Hello everyone,

in case someone can answer, there is a user that reported Latte Dock global
shortcuts arent working at alternative environments e.g. Gnome, Budgie

the bug report is at: https://bugs.kde.org/show_bug.cgi?id=396572

Latte supports global shortcuts through KGlobalAccel,
do you know if that framework is only Plasma centric?

regards,
michail

Latte Dock in string freeze

[Michail Vourlakos]

Latte updated its stable branch in order to prepare the last beta before
v0.8.
The official v0.8.0 release is scheduled for 16 July. All translators
interested to have a complete transation for v0.8.0 you can use the stable
branch of Latte Dock to do so...


regards,
michail

D11484: Fix combobox breakage

[Michail Vourlakos]

mvourlakos added a comment.


  thank you, it works just fine now...

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D11484

To: ngraham, broulik, #plasma, mvourlakos, davidedmundson
Cc: #frameworks, michaelh, ngraham

Re: Latte Dock and tangerine font

[Michail Vourlakos]

Jonathan can you please participate at:
https://github.com/psifidotos/Latte-Dock/issues/884#issuecomment-368876977

for this?

the ubuntu member I think responded there...

2018-02-27 14:52 GMT+02:00 Jonathan Riddell <j...@jriddell.org>:

> On 27 February 2018 at 09:24, Michail Vourlakos <mvourla...@gmail.com>
> wrote:
> > Today I received from RikMills that Latte was rejected from ubuntu
> because
> > it contains an OPL-licensed font (tangerine).
> >
> > The discussion is at: https://github.com/psifidotos/
> Latte-Dock/issues/884
> >
> > The font is used just for a label in the configuration window to draw the
> > "Latte"  text at the top-left corner. I thought that an alternative
> could be
> > to just screenshot the label in a png and use that one and drop totally
> the
> > tangerine font distrubution through Latte code...
> >
> > Do you have any ideas what we can do for this and if this is acceptable
> for
> > OPL?
>
> Font licencing is a bit of a quagmire but I really don't see any issue
> here.
>
> The font is freely licenced and .ttf can be considered preferred
> modifiable form so there's no freedom issue.
>
> He says "Source embeds and uses at runtime a GPL-incompatible
> (OPL-Licensed) font; "  but I see no embedding happening, it just
> ships the file which doesn't make it a derived work.  Loading a font
> file at runtime is done by every GUI program very often, it doesn't
> make it a derived work so there's no effect on copyleft licencing
> requirements.
>
> I recommend Ubuntu discuss this with their archive admins to see why
> they consider it a derived work.  I am an Ubuntu archive admin and can
> take part in that conversation if wanted.  If that doesn't get
> anywhere then play a political workaround and just upload it without
> the .ttf font, I presume the text where it's used will just fall back
> to some other font.  Maybe Latte-dock code can be changed to
> explicitly fall back to a generic cursive font if it doesn't find it
> but only if there's a desire to go out of the way for incorrectly
> applied rules.
>
> Jonathan
>

Latte Dock and tangerine font

[Michail Vourlakos]

Today I received from RikMills that Latte was rejected from ubuntu because
it contains an OPL-licensed font (tangerine).

The discussion is at: https://github.com/psifidotos/Latte-Dock/issues/884

The font is used just for a label in the configuration window to draw the
"Latte"  text at the top-left corner. I thought that an alternative could
be to just screenshot the label in a png and use that one and drop totally
the tangerine font distrubution through Latte code...

Do you have any ideas what we can do for this and if this is acceptable for
OPL?

regards,
michail

D10592: fix RTL appearance for ComboBox

[Michail Vourlakos]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:1ff405cca5b3: fix RTL appearance for ComboBox (authored 
by mvourlakos).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10592?vs=27382=27568

REVISION DETAIL
  https://phabricator.kde.org/D10592

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/ComboBox.qml

To: mvourlakos, #plasma, mart, safaalfulaij
Cc: safaalfulaij, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10592: fix RTL appearance for ComboBox

[Michail Vourlakos]

mvourlakos added a comment.


  > Sure. Go ahead and commit.
  
  is it possible to give first the green light by accepting the review?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10592

To: mvourlakos, #plasma, mart, safaalfulaij
Cc: safaalfulaij, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10592: fix RTL appearance for ComboBox

[Michail Vourlakos]

mvourlakos added a reviewer: safaalfulaij.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10592

To: mvourlakos, #plasma, mart, safaalfulaij
Cc: safaalfulaij, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10592: fix RTL appearance for ComboBox

[Michail Vourlakos]

mvourlakos added a comment.


  @safaalfulaij is there a green light for this?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10592

To: mvourlakos, #plasma, mart
Cc: safaalfulaij, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10592: fix RTL appearance for ComboBox

[Michail Vourlakos]

mvourlakos marked an inline comment as done.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10592

To: mvourlakos, #plasma, mart
Cc: safaalfulaij, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10592: fix RTL appearance for ComboBox

[Michail Vourlakos]

mvourlakos updated this revision to Diff 27382.
mvourlakos added a comment.


  - improve semantics

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10592?vs=27373=27382

BRANCH
  rtl

REVISION DETAIL
  https://phabricator.kde.org/D10592

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/ComboBox.qml

To: mvourlakos, #plasma, mart
Cc: safaalfulaij, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9275: fix RTL appearance for ComboBox

[Michail Vourlakos]

mvourlakos added a comment.


  @safaalfulaij I created the following for this: 
https://phabricator.kde.org/D10592

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9275

To: mvourlakos, #plasma, mart
Cc: safaalfulaij, mart, plasma-devel, #frameworks, michaelh, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D10592: fix RTL appearance for ComboBox

[Michail Vourlakos]

mvourlakos created this revision.
mvourlakos added reviewers: Plasma, mart.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
mvourlakos requested review of this revision.

REVISION SUMMARY
  - when the combobox isnt inside the main Item
  
  but rather a sub-Item it doesnt inherit the
  LayoutMirroring properties. This is a workaround
  to handle that behavior.
  QTBUG: https://bugreports.qt.io/browse/QTBUG-66446

TEST PLAN
  checkout that LayoutMirroring works properly in
  such case

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  rtl

REVISION DETAIL
  https://phabricator.kde.org/D10592

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/ComboBox.qml

To: mvourlakos, #plasma, mart
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9275: fix RTL appearance for ComboBox

[Michail Vourlakos]

mvourlakos added a comment.


  Latte config window is a Plasma::ConfigView, so it inherates a QQuickView

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9275

To: mvourlakos, #plasma, mart
Cc: safaalfulaij, mart, plasma-devel, #frameworks, michaelh, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D9275: fix RTL appearance for ComboBox

[Michail Vourlakos]

mvourlakos added a comment.


  Can you build Latte from master version? All comboboxes in its settings 
window are PlasmaComponents3

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9275

To: mvourlakos, #plasma, mart
Cc: safaalfulaij, mart, plasma-devel, #frameworks, michaelh, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D9275: fix RTL appearance for ComboBox

[Michail Vourlakos]

mvourlakos added a comment.


  > Would you please add a HACK so that we know when to remove this?
  
  You mean as a comment ?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9275

To: mvourlakos, #plasma, mart
Cc: safaalfulaij, mart, plasma-devel, #frameworks, michaelh, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D9275: fix RTL appearance for ComboBox

[Michail Vourlakos]

mvourlakos added a comment.


  @mart I fixed this issue by changing these lines to:
  
113LayoutMirroring.enabled: Qt.application.layoutDirection === 
Qt.RightToLeft
114LayoutMirroring.childrenInherit: true

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9275

To: mvourlakos, #plasma, mart
Cc: safaalfulaij, mart, plasma-devel, #frameworks, michaelh, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D9275: fix RTL appearance for ComboBox

[Michail Vourlakos]

mvourlakos added a comment.


  @safaalfulaij @mart we need to revert this...
  with frameworks 5.43 it reverses list items always!!!
  
  The issue is still present when the PlasmaComponents3.ComboBox is used in the 
Latte settings window,
  that is the items are not aligned correctly in --reverse mode

INLINE COMMENTS

> safaalfulaij wrote in ComboBox.qml:113
> So it is true even for LTR locales?

yes,
in my system with these settings the combobox list items are aligned correctly 
for both
LTR and --reverse

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9275

To: mvourlakos, #plasma, mart
Cc: safaalfulaij, mart, plasma-devel, #frameworks, michaelh, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D9275: fix RTL appearance for ComboBox

[Michail Vourlakos]

mvourlakos added a comment.


  In https://phabricator.kde.org/D9275#190594, @safaalfulaij wrote:
  
  > In https://phabricator.kde.org/D9275#190569, @mvourlakos wrote:
  >
  > > with your example me I cant reproduce it either...
  > >  I can only reproduce it with Latte Settings window, all other components 
are aligned correctly except the PlasmaComponent3.Combobox list items.
  > >
  > > you are right, this might be a downstream bug...
  > >
  > > Do you want to revert it 
  > >  I can do it
  >
  >
  > I checked out the source of latte-dock and it seems that it is using the 
old QQC1-based controls, which are problematic, especially with RTL :)
  >  This is a change for QQC2-based controls (version 3.0 of 
org.kde.plasma.components).
  
  
  To test it in Latte I added in the head of 
/shell/package/contents/configuration/AppearanceConfig.qml
  
import org.kde.plasma.components 3.0 as PlasmaComponents3
  
  and I set up the ComboBox in that file to:
  
PlasmaComponents3.ComboBox
  
  
  
  > But I can't understand how changing this V3 solved V2..
  
  V2 components are based totally at Qt Styles, V3 are reimplementing the 
behavior
  PlasmaComponents2.ComboBox is a ComboBoxStyle  but
  PlasmaComponents3.ComboBox is a real ComboBox

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9275

To: mvourlakos, #plasma, mart
Cc: safaalfulaij, mart, plasma-devel, #frameworks, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D9275: fix RTL appearance for ComboBox

[Michail Vourlakos]

mvourlakos added a comment.


  In https://phabricator.kde.org/D9275#190547, @safaalfulaij wrote:
  
  > In https://phabricator.kde.org/D9275#190497, @mvourlakos wrote:
  >
  > > how did you test it?
  > >
  > > I tried in an qml app (Latte dock) by passing the parameter "--reverse"...
  > >  If your system is already using in RTL language, have you tried with 
--reverse?
  >
  >
  > I am using this with qmlsence-qt5.
  >  `plasma` folder is the ones before this, and `plasmacomponents3` is the 
one after this.
  >  Using C locale, everything aligned to left. Using --reverse will align 
everything to right.
  >  Using ar locale, everything aligned to right. Using --reverse will **not** 
reverse it to LTR layout and it makes everything aligned to left.
  >
  > Can't see the problem really.
  
  
  with your example me I cant reproduce it either...
  I can only reproduce it with Latte Settings window, all other components are 
aligned correctly except the PlasmaComponent3.Combobox list items.
  
  you are right, this might be a downstream bug...
  
  Do you want to revert it 
  I can do it

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9275

To: mvourlakos, #plasma, mart
Cc: safaalfulaij, mart, plasma-devel, #frameworks, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D9275: fix RTL appearance for ComboBox

[Michail Vourlakos]

mvourlakos added a comment.


  In https://phabricator.kde.org/D9275#190473, @safaalfulaij wrote:
  
  > In https://phabricator.kde.org/D9275#190464, @mvourlakos wrote:
  >
  > > In https://phabricator.kde.org/D9275#190441, @safaalfulaij wrote:
  > >
  > > > Can you please explain why these are needed? I tested 
 plasmacomponents3 and the combobox was 
working correctly.
  > >
  > >
  > > It wasnt, use english text in the list items to see the issue without the 
patch.
  >
  >
  > Nope, I have also English text in the model. Its:
  >  تجربة_
  > _test
  > test
  
  
  how did you test it?
  
  I tried in an qml app (Latte dock) by passing the parameter "--reverse"...
  If your system is already using in RTL language, have you tried with 
--reverse?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9275

To: mvourlakos, #plasma, mart
Cc: safaalfulaij, mart, plasma-devel, #frameworks, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D9275: fix RTL appearance for ComboBox

[Michail Vourlakos]

mvourlakos added a comment.


  In https://phabricator.kde.org/D9275#190441, @safaalfulaij wrote:
  
  > Can you please explain why these are needed? I tested 
 plasmacomponents3 and the combobox was 
working correctly.
  
  
  It wasnt, use english text in the list items to see the issue without the 
patch.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9275

To: mvourlakos, #plasma, mart
Cc: safaalfulaij, mart, plasma-devel, #frameworks, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D9275: fix RTL appearance for ComboBox

[Michail Vourlakos]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:547dade2f803: fix RTL appearance for ComboBox (authored 
by mvourlakos).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9275?vs=23708=25254

REVISION DETAIL
  https://phabricator.kde.org/D9275

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/ComboBox.qml

To: mvourlakos, #plasma, mart
Cc: mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

Re: DownloadDialog for Latte Layouts

[Michail Vourlakos]

Found it Albert, the administrators of the store had to do something
first... Now it works fine ;-)

Στις 4 Ιαν 2018 12:30 π.μ., ο χρήστης "Albert Astals Cid" <aa...@kde.org>
έγραψε:

> El dimecres, 3 de gener de 2018, a les 10:30:49 CET, Michail Vourlakos va
> escriure:
> > Hello,
> >
> > I am trying to support the KNS3::DownloadDialog in Latte in order for the
> > user to be able to download Latte Layouts from store.kde.org from inside
> > Latte... But I cant get it to work, the DownloadDialog shows the message
> >
> > Could not find category "Latte Layouts"
> >
> > or when I change it to 417 based on:
> > https://store.kde.org/browse/cat/417/ord/latest/
> >
> > Could not find category "417"
> >
> >
> > Do you have any ideas what is needed to work?
>
> Without seeing your code is really hard to figure out what's wrong.
>
> Do you have a branch with that code?
>
> Cheers,
>   Albert
>
> >
> >
> > regards,
> > michail
>
>
>

DownloadDialog for Latte Layouts

[Michail Vourlakos]

Hello,

I am trying to support the KNS3::DownloadDialog in Latte in order for the
user to be able to download Latte Layouts from store.kde.org from inside
Latte... But I cant get it to work, the DownloadDialog shows the message

Could not find category "Latte Layouts"

or when I change it to 417 based on:
https://store.kde.org/browse/cat/417/ord/latest/

Could not find category "417"


Do you have any ideas what is needed to work?


regards,
michail

D9276: highlight PlasmaComponents3.ComboBox list items

[Michail Vourlakos]

mvourlakos added a comment.


  external bug report: 
https://github.com/PapirusDevelopmentTeam/adapta-kde/issues/26

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9276

To: mvourlakos, #plasma, mart
Cc: mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D9275: fix RTL appearance for ComboBox

[Michail Vourlakos]

mvourlakos added a subscriber: mart.
mvourlakos added a comment.


  @mart what about this? are you able to reproduce it in your system?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9275

To: mvourlakos, #plasma
Cc: mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D9276: highlight PlasmaComponents3.ComboBox list items

[Michail Vourlakos]

mvourlakos abandoned this revision.
mvourlakos added a comment.


  this is Adapta theme issue...

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9276

To: mvourlakos, #plasma, mart
Cc: mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D9276: highlight PlasmaComponents3.ComboBox list items

[Michail Vourlakos]

mvourlakos added a comment.


  In https://phabricator.kde.org/D9276#179574, @mart wrote:
  
  > here on master the item under mouse does get highlighted
  
  
  you are totally right!! so sorry... this is Adapta theme issue, changing to 
Breeze themes solves this...

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9276

To: mvourlakos, #plasma, mart
Cc: mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D9276: highlight PlasmaComponents3.ComboBox list items

[Michail Vourlakos]

mvourlakos added inline comments.

INLINE COMMENTS

> mart wrote in ComboBox.qml:49
> uuh, no, ItemDelegate should highlight by itself when hovered without having 
> to do that, this would say that there is a problem in ItemDelegate?

yes... it didnt highlight at all, neither the selected item nor the hovered 
one... this is happening both for LTR and RTL cases...

this is the reason of this patch

are you considering it a plasma issue or qt one ?
I can try to update the plasma ItemDelegate (which is based at CheckDelegate) 
if you want.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9276

To: mvourlakos, #plasma, mart
Cc: mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D9276: highlight PlasmaComponents3.ComboBox list items

[Michail Vourlakos]

mvourlakos added a comment.


  just noticed that the reviewer is the person that decides to give the green 
light so it cant be set by the author without prior communication...

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9276

To: mvourlakos, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9275: fix RTL appearance for ComboBox

[Michail Vourlakos]

mvourlakos added a comment.


  just noticed that the reviewer is the person that decides to give the green 
light so it cant be set by the author without prior communication...

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9275

To: mvourlakos, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9276: highlight PlasmaComponents3.ComboBox list items

[Michail Vourlakos]

mvourlakos removed a reviewer: mart.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9276

To: mvourlakos, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9275: fix RTL appearance for ComboBox

[Michail Vourlakos]

mvourlakos removed a reviewer: mart.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9275

To: mvourlakos, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9276: highlight PlasmaComponents3.ComboBox list items

[Michail Vourlakos]

mvourlakos added a reviewer: mart.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9276

To: mvourlakos, #plasma, mart
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9275: fix RTL appearance for ComboBox

[Michail Vourlakos]

mvourlakos added a reviewer: mart.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9275

To: mvourlakos, #plasma, mart
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9275: fix RTL appearance for ComboBox

[Michail Vourlakos]

mvourlakos edited the summary of this revision.
mvourlakos edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9275

To: mvourlakos, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9276: highlight PlasmaComponents3.ComboBox list items

[Michail Vourlakos]

mvourlakos created this revision.
mvourlakos added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  --PlasmaComponents.ComboBox now highlights correctly
  the selected item and on hovering any item from the
  items list.
  
  BUG: 387735

TEST PLAN
  show a combox list and check the correct
  behavior

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  highlight

REVISION DETAIL
  https://phabricator.kde.org/D9276

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/ComboBox.qml

To: mvourlakos, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9275: fix RTL appearance for ComboBox

[Michail Vourlakos]

mvourlakos updated this revision to Diff 23708.
mvourlakos added a comment.


  - fix typos

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9275?vs=23707=23708

BRANCH
  listrtl

REVISION DETAIL
  https://phabricator.kde.org/D9275

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/ComboBox.qml

To: mvourlakos, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9275: fix RTL appearance for ComboBox

[Michail Vourlakos]

mvourlakos created this revision.
mvourlakos added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  --PlasmaComponents3.ComboBox now appears correctly
  its list items in RTL environments by aligning them
  to the right
  
  BUG: 387558

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  listrtl

REVISION DETAIL
  https://phabricator.kde.org/D9275

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/ComboBox.qml

To: mvourlakos, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9126: [RTL] - align properly the selected text for RTL

[Michail Vourlakos]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:71f8f16fea15: [RTL] - align properly the selected text 
for RTL (authored by mvourlakos).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9126?vs=23332=23521

REVISION DETAIL
  https://phabricator.kde.org/D9126

AFFECTED FILES
  src/declarativeimports/plasmastyle/ComboBoxStyle.qml

To: mvourlakos, #plasma, davidedmundson
Cc: broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9126: [RTL] - align properly the selected text for RTL

[Michail Vourlakos]

mvourlakos added a comment.


  In https://phabricator.kde.org/D9126#175594, @broulik wrote:
  
  > (I'd be fine with this one liner going in but I'm wondering why it would be 
needed in the first place)
  
  
  are we ok for landing this?

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  rtl

REVISION DETAIL
  https://phabricator.kde.org/D9126

To: mvourlakos, #plasma, davidedmundson
Cc: broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9126: [RTL] - align properly the selected text for RTL

[Michail Vourlakos]

mvourlakos added a comment.


  without that line there is the following problem:
  
  if in the combobox list there are also LTR items then when these items are 
selected they are aligned to the left and
  when the RTL items are selected they are aligned to the right.
  
  By adding that line the LTR items in an RTL environment are aligned correctly 
to the right.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  rtl

REVISION DETAIL
  https://phabricator.kde.org/D9126

To: mvourlakos, #plasma, davidedmundson
Cc: broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9126: [RTL] - align properly the selected text for RTL

[Michail Vourlakos]

mvourlakos created this revision.
mvourlakos added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  --align selected text correctly for
  PlasmaComponents2.ComboBox taking into account
  RTL.
  
  BUG: 387415

TEST PLAN
  use ComboBoxes in RTL and LTR in order
  to check a proper behavior

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  rtl

REVISION DETAIL
  https://phabricator.kde.org/D9126

AFFECTED FILES
  src/declarativeimports/plasmastyle/ComboBoxStyle.qml

To: mvourlakos, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Re: Latte : make_unique for gcc <=4.8

[Michail Vourlakos]

2017-11-09 10:58 GMT+02:00 Tomaz Canabrava :

>
>
>> regards,
>> [michail]
>>
>>
>> BTW: for every e-mail I send I need moderator approval is that a standard
>> procedure or I can register somewhere to avoid this?
>>
>
> yes, you can: https://mail.kde.org/mailman/listinfo/kde-core-devel
>
>
>
the thing is that I am already subscribed there but all my e-mails to
kde-core-devel need a moderator approval... funny thing is that for
plasma-devel mailing list I dont need such moderator approval.


Απαλλαγμένο
από ιούς. www.avast.com

<#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

Re: Latte : make_unique for gcc <=4.8

[Michail Vourlakos]

gcc 4.8.5 is used by openSUSE Leap.

 If you check the code now i enable it through cmake if it is needed by
using the flag -DINCLUDE_MAKE_UNIQUE=ON

Στις 9 Νοε 2017 11:56, ο χρήστης "Sven Brauch" <m...@svenbrauch.de> έγραψε:

On 05/11/17 16:12, Michail Vourlakos wrote:
> Do you know any better way to handle this?

You can let cmake do the check:

https://cmake.org/cmake/help/v3.0/module/CheckSymbolExists.html

Not sure if this is the best option, though.

Greetings,
Sven

Latte : make_unique for gcc <=4.8

[Michail Vourlakos]

Hello everyone,

during the review phase in Latte we removed the following code in case it
would conflict in some cases:

#if __GLIBCXX__ <= 20150623
namespace std {
template
unique_ptr make_unique(Args &&... args)
{
return std::unique_ptr(new T(std::forward(args)...));
}
}
#endif


this was needed for gcc versions that even though they are C++14 compatible
they dont offer make_unique function. By removing that code we broke
compatibility with openSUSE Leap that uses gcc 4.8.5 ... so in order to
build latte packages a made a patch to readd that code.

Do you know any better way to handle this?

regards,
[michail]


BTW: for every e-mail I send I need moderator approval is that a standard
procedure or I can register somewhere to avoid this?

Latte Dock into extragear...

[Michail Vourlakos]

Just to update...

Latte from now on can be found at extragear after succeeding at its review
phase...
as mentioned also at: https://phabricator.kde.org/T7115

regards,
[michail]

Latte Dock as kde project and seeking some wisdomness

[Michail Vourlakos]

Hello everyone,

Latte is in review phase in order to become kde project but this mail is
not for this.
I am searching for some wisdom concering QML crashes. Some users reported
that an update in Arch crashes Latte Dock 0.7.1 even though this wasnt
happening in the past. The update references plasma 5.11 and qt 5.9.2

I pushed them in order to provide meaningful backtraces and the users
reported with the following:

trace1:
https://user-images.githubusercontent.com/1787385/31838269-052e5a92-b5aa-11e7-9003-939129a70f27.png
trace2:
https://user-images.githubusercontent.com/1787385/31841784-09315bbc-b5b9-11e7-81a4-9756bcf76f92.png

the crash occurs by just hovering the dock. my opinion is that leads to Qt
and is upstream but I cant be sure, I am not a QML expert.

if this isnt the correct channel for such questions feel free to correct
me...

regards,
[michail]

Re: Latte Dock in review phase

[Michail Vourlakos]

> Hi, what is the latte dock kde repo git url?

latte can be found at, kde:latte-dock
it is located in kdereview

2017-10-13 1:12 GMT+03:00 Albert Astals Cid <aa...@kde.org>:

> El dijous, 5 d’octubre de 2017, a les 0:00:01 CEST, Michail Vourlakos va
> escriure:
> > Hello everyone,
> >
> > we decided to make Latte an active kde project and so now it is in review
> > phase. I believe the best place to be is extragear because we would like
> to
> > keep some independence for the first year concerning releases...
>
> Hi, what is the latte dock kde repo git url?
>
> Cheers,
>   Albert
>
> >
> > What is Latte Dock?
> >
> > Latte is a project that is trying to provide a unified solution concering
> > docks and panels for the user. To achieve this it provides,
> > the Latte app, a Latte qml library, a Latte containment, a Latte
> plasmoid,
> > a Latte shell that uses plasma shell as base and 2 applets (a separator
> and
> > a specialized spacer)
> >
> > for more infos concerning the capabilities of the Latte suite you can
> find
> > at:
> > https://psifidotos.blogspot.nl/2017/04/latte-dock-v06-fresh-air.html
> > https://psifidotos.blogspot.nl/2017/08/latte-dock-v07-
> tornado-is-coming.html
> >
> > the project before entering the kde infrastructure could be found at:
> > https://github.com/psifidotos/Latte-Dock
> >
> > in review you can find our 0.7.1 version which is our stable version and
> > the plan is that after we succeed in the review phase to release a 0.7.2
> > version only through kde infrastructure...
> >
> > regards,
> > michail
>
>
>

Latte Dock in review phase

[Michail Vourlakos]

Hello everyone,

we decided to make Latte an active kde project and so now it is in review
phase. I believe the best place to be is extragear because we would like to
keep some independence for the first year concerning releases...

What is Latte Dock?

Latte is a project that is trying to provide a unified solution concering
docks and panels for the user. To achieve this it provides,
the Latte app, a Latte qml library, a Latte containment, a Latte plasmoid,
a Latte shell that uses plasma shell as base and 2 applets (a separator and
a specialized spacer)

for more infos concerning the capabilities of the Latte suite you can find
at:
https://psifidotos.blogspot.nl/2017/04/latte-dock-v06-fresh-air.html
https://psifidotos.blogspot.nl/2017/08/latte-dock-v07-tornado-is-coming.html

the project before entering the kde infrastructure could be found at:
https://github.com/psifidotos/Latte-Dock

in review you can find our 0.7.1 version which is our stable version and
the plan is that after we succeed in the review phase to release a 0.7.2
version only through kde infrastructure...

regards,
michail

D5515: Update the ungrabMouse hack for Qt 5.8

[Michail Vourlakos]

mvourlakos added a comment.


  I had reported qts faulty behavior concerning centextmenus at: 
https://bugreports.qt.io/browse/QTBUG-59044
  
  I think it is the mentioned case...

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5515

To: davidedmundson, #plasma
Cc: mvourlakos, plasma-devel, #frameworks, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Commented On] D4711: Ungrab mouse on menu close

[Michail Vourlakos]

mvourlakos added a comment.


  In https://phabricator.kde.org/D4711#89334, @mart wrote:
  
  > this on released Qt 5.8? on 5.8 branch?
  >  i can't reproduce with my 5.8 build here.
  >  anyways, that beahvior change would be a Qt bug (one of the many the 
terrible 5.8 release had) and should be fixed upstream
  >  the indicated if (!enter || !QWidget::mouseGrabber()) { code was added in 
2012, so can't be the responsible of the change
  
  
  I am using Qt 5.8 from 
http://download.opensuse.org/repositories/KDE:/Qt5/openSUSE_Leap_42.2/
  I think this is the released version...
  
  in my system I am doing the folowing:
  
  1. open a qtcreator
  2. notice the hovering works at the menu bar
  3. activate any menu from the top menu bar
  4. deactivate this menu by clicking on the desktop
  5. going the mouse above the qt creator's menu bar then hovering is not 
working, the user must click into the qtcreator in order for hovering to work 
again

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4711

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: anthonyfieroni, #plasma, broulik, mart
Cc: mvourlakos, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

[Differential] [Commented On] D4711: Ungrab mouse on menu close

[Michail Vourlakos]

mvourlakos added a comment.


  I just noticed...
  you dont have to go too far...
  any qt application using 5.8 has this problem...
  even qtcreator...
  
  showing a menu and then deactivating it from outside areas then the window 
needs a click from the user
  in order for this window to react properly

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4711

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: anthonyfieroni, #plasma, broulik, mart
Cc: mvourlakos, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

[Differential] [Commented On] D4711: Ungrab mouse on menu close

[Michail Vourlakos]

mvourlakos added a comment.


  You can observe the faulty behavior even with Qt's "Menu's Example".
  
  1. Open any menu you want either with right click or from the menu
  2. Close it by clicking in any outside area you want, that is (not inside the 
menu example window and not in the menu)
  3. Observe that you can not even hover at the menus on top. For the window to 
work as expected someone must click first in the example window.
  
  at (3) the menu example window should work as normal...

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4711

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: anthonyfieroni, #plasma, broulik, mart
Cc: mvourlakos, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

[Differential] [Commented On] D4711: Ungrab mouse on menu close

[Michail Vourlakos]

mvourlakos added a comment.


  In https://phabricator.kde.org/D4711#88621, @mart wrote:
  
  > do you know exactly what/where changed?
  
  
  sorry if this is irrelevant...
  I dont know if the above code works but in my code tree in latte dock I can 
not do anything to ungrabMouse in Qt 5.8 in case the user closes the menu by 
deactivating it with a click at the outside area (that is not the window area 
or the menu one)...
  
  I have filed a bug at: https://bugreports.qt.io/browse/QTBUG-59044
  
  I thought that this might be relevant to my qt bug report...

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4711

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: anthonyfieroni, #plasma, broulik, mart
Cc: mvourlakos, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol