Re: Can we rename gitklient?
Two name ideas came to me - DeltaKit (delta as difference in physics) - Konformity/Konform (conformity as antonym to difference) cheers On 3/2/23 19:32, Hamed Masafi wrote: Considering that gitklient is very close to the first version, I have to say something about its naming. When I started the project, no name came to my mind. Of course, it is the same now. That's why, just so that the name of the project is not empty, change its name to gitklient, in kde 3 naming style (I know). Considering that the first version of this app has not been published yet, can we change the name? If the answer is yes, what name should we choose? To be honest, I still don't have a suitable name in mind! I sent this email so that we can talk about this (of course, if we can change the name of the program) and find a good name for it. I had a long chat with ChatGpt! Also, I got help from some name suggestion sites and asked some people for their opinion. Finally, I have a list of suggested names to start a discussion. - Kodify - Kittie - Kode - Kommit - Codekit - Kodev - Please let me know what you think. BR -- Mladen Milinkovic GPG/PGP: EF9D9B26
Re: Registration
On 1/16/23 09:58, be...@tuta.io wrote: Hello there! I've just tried to register on your KDE Identity thing. I did everything properly and saw "Client rejected by automatic spammer detection system". What is that shit supposed to mean? I'm not a spammer. -- I'm using Tutanota - the end-to-end encrypted email service Hello there, Yes you are. Please stop spamming. -- Mladen Milinkovic GPG/PGP: EF9D9B26
Re: Submitting SubtitleComposer for KDE Review
On 11/7/21 20:57, Albert Astals Cid wrote: El diumenge, 7 de novembre de 2021, a les 19:05:44 (CET), Mladen Milinkovic va escriure: Have updated the bug report address to bugs.kde.org (default) in KAboutData and project has been added. Should I do something else to complete the process? From my side I think you fixed everything I reported. I'd say wait a week more in case someone else has time to have a look, but if there's no more movement consider the review done and ask sysadmin to finish the move to its final location. great... thanks When opening an existing .srt, there is a few Subtitle::insertLine calls that end up calling Subtitle::processAction with the if(app()->subtitle() != this) situation. I think all those Actions leak, because you just call redo on them but they are not deleted by anyone, no? Yes they were leaking fixed them with 911b94b. There are still some definite leaks after closing application: - libfontconfig/QTextDocument (FcFontRenderPrepare https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=655989) - QXcbGlxWindow::createVisual() calling radeon_dri.so and amdgpu_winsys_create() - Breeze::WidgetStateEngine::registerWidget calling QObject::connect (might be related to "QCoreApplication::postEvent: Unexpected null receiver" messages at application shutdown) - KF5WidgetAddons (KSelectActionPrivate::init()) I have found a cause of leak in KSelectActionPrivate::init(), it was also causing "QCoreApplication::postEvent: Unexpected null receiver" messages at application shutdown I fixed it inside SC, will submit a patch to invent.kde.org later.. I'm not sure what's the best why to fix it. -- Mladen Milinkovic GPG/PGP: EF9D9B26
Re: Submitting SubtitleComposer for KDE Review
Have updated the bug report address to bugs.kde.org (default) in KAboutData and project has been added. Should I do something else to complete the process? Cheers, Mladen On 10/16/21 00:28, Mladen Milinkovic wrote: On 10/15/21 22:39, Albert Astals Cid wrote: I think you may have dropped k-c-d from the CC, adding it back. I have hit a wrong button again :) El divendres, 15 d’octubre de 2021, a les 22:18:00 (CEST), Mladen Milinkovic va escriure: On 10/13/21 23:03, Albert Astals Cid wrote: I think the tests are somehow not correctly flagged as tests, running ctest will only run the appstream check and src/tests/test-subtitle, but not test-core-rangelist and the rest. Fixed in ec9ffba - I'm pretty sure this was working fine at some point in (not so distant) past. The first text format change doesn't seem to trigger the "file has changed and we should enable saving" logic. i.e. i have written a new subtitle line that says "HOLA" and saved the subtitle. Now if i select all the text and press the strikeout button, the save button does not get enabled, if i press the strikeout button again, the save button correctly gets enabled. I believe this was happening sometimes due to "relatively scary valgrind warning" below... looks like it's not happening anymore - could you please confirm? Seems to be working now :) If i close a video while it's playing, the Play button will still be enabled (if i stop the video it will not) Fixed in 663d209 Opening a .srt i just created and editing one of the subtitle lines i get this relatively scary valgrind warninghttps://ghostbin.com/YGnmL Fixed in 663d209. QUndoStack::push(action) can merge and delete action, in those cases it ended with invalid read immediately afterwards. When opening an existing .srt, there is a few Subtitle::insertLine calls that end up calling Subtitle::processAction with the if(app()->subtitle() != this) situation. I think all those Actions leak, because you just call redo on them but they are not deleted by anyone, no? Yes they were leaking fixed them with 911b94b. There are still some definite leaks after closing application: - libfontconfig/QTextDocument (FcFontRenderPrepare https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=655989) - QXcbGlxWindow::createVisual() calling radeon_dri.so and amdgpu_winsys_create() - Breeze::WidgetStateEngine::registerWidget calling QObject::connect (might be related to "QCoreApplication::postEvent: Unexpected null receiver" messages at application shutdown) - KF5WidgetAddons (KSelectActionPrivate::init()) There are also some memory errors that seem caused by KIO/KUrlRequester. There are some possible leaks related to QTextDocument and rendering, will investigate ASAP if it's due to something that SC does wrong. I think most of those are not your fault, but if you can spend a bit of time investigating won't hurt :) Sure... will do that at some point soonish. The "Report bug" incorrectly links tohttps://invent.kde.org/multimedia/subtitlecomposer/-/issues instead of bug.kde.org I didn't change the bug report url to bugs.kde.org yet as it doesn't seem possible to file Subtitle Composer bugs there? Would prefer to change it right before SC gets included there if it's necessary. There are SC binaries that get generated pretty often that people are using - I'd like them to have a bug report url they can use to report bugs. Ok, then should open a request at https://phabricator.kde.org/maniphest/task/edit/form/2/ so that a subtitlecomposer product is created :) And done https://phabricator.kde.org/T14947 Cheers, Albert Cheers, Albert Thank you! Cheers -- Mladen Milinkovic GPG/PGP: EF9D9B26
Re: Submitting SubtitleComposer for KDE Review
On 10/15/21 22:39, Albert Astals Cid wrote:
I think you may have dropped k-c-d from the CC, adding it back.
I have hit a wrong button again :)
El divendres, 15 d’octubre de 2021, a les 22:18:00 (CEST), Mladen Milinkovic va
escriure:
On 10/13/21 23:03, Albert Astals Cid wrote:
I think the tests are somehow not correctly flagged as tests, running ctest
will only run the appstream check and src/tests/test-subtitle, but not
test-core-rangelist and the rest.
Fixed in ec9ffba - I'm pretty sure this was working fine at some point in (not
so distant) past.
The first text format change doesn't seem to trigger the "file has changed and we should
enable saving" logic. i.e. i have written a new subtitle line that says "HOLA" and
saved the subtitle. Now if i select all the text and press the strikeout button, the save button
does not get enabled, if i press the strikeout button again, the save button correctly gets enabled.
I believe this was happening sometimes due to "relatively scary valgrind
warning" below... looks like it's not happening
anymore - could you please confirm?
Seems to be working now :)
If i close a video while it's playing, the Play button will still be enabled
(if i stop the video it will not)
Fixed in 663d209
Opening a .srt i just created and editing one of the subtitle lines i get this
relatively scary valgrind warninghttps://ghostbin.com/YGnmL
Fixed in 663d209. QUndoStack::push(action) can merge and delete action, in
those cases it ended with invalid read
immediately afterwards.
When opening an existing .srt, there is a few Subtitle::insertLine calls that end
up calling Subtitle::processAction with the if(app()->subtitle() != this)
situation. I think all those Actions leak, because you just call redo on them but
they are not deleted by anyone, no?
Yes they were leaking fixed them with 911b94b.
There are still some definite leaks after closing application:
- libfontconfig/QTextDocument (FcFontRenderPrepare
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=655989)
- QXcbGlxWindow::createVisual() calling radeon_dri.so and
amdgpu_winsys_create()
- Breeze::WidgetStateEngine::registerWidget calling QObject::connect (might
be related to
"QCoreApplication::postEvent: Unexpected null receiver" messages at application
shutdown)
- KF5WidgetAddons (KSelectActionPrivate::init())
There are also some memory errors that seem caused by KIO/KUrlRequester.
There are some possible leaks related to QTextDocument and rendering, will
investigate ASAP if it's due to something
that SC does wrong.
I think most of those are not your fault, but if you can spend a bit of time
investigating won't hurt :)
Sure... will do that at some point soonish.
The "Report bug" incorrectly links
tohttps://invent.kde.org/multimedia/subtitlecomposer/-/issues instead of bug.kde.org
I didn't change the bug report url to bugs.kde.org yet as it doesn't seem
possible to file Subtitle Composer bugs there?
Would prefer to change it right before SC gets included there if it's
necessary. There are SC binaries that get
generated pretty often that people are using - I'd like them to have a bug
report url they can use to report bugs.
Ok, then should open a request at
https://phabricator.kde.org/maniphest/task/edit/form/2/ so that a
subtitlecomposer product is created :)
And done https://phabricator.kde.org/T14947
Cheers,
Albert
Cheers,
Albert
Thank you!
Cheers
--
Mladen Milinkovic
GPG/PGP: EF9D9B26
Re: Submitting SubtitleComposer for KDE Review
On 10/13/21 23:03, Albert Astals Cid wrote: I think the tests are somehow not correctly flagged as tests, running ctest will only run the appstream check and src/tests/test-subtitle, but not test-core-rangelist and the rest. Fixed in ec9ffba - I'm pretty sure this was working fine at some point in (not so distant) past. The first text format change doesn't seem to trigger the "file has changed and we should enable saving" logic. i.e. i have written a new subtitle line that says "HOLA" and saved the subtitle. Now if i select all the text and press the strikeout button, the save button does not get enabled, if i press the strikeout button again, the save button correctly gets enabled. I believe this was happening sometimes due to "relatively scary valgrind warning" below... looks like it's not happening anymore - could you please confirm? If i close a video while it's playing, the Play button will still be enabled (if i stop the video it will not) Fixed in 663d209 Opening a .srt i just created and editing one of the subtitle lines i get this relatively scary valgrind warninghttps://ghostbin.com/YGnmL Fixed in 663d209. QUndoStack::push(action) can merge and delete action, in those cases it ended with invalid read immediately afterwards. When opening an existing .srt, there is a few Subtitle::insertLine calls that end up calling Subtitle::processAction with the if(app()->subtitle() != this) situation. I think all those Actions leak, because you just call redo on them but they are not deleted by anyone, no? Yes they were leaking fixed them with 911b94b. There are still some definite leaks after closing application: - libfontconfig/QTextDocument (FcFontRenderPrepare https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=655989) - QXcbGlxWindow::createVisual() calling radeon_dri.so and amdgpu_winsys_create() - Breeze::WidgetStateEngine::registerWidget calling QObject::connect (might be related to "QCoreApplication::postEvent: Unexpected null receiver" messages at application shutdown) - KF5WidgetAddons (KSelectActionPrivate::init()) There are also some memory errors that seem caused by KIO/KUrlRequester. There are some possible leaks related to QTextDocument and rendering, will investigate ASAP if it's due to something that SC does wrong. The "Report bug" incorrectly links tohttps://invent.kde.org/multimedia/subtitlecomposer/-/issues instead of bug.kde.org I didn't change the bug report url to bugs.kde.org yet as it doesn't seem possible to file Subtitle Composer bugs there? Would prefer to change it right before SC gets included there if it's necessary. There are SC binaries that get generated pretty often that people are using - I'd like them to have a bug report url they can use to report bugs. Cheers, Albert Thank you! -- Mladen Milinkovic GPG/PGP: EF9D9B26
Submitting SubtitleComposer for KDE Review
Hello everyone, I would like to move subtitlecomposer to kdereview. https://invent.kde.org/multimedia/subtitlecomposer https://subtitlecomposer.kde.org/ Subtitle Composer is an app to create, sync, translate, ... text subtitles for videos and media. Thanks -- Mladen Milinkovic GPG/PGP: EF9D9B26
Re: Looking for Subtitle Composer sponsor
On 11/14/19 9:47 AM, Ben Cooksley wrote: > On Thu, Nov 14, 2019 at 9:31 PM Mladen Milinkovic wrote: >> Thank you. It doesn't seem I have commit rights to it tho. >> I get this when trying to push: >> >>> GitLab: You are not allowed to push code to this project. >> fatal: Could not read from remote repository. >> >> Please make sure you have the correct access rights >> and the repository exists. >> >> Also am not listed in >> https://invent.kde.org/kde/subtitlecomposer/-/settings/members > > Sorry about that, that occurs when someone receives their developer > account after logging into Gitlab for the first time. > I've now corrected your group membership. > > (This is something we intend on fixing as part of the final deployment) > Thank you. I was trying to setup release builds using CI. I don't have permissions on the new repo to access settings (eg. so I can't add CI/CD env variables). Should I file a ticket somewhere when I want to change something in repo settings or will I get higher permissions at some point? I have noticed that GitLab API for creating tags is not working. It doesn't even work from web interface. Both just give blank errror message and HTTP/1.1 400 Bad Request. Is this a bug or intentional? API URL: https://invent.kde.org/api/v4/projects/731/repository/tags?ref=master_name=test WEB URL: https://invent.kde.org/milinkovic/subtitlecomposer/-/tags/new Mladen
Re: Looking for Subtitle Composer sponsor
On 11/14/19 8:54 AM, Ben Cooksley wrote: > On Thu, Nov 14, 2019 at 8:53 PM Mladen Milinkovic wrote: >> >> On 11/13/19 7:14 PM, Nate Graham wrote: >>> >>> Looks like the repo is open and you've got your commit rights, so you can >>> start migrating to use that repo now, Mladen! >>> >>> Nate >> >> That's great, thank you. How/where can I access the repo? >> I don't have permissions to see https://phabricator.kde.org/T11998 > > That is a Sysadmin ticket, which is why you wouldn't have been able to > access it as Nate filed that for you. > The repository can be found at https://invent.kde.org/kde/subtitlecomposer > >> >> Mladen > > Cheers, > Ben > Thank you. It doesn't seem I have commit rights to it tho. I get this when trying to push: > GitLab: You are not allowed to push code to this project. fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists. Also am not listed in https://invent.kde.org/kde/subtitlecomposer/-/settings/members Mladen
Re: Looking for Subtitle Composer sponsor
On 11/13/19 7:14 PM, Nate Graham wrote: > On 11/8/19 12:24 PM, Nate Graham wrote: >> On 11/8/19 2:42 AM, Ben Cooksley wrote: >>> We'll need a ticket submitted for this (as emails can get lost, but >>> tickets cannot be lost). >>> If you could submit one at https://go.kde.org/systickets that would be >>> appreciated. >> >> Done, I've filed https://phabricator.kde.org/T11998 >> >> Nate >> > > Looks like the repo is open and you've got your commit rights, so you can > start migrating to use that repo now, Mladen! > > Nate That's great, thank you. How/where can I access the repo? I don't have permissions to see https://phabricator.kde.org/T11998 Mladen
Re: Looking for Subtitle Composer sponsor
Hello Nate, On 11/7/19 3:31 PM, Nate Graham wrote: > I would be happy to be your sponsor! Thank you! > Per https://community.kde.org/Incubator#Candidate, we need you to provide the > following information: > > - A list of the people regularly committing to the project That would be only me I believe. Right now I'm the only one with write permissions to repository. There are occasional pull requests, but nothing regular. Most pull requests are translations which since recently are pulled from crowdin.com. This should be the list of contributors since Nov 2011: https://github.com/maxrd2/SubtitleComposer/graphs/contributors > - A plan to be in compliance with the KDE manifesto > (https://manifesto.kde.org/index.html). In particular, you'll need > to be okay moving your source code repo and other infrastructure away from > GitHub and into KDE's GitLab instance at > https://invent.kde.org. Have already created account on https://invent.kde.org/users/milinkovic. Should I create a personal repository there for the project? cheers, Mladen
Looking for Subtitle Composer sponsor
Hello everyone I'm maintainer of Subtitle Composer. It's an KF5 application to edit/create/translate/sync video subtitles. I would like to start the process of joining KDE and I need a sponsor. This was already proposed in https://phabricator.kde.org/T10034. Application project page is here: https://github.com/maxrd2/SubtitleComposer and relative ticket is here https://github.com/maxrd2/SubtitleComposer/issues/74 thanks, Mladen
D13808: Fix KMainWindow saving incorrect widget settings
maxrd2 added a comment. Events from the window system seem to be handled after normal events. http://code.qt.io/cgit/qt/qtbase.git/tree/src/platformsupport/eventdispatchers/qeventdispatcher_glib.cpp#n70 Is there a way to send the event so qt processes it as window system event? Have tried looking through code and documentation, but everything that deals with window system events is private. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D13808 To: maxrd2, #kde_applications, dfaure, elvisangelaccio, broulik, cfeck Cc: anthonyfieroni, marten, asturmlechner, wbauer, aacid, ngraham, kde-frameworks-devel, michaelh, bruns
D13808: Fix KMainWindow saving incorrect widget settings
maxrd2 added a comment. @dfaure great.. thanks INLINE COMMENTS > anthonyfieroni wrote in kmainwindow_unittest.cpp:267 > mw->setAttribute(Qt::WA_DeleteOnClose); > Then post event close or deleteLater should work KMainWindowPrivate::init() which is called from constructor already does setAttribute(Qt::WA_DeleteOnClose), so that doesnt change anything :-/ REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D13808 To: maxrd2, #kde_applications, dfaure, elvisangelaccio, broulik, cfeck Cc: anthonyfieroni, marten, asturmlechner, wbauer, aacid, ngraham, kde-frameworks-devel, michaelh, bruns
D13808: Fix KMainWindow saving incorrect widget settings
maxrd2 updated this revision to Diff 37950. maxrd2 added a comment. Rebased to master REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13808?vs=37211=37950 BRANCH fix-window-state-save REVISION DETAIL https://phabricator.kde.org/D13808 AFFECTED FILES autotests/kmainwindow_unittest.cpp autotests/kmainwindow_unittest.h To: maxrd2, #kde_applications, dfaure, elvisangelaccio, broulik, cfeck Cc: anthonyfieroni, arojas, marten, asturmlechner, wbauer, aacid, ngraham, kde-frameworks-devel, michaelh, bruns
D13808: Fix KMainWindow saving incorrect widget settings
maxrd2 added a comment. @ngraham Don't think I can. I have no commit rights. Should i revert/remove test part, as currently it doesn't test anything i believe.. it always passes. REPOSITORY R263 KXmlGui BRANCH fix-window-state-save REVISION DETAIL https://phabricator.kde.org/D13808 To: maxrd2, #kde_applications, dfaure, elvisangelaccio, broulik, cfeck Cc: arojas, marten, asturmlechner, wbauer, aacid, ngraham, kde-frameworks-devel, michaelh, bruns
D13808: Fix KMainWindow saving incorrect widget settings
maxrd2 added inline comments.
INLINE COMMENTS
> broulik wrote in kmainwindow_unittest.cpp:267
> `mw->deleteLater()`?
Retried with all of these... none of them causes the failure, only closing the
window manually cause it
QApplication::postEvent(mw, new QDeferredDeleteEvent); // qpa/window manager
sends this one.. with spontaneous flag tho
QApplication::postEvent(mw, new QCloseEvent); // this one does absolutely
nothing
QTimer::singleShot(1000, [&](){ QApplication::sendEvent(mw, new
QDeferredDeleteEvent); });
mw->close();
QTimer::singleShot(1000, [&](){ mw->close(); });
mw->deleteLater();
REPOSITORY
R263 KXmlGui
BRANCH
fix-window-state-save
REVISION DETAIL
https://phabricator.kde.org/D13808
To: maxrd2, #kde_applications, dfaure, elvisangelaccio, broulik, cfeck
Cc: asturmlechner, wbauer, aacid, ngraham, kde-frameworks-devel, michaelh, bruns
D13808: Fix KMainWindow saving incorrect widget settings
maxrd2 updated this revision to Diff 37211. maxrd2 added a comment. Clened up test code. Replaced isVisible() with isHidden() test to match KMainWindow's condition. REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13808?vs=37131=37211 BRANCH fix-window-state-save REVISION DETAIL https://phabricator.kde.org/D13808 AFFECTED FILES autotests/kmainwindow_unittest.cpp autotests/kmainwindow_unittest.h src/kmainwindow.cpp To: maxrd2, #kde_applications, dfaure, elvisangelaccio, broulik, cfeck Cc: asturmlechner, wbauer, aacid, ngraham, kde-frameworks-devel, michaelh, bruns
D13808: Fix KMainWindow saving incorrect widget settings
maxrd2 added inline comments. INLINE COMMENTS > broulik wrote in kmainwindow_unittest.cpp:267 > `mw->deleteLater()`? tried it too... will retry all of them again with isHidden() > broulik wrote in kmainwindow_unittest.cpp:278 > `QCOMPARE(mw->m-dock->isVisible(), true)` mmm.. sorry i was supposed to use isHidden() test here, isVisible() is not the opposite will change to QCOMPARE(mw->m-dock->isHidden(), false) REPOSITORY R263 KXmlGui BRANCH fix-window-state-save REVISION DETAIL https://phabricator.kde.org/D13808 To: maxrd2, #kde_applications, dfaure, elvisangelaccio, broulik, cfeck Cc: wbauer, aacid, ngraham, kde-frameworks-devel, michaelh, bruns
D13808: Fix KMainWindow saving incorrect widget settings
maxrd2 added a comment. Relative Qt Bug is here: https://bugreports.qt.io/browse/QTBUG-69277 Seems it's not their bug. And Qt guy commented there with: > ... You should, however, not save the window layout anymore then, because after closeEvent() any other widgets or child windows could also be gone already... REPOSITORY R263 KXmlGui BRANCH fix-window-state-save REVISION DETAIL https://phabricator.kde.org/D13808 To: maxrd2, #kde_applications, dfaure, elvisangelaccio, broulik, cfeck Cc: wbauer, aacid, ngraham, kde-frameworks-devel, michaelh, bruns
D13808: Fix KMainWindow saving incorrect widget settings
maxrd2 added a comment.
Thank you! QEventLoop and creating window with new operator did it. Now the
only problem is that no matter how i close the window from code it's not
reproducing behavior. Only closing the window manually through window manager
works.
Have tried:
QApplication::postEvent(mw, new QCloseEvent); // this one does absolutely
nothing
QApplication::postEvent(mw, new QDeferredDeleteEvent);
QTimer::singleShot(1000, [&](){ QApplication::sendEvent(mw, new
QDeferredDeleteEvent); });
mv.close();
QTimer::singleShot(1000, [&](){ mv.close(); });
The close event from window manager is QDeferredDeleteEvent and has
spontaneous flag, i didn't notice any other differences in debugger. Any ideas?
REPOSITORY
R263 KXmlGui
BRANCH
fix-window-state-save
REVISION DETAIL
https://phabricator.kde.org/D13808
To: maxrd2, #kde_applications, dfaure, elvisangelaccio, broulik, cfeck
Cc: wbauer, aacid, ngraham, kde-frameworks-devel, michaelh, bruns
D13808: Fix KMainWindow saving incorrect widget settings
maxrd2 updated this revision to Diff 37131. maxrd2 added a comment. Added event loop to test and replicated wanted KMainWindow behavior. REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13808?vs=36973=37131 BRANCH fix-window-state-save REVISION DETAIL https://phabricator.kde.org/D13808 AFFECTED FILES autotests/kmainwindow_unittest.cpp autotests/kmainwindow_unittest.h src/kmainwindow.cpp To: maxrd2, #kde_applications, dfaure, elvisangelaccio, broulik, cfeck Cc: wbauer, aacid, ngraham, kde-frameworks-devel, michaelh, bruns
D13808: Fix KMainWindow saving incorrect widget settings
maxrd2 added a comment. Have tried doing QApplication::processEvents() and QApplication::sendPostedEvents(), between main window instances... didnt change Have removed mw.close() and clicked close buttons manually... didnt change Then have started all three in separate process using QProcess and hack to main, and just now have figured that mw is supposed to be deleted during close... not sooner like it's happening now. Will change them to be created with new, make it not work and update. REPOSITORY R263 KXmlGui BRANCH fix-window-state-save REVISION DETAIL https://phabricator.kde.org/D13808 To: maxrd2, #kde_applications, dfaure, elvisangelaccio, broulik, cfeck Cc: wbauer, aacid, ngraham, kde-frameworks-devel, michaelh, bruns
D13808: Fix KMainWindow saving incorrect widget settings
maxrd2 added a comment. QTEST_MAIN already provides Application and event loop REPOSITORY R263 KXmlGui BRANCH fix-window-state-save REVISION DETAIL https://phabricator.kde.org/D13808 To: maxrd2, #kde_applications, dfaure, elvisangelaccio, broulik, cfeck Cc: wbauer, aacid, ngraham, kde-frameworks-devel, michaelh, bruns
D13808: Fix KMainWindow saving incorrect widget settings
maxrd2 added a comment. Unit test is there... and it passes... always... with or without the kmainwindow.cpp patch :-/ Is there some simpler way to initialize/kill QApplication for each mainwindow creation/deletion, other than adding new test that uses QTEST_APPLESS_MAIN instead of QTEST_MAIN? REPOSITORY R263 KXmlGui BRANCH fix-window-state-save REVISION DETAIL https://phabricator.kde.org/D13808 To: maxrd2, #kde_applications, dfaure, elvisangelaccio, broulik, cfeck Cc: wbauer, aacid, ngraham, kde-frameworks-devel, michaelh, bruns
D13808: Fix KMainWindow saving incorrect widget settings
maxrd2 updated this revision to Diff 36973. maxrd2 added a comment. Added unit test REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13808?vs=36938=36973 BRANCH fix-window-state-save REVISION DETAIL https://phabricator.kde.org/D13808 AFFECTED FILES autotests/kmainwindow_unittest.cpp autotests/kmainwindow_unittest.h src/kmainwindow.cpp To: maxrd2, #kde_applications, dfaure, elvisangelaccio, broulik, cfeck Cc: wbauer, aacid, ngraham, kde-frameworks-devel, michaelh, bruns
D13808: Fix KMainWindow saving incorrect widget settings
maxrd2 added a comment. The change in qt affects when the window close event is handled in queue, it didn't change when it is fired. With qt 5.11.1 child widgets get destroyed a bit sooner, but it's still gets triggered by same close event - i think that stayed like it always was. Also KMainWindow code is made to autosave settings (if not disabled) every time some relevant widget changes, so am pretty sure that this patch won't ever cause it to save incorrect settings. Window/widget visibility and size is unlikely to change by user after they click to close window. However to be 100% sure will submit the test. REPOSITORY R263 KXmlGui BRANCH fix-window-state-save REVISION DETAIL https://phabricator.kde.org/D13808 To: maxrd2, #kde_applications, dfaure, elvisangelaccio, broulik, cfeck Cc: wbauer, aacid, ngraham, kde-frameworks-devel, michaelh, bruns
D13808: Fix KMainWindow saving incorrect widget settings
maxrd2 added a comment. Relative bug is here https://bugs.kde.org/show_bug.cgi?id=395988 REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D13808 To: maxrd2 Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13808: Fix KMainWindow saving incorrect widget settings
maxrd2 updated this revision to Diff 36938. maxrd2 added a comment. Cleaned up indentation. REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13808?vs=36937=36938 BRANCH fix-window-state-save REVISION DETAIL https://phabricator.kde.org/D13808 AFFECTED FILES src/kmainwindow.cpp To: maxrd2 Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13808: Fix KMainWindow saving incorrect widget settings
maxrd2 created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. maxrd2 requested review of this revision. REVISION SUMMARY BUG: 395988 In certain cases KMainWindow::saveMainWindowSettings() could have been called after mainwindow started destroying itself. Window settings would be saved with incorrect child widget states. e.g. some widgets would be saved as hidden even if they were visible before destroying REPOSITORY R263 KXmlGui BRANCH fix-window-state-save REVISION DETAIL https://phabricator.kde.org/D13808 AFFECTED FILES src/kmainwindow.cpp To: maxrd2 Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D7648: Fix ksysguard not starting on plasmoid click
maxrd2 added a comment. In https://phabricator.kde.org/D7648#142638, @davidedmundson wrote: > Thanks, but do you know why the apps datasource doesn't have that entry after a while? I've managed to get some more insight into original problem. It seems that after some system updates, desktop database gets updated, and that triggers a bunch of onSourcesChanged+onSourcesRemoved events, followed by a bunch onSourcesChanged+onSourceAdded events. Since I'm on rolling distro i get updates very frequently and this problem happens to me pretty frequently. After .desktop database is updated these events are fired on 'apps' dataengine: bunch of events for various .desktop files Sep 08 00:44:19 onSourcesChanged() onSourceDisconnected() org.kde.ksysguard.desktop onConnectedSourcesChanged() onSourceRemoved() org.kde.ksysguard.desktop bunch of events for various .desktop files Sep 08 00:47:01 onSourceAdded() org.kde.ksysguard.desktop bunch of events for various .desktop files Sep 08 00:47:43 onSourceRemoved() org.kde.ksysguard.desktop bunch of events for various .desktop files Sep 08 00:49:54 onSourceAdded() org.kde.ksysguard.desktop bunch of events for various .desktop files No onSourceConnected() event was fired for "org.kde.ksysguard.desktop" after it has been disconnected -> removed -> added -> removed -> added. It wasn't connected to datasource again after it was updated and re-added and thus apps.data["org.kde.ksysguard.desktop"] became undefined. I can look into fixing/changing apps dataengine and making it re-connect "lost" sources if that is desired. Is that supposed to happen automatically or is qml script supposed to re-connect "lost" sources during onSourceAdded event? REPOSITORY R114 Plasma Addons BRANCH launch-change REVISION DETAIL https://phabricator.kde.org/D7648 To: maxrd2, #plasma, davidedmundson Cc: #frameworks, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7676: Added openService() method to KRunProxy
maxrd2 added a comment. In https://phabricator.kde.org/D7676#143033, @broulik wrote: > Well it is now "openService" calling "runApplication", that's inconsistent isn't it Yes, but it will start services that have Exec line though. Should i just rename the method to "openApplication" or "runApplication" ? Adding something like this wont change much it seems. if(!service->isApplication()) KRun::runService(*service, QList(), nullptr) != 0; REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D7676 To: maxrd2, davidedmundson Cc: broulik, #frameworks
D7676: Added openService() method to KRunProxy
maxrd2 updated this revision to Diff 19173. maxrd2 marked an inline comment as done. maxrd2 added a comment. Removed service->isApplication() check, improved method description. REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7676?vs=19138=19173 BRANCH runproxy_openservice REVISION DETAIL https://phabricator.kde.org/D7676 AFFECTED FILES src/qmlcontrols/kioplugin/krunproxy.cpp src/qmlcontrols/kioplugin/krunproxy.h To: maxrd2, davidedmundson Cc: broulik, #frameworks
D7648: Fix ksysguard not starting on plasmoid click
maxrd2 added a comment. I don't have full developer account so i can't land this one. It also needs https://phabricator.kde.org/D7676 for this to work. REPOSITORY R114 Plasma Addons BRANCH launch-change REVISION DETAIL https://phabricator.kde.org/D7648 To: maxrd2, #plasma, davidedmundson Cc: #frameworks, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7676: Added openService() method to KRunProxy
maxrd2 added inline comments.
INLINE COMMENTS
> krunproxy.cpp:48
> KService::Ptr service = KService::serviceByDesktopPath(filePath);
> return KRun::runService(*service, QList(), nullptr) != 0;
> } else {
While I'm at it should i also change to runApplication() here?
> krunproxy.cpp:57
> +KService::Ptr service = KService::serviceByDesktopName(serviceName);
> +if(service && service->isApplication())
> +return KRun::runApplication(*service, QList(), nullptr) != 0;
Am not sure if service->isApplication() check here is needed... can someone
confirm please?
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D7676
To: maxrd2, davidedmundson
Cc: broulik, #frameworks
D7648: Fix ksysguard not starting on plasmoid click
maxrd2 added a dependency: D7676: Added openService() method to KRunProxy. REPOSITORY R114 Plasma Addons BRANCH launch-change REVISION DETAIL https://phabricator.kde.org/D7648 To: maxrd2, #plasma, davidedmundson Cc: #frameworks, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7676: Added openService() method to KRunProxy
maxrd2 added a dependent revision: D7648: Fix ksysguard not starting on plasmoid click. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D7676 To: maxrd2, davidedmundson Cc: broulik, #frameworks
D7676: Added openService() method to KRunProxy
maxrd2 added a comment. Am not sure whether if( && service->isApplication()) is needed. While I'm at it should i replace runService() with runApplication() inside inside openUrl() method? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D7676 To: maxrd2, davidedmundson Cc: broulik, #frameworks
D7676: Added openService() method to KRunProxy
maxrd2 updated this revision to Diff 19138. maxrd2 added a comment. Replaced runService() call with runApplication() REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7676?vs=19137=19138 BRANCH runproxy_openservice REVISION DETAIL https://phabricator.kde.org/D7676 AFFECTED FILES src/qmlcontrols/kioplugin/krunproxy.cpp src/qmlcontrols/kioplugin/krunproxy.h To: maxrd2, davidedmundson Cc: broulik, #frameworks
D7648: Fix ksysguard not starting on plasmoid click
maxrd2 added a comment. There it goes... updated the qml and added KRunProxy changes here: https://phabricator.kde.org/D7676 REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D7648 To: maxrd2, #plasma Cc: #frameworks, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7676: Added openService() method to KRunProxy
maxrd2 added a reviewer: davidedmundson. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D7676 To: maxrd2, davidedmundson Cc: #frameworks
D7676: Added openService() method to KRunProxy
maxrd2 created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Added openService() method to KRunProxy so plasmoids can start applications without needing to use openUrl() and "apps" data source. REPOSITORY R296 KDeclarative BRANCH runproxy_openservice REVISION DETAIL https://phabricator.kde.org/D7676 AFFECTED FILES src/qmlcontrols/kioplugin/krunproxy.cpp src/qmlcontrols/kioplugin/krunproxy.h To: maxrd2 Cc: #frameworks
D7648: Fix ksysguard not starting on plasmoid click
maxrd2 updated this revision to Diff 19136. maxrd2 added a comment. Plasmoid uses KRun::openService() to launch ksysguard REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7648?vs=19134=19136 BRANCH launch-change REVISION DETAIL https://phabricator.kde.org/D7648 AFFECTED FILES applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml To: maxrd2, #plasma Cc: #frameworks, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7648: Fix ksysguard not starting on plasmoid click
maxrd2 updated this revision to Diff 19134. maxrd2 edited the summary of this revision. maxrd2 added a comment. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. Added KRun::openService() method REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7648?vs=19076=19134 BRANCH runproxy_openservice REVISION DETAIL https://phabricator.kde.org/D7648 AFFECTED FILES src/qmlcontrols/kioplugin/krunproxy.cpp src/qmlcontrols/kioplugin/krunproxy.h To: maxrd2, #plasma Cc: #frameworks, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
Re: Review Request 123601: Fix ambiguous shortcuts error message in applications caused by duplicate entries in QListQKeySequence
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123601/ --- (Updated May 3, 2015, 2:46 p.m.) Review request for KDE Frameworks. Bugs: 343665 https://bugs.kde.org/show_bug.cgi?id=343665 Repository: kxmlgui Description (updated) --- After customizing shortcut with KShortcutsDialog it prepends Primary and Alternate QKeySequence to QListQKeySequence without removing old QKeySequences. QListQKeySequence after awhile becomes a long list of duplicate QKeySequence and those cannot be removed without editing .rc file. Pressing keyboard shortcuts in applications shows Ambiguous Shortcut error. This patch removes all QKeySequences in QList except first two, which are only that are editable from KShortcutsDialog. Diffs - src/kactioncollection.cpp 9c45725 src/kxmlguifactory.cpp a4305a4 Diff: https://git.reviewboard.kde.org/r/123601/diff/ Testing --- Tested most of KDE applications and it solves the issue, keyboard shortcuts work just fine and annoying error message is no more. Thanks, Mladen Milinkovic ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
