D28045: Lua: add # as additional deliminator to activate auto-completion with `#something`
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH lua (branched from master) REVISION DETAIL https://phabricator.kde.org/D28045 AFFECTED FILES data/syntax/lua.xml To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D28044: C: remove ' as digit separator
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY This is not in C standard, but only in C++ REPOSITORY R216 Syntax Highlighting BRANCH c (branched from master) REVISION DETAIL https://phabricator.kde.org/D28044 AFFECTED FILES data/syntax/c.xml To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D27714: C++: constinit keyword and std::format syntax for strings. Improvement printf format.
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH cpp (branched from master) REVISION DETAIL https://phabricator.kde.org/D27714 AFFECTED FILES autotests/folding/highlight.cpp.fold autotests/html/highlight.cpp.html autotests/input/highlight.cpp autotests/reference/highlight.cpp.ref data/syntax/isocpp.xml To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D24939: Meson: more built-in functions and add built-in member functions
This revision was automatically updated to reflect the committed changes. Closed by commit R216:9181ad6fedae: Meson: more built-in functions and add built-in member functions (authored by jpoelen). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24939?vs=68727=68838#toc REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24939?vs=68727=68838 REVISION DETAIL https://phabricator.kde.org/D24939 AFFECTED FILES autotests/folding/meson.build.fold autotests/html/meson.build.html autotests/input/meson.build autotests/reference/meson.build.ref data/syntax/meson.xml To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D24939: Meson: more built-in functions and add built-in member functions
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH meson (branched from master) REVISION DETAIL https://phabricator.kde.org/D24939 AFFECTED FILES autotests/folding/meson.build.fold autotests/html/meson.build.html autotests/input/meson.build autotests/reference/meson.build.ref data/syntax/meson.xml To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D24578: Meson: Add a comment section for comment/uncomment with Kate
This revision was automatically updated to reflect the committed changes. Closed by commit R216:1371441ef57b: Meson: Add a comment section for comment/uncomment with Kate (authored by jpoelen). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24578?vs=67758=67823#toc REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24578?vs=67758=67823 REVISION DETAIL https://phabricator.kde.org/D24578 AFFECTED FILES data/syntax/meson.xml To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D24578: Meson: Add a comment section for comment/uncomment with Kate
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH meson (branched from master) REVISION DETAIL https://phabricator.kde.org/D24578 AFFECTED FILES data/syntax/meson.xml To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D24326: Add syntax highlighting for RenPy (.rpy)
This revision was automatically updated to reflect the committed changes. Closed by commit R216:4e278a1c3e47: Add syntax highlighting for RenPy (.rpy) (authored by jpoelen). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24326?vs=67235=67358 REVISION DETAIL https://phabricator.kde.org/D24326 AFFECTED FILES autotests/folding/highlight.rpy.fold autotests/html/highlight.rpy.html autotests/input/highlight.rpy autotests/reference/highlight.rpy.ref data/syntax/renpy.xml To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D24326: Add syntax highlighting for RenPy (.rpy)
jpoelen updated this revision to Diff 67235. jpoelen added a comment. - Renpy: folding sensitive to indentation REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24326?vs=67094=67235 BRANCH renpy (branched from master) REVISION DETAIL https://phabricator.kde.org/D24326 AFFECTED FILES autotests/folding/highlight.rpy.fold autotests/html/highlight.rpy.html autotests/input/highlight.rpy autotests/reference/highlight.rpy.ref data/syntax/renpy.xml To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D24326: Add syntax highlighting for RenPy (.rpy)
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY BUG: 381547 REPOSITORY R216 Syntax Highlighting BRANCH renpy (branched from master) REVISION DETAIL https://phabricator.kde.org/D24326 AFFECTED FILES autotests/folding/highlight.rpy.fold autotests/html/highlight.rpy.html autotests/input/highlight.rpy autotests/reference/highlight.rpy.ref data/syntax/renpy.xml To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D24179: Fix skipOffset with dynamic RegExpr
This revision was automatically updated to reflect the committed changes. Closed by commit R216:d6b1e02ad4da: Fix skipOffset with dynamic RegExpr (authored by jpoelen). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24179?vs=66788=66928#toc REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24179?vs=66788=66928 REVISION DETAIL https://phabricator.kde.org/D24179 AFFECTED FILES autotests/folding/d399388_dynamic_RegExpr.dyInclRl.fold autotests/html/d399388_dynamic_RegExpr.dyInclRl.html autotests/input/d399388_dynamic_RegExpr.dyInclRl autotests/input/syntax/d399388_dynamic_RegExpr.xml autotests/reference/d399388_dynamic_RegExpr.dyInclRl.ref src/lib/rule.cpp To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D24179: Fix skipOffset with dynamic RegExpr
jpoelen updated this revision to Diff 66788. jpoelen added a comment. - add a comment REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24179?vs=66724=66788 BRANCH d399388 (branched from master) REVISION DETAIL https://phabricator.kde.org/D24179 AFFECTED FILES autotests/folding/d399388_dynamic_RegExpr.dyInclRl.fold autotests/html/d399388_dynamic_RegExpr.dyInclRl.html autotests/input/d399388_dynamic_RegExpr.dyInclRl autotests/input/syntax/d399388_dynamic_RegExpr.xml autotests/reference/d399388_dynamic_RegExpr.dyInclRl.ref src/lib/rule.cpp To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D24180: Jam: fix identifier in a SubRule
This revision was automatically updated to reflect the committed changes. Closed by commit R216:c409eb751b91: Jam: fix identifier in a SubRule (authored by jpoelen). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24180?vs=66725=66789 REVISION DETAIL https://phabricator.kde.org/D24180 AFFECTED FILES autotests/folding/Jamroot.fold autotests/html/Jamroot.html autotests/input/Jamroot autotests/reference/Jamroot.ref data/syntax/jam.xml To: jpoelen, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, sars, dhaumann
D24180: Jam: fix identifier in a SubRule
jpoelen created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. jpoelen requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH jam_check_ident (branched from master) REVISION DETAIL https://phabricator.kde.org/D24180 AFFECTED FILES autotests/folding/Jamroot.fold autotests/html/Jamroot.html autotests/input/Jamroot autotests/reference/Jamroot.ref data/syntax/jam.xml To: jpoelen Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D24179: Fix skipOffset with dynamic RegExpr
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY The pattern used depends on the previous contexts so skipOffset cannot be computed with a dynamic regex. BUG: 399388 REPOSITORY R216 Syntax Highlighting BRANCH d399388 (branched from master) REVISION DETAIL https://phabricator.kde.org/D24179 AFFECTED FILES autotests/folding/d399388_dynamic_RegExpr.dyInclRl.fold autotests/html/d399388_dynamic_RegExpr.dyInclRl.html autotests/input/d399388_dynamic_RegExpr.dyInclRl autotests/input/syntax/d399388_dynamic_RegExpr.xml autotests/reference/d399388_dynamic_RegExpr.dyInclRl.ref src/lib/rule.cpp To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D24176: Add syntax definition for Perl6
This revision was automatically updated to reflect the committed changes. Closed by commit R216:5e0343812c22: Add syntax definition for Perl6 (authored by jpoelen). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24176?vs=66720=66721#toc REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24176?vs=66720=66721 REVISION DETAIL https://phabricator.kde.org/D24176 AFFECTED FILES autotests/folding/highlight.pl6.fold autotests/html/highlight.pl6.html autotests/input/highlight.pl6 autotests/reference/highlight.pl6.ref data/syntax/perl.xml data/syntax/perl6.xml To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D24176: Add syntax definition for Perl6
jpoelen updated this revision to Diff 66720. jpoelen added a comment. Perl: increase version... over and over again :) REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24176?vs=66718=66720 BRANCH perl6 (branched from master) REVISION DETAIL https://phabricator.kde.org/D24176 AFFECTED FILES autotests/folding/highlight.pl6.fold autotests/html/highlight.pl6.html autotests/input/highlight.pl6 autotests/reference/highlight.pl6.ref data/syntax/perl.xml data/syntax/perl6.xml To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D24176: Add syntax definition for Perl6
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY BUG: 392468 REPOSITORY R216 Syntax Highlighting BRANCH perl6 (branched from master) REVISION DETAIL https://phabricator.kde.org/D24176 AFFECTED FILES autotests/folding/highlight.pl6.fold autotests/html/highlight.pl6.html autotests/input/highlight.pl6 autotests/reference/highlight.pl6.ref data/syntax/perl.xml data/syntax/perl6.xml To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D23513: Gettext: Add "Translated String" style and spellChecking attribute
This revision was automatically updated to reflect the committed changes. Closed by commit R216:0f150cafac4b: Gettext: Add Translated String style and spellChecking attribute (authored by jpoelen). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23513?vs=64782=64783#toc REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23513?vs=64782=64783 REVISION DETAIL https://phabricator.kde.org/D23513 AFFECTED FILES autotests/html/highlight.po.html autotests/reference/highlight.po.ref data/syntax/gettext.xml To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D23513: Gettext: Add "Translated String" style and spellChecking attribute
jpoelen updated this revision to Diff 64782. jpoelen added a comment. - increase version REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23513?vs=64775=64782 BRANCH po_spellcheck (branched from master) REVISION DETAIL https://phabricator.kde.org/D23513 AFFECTED FILES autotests/html/highlight.po.html autotests/reference/highlight.po.ref data/syntax/gettext.xml To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D23513: Gettext: Add "Translated String" style and spellChecking attribute
jpoelen edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23513 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D23513: Gettext: Add "Translated String" style and spellChecking attribute
jpoelen edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23513 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D23513: Gettext: Add "Translated String" style and spellChecking attribute
jpoelen created this revision.
jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
jpoelen added projects: Kate, Frameworks.
jpoelen requested review of this revision.
REVISION SUMMARY
New style ("Translated String") for a string associated with msgstr and
msgstr_plural. Normal String and some other styles are now spellChecking=false.
BUG: 392612
REPOSITORY
R216 Syntax Highlighting
BRANCH
po_spellcheck (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D23513
AFFECTED FILES
autotests/html/highlight.po.html
autotests/reference/highlight.po.ref
data/syntax/gettext.xml
To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh,
ngraham, bruns, demsking, cullmann, sars, dhaumann
D23416: Highlighting indexer: check kateversion
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY Checks that files using are in version 5.53 and that contexts do not reference a higher version. The output looks like this: $ ninja data/index.katesyntax ".../data/syntax/markdown.xml" depends on a language in version 5.53. Please, increase kateversion. ".../data/syntax/djangotemplate.xml" depends on a language in version 5.0. Please, increase kateversion. ... REPOSITORY R216 Syntax Highlighting BRANCH check_kateversion (branched from master) REVISION DETAIL https://phabricator.kde.org/D23416 AFFECTED FILES data/syntax/coffee.xml data/syntax/djangotemplate.xml data/syntax/elixir.xml data/syntax/haskell.xml data/syntax/html.xml data/syntax/jira.xml data/syntax/mako.xml data/syntax/markdown.xml data/syntax/mediawiki.xml data/syntax/php.xml data/syntax/rmarkdown.xml src/indexer/katehighlightingindexer.cpp To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D23312: JSP: support of
This revision was automatically updated to reflect the committed changes. Closed by commit R216:433e5d85979c: JSP: support of script and style ; use IncludeRule ##Java (authored by jpoelen). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23312?vs=64183=64259#toc REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23312?vs=64183=64259 REVISION DETAIL https://phabricator.kde.org/D23312 AFFECTED FILES autotests/folding/highlight.jsp.fold autotests/html/highlight.jsp.html autotests/input/highlight.jsp autotests/reference/highlight.jsp.ref data/syntax/jsp.xml To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D23312: JSP: support of
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY BUG: 345003 REPOSITORY R216 Syntax Highlighting BRANCH jsp (branched from master) REVISION DETAIL https://phabricator.kde.org/D23312 AFFECTED FILES autotests/folding/highlight.jsp.fold autotests/html/highlight.jsp.html autotests/input/highlight.jsp autotests/reference/highlight.jsp.ref data/syntax/jsp.xml To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D23278: LESS: import CSS keywords, new highlighting and some improvements
This revision was automatically updated to reflect the committed changes. Closed by commit R216:63719f49867b: LESS: import CSS keywords, new highlighting and some improvements (authored by jpoelen). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23278?vs=64078=64182#toc REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23278?vs=64078=64182 REVISION DETAIL https://phabricator.kde.org/D23278 AFFECTED FILES autotests/html/highlight.less.html autotests/reference/highlight.less.ref data/syntax/less.xml To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D23278: LESS: import CSS keywords, new highlighting and some improvements
jpoelen added a comment. The other files that use the include statement are also in version 5.53. If highlightingindexer adds a version check, it is also necessary to check that the included files are of the same or lower version. Ideally, this should also be done for IncludeRules. I also note 2 additional changes that can be verified: - caseinsensitive WordDetect -> 5.44 - '!' with context and fallthroughContext -> 5.40 REPOSITORY R216 Syntax Highlighting BRANCH less (branched from master) REVISION DETAIL https://phabricator.kde.org/D23278 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D23278: LESS: import CSS keywords, new highlighting and some improvements
jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23278 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D23278: LESS: import CSS keywords, new highlighting and some improvements
jpoelen created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. jpoelen requested review of this revision. REVISION SUMMARY New highlighting (same as CSS): - Value Keyword - Color - Number - Unit Improvements and fixes (same as CSS): - number in scientific notation: `12.3e3` - fix color (`#aabbccaabbcc` does not exist) - keywords: use ...##CSS rather than an individual lists REPOSITORY R216 Syntax Highlighting BRANCH less (branched from master) REVISION DETAIL https://phabricator.kde.org/D23278 AFFECTED FILES autotests/html/highlight.less.html autotests/reference/highlight.less.ref data/syntax/less.xml To: jpoelen Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D23245: New syntax: SASS. Some fixes for CSS and SCSS
This revision was automatically updated to reflect the committed changes. Closed by commit R216:0edc0cb01ab7: New syntax: SASS. Some fixes for CSS and SCSS (authored by jpoelen). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23245?vs=63987=64075#toc REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23245?vs=63987=64075 REVISION DETAIL https://phabricator.kde.org/D23245 AFFECTED FILES autotests/folding/highlight.sass.fold autotests/folding/highlight.scss.fold autotests/html/highlight.css.html autotests/html/highlight.sass.html autotests/html/highlight.scss.html autotests/html/review128925-1.scss.html autotests/input/highlight.sass autotests/input/highlight.scss autotests/reference/highlight.css.ref autotests/reference/highlight.sass.ref autotests/reference/highlight.scss.ref autotests/reference/review128925-1.scss.ref data/syntax/css.xml data/syntax/sass.xml data/syntax/scss.xml To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D23245: New syntax: SASS. Some fixes for CSS and SCSS
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY CSS, SCSS (CSS4): - number in scientific notation: `12.3e3` - hexadecimal rgba: `#fffa` and `#ffaa` - new units: cap,ic,lh,rlh,vi,vb,vmin,vmax,Q,in,dpi,dpcm,dppx,x - remove unknown unit: vm - new pseudo selector: matches SCSS: - fix nested function - fix `...` as operator - fix interpolation as property SASS: - new syntax BUG: 149313 REPOSITORY R216 Syntax Highlighting BRANCH sass (branched from master) REVISION DETAIL https://phabricator.kde.org/D23245 AFFECTED FILES autotests/folding/highlight.sass.fold autotests/folding/highlight.scss.fold autotests/html/highlight.css.html autotests/html/highlight.sass.html autotests/html/highlight.scss.html autotests/html/review128925-1.scss.html autotests/input/highlight.sass autotests/input/highlight.scss autotests/reference/highlight.css.ref autotests/reference/highlight.sass.ref autotests/reference/highlight.scss.ref autotests/reference/review128925-1.scss.ref data/syntax/css.xml data/syntax/sass.xml data/syntax/scss.xml To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D23195: SCSS: fix interpolation (#{...}) and add the Interpolation color
jpoelen created this revision.
jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
jpoelen added projects: Kate, Frameworks.
jpoelen requested review of this revision.
REVISION SUMMARY
Only interpolation with variable (`#{$...}`) and beginning of the string
(`"${...}..."`) was highlighted.
REPOSITORY
R216 Syntax Highlighting
BRANCH
fix_scss_interpolation (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D23195
AFFECTED FILES
autotests/folding/highlight.scss.fold
autotests/html/highlight.scss.html
autotests/html/review128925-2.scss.html
autotests/input/highlight.scss
autotests/reference/highlight.scss.ref
autotests/reference/review128925-2.scss.ref
data/syntax/scss.xml
To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham,
bruns, demsking, cullmann, sars, dhaumann
D23135: Gettext: fix "previous untranslated string" and other improvements/fixes
jpoelen added a comment. If it is better not to have a hard-coded color, wouldn't it be better to remove them once and for all? Without necessarily incrementing the version. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23135 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D14632: keyword rule: Spport for keywords inclusion from another language/file
jpoelen added a comment. I don't think using the original word delimiters is a good thing. Let's imagine that c.xml lists the functions of the libc and a language that allows them to be used as `ffi.C.printf` (luajit for the curious). The separators of the 2 languages are not the same and `puts'plop'` works for one, but not for the other. If we rely on the C delimiters, it will not work anymore. I think we can find other examples and perhaps counter-examples. Currently, if we want to keep the word delimiters, we can always create a context in the referenced file (or another syntax file) and make an `IncludeRule`. It's ugly, the current checker complains if the context is not used, but I don't think that happens in nature. From what I see, the languages that share word lists are either syntactically similar or radically different. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14632 To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann, vkrause Cc: kwrite-devel, vkrause, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D23134: fix additionalDeliminator attribute
jpoelen updated this revision to Diff 63771. jpoelen added a comment. - add unit test REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23134?vs=63683=63771 BRANCH fix_wordDelimiters (branched from master) REVISION DETAIL https://phabricator.kde.org/D23134 AFFECTED FILES autotests/folding/fix_d399348.addDelim.fold autotests/html/fix_d399348.addDelim.html autotests/input/fix_d399348.addDelim autotests/input/syntax/fix_d399348_additional_deliminators.xml autotests/reference/fix_d399348.addDelim.ref src/lib/rule.cpp To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D23137: C++: contracts are not in C++20
jpoelen updated this revision to Diff 63689. jpoelen added a comment. - increase version REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23137?vs=63686=63689 BRANCH cpp_no_contract (branched from master) REVISION DETAIL https://phabricator.kde.org/D23137 AFFECTED FILES autotests/folding/highlight.cpp.fold autotests/html/highlight.cpp.html autotests/input/highlight.cpp autotests/reference/highlight.cpp.ref data/syntax/isocpp.xml To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D23137: C++: contracts are not in C++20
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY For C ++ 23 or C ++ 26 with perhaps a syntax change REPOSITORY R216 Syntax Highlighting BRANCH cpp_no_contract (branched from master) REVISION DETAIL https://phabricator.kde.org/D23137 AFFECTED FILES autotests/folding/highlight.cpp.fold autotests/html/highlight.cpp.html autotests/input/highlight.cpp autotests/reference/highlight.cpp.ref data/syntax/isocpp.xml To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D23136: Jam: Fix local with variable without initilisation and highlight SubRule
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH fix_jam (branched from master) REVISION DETAIL https://phabricator.kde.org/D23136 AFFECTED FILES autotests/folding/Jamroot.fold autotests/html/Jamroot.html autotests/input/Jamroot autotests/reference/Jamroot.ref data/syntax/jam.xml To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D23135: Gettext: fix "previous untranslated string" and other improvements/fixes
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY - fix #| (previous untranslated string) - fix hexadecimal entity - fix html tag in `a < b` - use rather than for auto-completion - string without " at the end of the line is an error - # followed by something other than " |:.," is an extension REPOSITORY R216 Syntax Highlighting BRANCH gettext (branched from master) REVISION DETAIL https://phabricator.kde.org/D23135 AFFECTED FILES autotests/folding/highlight.po.fold autotests/html/highlight.po.html autotests/input/highlight.po autotests/reference/highlight.po.ref data/syntax/gettext.xml To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D23134: fix additionalDeliminator attribute
jpoelen added a comment. I don't understand why there's so much difference in what's displayed :/ REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23134 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D23134: fix additionalDeliminator attribute
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY The initialization of the `Rule::m_wordDelimiter` cache was done before the delimiters were extracted, which can invalidate the character number. BUG: 399348 REPOSITORY R216 Syntax Highlighting BRANCH fix_wordDelimiters (branched from master) REVISION DETAIL https://phabricator.kde.org/D23134 AFFECTED FILES src/lib/rule.cpp To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D23034: implicit fallthough if there is fallthoughContext
jpoelen updated this revision to Diff 63455. jpoelen added a comment. - don't modify the *.xml files to maintain the compatibility in older versions of KF5 - langauge.xsd: accept only 1 or true for fallthrough attribute REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23034?vs=63382=63455 BRANCH auto_fallthrough (branched from master) REVISION DETAIL https://phabricator.kde.org/D23034 AFFECTED FILES data/schema/language.xsd src/lib/context.cpp To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: nibags, kwrite-devel, kde-frameworks-devel, univerz, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D23034: implicit fallthough if there is fallthoughContext
jpoelen added a comment. I will hand over the original xml files, that seems preferable to me too. I did not see `fallthrough="false"` nor `fallthrough="0"`. But after checking, `brightscript.xml` uses` fallthroughContext` twice without `fallthrough`. in my opinion, it's an oblivion with no unfortunate consequences. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23034 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: nibags, kwrite-devel, kde-frameworks-devel, univerz, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D23034: implicit fallthough if there is fallthoughContext
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY fallthrough="true" is redundant with fallthroughContext="xxx" and there is no reason to use fallthrough="false" REPOSITORY R216 Syntax Highlighting BRANCH auto_fallthrough (branched from master) REVISION DETAIL https://phabricator.kde.org/D23034 AFFECTED FILES data/syntax/4dos.xml data/syntax/actionscript.xml data/syntax/ahk.xml data/syntax/ample.xml data/syntax/ansic89.xml data/syntax/ansys.xml data/syntax/apparmor.xml data/syntax/asciidoc.xml data/syntax/awk.xml data/syntax/bash.xml data/syntax/bibtex.xml data/syntax/brightscript.xml data/syntax/c.xml data/syntax/ccss.xml data/syntax/cg.xml data/syntax/cgis.xml data/syntax/chicken.xml data/syntax/clojure.xml data/syntax/coffee.xml data/syntax/crk.xml data/syntax/cs.xml data/syntax/css.xml data/syntax/d.xml data/syntax/djangotemplate.xml data/syntax/ferite.xml data/syntax/fgl-4gl.xml data/syntax/fgl-per.xml data/syntax/fish.xml data/syntax/fortran-fixed.xml data/syntax/fortran-free.xml data/syntax/fsharp.xml data/syntax/glsl.xml data/syntax/grammar.xml data/syntax/groovy.xml data/syntax/html.xml data/syntax/hunspell-dat.xml data/syntax/hunspell-idx.xml data/syntax/ilerpg.xml data/syntax/isocpp.xml data/syntax/jam.xml data/syntax/java.xml data/syntax/javascript-react.xml data/syntax/javascript.xml data/syntax/jsp.xml data/syntax/kconfig.xml data/syntax/kotlin.xml data/syntax/latex.xml data/syntax/ld.xml data/syntax/less.xml data/syntax/lex.xml data/syntax/lilypond.xml data/syntax/logcat.xml data/syntax/lpc.xml data/syntax/lua.xml data/syntax/makefile.xml data/syntax/mako.xml data/syntax/mergetagtext.xml data/syntax/mup.xml data/syntax/mustache.xml data/syntax/nesc.xml data/syntax/ninja.xml data/syntax/objectivec.xml data/syntax/objectivecpp.xml data/syntax/opencl.xml data/syntax/perl.xml data/syntax/pig.xml data/syntax/pony.xml data/syntax/powershell.xml data/syntax/prolog.xml data/syntax/protobuf.xml data/syntax/puppet.xml data/syntax/python.xml data/syntax/r.xml data/syntax/rhtml.xml data/syntax/rtf.xml data/syntax/ruby.xml data/syntax/rust.xml data/syntax/scala.xml data/syntax/scheme.xml data/syntax/scss.xml data/syntax/selinux-cil.xml data/syntax/selinux-fc.xml data/syntax/selinux.xml data/syntax/sml.xml data/syntax/stan.xml data/syntax/taskjuggler.xml data/syntax/tcsh.xml data/syntax/toml.xml data/syntax/typescript-react.xml data/syntax/typescript.xml data/syntax/uscript.xml data/syntax/vala.xml data/syntax/xul.xml data/syntax/yacc.xml data/syntax/yaml.xml data/syntax/zsh.xml src/lib/context.cpp To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, univerz, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D23013: Latex: several fixes (math mode, nested verbatim, ...)
This revision was automatically updated to reflect the committed changes. Closed by commit R216:75e233dc5792: Latex: several fixes (math mode, nested verbatim, ...) (authored by jpoelen). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23013?vs=63378=63379#toc REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23013?vs=63378=63379 REVISION DETAIL https://phabricator.kde.org/D23013 AFFECTED FILES autotests/folding/example.rmd.fold autotests/folding/highlight.tex.fold autotests/folding/test.tex.fold autotests/html/highlight.tex.html autotests/html/test.tex.html autotests/input/highlight.tex autotests/input/test.tex autotests/reference/highlight.tex.ref autotests/reference/test.tex.ref autotests/syntaxrepository_test.cpp data/syntax/latex.xml To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: nibags, kde-frameworks-devel, kwrite-devel, univerz, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D23013: Latex: several fixes (math mode, nested verbatim, ...)
jpoelen edited the summary of this revision. REPOSITORY R216 Syntax Highlighting BRANCH tex (branched from master) REVISION DETAIL https://phabricator.kde.org/D23013 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: nibags, kde-frameworks-devel, kwrite-devel, univerz, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D23013: Latex: several fixes (math mode, nested verbatim, ...)
jpoelen added a comment. The 410477 did not exist when I started my modifications, I add it in the list. REPOSITORY R216 Syntax Highlighting BRANCH tex (branched from master) REVISION DETAIL https://phabricator.kde.org/D23013 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: nibags, kde-frameworks-devel, kwrite-devel, univerz, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D23013: Latex: several fixes (math mode, nested verbatim, ...)
jpoelen updated this revision to Diff 63378. jpoelen added a comment. At first, I didn't have much change. But as I broke my teeth on one of the bugs and there were some problems here and there, I armed myself with a bulldozer :D REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23013?vs=63319=63378 BRANCH tex (branched from master) REVISION DETAIL https://phabricator.kde.org/D23013 AFFECTED FILES autotests/folding/example.rmd.fold autotests/folding/highlight.tex.fold autotests/folding/test.tex.fold autotests/html/highlight.tex.html autotests/html/test.tex.html autotests/input/highlight.tex autotests/input/test.tex autotests/reference/highlight.tex.ref autotests/reference/test.tex.ref autotests/syntaxrepository_test.cpp data/syntax/latex.xml To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: nibags, kde-frameworks-devel, kwrite-devel, univerz, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D23014: Lua: fix color of end with several levels of condition and function nesting
This revision was automatically updated to reflect the committed changes. Closed by commit R216:2b06bf42be04: Lua: fix color of end with several levels of condition and function nesting (authored by jpoelen). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23014?vs=63376=63377#toc REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23014?vs=63376=63377 REVISION DETAIL https://phabricator.kde.org/D23014 AFFECTED FILES autotests/folding/highlight.lua.fold autotests/html/highlight.lua.html autotests/input/highlight.lua autotests/reference/highlight.lua.ref data/syntax/lua.xml To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kde-frameworks-devel, kwrite-devel, univerz, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D23014: Lua: fix color of end with several levels of condition and function nesting
jpoelen updated this revision to Diff 63376. jpoelen added a comment. increase the version number REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23014?vs=63320=63376 BRANCH lua (branched from master) REVISION DETAIL https://phabricator.kde.org/D23014 AFFECTED FILES autotests/folding/highlight.lua.fold autotests/html/highlight.lua.html autotests/input/highlight.lua autotests/reference/highlight.lua.ref data/syntax/lua.xml To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kde-frameworks-devel, kwrite-devel, univerz, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D23015: Highlighting indexer: all warnings are fatal
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH warning_as_error (branched from master) REVISION DETAIL https://phabricator.kde.org/D23015 AFFECTED FILES src/indexer/katehighlightingindexer.cpp To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kde-frameworks-devel, kwrite-devel, univerz, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D23014: Lua: fix color of end with several levels of condition and function nesting
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY if x then function foo() if x then end -- control (before: keyword) end -- keyword (before: control) end -- control REPOSITORY R216 Syntax Highlighting BRANCH lua (branched from master) REVISION DETAIL https://phabricator.kde.org/D23014 AFFECTED FILES autotests/folding/highlight.lua.fold autotests/html/highlight.lua.html autotests/input/highlight.lua autotests/reference/highlight.lua.ref data/syntax/lua.xml To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kde-frameworks-devel, kwrite-devel, univerz, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D23013: Latex: several fixes (math mode, nested verbatim, ...)
jpoelen created this revision.
jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
jpoelen added projects: Kate, Frameworks.
jpoelen requested review of this revision.
REVISION SUMMARY
- nested { and macro identifier with math mode
- add shortintertext, Cref, param with math env and fix providecommand
- text macro in math mode
- nested verbatim
- ...
BUG: 320303
BUG: 274440
BUG: 322081
REPOSITORY
R216 Syntax Highlighting
BRANCH
tex (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D23013
AFFECTED FILES
autotests/folding/example.rmd.fold
autotests/folding/highlight.tex.fold
autotests/folding/test.tex.fold
autotests/html/highlight.tex.html
autotests/html/test.tex.html
autotests/input/highlight.tex
autotests/input/test.tex
autotests/reference/highlight.tex.ref
autotests/reference/test.tex.ref
autotests/syntaxrepository_test.cpp
data/syntax/latex.xml
To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kde-frameworks-devel, kwrite-devel, univerz, LeGast00n, domson, michaelh,
ngraham, bruns, demsking, cullmann, sars, dhaumann
D21586: Add syntax definition for ninja build
jpoelen added a comment. After reflection (:D), I think the constraint is weak, the creation of new syntax is rare compared to the rest. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D21586 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
D21586: Add syntax definition for ninja build
This revision was automatically updated to reflect the committed changes. Closed by commit R216:a72b6b5e53ec: Add syntax definition for ninja build (authored by jpoelen). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21586?vs=59240=59421 REVISION DETAIL https://phabricator.kde.org/D21586 AFFECTED FILES autotests/folding/build.ninja.fold autotests/html/build.ninja.html autotests/input/build.ninja autotests/reference/build.ninja.ref data/syntax/ninja.xml To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
D21586: Add syntax definition for ninja build
jpoelen updated this revision to Diff 59240. jpoelen added a comment. I am confused, the generation of index.katesyntax fails because the list "variables" does not exist (there is no variable predefined in this context). We may be in a situation where a change of branch does not recompile the index file :/. I'll have to be more careful next time. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21586?vs=59154=59240 BRANCH ninja (branched from master) REVISION DETAIL https://phabricator.kde.org/D21586 AFFECTED FILES autotests/folding/build.ninja.fold autotests/html/build.ninja.html autotests/input/build.ninja autotests/reference/build.ninja.ref data/syntax/ninja.xml To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
D21587: Lua: update for Lua54 and end of function as Keyword rather than Control
This revision was automatically updated to reflect the committed changes. Closed by commit R216:602bbc7b7397: Lua: update for Lua54 and end of function as Keyword rather than Control (authored by jpoelen). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21587?vs=59155=59163 REVISION DETAIL https://phabricator.kde.org/D21587 AFFECTED FILES autotests/html/highlight.lua.html autotests/html/test.pbl.html autotests/reference/highlight.lua.ref autotests/reference/test.pbl.ref data/syntax/lua.xml To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
D21508: Jam: various improvements and fixes
This revision was automatically updated to reflect the committed changes. Closed by commit R216:6864c25f1d54: Jam: various improvements and fixes (authored by jpoelen). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21508?vs=59150=59164 REVISION DETAIL https://phabricator.kde.org/D21508 AFFECTED FILES autotests/folding/Jamroot.fold autotests/html/Jamroot.html autotests/input/Jamroot autotests/reference/Jamroot.ref data/syntax/jam.xml To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kde-frameworks-devel, kwrite-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D21585: C++: update for C++20
This revision was automatically updated to reflect the committed changes. Closed by commit R216:9ba02971123d: C++: update for C++20 (authored by jpoelen). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21585?vs=59156=59162 REVISION DETAIL https://phabricator.kde.org/D21585 AFFECTED FILES autotests/folding/highlight.cpp.fold autotests/html/highlight.cpp.html autotests/input/highlight.cpp autotests/reference/highlight.cpp.ref data/syntax/isocpp.xml To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
D21585: C++: update for C++20
jpoelen updated this revision to Diff 59156. jpoelen added a comment. oops, missing version increase REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21585?vs=59152=59156 BRANCH cpp2a (branched from master) REVISION DETAIL https://phabricator.kde.org/D21585 AFFECTED FILES autotests/folding/highlight.cpp.fold autotests/html/highlight.cpp.html autotests/input/highlight.cpp autotests/reference/highlight.cpp.ref data/syntax/isocpp.xml To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
D21587: Lua: update for Lua54 and end of function as Keyword rather than Control
jpoelen edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D21587 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
D21587: Lua: update for Lua54 and end of function as Keyword rather than Control
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Framework: Syntax Highlighting, Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY function foo() if x then end <--- Control Flow end <--- Keyword REPOSITORY R216 Syntax Highlighting BRANCH lua54 (branched from master) REVISION DETAIL https://phabricator.kde.org/D21587 AFFECTED FILES autotests/html/highlight.lua.html autotests/html/test.pbl.html autotests/reference/highlight.lua.ref autotests/reference/test.pbl.ref data/syntax/lua.xml To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
D21586: Add syntax definition for ninja build
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Framework: Syntax Highlighting, Kate, Frameworks. jpoelen requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH ninja (branched from master) REVISION DETAIL https://phabricator.kde.org/D21586 AFFECTED FILES autotests/folding/build.ninja.fold autotests/html/build.ninja.html autotests/input/build.ninja autotests/reference/build.ninja.ref data/syntax/ninja.xml To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
D21585: C++: update for C++20
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Framework: Syntax Highlighting, Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY - new attributes: assert, ensures and expects - new types: char8_t - new keywords: consteval, import, module, concept, requires, co_await, co_return, co_yield REPOSITORY R216 Syntax Highlighting BRANCH cpp2a (branched from master) REVISION DETAIL https://phabricator.kde.org/D21585 AFFECTED FILES autotests/folding/highlight.cpp.fold autotests/html/highlight.cpp.html autotests/input/highlight.cpp autotests/reference/highlight.cpp.ref data/syntax/isocpp.xml To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
D21508: Jam: various improvements and fixes
jpoelen updated this revision to Diff 59150. jpoelen added a comment. - fix module - remove hard coded color REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21508?vs=58930=59150 BRANCH fix_jam (branched from master) REVISION DETAIL https://phabricator.kde.org/D21508 AFFECTED FILES autotests/folding/Jamroot.fold autotests/html/Jamroot.html autotests/input/Jamroot autotests/reference/Jamroot.ref data/syntax/jam.xml To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kde-frameworks-devel, kwrite-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D21508: Jam: various improvements and fixes
jpoelen added a comment. I left it because it goes well with dark or light themes, but I removed it. Is the policy the same for bold, underlined and italic as for color? Because a basic applied distinction between Comment and CommentTitle seems to me preferable. I imagine not, but I would like to be sure. In any case I have to do an update because I mixed class and module :/ REPOSITORY R216 Syntax Highlighting BRANCH fix_jam (branched from master) REVISION DETAIL https://phabricator.kde.org/D21508 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kde-frameworks-devel, kwrite-devel, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D21508: Jam: various improvements and fixes
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY - fix `x=`: is a rule named `x=`, not a variable - fix `exe onx`: is a rule call, not a variable - fix `ifxxx`, `rulexxx`, etc: not keywords - fix `variable default = xxx ;` - fix keywords and operators in a condition: they must be separated by spaces - fix `on target` - fix `switch` - fix `class` and `module` - fix `for local x` - new styles: Feature and FeatureOperator for ``, `-`, `abc:abc`, `abc/abc`, `abc&` - don't use black color in Rule REPOSITORY R216 Syntax Highlighting BRANCH fix_jam (branched from master) REVISION DETAIL https://phabricator.kde.org/D21508 AFFECTED FILES autotests/folding/Jamroot.fold autotests/html/Jamroot.html autotests/input/Jamroot autotests/reference/Jamroot.ref data/syntax/jam.xml To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kde-frameworks-devel, kwrite-devel, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D21421: Tcsh: fix operators and keywords
jpoelen added a comment. OK I understand. Initially I had not changed the version number of txsh.xml and it is based on the reference in `/usr/share/org.kde.syntax-highlighting/syntax/index.katesyntax` rather than in the repository. And the fact that the versions in the index file were newer than my xml files... I had errors with highlight.fish. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D21421 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kde-frameworks-devel, kwrite-devel, gennad, bmortimer, domson, michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
D21421: Tcsh: fix operators and keywords
This revision was automatically updated to reflect the committed changes. Closed by commit R216:4d2329e3f63e: Tcsh: fix operators and keywords (authored by jpoelen). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21421?vs=58696=58742 REVISION DETAIL https://phabricator.kde.org/D21421 AFFECTED FILES autotests/folding/highlight.tcsh.fold autotests/html/highlight.tcsh.html autotests/input/highlight.tcsh autotests/reference/highlight.tcsh.ref data/syntax/tcsh.xml To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kde-frameworks-devel, kwrite-devel, gennad, bmortimer, domson, michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
D21421: Tcsh: fix operators and keywords
jpoelen added a comment. I forgot to ask about running the tests. Is it normal that system syntax files take precedence if we have an `index.katesyntax`? Currently I have to run the tests by setting the environment variable `XDG_DATA_DIRS`. REPOSITORY R216 Syntax Highlighting BRANCH fix_tcsh (branched from master) REVISION DETAIL https://phabricator.kde.org/D21421 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kde-frameworks-devel, kwrite-devel, gennad, bmortimer, domson, michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
D21421: Tcsh: fix operators and keywords
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Framework: Syntax Highlighting, Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY - missing `foreach` and `end` - fix folding with `if (expr) cmd` - missing != with `[ ... ]` - rules for arithmetic comparison - add dsControlFlow style - `[[ ... ]]` does not exists REPOSITORY R216 Syntax Highlighting BRANCH fix_tcsh (branched from master) REVISION DETAIL https://phabricator.kde.org/D21421 AFFECTED FILES autotests/folding/highlight.tcsh.fold autotests/html/highlight.tcsh.html autotests/input/highlight.tcsh autotests/reference/highlight.tcsh.ref data/syntax/tcsh.xml To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kde-frameworks-devel, kwrite-devel, gennad, bmortimer, domson, michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
D10621: Highlighting Indexer: list of suggestions
jpoelen added a comment. I agree that some rules are excessive or even false, but the last time I watched (it was several months ago now), some regexes suggested to be DetectString seemed to have writing errors (mainly `\\` count as 2 characters in xml) and some more or less useful propositions. If there has been no change at this level, it should still be checked. Actually, I came to the conclusion that the parser himself could make some changes on the fly. For example, DetectChar/Detect2Chars are specializations of DetectString and the concatenation of regexes could be automatic, which would make most checks obsolete. There would be only suggestions to turn a Regex into something else, but it is much easier using an AST rather than a very slobbery regexes. Finally, this commit will never make a complete list without false positives, especially since code reviews filter out such errors. We can abandon it. PS: this commit uses `attrToBool` as for the parser (if it has not changed) and adds 2 missing `return false`. I do not have time to take care of it at the moment. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D10621 To: jpoelen, dhaumann Cc: kwrite-devel, kde-frameworks-devel, vkrause, #framework_syntax_highlighting, dhaumann, bmortimer, hase, michaelh, genethomas, ngraham, bruns, demsking, cullmann, sars
D14632: keyword rule: Spport for keywords inclusion from another language/file
jpoelen updated this revision to Diff 42628. jpoelen added a comment. - fix the recursion detection and handling of nested included keyword lists REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14632?vs=41872=42628 BRANCH kwinclude REVISION DETAIL https://phabricator.kde.org/D14632 AFFECTED FILES autotests/syntaxrepository_test.cpp data/schema/language.xsd data/syntax/scss.xml src/indexer/katehighlightingindexer.cpp src/lib/definition.cpp src/lib/definition_p.h src/lib/keywordlist.cpp src/lib/keywordlist_p.h To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann Cc: kwrite-devel, vkrause, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D14632: keyword rule: Spport for keywords inclusion from another language/file
jpoelen added a comment. (I inadvertently edit the operators list in the previous commit) Finally, I added a parameter to `load()` and `loadHighlighting()` rather than a new function because there was a lot of code duplication. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14632 To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann Cc: kwrite-devel, vkrause, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
D14632: keyword rule: Spport for keywords inclusion from another language/file
jpoelen updated this revision to Diff 41872. jpoelen added a comment. - restore operators list - lazy load keyword lists REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14632?vs=41298=41872 BRANCH kwinclude REVISION DETAIL https://phabricator.kde.org/D14632 AFFECTED FILES data/schema/language.xsd data/syntax/scss.xml src/indexer/katehighlightingindexer.cpp src/lib/definition.cpp src/lib/definition_p.h src/lib/keywordlist.cpp src/lib/keywordlist_p.h To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann Cc: kwrite-devel, vkrause, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
D14632: keyword rule: Spport for keywords inclusion from another language/file
jpoelen added a comment. `resolveIncludeKeywords()` would then use `loadKeywords()` instead of `load()` ? This should be enough. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14632 To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann Cc: kwrite-devel, vkrause, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
D14632: keyword rule: Spport for keywords inclusion from another language/file
jpoelen added a comment. Sorry to answer so late, I had trouble logging in. I think I misinterpreted the use of `includedDefinitions()`. For me, this function lists the languages ​included by the rules and which influence the colors. While the inclusion of a keyword list has no influence here. In the case of SASS, there is no IncludeRules to CSS because small syntactic details do not allow it, it would not be logical to have CSS in the list of `includedDefinitions()`. Basically, I added `includedKeywordDefinitions()` because of a Format test that did not work. But it's true that putting it in the public interface is not a good idea. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14632 To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann Cc: kwrite-devel, vkrause, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
D14632: keyword rule: Spport for keywords inclusion from another language/file
jpoelen updated this revision to Diff 41298. jpoelen added a comment. include rule in keyword list to import those from another file REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14632?vs=39138=41298 BRANCH kwinclude REVISION DETAIL https://phabricator.kde.org/D14632 AFFECTED FILES autotests/syntaxrepository_test.cpp data/schema/language.xsd data/syntax/scss.xml src/indexer/katehighlightingindexer.cpp src/lib/definition.cpp src/lib/definition.h src/lib/definition_p.h src/lib/keywordlist.cpp src/lib/keywordlist_p.h To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann Cc: kwrite-devel, vkrause, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)
This revision was automatically updated to reflect the committed changes. Closed by commit R216:3ebb3c09e512: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle) (authored by jpoelen). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11470?vs=32861=40010#toc REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11470?vs=32861=40010 REVISION DETAIL https://phabricator.kde.org/D11470 AFFECTED FILES autotests/folding/test.sql.fold autotests/folding/test.sql_oracle.fold autotests/html/test.sql.html autotests/html/test.sql_oracle.html autotests/input/test.sql autotests/input/test.sql_oracle autotests/reference/test.sql.ref autotests/reference/test.sql_oracle.ref data/syntax/sql-mysql.xml data/syntax/sql-oracle.xml data/syntax/sql-postgresql.xml data/syntax/sql.xml To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, cullmann, rkflx, michaelh, kevinapavew, ngraham, bruns, demsking, sars, dhaumann
D14603: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting
jpoelen added a comment. Yes, my compilation folder was pointing to my fork on github from which I make the patches (as I do not have the right version for ECM, I have a script that does among other things a new CMakeLists.txt in another folder and adds symbolic links for project files). If there was no more error it was because I saw them in the conflicts. Currently I put `find_package (ECM 5.31.0 ...` (instead of 5.49.0) and delete `include (ECMAddQch)` which I think should be in `if (BUILD_QCH)`. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14603 To: jpoelen, #framework_syntax_highlighting, dhaumann, vkrause, cullmann Cc: cullmann, kwrite-devel, dhaumann, kde-frameworks-devel, #framework_syntax_highlighting, michaelh, kevinapavew, ngraham, bruns, demsking, sars
D14603: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting
This revision was automatically updated to reflect the committed changes. Closed by commit R216:113ebe28645a: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting (authored by jpoelen). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14603?vs=39067=40004#toc REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14603?vs=39067=40004 REVISION DETAIL https://phabricator.kde.org/D14603 AFFECTED FILES autotests/folding/highlight.scss.fold autotests/html/highlight.css.html autotests/html/highlight.scss.html autotests/html/review128925-1.scss.html autotests/html/review128925-2.scss.html autotests/input/highlight.scss autotests/reference/highlight.css.ref autotests/reference/highlight.scss.ref autotests/reference/review128925-1.scss.ref autotests/reference/review128925-2.css.ref autotests/reference/review128925-2.scss.ref autotests/reference/test.css.ref data/syntax/css.xml data/syntax/scss.xml To: jpoelen, #framework_syntax_highlighting, dhaumann, vkrause, cullmann Cc: cullmann, kwrite-devel, dhaumann, kde-frameworks-devel, #framework_syntax_highlighting, michaelh, kevinapavew, ngraham, bruns, demsking, sars
D14603: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting
jpoelen added a comment. Ok, i'm doing this in the week. REPOSITORY R216 Syntax Highlighting BRANCH scss REVISION DETAIL https://phabricator.kde.org/D14603 To: jpoelen, #framework_syntax_highlighting, dhaumann, vkrause, cullmann Cc: cullmann, kwrite-devel, dhaumann, kde-frameworks-devel, #framework_syntax_highlighting, michaelh, kevinapavew, ngraham, bruns, demsking, sars
D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)
jpoelen added a comment. There have been changes in the xml files that will cause conflicts. I would look in the next few days. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D11470 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, cullmann, rkflx, michaelh, kevinapavew, ngraham, bruns, demsking, sars, dhaumann
D14632: keyword rule: Spport for keywords inclusion from another language/file
jpoelen added a comment. I just thought of `Definition::keywordLists()` which does not list the keywords used by this new syntax. - Should we add the lists used as and when parsing? - Move the functionality on the tag ``? (``, ` name##language `) - Other? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14632 To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann Cc: kwrite-devel, vkrause, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
D14632: keyword rule: Spport for keywords inclusion from another language/file
jpoelen edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14632 To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann Cc: kwrite-devel, vkrause, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
D14632: keyword rule: Spport for keywords inclusion from another language/file
jpoelen edited the summary of this revision. jpoelen edited the test plan for this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14632 To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann Cc: kwrite-devel, vkrause, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
D14632: keyword rule: Spport for keywords inclusion from another language/file
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, cullmann, dhaumann. Restricted Application added projects: Kate, Frameworks. Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. jpoelen requested review of this revision. REVISION SUMMARY The presence of "##" in the name of the keyword rule indicates that it is necessary to look for the list in another file (format: "listName##languageName") TEST PLAN A quick test was done by removing the "properties" list from scss.xml and with "properties##CSS" as the keyword name. REPOSITORY R216 Syntax Highlighting BRANCH keyword_rule REVISION DETAIL https://phabricator.kde.org/D14632 AFFECTED FILES src/indexer/katehighlightingindexer.cpp src/lib/rule.cpp To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann Cc: kwrite-devel, vkrause, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
D14603: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting
jpoelen added a comment. Yes, I can start tomorrow. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14603 To: jpoelen, #framework_syntax_highlighting, dhaumann, vkrause Cc: cullmann, kwrite-devel, dhaumann, kde-frameworks-devel, #framework_syntax_highlighting, michaelh, kevinapavew, ngraham, bruns, demsking, sars
D14603: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting
jpoelen added a comment. I copied all the keywords in the css.xml file and it's a shame. I think that Keyword could refer to those of other files with `##` as for IncludeRules. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14603 To: jpoelen, #framework_syntax_highlighting, dhaumann Cc: kwrite-devel, dhaumann, kde-frameworks-devel, #framework_syntax_highlighting, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars
D14603: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann. Restricted Application added projects: Kate, Frameworks. Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. jpoelen requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH scss REVISION DETAIL https://phabricator.kde.org/D14603 AFFECTED FILES autotests/folding/highlight.scss.fold autotests/html/highlight.css.html autotests/html/highlight.scss.html autotests/html/review128925-1.scss.html autotests/html/review128925-2.scss.html autotests/input/highlight.scss autotests/reference/highlight.css.ref autotests/reference/highlight.scss.ref autotests/reference/review128925-1.scss.ref autotests/reference/review128925-2.css.ref autotests/reference/review128925-2.scss.ref autotests/reference/test.css.ref data/syntax/css.xml data/syntax/scss.xml To: jpoelen, #framework_syntax_highlighting, dhaumann Cc: kwrite-devel, dhaumann, kde-frameworks-devel, #framework_syntax_highlighting, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars
D14434: add functions to access keywords
jpoelen added a comment. This follows https://mail.kde.org/pipermail/kde-frameworks-devel/2018-July/066564.html REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14434 To: jpoelen, #framework_syntax_highlighting, dhaumann Cc: kde-frameworks-devel, kwrite-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
D14434: add functions to access keywords
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: kwrite-devel. jpoelen requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH keywordlist REVISION DETAIL https://phabricator.kde.org/D14434 AFFECTED FILES autotests/syntaxrepository_test.cpp src/lib/definition.cpp src/lib/definition.h src/lib/keywordlist.cpp src/lib/keywordlist_p.h To: jpoelen, #framework_syntax_highlighting, dhaumann Cc: kde-frameworks-devel, kwrite-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
D14282: CSS: fix test reference of the previous commit
This revision was automatically updated to reflect the committed changes. Closed by commit R216:a82af177bc2f: CSS: fix test reference of the previous commit (authored by jpoelen). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14282?vs=38217=38277 REVISION DETAIL https://phabricator.kde.org/D14282 AFFECTED FILES autotests/reference/highlight.css.ref autotests/reference/review128925-1.css.ref autotests/reference/review128925-2.css.ref To: jpoelen, dhaumann Cc: kde-frameworks-devel, kwrite-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
D14283: C++: fix standard floating-point literals
This revision was automatically updated to reflect the committed changes. Closed by commit R216:7a2ae6be229b: C++: fix standard floating-point literals (authored by jpoelen). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14283?vs=38218=38276 REVISION DETAIL https://phabricator.kde.org/D14283 AFFECTED FILES autotests/folding/highlight.cpp.fold autotests/html/highlight.cpp.html autotests/input/highlight.cpp autotests/reference/highlight.cpp.ref data/syntax/isocpp.xml To: jpoelen, #framework_syntax_highlighting, dhaumann Cc: kde-frameworks-devel, kwrite-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
D14283: C++: fix standard floating-point literals
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: kwrite-devel. jpoelen requested review of this revision. REVISION SUMMARY BUG: 389693 REPOSITORY R216 Syntax Highlighting BRANCH fix_cpp_udl REVISION DETAIL https://phabricator.kde.org/D14283 AFFECTED FILES autotests/folding/highlight.cpp.fold autotests/html/highlight.cpp.html autotests/input/highlight.cpp autotests/reference/highlight.cpp.ref data/syntax/isocpp.xml To: jpoelen, #framework_syntax_highlighting, dhaumann Cc: kde-frameworks-devel, kwrite-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
D14282: CSS: fix test reference of the previous commit
jpoelen created this revision. jpoelen added a reviewer: dhaumann. Restricted Application added projects: Kate, Frameworks. jpoelen requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH fix_cxx REVISION DETAIL https://phabricator.kde.org/D14282 AFFECTED FILES autotests/reference/highlight.css.ref autotests/reference/review128925-1.css.ref autotests/reference/review128925-2.css.ref To: jpoelen, dhaumann Cc: kde-frameworks-devel, kwrite-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
D14137: CSS: update syntax and fix some errors
jpoelen added a comment. It is done. So much emotion :') REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14137 To: jpoelen, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
D14137: CSS: update syntax and fix some errors
This revision was automatically updated to reflect the committed changes. Closed by commit R216:423239c45ec5: CSS: update syntax and fix some errors (authored by jpoelen). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14137?vs=37815=37912 REVISION DETAIL https://phabricator.kde.org/D14137 AFFECTED FILES autotests/folding/highlight.css.fold autotests/html/highlight.css.html autotests/html/review128925-1.css.html autotests/html/review128925-2.css.html autotests/html/test.htm.html autotests/input/highlight.css autotests/reference/highlight.css.ref autotests/reference/review128925-1.css.ref autotests/reference/review128925-2.css.ref autotests/reference/test.css.ref autotests/reference/test.htm.ref data/syntax/css.xml To: jpoelen, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
D14137: CSS: update syntax and fix some errors
jpoelen created this revision. jpoelen added a reviewer: dhaumann. jpoelen added projects: Frameworks, Framework: Syntax Highlighting. Restricted Application added a project: Kate. Restricted Application edited subscribers, added: kde-frameworks-devel, kwrite-devel; removed: Frameworks. jpoelen requested review of this revision. REVISION SUMMARY - fix tag followed by a pseudo-class in a nested rule (@media, ...) - fix constraint in a rule - fix Kate auto-completion for properties and rules New highlighting categories - Keyword - Operator - Separator Symbol - SpecialChar - Variable - Value Keyword - Color - Number - Unit - Selector Tag REPOSITORY R216 Syntax Highlighting BRANCH css REVISION DETAIL https://phabricator.kde.org/D14137 AFFECTED FILES autotests/folding/highlight.css.fold autotests/html/highlight.css.html autotests/html/review128925-1.css.html autotests/html/review128925-2.css.html autotests/html/test.htm.html autotests/input/highlight.css autotests/reference/highlight.css.ref autotests/reference/review128925-1.css.ref autotests/reference/review128925-2.css.ref autotests/reference/test.css.ref autotests/reference/test.htm.ref data/syntax/css.xml To: jpoelen, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
