Changing dependencies for a project
I have just changed the dependencies for KAlarm (removed Canberra, added libvlc and libvlccore), but after committing the changes, the build fails on invent.kde.org. I've changed everything I can find in the KAlarm repository relating to the dependencies, so is there something else I need to do to set up the new dependencies? -- David Jarvie. KDE developer, KAlarm author.
Re: Changing dependencies for a project
El dimarts, 9 de juliol del 2024, a les 22:12:40 (CEST), David Jarvie va escriure: > I have just changed the dependencies for KAlarm (removed Canberra, added > libvlc and libvlccore), but after committing the changes, the build fails on > invent.kde.org. In the future probably helps if you do similar (or all) your changes as Merge Requests instead of directly committing. This way you would have found this issue earlier and we would not end up with a non compiling CI. Cheers, Albert > I've changed everything I can find in the KAlarm repository > relating to the dependencies, so is there something else I need to do to > set up the new dependencies?
Re: Changing dependencies for a project
On Tuesday, 9 July 2024 23:47:30 BST Albert Astals Cid wrote: > El dimarts, 9 de juliol del 2024, a les 22:12:40 (CEST), David Jarvie va > > escriure: > > I have just changed the dependencies for KAlarm (removed Canberra, added > > libvlc and libvlccore), but after committing the changes, the build fails > > on invent.kde.org. > > In the future probably helps if you do similar (or all) your changes as > Merge Requests instead of directly committing. > > This way you would have found this issue earlier and we would not end up > with a non compiling CI. If I'd created a merge request, it would presumably have just sat there unmergeable because of the missing CI dependency. How does a new dependency get added to the CI? > > I've changed everything I can find in the KAlarm repository > > relating to the dependencies, so is there something else I need to do to > > set up the new dependencies? -- David Jarvie. KDE developer, KAlarm author.
Re: Changing dependencies for a project
On Wednesday, 10 July 2024 01:51:16 CEST, David Jarvie wrote: On Tuesday, 9 July 2024 23:47:30 BST Albert Astals Cid wrote: El dimarts, 9 de juliol del 2024, a les 22:12:40 (CEST), David Jarvie va escriure: ... If I'd created a merge request, it would presumably have just sat there unmergeable because of the missing CI dependency. How does a new dependency get added to the CI? I've changed everything I can find in the KAlarm repository relating to the dependencies, so is there something else I need to do to set up the new dependencies? You can a) file a sysadmin ticket or b) create a MR for https://invent.kde.org/sysadmin/ci-images/ adding the dependency to the images. It seems, judging from a quick look, that vlc is missing for the qt6 variants because it pulls in qt5. Regards, Heiko
Re: Changing dependencies for a project
Hi, To paraphrase Captain Tsubasa "the CI is your friend". If there was a merge request, the build would have failed and you still would have sent a mail here to ask how to add the dependency :). Even for smaller changes, it's always interesting to have the CI run because it's quite quick and can find small issues that can be avoided (for example, if a file is added, it could be easy to miss to add the licence, the reuse job will fail and in a wonderful world, the commit where the file has been added would be amended to add the licence and we will have a clean history. Or if a xml is not correctly formatted for example). Heiko answered you for the process to add the dependency. And thanks for the change, it's always nice to have up-to-date code! Cheers, Johnny Le mer. 10 juil. 2024 à 01:52, David Jarvie a écrit : > > On Tuesday, 9 July 2024 23:47:30 BST Albert Astals Cid wrote: > > El dimarts, 9 de juliol del 2024, a les 22:12:40 (CEST), David Jarvie va > > > > escriure: > > > I have just changed the dependencies for KAlarm (removed Canberra, added > > > libvlc and libvlccore), but after committing the changes, the build fails > > > on invent.kde.org. > > > > In the future probably helps if you do similar (or all) your changes as > > Merge Requests instead of directly committing. > > > > This way you would have found this issue earlier and we would not end up > > with a non compiling CI. > > If I'd created a merge request, it would presumably have just sat there > unmergeable because of the missing CI dependency. How does a new dependency > get added to the CI? > > > > I've changed everything I can find in the KAlarm repository > > > relating to the dependencies, so is there something else I need to do to > > > set up the new dependencies? > > -- > David Jarvie. > KDE developer, KAlarm author.
Re: Changing dependencies for a project
On Dienstag, 9. Juli 2024 22:12:40 CEST David Jarvie wrote: > I have just changed the dependencies for KAlarm (removed Canberra, added > libvlc and libvlccore), but after committing the changes, the build fails on > invent.kde.org. I've changed everything I can find in the KAlarm repository > relating to the dependencies, so is there something else I need to do to > set up the new dependencies? For a start, you should read https://community.kde.org/Policies/Dependency_Changes_and_CI and follow the documented process. To ping Ben on an MR I add his GitLab handle to the description of the MR. Regards, Ingo signature.asc Description: This is a digitally signed message part.
Re: Changing dependencies for a project
On 10 July 2024 06:29:18 BST, Heiko Becker wrote: > On Wednesday, 10 July 2024 01:51:16 CEST, David Jarvie wrote: > > On Tuesday, 9 July 2024 23:47:30 BST Albert Astals Cid wrote: > >> El dimarts, 9 de juliol del 2024, a les 22:12:40 (CEST), David Jarvie va > >> > >> escriure: ... > > > > If I'd created a merge request, it would presumably have just sat there > > unmergeable because of the missing CI dependency. How does a new dependency > > get added to the CI? > > > >>> I've changed everything I can find in the KAlarm repository > >>> relating to the dependencies, so is there something else I need to do to > >>> set up the new dependencies? > > You can a) file a sysadmin ticket or b) create a MR for > https://invent.kde.org/sysadmin/ci-images/ adding the dependency to the > images. > > It seems, judging from a quick look, that vlc is missing for the qt6 variants > because it pulls in qt5. Thank you. There doesn't seem any obvious reason why Qt should be pulled in by a VLC library - if the way packages are built does indeed do this, it's unfortunate. In Debian there is no such link, but I don't know about other distros. -- David Jarvie KAlarm author, KDE developer
Re: Changing dependencies for a project
On Wed, Jul 10, 2024 at 7:26 PM David Jarvie wrote: > > > On 10 July 2024 06:29:18 BST, Heiko Becker wrote: > > On Wednesday, 10 July 2024 01:51:16 CEST, David Jarvie wrote: > > > On Tuesday, 9 July 2024 23:47:30 BST Albert Astals Cid wrote: > > >> El dimarts, 9 de juliol del 2024, a les 22:12:40 (CEST), David Jarvie > va > > >> > > >> escriure: ... > > > > > > If I'd created a merge request, it would presumably have just sat > there unmergeable because of the missing CI dependency. How does a new > dependency get added to the CI? > > > > > >>> I've changed everything I can find in the KAlarm repository > > >>> relating to the dependencies, so is there something else I need to > do to > > >>> set up the new dependencies? > > > > You can a) file a sysadmin ticket or b) create a MR for > https://invent.kde.org/sysadmin/ci-images/ adding the dependency to the > images. > > > > It seems, judging from a quick look, that vlc is missing for the qt6 > variants because it pulls in qt5. > > Thank you. There doesn't seem any obvious reason why Qt should be pulled > in by a VLC library - if the way packages are built does indeed do this, > it's unfortunate. In Debian there is no such link, but I don't know about > other distros. > It's pulled in because vlc-devel depends on all the other components of VLC, at least in OpenSUSE. That includes vlc-qt which is a Qt 5 package. That being said, while they don't require the development headers of Qt 5, the current packages in our image pull Qt 5 in at the moment and should probably be sorted at some point or another. gnuplot libmlt7-module-qt6 libmlt7-modules libopencv3_4 libopencv_highgui409 libqscintilla2_qt5-15 libstellarsolver2 maxima melt octave opencv opencv-devel python3-opencv3 qscintilla-qt5 stellarsolver-devel Given the above, i'll enable vlc-devel for now given it doesn't pull in Qt 5 development headers. > -- > David Jarvie > KAlarm author, KDE developer > Cheers, Ben
