Re: Compiling konsole on Windows via craft

2020-04-20 Thread Johnny Jazeix
Hi,
KPty is mentioned as Pty in the CMakeLists.txt
(https://invent.kde.org/kde/konsole/-/blob/master/CMakeLists.txt#L50).
Hannah mentioned on the KDE-Windows hread that KPty can't be compiled
on Windows yet and is necessary for Konsole, so Konsole can't be
compiled on Windows yet.

Thanks for the quick reply,

Johnny

Le lun. 20 avr. 2020 à 10:52, Konstantin Kharlamov
 a écrit :
>
> On 20.04.2020 11:03, Johnny Jazeix wrote:
> > Hi,
> >
> > there is an issue to compile Konsole on Windows. KPty is not found. A
> > fix for Cantor (https://bugs.kde.org/show_bug.cgi?id=386787) was to
> > remove it from the CMakeLists.txt.
> > Can the same be done for Konsole?
> >
> > Full thread: 
> > https://mail.kde.org/pipermail/kde-windows/2020-April/011157.html
> >
> > Johnny
>
> FWIW, I grepped for kpty over the Konsole sources, and CMakeLists.txt is not 
> among the files where kpty is mentioned. It is however used in the Konsole 
> code.
>
> When I look the fix you mentioned¹, I see they explain in the commit message 
> that components that depend on kpty are simply not built for Windows 
> platform. Offhand, I don't believe this is the case for Konsole.
>
> 1:https://cgit.kde.org/cantor.git/commit/?id=5700cc59da6f8bba503a38ba4c902877206a59cf


Re: Compiling konsole on Windows via craft

2020-04-20 Thread Konstantin Kharlamov

On 20.04.2020 11:03, Johnny Jazeix wrote:

Hi,

there is an issue to compile Konsole on Windows. KPty is not found. A
fix for Cantor (https://bugs.kde.org/show_bug.cgi?id=386787) was to
remove it from the CMakeLists.txt.
Can the same be done for Konsole?

Full thread: https://mail.kde.org/pipermail/kde-windows/2020-April/011157.html

Johnny


FWIW, I grepped for kpty over the Konsole sources, and CMakeLists.txt is not 
among the files where kpty is mentioned. It is however used in the Konsole code.

When I look the fix you mentioned¹, I see they explain in the commit message 
that components that depend on kpty are simply not built for Windows platform. 
Offhand, I don't believe this is the case for Konsole.

1:https://cgit.kde.org/cantor.git/commit/?id=5700cc59da6f8bba503a38ba4c902877206a59cf


Compiling konsole on Windows via craft

2020-04-20 Thread Johnny Jazeix
Hi,

there is an issue to compile Konsole on Windows. KPty is not found. A
fix for Cantor (https://bugs.kde.org/show_bug.cgi?id=386787) was to
remove it from the CMakeLists.txt.
Can the same be done for Konsole?

Full thread: https://mail.kde.org/pipermail/kde-windows/2020-April/011157.html

Johnny