Review Request 117830: disable extended attributes support on windows
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117830/ --- Review request for Baloo and kdewin. Repository: baloo Description --- At the moment, there is no support available for extended attributes for Windows/NTFS. So we simply disable it. Diffs - src/file/lib/baloo_xattr_p.h fefc3d9 src/file/lib/xattrdetector.cpp 9bff838 Diff: https://git.reviewboard.kde.org/r/117830/diff/ Testing --- windows msvc 2010 Thanks, Patrick Spendrin >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
Re: Review Request 117830: disable extended attributes support on windows
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117830/#review56737 --- Ship it! I'm a little surprised that NTFS doesn't support xattr, but sure! - Vishesh Handa On April 28, 2014, 9:58 a.m., Patrick Spendrin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117830/ > --- > > (Updated April 28, 2014, 9:58 a.m.) > > > Review request for Baloo and kdewin. > > > Repository: baloo > > > Description > --- > > At the moment, there is no support available for extended attributes for > Windows/NTFS. So we simply disable it. > > > Diffs > - > > src/file/lib/baloo_xattr_p.h fefc3d9 > src/file/lib/xattrdetector.cpp 9bff838 > > Diff: https://git.reviewboard.kde.org/r/117830/diff/ > > > Testing > --- > > windows msvc 2010 > > > Thanks, > > Patrick Spendrin > > >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
Re: Review Request 117830: disable extended attributes support on windows
> On April 28, 2014, 12:41 p.m., Vishesh Handa wrote: > > I'm a little surprised that NTFS doesn't support xattr, but sure! NTFS /does/ support xattr (on ntfs-3g), but WinNT does support infinite length xattr via ADS only, so basically xattr invocation would have to be ported for Windows. - Thomas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117830/#review56737 --- On April 28, 2014, 9:58 a.m., Patrick Spendrin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117830/ > --- > > (Updated April 28, 2014, 9:58 a.m.) > > > Review request for Baloo and kdewin. > > > Repository: baloo > > > Description > --- > > At the moment, there is no support available for extended attributes for > Windows/NTFS. So we simply disable it. > > > Diffs > - > > src/file/lib/baloo_xattr_p.h fefc3d9 > src/file/lib/xattrdetector.cpp 9bff838 > > Diff: https://git.reviewboard.kde.org/r/117830/diff/ > > > Testing > --- > > windows msvc 2010 > > > Thanks, > > Patrick Spendrin > > >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
Re: Review Request 117830: disable extended attributes support on windows
> On April 28, 2014, 12:41 p.m., Vishesh Handa wrote: > > I'm a little surprised that NTFS doesn't support xattr, but sure! > > Thomas Lübking wrote: > NTFS /does/ support xattr (on ntfs-3g), but WinNT does support infinite > length xattr via ADS only, so basically xattr invocation would have to be > ported for Windows. I think that would be indeed a way to address this, but I don't want to port it right away. - Patrick --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117830/#review56737 --- On April 28, 2014, 9:58 a.m., Patrick Spendrin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117830/ > --- > > (Updated April 28, 2014, 9:58 a.m.) > > > Review request for Baloo and kdewin. > > > Repository: baloo > > > Description > --- > > At the moment, there is no support available for extended attributes for > Windows/NTFS. So we simply disable it. > > > Diffs > - > > src/file/lib/baloo_xattr_p.h fefc3d9 > src/file/lib/xattrdetector.cpp 9bff838 > > Diff: https://git.reviewboard.kde.org/r/117830/diff/ > > > Testing > --- > > windows msvc 2010 > > > Thanks, > > Patrick Spendrin > > >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
Re: Review Request 117830: disable extended attributes support on windows
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117830/ --- (Updated April 28, 2014, 2:42 p.m.) Status -- This change has been marked as submitted. Review request for Baloo and kdewin. Repository: baloo Description --- At the moment, there is no support available for extended attributes for Windows/NTFS. So we simply disable it. Diffs - src/file/lib/baloo_xattr_p.h fefc3d9 src/file/lib/xattrdetector.cpp 9bff838 Diff: https://git.reviewboard.kde.org/r/117830/diff/ Testing --- windows msvc 2010 Thanks, Patrick Spendrin >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
