Shall we condense the bots' commit announcements

2021-05-25 Thread Nate Graham

Hello all,

Recently we removed the commit announcement bots from the #plasma and 
#kwin chatrooms because we felt their output was too noisy. However for 
the rooms where they are still active and announcing git commits, would 
people appreciate it if the announcements were shorter?


For example, instead of sending 5 messages (title, first three lines, 
and URL) the announcement could send one message (something like title 
and URL combined).


Would anyone object to this change?

Nate


Re: Shall we condense the bots' commit announcements

2021-05-25 Thread Frederik Schwarzer

Hi,

I would not object to this change. Maybe keep the longer versions in 
#kde-commits?


Another thought I had was that GIT_SILENT messages could be omitted. 
Maybe also worth considering?


Cheers
Frederik


On 5/25/21 11:25 PM, Nate Graham wrote:

Hello all,

Recently we removed the commit announcement bots from the #plasma and 
#kwin chatrooms because we felt their output was too noisy. However for 
the rooms where they are still active and announcing git commits, would 
people appreciate it if the announcements were shorter?


For example, instead of sending 5 messages (title, first three lines, 
and URL) the announcement could send one message (something like title 
and URL combined).


Would anyone object to this change?

Nate


Re: Shall we condense the bots' commit announcements

2021-05-25 Thread Nicolás Alvarez
El mar, 25 de may. de 2021 a la(s) 21:59, Frederik Schwarzer
(schwar...@kde.org) escribió:
>
> Hi,
>
> I would not object to this change. Maybe keep the longer versions in
> #kde-commits?

Currently the script first creates the message to send for the commit,
and then sends it to multiple channels. Sending a different message
(shorter vs longer) to different channels for a given commit is doable
but would need some extensive refactoring to the code.

> Another thought I had was that GIT_SILENT messages could be omitted.
> Maybe also worth considering?

Seems this is already possible in the configuration, per channel. Some
channels have notify_silent=False:
https://invent.kde.org/sysadmin/irc-notifications/-/blob/master/gateway/notifications.cfg

-- 
Nicolás

> Cheers
> Frederik
>
>
> On 5/25/21 11:25 PM, Nate Graham wrote:
> > Hello all,
> >
> > Recently we removed the commit announcement bots from the #plasma and
> > #kwin chatrooms because we felt their output was too noisy. However for
> > the rooms where they are still active and announcing git commits, would
> > people appreciate it if the announcements were shorter?
> >
> > For example, instead of sending 5 messages (title, first three lines,
> > and URL) the announcement could send one message (something like title
> > and URL combined).
> >
> > Would anyone object to this change?
> >
> > Nate


Re: Shall we condense the bots' commit announcements

2021-05-26 Thread Frederik Schwarzer




Am 26.05.2021 03:12 schrieb Nicolás Alvarez:

El mar, 25 de may. de 2021 a la(s) 21:59, Frederik Schwarzer
(schwar...@kde.org) escribió:

Another thought I had was that GIT_SILENT messages could be omitted.
Maybe also worth considering?


Seems this is already possible in the configuration, per channel. Some
channels have notify_silent=False:
https://invent.kde.org/sysadmin/irc-notifications/-/blob/master/gateway/notifications.cfg


Thanks for the info.

Cheers
Frederik


Re: Shall we condense the bots' commit announcements

2021-06-20 Thread Nate Graham
The code has been changed to make this a possibility. If you'd like to 
opt into it for your channels, you need to set `short_message=True` in 
the appropriate channel config in the sysadmin/irc-notifications repository.


Nate

On 5/26/21 7:49 AM, Frederik Schwarzer wrote:



Am 26.05.2021 03:12 schrieb Nicolás Alvarez:

El mar, 25 de may. de 2021 a la(s) 21:59, Frederik Schwarzer
(schwar...@kde.org) escribió:

Another thought I had was that GIT_SILENT messages could be omitted.
Maybe also worth considering?


Seems this is already possible in the configuration, per channel. Some
channels have notify_silent=False:
https://invent.kde.org/sysadmin/irc-notifications/-/blob/master/gateway/notifications.cfg 



Thanks for the info.

Cheers
Frederik