Re: kdesrc-build expects fixed path

2021-06-07 Thread Frederik Schwarzer

Hi,

thanks for your replies. So it seems as if it broke recently and I was 
not just doing it wrong. :)


In the code the bashrc snippet is just plain text. That's not going to 
work if there two different repo layouts.


As for the fix, I guess we could either make kdesrc-build handle both 
layouts or make it add the path of the checkout it was run from to the 
bashrc.


It feels intentional to use the copy from the repo layout to be more 
self-contained so it continues to work when the initial repo is deleted 
or moved around.


Once the repo layout question is decided, we can check what to do here.

Cheers,
Frederik

On 6/7/21 12:13 AM, Nate Graham wrote:

I think a better change would be to return to the older, simpler, shorter 
"flat" folder structure. See 
https://invent.kde.org/sdk/kdesrc-build/-/merge_requests/96

Nate


   On Sat, 05 Jun 2021 22:27:44 -0600 Ömer Fadıl USTA  
wrote 
  > I think we need to change templates and other docs for its standard 
location as$HOME/kde/src/sdk/kdesrc-build  
  > because it already downloads its self (as a copy)  whenever we run 
kdesrc-buildI believe it was set up flat structure just before passing to invent 
structure sonow it must be looked up in sdk folder
  >
  > Ömer Fadıl Usta
  > PGP key : 0xfd11561976b1690b
  > about.me/omerusta
  >
  >
  > Frederik Schwarzer , 5 Haz 2021 Cmt, 20:18 tarihinde 
şunu yazdı:
  > Hi,
  >
  > when I just tried to set up kdesrc-build with --initial-setup it offered
  > me to update my .bashrc file.
  >
  > The changes made did not work for me because it adds
  >  $HOME/kde/src/kdesrc-build
  > to the PATH while I have my checkout at another location.
  >
  > Maybe I have missed something but I think we should either
  > - print a warning or even an error message when
  >running "--initial-setup" from a "wrong" location
  > or
  > - add the location of the actual checkout to .bashrc
  >
  > Any thought or amendments?
  >
  > Cheers,
  > Frederik
  >



Re: kdesrc-build expects fixed path

2021-06-06 Thread Nate Graham
I think a better change would be to return to the older, simpler, shorter 
"flat" folder structure. See 
https://invent.kde.org/sdk/kdesrc-build/-/merge_requests/96

Nate


  On Sat, 05 Jun 2021 22:27:44 -0600 Ömer Fadıl USTA  
wrote 
 > I think we need to change templates and other docs for its standard location 
 > as$HOME/kde/src/sdk/kdesrc-build   
 > because it already downloads its self (as a copy)  whenever we run 
 > kdesrc-buildI believe it was set up flat structure just before passing to 
 > invent structure sonow it must be looked up in sdk folder
 > 
 > Ömer Fadıl Usta
 > PGP key : 0xfd11561976b1690b
 > about.me/omerusta
 > 
 > 
 > Frederik Schwarzer , 5 Haz 2021 Cmt, 20:18 tarihinde şunu 
 > yazdı:
 > Hi,
 > 
 > when I just tried to set up kdesrc-build with --initial-setup it offered 
 > me to update my .bashrc file.
 > 
 > The changes made did not work for me because it adds
 >  $HOME/kde/src/kdesrc-build
 > to the PATH while I have my checkout at another location.
 > 
 > Maybe I have missed something but I think we should either
 > - print a warning or even an error message when
 >running "--initial-setup" from a "wrong" location
 > or
 > - add the location of the actual checkout to .bashrc
 > 
 > Any thought or amendments?
 > 
 > Cheers,
 > Frederik
 > 


Re: kdesrc-build expects fixed path

2021-06-05 Thread Ömer Fadıl USTA
I think we need to change templates and other docs for its standard
location as
$HOME/kde/src/sdk/kdesrc-build
  
because it already downloads its self (as a copy)  whenever we run
kdesrc-build
I believe it was set up flat structure just before passing to invent
structure so
now it must be looked up in sdk folder

Ömer Fadıl Usta
PGP key : 0xfd11561976b1690b
about.me/omerusta


Frederik Schwarzer , 5 Haz 2021 Cmt, 20:18 tarihinde
şunu yazdı:

> Hi,
>
> when I just tried to set up kdesrc-build with --initial-setup it offered
> me to update my .bashrc file.
>
> The changes made did not work for me because it adds
>  $HOME/kde/src/kdesrc-build
> to the PATH while I have my checkout at another location.
>
> Maybe I have missed something but I think we should either
> - print a warning or even an error message when
>running "--initial-setup" from a "wrong" location
> or
> - add the location of the actual checkout to .bashrc
>
> Any thought or amendments?
>
> Cheers,
> Frederik
>


kdesrc-build expects fixed path

2021-06-05 Thread Frederik Schwarzer

Hi,

when I just tried to set up kdesrc-build with --initial-setup it offered 
me to update my .bashrc file.


The changes made did not work for me because it adds
$HOME/kde/src/kdesrc-build
to the PATH while I have my checkout at another location.

Maybe I have missed something but I think we should either
- print a warning or even an error message when
  running "--initial-setup" from a "wrong" location
or
- add the location of the actual checkout to .bashrc

Any thought or amendments?

Cheers,
Frederik