[kde-doc-english] Review Request 115818: Support more catalogs and reduce code duplication
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115818/#review50295 --- This review has been submitted with commit 341c7f48af628a3d9daa652d12a423dcb641bf20 by Luigi Toscano to branch master. - Commit Hook On Feb. 16, 2014, 8:16 p.m., Luigi Toscano wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115818/ > --- > > (Updated Feb. 16, 2014, 8:16 p.m.) > > > Review request for Documentation and KDE Frameworks. > > > Repository: kdoctools > > > Description > --- > > Don't duplicate the code which searches the catalog(s) between xslt.cpp and > meinproc.cpp, centralize it in getAllKDocToolsCatalogs. > > Also, allow the usage of multiple catalogs (catalog.xml is always the main > one); this can be useful to allow other modules to drop-in other DTD > definitions (for example, if the main DTD is changed to use DocBook XML 4.5 > instead of 4.2, the 4.2-based can be defined in a compatibility catalog > installed by kde4support). > > > Diffs > - > > src/meinproc.cpp 86e83ae > src/xslt.h 6fd2dae > src/xslt.cpp 70e0d6a > > Diff: https://git.reviewboard.kde.org/r/115818/diff/ > > > Testing > --- > > > Thanks, > > Luigi Toscano > > -- next part -- An HTML attachment was scrubbed... URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20140219/f0ecb2d1/attachment.html>
[kde-doc-english] Review Request 115818: Support more catalogs and reduce code duplication
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115818/ --- (Updated Feb. 19, 2014, 11:51 p.m.) Status -- This change has been marked as submitted. Review request for Documentation and KDE Frameworks. Repository: kdoctools Description --- Don't duplicate the code which searches the catalog(s) between xslt.cpp and meinproc.cpp, centralize it in getAllKDocToolsCatalogs. Also, allow the usage of multiple catalogs (catalog.xml is always the main one); this can be useful to allow other modules to drop-in other DTD definitions (for example, if the main DTD is changed to use DocBook XML 4.5 instead of 4.2, the 4.2-based can be defined in a compatibility catalog installed by kde4support). Diffs - src/meinproc.cpp 86e83ae src/xslt.h 6fd2dae src/xslt.cpp 70e0d6a Diff: https://git.reviewboard.kde.org/r/115818/diff/ Testing --- Thanks, Luigi Toscano -- next part -- An HTML attachment was scrubbed... URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20140219/99739530/attachment.html>
[kde-doc-english] Review Request 115818: Support more catalogs and reduce code duplication
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115818/#review50294 --- This review has been submitted with commit aacda6f30012e6af1be4a4ba8a8a77808bf3d8fa by Luigi Toscano to branch master. - Commit Hook On Feb. 16, 2014, 8:16 p.m., Luigi Toscano wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115818/ > --- > > (Updated Feb. 16, 2014, 8:16 p.m.) > > > Review request for Documentation and KDE Frameworks. > > > Repository: kdoctools > > > Description > --- > > Don't duplicate the code which searches the catalog(s) between xslt.cpp and > meinproc.cpp, centralize it in getAllKDocToolsCatalogs. > > Also, allow the usage of multiple catalogs (catalog.xml is always the main > one); this can be useful to allow other modules to drop-in other DTD > definitions (for example, if the main DTD is changed to use DocBook XML 4.5 > instead of 4.2, the 4.2-based can be defined in a compatibility catalog > installed by kde4support). > > > Diffs > - > > src/meinproc.cpp 86e83ae > src/xslt.h 6fd2dae > src/xslt.cpp 70e0d6a > > Diff: https://git.reviewboard.kde.org/r/115818/diff/ > > > Testing > --- > > > Thanks, > > Luigi Toscano > > -- next part -- An HTML attachment was scrubbed... URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20140219/bfee630b/attachment.html>
[kde-doc-english] Review Request 115744: Fix projects using KDocTools on windows.
> On Feb. 19, 2014, 10:44 p.m., Luigi Toscano wrote:
> > > Fix the real issue: Since I have
> > > https://git.reviewboard.kde.org/r/115210/ applied
> > > locally the install path contains C:/kf5/install/../../ProgramData/share.
> > > This resulted in a wrong relative path in kdex.dtd at line 100 (8 times
> > > ../ instead of 4).
> >
> > Just to be sure: the fix solves the issue even if the patch above (dropped)
> > is not applied?
Yeah, the new patch fixes the build of all frameworks using KDocTools. Seems
less invasive than dropping that if statement.
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115744/#review50283
---
On Feb. 19, 2014, 8:45 p.m., Alexander Richardson wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115744/
> ---
>
> (Updated Feb. 19, 2014, 8:45 p.m.)
>
>
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
>
>
> Repository: kdoctools
>
>
> Description
> ---
>
> Fix projects using KDocTools on windows.
>
> If ${CMAKE_INSTALL_PREFIX}/${DATA_INSTALL_DIR} contained /../ elements
> file(RELATIVE_PATH) would interpret these as valid directory names and
> therefore return a relative path which has too many /../
>
> REVIEW: 115744
>
>
> Diffs
> -
>
> src/CMakeLists.txt 241d56ffdb9f5cf4859eaf06aad491b9e1ca94fa
>
> Diff: https://git.reviewboard.kde.org/r/115744/diff/
>
>
> Testing
> ---
>
> kservice didn't compile before this change, now it does (win32), doesn't
> affect other platforms
>
>
> Thanks,
>
> Alexander Richardson
>
>
-- next part --
An HTML attachment was scrubbed...
URL:
<http://mail.kde.org/pipermail/kde-doc-english/attachments/20140219/034d886b/attachment.html>
[kde-doc-english] [kate/frameworks] doc/kate: more JS API documentation
Git commit e5f60c4fa412ae8fd8b67ff03a5df046f2a202da by Dominik Haumann. Committed on 19/02/2014 at 22:18. Pushed by dhaumann into branch 'frameworks'. more JS API documentation M +34 -0doc/kate/development.docbook http://commits.kde.org/kate/e5f60c4fa412ae8fd8b67ff03a5df046f2a202da diff --git a/doc/kate/development.docbook b/doc/kate/development.docbook index a4efd97..0f23b0d 100644 --- a/doc/kate/development.docbook +++ b/doc/kate/development.docbook @@ -1546,6 +1546,40 @@ String document.commentEnd(int attribute + + +Range document.documentRange(); + + +Returns a range that encompasses the whole document. + + + + + + +Cursor documentEnd(); + + +Returns a cursor positioned at the last column of the last line in the document. + + + + + + +bool isValidTextPosition(int line, int column); +bool isValidTextPosition(Cursor cursor); + + +Returns true, if the given cursor position is positioned at a valid text position. +A text position is valid only if it locate at the start, in the middle, or the end of a valid line. +Further, a text position is invalid if it is located in a Unicode surrogate. + +Since: &kde; 5.0 + + +
[kde-doc-english] [kate/frameworks] doc/kate: document scripting API
Git commit 1603ce98098da2b569153199f07d576788735137 by Dominik Haumann. Committed on 19/02/2014 at 21:54. Pushed by dhaumann into branch 'frameworks'. document scripting API - bool document.isLineModified(int line); - bool document.isLineTouched(int line); - bool document.isLineSaved(int line); - bool document.findTouchedLine(int startLine, bool down) M +54 -0doc/kate/development.docbook http://commits.kde.org/kate/1603ce98098da2b569153199f07d576788735137 diff --git a/doc/kate/development.docbook b/doc/kate/development.docbook index 6152bd1..a4efd97 100644 --- a/doc/kate/development.docbook +++ b/doc/kate/development.docbook @@ -1314,6 +1314,60 @@ int document.lines(); +bool document.isLineModified(int line); + + +Returns true, if line currently contains unsaved data. + + +Since: &kde; 5.0 + + + + + + +bool document.isLineSaved(int line); + + +Returns true, if line was changed, but the document was saved. +Hence, the line currently does not contain any unsaved data. + + +Since: &kde; 5.0 + + + + + + +bool document.isLineTouched(int line); + + +Returns true, if line currently contains unsaved data or was changed before. + + +Since: &kde; 5.0 + + + + + + +bool document.findTouchedLine(int startLine, bool down); + + +Search for the next touched line starting at line. +The search is performed either upwards or downwards depending on the search direction specified in down. + + +Since: &kde; 5.0 + + + + + + int document.length();
[kde-doc-english] Review Request 115744: Fix projects using KDocTools on windows.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115744/#review50283
---
> Fix the real issue: Since I have https://git.reviewboard.kde.org/r/115210/
> applied
> locally the install path contains C:/kf5/install/../../ProgramData/share.
> This resulted in a wrong relative path in kdex.dtd at line 100 (8 times ../
> instead of 4).
Just to be sure: the fix solves the issue even if the patch above (dropped) is
not applied?
- Luigi Toscano
On Feb. 19, 2014, 7:45 p.m., Alexander Richardson wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115744/
> ---
>
> (Updated Feb. 19, 2014, 7:45 p.m.)
>
>
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
>
>
> Repository: kdoctools
>
>
> Description
> ---
>
> Fix projects using KDocTools on windows.
>
> If ${CMAKE_INSTALL_PREFIX}/${DATA_INSTALL_DIR} contained /../ elements
> file(RELATIVE_PATH) would interpret these as valid directory names and
> therefore return a relative path which has too many /../
>
> REVIEW: 115744
>
>
> Diffs
> -
>
> src/CMakeLists.txt 241d56ffdb9f5cf4859eaf06aad491b9e1ca94fa
>
> Diff: https://git.reviewboard.kde.org/r/115744/diff/
>
>
> Testing
> ---
>
> kservice didn't compile before this change, now it does (win32), doesn't
> affect other platforms
>
>
> Thanks,
>
> Alexander Richardson
>
>
-- next part --
An HTML attachment was scrubbed...
URL:
<http://mail.kde.org/pipermail/kde-doc-english/attachments/20140219/028afcbb/attachment.html>
[kde-doc-english] [parley] doc: Update the label name in the docs
Git commit 44763e6cb9611f8e1ed6428d19c9addac1e81879 by Yuri Chornoivan. Committed on 19/02/2014 at 20:17. Pushed by yurchor into branch 'master'. Update the label name in the docs M +2-2doc/index.docbook http://commits.kde.org/parley/44763e6cb9611f8e1ed6428d19c9addac1e81879 diff --git a/doc/index.docbook b/doc/index.docbook index c6c3cfa..e32389a 100644 --- a/doc/index.docbook +++ b/doc/index.docbook @@ -44,7 +44,7 @@ &FDLNotice; -2013-11-10 +2014-02-19 0.9.4 (&kde; SC 4.13) @@ -1688,7 +1688,7 @@ The sound file will be saved next to the current vocabulary file in the View Tab -The View Settings allows you to change font and size for the pronunciation symbols, and you can choose the Grade Colors you like best. +The View Settings allows you to change font and size for the pronunciation symbols, and you can choose the Base color for displaying grades you like best.
[kde-doc-english] Review Request 115744: Fix projects using KDocTools on windows.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115744/
---
(Updated Feb. 19, 2014, 8:45 p.m.)
Review request for Documentation, KDE Frameworks and Luigi Toscano.
Changes
---
Fix the real issue: Since I have https://git.reviewboard.kde.org/r/115210/
applied locally the install path contains
C:/kf5/install/../../ProgramData/share.
This resulted in a wrong relative path in kdex.dtd at line 100 (8 times ../
instead of 4).
Summary (updated)
-
Fix projects using KDocTools on windows.
Repository: kdoctools
Description (updated)
---
Fix projects using KDocTools on windows.
If ${CMAKE_INSTALL_PREFIX}/${DATA_INSTALL_DIR} contained /../ elements
file(RELATIVE_PATH) would interpret these as valid directory names and
therefore return a relative path which has too many /../
REVIEW: 115744
Diffs (updated)
-
src/CMakeLists.txt 241d56ffdb9f5cf4859eaf06aad491b9e1ca94fa
Diff: https://git.reviewboard.kde.org/r/115744/diff/
Testing
---
kservice didn't compile before this change, now it does (win32), doesn't affect
other platforms
Thanks,
Alexander Richardson
-- next part --
An HTML attachment was scrubbed...
URL:
<http://mail.kde.org/pipermail/kde-doc-english/attachments/20140219/85057401/attachment-0001.html>
[kde-doc-english] Review Request 115744: The WIN32 part of this if statement doesn't seem to work -> drop it
> On Feb. 19, 2014, 2:52 p.m., Alex Merry wrote: > > src/CMakeLists.txt, lines 63-67 > > <https://git.reviewboard.kde.org/r/115744/diff/1/?file=243985#file243985line63> > > > > This warning no longer applies, right? In that, since we no longer > > have a monolithic kdelibs, we can just use relative paths in the xsl files. > > Luigi Toscano wrote: > I'm not sure it does not apply: the files are not installed either while > building kdoctools alone, but I could have mistaken that part. As I said, it > was changed by the kde-windows team as it caused issues with emerge, and I > can't really say if it's still the case or not. Oh, true, kdoctools does some docbook building of its own. I hadn't spotted that. - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115744/#review50247 --- On Feb. 14, 2014, 12:29 a.m., Alexander Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115744/ > --- > > (Updated Feb. 14, 2014, 12:29 a.m.) > > > Review request for Documentation, KDE Frameworks, kdewin, and Luigi Toscano. > > > Repository: kdoctools > > > Description > --- > > The WIN32 part of this if statement doesn't seem to work -> drop it > > The frameworks using KDocTools fail otherwise complaining about invalid > paths (Win32 build) > > Without this patch I get the following error: > > file:///C:/ProgramData/kdoctools5/customization/dtd/kdex.dtd:102: warning: > failed to load external entity > "file:///emerge-root/share/xml/docbook/schema/dtd/4.2/docbookx.dtd" > > The path there is actually correct and should work. However, it seems that > XSLT does not accept paths starting with a / on windows. Using / is fine > and evaluates to the root directory of the current drive. > > > Diffs > - > > src/CMakeLists.txt 241d56ffdb9f5cf4859eaf06aad491b9e1ca94fa > > Diff: https://git.reviewboard.kde.org/r/115744/diff/ > > > Testing > --- > > kservice didn't compile before this change, now it does (win32), doesn't > affect other platforms > > > Thanks, > > Alexander Richardson > > -- next part -- An HTML attachment was scrubbed... URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20140219/b14c0f5f/attachment.html>
[kde-doc-english] Review Request 115818: Support more catalogs and reduce code duplication
> On Feb. 19, 2014, 3:07 p.m., Alex Merry wrote: > > Looks good. On the whole, I think this would be better as two separate > > commits (from the POV of git bisect), but I'm not going to push that. > > Luigi Toscano wrote: > Thanks; how would you break it? Do the de-duplication first (call getAllKDocToolsCatalogs getKDocToolsCatalog instead, say, and have it just be the common line). Then extend it to search for all catalogs in a separate commit. - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115818/#review50252 --- On Feb. 16, 2014, 8:16 p.m., Luigi Toscano wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115818/ > --- > > (Updated Feb. 16, 2014, 8:16 p.m.) > > > Review request for Documentation and KDE Frameworks. > > > Repository: kdoctools > > > Description > --- > > Don't duplicate the code which searches the catalog(s) between xslt.cpp and > meinproc.cpp, centralize it in getAllKDocToolsCatalogs. > > Also, allow the usage of multiple catalogs (catalog.xml is always the main > one); this can be useful to allow other modules to drop-in other DTD > definitions (for example, if the main DTD is changed to use DocBook XML 4.5 > instead of 4.2, the 4.2-based can be defined in a compatibility catalog > installed by kde4support). > > > Diffs > - > > src/meinproc.cpp 86e83ae > src/xslt.h 6fd2dae > src/xslt.cpp 70e0d6a > > Diff: https://git.reviewboard.kde.org/r/115818/diff/ > > > Testing > --- > > > Thanks, > > Luigi Toscano > > -- next part -- An HTML attachment was scrubbed... URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20140219/64df340a/attachment.html>
[kde-doc-english] Review Request 115818: Support more catalogs and reduce code duplication
> On Feb. 19, 2014, 3:07 p.m., Alex Merry wrote: > > Looks good. On the whole, I think this would be better as two separate > > commits (from the POV of git bisect), but I'm not going to push that. Thanks; how would you break it? - Luigi --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115818/#review50252 --- On Feb. 16, 2014, 8:16 p.m., Luigi Toscano wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115818/ > --- > > (Updated Feb. 16, 2014, 8:16 p.m.) > > > Review request for Documentation and KDE Frameworks. > > > Repository: kdoctools > > > Description > --- > > Don't duplicate the code which searches the catalog(s) between xslt.cpp and > meinproc.cpp, centralize it in getAllKDocToolsCatalogs. > > Also, allow the usage of multiple catalogs (catalog.xml is always the main > one); this can be useful to allow other modules to drop-in other DTD > definitions (for example, if the main DTD is changed to use DocBook XML 4.5 > instead of 4.2, the 4.2-based can be defined in a compatibility catalog > installed by kde4support). > > > Diffs > - > > src/meinproc.cpp 86e83ae > src/xslt.h 6fd2dae > src/xslt.cpp 70e0d6a > > Diff: https://git.reviewboard.kde.org/r/115818/diff/ > > > Testing > --- > > > Thanks, > > Luigi Toscano > > -- next part -- An HTML attachment was scrubbed... URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20140219/51268b91/attachment.html>
[kde-doc-english] Review Request 115818: Support more catalogs and reduce code duplication
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115818/#review50252 --- Ship it! Looks good. On the whole, I think this would be better as two separate commits (from the POV of git bisect), but I'm not going to push that. - Alex Merry On Feb. 16, 2014, 8:16 p.m., Luigi Toscano wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115818/ > --- > > (Updated Feb. 16, 2014, 8:16 p.m.) > > > Review request for Documentation and KDE Frameworks. > > > Repository: kdoctools > > > Description > --- > > Don't duplicate the code which searches the catalog(s) between xslt.cpp and > meinproc.cpp, centralize it in getAllKDocToolsCatalogs. > > Also, allow the usage of multiple catalogs (catalog.xml is always the main > one); this can be useful to allow other modules to drop-in other DTD > definitions (for example, if the main DTD is changed to use DocBook XML 4.5 > instead of 4.2, the 4.2-based can be defined in a compatibility catalog > installed by kde4support). > > > Diffs > - > > src/meinproc.cpp 86e83ae > src/xslt.h 6fd2dae > src/xslt.cpp 70e0d6a > > Diff: https://git.reviewboard.kde.org/r/115818/diff/ > > > Testing > --- > > > Thanks, > > Luigi Toscano > > -- next part -- An HTML attachment was scrubbed... URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20140219/60be887f/attachment.html>
[kde-doc-english] Review Request 115744: The WIN32 part of this if statement doesn't seem to work -> drop it
> On Feb. 19, 2014, 2:52 p.m., Alex Merry wrote: > > src/CMakeLists.txt, lines 63-67 > > <https://git.reviewboard.kde.org/r/115744/diff/1/?file=243985#file243985line63> > > > > This warning no longer applies, right? In that, since we no longer > > have a monolithic kdelibs, we can just use relative paths in the xsl files. I'm not sure it does not apply: the files are not installed either while building kdoctools alone, but I could have mistaken that part. As I said, it was changed by the kde-windows team as it caused issues with emerge, and I can't really say if it's still the case or not. - Luigi --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115744/#review50247 --- On Feb. 14, 2014, 12:29 a.m., Alexander Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115744/ > --- > > (Updated Feb. 14, 2014, 12:29 a.m.) > > > Review request for Documentation, KDE Frameworks, kdewin, and Luigi Toscano. > > > Repository: kdoctools > > > Description > --- > > The WIN32 part of this if statement doesn't seem to work -> drop it > > The frameworks using KDocTools fail otherwise complaining about invalid > paths (Win32 build) > > Without this patch I get the following error: > > file:///C:/ProgramData/kdoctools5/customization/dtd/kdex.dtd:102: warning: > failed to load external entity > "file:///emerge-root/share/xml/docbook/schema/dtd/4.2/docbookx.dtd" > > The path there is actually correct and should work. However, it seems that > XSLT does not accept paths starting with a / on windows. Using / is fine > and evaluates to the root directory of the current drive. > > > Diffs > - > > src/CMakeLists.txt 241d56ffdb9f5cf4859eaf06aad491b9e1ca94fa > > Diff: https://git.reviewboard.kde.org/r/115744/diff/ > > > Testing > --- > > kservice didn't compile before this change, now it does (win32), doesn't > affect other platforms > > > Thanks, > > Alexander Richardson > > -- next part -- An HTML attachment was scrubbed... URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20140219/1b30a168/attachment.html>
[kde-doc-english] Review Request 115744: The WIN32 part of this if statement doesn't seem to work -> drop it
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115744/#review50247 --- src/CMakeLists.txt <https://git.reviewboard.kde.org/r/115744/#comment35372> This warning no longer applies, right? In that, since we no longer have a monolithic kdelibs, we can just use relative paths in the xsl files. - Alex Merry On Feb. 14, 2014, 12:29 a.m., Alexander Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115744/ > --- > > (Updated Feb. 14, 2014, 12:29 a.m.) > > > Review request for Documentation, KDE Frameworks, kdewin, and Luigi Toscano. > > > Repository: kdoctools > > > Description > --- > > The WIN32 part of this if statement doesn't seem to work -> drop it > > The frameworks using KDocTools fail otherwise complaining about invalid > paths (Win32 build) > > Without this patch I get the following error: > > file:///C:/ProgramData/kdoctools5/customization/dtd/kdex.dtd:102: warning: > failed to load external entity > "file:///emerge-root/share/xml/docbook/schema/dtd/4.2/docbookx.dtd" > > The path there is actually correct and should work. However, it seems that > XSLT does not accept paths starting with a / on windows. Using / is fine > and evaluates to the root directory of the current drive. > > > Diffs > - > > src/CMakeLists.txt 241d56ffdb9f5cf4859eaf06aad491b9e1ca94fa > > Diff: https://git.reviewboard.kde.org/r/115744/diff/ > > > Testing > --- > > kservice didn't compile before this change, now it does (win32), doesn't > affect other platforms > > > Thanks, > > Alexander Richardson > > -- next part -- An HTML attachment was scrubbed... URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20140219/3a44f8d8/attachment.html>
[kde-doc-english] Review Request 115896: Import FindDocBook*.cmake from extra-cmake-modules
> On Feb. 19, 2014, 12:52 p.m., Luigi Toscano wrote: > > Sorry for the low cmake-fu, but does that change in CMakeLists.txt mean > > that they are going to exported? No, it's just to allow CMake to find them when it's configuring kdoctools. - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115896/#review50219 --- On Feb. 19, 2014, 12:47 p.m., Alex Merry wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115896/ > --- > > (Updated Feb. 19, 2014, 12:47 p.m.) > > > Review request for Documentation, KDE Frameworks and Luigi Toscano. > > > Repository: kdoctools > > > Description > --- > > Commits imported with `git format-patch` (edited), followed by `git am`. > > > Add the local cmake directory to the CMake module path > > > Use the newer syntax in FindDocBook* > > It approprietly sets the _FOUND variables, we were defining the all > uppercase instead. > Sorry for the mess! > > Originally commit 190c79bb4e6bc8b8757bd890485a9bafb4a65219 of the > extra-cmake-modules repository > > Move FindDocBook* to find-modules > > Originally commit d42d5889d25ac4c900a294f283dd802eccf96010 of the > extra-cmake-modules repository > > > Diffs > - > > CMakeLists.txt d135e0caa55d126ba3c335b9f05f8125453c1e53 > cmake/FindDocBookXML.cmake PRE-CREATION > cmake/FindDocBookXSL.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/115896/diff/ > > > Testing > --- > > Removed FindDocBook*.cmake from $PREFIX/share/ECM/find-modules, and a clean > configure, build, install still works. > > > Thanks, > > Alex Merry > > -- next part -- An HTML attachment was scrubbed... URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20140219/fcf55c39/attachment.html>
[kde-doc-english] Review Request 115896: Import FindDocBook*.cmake from extra-cmake-modules
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115896/#review50219 --- Sorry for the low cmake-fu, but does that change in CMakeLists.txt mean that they are going to exported? - Luigi Toscano On Feb. 19, 2014, 12:47 p.m., Alex Merry wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115896/ > --- > > (Updated Feb. 19, 2014, 12:47 p.m.) > > > Review request for Documentation, KDE Frameworks and Luigi Toscano. > > > Repository: kdoctools > > > Description > --- > > Commits imported with `git format-patch` (edited), followed by `git am`. > > > Add the local cmake directory to the CMake module path > > > Use the newer syntax in FindDocBook* > > It approprietly sets the _FOUND variables, we were defining the all > uppercase instead. > Sorry for the mess! > > Originally commit 190c79bb4e6bc8b8757bd890485a9bafb4a65219 of the > extra-cmake-modules repository > > Move FindDocBook* to find-modules > > Originally commit d42d5889d25ac4c900a294f283dd802eccf96010 of the > extra-cmake-modules repository > > > Diffs > - > > CMakeLists.txt d135e0caa55d126ba3c335b9f05f8125453c1e53 > cmake/FindDocBookXML.cmake PRE-CREATION > cmake/FindDocBookXSL.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/115896/diff/ > > > Testing > --- > > Removed FindDocBook*.cmake from $PREFIX/share/ECM/find-modules, and a clean > configure, build, install still works. > > > Thanks, > > Alex Merry > > -- next part -- An HTML attachment was scrubbed... URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20140219/fc8719dc/attachment.html>
[kde-doc-english] Review Request 115896: Import FindDocBook*.cmake from extra-cmake-modules
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115896/ --- Review request for Documentation, KDE Frameworks and Luigi Toscano. Repository: kdoctools Description --- Commits imported with `git format-patch` (edited), followed by `git am`. Add the local cmake directory to the CMake module path Use the newer syntax in FindDocBook* It approprietly sets the _FOUND variables, we were defining the all uppercase instead. Sorry for the mess! Originally commit 190c79bb4e6bc8b8757bd890485a9bafb4a65219 of the extra-cmake-modules repository Move FindDocBook* to find-modules Originally commit d42d5889d25ac4c900a294f283dd802eccf96010 of the extra-cmake-modules repository Diffs - CMakeLists.txt d135e0caa55d126ba3c335b9f05f8125453c1e53 cmake/FindDocBookXML.cmake PRE-CREATION cmake/FindDocBookXSL.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/115896/diff/ Testing --- Removed FindDocBook*.cmake from $PREFIX/share/ECM/find-modules, and a clean configure, build, install still works. Thanks, Alex Merry -- next part -- An HTML attachment was scrubbed... URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20140219/f15428fa/attachment.html>
[kde-doc-english] [kajongg] /: update remaining old version numbers to 4.13
Git commit 5b30aa4ec673ab557169bf4cd957c39f9227f55c by Wolfgang Rohdewald. Committed on 17/02/2014 at 19:30. Pushed by wrohdewald into branch 'master'. update remaining old version numbers to 4.13 M +3-3doc/index.docbook M +1-1setup.py http://commits.kde.org/kajongg/5b30aa4ec673ab557169bf4cd957c39f9227f55c diff --git a/doc/index.docbook b/doc/index.docbook index 3c9c529..c5665eb 100644 --- a/doc/index.docbook +++ b/doc/index.docbook @@ -3,7 +3,7 @@ Kajongg"> - + @@ -49,8 +49,8 @@ &FDLNotice; -2013-09-02 -&kappversion; (&kde; 4.12) +2014-02-20 +&kappversion; (&kde; 4.13) diff --git a/setup.py b/setup.py index 49b5eca..062c441 100755 --- a/setup.py +++ b/setup.py @@ -26,7 +26,7 @@ if not hasattr(sys, 'version_info') or sys.version_info < (2, 6, 0, 'final'): FULLAUTHOR = "Wolfgang Rohdewald " LICENSE = 'GNU General Public License v2' URL = "http://www.kde.org/applications/games/kajongg/"; -VERSION = "4.11.0" +VERSION = "4.13.0" # ===
[kde-doc-english] [palapeli] doc: add missing 'are'
Git commit a3127ddd1e9563bd448bdd54e349767af8f3419b by Burkhard L?ck. Committed on 19/02/2014 at 08:12. Pushed by lueck into branch 'master'. add missing 'are' M +1-1doc/index.docbook http://commits.kde.org/palapeli/a3127ddd1e9563bd448bdd54e349767af8f3419b diff --git a/doc/index.docbook b/doc/index.docbook index 0c64b73..29c4ba8 100644 --- a/doc/index.docbook +++ b/doc/index.docbook @@ -279,7 +279,7 @@ window. ViewBack to collection - Go back to the collection to choose another puzzle. Can be used only when you solving a puzzle. + Go back to the collection to choose another puzzle. Can be used only when you are solving a puzzle.
[kde-doc-english] How to enable / control reconq plug-ins?
Wed, 19 Feb 2014 04:12:58 +0200, Kirk Fraser : > Hi, > > Attempting to watch free Hulu shows, the first time worked great. Now > the > Hulu page often demands I download a new Adobe Flash Player before > continuing. Sometimes I have fiddled around and lucked out. But I have > no > idea what I really did or need to do. When I looked up in Configure > Rekonq > and enter the KDE help center, the only applicable help is "How do I load > flash on demand?" It says go to WebKit Plugis and select Manually Load > Plugins. This does not help. > > Where is the Plugins control menu like in Windows browsers? I don't know > what plugins are available, why Adobe flash is not working, where, how to > get them hooked up to reconq so they always load instead of always > requesting a new download, or even which download I need, the tar.gz or > the > .rpm or what? > > Please advise, thank you. > > Kirk W. Fraser Hi, You just need to install flash-plugin package for your distribution. Rekonq should detect and use it automatically. Hope this helps. Best regards, Yuri
