D22799: Adding new .docbook for KAddressBook, draft version

2019-07-31 Thread David Bryant 
davidbryant updated this revision to Diff 62874.
davidbryant added a comment.


  
  
  1. Updating D22799 : Adding new .docbook 
for KAddressBook, draft version #
  
  Incorporated changes suggested by Burkhard Lueck
  Remember, this is still a rough draft. I was intending to remove Konqui and 
Tux eventually, in my final draft. I still have many chapters to write. Please 
be patient.

REPOSITORY
  R204 KAddressBook

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22799?vs=62845=62874

BRANCH
  docbook_0.0 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22799

AFFECTED FILES
  index.docbook

To: davidbryant, #documentation, #kde_pim
Cc: lueck, ognarb, kde-pim, kde-doc-english, gennad, fbampaloukas, skadinna, 
dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil

Re: Error in template/messages/playground-base/ktrip.pot

2019-07-31 Thread Yuri Chornoivan 
31 липня 2019, 15:36:35, від "Freek de Kruijf" : > The 
plural "%2 changes" in templates/messages/playground-base/ktrip.pot should > be 
"%1 changes". Otherwise the file nl/messages/playground-base/ktrip.po will > 
not be accepted. > > -- > vr.gr. > > vertaler van KDE > Freek de Kruijf > 
Fixed. Thanks. Best regards, Yuri

D22799: Adding new .docbook for KAddressBook, draft version

2019-07-31 Thread Burkhard Lück 
lueck added inline comments.

INLINE COMMENTS

> index.docbook:11
> +
> +
> +

please add a line with:

The  Handbook

REPOSITORY
  R204 KAddressBook

REVISION DETAIL
  https://phabricator.kde.org/D22799

To: davidbryant, #documentation, #kde_pim
Cc: lueck, ognarb, kde-pim, kde-doc-english, gennad, fbampaloukas, skadinna, 
dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil

D22799: Adding new .docbook for KAddressBook, draft version

2019-07-31 Thread Burkhard Lück 
lueck added inline comments.

INLINE COMMENTS

> index.docbook:435
> +  Program copyright ??? John Q. Hacker j...@kde.org
> +  
> +  

KAddressBook -> Help -> About KAddressBook reads:
"Copyright © 2007–2019 KAddressBook authors", please use it

> index.docbook:437-443
> +  
> +  Contributors:
> +  
> +  Konqui the  Dragon 
> kon...@kde.org
> +  Tux the  Penguin 
> t...@linux.org
> +  
> +  

Please remove these lines, it is just a placeholder from the template

REPOSITORY
  R204 KAddressBook

REVISION DETAIL
  https://phabricator.kde.org/D22799

To: davidbryant, #documentation, #kde_pim
Cc: lueck, ognarb, kde-pim, kde-doc-english, gennad, fbampaloukas, skadinna, 
dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil

Error in template/messages/playground-base/ktrip.pot

2019-07-31 Thread Freek de Kruijf 
The plural "%2 changes" in templates/messages/playground-base/ktrip.pot should 
be "%1 changes". Otherwise the file nl/messages/playground-base/ktrip.po will 
not be accepted.

-- 
vr.gr.

vertaler van KDE
Freek de Kruijf

D22799: Adding new .docbook for KAddressBook, draft version

2019-07-31 Thread David Bryant 
davidbryant updated this revision to Diff 62845.
davidbryant added a comment.


  
  
  1. Updating D22799 : Adding new .docbook 
for KAddressBook, draft version #
  
  I made the changes Lueck suggested, plus a few more cosmetic adjustments.
  I finally understand that both CCBYSA4 and underCCBYSA4 (XML entities) must 
be present in index.docbook

REPOSITORY
  R204 KAddressBook

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22799?vs=62707=62845

BRANCH
  docbook_0.0 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22799

AFFECTED FILES
  index.docbook

To: davidbryant, #documentation, #kde_pim
Cc: lueck, ognarb, kde-pim, kde-doc-english, gennad, fbampaloukas, skadinna, 
dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil

D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7

2019-07-31 Thread Friedrich W. H. Kossebau 
This revision was automatically updated to reflect the committed changes.
Closed by commit R264:1c08ce74d29f: Fix checking dirs for metainfo.yaml with 
non-ascii chars with Python 2.7 (authored by kossebau).

REPOSITORY
  R264 KApiDox

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22836?vs=62808=62834

REVISION DETAIL
  https://phabricator.kde.org/D22836

AFFECTED FILES
  src/kapidox/preprocessing.py

To: kossebau, ochurlaud, bshah, aacid, lbeltrame
Cc: lbeltrame, davidre, aacid, pino, kde-frameworks-devel, kde-doc-english, 
LeGast00n, sbergeron, gennad, fbampaloukas, michaelh, ngraham, bruns, skadinna

D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7

2019-07-31 Thread Luca Beltrame 
lbeltrame accepted this revision.
lbeltrame added a comment.


  Not the prettiest, but I've seen worse. ;)

REPOSITORY
  R264 KApiDox

BRANCH
  handlenonasciipathwpython27

REVISION DETAIL
  https://phabricator.kde.org/D22836

To: kossebau, ochurlaud, bshah, aacid, lbeltrame
Cc: lbeltrame, davidre, aacid, pino, kde-frameworks-devel, kde-doc-english, 
LeGast00n, sbergeron, gennad, fbampaloukas, michaelh, ngraham, bruns, skadinna

D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7

2019-07-31 Thread Bhushan Shah 
bshah accepted this revision.
bshah added a comment.


  As a short term workaround, this is fine, in terms of porting to python3 it 
will also need changes on our server zivo.kde.org which is hosting api.kde.org, 
right now every scripts including krazy2 and apidox generation scripts are too 
much complex, and current system is running Gentoo. So overall this asks for 
much more effort. https://invent.kde.org/branislavaz/documentation-generator is 
one of steps to tidify all this and get things working properly.
  
  For now I am in favor of submitting this.

REPOSITORY
  R264 KApiDox

BRANCH
  handlenonasciipathwpython27

REVISION DETAIL
  https://phabricator.kde.org/D22836

To: kossebau, ochurlaud, bshah, aacid
Cc: davidre, aacid, pino, kde-frameworks-devel, kde-doc-english, LeGast00n, 
sbergeron, gennad, fbampaloukas, michaelh, ngraham, bruns, skadinna