D22594: [Dolphin] Open Preferred Search Tool action

2019-10-08 Thread Piotr Dabrowski
pdabrowski marked 2 inline comments as done.
pdabrowski added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in dolphinmainwindow.cpp:916-919
> I don't get this connection. Can you explain what's needed for?

There is no other way to update the open_preferred_search_tool action *before* 
the Configure Shortcuts window is shown.
This action is then listed in that window, so it should be up-to-date when it 
is displayed.
This update is instantaneous if user made no changes to the search tools in the 
meantime.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D22594

To: pdabrowski, #dolphin, ngraham, elvisangelaccio
Cc: pkloc, kfm-devel, kde-doc-english, iasensio, fprice, gennad, MrPepe, 
fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, 
firef, ngraham, andrebarros, skadinna, emmanuelp, mikesomov


D22594: [Dolphin] Open Preferred Search Tool action

2019-10-08 Thread Piotr Dabrowski
pdabrowski updated this revision to Diff 67500.
pdabrowski marked 4 inline comments as done.

REPOSITORY
  R318 Dolphin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22594?vs=66163=67500

REVISION DETAIL
  https://phabricator.kde.org/D22594

AFFECTED FILES
  doc/index.docbook
  src/dolphinmainwindow.cpp
  src/dolphinmainwindow.h
  src/dolphinpart.cpp
  src/dolphinpart.h
  src/dolphinui.rc

To: pdabrowski, #dolphin, ngraham, elvisangelaccio
Cc: pkloc, kfm-devel, kde-doc-english, iasensio, fprice, gennad, MrPepe, 
fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, 
firef, ngraham, andrebarros, skadinna, emmanuelp, mikesomov


Re: Can we revisit https://phabricator.kde.org/D10068

2019-10-08 Thread laurent Montel
Le mardi 8 octobre 2019, 13:47:28 CEST David Bryant a écrit :
> On Tuesday, October 8, 2019 5:59:15 AM CDT James Thornber wrote:
> > Thanks that worked a treat! :)
> > 
> > However, there is absolutely no chance of me, or indeed any new user
> > finding that option!  [snip ...]
> 
> I'm working on the KMail documentation, and I'll be sure to give that button
> some extra ink, James. There are quite a few "plugins" that alter the basic
> program's appearance (by adding and subtracting menu items) and
> functionality. Not all of the features can be "prominent". There are too
> many features for that to be possible.
> 
> I'm still looking for someone who's willing to help me update the KMail
> documentation. I'm mainly looking for feedback and criticism. Takers?

Hi,
Where is your patch for documentation ?
I can't fix english text but I can help you to find features etc.
Regards

> 
> D. Bryant
> Canyon Lake, Texas


-- 
Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer 
KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, 
 www.kdab.fr KDAB - The Qt, C++ and OpenGL Experts - Platform-independent 
software solutions 




Re: Can we revisit https://phabricator.kde.org/D10068

2019-10-08 Thread David Bryant
On Tuesday, October 8, 2019 5:59:15 AM CDT James Thornber wrote:
> Thanks that worked a treat! :)
> 
> However, there is absolutely no chance of me, or indeed any new user finding
> that option!  [snip ...]
> 

I'm working on the KMail documentation, and I'll be sure to give that button 
some extra ink, James. There are quite a few "plugins" that alter the basic 
program's appearance (by adding and subtracting menu items) and functionality. 
Not all of the features can be "prominent". There are too many features for 
that to be possible.

I'm still looking for someone who's willing to help me update the KMail 
documentation. I'm mainly looking for feedback and criticism. Takers?

D. Bryant
Canyon Lake, Texas



signature.asc
Description: This is a digitally signed message part.