D29723: Adapt KMail to MessageComposer SendLater API changes
dvratil added a task: T13172: kdepim-apps-libs cleanup. REPOSITORY R206 KMail REVISION DETAIL https://phabricator.kde.org/D29723 To: dvratil, mlaurent Cc: kde-doc-english, kde-pim, gennad, fbampaloukas, skadinna, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
D29724: SendLaterAgent: merge libKF5SendLater library into the agent
dvratil added a task: T13172: kdepim-apps-libs cleanup. REPOSITORY R206 KMail REVISION DETAIL https://phabricator.kde.org/D29724 To: dvratil, mlaurent Cc: kde-doc-english, kde-pim, gennad, fbampaloukas, skadinna, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
D29724: SendLaterAgent: merge libKF5SendLater library into the agent
dvratil closed this revision. REPOSITORY R206 KMail REVISION DETAIL https://phabricator.kde.org/D29724 To: dvratil, mlaurent Cc: kde-doc-english, kde-pim, gennad, fbampaloukas, skadinna, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
D29723: Adapt KMail to MessageComposer SendLater API changes
dvratil closed this revision. REPOSITORY R206 KMail REVISION DETAIL https://phabricator.kde.org/D29723 To: dvratil, mlaurent Cc: kde-doc-english, kde-pim, gennad, fbampaloukas, skadinna, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
D29724: SendLaterAgent: merge libKF5SendLater library into the agent
dvratil marked 3 inline comments as done. dvratil added inline comments. INLINE COMMENTS > mlaurent wrote in sendlaterutil.cpp:32 > #include "sendlaterinfo.h" Done on line 24. REPOSITORY R206 KMail REVISION DETAIL https://phabricator.kde.org/D29724 To: dvratil, mlaurent Cc: kde-doc-english, kde-pim, gennad, fbampaloukas, skadinna, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
D29724: SendLaterAgent: merge libKF5SendLater library into the agent
dvratil updated this revision to Diff 83039. dvratil added a comment. - Remove useless include REPOSITORY R206 KMail CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29724?vs=82929=83039 BRANCH arcpatch-D29724 REVISION DETAIL https://phabricator.kde.org/D29724 AFFECTED FILES agents/sendlateragent/CMakeLists.txt agents/sendlateragent/autotests/CMakeLists.txt agents/sendlateragent/autotests/sendlaterconfigtest.cpp agents/sendlateragent/autotests/sendlaterdialogtest.cpp agents/sendlateragent/autotests/sendlaterdialogtest.h agents/sendlateragent/autotests/sendlaterinfotest.cpp agents/sendlateragent/autotests/sendlaterinfotest.h agents/sendlateragent/autotests/sendlaterutiltest.cpp agents/sendlateragent/autotests/sendlaterutiltest.h agents/sendlateragent/org.freedesktop.Akonadi.SendLaterAgent.xml agents/sendlateragent/sendlateragent.cpp agents/sendlateragent/sendlateragent.h agents/sendlateragent/sendlateragentsettings.kcfg agents/sendlateragent/sendlateragentsettings.kcfgc agents/sendlateragent/sendlaterconfigurewidget.cpp agents/sendlateragent/sendlaterconfigurewidget.h agents/sendlateragent/sendlaterjob.cpp agents/sendlateragent/sendlaterjob.h agents/sendlateragent/sendlatermanager.cpp agents/sendlateragent/sendlatermanager.h agents/sendlateragent/sendlaterutil.cpp agents/sendlateragent/sendlaterutil.h agents/sendlateragent/sendlaterutil_p.h agents/sendlateragent/tests/CMakeLists.txt agents/sendlateragent/tests/sendlaterinfo_gui.cpp To: dvratil, mlaurent Cc: kde-doc-english, kde-pim, gennad, fbampaloukas, skadinna, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
D29724: SendLaterAgent: merge libKF5SendLater library into the agent
dvratil updated this revision to Diff 82929. dvratil added a comment. - Fix arc going crazy REPOSITORY R206 KMail CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29724?vs=82928=82929 BRANCH arcpatch-D29724 REVISION DETAIL https://phabricator.kde.org/D29724 AFFECTED FILES agents/sendlateragent/CMakeLists.txt agents/sendlateragent/autotests/CMakeLists.txt agents/sendlateragent/autotests/sendlaterconfigtest.cpp agents/sendlateragent/autotests/sendlaterdialogtest.cpp agents/sendlateragent/autotests/sendlaterdialogtest.h agents/sendlateragent/autotests/sendlaterinfotest.cpp agents/sendlateragent/autotests/sendlaterinfotest.h agents/sendlateragent/autotests/sendlaterutiltest.cpp agents/sendlateragent/autotests/sendlaterutiltest.h agents/sendlateragent/org.freedesktop.Akonadi.SendLaterAgent.xml agents/sendlateragent/sendlateragent.cpp agents/sendlateragent/sendlateragent.h agents/sendlateragent/sendlateragentsettings.kcfg agents/sendlateragent/sendlateragentsettings.kcfgc agents/sendlateragent/sendlaterconfigurewidget.cpp agents/sendlateragent/sendlaterconfigurewidget.h agents/sendlateragent/sendlaterjob.cpp agents/sendlateragent/sendlaterjob.h agents/sendlateragent/sendlatermanager.cpp agents/sendlateragent/sendlatermanager.h agents/sendlateragent/sendlaterutil.cpp agents/sendlateragent/sendlaterutil.h agents/sendlateragent/sendlaterutil_p.h agents/sendlateragent/tests/CMakeLists.txt agents/sendlateragent/tests/sendlaterinfo_gui.cpp To: dvratil, mlaurent Cc: kde-doc-english, kde-pim, gennad, fbampaloukas, skadinna, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
D29724: SendLaterAgent: merge libKF5SendLater library into the agent
dvratil updated this revision to Diff 82928. dvratil added a comment. Herald added a project: Documentation. Herald added a subscriber: kde-doc-english. - Address review comments REPOSITORY R206 KMail CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29724?vs=82769=82928 BRANCH arcpatch-D29724 REVISION DETAIL https://phabricator.kde.org/D29724 AFFECTED FILES .gitignore .krazy CMakeLists.txt MAINTAINERS agents/archivemailagent/CMakeLists.txt agents/archivemailagent/addarchivemaildialog.cpp agents/archivemailagent/addarchivemaildialog.h agents/archivemailagent/akonadi_archivemail_agent.notifyrc agents/archivemailagent/archivemailagent.cpp agents/archivemailagent/archivemailagent.desktop agents/archivemailagent/archivemailagent.h agents/archivemailagent/archivemailagentutil.cpp agents/archivemailagent/archivemailagentutil.h agents/archivemailagent/archivemailinfo.cpp agents/archivemailagent/archivemailinfo.h agents/archivemailagent/archivemailkernel.cpp agents/archivemailagent/archivemailkernel.h agents/archivemailagent/archivemailmanager.cpp agents/archivemailagent/archivemailmanager.h agents/archivemailagent/archivemailwidget.cpp agents/archivemailagent/archivemailwidget.h agents/archivemailagent/autotests/CMakeLists.txt agents/archivemailagent/autotests/archivemailinfotest.cpp agents/archivemailagent/autotests/archivemailinfotest.h agents/archivemailagent/autotests/archivemailwidgettest.cpp agents/archivemailagent/autotests/archivemailwidgettest.h agents/archivemailagent/autotests/formatcomboboxtest.cpp agents/archivemailagent/autotests/formatcomboboxtest.h agents/archivemailagent/autotests/unitcomboboxtest.cpp agents/archivemailagent/autotests/unitcomboboxtest.h agents/archivemailagent/job/archivejob.cpp agents/archivemailagent/job/archivejob.h agents/archivemailagent/widgets/formatcombobox.cpp agents/archivemailagent/widgets/formatcombobox.h agents/archivemailagent/widgets/unitcombobox.cpp agents/archivemailagent/widgets/unitcombobox.h agents/followupreminderagent/CMakeLists.txt agents/followupreminderagent/akonadi_followupreminder_agent.notifyrc agents/followupreminderagent/autotests/CMakeLists.txt agents/followupreminderagent/autotests/followupreminderconfigtest.cpp agents/followupreminderagent/autotests/followupreminderconfigtest.h agents/followupreminderagent/autotests/followupreminderinfotest.cpp agents/followupreminderagent/autotests/followupreminderinfotest.h agents/followupreminderagent/autotests/followupremindernoanswerdialogtest.cpp agents/followupreminderagent/autotests/followupremindernoanswerdialogtest.h agents/followupreminderagent/followupreminder.desktop agents/followupreminderagent/followupreminderagent.cpp agents/followupreminderagent/followupreminderagent.h agents/followupreminderagent/followupreminderinfoconfigwidget.cpp agents/followupreminderagent/followupreminderinfoconfigwidget.h agents/followupreminderagent/followupreminderinfowidget.cpp agents/followupreminderagent/followupreminderinfowidget.h agents/followupreminderagent/followupremindermanager.cpp agents/followupreminderagent/followupremindermanager.h agents/followupreminderagent/followupremindernoanswerdialog.cpp agents/followupreminderagent/followupremindernoanswerdialog.h agents/followupreminderagent/jobs/followupreminderfinishtaskjob.cpp agents/followupreminderagent/jobs/followupreminderfinishtaskjob.h agents/followupreminderagent/jobs/followupreminderjob.cpp agents/followupreminderagent/jobs/followupreminderjob.h agents/followupreminderagent/jobs/followupremindershowmessagejob.cpp agents/followupreminderagent/jobs/followupremindershowmessagejob.h agents/followupreminderagent/org.freedesktop.Akonadi.FollowUpReminder.xml agents/followupreminderagent/org.freedesktop.DBus.Properties.xml agents/followupreminderagent/org.freedesktop.Notifications.xml agents/mailfilteragent/CMakeLists.txt agents/mailfilteragent/akonadi_mailfilter_agent.notifyrc agents/mailfilteragent/autotests/CMakeLists.txt agents/mailfilteragent/autotests/configurewidgettest.cpp agents/mailfilteragent/autotests/configurewidgettest.h agents/mailfilteragent/config/configurewidget.cpp agents/mailfilteragent/config/configurewidget.h agents/mailfilteragent/filterlogdialog.cpp agents/mailfilteragent/filterlogdialog.h agents/mailfilteragent/filtermanager.cpp agents/mailfilteragent/filtermanager.h agents/mailfilteragent/mailfilteragent.cpp agents/mailfilteragent/mailfilteragent.desktop agents/mailfilteragent/mailfilteragent.h agents/mailfilteragent/mailfilterpurposemenuwidget.cpp agents/mailfilteragent/mailfilterpurposemenuwidget.h agents/sendlateragent/CMakeLists.txt agents/sendlateragent/akonadi_sendlater_agent.notifyrc agents/sendlateragent/autotests/CMakeLists.txt agents/sendlateragent/autotests/sendlaterconfigtest.cpp agents/sendlateragent/autotests/sendlaterconfigtest.h
D29723: Adapt KMail to MessageComposer SendLater API changes
dvratil updated this revision to Diff 82812. dvratil added a comment. Herald added a project: Documentation. Herald added a subscriber: kde-doc-english. - Update messagelib dependency REPOSITORY R206 KMail CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29723?vs=82768=82812 BRANCH sendlater-refactor REVISION DETAIL https://phabricator.kde.org/D29723 AFFECTED FILES .gitignore .krazy CMakeLists.txt MAINTAINERS agents/archivemailagent/CMakeLists.txt agents/archivemailagent/addarchivemaildialog.cpp agents/archivemailagent/addarchivemaildialog.h agents/archivemailagent/akonadi_archivemail_agent.notifyrc agents/archivemailagent/archivemailagent.cpp agents/archivemailagent/archivemailagent.desktop agents/archivemailagent/archivemailagent.h agents/archivemailagent/archivemailagentutil.cpp agents/archivemailagent/archivemailagentutil.h agents/archivemailagent/archivemailinfo.cpp agents/archivemailagent/archivemailinfo.h agents/archivemailagent/archivemailkernel.cpp agents/archivemailagent/archivemailkernel.h agents/archivemailagent/archivemailmanager.cpp agents/archivemailagent/archivemailmanager.h agents/archivemailagent/archivemailwidget.cpp agents/archivemailagent/archivemailwidget.h agents/archivemailagent/autotests/CMakeLists.txt agents/archivemailagent/autotests/archivemailinfotest.cpp agents/archivemailagent/autotests/archivemailinfotest.h agents/archivemailagent/autotests/archivemailwidgettest.cpp agents/archivemailagent/autotests/archivemailwidgettest.h agents/archivemailagent/autotests/formatcomboboxtest.cpp agents/archivemailagent/autotests/formatcomboboxtest.h agents/archivemailagent/autotests/unitcomboboxtest.cpp agents/archivemailagent/autotests/unitcomboboxtest.h agents/archivemailagent/job/archivejob.cpp agents/archivemailagent/job/archivejob.h agents/archivemailagent/widgets/formatcombobox.cpp agents/archivemailagent/widgets/formatcombobox.h agents/archivemailagent/widgets/unitcombobox.cpp agents/archivemailagent/widgets/unitcombobox.h agents/followupreminderagent/CMakeLists.txt agents/followupreminderagent/akonadi_followupreminder_agent.notifyrc agents/followupreminderagent/autotests/CMakeLists.txt agents/followupreminderagent/autotests/followupreminderconfigtest.cpp agents/followupreminderagent/autotests/followupreminderconfigtest.h agents/followupreminderagent/autotests/followupreminderinfotest.cpp agents/followupreminderagent/autotests/followupreminderinfotest.h agents/followupreminderagent/autotests/followupremindernoanswerdialogtest.cpp agents/followupreminderagent/autotests/followupremindernoanswerdialogtest.h agents/followupreminderagent/followupreminder.desktop agents/followupreminderagent/followupreminderagent.cpp agents/followupreminderagent/followupreminderagent.h agents/followupreminderagent/followupreminderinfoconfigwidget.cpp agents/followupreminderagent/followupreminderinfoconfigwidget.h agents/followupreminderagent/followupreminderinfowidget.cpp agents/followupreminderagent/followupreminderinfowidget.h agents/followupreminderagent/followupremindermanager.cpp agents/followupreminderagent/followupremindermanager.h agents/followupreminderagent/followupremindernoanswerdialog.cpp agents/followupreminderagent/followupremindernoanswerdialog.h agents/followupreminderagent/jobs/followupreminderfinishtaskjob.cpp agents/followupreminderagent/jobs/followupreminderfinishtaskjob.h agents/followupreminderagent/jobs/followupreminderjob.cpp agents/followupreminderagent/jobs/followupreminderjob.h agents/followupreminderagent/jobs/followupremindershowmessagejob.cpp agents/followupreminderagent/jobs/followupremindershowmessagejob.h agents/followupreminderagent/org.freedesktop.Akonadi.FollowUpReminder.xml agents/followupreminderagent/org.freedesktop.DBus.Properties.xml agents/followupreminderagent/org.freedesktop.Notifications.xml agents/mailfilteragent/CMakeLists.txt agents/mailfilteragent/akonadi_mailfilter_agent.notifyrc agents/mailfilteragent/autotests/CMakeLists.txt agents/mailfilteragent/autotests/configurewidgettest.cpp agents/mailfilteragent/autotests/configurewidgettest.h agents/mailfilteragent/config/configurewidget.cpp agents/mailfilteragent/config/configurewidget.h agents/mailfilteragent/filterlogdialog.cpp agents/mailfilteragent/filterlogdialog.h agents/mailfilteragent/filtermanager.cpp agents/mailfilteragent/filtermanager.h agents/mailfilteragent/mailfilteragent.cpp agents/mailfilteragent/mailfilteragent.desktop agents/mailfilteragent/mailfilteragent.h agents/mailfilteragent/mailfilterpurposemenuwidget.cpp agents/mailfilteragent/mailfilterpurposemenuwidget.h agents/sendlateragent/CMakeLists.txt agents/sendlateragent/akonadi_sendlater_agent.notifyrc agents/sendlateragent/autotests/sendlaterconfigtest.cpp agents/sendlateragent/autotests/sendlaterconfigtest.h
D29723: Adapt KMail to MessageComposer SendLater API changes
dvratil updated this revision to Diff 82813. dvratil added a comment. - Fix broken patch REPOSITORY R206 KMail CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29723?vs=82812=82813 BRANCH sendlater-refactor REVISION DETAIL https://phabricator.kde.org/D29723 AFFECTED FILES CMakeLists.txt src/CMakeLists.txt src/editor/kmcomposerwin.cpp src/undosend/undosendcreatejob.cpp To: dvratil, mlaurent Cc: kde-doc-english, kde-pim, gennad, fbampaloukas, skadinna, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
Re: Review Request 129561: update kontact-admin docbook to kf5
> On Dec. 3, 2016, 10:19 p.m., Daniel Vrátil wrote: > > Looks good to me > > Burkhard Lück wrote: > What about my question: > "There is not much content in this docbook and parts of these options are > already in the kmail handbook. > Maybe we should move everything into the kmail/kontact docbooks are and > delete this docbook?" > > Luigi Toscano wrote: > The changes themselves look good. IMHO (and waiting on developers), the > options for specific programs should be documented in the respective > documentation, and then there would probably be no need for this manual (even > if it was something left, it could go into the main kontact manual). Yup, makes sense to merge into kontact docbook. - Daniel --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129561/#review101254 --- On Nov. 26, 2016, 2:13 p.m., Burkhard Lück wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129561/ > --- > > (Updated Nov. 26, 2016, 2:13 p.m.) > > > Review request for Documentation, KDEPIM and Allen Winter. > > > Repository: kontact > > > Description > --- > > remove kappname + packages, no longer used > bump date + releaseinfo > remove "Outlook compatible invitation reply comments", I could not find it in > the code > remove empty chapter Common Problems > remove appendix > > There is not much content in this docbook and parts of these options are > already in the kmail handbook. > Maybe we should move everything into the kmail/kontact docbooks are and > delete this docbook? > Any comments? > > > Diffs > - > > doc/kontact-admin/index.docbook dd21a2c > > Diff: https://git.reviewboard.kde.org/r/129561/diff/ > > > Testing > --- > > passes checkXML5 > > > Thanks, > > Burkhard Lück > >
Re: Review Request 129561: update kontact-admin docbook to kf5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129561/#review101254 --- Ship it! Looks good to me - Daniel Vrátil On Nov. 26, 2016, 2:13 p.m., Burkhard Lück wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129561/ > --- > > (Updated Nov. 26, 2016, 2:13 p.m.) > > > Review request for Documentation, KDEPIM and Allen Winter. > > > Repository: kontact > > > Description > --- > > remove kappname + packages, no longer used > bump date + releaseinfo > remove "Outlook compatible invitation reply comments", I could not find it in > the code > remove empty chapter Common Problems > remove appendix > > There is not much content in this docbook and parts of these options are > already in the kmail handbook. > Maybe we should move everything into the kmail/kontact docbooks are and > delete this docbook? > Any comments? > > > Diffs > - > > doc/kontact-admin/index.docbook dd21a2c > > Diff: https://git.reviewboard.kde.org/r/129561/diff/ > > > Testing > --- > > passes checkXML5 > > > Thanks, > > Burkhard Lück > >
[kde-doc-english] [frameworks-kdoctools] [Bug 337442] kdoctools only builds a static lib
https://bugs.kde.org/show_bug.cgi?id=337442 Daniel Vr?til dvratil at redhat.com changed: What|Removed |Added CC||dvratil at redhat.com --- Comment #2 from Daniel Vr?til dvratil at redhat.com --- We ran into the same thing in Fedora - I was first arguing for making it a shared library, but after opening the header files, I found out that the library has no class and no namespace, !!NO COPYRIGHT HEADER!! and that the API has no real useful outside kdoctools. AFAIK the API is only used by the man:// slave in KIO, so the lack of proper API is justified. -- You are receiving this mail because: You are the assignee for the bug.
