D29724: SendLaterAgent: merge libKF5SendLater library into the agent
dvratil added a task: T13172: kdepim-apps-libs cleanup. REPOSITORY R206 KMail REVISION DETAIL https://phabricator.kde.org/D29724 To: dvratil, mlaurent Cc: kde-doc-english, kde-pim, gennad, fbampaloukas, skadinna, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
D29724: SendLaterAgent: merge libKF5SendLater library into the agent
dvratil closed this revision. REPOSITORY R206 KMail REVISION DETAIL https://phabricator.kde.org/D29724 To: dvratil, mlaurent Cc: kde-doc-english, kde-pim, gennad, fbampaloukas, skadinna, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
D29724: SendLaterAgent: merge libKF5SendLater library into the agent
mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R206 KMail BRANCH arcpatch-D29724 REVISION DETAIL https://phabricator.kde.org/D29724 To: dvratil, mlaurent Cc: kde-doc-english, kde-pim, gennad, fbampaloukas, skadinna, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
D29724: SendLaterAgent: merge libKF5SendLater library into the agent
dvratil marked 3 inline comments as done. dvratil added inline comments. INLINE COMMENTS > mlaurent wrote in sendlaterutil.cpp:32 > #include "sendlaterinfo.h" Done on line 24. REPOSITORY R206 KMail REVISION DETAIL https://phabricator.kde.org/D29724 To: dvratil, mlaurent Cc: kde-doc-english, kde-pim, gennad, fbampaloukas, skadinna, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
D29724: SendLaterAgent: merge libKF5SendLater library into the agent
dvratil updated this revision to Diff 83039. dvratil added a comment. - Remove useless include REPOSITORY R206 KMail CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29724?vs=82929=83039 BRANCH arcpatch-D29724 REVISION DETAIL https://phabricator.kde.org/D29724 AFFECTED FILES agents/sendlateragent/CMakeLists.txt agents/sendlateragent/autotests/CMakeLists.txt agents/sendlateragent/autotests/sendlaterconfigtest.cpp agents/sendlateragent/autotests/sendlaterdialogtest.cpp agents/sendlateragent/autotests/sendlaterdialogtest.h agents/sendlateragent/autotests/sendlaterinfotest.cpp agents/sendlateragent/autotests/sendlaterinfotest.h agents/sendlateragent/autotests/sendlaterutiltest.cpp agents/sendlateragent/autotests/sendlaterutiltest.h agents/sendlateragent/org.freedesktop.Akonadi.SendLaterAgent.xml agents/sendlateragent/sendlateragent.cpp agents/sendlateragent/sendlateragent.h agents/sendlateragent/sendlateragentsettings.kcfg agents/sendlateragent/sendlateragentsettings.kcfgc agents/sendlateragent/sendlaterconfigurewidget.cpp agents/sendlateragent/sendlaterconfigurewidget.h agents/sendlateragent/sendlaterjob.cpp agents/sendlateragent/sendlaterjob.h agents/sendlateragent/sendlatermanager.cpp agents/sendlateragent/sendlatermanager.h agents/sendlateragent/sendlaterutil.cpp agents/sendlateragent/sendlaterutil.h agents/sendlateragent/sendlaterutil_p.h agents/sendlateragent/tests/CMakeLists.txt agents/sendlateragent/tests/sendlaterinfo_gui.cpp To: dvratil, mlaurent Cc: kde-doc-english, kde-pim, gennad, fbampaloukas, skadinna, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
D29724: SendLaterAgent: merge libKF5SendLater library into the agent
mlaurent added inline comments. INLINE COMMENTS > mlaurent wrote in sendlaterutil_p.h:23 > not necessary no ? I think that we can remove this include no ? REPOSITORY R206 KMail REVISION DETAIL https://phabricator.kde.org/D29724 To: dvratil, mlaurent Cc: kde-doc-english, kde-pim, gennad, fbampaloukas, skadinna, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
D29724: SendLaterAgent: merge libKF5SendLater library into the agent
dvratil updated this revision to Diff 82929. dvratil added a comment. - Fix arc going crazy REPOSITORY R206 KMail CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29724?vs=82928=82929 BRANCH arcpatch-D29724 REVISION DETAIL https://phabricator.kde.org/D29724 AFFECTED FILES agents/sendlateragent/CMakeLists.txt agents/sendlateragent/autotests/CMakeLists.txt agents/sendlateragent/autotests/sendlaterconfigtest.cpp agents/sendlateragent/autotests/sendlaterdialogtest.cpp agents/sendlateragent/autotests/sendlaterdialogtest.h agents/sendlateragent/autotests/sendlaterinfotest.cpp agents/sendlateragent/autotests/sendlaterinfotest.h agents/sendlateragent/autotests/sendlaterutiltest.cpp agents/sendlateragent/autotests/sendlaterutiltest.h agents/sendlateragent/org.freedesktop.Akonadi.SendLaterAgent.xml agents/sendlateragent/sendlateragent.cpp agents/sendlateragent/sendlateragent.h agents/sendlateragent/sendlateragentsettings.kcfg agents/sendlateragent/sendlateragentsettings.kcfgc agents/sendlateragent/sendlaterconfigurewidget.cpp agents/sendlateragent/sendlaterconfigurewidget.h agents/sendlateragent/sendlaterjob.cpp agents/sendlateragent/sendlaterjob.h agents/sendlateragent/sendlatermanager.cpp agents/sendlateragent/sendlatermanager.h agents/sendlateragent/sendlaterutil.cpp agents/sendlateragent/sendlaterutil.h agents/sendlateragent/sendlaterutil_p.h agents/sendlateragent/tests/CMakeLists.txt agents/sendlateragent/tests/sendlaterinfo_gui.cpp To: dvratil, mlaurent Cc: kde-doc-english, kde-pim, gennad, fbampaloukas, skadinna, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
D29724: SendLaterAgent: merge libKF5SendLater library into the agent
dvratil updated this revision to Diff 82928. dvratil added a comment. Herald added a project: Documentation. Herald added a subscriber: kde-doc-english. - Address review comments REPOSITORY R206 KMail CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29724?vs=82769=82928 BRANCH arcpatch-D29724 REVISION DETAIL https://phabricator.kde.org/D29724 AFFECTED FILES .gitignore .krazy CMakeLists.txt MAINTAINERS agents/archivemailagent/CMakeLists.txt agents/archivemailagent/addarchivemaildialog.cpp agents/archivemailagent/addarchivemaildialog.h agents/archivemailagent/akonadi_archivemail_agent.notifyrc agents/archivemailagent/archivemailagent.cpp agents/archivemailagent/archivemailagent.desktop agents/archivemailagent/archivemailagent.h agents/archivemailagent/archivemailagentutil.cpp agents/archivemailagent/archivemailagentutil.h agents/archivemailagent/archivemailinfo.cpp agents/archivemailagent/archivemailinfo.h agents/archivemailagent/archivemailkernel.cpp agents/archivemailagent/archivemailkernel.h agents/archivemailagent/archivemailmanager.cpp agents/archivemailagent/archivemailmanager.h agents/archivemailagent/archivemailwidget.cpp agents/archivemailagent/archivemailwidget.h agents/archivemailagent/autotests/CMakeLists.txt agents/archivemailagent/autotests/archivemailinfotest.cpp agents/archivemailagent/autotests/archivemailinfotest.h agents/archivemailagent/autotests/archivemailwidgettest.cpp agents/archivemailagent/autotests/archivemailwidgettest.h agents/archivemailagent/autotests/formatcomboboxtest.cpp agents/archivemailagent/autotests/formatcomboboxtest.h agents/archivemailagent/autotests/unitcomboboxtest.cpp agents/archivemailagent/autotests/unitcomboboxtest.h agents/archivemailagent/job/archivejob.cpp agents/archivemailagent/job/archivejob.h agents/archivemailagent/widgets/formatcombobox.cpp agents/archivemailagent/widgets/formatcombobox.h agents/archivemailagent/widgets/unitcombobox.cpp agents/archivemailagent/widgets/unitcombobox.h agents/followupreminderagent/CMakeLists.txt agents/followupreminderagent/akonadi_followupreminder_agent.notifyrc agents/followupreminderagent/autotests/CMakeLists.txt agents/followupreminderagent/autotests/followupreminderconfigtest.cpp agents/followupreminderagent/autotests/followupreminderconfigtest.h agents/followupreminderagent/autotests/followupreminderinfotest.cpp agents/followupreminderagent/autotests/followupreminderinfotest.h agents/followupreminderagent/autotests/followupremindernoanswerdialogtest.cpp agents/followupreminderagent/autotests/followupremindernoanswerdialogtest.h agents/followupreminderagent/followupreminder.desktop agents/followupreminderagent/followupreminderagent.cpp agents/followupreminderagent/followupreminderagent.h agents/followupreminderagent/followupreminderinfoconfigwidget.cpp agents/followupreminderagent/followupreminderinfoconfigwidget.h agents/followupreminderagent/followupreminderinfowidget.cpp agents/followupreminderagent/followupreminderinfowidget.h agents/followupreminderagent/followupremindermanager.cpp agents/followupreminderagent/followupremindermanager.h agents/followupreminderagent/followupremindernoanswerdialog.cpp agents/followupreminderagent/followupremindernoanswerdialog.h agents/followupreminderagent/jobs/followupreminderfinishtaskjob.cpp agents/followupreminderagent/jobs/followupreminderfinishtaskjob.h agents/followupreminderagent/jobs/followupreminderjob.cpp agents/followupreminderagent/jobs/followupreminderjob.h agents/followupreminderagent/jobs/followupremindershowmessagejob.cpp agents/followupreminderagent/jobs/followupremindershowmessagejob.h agents/followupreminderagent/org.freedesktop.Akonadi.FollowUpReminder.xml agents/followupreminderagent/org.freedesktop.DBus.Properties.xml agents/followupreminderagent/org.freedesktop.Notifications.xml agents/mailfilteragent/CMakeLists.txt agents/mailfilteragent/akonadi_mailfilter_agent.notifyrc agents/mailfilteragent/autotests/CMakeLists.txt agents/mailfilteragent/autotests/configurewidgettest.cpp agents/mailfilteragent/autotests/configurewidgettest.h agents/mailfilteragent/config/configurewidget.cpp agents/mailfilteragent/config/configurewidget.h agents/mailfilteragent/filterlogdialog.cpp agents/mailfilteragent/filterlogdialog.h agents/mailfilteragent/filtermanager.cpp agents/mailfilteragent/filtermanager.h agents/mailfilteragent/mailfilteragent.cpp agents/mailfilteragent/mailfilteragent.desktop agents/mailfilteragent/mailfilteragent.h agents/mailfilteragent/mailfilterpurposemenuwidget.cpp agents/mailfilteragent/mailfilterpurposemenuwidget.h agents/sendlateragent/CMakeLists.txt agents/sendlateragent/akonadi_sendlater_agent.notifyrc agents/sendlateragent/autotests/CMakeLists.txt agents/sendlateragent/autotests/sendlaterconfigtest.cpp agents/sendlateragent/autotests/sendlaterconfigtest.h
