D7413: Adds missing dependency

2017-08-19 Thread Luigi Toscano
This revision was automatically updated to reflect the committed changes.
Closed by commit R125:db656fd3116b: Adds missing dependency (authored by bkchr, 
committed by ltoscano).

REPOSITORY
  R125 KHelpCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7413?vs=18392=18414

REVISION DETAIL
  https://phabricator.kde.org/D7413

AFFECTED FILES
  searchhandlers/CMakeLists.txt

To: bkchr, ltoscano
Cc: #documentation, skadinna


D7413: Adds missing dependency

2017-08-19 Thread Bastian Köcher
bkchr added a comment.


  No I don't have commit access, so it would be nice if you could merge that 
for me! Please use g...@kchr.de as email address.

REPOSITORY
  R125 KHelpCenter

REVISION DETAIL
  https://phabricator.kde.org/D7413

To: bkchr, ltoscano
Cc: #documentation, skadinna


D7413: Adds missing dependency

2017-08-19 Thread Luigi Toscano
ltoscano accepted this revision.
ltoscano added a comment.
This revision is now accepted and ready to land.


  Thanks; well, it's not a problem for NixOS only, the dependency should be 
explicit (if not brought up by some other dependency, which is not the case 
here). This should land in the Applications/17.08 branch. Do you have commit 
access? If no, I would need your email for the commit credentials.

REPOSITORY
  R125 KHelpCenter

REVISION DETAIL
  https://phabricator.kde.org/D7413

To: bkchr, ltoscano
Cc: #documentation, skadinna


D7413: Adds missing dependency

2017-08-19 Thread Bastian Köcher
bkchr created this revision.
Restricted Application added a project: Documentation.
Restricted Application added a subscriber: Documentation.

REVISION SUMMARY
  KF5::CoreAddons files are included by khc_xapianindexer, but not declared as 
dependency. For operating systems like Nixos that is a problem, because every 
dependency is located in a different path and so, the CoreAddons files are not 
found in the include path. By adding CoreAddons as target link library, the 
CoreAddon paths are added to the include paths.

REPOSITORY
  R125 KHelpCenter

REVISION DETAIL
  https://phabricator.kde.org/D7413

AFFECTED FILES
  searchhandlers/CMakeLists.txt

To: bkchr
Cc: #documentation, skadinna