Re: CMake usage requirements in KDE Frameworks
Alexander Neundorf wrote:
currently this breaks the stand-alone build of the libraries in tier1/ and
tier2/.
http://quickgit.kde.org/?p=kdelibs.gita=commitdiffh=56d571a223e00ffed4cb682eb098c5b1e347fa70
E.g. due to removing
include_directories(${kdeqt5staging_INCLUDE_DIRS})
from kcoreaddons/CMakeLists.txt, kcoreaddons does not find the
kdeqt5staging headers anymore when being built stand-alone.
You can do that by building the superbuild/ directory of kdelibs/.
That superbuild directory doesn't seem to work for me. Although I run cmake
on it with cmake master, it seems to try to use cmake 2.8.9 from my distro
when building the subprojects.
I reproduced the problem with a build of kcoreaddons alone.
What is your plan regarding moving this forward ?
As I wrote elsewhere in this thread, the plan going forward is to have cmake
populate the INTERFACE_INCLUDE_DIRECTORIES with the INSTALL_INTERFACE.
Until that is done we can either add code to do that ourselves (and remove
it later), or simply use include_directories() where you need it. I've
pushed a commit doing the former for kdeqt5staging, so tier1 libs which
depend on that should work in your superbuild again.
Thanks,
Steve.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 109551: port KPtyProcess to QProcess
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109551/#review29802 --- after extensive deliberation of the code i found that ... i have no clue what is wrong. you'll need to find out yourself (with strace -f -tt). one notable difference between kprocess and qprocess is that the output channel mode default differs (kprocess forwards, while qprocess collects). however, i wasn't able to come up with an obvious explanation how that would correlate with your hangs. - Oswald Buddenhagen On March 18, 2013, 7:54 p.m., Martin Tobias Holmedahl Sandsmark wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109551/ --- (Updated March 18, 2013, 7:54 p.m.) Review request for KDE Frameworks, kdelibs, David Faure, and Oswald Buddenhagen. Description --- Just a simple port of KPtyProcess away from using KProcess. Diffs - kpty/kptyprocess.h 5e0df96 kpty/kptyprocess.cpp 015a58c kpty/tests/kptyprocesstest.cpp 04990a0 Diff: http://git.reviewboard.kde.org/r/109551/diff/ Testing --- builds and tests pass. Thanks, Martin Tobias Holmedahl Sandsmark ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: CMake usage requirements in KDE Frameworks
Alexander Neundorf wrote: That superbuild directory doesn't seem to work for me. Although I run cmake on it with cmake master, it seems to try to use cmake 2.8.9 from my distro when building the subprojects. Hmm, for me it works as expected. What exactly did you do ? The problem was that I edited the cache using ccmake, but I didn't build ccmake from master - it came from distro packages, and when it configured, it used its own too-old cmake. Invoking cmake with -DBUILD_foo works. Thanks, Steve. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 109517: Port away from KListWidget to QListWidget
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109517/#review29819 --- Given that autoselect is disabled by default I'd say it's ok not to block on it, but i guess that's because i don't use that feature :D - Albert Astals Cid On March 24, 2013, 8:10 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109517/ --- (Updated March 24, 2013, 8:10 p.m.) Review request for KDE Frameworks. Description --- Move KListWidget to kde4support and replace uses with QListWidget Diffs - kdeui/CMakeLists.txt 03b1e8d kdeui/dialogs/kinputdialog.cpp 28ce074 kdeui/dialogs/kinputdialog_p.h 9b40158 kdeui/fonts/kfontchooser.cpp a445f43 kdeui/icons/kicondialog.cpp aeba58c kdeui/icons/kicondialog_p.h bc46295 kdeui/itemviews/klistwidget.h 48ef4d7 kdeui/itemviews/klistwidget.cpp 185db8b kdeui/widgets/kcompletionbox.h 1dabb1a kdeui/widgets/kcompletionbox.cpp a470621 khtml/rendering/render_form.h 28c3082 khtml/rendering/render_form.cpp 851a4dd staging/kde4support/src/CMakeLists.txt 0543844 staging/kde4support/src/kdeui/klistwidget.h PRE-CREATION staging/kde4support/src/kdeui/klistwidget.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/109517/diff/ Testing --- Compiles Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
