Re: Somebody interested in porting mingw manifest support into cmake ?

2013-03-26 Thread Ralf Habacker 

Am 24.03.2013 16:19, schrieb Alexander Neundorf:

Hi,

in kdelibs in the frameworks branch, we are trying to get rid of KDE-specific
extensions, both for Qt and for cmake.
This means also no longer kde4_add_executable(), but plain cmake
add_executable() instead.
kde_add_executable is a hook to extend basic cmake commands, which may 
still be required in the future for kde and/or other projects.
Do recent cmake releases have buildin support for extending basic cmake 
commands in a configurable manner or is it required to patch cmake c++ 
code for this ?




This means we loose the manifest support for mingw under Windows we currently
have.

To keep manifest support for mingw, somebody needs to port that to cmake.
The cmake developers signalles support for that idea, but we (i.e. somebody
from KDE) has to do it.



I don't have a windows machine, so this won't be me.



Volunteers ?



Thanks :-)
Alex
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: KTabWidget task

2013-03-26 Thread Kevin Ottens 
On Sunday 24 March 2013 10:01:37 David Faure wrote:
 On Sunday 24 March 2013 00:28:02 David Gil Oliva wrote:
  By the way, I have found KColorDialog in kde4support, but it seems that
  two tasks haven't been done yet (porting web color line edit and color
  picker button to QColorDialog). Won't they be implemented?

 Kévin?

They will (provided someone picks them up of course). They don't impact the
API, so that could be done in whatever order was most convenient at the time.

Regards.
--
Kévin Ottens, http://ervin.ipsquad.net

Sponsored by BlueSystems and KDAB to work on KDE Frameworks


signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 109667: Make some KConfig classes return a bool when saving

2013-03-26 Thread Albert Astals Cid 


 On March 23, 2013, 9:56 p.m., Oswald Buddenhagen wrote:
  tier2/kconfig/src/core/kconfig.cpp, line 440
  http://git.reviewboard.kde.org/r/109667/diff/2/?file=121088#file121088line440
 
  well, it appears to fit the pre-existing logic. any particular reason 
  why you are not sure?

What bothers me is that the d-bDirty is not there in 4.10 nor master, maybe we 
should put it there too?


- Albert


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109667/#review29769
---


On March 23, 2013, 3:47 p.m., Albert Astals Cid wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/109667/
 ---
 
 (Updated March 23, 2013, 3:47 p.m.)
 
 
 Review request for KDE Frameworks and Oswald Buddenhagen.
 
 
 Description
 ---
 
 If it can fail, i want to know it so i can tell my users
 
 Not totally sure of the
d-bDirty = true;
 i added in 
if (d-configState == ReadWrite  !tmp-lock()) {
 
 
 Diffs
 -
 
   KDE5PORTING.html a01f3ec 
   tier2/kconfig/autotests/kconfigguitest.cpp e6b4c17 
   tier2/kconfig/autotests/kconfigtest.h 17a5294 
   tier2/kconfig/autotests/kconfigtest.cpp 86ff718 
   tier2/kconfig/autotests/ksharedconfigtest.cpp 2bb612f 
   tier2/kconfig/src/core/kconfig.h 597330f 
   tier2/kconfig/src/core/kconfig.cpp 5809275 
   tier2/kconfig/src/core/kconfigbase.h ce190f3 
   tier2/kconfig/src/core/kconfiggroup.h ff63afa 
   tier2/kconfig/src/core/kconfiggroup.cpp 53cac13 
   tier2/kconfig/src/core/kcoreconfigskeleton.h 3e4971b 
   tier2/kconfig/src/core/kcoreconfigskeleton.cpp c0ad044 
 
 Diff: http://git.reviewboard.kde.org/r/109667/diff/
 
 
 Testing
 ---
 
 New Unitttest passes
 
 
 Thanks,
 
 Albert Astals Cid
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kdelibs_frameworks_qt5 #527

2013-03-26 Thread KDE CI System 
See http://build.kde.org/job/kdelibs_frameworks_qt5/527/changes

Changes:

[svenbrauch] If the provider file lists a register account URL, provide a 
link to that.

[adawit] Disable SSL compression to prevent the potential for CRIME based SSL 
attacks.

[aiacovitti] We do not paint css borders for input of type file.

[aiacovitti] Set the widget's background color to transparent when we have to 
paint

[lukas] recognize additional battery types

[scripty] SVN_SILENT made messages (.desktop file)

[aacid] Set d-bDirty back to true if we can't lock the global file

--
[...truncated 11009 lines...]
[ 80%] Generating kdewidgets.moc
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/kfile/kurlnavigator.cpp:54:5:
 warning: HAVE_X11 is not defined [-Wundef]
In file included from 
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/kfile/kurlnavigator.cpp:38:0:
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/kio/kio/kurifilter.h:732:128:
 warning: ‘ProviderInfoList’ is deprecated [-Wdeprecated-declarations]
In file included from 
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/kfile/kurlnavigator.cpp:1258:0:
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/build/kfile/moc_kurlnavigator.cpp:
 In static member function ‘static void 
KUrlNavigator::qt_static_metacall(QObject*, QMetaObject::Call, int, void**)’:
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/build/kfile/moc_kurlnavigator.cpp:179:71:
 warning: ‘void KUrlNavigator::setUrl(const QUrl)’ is deprecated (declared at 
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/kfile/kurlnavigator.cpp:1080)
 [-Wdeprecated-declarations]
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/build/kfile/moc_kurlnavigator.cpp:180:76:
 warning: ‘void KUrlNavigator::saveRootUrl(const QUrl)’ is deprecated 
(declared at 
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/kfile/kurlnavigator.cpp:1088)
 [-Wdeprecated-declarations]
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/build/kfile/moc_kurlnavigator.cpp:181:106:
 warning: ‘void KUrlNavigator::savePosition(int, int)’ is deprecated (declared 
at 
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/kfile/kurlnavigator.cpp:1096)
 [-Wdeprecated-declarations]
Linking CXX shared library ../lib/libkfile.so
In file included from 
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/staging/kservice/src/plugin/kpluginfactory.h:31:0,
 from 
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/staging/kservice/src/services/kservice.h:27,
 from 
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/knotify/config/knotifyconfigelement.cpp:27:
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/staging/kservice/src/plugin/kexportplugin.h:71:129:
 note: #pragma message: K_EXPORT_PLUGIN is defined as a hack here, for compat. 
Port to new plugin system (QT_PLUGIN_METADATA) instead.
[ 80%] [ 80%] Building CXX object 
knotify/config/CMakeFiles/knotifyconfig.dir/knotifyconfigwidget.cpp.o
Building CXX object kunitconversion/CMakeFiles/kunitconversion.dir/mass.cpp.o
Scanning dependencies of target kdewidgets
[ 80%] Building CXX object 
kdewidgets/CMakeFiles/kdewidgets.dir/classpreviews.cpp.o
[ 80%] Building CXX object 
kparts/CMakeFiles/kparts.dir/scriptableextension.cpp.o
[ 80%] Building CXX object 
knotify/config/CMakeFiles/knotifyconfig.dir/knotifyconfig_automoc.cpp.o
[ 80%] [ 80%] Building CXX object 
kunitconversion/CMakeFiles/kunitconversion.dir/pressure.cpp.o
Building CXX object 
knewstuff/knewstuff3/CMakeFiles/knewstuff3.dir/core/installation.cpp.o
[ 80%] Built target kfile
[ 80%] Building CXX object kparts/CMakeFiles/kparts.dir/textextension.cpp.o
[ 80%] Building CXX object kdewidgets/CMakeFiles/kdewidgets.dir/kdewidgets.cpp.o
[ 80%] Building CXX object 
kdewidgets/CMakeFiles/kdewidgets.dir/qrc_kdewidgets.cpp.o
Linking CXX shared library ../../lib/libknotifyconfig.so
[ 81%] Building CXX object 
kunitconversion/CMakeFiles/kunitconversion.dir/energy.cpp.o
[ 81%] Building CXX object 
knewstuff/knewstuff3/CMakeFiles/knewstuff3.dir/core/provider.cpp.o
[ 81%] Building CXX object 
kdewidgets/CMakeFiles/kdewidgets.dir/kdewidgets_automoc.cpp.o
[ 81%] Building CXX object 
kunitconversion/CMakeFiles/kunitconversion.dir/currency.cpp.o
[ 81%] Built target knotifyconfig
[ 81%] Building CXX object 
knewstuff/knewstuff3/CMakeFiles/knewstuff3.dir/core/security.cpp.o
[ 81%] Building CXX object kparts/CMakeFiles/kparts.dir/htmlextension.cpp.o
Scanning dependencies of target kiconloadertest
[ 81%] Building CXX object 
staging/kwidgets/tests/CMakeFiles/kiconloadertest.dir/kiconloadertest.cpp.o
Scanning dependencies of target kmessageboxtest
[ 81%] [ 81%] Building CXX object 
staging/kwidgets/tests/CMakeFiles/kmessageboxtest.dir/kmessageboxtest.cpp.o
Building CXX object 
staging/kwidgets/tests/CMakeFiles/kiconloadertest.dir/kiconloadertest_automoc.cpp.o
Linking CXX executable kiconloadertest
[ 81%] Building CXX object

Build failed in Jenkins: kdelibs_frameworks_qt5 #528

2013-03-26 Thread KDE CI System 
See http://build.kde.org/job/kdelibs_frameworks_qt5/528/changes

Changes:

[tsdgeos] Make some KConfig classes return a bool when saving

[tsdgeos] Compile

--
[...truncated 4467 lines...]
In file included from 
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/staging/kservice/src/plugin/kpluginfactory.h:31:0,
 from 
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/staging/kservice/src/plugin/klibrary.cpp:26:
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/staging/kservice/src/plugin/kexportplugin.h:71:129:
 note: #pragma message: K_EXPORT_PLUGIN is defined as a hack here, for compat. 
Port to new plugin system (QT_PLUGIN_METADATA) instead.
[ 36%] Generating test3.cpp, test3.h
[ 36%] [ 36%] Generating test3.moc
Generating test3a.cpp, test3a.h
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/build/tier2/kconfig/autotests/kconfig_compiler/test3.h:0:
 Note: No relevant classes found. No output generated.
[ 36%] Built target test12
[ 36%] [ 36%] Generating test4.cpp, test4.h
Generating test3a.moc
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/build/tier2/kconfig/autotests/kconfig_compiler/test3a.h:0:
 Note: No relevant classes found. No output generated.
[ 36%] Scanning dependencies of target test3
Generating test4.moc
[ 36%] Building CXX object 
tier2/kconfig/autotests/kconfig_compiler/CMakeFiles/test3.dir/test3main.cpp.o
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/build/tier2/kconfig/autotests/kconfig_compiler/test4.h:0:
 Note: No relevant classes found. No output generated.
Scanning dependencies of target test3a
[ 36%] Building CXX object 
tier2/kconfig/autotests/kconfig_compiler/CMakeFiles/test3a.dir/test3amain.cpp.o
Scanning dependencies of target test4
[ 36%] Building CXX object 
tier2/kconfig/autotests/kconfig_compiler/CMakeFiles/test4.dir/test4main.cpp.o
In file included from 
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/build/staging/kservice/src/../../../../staging/kservice/src/plugin/kpluginfactory.h:31:0,
 from 
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/build/staging/kservice/src/moc_kpluginfactory.cpp:9,
 from 
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/build/staging/kservice/src/kservice_automoc.cpp:3:
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/staging/kservice/src/plugin/kexportplugin.h:71:129:
 note: #pragma message: K_EXPORT_PLUGIN is defined as a hack here, for compat. 
Port to new plugin system (QT_PLUGIN_METADATA) instead.
[ 36%] Building CXX object 
tier2/kconfig/autotests/kconfig_compiler/CMakeFiles/test4.dir/test4.cpp.o
In file included from 
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/staging/kservice/src/plugin/kpluginfactory.h:31:0,
 from 
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/staging/kservice/src/plugin/kpluginfactory.cpp:22:
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/staging/kservice/src/plugin/kexportplugin.h:71:129:
 note: #pragma message: K_EXPORT_PLUGIN is defined as a hack here, for compat. 
Port to new plugin system (QT_PLUGIN_METADATA) instead.
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/staging/kservice/src/plugin/kpluginfactory.cpp:
 In destructor ‘virtual KPluginFactory::~KPluginFactory()’:
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/staging/kservice/src/plugin/kpluginfactory.cpp:57:35:
 warning: unused variable ‘d’ [-Wunused-variable]
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/staging/kservice/src/plugin/kpluginfactory.cpp:
 In member function ‘virtual QObject* KPluginFactory::create(const char*, 
QWidget*, QObject*, const QVariantList, const QString)’:
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/staging/kservice/src/plugin/kpluginfactory.cpp:156:114:
 warning: ‘virtual KParts::Part* KPluginFactory::createPartObject(QWidget*, 
QObject*, const char*, const QStringList)’ is deprecated (declared at 
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/staging/kservice/src/plugin/kpluginfactory.cpp:125)
 [-Wdeprecated-declarations]
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/staging/kservice/src/plugin/kpluginfactory.cpp:161:62:
 warning: ‘virtual QObject* KPluginFactory::createObject(QObject*, const char*, 
const QStringList)’ is deprecated (declared at 
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/staging/kservice/src/plugin/kpluginfactory.cpp:115)
 [-Wdeprecated-declarations]
[ 36%] Building CXX object 
tier2/kconfig/autotests/kconfig_compiler/CMakeFiles/test4.dir/test4_automoc.cpp.o
[ 36%] Building CXX object 
tier2/kconfig/autotests/kconfig_compiler/CMakeFiles/test3.dir/test3.cpp.o
[ 36%] Building CXX object 
tier2/kconfig/autotests/kconfig_compiler/CMakeFiles/test3.dir/test3_automoc.cpp.o
[ 36%] Building CXX object 
tier2/kconfig/autotests/kconfig_compiler/CMakeFiles/test3a.dir/test3a.cpp.o
In file included from 
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/staging/kservice/src/plugin/kpluginloader.h:21:0,
 from