date:20130819

Review Request 112151: Use components in FindXCB

2013-08-19 Thread Martin Gräßlin


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112151/
---

Review request for KDE Frameworks and Alexander Neundorf.


Description
---

Instead of finding all or nothing from XCB it becomes components aware. So a 
user can just specify which XCB components it needs and compilation doesn't 
fail if a not-needed unrelated component is not found. It also allows to have 
some components as required and some as optional.


Diffs
-

  find-modules/FindXCB.cmake 7e7e701 

Diff: http://git.reviewboard.kde.org/r/112151/diff/


Testing
---

tested in kde-workspace


Thanks,

Martin Gräßlin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111636: Port away from kde_file.h in AuthInfo (KIO)

2013-08-19 Thread David Faure


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111636/#review38098
---



staging/kio/src/core/authinfo.cpp


The boolean OR operator is ||, not |.
| is bitwise OR.




staging/kio/src/core/authinfo.cpp


Missing
  && i+1 < stringList.size()

to ensure the stringList.at(i+1) call on the next line doesn't go out of 
bounds.



staging/kio/src/core/authinfo.cpp


Where is "buf" used in this method?

It seems to be used before this += operation (the extract() for "macdef" is 
before the loop), so this seems rather useless?

Ah, given the comment in the caller of getMacdefPart, I suppose the last 
line should say append(buf), not append(line)?


- David Faure


On Aug. 18, 2013, 10 p.m., David Gil Oliva wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111636/
> ---
> 
> (Updated Aug. 18, 2013, 10 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Port away from kde_file.h in AuthInfo (KIO)
> 
> 
> Diffs
> -
> 
>   staging/kio/src/core/authinfo.h d6415b2f2e9ccec7c3e046f569fb44dbbc879d6b 
>   staging/kio/src/core/authinfo.cpp 65ebacf84e989f19f1b896c596a6b24185c67447 
> 
> Diff: http://git.reviewboard.kde.org/r/111636/diff/
> 
> 
> Testing
> ---
> 
> It builds. I have tested the part of the code not related to loginMap with a 
> little program and .netrc sample files, to check whether it correctly parses 
> the information.
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112118: Move KGlobalSettings to kde4support, stop compiling kdeui while at it

2013-08-19 Thread David Faure


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112118/#review38099
---

Ship it!



staging/kde4support/autotests/CMakeLists.txt


The comment needs to be adjusted ;)

One such comment after each executable, then.



staging/kde4support/src/CMakeLists.txt


I don't recognize this define, what does it do?


- David Faure


On Aug. 16, 2013, 4:15 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112118/
> ---
> 
> (Updated Aug. 16, 2013, 4:15 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Moves KGlobalSettings to kde4support. It was the last class in kdeui so I 
> removed the add_subdirectory(kdeui). This forced me to do some additional 
> fixes that are also included in this patch, so that everything kept linking.
> 
> 
> Diffs
> -
> 
>   kio/tests/krununittest.cpp a572458 
>   kio/tests/CMakeLists.txt df4348b 
>   kio/CMakeLists.txt 9bfe7a4 
>   kdeui/util/kglobalsettings.cpp 0f749f2 
>   kdeui/util/kglobalsettings.h 61264d2 
>   kdeui/tests/kglobalsettingstest.cpp  
>   kdeui/tests/kglobalsettingstest.h  
>   kdeui/tests/kglobalsettingsclient.cpp  
>   kdeui/tests/CMakeLists.txt 513b51a 
>   kdeui/CMakeLists.txt 7afa6bd 
>   CMakeLists.txt fb51ff4 
>   interfaces/kimproxy/library/CMakeLists.txt 0dcee60 
>   staging/kde4support/autotests/CMakeLists.txt 12fa24c 
>   staging/kde4support/src/CMakeLists.txt 9e9b1d1 
> 
> Diff: http://git.reviewboard.kde.org/r/112118/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111916: Port khtml_part away from kde_file.h

2013-08-19 Thread Kevin Ottens



> On Aug. 13, 2013, 7:29 a.m., Kevin Ottens wrote:
> > Ship It!

Vishesh, anything preventing you to push this patch?


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111916/#review37643
---


On Aug. 12, 2013, 10:15 a.m., Vishesh Handa wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111916/
> ---
> 
> (Updated Aug. 12, 2013, 10:15 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
>  Port khtml_part away from kde_file.h
> 
> 
> Diffs
> -
> 
>   khtml/khtml_part.cpp d944a29 
> 
> Diff: http://git.reviewboard.kde.org/r/111916/diff/
> 
> 
> Testing
> ---
> 
> Compiles. The tests seem to segfault with and without this patch. I'll try to 
> diagnose it.
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111985: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 2)

2013-08-19 Thread Kevin Ottens



> On Aug. 13, 2013, 9:30 a.m., Kevin Ottens wrote:
> > Ship It!

Wojciech, anything preventing you to push this patch?


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111985/#review37660
---


On Aug. 13, 2013, 8:50 a.m., Wojciech Kapuscinski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111985/
> ---
> 
> (Updated Aug. 13, 2013, 8:50 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Task from kdelibs cleanup (tier2 subdir)
> 
> 
> Diffs
> -
> 
>   tier2/kauth/src/CMakeLists.txt 2ceff81 
>   tier2/kauth/src/ConfigureChecks.cmake cab1d01 
> 
> Diff: http://git.reviewboard.kde.org/r/111985/diff/
> 
> 
> Testing
> ---
> 
> It builds and tests looks OK.
> 
> 
> Thanks,
> 
> Wojciech Kapuscinski
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112046: reduce itmeviews test dependency

2013-08-19 Thread Kevin Ottens



> On Aug. 13, 2013, 9:31 a.m., Kevin Ottens wrote:
> > Ship It!

Wojciech, anything preventing you from pushing this patch?


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112046/#review37661
---


On Aug. 13, 2013, 9:31 a.m., Wojciech Kapuscinski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112046/
> ---
> 
> (Updated Aug. 13, 2013, 9:31 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> ItemViews use KIconThemes frameworks as test dependency (only for manual 
> test). But KIconThemes have ItemViews as "hard" dependency. Is is easy to 
> remove this "pseudo" circular dependency.
> Dependency form CMakeLists.txt will be removed in another review (still in 
> progress)
> 
> 
> Diffs
> -
> 
>   staging/itemviews/tests/kcategorizedviewtest.cpp 8c50f96 
> 
> Diff: http://git.reviewboard.kde.org/r/112046/diff/
> 
> 
> Testing
> ---
> 
> It builds and tests looks OK (with manual test)
> 
> 
> Thanks,
> 
> Wojciech Kapuscinski
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111945: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 1)

2013-08-19 Thread Kevin Ottens



> On Aug. 12, 2013, 9:24 a.m., Kevin Ottens wrote:
> > tier1/kconfig/src/gui/CMakeLists.txt, line 15
> > 
> >
> > You will have to rebase your patch because of a commit I've pushed just 
> > now. It should use Qt5::Gui (as initially intended), not Qt5::Widgets. So 
> > just change in favor of Qt5::Gui in that line.
> 
> Wojciech Kapuscinski wrote:
> Fixed in my local branch

Wojciech, anything preventing you from pushing this patch?


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111945/#review37557
---


On Aug. 9, 2013, 2:33 p.m., Wojciech Kapuscinski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111945/
> ---
> 
> (Updated Aug. 9, 2013, 2:33 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Task from kdelibs cleanup.
> 
> 
> Diffs
> -
> 
>   tier1/itemmodels/autotests/CMakeLists.txt 5e4e76b 
>   tier1/kconfig/autotests/CMakeLists.txt 751396f 
>   tier1/kconfig/autotests/kconfig_compiler/CMakeLists.txt b04b867 
>   tier1/kconfig/src/core/CMakeLists.txt 398a1d7 
>   tier1/kconfig/src/gui/CMakeLists.txt 91f013b 
>   tier1/kconfig/src/kconfig_compiler/CMakeLists.txt 3e1cf3a 
>   tier1/kdbusaddons/autotests/CMakeLists.txt bf03734 
>   tier1/kdbusaddons/src/CMakeLists.txt 25d1f60 
>   tier1/kdbusaddons/tests/CMakeLists.txt 57e6d4f 
>   tier1/kidletime/src/CMakeLists.txt d709b2b 
>   tier1/kjs/src/kjs/CMakeLists.txt ebbb820 
>   tier1/kjs/src/kjs/api/CMakeLists.txt 4d5c5d6 
>   tier1/kplotting/autotests/CMakeLists.txt afebdee 
>   tier1/kplotting/src/CMakeLists.txt 7ce75bd 
>   tier1/kwidgetsaddons/autotests/CMakeLists.txt 870e16e 
>   tier1/kwidgetsaddons/src/CMakeLists.txt c64302a 
>   tier1/kwidgetsaddons/tests/CMakeLists.txt 502218a 
>   tier1/kwindowsystem/src/CMakeLists.txt fe0f920 
>   tier1/sonnet/autotests/CMakeLists.txt 88574ff 
>   tier1/sonnet/src/plugins/aspell/CMakeLists.txt 9bdb4c7 
>   tier1/sonnet/src/plugins/enchant/CMakeLists.txt 2319be8 
>   tier1/sonnet/src/plugins/hspell/CMakeLists.txt c7cafc5 
>   tier1/sonnet/src/plugins/hunspell/CMakeLists.txt a0e2d9b 
>   tier1/sonnet/src/ui/CMakeLists.txt 723d8f3 
>   tier1/sonnet/src/unicode/CMakeLists.txt 6b5d27d 
>   tier1/sonnet/tests/CMakeLists.txt 6e0e450 
>   tier1/threadweaver/src/WeaverGui/CMakeLists.txt f92577c 
> 
> Diff: http://git.reviewboard.kde.org/r/111945/diff/
> 
> 
> Testing
> ---
> 
> It builds and tests looks OK.
> 
> 
> Thanks,
> 
> Wojciech Kapuscinski
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112052: Split kwindoweffects into an x11 and dummy implementation

2013-08-19 Thread Kevin Ottens


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112052/#review38105
---

Ship it!


Ship It!

- Kevin Ottens


On Aug. 13, 2013, 11:53 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112052/
> ---
> 
> (Updated Aug. 13, 2013, 11:53 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Proper implementation is moved into kwindoweffects_x11.cpp and a
> kwindoweffects_dummy.cpp is provided for Mac and Windows systems.
> 
> As every method is X11 specific this makes the code cleaner.
> 
> 
> Diffs
> -
> 
>   tier1/kwindowsystem/src/CMakeLists.txt fe0f920 
>   tier1/kwindowsystem/src/kwindoweffects.cpp 33a4531 
>   tier1/kwindowsystem/src/kwindoweffects_dummy.cpp PRE-CREATION 
>   tier1/kwindowsystem/src/kwindoweffects_x11.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112052/diff/
> 
> 
> Testing
> ---
> 
> Compile tested only X11 - cannot test Windows or Mac
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112051: port kconfig_compiler from QApplication to QGuiApplication

2013-08-19 Thread Kevin Ottens



> On Aug. 13, 2013, 11:08 a.m., Albert Astals Cid wrote:
> > Can it maybe even be a QCoreApplication?
> 
> Wojciech Kapuscinski wrote:
> Probably yes :) Kevin?

Quite some of those tests refer to QIcon and QColor, so QGuiApplication makes 
more sense.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112051/#review37676
---


On Aug. 13, 2013, 11:06 a.m., Wojciech Kapuscinski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112051/
> ---
> 
> (Updated Aug. 13, 2013, 11:06 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> port kconfig_compiler from QApplication to QGuiApplication.
> 
> NOTE. This must go before https://git.reviewboard.kde.org/r/111945/ because 
> Qt5::Widgets dependency was removed from kconfig
> 
> 
> Diffs
> -
> 
>   tier1/kconfig/autotests/kconfig_compiler/test10main.cpp ca937e4 
>   tier1/kconfig/autotests/kconfig_compiler/test11main.cpp 9d6b12c 
>   tier1/kconfig/autotests/kconfig_compiler/test1main.cpp 229384f 
>   tier1/kconfig/autotests/kconfig_compiler/test2main.cpp dc2714d 
>   tier1/kconfig/autotests/kconfig_compiler/test3amain.cpp b86ee13 
>   tier1/kconfig/autotests/kconfig_compiler/test3main.cpp 3e61573 
>   tier1/kconfig/autotests/kconfig_compiler/test4main.cpp 0de0ec8 
>   tier1/kconfig/autotests/kconfig_compiler/test5main.cpp 4173a31 
>   tier1/kconfig/autotests/kconfig_compiler/test6main.cpp c8a89bb 
>   tier1/kconfig/autotests/kconfig_compiler/test7main.cpp 3fff327 
>   tier1/kconfig/autotests/kconfig_compiler/test8main.cpp e7416e7 
>   tier1/kconfig/autotests/kconfig_compiler/test9main.cpp 5519068 
>   tier1/kconfig/autotests/kconfig_compiler/test_dpointer_main.cpp 4a1320b 
>   tier1/kconfig/autotests/kconfig_compiler/test_signal_main.cpp cce65dc 
> 
> Diff: http://git.reviewboard.kde.org/r/112051/diff/
> 
> 
> Testing
> ---
> 
> It builds
> 
> 
> Thanks,
> 
> Wojciech Kapuscinski
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112051: port kconfig_compiler from QApplication to QGuiApplication

2013-08-19 Thread Kevin Ottens


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112051/#review38108
---

Ship it!


Ship It!

- Kevin Ottens


On Aug. 13, 2013, 11:06 a.m., Wojciech Kapuscinski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112051/
> ---
> 
> (Updated Aug. 13, 2013, 11:06 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> port kconfig_compiler from QApplication to QGuiApplication.
> 
> NOTE. This must go before https://git.reviewboard.kde.org/r/111945/ because 
> Qt5::Widgets dependency was removed from kconfig
> 
> 
> Diffs
> -
> 
>   tier1/kconfig/autotests/kconfig_compiler/test10main.cpp ca937e4 
>   tier1/kconfig/autotests/kconfig_compiler/test11main.cpp 9d6b12c 
>   tier1/kconfig/autotests/kconfig_compiler/test1main.cpp 229384f 
>   tier1/kconfig/autotests/kconfig_compiler/test2main.cpp dc2714d 
>   tier1/kconfig/autotests/kconfig_compiler/test3amain.cpp b86ee13 
>   tier1/kconfig/autotests/kconfig_compiler/test3main.cpp 3e61573 
>   tier1/kconfig/autotests/kconfig_compiler/test4main.cpp 0de0ec8 
>   tier1/kconfig/autotests/kconfig_compiler/test5main.cpp 4173a31 
>   tier1/kconfig/autotests/kconfig_compiler/test6main.cpp c8a89bb 
>   tier1/kconfig/autotests/kconfig_compiler/test7main.cpp 3fff327 
>   tier1/kconfig/autotests/kconfig_compiler/test8main.cpp e7416e7 
>   tier1/kconfig/autotests/kconfig_compiler/test9main.cpp 5519068 
>   tier1/kconfig/autotests/kconfig_compiler/test_dpointer_main.cpp 4a1320b 
>   tier1/kconfig/autotests/kconfig_compiler/test_signal_main.cpp cce65dc 
> 
> Diff: http://git.reviewboard.kde.org/r/112051/diff/
> 
> 
> Testing
> ---
> 
> It builds
> 
> 
> Thanks,
> 
> Wojciech Kapuscinski
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112118: Move KGlobalSettings to kde4support, stop compiling kdeui while at it

2013-08-19 Thread Commit Hook


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112118/
---

(Updated Aug. 19, 2013, 9:03 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Description
---

Moves KGlobalSettings to kde4support. It was the last class in kdeui so I 
removed the add_subdirectory(kdeui). This forced me to do some additional fixes 
that are also included in this patch, so that everything kept linking.


Diffs
-

  kio/tests/krununittest.cpp a572458 
  kio/tests/CMakeLists.txt df4348b 
  kio/CMakeLists.txt 9bfe7a4 
  kdeui/util/kglobalsettings.cpp 0f749f2 
  kdeui/util/kglobalsettings.h 61264d2 
  kdeui/tests/kglobalsettingstest.cpp  
  kdeui/tests/kglobalsettingstest.h  
  kdeui/tests/kglobalsettingsclient.cpp  
  kdeui/tests/CMakeLists.txt 513b51a 
  kdeui/CMakeLists.txt 7afa6bd 
  CMakeLists.txt fb51ff4 
  interfaces/kimproxy/library/CMakeLists.txt 0dcee60 
  staging/kde4support/autotests/CMakeLists.txt 12fa24c 
  staging/kde4support/src/CMakeLists.txt 9e9b1d1 

Diff: http://git.reviewboard.kde.org/r/112118/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112096: Port KWindowEffects to XCB

2013-08-19 Thread Kevin Ottens


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112096/#review38109
---


I'll trust you with the XCB code I'm totally clueless on that. :-)


tier1/kwindowsystem/autotests/CMakeLists.txt


You could use X11_FOUND directly, no need for the intermediate HAVE_X11 in 
such a case.


- Kevin Ottens


On Aug. 15, 2013, 7:15 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112096/
> ---
> 
> (Updated Aug. 15, 2013, 7:15 a.m.)
> 
> 
> Review request for KDE Frameworks and Marco Martin.
> 
> 
> Description
> ---
> 
> Basically a rewrite of the X11 implementation of KWindowEffects to XCB. To 
> ensure that it doesn't break I added unit tests for everything except 
> isEffectAvailable (that can hardly be tested as it requires a running KWin).
> 
> Please note: this patch is on top of review #112052
> 
> 
> Diffs
> -
> 
>   tier1/kwindowsystem/autotests/CMakeLists.txt 5e05c6d 
>   tier1/kwindowsystem/autotests/kwindoweffectstest.cpp PRE-CREATION 
>   tier1/kwindowsystem/src/kwindoweffects.h bf77e7c 
>   tier1/kwindowsystem/src/kwindoweffects_x11.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112096/diff/
> 
> 
> Testing
> ---
> 
> See new unit tests and test application in 
> kde:scratch/graesslin/kwindoweffectsplugin.git
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112118: Move KGlobalSettings to kde4support, stop compiling kdeui while at it

2013-08-19 Thread Commit Hook


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112118/#review38110
---


This review has been submitted with commit 
4bb2e6783c0965e6c980540546baf17db4773818 by Aleix Pol to branch frameworks.

- Commit Hook


On Aug. 16, 2013, 4:15 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112118/
> ---
> 
> (Updated Aug. 16, 2013, 4:15 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Moves KGlobalSettings to kde4support. It was the last class in kdeui so I 
> removed the add_subdirectory(kdeui). This forced me to do some additional 
> fixes that are also included in this patch, so that everything kept linking.
> 
> 
> Diffs
> -
> 
>   kio/tests/krununittest.cpp a572458 
>   kio/tests/CMakeLists.txt df4348b 
>   kio/CMakeLists.txt 9bfe7a4 
>   kdeui/util/kglobalsettings.cpp 0f749f2 
>   kdeui/util/kglobalsettings.h 61264d2 
>   kdeui/tests/kglobalsettingstest.cpp  
>   kdeui/tests/kglobalsettingstest.h  
>   kdeui/tests/kglobalsettingsclient.cpp  
>   kdeui/tests/CMakeLists.txt 513b51a 
>   kdeui/CMakeLists.txt 7afa6bd 
>   CMakeLists.txt fb51ff4 
>   interfaces/kimproxy/library/CMakeLists.txt 0dcee60 
>   staging/kde4support/autotests/CMakeLists.txt 12fa24c 
>   staging/kde4support/src/CMakeLists.txt 9e9b1d1 
> 
> Diff: http://git.reviewboard.kde.org/r/112118/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112037: Replace most instances of KFileDialog with QFileDialog

2013-08-19 Thread Kevin Ottens



> On Aug. 13, 2013, 7:25 a.m., Kevin Ottens wrote:
> > kfile/kdirselectdialog.cpp, line 408
> > 
> >
> > Hmmm it makes me realize, couldn't KEncodingFileDialog be made to 
> > depend on the file module only? That would remove the dependency on 
> > KFileDialog (the file module is planned to stay).
> 
> Teo Mrnjavac wrote:
> I've investigated a bit, and we could try to make KEncodingFileDialog 
> static-only.
> The majority of KEncodingFileDialog uses are static, however in a few 
> instances kdepim/messagecomposer uses KEncodingFileDialog with instantiation 
> and some customization (e.g. 
> http://lxr.kde.org/source/kde/kdepim/messagecomposer/attachment/attachmentcontrollerbase.cpp#770).
> 
> Maybe we can factor this into a separate kdelibs cleanups dashboard task 
> that would involve staticifying KEncodingFileDialog while making sure kdepim 
> can get what it needs.

Yes, please add that to the task list.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112037/#review37641
---


On Aug. 15, 2013, 3:36 p.m., Teo Mrnjavac wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112037/
> ---
> 
> (Updated Aug. 15, 2013, 3:36 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> KFileDialog is deprecated in favor of QFileDialog. The original intention was 
> to completely replace the former with the latter and move KFileDialog to 
> kde4support.
> kdelibs cleanup task: Move KFileDialog to kde4support once the QUrl static 
> methods are in Qt (see the 5.1 epic)   
> Unfortunately, it turned out that KEncodingFileDialog inherits from 
> KFileDialog, and is still used in a bunch of places, making the complete 
> removal of KFileDialog impractical.
> 
> With this all uses of KFileDialog are removed, except for KEncodingFileDialog.
> 
> 
> Diffs
> -
> 
>   kfile/kdirselectdialog.cpp dcbcc4cf743bad17cfa520def611445ceb31eb21 
>   kio/kfile/kfiledialog.h 216dcc8b41e3a9027b2a94b307d6c6374ee53c51 
>   kio/kfile/kpropertiesdialog.cpp 995e962353a09e40f627f2db60ce831b46b6a414 
>   kio/kfile/kurlrequester.h bb111271b6d6b7b1fd66a4b5f13d9f0aa499289f 
>   kio/kfile/kurlrequester.cpp 523ae7a3bec64a3d997a255899cb15a8fdc5689e 
>   kio/kfile/kurlrequesterdialog.h 2e515b23060748e632cc96eed4a2305f67ebb40e 
>   kio/kfile/kurlrequesterdialog.cpp b0afd16388dab56b0a1127dd6e8921476196f234 
>   kio/kssl/kcm/cacertificatespage.cpp 
> 8b35c2a73f0f2caa3e385568d32428fdbb00bba4 
>   kparts/browserrun.cpp ff3a5fd1220cf0be3c8775cf97f204f3a26300d0 
>   kross/ui/view.cpp 51f31c5bc247d385c685cf91a94c48a0ed855532 
> 
> Diff: http://git.reviewboard.kde.org/r/112037/diff/
> 
> 
> Testing
> ---
> 
> Does not break any tests.
> 
> 
> Thanks,
> 
> Teo Mrnjavac
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kdelibs_frameworks_qt5 #1034

2013-08-19 Thread KDE CI System

See 

Changes:

[aleixpol] Move KGlobalSettings to kde4support, stop compiling kdeui while at it

--
[...truncated 15967 lines...]
[ 74%] Building CXX object 
staging/xmlgui/src/CMakeFiles/XmlGui.dir/ktoolbar.cpp.o
[ 74%] Building CXX object 
staging/xmlgui/src/CMakeFiles/XmlGui.dir/ktoolbarhandler.cpp.o
[ 74%] Building CXX object 
staging/xmlgui/src/CMakeFiles/XmlGui.dir/kxmlguibuilder.cpp.o
[ 74%] Building CXX object 
staging/xmlgui/src/CMakeFiles/XmlGui.dir/kxmlguiclient.cpp.o
[ 74%] Building CXX object 
staging/xmlgui/src/CMakeFiles/XmlGui.dir/kshortcutseditordelegate.cpp.o
[ 74%] Building CXX object 
staging/xmlgui/src/CMakeFiles/XmlGui.dir/kxmlguifactory.cpp.o
[ 74%] Building CXX object 
staging/xmlgui/src/CMakeFiles/XmlGui.dir/kxmlguifactory_p.cpp.o
[ 74%] Building CXX object 
staging/xmlgui/src/CMakeFiles/XmlGui.dir/kxmlguiversionhandler.cpp.o
[ 74%] Building CXX object 
staging/xmlgui/src/CMakeFiles/XmlGui.dir/kxmlguiwindow.cpp.o
[ 75%] Building CXX object 
staging/xmlgui/src/CMakeFiles/XmlGui.dir/kundoactions.cpp.o
[ 75%] Building CXX object 
staging/xmlgui/src/CMakeFiles/XmlGui.dir/kcheckaccelerators.cpp.o
[ 75%] Building CXX object 
staging/xmlgui/src/CMakeFiles/XmlGui.dir/khelpclient.cpp.o
:678:6:
 warning: unused parameter ‘client’ [-Wunused-parameter]
[ 75%] Building CXX object 
staging/xmlgui/src/CMakeFiles/XmlGui.dir/kglobalaccel_interface.cpp.o
[ 75%] Building CXX object 
staging/xmlgui/src/CMakeFiles/XmlGui.dir/kglobalaccel_component_interface.cpp.o
[ 75%] Building CXX object 
staging/xmlgui/src/CMakeFiles/XmlGui.dir/XmlGui_automoc.cpp.o
Linking CXX shared library libXmlGui.so
[ 75%] Built target XmlGui
Scanning dependencies of target kbugreporttest
Scanning dependencies of target kmainwindowrestoretest
Scanning dependencies of target kmainwindowtest
[ 75%] [ 75%] Building CXX object 
staging/xmlgui/tests/CMakeFiles/kbugreporttest.dir/kbugreporttest.cpp.o
Building CXX object 
staging/xmlgui/tests/CMakeFiles/kmainwindowrestoretest.dir/kmainwindowrestoretest.cpp.o
[ 75%] Building CXX object 
staging/xmlgui/tests/CMakeFiles/kmainwindowtest.dir/kmainwindowtest.cpp.o
Scanning dependencies of target ktoolbartest
[ 75%] Building CXX object 
staging/xmlgui/tests/CMakeFiles/ktoolbartest.dir/ktoolbartest.cpp.o
[ 75%] Building CXX object 
staging/xmlgui/tests/CMakeFiles/kbugreporttest.dir/kbugreporttest_automoc.cpp.o
[ 75%] Building CXX object 
staging/xmlgui/tests/CMakeFiles/kmainwindowtest.dir/kmainwindowtest_automoc.cpp.o
[ 75%] Building CXX object 
staging/xmlgui/tests/CMakeFiles/kmainwindowrestoretest.dir/kmainwindowrestoretest_automoc.cpp.o
Linking CXX executable kbugreporttest
[ 75%] Built target kbugreporttest
[ 75%] Building CXX object 
staging/xmlgui/tests/CMakeFiles/ktoolbartest.dir/ktoolbartest_automoc.cpp.o
Scanning dependencies of target krulertest
[ 75%] Building CXX object 
staging/xmlgui/tests/CMakeFiles/krulertest.dir/krulertest.cpp.o
Linking CXX executable ktoolbartest
Scanning dependencies of target kwindowtest
[ 75%] Building CXX object 
staging/xmlgui/tests/CMakeFiles/kwindowtest.dir/kwindowtest.cpp.o
Linking CXX executable kmainwindowrestoretest
Linking CXX executable kmainwindowtest
[ 75%] Built target ktoolbartest
[ 75%] Building CXX object 
staging/xmlgui/tests/CMakeFiles/kwindowtest.dir/kwindowtest_automoc.cpp.o
[ 75%] Built target kmainwindowtest
[ 75%] Built target kmainwindowrestoretest
[ 76%] Building CXX object 
staging/xmlgui/tests/CMakeFiles/krulertest.dir/krulertest_automoc.cpp.o
Scanning dependencies of target kxmlguitest
[ 76%] Building CXX object 
staging/xmlgui/tests/CMakeFiles/kxmlguitest.dir/kxmlguitest.cpp.o
[ 76%] Building CXX object 
staging/xmlgui/tests/CMakeFiles/kxmlguitest.dir/kxmlguitest_automoc.cpp.o
Scanning dependencies of target kxmlguiwindowtest
[ 76%] Building CXX object 
staging/xmlgui/tests/CMakeFiles/kxmlguiwindowtest.dir/kxmlguiwindowtest.cpp.o
Linking CXX executable krulertest
[ 76%] Built target krulertest
[ 76%] Building CXX object 
staging/xmlgui/tests/CMakeFiles/kxmlguiwindowtest.dir/kxmlguiwindowtest_automoc.cpp.o
Scanning dependencies of target krichtexteditor
[ 76%] Building CXX object 
staging/xmlgui/tests/krichtexteditor/CMakeFiles/krichtexteditor.dir/main.cpp.o
Scanning dependencies of target kactioncategorytest
[ 76%] Building CXX object 
staging/xmlgui/autotests/CMakeFiles/kactioncategorytest.dir/kactioncategorytest.cpp.o
Linking CXX executable kxmlguitest
[ 76%] Built target kxmlguitest
[ 76%] Building CXX object 
staging/xmlgui/tests/krichtexteditor/CMakeFiles/krichtexteditor.dir/krichtexteditor.cpp.o
Linking CXX executable kwindowtest
Linking CXX executable kxmlguiwindowtest
[ 76%] Built target kwindowtest
[ 76%] Building CXX object 
staging/xmlgui/autotests/CMakeFiles/kactioncategorytest.dir/kactioncategorytest_automoc.cpp.o
[ 76%] Bui

Re: Review Request 111916: Port khtml_part away from kde_file.h

2013-08-19 Thread Vishesh Handa


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111916/
---

(Updated Aug. 19, 2013, 9:32 a.m.)


Review request for KDE Frameworks.


Changes
---

Use QFileInfo::symLinkTarget() instead of relying on readlink.


Description
---

 Port khtml_part away from kde_file.h


Diffs (updated)
-

  khtml/khtml_part.cpp d944a29 

Diff: http://git.reviewboard.kde.org/r/111916/diff/


Testing
---

Compiles. The tests seem to segfault with and without this patch. I'll try to 
diagnose it.


Thanks,

Vishesh Handa

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111916: Port khtml_part away from kde_file.h

2013-08-19 Thread Kevin Ottens


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111916/#review38117
---

Ship it!


Ship It!

- Kevin Ottens


On Aug. 19, 2013, 9:32 a.m., Vishesh Handa wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111916/
> ---
> 
> (Updated Aug. 19, 2013, 9:32 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
>  Port khtml_part away from kde_file.h
> 
> 
> Diffs
> -
> 
>   khtml/khtml_part.cpp d944a29 
> 
> Diff: http://git.reviewboard.kde.org/r/111916/diff/
> 
> 
> Testing
> ---
> 
> Compiles. The tests seem to segfault with and without this patch. I'll try to 
> diagnose it.
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111916: Port khtml_part away from kde_file.h

2013-08-19 Thread David Faure


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111916/#review38118
---

Ship it!


Ship It!

- David Faure


On Aug. 19, 2013, 9:32 a.m., Vishesh Handa wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111916/
> ---
> 
> (Updated Aug. 19, 2013, 9:32 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
>  Port khtml_part away from kde_file.h
> 
> 
> Diffs
> -
> 
>   khtml/khtml_part.cpp d944a29 
> 
> Diff: http://git.reviewboard.kde.org/r/111916/diff/
> 
> 
> Testing
> ---
> 
> Compiles. The tests seem to segfault with and without this patch. I'll try to 
> diagnose it.
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112151: Use components in FindXCB

2013-08-19 Thread Kevin Ottens


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112151/
---

(Updated Aug. 19, 2013, 9:39 a.m.)


Review request for KDE Frameworks, Alexander Neundorf and Stephen Kelly.


Changes
---

Adding Steve to this review he might be able to provide feedback before Alex is 
back from vacations.


Description
---

Instead of finding all or nothing from XCB it becomes components aware. So a 
user can just specify which XCB components it needs and compilation doesn't 
fail if a not-needed unrelated component is not found. It also allows to have 
some components as required and some as optional.


Diffs
-

  find-modules/FindXCB.cmake 7e7e701 

Diff: http://git.reviewboard.kde.org/r/112151/diff/


Testing
---

tested in kde-workspace


Thanks,

Martin Gräßlin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112079: Add utility function to paint icon overlays

2013-08-19 Thread Kevin Ottens


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112079/#review38113
---



staging/kguiaddons/src/util/qiconoverlay.h


Apidox is missing for those two functions.



staging/kguiaddons/src/util/qiconoverlay.cpp


Should be const ref for the QHash too.


- Kevin Ottens


On Aug. 14, 2013, 10:49 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112079/
> ---
> 
> (Updated Aug. 14, 2013, 10:49 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> As this was rejected from QIcon, I decided to implement it in frameworks. The 
> idea is new private icon engine (KOverlayIconEngine), which paints the 
> overlays itself, and then an utility function in KIconUtils:: namespace, 
> which takes the base icon and the overlay icons as parameters and constructs 
> new QIcon using KOverlayIconEngine. As QPixmapIconEngine (QIcon default) is 
> private in Qt and couldn't be simply extended, the KOverlayIconEngine simply 
> forwards the calls to QIcon, which then forwards those calls internally to 
> QPixmapIconEngine (QIcon is really mostly just a wrapper around an engine).
> 
> There are two functions
> 
> QIcon KIconUtils::kIconAddOverlay(const QIcon &icon, const QIcon &overlay, 
> Qt::Corner position);
> 
> and
> 
> QIcon KIconUtils::kIconAddOverlay(const QIcon &icon, QHash 
> overlays);
> 
> The first one serves for single overlay icon, the second one is then for 
> multiple overlays, requires the QHash to be built up before passing though.
> 
> 
> Diffs
> -
> 
>   staging/kguiaddons/src/CMakeLists.txt fc8941a 
>   staging/kguiaddons/src/util/qiconoverlay.h PRE-CREATION 
>   staging/kguiaddons/src/util/qiconoverlay.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112079/diff/
> 
> 
> Testing
> ---
> 
> I have a small testing app with 3 QLabels, testing both ::paint() and 
> ::pixmap() methods, all works \o/ I'm thinking about bundling the app with 
> kguiaddons and/or additionally creating a unittest for it (I have one for Qt 
> already), but I'll do that later as I'm off to vacation and I'd like to get 
> comments for the code.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112037: Replace most instances of KFileDialog with QFileDialog

2013-08-19 Thread Kevin Ottens


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112037/#review38122
---



kio/kfile/kurlrequester.cpp


Unneeded change.



kio/kfile/kurlrequester.cpp


Unneeded change.



kio/kfile/kurlrequester.cpp


Unneeded change.


- Kevin Ottens


On Aug. 15, 2013, 3:36 p.m., Teo Mrnjavac wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112037/
> ---
> 
> (Updated Aug. 15, 2013, 3:36 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> KFileDialog is deprecated in favor of QFileDialog. The original intention was 
> to completely replace the former with the latter and move KFileDialog to 
> kde4support.
> kdelibs cleanup task: Move KFileDialog to kde4support once the QUrl static 
> methods are in Qt (see the 5.1 epic)   
> Unfortunately, it turned out that KEncodingFileDialog inherits from 
> KFileDialog, and is still used in a bunch of places, making the complete 
> removal of KFileDialog impractical.
> 
> With this all uses of KFileDialog are removed, except for KEncodingFileDialog.
> 
> 
> Diffs
> -
> 
>   kfile/kdirselectdialog.cpp dcbcc4cf743bad17cfa520def611445ceb31eb21 
>   kio/kfile/kfiledialog.h 216dcc8b41e3a9027b2a94b307d6c6374ee53c51 
>   kio/kfile/kpropertiesdialog.cpp 995e962353a09e40f627f2db60ce831b46b6a414 
>   kio/kfile/kurlrequester.h bb111271b6d6b7b1fd66a4b5f13d9f0aa499289f 
>   kio/kfile/kurlrequester.cpp 523ae7a3bec64a3d997a255899cb15a8fdc5689e 
>   kio/kfile/kurlrequesterdialog.h 2e515b23060748e632cc96eed4a2305f67ebb40e 
>   kio/kfile/kurlrequesterdialog.cpp b0afd16388dab56b0a1127dd6e8921476196f234 
>   kio/kssl/kcm/cacertificatespage.cpp 
> 8b35c2a73f0f2caa3e385568d32428fdbb00bba4 
>   kparts/browserrun.cpp ff3a5fd1220cf0be3c8775cf97f204f3a26300d0 
>   kross/ui/view.cpp 51f31c5bc247d385c685cf91a94c48a0ed855532 
> 
> Diff: http://git.reviewboard.kde.org/r/112037/diff/
> 
> 
> Testing
> ---
> 
> Does not break any tests.
> 
> 
> Thanks,
> 
> Teo Mrnjavac
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112060: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 3)

2013-08-19 Thread Kevin Ottens


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112060/#review38124
---



staging/frameworkintegration/src/platformtheme/CMakeLists.txt


The comment actually matters, please keep it. Even if that's indirect we 
have to link to KIO.



staging/ktextwidgets/src/CMakeLists.txt


Useless change.



staging/ktextwidgets/src/CMakeLists.txt


ditto


- Kevin Ottens


On Aug. 13, 2013, 5:18 p.m., Wojciech Kapuscinski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112060/
> ---
> 
> (Updated Aug. 13, 2013, 5:18 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Everything in staging directory (except kde4support)
> 
> 
> Diffs
> -
> 
>   experimental/kdeclarative/CMakeLists.txt 6c9b088 
>   staging/frameworkintegration/src/integrationplugin/CMakeLists.txt 437f0e7 
>   staging/frameworkintegration/src/platformtheme/CMakeLists.txt ec20115 
>   staging/itemviews/autotests/CMakeLists.txt a122958 
>   staging/itemviews/src/CMakeLists.txt 45b76e1 
>   staging/itemviews/tests/CMakeLists.txt 68dd537 
>   staging/kcompletion/autotests/CMakeLists.txt 25fee98 
>   staging/kcompletion/src/CMakeLists.txt 9ef378c 
>   staging/kcompletion/tests/CMakeLists.txt 22050fc 
>   staging/kconfigwidgets/autotests/CMakeLists.txt 3afeccc 
>   staging/kconfigwidgets/src/CMakeLists.txt 0ec0987 
>   staging/kconfigwidgets/tests/CMakeLists.txt 919342f 
>   staging/kcrash/src/CMakeLists.txt 5bdaf61 
>   staging/kde4attic/autotests/CMakeLists.txt 9e3d488 
>   staging/kde4attic/src/CMakeLists.txt f395cd5 
>   staging/kde4attic/tests/CMakeLists.txt fd7fd3a 
>   staging/kemoticons/autotests/CMakeLists.txt b00056a 
>   staging/kemoticons/src/core/CMakeLists.txt de6640b 
>   staging/kemoticons/src/core/kemoticonstheme.cpp 725c9c1 
>   staging/kemoticons/src/providers/adium/CMakeLists.txt 2ad9512 
>   staging/kemoticons/src/providers/kde/CMakeLists.txt 8602909 
>   staging/kemoticons/src/providers/pidgin/CMakeLists.txt 242807d 
>   staging/kemoticons/src/providers/xmpp/CMakeLists.txt 55330ce 
>   staging/kemoticons/tests/CMakeLists.txt ea7fc0b 
>   staging/kguiaddons/autotests/CMakeLists.txt 772caee 
>   staging/kguiaddons/src/CMakeLists.txt fc8941a 
>   staging/kguiaddons/tests/CMakeLists.txt ab44a37 
>   staging/ki18n/src/CMakeLists.txt f80bae6 
>   staging/kiconthemes/autotests/CMakeLists.txt 854cbe3 
>   staging/kiconthemes/src/CMakeLists.txt 150eb1a 
>   staging/kiconthemes/tests/CMakeLists.txt 49f179c 
>   staging/kinterprocesswindowing/src/CMakeLists.txt 0cb849a 
>   staging/kio/autotests/CMakeLists.txt b43ac26 
>   staging/kio/src/core/CMakeLists.txt be00bbe 
>   staging/kio/src/kssld/CMakeLists.txt f030a65 
>   staging/kio/src/widgets/CMakeLists.txt f68034c 
>   staging/kjobwidgets/autotests/CMakeLists.txt 559ba28 
>   staging/kjobwidgets/src/CMakeLists.txt e160da0 
>   staging/kjobwidgets/tests/CMakeLists.txt 7e5331a 
>   staging/knotifications/autotests/CMakeLists.txt b12bff6 
>   staging/knotifications/tests/CMakeLists.txt 91d46cf 
>   staging/kservice/autotests/CMakeLists.txt 326bbf9 
>   staging/kservice/src/CMakeLists.txt 893f6dd 
>   staging/kservice/tests/CMakeLists.txt 5e94b81 
>   staging/ktextwidgets/autotests/CMakeLists.txt 4c2b9d6 
>   staging/ktextwidgets/src/CMakeLists.txt 1f47da2 
>   staging/ktextwidgets/tests/CMakeLists.txt 3dd1376 
>   staging/kunitconversion/autotests/CMakeLists.txt c041a91 
>   staging/kunitconversion/src/kunitconversion/CMakeLists.txt 3d6771b 
>   staging/kwallet/autotests/CMakeLists.txt 95535ca 
>   staging/kwallet/src/CMakeLists.txt d181426 
>   staging/kwallet/tests/CMakeLists.txt c75ff00 
>   staging/xmlgui/autotests/CMakeLists.txt 6b415ba 
>   staging/xmlgui/src/CMakeLists.txt 9731f98 
>   staging/xmlgui/tests/CMakeLists.txt 3f17e9a 
>   staging/xmlgui/tests/krichtexteditor/CMakeLists.txt 4007776 
> 
> Diff: http://git.reviewboard.kde.org/r/112060/diff/
> 
> 
> Testing
> ---
> 
> it builds (with prefix removed) and tests looks OK.
> Testes with other changes (CMake part1, part2)
> 
> 
> Thanks,
> 
> Wojciech Kapuscinski
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112060: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 3)

2013-08-19 Thread Wojciech Kapuscinski


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112060/
---

(Updated Aug. 19, 2013, 10:27 a.m.)


Review request for KDE Frameworks.


Description
---

Everything in staging directory (except kde4support)


Diffs
-

  staging/kemoticons/src/providers/pidgin/CMakeLists.txt 242807d 
  staging/kemoticons/src/providers/kde/CMakeLists.txt 8602909 
  staging/kemoticons/src/providers/adium/CMakeLists.txt 2ad9512 
  staging/kemoticons/src/core/kemoticonstheme.cpp 725c9c1 
  staging/kemoticons/src/core/CMakeLists.txt de6640b 
  staging/kemoticons/autotests/CMakeLists.txt b00056a 
  staging/kde4attic/src/CMakeLists.txt f395cd5 
  staging/kde4attic/tests/CMakeLists.txt fd7fd3a 
  staging/kcrash/src/CMakeLists.txt 5bdaf61 
  staging/kde4attic/autotests/CMakeLists.txt 9e3d488 
  staging/kconfigwidgets/tests/CMakeLists.txt 919342f 
  staging/kconfigwidgets/src/CMakeLists.txt 0ec0987 
  staging/kconfigwidgets/autotests/CMakeLists.txt 3afeccc 
  staging/kcompletion/tests/CMakeLists.txt 22050fc 
  staging/kcompletion/src/CMakeLists.txt 9ef378c 
  staging/kcompletion/autotests/CMakeLists.txt 25fee98 
  staging/itemviews/tests/CMakeLists.txt 68dd537 
  staging/itemviews/src/CMakeLists.txt 45b76e1 
  staging/itemviews/autotests/CMakeLists.txt a122958 
  staging/frameworkintegration/src/platformtheme/CMakeLists.txt ec20115 
  staging/frameworkintegration/src/integrationplugin/CMakeLists.txt 437f0e7 
  experimental/kdeclarative/CMakeLists.txt 6c9b088 
  staging/kemoticons/src/providers/xmpp/CMakeLists.txt 55330ce 
  staging/kemoticons/tests/CMakeLists.txt ea7fc0b 
  staging/kguiaddons/autotests/CMakeLists.txt 772caee 
  staging/kguiaddons/src/CMakeLists.txt fc8941a 
  staging/kguiaddons/tests/CMakeLists.txt ab44a37 
  staging/ki18n/src/CMakeLists.txt f80bae6 
  staging/kiconthemes/autotests/CMakeLists.txt 854cbe3 
  staging/kiconthemes/src/CMakeLists.txt 150eb1a 
  staging/kiconthemes/tests/CMakeLists.txt 49f179c 
  staging/kinterprocesswindowing/src/CMakeLists.txt 0cb849a 
  staging/kio/autotests/CMakeLists.txt b43ac26 
  staging/kio/src/core/CMakeLists.txt be00bbe 
  staging/kio/src/kssld/CMakeLists.txt f030a65 
  staging/kio/src/widgets/CMakeLists.txt f68034c 
  staging/kjobwidgets/autotests/CMakeLists.txt 559ba28 
  staging/kjobwidgets/src/CMakeLists.txt e160da0 
  staging/kjobwidgets/tests/CMakeLists.txt 7e5331a 
  staging/knotifications/autotests/CMakeLists.txt b12bff6 
  staging/knotifications/tests/CMakeLists.txt 91d46cf 
  staging/kservice/autotests/CMakeLists.txt 326bbf9 
  staging/kservice/src/CMakeLists.txt 893f6dd 
  staging/kservice/tests/CMakeLists.txt 5e94b81 
  staging/ktextwidgets/autotests/CMakeLists.txt 4c2b9d6 
  staging/ktextwidgets/src/CMakeLists.txt 1f47da2 
  staging/ktextwidgets/tests/CMakeLists.txt 3dd1376 
  staging/kunitconversion/autotests/CMakeLists.txt c041a91 
  staging/kunitconversion/src/kunitconversion/CMakeLists.txt 3d6771b 
  staging/kwallet/autotests/CMakeLists.txt 95535ca 
  staging/kwallet/src/CMakeLists.txt d181426 
  staging/kwallet/tests/CMakeLists.txt c75ff00 
  staging/xmlgui/autotests/CMakeLists.txt 6b415ba 
  staging/xmlgui/src/CMakeLists.txt 9731f98 
  staging/xmlgui/tests/CMakeLists.txt 3f17e9a 
  staging/xmlgui/tests/krichtexteditor/CMakeLists.txt 4007776 

Diff: http://git.reviewboard.kde.org/r/112060/diff/


Testing
---

it builds (with prefix removed) and tests looks OK.
Testes with other changes (CMake part1, part2)


Thanks,

Wojciech Kapuscinski

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112060: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 3)

2013-08-19 Thread Kevin Ottens


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112060/#review38125
---

Ship it!


Ship It!

- Kevin Ottens


On Aug. 19, 2013, 10:27 a.m., Wojciech Kapuscinski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112060/
> ---
> 
> (Updated Aug. 19, 2013, 10:27 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Everything in staging directory (except kde4support)
> 
> 
> Diffs
> -
> 
>   staging/kemoticons/src/providers/pidgin/CMakeLists.txt 242807d 
>   staging/kemoticons/src/providers/kde/CMakeLists.txt 8602909 
>   staging/kemoticons/src/providers/adium/CMakeLists.txt 2ad9512 
>   staging/kemoticons/src/core/kemoticonstheme.cpp 725c9c1 
>   staging/kemoticons/src/core/CMakeLists.txt de6640b 
>   staging/kemoticons/autotests/CMakeLists.txt b00056a 
>   staging/kde4attic/src/CMakeLists.txt f395cd5 
>   staging/kde4attic/tests/CMakeLists.txt fd7fd3a 
>   staging/kcrash/src/CMakeLists.txt 5bdaf61 
>   staging/kde4attic/autotests/CMakeLists.txt 9e3d488 
>   staging/kconfigwidgets/tests/CMakeLists.txt 919342f 
>   staging/kconfigwidgets/src/CMakeLists.txt 0ec0987 
>   staging/kconfigwidgets/autotests/CMakeLists.txt 3afeccc 
>   staging/kcompletion/tests/CMakeLists.txt 22050fc 
>   staging/kcompletion/src/CMakeLists.txt 9ef378c 
>   staging/kcompletion/autotests/CMakeLists.txt 25fee98 
>   staging/itemviews/tests/CMakeLists.txt 68dd537 
>   staging/itemviews/src/CMakeLists.txt 45b76e1 
>   staging/itemviews/autotests/CMakeLists.txt a122958 
>   staging/frameworkintegration/src/platformtheme/CMakeLists.txt ec20115 
>   staging/frameworkintegration/src/integrationplugin/CMakeLists.txt 437f0e7 
>   experimental/kdeclarative/CMakeLists.txt 6c9b088 
>   staging/kemoticons/src/providers/xmpp/CMakeLists.txt 55330ce 
>   staging/kemoticons/tests/CMakeLists.txt ea7fc0b 
>   staging/kguiaddons/autotests/CMakeLists.txt 772caee 
>   staging/kguiaddons/src/CMakeLists.txt fc8941a 
>   staging/kguiaddons/tests/CMakeLists.txt ab44a37 
>   staging/ki18n/src/CMakeLists.txt f80bae6 
>   staging/kiconthemes/autotests/CMakeLists.txt 854cbe3 
>   staging/kiconthemes/src/CMakeLists.txt 150eb1a 
>   staging/kiconthemes/tests/CMakeLists.txt 49f179c 
>   staging/kinterprocesswindowing/src/CMakeLists.txt 0cb849a 
>   staging/kio/autotests/CMakeLists.txt b43ac26 
>   staging/kio/src/core/CMakeLists.txt be00bbe 
>   staging/kio/src/kssld/CMakeLists.txt f030a65 
>   staging/kio/src/widgets/CMakeLists.txt f68034c 
>   staging/kjobwidgets/autotests/CMakeLists.txt 559ba28 
>   staging/kjobwidgets/src/CMakeLists.txt e160da0 
>   staging/kjobwidgets/tests/CMakeLists.txt 7e5331a 
>   staging/knotifications/autotests/CMakeLists.txt b12bff6 
>   staging/knotifications/tests/CMakeLists.txt 91d46cf 
>   staging/kservice/autotests/CMakeLists.txt 326bbf9 
>   staging/kservice/src/CMakeLists.txt 893f6dd 
>   staging/kservice/tests/CMakeLists.txt 5e94b81 
>   staging/ktextwidgets/autotests/CMakeLists.txt 4c2b9d6 
>   staging/ktextwidgets/src/CMakeLists.txt 1f47da2 
>   staging/ktextwidgets/tests/CMakeLists.txt 3dd1376 
>   staging/kunitconversion/autotests/CMakeLists.txt c041a91 
>   staging/kunitconversion/src/kunitconversion/CMakeLists.txt 3d6771b 
>   staging/kwallet/autotests/CMakeLists.txt 95535ca 
>   staging/kwallet/src/CMakeLists.txt d181426 
>   staging/kwallet/tests/CMakeLists.txt c75ff00 
>   staging/xmlgui/autotests/CMakeLists.txt 6b415ba 
>   staging/xmlgui/src/CMakeLists.txt 9731f98 
>   staging/xmlgui/tests/CMakeLists.txt 3f17e9a 
>   staging/xmlgui/tests/krichtexteditor/CMakeLists.txt 4007776 
> 
> Diff: http://git.reviewboard.kde.org/r/112060/diff/
> 
> 
> Testing
> ---
> 
> it builds (with prefix removed) and tests looks OK.
> Testes with other changes (CMake part1, part2)
> 
> 
> Thanks,
> 
> Wojciech Kapuscinski
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112046: reduce itmeviews test dependency

2013-08-19 Thread Commit Hook


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112046/
---

(Updated Aug. 19, 2013, 10:37 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Description
---

ItemViews use KIconThemes frameworks as test dependency (only for manual test). 
But KIconThemes have ItemViews as "hard" dependency. Is is easy to remove this 
"pseudo" circular dependency.
Dependency form CMakeLists.txt will be removed in another review (still in 
progress)


Diffs
-

  staging/itemviews/tests/kcategorizedviewtest.cpp 8c50f96 

Diff: http://git.reviewboard.kde.org/r/112046/diff/


Testing
---

It builds and tests looks OK (with manual test)


Thanks,

Wojciech Kapuscinski

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112051: port kconfig_compiler from QApplication to QGuiApplication

2013-08-19 Thread Commit Hook


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112051/
---

(Updated Aug. 19, 2013, 10:37 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Description
---

port kconfig_compiler from QApplication to QGuiApplication.

NOTE. This must go before https://git.reviewboard.kde.org/r/111945/ because 
Qt5::Widgets dependency was removed from kconfig


Diffs
-

  tier1/kconfig/autotests/kconfig_compiler/test10main.cpp ca937e4 
  tier1/kconfig/autotests/kconfig_compiler/test11main.cpp 9d6b12c 
  tier1/kconfig/autotests/kconfig_compiler/test1main.cpp 229384f 
  tier1/kconfig/autotests/kconfig_compiler/test2main.cpp dc2714d 
  tier1/kconfig/autotests/kconfig_compiler/test3amain.cpp b86ee13 
  tier1/kconfig/autotests/kconfig_compiler/test3main.cpp 3e61573 
  tier1/kconfig/autotests/kconfig_compiler/test4main.cpp 0de0ec8 
  tier1/kconfig/autotests/kconfig_compiler/test5main.cpp 4173a31 
  tier1/kconfig/autotests/kconfig_compiler/test6main.cpp c8a89bb 
  tier1/kconfig/autotests/kconfig_compiler/test7main.cpp 3fff327 
  tier1/kconfig/autotests/kconfig_compiler/test8main.cpp e7416e7 
  tier1/kconfig/autotests/kconfig_compiler/test9main.cpp 5519068 
  tier1/kconfig/autotests/kconfig_compiler/test_dpointer_main.cpp 4a1320b 
  tier1/kconfig/autotests/kconfig_compiler/test_signal_main.cpp cce65dc 

Diff: http://git.reviewboard.kde.org/r/112051/diff/


Testing
---

It builds


Thanks,

Wojciech Kapuscinski

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111945: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 1)

2013-08-19 Thread Commit Hook


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111945/#review38127
---


This review has been submitted with commit 
796a4955977430545cd82841e8b60374075b8ffb by Wojciech Kapuscinski to branch 
frameworks.

- Commit Hook


On Aug. 9, 2013, 2:33 p.m., Wojciech Kapuscinski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111945/
> ---
> 
> (Updated Aug. 9, 2013, 2:33 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Task from kdelibs cleanup.
> 
> 
> Diffs
> -
> 
>   tier1/itemmodels/autotests/CMakeLists.txt 5e4e76b 
>   tier1/kconfig/autotests/CMakeLists.txt 751396f 
>   tier1/kconfig/autotests/kconfig_compiler/CMakeLists.txt b04b867 
>   tier1/kconfig/src/core/CMakeLists.txt 398a1d7 
>   tier1/kconfig/src/gui/CMakeLists.txt 91f013b 
>   tier1/kconfig/src/kconfig_compiler/CMakeLists.txt 3e1cf3a 
>   tier1/kdbusaddons/autotests/CMakeLists.txt bf03734 
>   tier1/kdbusaddons/src/CMakeLists.txt 25d1f60 
>   tier1/kdbusaddons/tests/CMakeLists.txt 57e6d4f 
>   tier1/kidletime/src/CMakeLists.txt d709b2b 
>   tier1/kjs/src/kjs/CMakeLists.txt ebbb820 
>   tier1/kjs/src/kjs/api/CMakeLists.txt 4d5c5d6 
>   tier1/kplotting/autotests/CMakeLists.txt afebdee 
>   tier1/kplotting/src/CMakeLists.txt 7ce75bd 
>   tier1/kwidgetsaddons/autotests/CMakeLists.txt 870e16e 
>   tier1/kwidgetsaddons/src/CMakeLists.txt c64302a 
>   tier1/kwidgetsaddons/tests/CMakeLists.txt 502218a 
>   tier1/kwindowsystem/src/CMakeLists.txt fe0f920 
>   tier1/sonnet/autotests/CMakeLists.txt 88574ff 
>   tier1/sonnet/src/plugins/aspell/CMakeLists.txt 9bdb4c7 
>   tier1/sonnet/src/plugins/enchant/CMakeLists.txt 2319be8 
>   tier1/sonnet/src/plugins/hspell/CMakeLists.txt c7cafc5 
>   tier1/sonnet/src/plugins/hunspell/CMakeLists.txt a0e2d9b 
>   tier1/sonnet/src/ui/CMakeLists.txt 723d8f3 
>   tier1/sonnet/src/unicode/CMakeLists.txt 6b5d27d 
>   tier1/sonnet/tests/CMakeLists.txt 6e0e450 
>   tier1/threadweaver/src/WeaverGui/CMakeLists.txt f92577c 
> 
> Diff: http://git.reviewboard.kde.org/r/111945/diff/
> 
> 
> Testing
> ---
> 
> It builds and tests looks OK.
> 
> 
> Thanks,
> 
> Wojciech Kapuscinski
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112046: reduce itmeviews test dependency

2013-08-19 Thread Commit Hook


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112046/#review38129
---


This review has been submitted with commit 
2f99377331f12ca3fb004bfab83f3e812c2b75c1 by Wojciech Kapuscinski to branch 
frameworks.

- Commit Hook


On Aug. 13, 2013, 9:31 a.m., Wojciech Kapuscinski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112046/
> ---
> 
> (Updated Aug. 13, 2013, 9:31 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> ItemViews use KIconThemes frameworks as test dependency (only for manual 
> test). But KIconThemes have ItemViews as "hard" dependency. Is is easy to 
> remove this "pseudo" circular dependency.
> Dependency form CMakeLists.txt will be removed in another review (still in 
> progress)
> 
> 
> Diffs
> -
> 
>   staging/itemviews/tests/kcategorizedviewtest.cpp 8c50f96 
> 
> Diff: http://git.reviewboard.kde.org/r/112046/diff/
> 
> 
> Testing
> ---
> 
> It builds and tests looks OK (with manual test)
> 
> 
> Thanks,
> 
> Wojciech Kapuscinski
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112060: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 3)

2013-08-19 Thread Commit Hook


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112060/#review38130
---


This review has been submitted with commit 
127b55739d507b9790028b63adcbd06e614bca0c by Wojciech Kapuscinski to branch 
frameworks.

- Commit Hook


On Aug. 19, 2013, 10:27 a.m., Wojciech Kapuscinski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112060/
> ---
> 
> (Updated Aug. 19, 2013, 10:27 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Everything in staging directory (except kde4support)
> 
> 
> Diffs
> -
> 
>   staging/kemoticons/src/providers/pidgin/CMakeLists.txt 242807d 
>   staging/kemoticons/src/providers/kde/CMakeLists.txt 8602909 
>   staging/kemoticons/src/providers/adium/CMakeLists.txt 2ad9512 
>   staging/kemoticons/src/core/kemoticonstheme.cpp 725c9c1 
>   staging/kemoticons/src/core/CMakeLists.txt de6640b 
>   staging/kemoticons/autotests/CMakeLists.txt b00056a 
>   staging/kde4attic/src/CMakeLists.txt f395cd5 
>   staging/kde4attic/tests/CMakeLists.txt fd7fd3a 
>   staging/kcrash/src/CMakeLists.txt 5bdaf61 
>   staging/kde4attic/autotests/CMakeLists.txt 9e3d488 
>   staging/kconfigwidgets/tests/CMakeLists.txt 919342f 
>   staging/kconfigwidgets/src/CMakeLists.txt 0ec0987 
>   staging/kconfigwidgets/autotests/CMakeLists.txt 3afeccc 
>   staging/kcompletion/tests/CMakeLists.txt 22050fc 
>   staging/kcompletion/src/CMakeLists.txt 9ef378c 
>   staging/kcompletion/autotests/CMakeLists.txt 25fee98 
>   staging/itemviews/tests/CMakeLists.txt 68dd537 
>   staging/itemviews/src/CMakeLists.txt 45b76e1 
>   staging/itemviews/autotests/CMakeLists.txt a122958 
>   staging/frameworkintegration/src/platformtheme/CMakeLists.txt ec20115 
>   staging/frameworkintegration/src/integrationplugin/CMakeLists.txt 437f0e7 
>   experimental/kdeclarative/CMakeLists.txt 6c9b088 
>   staging/kemoticons/src/providers/xmpp/CMakeLists.txt 55330ce 
>   staging/kemoticons/tests/CMakeLists.txt ea7fc0b 
>   staging/kguiaddons/autotests/CMakeLists.txt 772caee 
>   staging/kguiaddons/src/CMakeLists.txt fc8941a 
>   staging/kguiaddons/tests/CMakeLists.txt ab44a37 
>   staging/ki18n/src/CMakeLists.txt f80bae6 
>   staging/kiconthemes/autotests/CMakeLists.txt 854cbe3 
>   staging/kiconthemes/src/CMakeLists.txt 150eb1a 
>   staging/kiconthemes/tests/CMakeLists.txt 49f179c 
>   staging/kinterprocesswindowing/src/CMakeLists.txt 0cb849a 
>   staging/kio/autotests/CMakeLists.txt b43ac26 
>   staging/kio/src/core/CMakeLists.txt be00bbe 
>   staging/kio/src/kssld/CMakeLists.txt f030a65 
>   staging/kio/src/widgets/CMakeLists.txt f68034c 
>   staging/kjobwidgets/autotests/CMakeLists.txt 559ba28 
>   staging/kjobwidgets/src/CMakeLists.txt e160da0 
>   staging/kjobwidgets/tests/CMakeLists.txt 7e5331a 
>   staging/knotifications/autotests/CMakeLists.txt b12bff6 
>   staging/knotifications/tests/CMakeLists.txt 91d46cf 
>   staging/kservice/autotests/CMakeLists.txt 326bbf9 
>   staging/kservice/src/CMakeLists.txt 893f6dd 
>   staging/kservice/tests/CMakeLists.txt 5e94b81 
>   staging/ktextwidgets/autotests/CMakeLists.txt 4c2b9d6 
>   staging/ktextwidgets/src/CMakeLists.txt 1f47da2 
>   staging/ktextwidgets/tests/CMakeLists.txt 3dd1376 
>   staging/kunitconversion/autotests/CMakeLists.txt c041a91 
>   staging/kunitconversion/src/kunitconversion/CMakeLists.txt 3d6771b 
>   staging/kwallet/autotests/CMakeLists.txt 95535ca 
>   staging/kwallet/src/CMakeLists.txt d181426 
>   staging/kwallet/tests/CMakeLists.txt c75ff00 
>   staging/xmlgui/autotests/CMakeLists.txt 6b415ba 
>   staging/xmlgui/src/CMakeLists.txt 9731f98 
>   staging/xmlgui/tests/CMakeLists.txt 3f17e9a 
>   staging/xmlgui/tests/krichtexteditor/CMakeLists.txt 4007776 
> 
> Diff: http://git.reviewboard.kde.org/r/112060/diff/
> 
> 
> Testing
> ---
> 
> it builds (with prefix removed) and tests looks OK.
> Testes with other changes (CMake part1, part2)
> 
> 
> Thanks,
> 
> Wojciech Kapuscinski
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111985: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 2)

2013-08-19 Thread Commit Hook


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111985/#review38128
---


This review has been submitted with commit 
d9a79c3091d44a00ac21e47f08a30e356b681832 by Wojciech Kapuscinski to branch 
frameworks.

- Commit Hook


On Aug. 13, 2013, 8:50 a.m., Wojciech Kapuscinski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111985/
> ---
> 
> (Updated Aug. 13, 2013, 8:50 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Task from kdelibs cleanup (tier2 subdir)
> 
> 
> Diffs
> -
> 
>   tier2/kauth/src/CMakeLists.txt 2ceff81 
>   tier2/kauth/src/ConfigureChecks.cmake cab1d01 
> 
> Diff: http://git.reviewboard.kde.org/r/111985/diff/
> 
> 
> Testing
> ---
> 
> It builds and tests looks OK.
> 
> 
> Thanks,
> 
> Wojciech Kapuscinski
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112060: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 3)

2013-08-19 Thread Commit Hook


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112060/
---

(Updated Aug. 19, 2013, 10:37 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Description
---

Everything in staging directory (except kde4support)


Diffs
-

  staging/kemoticons/src/providers/pidgin/CMakeLists.txt 242807d 
  staging/kemoticons/src/providers/kde/CMakeLists.txt 8602909 
  staging/kemoticons/src/providers/adium/CMakeLists.txt 2ad9512 
  staging/kemoticons/src/core/kemoticonstheme.cpp 725c9c1 
  staging/kemoticons/src/core/CMakeLists.txt de6640b 
  staging/kemoticons/autotests/CMakeLists.txt b00056a 
  staging/kde4attic/src/CMakeLists.txt f395cd5 
  staging/kde4attic/tests/CMakeLists.txt fd7fd3a 
  staging/kcrash/src/CMakeLists.txt 5bdaf61 
  staging/kde4attic/autotests/CMakeLists.txt 9e3d488 
  staging/kconfigwidgets/tests/CMakeLists.txt 919342f 
  staging/kconfigwidgets/src/CMakeLists.txt 0ec0987 
  staging/kconfigwidgets/autotests/CMakeLists.txt 3afeccc 
  staging/kcompletion/tests/CMakeLists.txt 22050fc 
  staging/kcompletion/src/CMakeLists.txt 9ef378c 
  staging/kcompletion/autotests/CMakeLists.txt 25fee98 
  staging/itemviews/tests/CMakeLists.txt 68dd537 
  staging/itemviews/src/CMakeLists.txt 45b76e1 
  staging/itemviews/autotests/CMakeLists.txt a122958 
  staging/frameworkintegration/src/platformtheme/CMakeLists.txt ec20115 
  staging/frameworkintegration/src/integrationplugin/CMakeLists.txt 437f0e7 
  experimental/kdeclarative/CMakeLists.txt 6c9b088 
  staging/kemoticons/src/providers/xmpp/CMakeLists.txt 55330ce 
  staging/kemoticons/tests/CMakeLists.txt ea7fc0b 
  staging/kguiaddons/autotests/CMakeLists.txt 772caee 
  staging/kguiaddons/src/CMakeLists.txt fc8941a 
  staging/kguiaddons/tests/CMakeLists.txt ab44a37 
  staging/ki18n/src/CMakeLists.txt f80bae6 
  staging/kiconthemes/autotests/CMakeLists.txt 854cbe3 
  staging/kiconthemes/src/CMakeLists.txt 150eb1a 
  staging/kiconthemes/tests/CMakeLists.txt 49f179c 
  staging/kinterprocesswindowing/src/CMakeLists.txt 0cb849a 
  staging/kio/autotests/CMakeLists.txt b43ac26 
  staging/kio/src/core/CMakeLists.txt be00bbe 
  staging/kio/src/kssld/CMakeLists.txt f030a65 
  staging/kio/src/widgets/CMakeLists.txt f68034c 
  staging/kjobwidgets/autotests/CMakeLists.txt 559ba28 
  staging/kjobwidgets/src/CMakeLists.txt e160da0 
  staging/kjobwidgets/tests/CMakeLists.txt 7e5331a 
  staging/knotifications/autotests/CMakeLists.txt b12bff6 
  staging/knotifications/tests/CMakeLists.txt 91d46cf 
  staging/kservice/autotests/CMakeLists.txt 326bbf9 
  staging/kservice/src/CMakeLists.txt 893f6dd 
  staging/kservice/tests/CMakeLists.txt 5e94b81 
  staging/ktextwidgets/autotests/CMakeLists.txt 4c2b9d6 
  staging/ktextwidgets/src/CMakeLists.txt 1f47da2 
  staging/ktextwidgets/tests/CMakeLists.txt 3dd1376 
  staging/kunitconversion/autotests/CMakeLists.txt c041a91 
  staging/kunitconversion/src/kunitconversion/CMakeLists.txt 3d6771b 
  staging/kwallet/autotests/CMakeLists.txt 95535ca 
  staging/kwallet/src/CMakeLists.txt d181426 
  staging/kwallet/tests/CMakeLists.txt c75ff00 
  staging/xmlgui/autotests/CMakeLists.txt 6b415ba 
  staging/xmlgui/src/CMakeLists.txt 9731f98 
  staging/xmlgui/tests/CMakeLists.txt 3f17e9a 
  staging/xmlgui/tests/krichtexteditor/CMakeLists.txt 4007776 

Diff: http://git.reviewboard.kde.org/r/112060/diff/


Testing
---

it builds (with prefix removed) and tests looks OK.
Testes with other changes (CMake part1, part2)


Thanks,

Wojciech Kapuscinski

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112060: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 3)

2013-08-19 Thread Wojciech Kapuscinski


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112060/
---

(Updated Aug. 19, 2013, 10:25 a.m.)


Review request for KDE Frameworks.


Changes
---

fix issues pointed by ervin


Description
---

Everything in staging directory (except kde4support)


Diffs (updated)
-

  staging/kemoticons/src/providers/pidgin/CMakeLists.txt 242807d 
  staging/kemoticons/src/providers/kde/CMakeLists.txt 8602909 
  staging/kemoticons/src/providers/adium/CMakeLists.txt 2ad9512 
  staging/kemoticons/src/core/kemoticonstheme.cpp 725c9c1 
  staging/kemoticons/src/core/CMakeLists.txt de6640b 
  staging/kemoticons/autotests/CMakeLists.txt b00056a 
  staging/kde4attic/src/CMakeLists.txt f395cd5 
  staging/kde4attic/tests/CMakeLists.txt fd7fd3a 
  staging/kcrash/src/CMakeLists.txt 5bdaf61 
  staging/kde4attic/autotests/CMakeLists.txt 9e3d488 
  staging/kconfigwidgets/tests/CMakeLists.txt 919342f 
  staging/kconfigwidgets/src/CMakeLists.txt 0ec0987 
  staging/kconfigwidgets/autotests/CMakeLists.txt 3afeccc 
  staging/kcompletion/tests/CMakeLists.txt 22050fc 
  staging/kcompletion/src/CMakeLists.txt 9ef378c 
  staging/kcompletion/autotests/CMakeLists.txt 25fee98 
  staging/itemviews/tests/CMakeLists.txt 68dd537 
  staging/itemviews/src/CMakeLists.txt 45b76e1 
  staging/itemviews/autotests/CMakeLists.txt a122958 
  staging/frameworkintegration/src/platformtheme/CMakeLists.txt ec20115 
  staging/frameworkintegration/src/integrationplugin/CMakeLists.txt 437f0e7 
  experimental/kdeclarative/CMakeLists.txt 6c9b088 
  staging/kemoticons/src/providers/xmpp/CMakeLists.txt 55330ce 
  staging/kemoticons/tests/CMakeLists.txt ea7fc0b 
  staging/kguiaddons/autotests/CMakeLists.txt 772caee 
  staging/kguiaddons/src/CMakeLists.txt fc8941a 
  staging/kguiaddons/tests/CMakeLists.txt ab44a37 
  staging/ki18n/src/CMakeLists.txt f80bae6 
  staging/kiconthemes/autotests/CMakeLists.txt 854cbe3 
  staging/kiconthemes/src/CMakeLists.txt 150eb1a 
  staging/kiconthemes/tests/CMakeLists.txt 49f179c 
  staging/kinterprocesswindowing/src/CMakeLists.txt 0cb849a 
  staging/kio/autotests/CMakeLists.txt b43ac26 
  staging/kio/src/core/CMakeLists.txt be00bbe 
  staging/kio/src/kssld/CMakeLists.txt f030a65 
  staging/kio/src/widgets/CMakeLists.txt f68034c 
  staging/kjobwidgets/autotests/CMakeLists.txt 559ba28 
  staging/kjobwidgets/src/CMakeLists.txt e160da0 
  staging/kjobwidgets/tests/CMakeLists.txt 7e5331a 
  staging/knotifications/autotests/CMakeLists.txt b12bff6 
  staging/knotifications/tests/CMakeLists.txt 91d46cf 
  staging/kservice/autotests/CMakeLists.txt 326bbf9 
  staging/kservice/src/CMakeLists.txt 893f6dd 
  staging/kservice/tests/CMakeLists.txt 5e94b81 
  staging/ktextwidgets/autotests/CMakeLists.txt 4c2b9d6 
  staging/ktextwidgets/src/CMakeLists.txt 1f47da2 
  staging/ktextwidgets/tests/CMakeLists.txt 3dd1376 
  staging/kunitconversion/autotests/CMakeLists.txt c041a91 
  staging/kunitconversion/src/kunitconversion/CMakeLists.txt 3d6771b 
  staging/kwallet/autotests/CMakeLists.txt 95535ca 
  staging/kwallet/src/CMakeLists.txt d181426 
  staging/kwallet/tests/CMakeLists.txt c75ff00 
  staging/xmlgui/autotests/CMakeLists.txt 6b415ba 
  staging/xmlgui/src/CMakeLists.txt 9731f98 
  staging/xmlgui/tests/CMakeLists.txt 3f17e9a 
  staging/xmlgui/tests/krichtexteditor/CMakeLists.txt 4007776 

Diff: http://git.reviewboard.kde.org/r/112060/diff/


Testing
---

it builds (with prefix removed) and tests looks OK.
Testes with other changes (CMake part1, part2)


Thanks,

Wojciech Kapuscinski

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111985: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 2)

2013-08-19 Thread Wojciech Kapuscinski


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111985/
---

(Updated Aug. 19, 2013, 10:40 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Description
---

Task from kdelibs cleanup (tier2 subdir)


Diffs
-

  tier2/kauth/src/CMakeLists.txt 2ceff81 
  tier2/kauth/src/ConfigureChecks.cmake cab1d01 

Diff: http://git.reviewboard.kde.org/r/111985/diff/


Testing
---

It builds and tests looks OK.


Thanks,

Wojciech Kapuscinski

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111945: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 1)

2013-08-19 Thread Wojciech Kapuscinski


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111945/
---

(Updated Aug. 19, 2013, 10:40 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Description
---

Task from kdelibs cleanup.


Diffs
-

  tier1/itemmodels/autotests/CMakeLists.txt 5e4e76b 
  tier1/kconfig/autotests/CMakeLists.txt 751396f 
  tier1/kconfig/autotests/kconfig_compiler/CMakeLists.txt b04b867 
  tier1/kconfig/src/core/CMakeLists.txt 398a1d7 
  tier1/kconfig/src/gui/CMakeLists.txt 91f013b 
  tier1/kconfig/src/kconfig_compiler/CMakeLists.txt 3e1cf3a 
  tier1/kdbusaddons/autotests/CMakeLists.txt bf03734 
  tier1/kdbusaddons/src/CMakeLists.txt 25d1f60 
  tier1/kdbusaddons/tests/CMakeLists.txt 57e6d4f 
  tier1/kidletime/src/CMakeLists.txt d709b2b 
  tier1/kjs/src/kjs/CMakeLists.txt ebbb820 
  tier1/kjs/src/kjs/api/CMakeLists.txt 4d5c5d6 
  tier1/kplotting/autotests/CMakeLists.txt afebdee 
  tier1/kplotting/src/CMakeLists.txt 7ce75bd 
  tier1/kwidgetsaddons/autotests/CMakeLists.txt 870e16e 
  tier1/kwidgetsaddons/src/CMakeLists.txt c64302a 
  tier1/kwidgetsaddons/tests/CMakeLists.txt 502218a 
  tier1/kwindowsystem/src/CMakeLists.txt fe0f920 
  tier1/sonnet/autotests/CMakeLists.txt 88574ff 
  tier1/sonnet/src/plugins/aspell/CMakeLists.txt 9bdb4c7 
  tier1/sonnet/src/plugins/enchant/CMakeLists.txt 2319be8 
  tier1/sonnet/src/plugins/hspell/CMakeLists.txt c7cafc5 
  tier1/sonnet/src/plugins/hunspell/CMakeLists.txt a0e2d9b 
  tier1/sonnet/src/ui/CMakeLists.txt 723d8f3 
  tier1/sonnet/src/unicode/CMakeLists.txt 6b5d27d 
  tier1/sonnet/tests/CMakeLists.txt 6e0e450 
  tier1/threadweaver/src/WeaverGui/CMakeLists.txt f92577c 

Diff: http://git.reviewboard.kde.org/r/111945/diff/


Testing
---

It builds and tests looks OK.


Thanks,

Wojciech Kapuscinski

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112037: Replace most instances of KFileDialog with QFileDialog

2013-08-19 Thread Teo Mrnjavac


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112037/
---

(Updated Aug. 19, 2013, 10:43 a.m.)


Review request for KDE Frameworks.


Description
---

KFileDialog is deprecated in favor of QFileDialog. The original intention was 
to completely replace the former with the latter and move KFileDialog to 
kde4support.
kdelibs cleanup task: Move KFileDialog to kde4support once the QUrl static 
methods are in Qt (see the 5.1 epic) 
Unfortunately, it turned out that KEncodingFileDialog inherits from 
KFileDialog, and is still used in a bunch of places, making the complete 
removal of KFileDialog impractical.

With this all uses of KFileDialog are removed, except for KEncodingFileDialog.


Diffs (updated)
-

  kfile/kdirselectdialog.cpp dcbcc4cf743bad17cfa520def611445ceb31eb21 
  kio/kfile/kfiledialog.h 216dcc8b41e3a9027b2a94b307d6c6374ee53c51 
  kio/kfile/kpropertiesdialog.cpp 995e962353a09e40f627f2db60ce831b46b6a414 
  kio/kfile/kurlrequester.h bb111271b6d6b7b1fd66a4b5f13d9f0aa499289f 
  kio/kfile/kurlrequester.cpp 523ae7a3bec64a3d997a255899cb15a8fdc5689e 
  kio/kfile/kurlrequesterdialog.h 2e515b23060748e632cc96eed4a2305f67ebb40e 
  kio/kfile/kurlrequesterdialog.cpp b0afd16388dab56b0a1127dd6e8921476196f234 
  kio/kssl/kcm/cacertificatespage.cpp 8b35c2a73f0f2caa3e385568d32428fdbb00bba4 
  kparts/browserrun.cpp ff3a5fd1220cf0be3c8775cf97f204f3a26300d0 
  kross/ui/view.cpp 51f31c5bc247d385c685cf91a94c48a0ed855532 

Diff: http://git.reviewboard.kde.org/r/112037/diff/


Testing
---

Does not break any tests.


Thanks,

Teo Mrnjavac

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

KF5 Update Meeting 2013-w34 Reminder

2013-08-19 Thread Kevin Ottens

Hello all,

Just a quick reminder:
The next KF5 Update Meeting will happen on #kde-devel tomorrow at 4pm Paris 
time.

See you there!

Regards.
-- 
Kévin Ottens, http://ervin.ipsquad.net

Sponsored by BlueSystems and KDAB to work on KDE Frameworks


signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kdelibs_frameworks_qt5 #1037

2013-08-19 Thread KDE CI System

See 

Changes:

[wojtask9.kde] fix test linking

--
[...truncated 15396 lines...]
 from 
:27,
 from 
:26:
:723:1:
 warning: "WTF_COMPILER_MSVC7" is not defined [-Wundef]
In file included from 
:26:0,
 from 
:26,
 from 
:25,
 from 
:27,
 from 
:28,
 from 
:36,
 from 
:25,
 from 
:24,
 from 
:28,
 from 
:28,
 from 
:27,
 from 
:26:
:110:1:
 warning: "WTF_COMPILER_MSVC" is not defined [-Wundef]
:115:1:
 warning: "WTF_COMPILER_MSVC" is not defined [-Wundef]
:159:1:
 warning: "WTF_COMPILER_MSVC" is not defined [-Wundef]
In file included from 
:26:0,
 from 
:25,
 from 
:27,
 from 
:28,
 from 
:36,
 from 
:25,
 from 
:24,
 from 
:28,
 from 
:28,
 from 
:27,
 from 
:26:
:49:1:
 warning: "WTF_COMPILER_MSVC" is not defined [-Wundef]
:66:1:
 warning: "WTF_COMPILER_MSVC" is not defined [-Wundef]
In file included from 
:25:0,
 from 
:24,
 from 
:28,
 from 
:28,
 from 
:27,
 from 
:26:
:43:1:
 warning: "WTF_PLATFORM_FORCE_PACK" is not defined [-Wundef]
In file included from 
:3

Build failed in Jenkins: kdelibs_frameworks_qt5 #1036

2013-08-19 Thread KDE CI System

See 

Changes:

[wojtask9.kde] Port kconfig_compiler from QApplication to QGuiApplication

[wojtask9.kde] Use LINK_PRIVATE LINK_PUBLIC in CMake (part 1)

[wojtask9.kde] Use LINK_PRIVATE LINK_PUBLIC in CMake (part 2)

[wojtask9.kde] Reduce ItemViews test dependency

[wojtask9.kde] Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 3)

--
[...truncated 9606 lines...]
 from 
:28,
 from 
:36,
 from 
:32,
 from 
:52,
 from 
:47:
:110:1:
 warning: "WTF_COMPILER_MSVC" is not defined [-Wundef]
:115:1:
 warning: "WTF_COMPILER_MSVC" is not defined [-Wundef]
:159:1:
 warning: "WTF_COMPILER_MSVC" is not defined [-Wundef]
In file included from 
:26:0,
 from 
:25,
 from 
:27,
 from 
:28,
 from 
:36,
 from 
:32,
 from 
:52,
 from 
:47:
:49:1:
 warning: "WTF_COMPILER_MSVC" is not defined [-Wundef]
:66:1:
 warning: "WTF_COMPILER_MSVC" is not defined [-Wundef]
In file included from 
:32:0,
 from 
:52,
 from 
:47:
:43:1:
 warning: "WTF_PLATFORM_FORCE_PACK" is not defined [-Wundef]
In file included from 
:30:0,
 from 
:27,
 from 
:29,
 from 
:27,
 from 
:30,
 from 
:53,
 from 
:47:
:31:1:
 warning: "WTF_PLATFORM_WIN" is not defined [-Wundef]
:60:1:
 warning: "WTF_COMPILER_MSVC" is not defined [-Wundef]
In file included from 
:27:0,
 from 
:29,
 from 
:27,
 from 
:30,
 from 
:53,
 from 
:47:

Build failed in Jenkins: kdelibs_frameworks_qt5 #1038

2013-08-19 Thread KDE CI System

See 

Changes:

[aleixpol] Remove KDEUI_DEPRECATED uses

--
[...truncated 15284 lines...]
:56:1:
 warning: "WTF_USE_MULTIPLE_THREADS" is not defined [-Wundef]
In file included from 
:33:0,
 from 
:25,
 from 
:24,
 from 
:28,
 from 
:28,
 from 
:27,
 from 
:30,
 from 
:30,
 from 
:27,
 from 
:22:
:723:1:
 warning: "WTF_COMPILER_MSVC7" is not defined [-Wundef]
In file included from 
:26:0,
 from 
:26,
 from 
:25,
 from 
:27,
 from 
:28,
 from 
:36,
 from 
:25,
 from 
:24,
 from 
:28,
 from 
:28,
 from 
:27,
 from 
:30,
 from 
:30,
 from 
:27,
 from 
:22:
:110:1:
 warning: "WTF_COMPILER_MSVC" is not defined [-Wundef]
:115:1:
 warning: "WTF_COMPILER_MSVC" is not defined [-Wundef]
:159:1:
 warning: "WTF_COMPILER_MSVC" is not defined [-Wundef]
In file included from 
:26:0,
 from 
:25,
 from 
:27,
 from 
:28,
 from 
:36,
 from 
:25,
 from 
:24,
 from 
:28,
 from 
:28,
 from

Build failed in Jenkins: kdelibs_frameworks_qt5 #1039

2013-08-19 Thread KDE CI System

See 

Changes:

[afiestas] Remove unused include that fixes build

[afiestas] kconfigskeleton is in KConfigGui, so adding it to the target

--
[...truncated 15585 lines...]
:208:1:
 warning: "WTF_PLATFORM_WIN" is not defined [-Wundef]
:212:1:
 warning: "WTF_PLATFORM_GDK" is not defined [-Wundef]
In file included from 
:29:0,
 from 
:25,
 from 
:24,
 from 
:28,
 from 
:28,
 from 
:27,
 from 
:26:
:27:1:
 warning: "WTF_COMPILER_MSVC" is not defined [-Wundef]
In file included from 
:30:0,
 from 
:25,
 from 
:24,
 from 
:28,
 from 
:28,
 from 
:27,
 from 
:26:
:27:1:
 warning: "WTF_USE_MULTIPLE_THREADS" is not defined [-Wundef]
:56:1:
 warning: "WTF_USE_MULTIPLE_THREADS" is not defined [-Wundef]
In file included from 
:33:0,
 from 
:25,
 from 
:24,
 from 
:28,
 from 
:28,
 from 
:27,
 from 
:26:
:723:1:
 warning: "WTF_COMPILER_MSVC7" is not defined [-Wundef]
In file included from 
:26:0,
 from 
:26,
 from 
:25,
 from 
:27,
 from 
:28,
 from 
:36,
 from 
:25,
 from 
:24,
 from 
:28,
 from 
:28,
 from 
:27,
 from

Re: Review Request 111916: Port khtml_part away from kde_file.h

2013-08-19 Thread Commit Hook


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111916/#review38139
---


This review has been submitted with commit 
499b52c5d6f169d9d78f6aff63d820f2ca0a1e7e by Vishesh Handa to branch frameworks.

- Commit Hook


On Aug. 19, 2013, 9:32 a.m., Vishesh Handa wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111916/
> ---
> 
> (Updated Aug. 19, 2013, 9:32 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
>  Port khtml_part away from kde_file.h
> 
> 
> Diffs
> -
> 
>   khtml/khtml_part.cpp d944a29 
> 
> Diff: http://git.reviewboard.kde.org/r/111916/diff/
> 
> 
> Testing
> ---
> 
> Compiles. The tests seem to segfault with and without this patch. I'll try to 
> diagnose it.
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111916: Port khtml_part away from kde_file.h

2013-08-19 Thread Commit Hook


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111916/
---

(Updated Aug. 19, 2013, 2:05 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Description
---

 Port khtml_part away from kde_file.h


Diffs
-

  khtml/khtml_part.cpp d944a29 

Diff: http://git.reviewboard.kde.org/r/111916/diff/


Testing
---

Compiles. The tests seem to segfault with and without this patch. I'll try to 
diagnose it.


Thanks,

Vishesh Handa

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kdelibs_frameworks_qt5 #1040

2013-08-19 Thread KDE CI System

See 

Changes:

[me] Port khtml_part away from kde_file.h

--
[...truncated 15585 lines...]
[ 68%] Building CXX object 
staging/kiconthemes/tests/CMakeFiles/kiconeffecttest.dir/kiconeffecttest.cpp.o
:675:5:
 warning: "HAVE_X11" is not defined [-Wundef]
[ 68%] Building CXX object 
staging/kio/src/core/CMakeFiles/KIOCore.dir/kdirnotify.cpp.o
[ 68%] Building CXX object 
staging/kiconthemes/tests/CMakeFiles/kiconeffecttest.dir/kiconeffecttest_automoc.cpp.o
Scanning dependencies of target kpixmapsequenceoverlaypaintertest
[ 68%] Building CXX object 
staging/kiconthemes/tests/CMakeFiles/kpixmapsequenceoverlaypaintertest.dir/kpixmapsequenceoverlaypaintertest.cpp.o
Scanning dependencies of target KCompletion
[ 68%] Building CXX object 
staging/kcompletion/src/CMakeFiles/KCompletion.dir/kcombobox.cpp.o
Linking CXX executable kiconeffecttest
[ 68%] Building CXX object 
staging/kio/src/core/CMakeFiles/KIOCore.dir/kauthorized.cpp.o
:
 In member function ‘virtual void KComboBox::setContextMenuEnabled(bool)’:
:127:55:
 warning: ‘virtual void KLineEdit::setContextMenuEnabled(bool)’ is deprecated 
(declared at 
:230)
 [-Wdeprecated-declarations]
[ 68%] Built target kiconeffecttest
[ 68%] Building CXX object 
staging/kcompletion/src/CMakeFiles/KCompletion.dir/kcompletion.cpp.o
[ 68%] Building CXX object 
staging/kio/src/core/CMakeFiles/KIOCore.dir/kacl.cpp.o
[ 68%] Building CXX object 
staging/kio/src/core/CMakeFiles/KIOCore.dir/udsentry.cpp.o
Scanning dependencies of target kjsapitest
[ 68%] [ 68%] Building CXX object 
tier1/kjs/autotests/CMakeFiles/kjsapitest.dir/kjsapitest.cpp.o
Building CXX object staging/kio/src/core/CMakeFiles/KIOCore.dir/global.cpp.o
[ 68%] Building CXX object 
staging/kcompletion/src/CMakeFiles/KCompletion.dir/kcompletionbase.cpp.o
[ 68%] Building CXX object 
staging/kiconthemes/tests/CMakeFiles/kpixmapsequenceoverlaypaintertest.dir/kpixmapsequenceoverlaypaintertest_automoc.cpp.o
[ 68%] Building CXX object 
tier1/kjs/autotests/CMakeFiles/kjsapitest.dir/kjsapitest_automoc.cpp.o
Linking CXX executable kjsapitest
[ 68%] [ 68%] Building CXX object 
staging/kio/src/core/CMakeFiles/KIOCore.dir/metadata.cpp.o
Building CXX object 
staging/kcompletion/src/CMakeFiles/KCompletion.dir/kcompletionbox.cpp.o
Scanning dependencies of target kiconloader_unittest
[ 68%] [ 68%] Building CXX object 
staging/kiconthemes/autotests/CMakeFiles/kiconloader_unittest.dir/kiconloader_unittest.cpp.o
Built target kjsapitest
[ 68%] Building CXX object 
staging/kiconthemes/autotests/CMakeFiles/kiconloader_unittest.dir/kiconloader_unittest_automoc.cpp.o
[ 68%] [ 68%] Building CXX object 
staging/kcompletion/src/CMakeFiles/KCompletion.dir/klineedit.cpp.o
Building CXX object 
staging/kio/src/core/CMakeFiles/KIOCore.dir/kprotocolinfo.cpp.o
Linking CXX executable kpixmapsequenceoverlaypaintertest
:
 In member function ‘void KIconLoader_UnitTest::initTestCase()’:
:45:34:
 warning: ‘void KIconLoader::newIconLoader()’ is deprecated (declared at 
:447)
 [-Wdeprecated-declarations]
Linking CXX executable kiconloader_unittest
Scanning dependencies of target KDEPlatformTheme
[ 68%] Building CXX object 
staging/frameworkintegration/src/platformtheme/CMakeFiles/KDEPlatformTheme.dir/kdeplatformtheme.cpp.o
In file included from 
:29:0:
:181:3:
 warning: unused parameter ‘style’ [-Wunused-parameter]
In file included from 
:1779:0:
:
 In member function ‘virtual int KLineEdit::qt_metacall(QMetaObject::Call, int, 
void**)’:
:325:70:
 warning: ‘bool KLineEdit::isContextMenuEnabled() const’ is deprecated 
(declared at 
:1737)
 [-Wdeprecated-declarations]

Re: Review Request 112052: Split kwindoweffects into an x11 and dummy implementation

2013-08-19 Thread Commit Hook


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112052/#review38143
---


This review has been submitted with commit 
723d6d37b3286678cfd8b4284da7e7181d249163 by Martin Gräßlin to branch frameworks.

- Commit Hook


On Aug. 13, 2013, 11:53 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112052/
> ---
> 
> (Updated Aug. 13, 2013, 11:53 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Proper implementation is moved into kwindoweffects_x11.cpp and a
> kwindoweffects_dummy.cpp is provided for Mac and Windows systems.
> 
> As every method is X11 specific this makes the code cleaner.
> 
> 
> Diffs
> -
> 
>   tier1/kwindowsystem/src/CMakeLists.txt fe0f920 
>   tier1/kwindowsystem/src/kwindoweffects.cpp 33a4531 
>   tier1/kwindowsystem/src/kwindoweffects_dummy.cpp PRE-CREATION 
>   tier1/kwindowsystem/src/kwindoweffects_x11.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112052/diff/
> 
> 
> Testing
> ---
> 
> Compile tested only X11 - cannot test Windows or Mac
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112052: Split kwindoweffects into an x11 and dummy implementation

2013-08-19 Thread Commit Hook


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112052/
---

(Updated Aug. 19, 2013, 2:43 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Description
---

Proper implementation is moved into kwindoweffects_x11.cpp and a
kwindoweffects_dummy.cpp is provided for Mac and Windows systems.

As every method is X11 specific this makes the code cleaner.


Diffs
-

  tier1/kwindowsystem/src/CMakeLists.txt fe0f920 
  tier1/kwindowsystem/src/kwindoweffects.cpp 33a4531 
  tier1/kwindowsystem/src/kwindoweffects_dummy.cpp PRE-CREATION 
  tier1/kwindowsystem/src/kwindoweffects_x11.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/112052/diff/


Testing
---

Compile tested only X11 - cannot test Windows or Mac


Thanks,

Martin Gräßlin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112096: Port KWindowEffects to XCB

2013-08-19 Thread Martin Gräßlin


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112096/
---

(Updated Aug. 19, 2013, 5:11 p.m.)


Review request for KDE Frameworks and Marco Martin.


Changes
---

included suggested change.


Description
---

Basically a rewrite of the X11 implementation of KWindowEffects to XCB. To 
ensure that it doesn't break I added unit tests for everything except 
isEffectAvailable (that can hardly be tested as it requires a running KWin).

Please note: this patch is on top of review #112052


Diffs (updated)
-

  tier1/kwindowsystem/autotests/CMakeLists.txt 5e05c6d 
  tier1/kwindowsystem/autotests/kwindoweffectstest.cpp PRE-CREATION 
  tier1/kwindowsystem/src/kwindoweffects.h bf77e7c 
  tier1/kwindowsystem/src/kwindoweffects_x11.cpp d05ffaf 

Diff: http://git.reviewboard.kde.org/r/112096/diff/


Testing
---

See new unit tests and test application in 
kde:scratch/graesslin/kwindoweffectsplugin.git


Thanks,

Martin Gräßlin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: plasma-framework_master_qt5 #600

2013-08-19 Thread KDE CI System

See 

Changes:

[notmart] remove old test panel

--
Started by remote host 127.0.0.1 with note: Triggered by commit
Building remotely on LinuxSlave - 3 in workspace 

Running Prebuild steps
[plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson7426963198483073184.sh
+ /home/jenkins/scripts/setup-env.sh
>From git://anongit.kde.org/plasma-framework
   9aba51f..5e37605  master -> origin/master
Branch jenkins set up to track remote branch master from origin.
Success build forhudson.tasks.Shell@6964e4a3
Checkout:plasma-framework_master_qt5 / 
 - 
hudson.remoting.Channel@63446816:LinuxSlave - 3
Using strategy: Default
Last Built Revision: Revision 9aba51f7a34875863c5b2742ea3758d3183d0edd 
(refs/heads/jenkins)
Fetching changes from 1 remote Git repository
Fetching upstream changes from origin
Commencing build of Revision 5e376058c8115c8f7f4ace8b2833bf63d6aa714d 
(refs/heads/jenkins)
Checking out Revision 5e376058c8115c8f7f4ace8b2833bf63d6aa714d 
(refs/heads/jenkins)
[plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson3708810576847197298.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: plasma-framework - Branch master
== Build Dependencies:
 libstreamanalyzer - Branch master
 libstreams - Branch master
 strigidaemon - Branch master
 attica - Branch master
 strigiclient - Branch master
 extra-cmake-modules - Branch master
 kdelibs - Branch frameworks
 strigiutils - Branch master
 qt5 - Branch dev

== Cleaning Source Tree

HEAD is now at 5e37605 remove old test panel
Removing build/
Removing install/

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server


== Configuring Build

-- The C compiler identification is GNU 4.6.0
-- The CXX compiler identification is GNU 4.6.0
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /home/jenkins/bin/c++
-- Check for working CXX compiler: /home/jenkins/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- KF5[InstallDirs]: Loaded settings from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDEInstallDirs.cmake
-- KF5[CMake]: Loaded settings from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECMakeSettings.cmake
-- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL
-- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL - Success
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success
-- KF5[Compiler]: Loaded settings from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECompilerSettings.cmake
-- KF5[KIdleTime]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KIdleTime/KIdleTimeConfig.cmake
-- KF5[ItemModels]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/ItemModels/ItemModelsConfig.cmake
-- KF5[KWidgetsAddons]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KWidgetsAddons/KWidgetsAddonsConfig.cmake
-- KF5[KWindowSystem]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KWindowSystem/KWindowSystemConfig.cmake
-- KF5[KCodecs]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KCodecs/KCodecsConfig.cmake
-- KF5[KArchive]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KArchive/KArchiveConfig.cmake
-- KF5[KCoreAddons]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KCoreAddons/KCoreAddonsConfig.cmake
-- KF5[Solid]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/Solid/SolidConfig.cmake
-- KF5[ThreadWeaver]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/ThreadWeaver/ThreadWeaverConfig.cmake
-- KF5[KConfig]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KConfig/KConfigConfig.cmake
-- KF5[KAuth]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KAuth/KAuthConfig.cmake
-- KF5[KJS]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KJS/KJSConfig.cmake
-- K

Build failed in Jenkins: plasma-framework_master_qt5 #601

2013-08-19 Thread KDE CI System

See 

Changes:

[notmart] export fillWidth/fillHeight properties

--
Started by remote host 127.0.0.1 with note: Triggered by commit
Building remotely on LinuxSlave - 3 in workspace 

Running Prebuild steps
[plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson4042988980961572678.sh
+ /home/jenkins/scripts/setup-env.sh
>From git://anongit.kde.org/plasma-framework
   5e37605..ea69577  master -> origin/master
Branch jenkins set up to track remote branch master from origin.
Success build forhudson.tasks.Shell@6964e4a3
Checkout:plasma-framework_master_qt5 / 
 - 
hudson.remoting.Channel@63446816:LinuxSlave - 3
Using strategy: Default
Last Built Revision: Revision 5e376058c8115c8f7f4ace8b2833bf63d6aa714d 
(refs/heads/jenkins)
Fetching changes from 1 remote Git repository
Fetching upstream changes from origin
Commencing build of Revision ea6957700591cc3f0c97ebec3179801594c39665 
(refs/heads/jenkins)
Checking out Revision ea6957700591cc3f0c97ebec3179801594c39665 
(refs/heads/jenkins)
[plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson1075652535169680963.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: plasma-framework - Branch master
== Build Dependencies:
 libstreamanalyzer - Branch master
 libstreams - Branch master
 strigidaemon - Branch master
 attica - Branch master
 strigiclient - Branch master
 extra-cmake-modules - Branch master
 kdelibs - Branch frameworks
 strigiutils - Branch master
 qt5 - Branch dev

== Cleaning Source Tree

HEAD is now at ea69577 export fillWidth/fillHeight properties
Removing build/

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server


== Configuring Build

-- The C compiler identification is GNU 4.6.0
-- The CXX compiler identification is GNU 4.6.0
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /home/jenkins/bin/c++
-- Check for working CXX compiler: /home/jenkins/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- KF5[InstallDirs]: Loaded settings from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDEInstallDirs.cmake
-- KF5[CMake]: Loaded settings from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECMakeSettings.cmake
-- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL
-- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL - Success
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success
-- KF5[Compiler]: Loaded settings from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECompilerSettings.cmake
-- KF5[KIdleTime]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KIdleTime/KIdleTimeConfig.cmake
-- KF5[ItemModels]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/ItemModels/ItemModelsConfig.cmake
-- KF5[KWidgetsAddons]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KWidgetsAddons/KWidgetsAddonsConfig.cmake
-- KF5[KWindowSystem]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KWindowSystem/KWindowSystemConfig.cmake
-- KF5[KCodecs]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KCodecs/KCodecsConfig.cmake
-- KF5[KArchive]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KArchive/KArchiveConfig.cmake
-- KF5[KCoreAddons]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KCoreAddons/KCoreAddonsConfig.cmake
-- KF5[Solid]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/Solid/SolidConfig.cmake
-- KF5[ThreadWeaver]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/ThreadWeaver/ThreadWeaverConfig.cmake
-- KF5[KConfig]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KConfig/KConfigConfig.cmake
-- KF5[KAuth]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KAuth/KAuthConfig.cmake
-- KF5[KJS]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KJS/KJSC

Build failed in Jenkins: plasma-framework_master_qt5 #602

2013-08-19 Thread KDE CI System

See 

Changes:

[notmart] correctly pass fillWidth and hints to outer layers

--
Started by remote host 127.0.0.1 with note: Triggered by commit
Building remotely on LinuxSlave - 2 in workspace 

Running Prebuild steps
[plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson7978156892775094031.sh
+ /home/jenkins/scripts/setup-env.sh
>From git://anongit.kde.org/plasma-framework
 * [new branch]  davidedmundson/controls -> origin/davidedmundson/controls
   5e4e667..571a5d8  ivan/shell-switching -> origin/ivan/shell-switching
   3880ffb..d68e452  master -> origin/master
Branch jenkins set up to track remote branch master from origin.
Success build forhudson.tasks.Shell@6964e4a3
Checkout:plasma-framework_master_qt5 / 
 - 
hudson.remoting.Channel@46844c3d:LinuxSlave - 2
Using strategy: Default
Last Built Revision: Revision ea6957700591cc3f0c97ebec3179801594c39665 
(refs/heads/jenkins)
Fetching changes from 1 remote Git repository
Fetching upstream changes from origin
Commencing build of Revision d68e45254569004d450fa4f0ef3352523877415e 
(refs/heads/jenkins)
Checking out Revision d68e45254569004d450fa4f0ef3352523877415e 
(refs/heads/jenkins)
[plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson2831790848151300371.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: plasma-framework - Branch master
== Build Dependencies:
 libstreamanalyzer - Branch master
 libstreams - Branch master
 strigidaemon - Branch master
 attica - Branch master
 strigiclient - Branch master
 extra-cmake-modules - Branch master
 kdelibs - Branch frameworks
 strigiutils - Branch master
 qt5 - Branch dev

== Cleaning Source Tree

HEAD is now at d68e452 correctly pass fillWidth and hints to outer layers
Removing build/
Removing install/

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server


== Configuring Build

-- The C compiler identification is GNU 4.6.0
-- The CXX compiler identification is GNU 4.6.0
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /home/jenkins/bin/c++
-- Check for working CXX compiler: /home/jenkins/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- KF5[InstallDirs]: Loaded settings from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDEInstallDirs.cmake
-- KF5[CMake]: Loaded settings from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECMakeSettings.cmake
-- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL
-- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL - Success
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success
-- KF5[Compiler]: Loaded settings from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECompilerSettings.cmake
-- KF5[KIdleTime]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KIdleTime/KIdleTimeConfig.cmake
-- KF5[ItemModels]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/ItemModels/ItemModelsConfig.cmake
-- KF5[KWidgetsAddons]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KWidgetsAddons/KWidgetsAddonsConfig.cmake
-- KF5[KWindowSystem]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KWindowSystem/KWindowSystemConfig.cmake
-- KF5[KCodecs]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KCodecs/KCodecsConfig.cmake
-- KF5[KArchive]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KArchive/KArchiveConfig.cmake
-- KF5[KCoreAddons]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KCoreAddons/KCoreAddonsConfig.cmake
-- KF5[Solid]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/Solid/SolidConfig.cmake
-- KF5[ThreadWeaver]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/ThreadWeaver/ThreadWeaverConfig.cmake
-- KF5[KConfig]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KConfig/KConfigConfig.cmake
-- KF5[KAuth]: Loaded 
/srv/jenkins/

Build failed in Jenkins: kdelibs_frameworks_qt5 #1043

2013-08-19 Thread KDE CI System

See 

--
Started by remote host 127.0.0.1 with note: Triggered by commit
Building remotely on LinuxSlave - 1 in workspace 

Running Prebuild steps
[kdelibs_frameworks_qt5] $ /bin/sh -xe /tmp/hudson8828082200909058012.sh
+ /home/jenkins/scripts/setup-env.sh
Traceback (most recent call last):
  File "tools/prepare-environment.py", line 22, in 
load_projects( 'kde_projects.xml', 
'http://projects.kde.org/kde_projects.xml', 'config/projects' )
  File "/home/jenkins/scripts/tools/kdecilib.py", line 974, in load_projects
ProjectManager.load_projects( etree.parse(fileHandle) )
  File "lxml.etree.pyx", line 2942, in lxml.etree.parse 
(src/lxml/lxml.etree.c:54187)
  File "parser.pxi", line 1550, in lxml.etree._parseDocument 
(src/lxml/lxml.etree.c:79703)
  File "parser.pxi", line 1580, in lxml.etree._parseFilelikeDocument 
(src/lxml/lxml.etree.c:80012)
  File "parser.pxi", line 1463, in lxml.etree._parseDocFromFilelike 
(src/lxml/lxml.etree.c:78908)
  File "parser.pxi", line 1019, in lxml.etree._BaseParser._parseDocFromFilelike 
(src/lxml/lxml.etree.c:75905)
  File "parser.pxi", line 564, in 
lxml.etree._ParserContext._handleParseResultDoc (src/lxml/lxml.etree.c:71739)
  File "parser.pxi", line 645, in lxml.etree._handleParseResult 
(src/lxml/lxml.etree.c:72614)
  File "parser.pxi", line 585, in lxml.etree._raiseParseError 
(src/lxml/lxml.etree.c:71955)
lxml.etree.XMLSyntaxError: Char 0x0 out of allowed range, line 9735, column 88
Failed build for hudson.tasks.Shell@32f7ddeb
Checkout:kdelibs_frameworks_qt5 / 
 - 
hudson.remoting.Channel@75e77b7d:LinuxSlave - 1
Using strategy: Default
Last Built Revision: Revision 723d6d37b3286678cfd8b4284da7e7181d249163 
(refs/heads/jenkins)
Fetching changes from 1 remote Git repository
Fetching upstream changes from origin
Commencing build of Revision 6a6b77b28ef0e60519cd7aa83fa5e3d7b1fe41da 
(refs/heads/jenkins)
Checking out Revision 6a6b77b28ef0e60519cd7aa83fa5e3d7b1fe41da 
(refs/heads/jenkins)
[kdelibs_frameworks_qt5] $ /bin/sh -xe /tmp/hudson6661639768771916206.sh
+ /home/jenkins/scripts/execute-job.sh
Traceback (most recent call last):
  File "tools/perform-build.py", line 21, in 
load_projects( 'kde_projects.xml', 
'http://projects.kde.org/kde_projects.xml', 'config/projects' )
  File "/home/jenkins/scripts/tools/kdecilib.py", line 974, in load_projects
ProjectManager.load_projects( etree.parse(fileHandle) )
  File "lxml.etree.pyx", line 2942, in lxml.etree.parse 
(src/lxml/lxml.etree.c:54187)
  File "parser.pxi", line 1550, in lxml.etree._parseDocument 
(src/lxml/lxml.etree.c:79703)
  File "parser.pxi", line 1580, in lxml.etree._parseFilelikeDocument 
(src/lxml/lxml.etree.c:80012)
  File "parser.pxi", line 1463, in lxml.etree._parseDocFromFilelike 
(src/lxml/lxml.etree.c:78908)
  File "parser.pxi", line 1019, in lxml.etree._BaseParser._parseDocFromFilelike 
(src/lxml/lxml.etree.c:75905)
  File "parser.pxi", line 564, in 
lxml.etree._ParserContext._handleParseResultDoc (src/lxml/lxml.etree.c:71739)
  File "parser.pxi", line 645, in lxml.etree._handleParseResult 
(src/lxml/lxml.etree.c:72614)
  File "parser.pxi", line 585, in lxml.etree._raiseParseError 
(src/lxml/lxml.etree.c:71955)
lxml.etree.XMLSyntaxError: Char 0x0 out of allowed range, line 9735, column 88
Build step 'Execute shell' marked build as failure
[WARNINGS] Skipping publisher since build result is FAILURE
Skipping Cobertura coverage report as build was not UNSTABLE or better ...
Recording test results
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kdelibs_frameworks_qt5 #1044

2013-08-19 Thread KDE CI System

See 

--
Started by remote host 127.0.0.1 with note: Triggered by commit
Building remotely on LinuxSlave - 1 in workspace 

Running Prebuild steps
[kdelibs_frameworks_qt5] $ /bin/sh -xe /tmp/hudson3575962422845890852.sh
+ /home/jenkins/scripts/setup-env.sh
Traceback (most recent call last):
  File "tools/prepare-environment.py", line 22, in 
load_projects( 'kde_projects.xml', 
'http://projects.kde.org/kde_projects.xml', 'config/projects' )
  File "/home/jenkins/scripts/tools/kdecilib.py", line 974, in load_projects
ProjectManager.load_projects( etree.parse(fileHandle) )
  File "lxml.etree.pyx", line 2942, in lxml.etree.parse 
(src/lxml/lxml.etree.c:54187)
  File "parser.pxi", line 1550, in lxml.etree._parseDocument 
(src/lxml/lxml.etree.c:79703)
  File "parser.pxi", line 1580, in lxml.etree._parseFilelikeDocument 
(src/lxml/lxml.etree.c:80012)
  File "parser.pxi", line 1463, in lxml.etree._parseDocFromFilelike 
(src/lxml/lxml.etree.c:78908)
  File "parser.pxi", line 1019, in lxml.etree._BaseParser._parseDocFromFilelike 
(src/lxml/lxml.etree.c:75905)
  File "parser.pxi", line 564, in 
lxml.etree._ParserContext._handleParseResultDoc (src/lxml/lxml.etree.c:71739)
  File "parser.pxi", line 645, in lxml.etree._handleParseResult 
(src/lxml/lxml.etree.c:72614)
  File "parser.pxi", line 585, in lxml.etree._raiseParseError 
(src/lxml/lxml.etree.c:71955)
lxml.etree.XMLSyntaxError: Char 0x0 out of allowed range, line 9735, column 88
Failed build for hudson.tasks.Shell@32f7ddeb
Checkout:kdelibs_frameworks_qt5 / 
 - 
hudson.remoting.Channel@75e77b7d:LinuxSlave - 1
Using strategy: Default
Last Built Revision: Revision 6a6b77b28ef0e60519cd7aa83fa5e3d7b1fe41da 
(refs/heads/jenkins)
Fetching changes from 1 remote Git repository
Fetching upstream changes from origin
Commencing build of Revision 6a6b77b28ef0e60519cd7aa83fa5e3d7b1fe41da 
(refs/heads/jenkins)
Checking out Revision 6a6b77b28ef0e60519cd7aa83fa5e3d7b1fe41da 
(refs/heads/jenkins)
[kdelibs_frameworks_qt5] $ /bin/sh -xe /tmp/hudson3677617061213481662.sh
+ /home/jenkins/scripts/execute-job.sh
Traceback (most recent call last):
  File "tools/perform-build.py", line 21, in 
load_projects( 'kde_projects.xml', 
'http://projects.kde.org/kde_projects.xml', 'config/projects' )
  File "/home/jenkins/scripts/tools/kdecilib.py", line 974, in load_projects
ProjectManager.load_projects( etree.parse(fileHandle) )
  File "lxml.etree.pyx", line 2942, in lxml.etree.parse 
(src/lxml/lxml.etree.c:54187)
  File "parser.pxi", line 1550, in lxml.etree._parseDocument 
(src/lxml/lxml.etree.c:79703)
  File "parser.pxi", line 1580, in lxml.etree._parseFilelikeDocument 
(src/lxml/lxml.etree.c:80012)
  File "parser.pxi", line 1463, in lxml.etree._parseDocFromFilelike 
(src/lxml/lxml.etree.c:78908)
  File "parser.pxi", line 1019, in lxml.etree._BaseParser._parseDocFromFilelike 
(src/lxml/lxml.etree.c:75905)
  File "parser.pxi", line 564, in 
lxml.etree._ParserContext._handleParseResultDoc (src/lxml/lxml.etree.c:71739)
  File "parser.pxi", line 645, in lxml.etree._handleParseResult 
(src/lxml/lxml.etree.c:72614)
  File "parser.pxi", line 585, in lxml.etree._raiseParseError 
(src/lxml/lxml.etree.c:71955)
lxml.etree.XMLSyntaxError: Char 0x0 out of allowed range, line 9735, column 88
Build step 'Execute shell' marked build as failure
[WARNINGS] Skipping publisher since build result is FAILURE
Skipping Cobertura coverage report as build was not UNSTABLE or better ...
Recording test results
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Can not find XCB modules.

2013-08-19 Thread Bhushan Shah

Hello,

I am using project-neon5 on KUbuntu 13.04. I have every packages
installed on my computer which is required to build. I can not build
kwin, kstyles and powermanagement data engine so I have to disable it
for building kde-workspace.

CMake exits saying that XCB Libraries are not installed. [1] Well I
have every xcb* packages installed on my computer. And related library
files are present on my computer [2].

Invoking pkg-config with --debug prints that xcb packages are
installed. [3]. And here is my env output. I still can not figure out
what is wrong? My system? Project Neon 5? Extra cmake modules? Or
myself? :-|

Thanks!

[1] http://paste.kde.org/pd1e6e267/
[2] http://paste.kde.org/p5d03022c/
[3] http://paste.kde.org/p6dad5f16/
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111636: Port away from kde_file.h in AuthInfo (KIO)

2013-08-19 Thread David Gil Oliva


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111636/
---

(Updated Aug. 19, 2013, 9:41 p.m.)


Review request for KDE Frameworks.


Changes
---

Fix issues.


Description
---

Port away from kde_file.h in AuthInfo (KIO)


Diffs (updated)
-

  staging/kio/src/core/authinfo.h d6415b2f2e9ccec7c3e046f569fb44dbbc879d6b 
  staging/kio/src/core/authinfo.cpp 65ebacf84e989f19f1b896c596a6b24185c67447 

Diff: http://git.reviewboard.kde.org/r/111636/diff/


Testing
---

It builds. I have tested the part of the code not related to loginMap with a 
little program and .netrc sample files, to check whether it correctly parses 
the information.


Thanks,

David Gil Oliva

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: plasma-framework_master_qt5 #603

2013-08-19 Thread KDE CI System

See 

Changes:

[scripty] SVN_SILENT made messages (.desktop file)

--
Started by remote host 127.0.0.1 with note: Triggered by commit
Building remotely on LinuxSlave - 2 in workspace 

Running Prebuild steps
[plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson2735606058254888613.sh
+ /home/jenkins/scripts/setup-env.sh
>From git://anongit.kde.org/plasma-framework
   d68e452..c3742a0  master -> origin/master
Branch jenkins set up to track remote branch master from origin.
Success build forhudson.tasks.Shell@6964e4a3
Checkout:plasma-framework_master_qt5 / 
 - 
hudson.remoting.Channel@46844c3d:LinuxSlave - 2
Using strategy: Default
Last Built Revision: Revision d68e45254569004d450fa4f0ef3352523877415e 
(refs/heads/jenkins)
Fetching changes from 1 remote Git repository
Fetching upstream changes from origin
Commencing build of Revision c3742a068c8768d99571b48566d8a85a5c3220c6 
(refs/heads/jenkins)
Checking out Revision c3742a068c8768d99571b48566d8a85a5c3220c6 
(refs/heads/jenkins)
[plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson1090578274636107673.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: plasma-framework - Branch master
== Build Dependencies:
 libstreamanalyzer - Branch master
 libstreams - Branch master
 strigidaemon - Branch master
 attica - Branch master
 strigiclient - Branch master
 extra-cmake-modules - Branch master
 kdelibs - Branch frameworks
 strigiutils - Branch master
 qt5 - Branch dev

== Cleaning Source Tree

HEAD is now at c3742a0 SVN_SILENT made messages (.desktop file)
Removing build/

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server


== Configuring Build

-- The C compiler identification is GNU 4.6.0
-- The CXX compiler identification is GNU 4.6.0
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /home/jenkins/bin/c++
-- Check for working CXX compiler: /home/jenkins/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- KF5[InstallDirs]: Loaded settings from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDEInstallDirs.cmake
-- KF5[CMake]: Loaded settings from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECMakeSettings.cmake
-- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL
-- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL - Success
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success
-- KF5[Compiler]: Loaded settings from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECompilerSettings.cmake
-- KF5[KIdleTime]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KIdleTime/KIdleTimeConfig.cmake
-- KF5[ItemModels]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/ItemModels/ItemModelsConfig.cmake
-- KF5[KWidgetsAddons]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KWidgetsAddons/KWidgetsAddonsConfig.cmake
-- KF5[KWindowSystem]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KWindowSystem/KWindowSystemConfig.cmake
-- KF5[KCodecs]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KCodecs/KCodecsConfig.cmake
-- KF5[KArchive]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KArchive/KArchiveConfig.cmake
-- KF5[KCoreAddons]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KCoreAddons/KCoreAddonsConfig.cmake
-- KF5[Solid]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/Solid/SolidConfig.cmake
-- KF5[ThreadWeaver]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/ThreadWeaver/ThreadWeaverConfig.cmake
-- KF5[KConfig]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KConfig/KConfigConfig.cmake
-- KF5[KAuth]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KAuth/KAuthConfig.cmake
-- KF5[KJS]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KJS/

Build failed in Jenkins: plasma-framework_master_qt5 #604

2013-08-19 Thread KDE CI System

See 

Changes:

[mgraesslin] Fix linking

--
Started by remote host 127.0.0.1 with note: Triggered by commit
Building remotely on LinuxSlave - 2 in workspace 

Running Prebuild steps
[plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson6250709141152000897.sh
+ /home/jenkins/scripts/setup-env.sh
>From git://anongit.kde.org/plasma-framework
   c3742a0..531e6c3  master -> origin/master
Branch jenkins set up to track remote branch master from origin.
Success build forhudson.tasks.Shell@6964e4a3
Checkout:plasma-framework_master_qt5 / 
 - 
hudson.remoting.Channel@46844c3d:LinuxSlave - 2
Using strategy: Default
Last Built Revision: Revision c3742a068c8768d99571b48566d8a85a5c3220c6 
(refs/heads/jenkins)
Fetching changes from 1 remote Git repository
Fetching upstream changes from origin
Commencing build of Revision 531e6c3db58708c62b5db32e6507444f3a1012aa 
(refs/heads/jenkins)
Checking out Revision 531e6c3db58708c62b5db32e6507444f3a1012aa 
(refs/heads/jenkins)
[plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson3539586087226016220.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: plasma-framework - Branch master
== Build Dependencies:
 libstreamanalyzer - Branch master
 libstreams - Branch master
 strigidaemon - Branch master
 attica - Branch master
 strigiclient - Branch master
 extra-cmake-modules - Branch master
 kdelibs - Branch frameworks
 strigiutils - Branch master
 qt5 - Branch dev

== Cleaning Source Tree

HEAD is now at 531e6c3 Fix linking
Removing build/

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server


== Configuring Build

-- The C compiler identification is GNU 4.6.0
-- The CXX compiler identification is GNU 4.6.0
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /home/jenkins/bin/c++
-- Check for working CXX compiler: /home/jenkins/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- KF5[InstallDirs]: Loaded settings from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDEInstallDirs.cmake
-- KF5[CMake]: Loaded settings from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECMakeSettings.cmake
-- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL
-- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL - Success
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success
-- KF5[Compiler]: Loaded settings from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECompilerSettings.cmake
-- KF5[KIdleTime]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KIdleTime/KIdleTimeConfig.cmake
-- KF5[ItemModels]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/ItemModels/ItemModelsConfig.cmake
-- KF5[KWidgetsAddons]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KWidgetsAddons/KWidgetsAddonsConfig.cmake
-- KF5[KWindowSystem]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KWindowSystem/KWindowSystemConfig.cmake
-- KF5[KCodecs]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KCodecs/KCodecsConfig.cmake
-- KF5[KArchive]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KArchive/KArchiveConfig.cmake
-- KF5[KCoreAddons]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KCoreAddons/KCoreAddonsConfig.cmake
-- KF5[Solid]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/Solid/SolidConfig.cmake
-- KF5[ThreadWeaver]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/ThreadWeaver/ThreadWeaverConfig.cmake
-- KF5[KConfig]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KConfig/KConfigConfig.cmake
-- KF5[KAuth]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KAuth/KAuthConfig.cmake
-- KF5[KJS]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KJS/KJSConfig.cmake
-- KF5[KWallet]: Loaded 
/srv/jenkins/i

Review Request 112170: Drop hack for cyclic depndencies between kde4support and kdelibs

2013-08-19 Thread Martin Gräßlin


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112170/
---

Review request for KDE Frameworks.


Description
---

With KDEUI gone this hack seems to be no longer needed. At least with it 
installed one cannot build the plasma frameworks. With the hack removed it 
builds again.


Diffs
-

  staging/kde4support/KDE4SupportConfig.cmake.in efb3cc3 

Diff: http://git.reviewboard.kde.org/r/112170/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

56 matches

Mail list logo